activeadmin-rails 1.7.0

data/spec/support/templates/policies/active_admin/page_policy.rb

@@ -0,0 +1,18 @@
+module ActiveAdmin
+  class PagePolicy < ApplicationPolicy
+    class Scope < Struct.new(:user, :scope)
+      def resolve
+        scope
+      end
+    end
+
+    def show?
+      case record.name
+      when "Dashboard"
+        true
+      else
+        false
+      end
+    end
+  end
+end

data/spec/support/templates/policies/admin_user_policy.rb

@@ -0,0 +1,11 @@
+class AdminUserPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def destroy?
+    record != user
+  end
+end

data/spec/support/templates/policies/application_policy.rb

@@ -0,0 +1,44 @@
+class ApplicationPolicy
+  attr_reader :user, :record
+
+  def initialize(user, record)
+    @user = user
+    @record = record
+  end
+
+  def index?
+    true
+  end
+
+  def show?
+    scope.where(id: record.id).exists?
+  end
+
+  def new?
+    create?
+  end
+
+  def create?
+    true
+  end
+
+  def edit?
+    update?
+  end
+
+  def update?
+    true
+  end
+
+  def destroy?
+    true
+  end
+
+  def destroy_all?
+    true
+  end
+
+  def scope
+    Pundit.policy_scope!(user, record.class)
+  end
+end

data/spec/support/templates/policies/category_policy.rb

@@ -0,0 +1,7 @@
+class CategoryPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+end

data/spec/support/templates/policies/post_policy.rb

@@ -0,0 +1,15 @@
+class PostPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def update?
+    record.author == user
+  end
+
+  def destroy?
+    update?
+  end
+end

data/spec/support/templates/policies/store_policy.rb

@@ -0,0 +1,11 @@
+class StorePolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def destroy?
+    false
+  end
+end

data/spec/support/templates/policies/user_policy.rb

@@ -0,0 +1,11 @@
+class UserPolicy < ApplicationPolicy
+  class Scope < Struct.new(:user, :scope)
+    def resolve
+      scope
+    end
+  end
+
+  def destroy_all?
+    true
+  end
+end

data/spec/support/templates/post_decorator.rb

@@ -0,0 +1,24 @@
+require 'draper'
+
+class PostDecorator < Draper::Decorator
+  decorates :post
+  delegate_all
+
+  # @param attributes [Hash]
+  def assign_attributes(attributes)
+    object.assign_attributes attributes.except(:virtual_title)
+    self.virtual_title = attributes.fetch(:virtual_title) if attributes.key?(:virtual_title)
+  end
+
+  def virtual_title
+    object.title
+  end
+
+  def virtual_title=(virtual_title)
+    object.title = virtual_title
+  end
+
+  def decorator_method
+    'A method only available on the decorator'
+  end
+end

data/spec/unit/abstract_view_factory_spec.rb

@@ -0,0 +1,78 @@
+require 'rails_helper'
+
+require 'active_admin/abstract_view_factory'
+
+RSpec.describe ActiveAdmin::AbstractViewFactory do
+
+  let(:view_factory){ ActiveAdmin::AbstractViewFactory.new }
+  let(:view){ ActiveAdmin::Component }
+
+  describe "registering a new view key" do
+    before do
+      view_factory.register my_new_view_class: view
+    end
+
+    it "should respond to :my_new_view_class" do
+      expect(view_factory.respond_to? :my_new_view_class).to be true
+    end
+
+    it "should respond to :my_new_view_class=" do
+      expect(view_factory.respond_to? :my_new_view_class=).to be true
+    end
+
+    it "should generate a getter method" do
+      expect(view_factory.my_new_view_class).to eq view
+    end
+
+    it "should be settable view a setter method" do
+      view_factory.my_new_view_class = "Some Obj"
+      expect(view_factory.my_new_view_class).to eq "Some Obj"
+    end
+  end
+
+  describe "array syntax access" do
+    before do
+      view_factory.register my_new_view_class: view
+    end
+
+    it "should be available through array syntax" do
+      expect(view_factory[:my_new_view_class]).to eq view
+    end
+
+    it "should be settable through array syntax" do
+      view_factory[:my_new_view_class] = "My New View Class"
+      expect(view_factory[:my_new_view_class]).to eq "My New View Class"
+    end
+  end
+
+  describe "registering default views" do
+    before do
+      ActiveAdmin::AbstractViewFactory.register my_default_view_class: view
+    end
+    it "should generate a getter method" do
+      expect(view_factory.my_default_view_class).to eq view
+    end
+    it "should be settable view a setter method and not change default" do
+      view_factory.my_default_view_class = "Some Obj"
+      expect(view_factory.my_default_view_class).to eq "Some Obj"
+      expect(view_factory.default_for(:my_default_view_class)).to eq view
+    end
+  end
+
+  describe "subclassing the ViewFactory" do
+    let(:subclass) do
+      ActiveAdmin::AbstractViewFactory.register my_subclassed_view: view
+      Class.new(ActiveAdmin::AbstractViewFactory) do
+        def my_subclassed_view
+          "From Subclass"
+        end
+      end
+    end
+
+    it "should use the subclass implementation" do
+      factory = subclass.new
+      expect(factory.my_subclassed_view).to eq "From Subclass"
+    end
+  end
+
+end

data/spec/unit/action_builder_spec.rb

@@ -0,0 +1,160 @@
+require 'rails_helper'
+
+RSpec.describe 'defining actions from registration blocks', type: :controller do
+  let(:klass){ Admin::PostsController }
+
+  before do
+    load_resources { action! }
+
+    @controller = klass.new
+  end
+
+  describe 'creates a member action' do
+    after(:each) do
+      klass.clear_member_actions!
+    end
+
+    context 'with a block' do
+      let(:action!) do
+        ActiveAdmin.register Post do
+          member_action :comment do
+            # Do nothing
+          end
+        end
+      end
+
+      it 'should create a new public instance method' do
+        expect(klass.public_instance_methods.collect(&:to_s)).to include('comment')
+      end
+
+      it 'should add itself to the member actions config' do
+        expect(klass.active_admin_config.member_actions.size).to eq 1
+      end
+
+      it 'should create a new named route' do
+        expect(Rails.application.routes.url_helpers.methods.collect(&:to_s)).to include('comment_admin_post_path')
+      end
+    end
+
+    context 'without a block' do
+      let(:action!) do
+        ActiveAdmin.register Post do
+          member_action :comment
+        end
+      end
+
+      it 'should still generate a new empty action' do
+        expect(klass.public_instance_methods.collect(&:to_s)).to include('comment')
+      end
+    end
+
+    context 'with :title' do
+      let(:action!) do
+        ActiveAdmin.register Post do
+          member_action :comment, title: 'My Awesome Comment' do
+            render json: {a: 2}
+          end
+        end
+      end
+
+      it 'sets the page title' do
+        get :comment, params: { id: 1 }
+
+        expect(controller.instance_variable_get(:@page_title)).to eq 'My Awesome Comment'
+      end
+    end
+  end
+
+  describe 'creates a collection action' do
+    after(:each) do
+      klass.clear_collection_actions!
+    end
+
+    context 'with a block' do
+      let(:action!) do
+        ActiveAdmin.register Post do
+          collection_action :comments do
+            # Do nothing
+          end
+        end
+      end
+
+      it 'should create a public instance method' do
+        expect(klass.public_instance_methods.collect(&:to_s)).to include('comments')
+      end
+
+      it 'should add itself to the member actions config' do
+        expect(klass.active_admin_config.collection_actions.size).to eq 1
+      end
+
+      it 'should create a named route' do
+        expect(Rails.application.routes.url_helpers.methods.collect(&:to_s)).to include('comments_admin_posts_path')
+      end
+    end
+
+    context 'without a block' do
+      let(:action!) do
+        ActiveAdmin.register Post do
+          collection_action :comments
+        end
+      end
+
+      it 'should still generate a new empty action' do
+        expect(klass.public_instance_methods.collect(&:to_s)).to include('comments')
+      end
+    end
+
+    context 'with :title' do
+      let(:action!) do
+        ActiveAdmin.register Post do
+          collection_action :comments, title: 'My Awesome Comments' do
+            render json: {a: 2}
+          end
+        end
+      end
+
+      it 'sets the page title' do
+        get :comments
+
+        expect(controller.instance_variable_get(:@page_title)).to eq 'My Awesome Comments'
+      end
+    end
+  end
+
+  context 'when method with given name is already defined' do
+    around :each do |example|
+      original_stderr = $stderr
+      $stderr = StringIO.new
+      example.run
+      $stderr = original_stderr
+    end
+
+    describe 'defining member action' do
+      let :action! do
+        ActiveAdmin.register Post do
+          member_action :process do
+            # Do nothing
+          end
+        end
+      end
+
+      it 'writes warning to $stderr' do
+        expect($stderr.string).to include('Warning: method `process` already defined')
+      end
+    end
+
+    describe 'defining collection action' do
+      let :action! do
+        ActiveAdmin.register Post do
+          collection_action :process do
+            # Do nothing
+          end
+        end
+      end
+
+      it 'writes warning to $stderr' do
+        expect($stderr.string).to include('Warning: method `process` already defined')
+      end
+    end
+  end
+end

data/spec/unit/active_admin_spec.rb

@@ -0,0 +1,11 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin do
+  %w(register register_page unload! load! routes).each do |method|
+    it "delegates ##{method} to application" do
+      expect(ActiveAdmin.application).to receive(method)
+
+      ActiveAdmin.send(method)
+    end
+  end
+end

data/spec/unit/application_spec.rb

@@ -0,0 +1,180 @@
+require 'rails_helper'
+require 'fileutils'
+
+RSpec.describe ActiveAdmin::Application do
+
+  let(:application) { ActiveAdmin::Application.new }
+
+  it "should have a default load path of ['app/admin']" do
+    expect(application.load_paths).to eq [File.expand_path('app/admin', application.app_path)]
+  end
+
+  it "should remove app/admin from the autoload paths (Active Admin deals with loading)" do
+    expect(ActiveSupport::Dependencies.autoload_paths).to_not include(File.join(Rails.root, "app/admin"))
+  end
+
+  it "should store the site's title" do
+    expect(application.site_title).to eq ""
+  end
+
+  it "should set the site title" do
+    application.site_title = "New Title"
+    expect(application.site_title).to eq "New Title"
+  end
+
+  it "should store the site's title link" do
+    expect(application.site_title_link).to eq ""
+  end
+
+  it "should set the site's title link" do
+    application.site_title_link = "http://www.mygreatsite.com"
+    expect(application.site_title_link).to eq "http://www.mygreatsite.com"
+  end
+
+  it "should store the site's title image" do
+    expect(application.site_title_image).to eq ""
+  end
+
+  it "should set the site's title image" do
+    application.site_title_image = "http://railscasts.com/assets/episodes/stills/284-active-admin.png?1316476106"
+    expect(application.site_title_image).to eq "http://railscasts.com/assets/episodes/stills/284-active-admin.png?1316476106"
+  end
+
+  it "should store the site's favicon" do
+    expect(application.favicon).to eq false
+  end
+
+  it "should return default localize format" do
+    expect(application.localize_format).to eq :long
+  end
+
+  it "should set localize format" do
+    application.localize_format = :default
+    expect(application.localize_format).to eq :default
+  end
+
+  it "should set the site's favicon" do
+    application.favicon = "/a/favicon.ico"
+    expect(application.favicon).to eq "/a/favicon.ico"
+  end
+
+  it "should store meta tags" do
+    expect(application.meta_tags).to eq({})
+  end
+
+  it "should set meta tags" do
+    application.meta_tags = { author: "My Company" }
+    expect(application.meta_tags).to eq(author: "My Company")
+  end
+
+  it "should contains robots meta tags by default" do
+    result = application.meta_tags_for_logged_out_pages
+    expect(result).to eq(robots: "noindex, nofollow")
+  end
+
+  it "should set meta tags for logged out pages" do
+    value = { author: "My Company" }
+    application.meta_tags_for_logged_out_pages = value
+    expect(application.meta_tags_for_logged_out_pages).to eq value
+  end
+
+  it "should have a view factory" do
+    expect(application.view_factory).to be_an_instance_of(ActiveAdmin::ViewFactory)
+  end
+
+  it "should allow comments by default" do
+    expect(application.comments).to eq true
+  end
+
+  it "should have default order clause class" do
+    expect(application.order_clause).to eq ActiveAdmin::OrderClause
+  end
+
+  it "should have default show_count for scopes" do
+    expect(application.scopes_show_count).to eq true
+  end
+
+  it "fails if setting undefined" do
+    expect do
+      application.undefined_setting
+    end.to raise_error(NoMethodError)
+  end
+
+  describe "authentication settings" do
+
+    it "should have no default current_user_method" do
+      expect(application.current_user_method).to eq false
+    end
+
+    it "should have no default authentication method" do
+      expect(application.authentication_method).to eq false
+    end
+
+    it "should have a logout link path (Devise's default)" do
+      expect(application.logout_link_path).to eq :destroy_admin_user_session_path
+    end
+
+    it "should have a logout link method (Devise's default)" do
+      expect(application.logout_link_method).to eq :get
+    end
+  end
+
+  describe "files in load path" do
+    it "should load files in the first level directory" do
+      expect(application.files).to include(File.expand_path("app/admin/dashboard.rb", application.app_path))
+    end
+
+    it "should load files from subdirectories" do
+      test_dir = File.expand_path("app/admin/public", application.app_path)
+      test_file = File.expand_path("app/admin/public/posts.rb", application.app_path)
+
+      begin
+        FileUtils.mkdir_p(test_dir)
+        FileUtils.touch(test_file)
+        expect(application.files).to include(test_file)
+      ensure
+        FileUtils.remove_entry_secure(test_dir, force: true)
+      end
+    end
+  end
+
+  describe "#namespace" do
+
+    it "should yield a new namespace" do
+      application.namespace :new_namespace do |ns|
+        expect(ns.name).to eq :new_namespace
+      end
+    end
+
+    it "should return an instantiated namespace" do
+      admin = application.namespace :admin
+      expect(admin).to eq application.namespaces[:admin]
+    end
+
+    it "should yield an existing namespace" do
+      expect {
+        application.namespace :admin do |ns|
+          expect(ns).to eq application.namespaces[:admin]
+          raise "found"
+        end
+      }.to raise_error("found")
+    end
+
+    it "should not pollute the global app" do
+      expect(application.namespaces).to be_empty
+      application.namespace(:brand_new_ns)
+      expect(application.namespaces.names).to eq [:brand_new_ns]
+      expect(ActiveAdmin.application.namespaces.names).to eq [:admin]
+    end
+  end
+
+  describe "#register_page" do
+    it "finds or create the namespace and register the page to it" do
+      namespace = double
+      expect(application).to receive(:namespace).with("public").and_return namespace
+      expect(namespace).to receive(:register_page).with("My Page", {namespace: "public"})
+      application.register_page("My Page", namespace: "public")
+    end
+  end
+
+end

data/spec/unit/asset_registration_spec.rb

@@ -0,0 +1,52 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::AssetRegistration do
+  include ActiveAdmin::AssetRegistration
+
+  before do
+    clear_stylesheets!
+    clear_javascripts!
+  end
+
+  it "should register a stylesheet file" do
+    register_stylesheet "active_admin.css"
+    expect(stylesheets.length).to eq 1
+    expect(stylesheets.keys.first).to eq "active_admin.css"
+  end
+
+  it "should clear all existing stylesheets" do
+    register_stylesheet "active_admin.css"
+    expect(stylesheets.length).to eq 1
+    clear_stylesheets!
+    expect(stylesheets).to be_empty
+  end
+
+  it "should allow media option when registering stylesheet" do
+    register_stylesheet "active_admin.css", media: :print
+    expect(stylesheets.values.first[:media]).to eq :print
+  end
+
+  it "shouldn't register a stylesheet twice" do
+    register_stylesheet "active_admin.css"
+    register_stylesheet "active_admin.css"
+    expect(stylesheets.length).to eq 1
+  end
+
+  it "should register a javascript file" do
+    register_javascript "active_admin.js"
+    expect(javascripts).to eq ["active_admin.js"].to_set
+  end
+
+  it "should clear all existing javascripts" do
+    register_javascript "active_admin.js"
+    expect(javascripts).to eq ["active_admin.js"].to_set
+    clear_javascripts!
+    expect(javascripts).to be_empty
+  end
+
+  it "shouldn't register a javascript twice" do
+    register_javascript "active_admin.js"
+    register_javascript "active_admin.js"
+    expect(javascripts.length).to eq 1
+  end
+end

data/spec/unit/authorization/authorization_adapter_spec.rb

@@ -0,0 +1,61 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::AuthorizationAdapter do
+
+  let(:adapter) { ActiveAdmin::AuthorizationAdapter.new(double, double) }
+
+  describe "#authorized?" do
+
+    it "should always return true" do
+      expect(adapter.authorized?(:read, "Resource")).to eq true
+    end
+
+  end
+
+  describe "#scope_collection" do
+
+    it "should return the collection unscoped" do
+      collection = double
+      expect(adapter.scope_collection(collection, ActiveAdmin::Auth::READ)).to eq collection
+    end
+
+  end
+
+  describe "using #normalized in a subclass" do
+
+    let(:auth_class) do
+      Class.new(ActiveAdmin::AuthorizationAdapter) do
+
+        def authorized?(action, subject = nil)
+          case subject
+          when normalized(String)
+            true
+          else
+            false
+          end
+        end
+
+      end
+    end
+
+    let(:adapter) { auth_class.new(double, double) }
+
+    it "should match against a class" do
+      expect(adapter.authorized?(:read, String)).to eq true
+    end
+
+    it 'should match against an instance' do
+      expect(adapter.authorized?(:read, "String")).to eq true
+    end
+
+    it 'should not match a different class' do
+      expect(adapter.authorized?(:read, Hash)).to eq false
+    end
+
+    it 'should not match a different instance' do
+      expect(adapter.authorized?(:read, {})).to eq false
+    end
+
+  end
+
+end