active_remote 3.3.3 → 5.0.0.pre

data/spec/lib/active_remote/rpc_adapters/protobuf_adapter_spec.rb

@@ -17,7 +17,7 @@ describe ActiveRemote::RPCAdapters::ProtobufAdapter do
 
       it "calls the custom endpoint" do
         expect(adapter.client).to receive(:register)
-        adapter.execute(:create, { :name => "foo" })
+        adapter.execute(:create, :name => "foo")
       end
     end
   end

data/spec/lib/active_remote/rpc_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ::ActiveRemote::RPC do
   subject { ::Tag.new }

data/spec/lib/active_remote/scope_keys_spec.rb

@@ -1,16 +1,16 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::ScopeKeys do
   let(:key) { :user_guid }
-  let(:_scope_keys) { [ 'user_guid' ] }
-  let(:scope_keys) { [ 'guid' ] + _scope_keys }
+  let(:_scope_keys) { ["user_guid"] }
+  let(:scope_keys) { ["guid"] + _scope_keys }
   let(:tag) { Tag.new(tag_hash) }
-  let(:tag_hash) { { :guid => 'TAG-123', :user_guid => 'USR-123', :name => 'teh tag' } }
+  let(:tag_hash) { { :guid => "TAG-123", :user_guid => "USR-123", :name => "teh tag" } }
 
   describe ".scope_key" do
     after { Tag._scope_keys = [] }
 
-    it 'adds scope_key to _scope_keys' do
+    it "adds scope_key to _scope_keys" do
       Tag.scope_key(key)
       expect(Tag._scope_keys).to eq(_scope_keys)
     end
@@ -20,7 +20,7 @@ describe ActiveRemote::ScopeKeys do
     before { allow(Tag).to receive(:_scope_keys).and_return(_scope_keys) }
 
     it "combines primary key with _scope_keys" do
-      expect(Tag.scope_keys).to eq(['guid'] + _scope_keys)
+      expect(Tag.scope_keys).to eq(["guid"] + _scope_keys)
     end
   end
 
@@ -31,7 +31,7 @@ describe ActiveRemote::ScopeKeys do
   end
 
   describe "#scope_key_hash" do
-    let(:scope_key_hash) { { 'guid' => 'TAG-123', 'user_guid' => 'USR-123' } }
+    let(:scope_key_hash) { { "guid" => "TAG-123", "user_guid" => "USR-123" } }
 
     before { allow(tag).to receive(:scope_keys).and_return(scope_keys) }
 

data/spec/lib/active_remote/search_spec.rb

@@ -1,14 +1,14 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Search do
-  let(:records) { [ Generic::Remote::Tag.new ] }
+  let(:records) { [Generic::Remote::Tag.new] }
   let(:response) { Generic::Remote::Tags.new(:records => records) }
   let(:rpc) { double(:rpc) }
 
   describe ".find" do
-    let(:args) { Hash.new }
+    let(:args) { {} }
     let(:record) { double(:record) }
-    let(:records) { [ record ] }
+    let(:records) { [record] }
 
     before { allow(Tag).to receive(:search).and_return(records) }
 
@@ -37,10 +37,10 @@ describe ActiveRemote::Search do
   end
 
   describe ".search" do
-    let(:serialized_records) { [ Tag.new ] }
+    let(:serialized_records) { [Tag.new] }
 
     context "given args that respond to :to_hash" do
-      let(:args) { Hash.new }
+      let(:args) { {} }
       let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class, ::Tag.endpoints) }
 
       before { allow(rpc).to receive(:execute).and_return(response) }
@@ -66,8 +66,8 @@ describe ActiveRemote::Search do
   end
 
   describe "#reload" do
-    let(:args) { attributes.slice('guid', 'user_guid') }
-    let(:attributes) { HashWithIndifferentAccess.new(:guid => 'foo', :name => 'bar', :updated_at => nil, :user_guid => 'baz') }
+    let(:args) { attributes.slice("guid", "user_guid") }
+    let(:attributes) { HashWithIndifferentAccess.new(:guid => "foo", :name => "bar", :updated_at => nil, :user_guid => "baz") }
 
     subject { Tag.new(args) }
 

data/spec/lib/active_remote/serialization_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Serialization do
   describe ".serialize_records" do
-    let(:records) { [ { :foo => 'bar' } ] }
+    let(:records) { [{ :foo => "bar" }] }
 
     subject { Tag.new }
 
@@ -14,7 +14,7 @@ describe ActiveRemote::Serialization do
   end
 
   describe "#add_errors" do
-    let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
+    let(:error) { Generic::Error.new(:field => "name", :message => "Boom!") }
     let(:response) {
       tag = Generic::Remote::Tag.new
       tag.errors << error
@@ -26,7 +26,7 @@ describe ActiveRemote::Serialization do
     context "when the response has errors" do
       it "adds the errors to the active remote object" do
         subject.add_errors(response.errors)
-        expect(subject.errors[:name]).to match_array(['Boom!'])
+        expect(subject.errors[:name]).to match_array(["Boom!"])
       end
     end
   end

data/spec/lib/active_remote/serializers/protobuf_spec.rb

@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Serializers::Protobuf::Fields do
   describe ".from_attributes" do
-    let(:ready_value) { { :records => [ { :name => 'Cool Post', :errors => [ { :message => 'Boom!' } ] } ] } }
-    let(:value) { { :records => { :name => 'Cool Post', :errors => { :message => 'Boom!' } } } }
+    let(:ready_value) { { :records => [{ :name => "Cool Post", :errors => [{ :message => "Boom!" }] }] } }
+    let(:value) { { :records => { :name => "Cool Post", :errors => { :message => "Boom!" } } } }
 
     it "gets protobuf-ready fields from attributes" do
       expect(described_class.from_attributes(Generic::Remote::Posts, value)).to eq ready_value
@@ -17,8 +17,8 @@ describe ActiveRemote::Serializers::Protobuf::Field do
       let(:field) { Generic::Remote::Posts.get_field(:records) }
 
       context "and the value is not an array" do
-        let(:ready_value) { [ { :name => 'Cool Post', :errors => [ { :message => 'Boom!' } ] } ] }
-        let(:value) { { :name => 'Cool Post', :errors => { :message => 'Boom!' } } }
+        let(:ready_value) { [{ :name => "Cool Post", :errors => [{ :message => "Boom!" }] }] }
+        let(:value) { { :name => "Cool Post", :errors => { :message => "Boom!" } } }
 
         it "gets protobuf-ready fields from the value" do
           expect(described_class.from_attribute(field, value)).to eq ready_value
@@ -30,8 +30,8 @@ describe ActiveRemote::Serializers::Protobuf::Field do
       let(:field) { Generic::Remote::Post.get_field(:category) }
 
       context "and value is a hash" do
-        let(:ready_value) { { :name => 'Film', :errors => [ { :message => 'Boom!' } ] } }
-        let(:value) { { :name => 'Film', :errors => { :message => 'Boom!' } } }
+        let(:ready_value) { { :name => "Film", :errors => [{ :message => "Boom!" }] } }
+        let(:value) { { :name => "Film", :errors => { :message => "Boom!" } } }
 
         it "gets protobuf-ready fields from the value" do
           expect(described_class.from_attribute(field, value)).to eq ready_value
@@ -43,8 +43,8 @@ describe ActiveRemote::Serializers::Protobuf::Field do
       let(:field) { Generic::Remote::PostRequest.get_field(:name) }
 
       context "and the value is not an array" do
-        let(:ready_value) { [ 'Cool Post' ] }
-        let(:value) { 'Cool Post' }
+        let(:ready_value) { ["Cool Post"] }
+        let(:value) { "Cool Post" }
 
         it "gets protobuf-ready fields from the value" do
           expect(described_class.from_attribute(field, value)).to eq ready_value
@@ -61,28 +61,28 @@ describe ActiveRemote::Serializers::Protobuf::Field do
     # typecasting.
     #
     context "when typecasting fields" do
-      let(:string_value) { double(:string, :to_s => '') }
+      let(:string_value) { double(:string, :to_s => "") }
 
       def typecasts(field, conversion)
         field = Serializer.get_field(field, true)
         expect(described_class.from_attribute(field, conversion.first[0])).to eq conversion.first[1]
       end
 
-      it { typecasts(:bool_field, '0' => false) }
-      it { typecasts(:bytes_field, string_value => '') }
+      it { typecasts(:bool_field, "0" => false) }
+      it { typecasts(:bytes_field, string_value => "") }
       it { typecasts(:double_field, 0 => 0.0) }
-      it { typecasts(:fixed32_field, '0' => 0) }
-      it { typecasts(:fixed64_field, '0' => 0) }
+      it { typecasts(:fixed32_field, "0" => 0) }
+      it { typecasts(:fixed64_field, "0" => 0) }
       it { typecasts(:float_field, 0 => 0.0) }
-      it { typecasts(:int32_field, '0' => 0) }
-      it { typecasts(:int64_field, '0' => 0) }
-      it { typecasts(:sfixed32_field, '0' => 0) }
-      it { typecasts(:sfixed64_field, '0' => 0) }
-      it { typecasts(:sint32_field, '0' => 0) }
-      it { typecasts(:sint64_field, '0' => 0) }
-      it { typecasts(:string_field, string_value => '') }
-      it { typecasts(:uint32_field, '0' => 0) }
-      it { typecasts(:uint64_field, '0' => 0) }
+      it { typecasts(:int32_field, "0" => 0) }
+      it { typecasts(:int64_field, "0" => 0) }
+      it { typecasts(:sfixed32_field, "0" => 0) }
+      it { typecasts(:sfixed64_field, "0" => 0) }
+      it { typecasts(:sint32_field, "0" => 0) }
+      it { typecasts(:sint64_field, "0" => 0) }
+      it { typecasts(:string_field, string_value => "") }
+      it { typecasts(:uint32_field, "0" => 0) }
+      it { typecasts(:uint64_field, "0" => 0) }
       it { typecasts(:enum_field, 0 => 0) }
     end
   end

data/spec/lib/active_remote/validations_spec.rb

@@ -1,53 +1,53 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Validations do
   let(:invalid_record) { ::Post.new }
-  let(:valid_record) { ::Post.new(:name => 'test') }
+  let(:valid_record) { ::Post.new(:name => "test") }
 
   before { allow(valid_record).to receive(:create_or_update).and_return(true) }
   before { allow(invalid_record).to receive(:create_or_update).and_return(true) }
 
-  describe 'save' do
-    context 'valid record' do
-      it 'returns true' do
+  describe "save" do
+    context "valid record" do
+      it "returns true" do
         result = valid_record.save
         expect(result).to be true
       end
     end
 
-    context 'invalid record' do
-      it 'returns false' do
+    context "invalid record" do
+      it "returns false" do
         result = invalid_record.save
         expect(result).to be false
       end
     end
   end
 
-  describe 'save!' do
-    context 'valid record' do
-      it 'returns true' do
+  describe "save!" do
+    context "valid record" do
+      it "returns true" do
         result = valid_record.save!
         expect(result).to be true
       end
     end
 
-    context 'invalid record' do
-      it 'raises invalid record error' do
+    context "invalid record" do
+      it "raises invalid record error" do
         expect { invalid_record.save! }.to raise_error(ActiveRemote::RemoteRecordInvalid)
       end
     end
   end
 
-  describe 'valid?' do
-    context 'valid record' do
-      it 'returns true' do
+  describe "valid?" do
+    context "valid record" do
+      it "returns true" do
         result = valid_record.valid?
         expect(result).to be true
       end
     end
 
-    context 'invalid record' do
-      it 'returns false' do
+    context "invalid record" do
+      it "returns false" do
         result = invalid_record.valid?
         expect(result).to be false
       end

data/spec/spec_helper.rb

@@ -1,19 +1,19 @@
-require 'rubygems'
-require 'bundler'
+require "rubygems"
+require "bundler"
 
-require 'simplecov'
+require "simplecov"
 SimpleCov.start do
-  add_filter '/spec/'
+  add_filter "/spec/"
 end
 
 Bundler.require(:default, :development, :test)
 
-require 'protobuf/rspec'
-require 'support/helpers'
+require "protobuf/rspec"
+require "support/helpers"
 
-$LOAD_PATH << ::File.expand_path('../support/protobuf', __FILE__)
-require 'support/protobuf'
-require 'support/models'
+$LOAD_PATH << ::File.expand_path("../support/protobuf", __FILE__)
+require "support/protobuf"
+require "support/models"
 
 RSpec.configure do |config|
   config.include Protobuf::RSpec::Helpers

data/spec/support/helpers.rb

@@ -11,25 +11,25 @@ def reset_dsl_variables(klass)
 end
 
 def reset_app_name(klass)
- klass.send(:instance_variable_set, :@app_name, nil)
+  klass.send(:instance_variable_set, :@app_name, nil)
 end
 
 def reset_auto_paging_size(klass)
- klass.send(:instance_variable_set, :@auto_paging_size, nil)
+  klass.send(:instance_variable_set, :@auto_paging_size, nil)
 end
 
 def reset_namespace(klass)
- klass.send(:instance_variable_set, :@namespace, nil)
+  klass.send(:instance_variable_set, :@namespace, nil)
 end
 
 def reset_publishable_attributes(klass)
- klass.send(:instance_variable_set, :@publishable_attributes, nil)
+  klass.send(:instance_variable_set, :@publishable_attributes, nil)
 end
 
 def reset_service_class(klass)
- klass.send(:instance_variable_set, :@service_class, nil)
+  klass.send(:instance_variable_set, :@service_class, nil)
 end
 
 def reset_service_name(klass)
- klass.send(:instance_variable_set, :@service_name, nil)
+  klass.send(:instance_variable_set, :@service_name, nil)
 end

data/spec/support/models.rb

@@ -1,8 +1,8 @@
-require 'support/models/message_with_options'
-require 'support/models/author'
-require 'support/models/default_author'
-require 'support/models/category'
-require 'support/models/no_attributes'
-require 'support/models/post'
-require 'support/models/tag'
-require 'support/models/typecasted_author'
+require "support/models/message_with_options"
+require "support/models/author"
+require "support/models/default_author"
+require "support/models/category"
+require "support/models/no_attributes"
+require "support/models/post"
+require "support/models/tag"
+require "support/models/typecasted_author"

data/spec/support/models/author.rb

@@ -1,4 +1,4 @@
-require 'support/protobuf/author.pb'
+require "support/protobuf/author.pb"
 
 ##
 # Define a generic class that inherits from active remote base

data/spec/support/models/category.rb

@@ -1,4 +1,4 @@
-require 'support/protobuf/category.pb'
+require "support/protobuf/category.pb"
 
 ##
 # Define a generic class that inherits from active remote base
@@ -16,5 +16,4 @@ class Category < ::ActiveRemote::Base
   has_one :senior_author, :class_name => "::Author"
   has_one :primary_editor, :class_name => "::Author", :foreign_key => :editor_guid
   has_one :chief_editor, :class_name => "::Author", :scope => :user_guid, :foreign_key => :chief_editor_guid
-
 end

data/spec/support/models/default_author.rb

@@ -1,4 +1,4 @@
-require 'support/protobuf/author.pb'
+require "support/protobuf/author.pb"
 
 ##
 # Define a generic class that inherits from active remote base

data/spec/support/models/post.rb

@@ -1,4 +1,4 @@
-require 'support/protobuf/post.pb'
+require "support/protobuf/post.pb"
 
 ##
 # Define a generic class that inherits from active remote base
@@ -13,9 +13,9 @@ class Post < ::ActiveRemote::Base
   attribute :bestseller_guid
 
   belongs_to :author
-  belongs_to :coauthor, :class_name => '::Author'
-  belongs_to :bestseller, :class_name => '::Author', :foreign_key => :bestseller_guid
-  belongs_to :user, :class_name => '::Author', :scope => :user_guid
+  belongs_to :coauthor, :class_name => "::Author"
+  belongs_to :bestseller, :class_name => "::Author", :foreign_key => :bestseller_guid
+  belongs_to :user, :class_name => "::Author", :scope => :user_guid
 
   validates :name, :presence => true
 end

data/spec/support/models/tag.rb

@@ -1,4 +1,4 @@
-require 'support/protobuf/tag.pb'
+require "support/protobuf/tag.pb"
 
 ##
 # Define a generic class that inherits from active remote base

data/spec/support/models/typecasted_author.rb

@@ -1,9 +1,8 @@
 class TypecastedAuthor < ::ActiveRemote::Base
-  attribute :guid, :type => String
-  attribute :name, :typecaster => StringTypecaster
+  attribute :guid, :string
+  attribute :name, :string
   attribute :age, :integer
-  attribute :birthday, :type => DateTime
+  attribute :birthday, :datetime
   attribute :writes_fiction, :boolean
-  attribute :net_sales, :typecaster => FloatTypecaster
-  attribute :big_integer_field, :big_integer
+  attribute :net_sales, :float
 end

data/spec/support/protobuf.rb

@@ -1,5 +1,5 @@
-require 'support/protobuf/author.pb'
-require 'support/protobuf/category.pb'
-require 'support/protobuf/post.pb'
-require 'support/protobuf/serializer.pb'
-require 'support/protobuf/tag.pb'
+require "support/protobuf/author.pb"
+require "support/protobuf/category.pb"
+require "support/protobuf/post.pb"
+require "support/protobuf/serializer.pb"
+require "support/protobuf/tag.pb"