active_remote 3.3.3 → 5.0.0.pre

data/spec/lib/active_remote/attributes_spec.rb

@@ -15,6 +15,52 @@ describe ::ActiveRemote::Attributes do
   end
   subject { ::Author.new }
 
+  describe "type casting" do
+    let(:test_class) { ::TypecastedAuthor }
+
+    describe "boolean" do
+      it "casts to boolean" do
+        record = test_class.new(:writes_fiction => "f")
+        expect(record.writes_fiction).to eq(false)
+      end
+    end
+
+    describe "datetime" do
+      it "casts to datetime" do
+        record = test_class.new(:birthday => "2016-01-01")
+        expect(record.birthday).to eq(DateTime.parse("2016-01-01"))
+      end
+
+      context "invalid date" do
+        it "sets attribute to nil" do
+          record = test_class.new(:birthday => "23451234")
+          expect(record.birthday).to be_nil
+        end
+      end
+    end
+
+    describe "float" do
+      it "casts to float" do
+        record = test_class.new(:net_sales => "2000.20")
+        expect(record.net_sales).to eq(2000.2)
+      end
+    end
+
+    describe "integer" do
+      it "casts to integer" do
+        record = test_class.new(:age => "40")
+        expect(record.age).to eq(40)
+      end
+    end
+
+    describe "string" do
+      it "casts to string" do
+        record = test_class.new(:guid => 1000)
+        expect(record.guid).to eq("1000")
+      end
+    end
+  end
+
   describe ".attribute" do
     context "a dangerous attribute" do
       it "raises an error" do
@@ -98,7 +144,7 @@ describe ::ActiveRemote::Attributes do
       end
 
       it "returns a new Hash " do
-        subject.attributes.merge!("foobar" => "foobar")
+        subject.attributes["foobar"] = "foobar"
         expect(subject.attributes).to_not include("foobar" => "foobar")
       end
 
@@ -112,11 +158,11 @@ describe ::ActiveRemote::Attributes do
     before { subject.name = "test" }
 
     it "includes the class name and all attribute values in alphabetical order by attribute name" do
-      expect(subject.inspect).to eq(%{#<Author category_guid: nil, chief_editor_guid: nil, editor_guid: nil, guid: nil, name: "test", user_guid: nil>})
+      expect(subject.inspect).to eq(%(#<Author category_guid: nil, chief_editor_guid: nil, editor_guid: nil, guid: nil, name: "test", user_guid: nil>))
     end
 
     it "doesn't format the inspection string for attributes if the model does not have any" do
-      expect(::NoAttributes.new.inspect).to eq(%{#<NoAttributes>})
+      expect(::NoAttributes.new.inspect).to eq(%(#<NoAttributes>))
     end
   end
 

data/spec/lib/active_remote/base_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Base do
   describe "#initialize" do

data/spec/lib/active_remote/dirty_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Dirty do
   context "when writing attributes through the setter" do
-    subject { Post.new(:name => 'foo') }
+    subject { Post.new(:name => "foo") }
 
     before {
       subject.previous_changes.try(:clear)
@@ -10,20 +10,20 @@ describe ActiveRemote::Dirty do
     }
 
     context "when the value changes" do
-      before { subject.name = 'bar' }
+      before { subject.name = "bar" }
 
       its(:name_changed?) { should be_truthy }
     end
 
     context "when the value doesn't change" do
-      before { subject.name = 'foo' }
+      before { subject.name = "foo" }
 
       its(:name_changed?) { should be_falsey }
     end
   end
 
   context "when writing attributes directly" do
-    subject { Post.new(:name => 'foo') }
+    subject { Post.new(:name => "foo") }
 
     before {
       subject.previous_changes.try(:clear)
@@ -31,23 +31,23 @@ describe ActiveRemote::Dirty do
     }
 
     context "when the value changes" do
-      before { subject[:name] = 'bar' }
+      before { subject[:name] = "bar" }
 
       its(:name_changed?) { should be_truthy }
     end
 
     context "when the value doesn't change" do
-      before { subject[:name] = 'foo' }
+      before { subject[:name] = "foo" }
 
       its(:name_changed?) { should be_falsey }
     end
   end
 
   describe "#reload" do
-    subject { Post.new(:name => 'foo') }
+    subject { Post.new(:name => "foo") }
 
     before {
-      allow(Post).to receive(:find).and_return(Post.new(:name => 'foo'))
+      allow(Post).to receive(:find).and_return(Post.new(:name => "foo"))
       subject.reload
     }
 
@@ -57,7 +57,7 @@ describe ActiveRemote::Dirty do
   describe "#save" do
     let!(:changes) { subject.changes }
 
-    subject { Post.new(:name => 'foo') }
+    subject { Post.new(:name => "foo") }
 
     before {
       allow(subject).to receive(:create_or_update).and_return(true)
@@ -71,7 +71,7 @@ describe ActiveRemote::Dirty do
   describe "#save!" do
     let!(:changes) { subject.changes }
 
-    subject { Post.new(:name => 'foo') }
+    subject { Post.new(:name => "foo") }
 
     before {
       allow(subject).to receive(:save).and_return(true)
@@ -84,7 +84,7 @@ describe ActiveRemote::Dirty do
 
   describe "#instantiate" do
     let(:post) { Post.new }
-    let(:record) { ::Generic::Remote::Post.new(:name => 'foo') }
+    let(:record) { ::Generic::Remote::Post.new(:name => "foo") }
 
     it "clears previous changes" do
       new_record = post.instantiate(record.to_hash)

data/spec/lib/active_remote/dsl_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 # For testing the DSL methods
 module Another
@@ -17,19 +17,19 @@ describe ActiveRemote::DSL do
       Tag.attr_publishable :guid
       Tag.attr_publishable :name
 
-      expect(Tag.publishable_attributes).to match_array([ :guid, :name ])
+      expect(Tag.publishable_attributes).to match_array([:guid, :name])
     end
   end
 
   describe ".endpoints" do
     it "has default values" do
-      expect(Tag.endpoints).to eq({
+      expect(Tag.endpoints).to eq(
         :create => :create,
         :delete => :delete,
         :destroy => :destroy,
         :search => :search,
         :update => :update
-      })
+      )
     end
 
     context "given a new value for an endpoint" do

data/spec/lib/active_remote/integration_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ::ActiveRemote::Integration do
   let(:guid) { "GUID-derp" }
@@ -29,7 +29,7 @@ describe ::ActiveRemote::Integration do
 
     it "adds the 'updated_at' attribute to the cache_key if updated_at is present" do
       ::ActiveRemote.config.default_cache_key_updated_at = true
-      twenty_o_one_one = subject[:updated_at] = DateTime.new(2001, 01, 01)
+      twenty_o_one_one = subject[:updated_at] = DateTime.new(2001, 0o1, 0o1)
       expect(subject).to receive(:new_record?).and_return(false)
       expect(subject.cache_key).to eq("tag/#{guid}-#{twenty_o_one_one.to_s(:number)}")
       subject[:updated_at] = nil

data/spec/lib/active_remote/persistence_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ::ActiveRemote::Persistence do
   let(:response_without_errors) { ::HashWithIndifferentAccess.new(:errors => []) }
@@ -15,16 +15,16 @@ describe ::ActiveRemote::Persistence do
   describe ".create" do
     it "runs create callbacks" do
       expect_any_instance_of(Tag).to receive(:after_create_callback)
-      Tag.create(:name => 'foo')
+      Tag.create(:name => "foo")
     end
 
     it "initializes and saves a new record" do
       expect_any_instance_of(Tag).to receive(:save)
-      Tag.create(:name => 'foo')
+      Tag.create(:name => "foo")
     end
 
     it "returns a new record" do
-      value = Tag.create(:name => 'foo')
+      value = Tag.create(:name => "foo")
       expect(value).to be_a(Tag)
     end
   end
@@ -32,14 +32,14 @@ describe ::ActiveRemote::Persistence do
   describe ".create!" do
     it "initializes and saves a new record" do
       expect_any_instance_of(Tag).to receive(:save!)
-      Tag.create!(:name => 'foo')
+      Tag.create!(:name => "foo")
     end
 
     context "when the record has errors" do
       before { allow_any_instance_of(Tag).to receive(:save!).and_raise(ActiveRemote::ActiveRemoteError) }
 
       it "raises an exception" do
-        expect { Tag.create!(:name => 'foo') }.to raise_error(ActiveRemote::ActiveRemoteError)
+        expect { Tag.create!(:name => "foo") }.to raise_error(ActiveRemote::ActiveRemoteError)
       end
     end
   end
@@ -58,8 +58,8 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the response has errors" do
-      let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
-      let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
+      let(:error) { Generic::Error.new(:field => "name", :message => "Boom!") }
+      let(:response) { Generic::Remote::Tag.new(:errors => [error]) }
 
       before { allow(rpc).to receive(:execute).and_return(response) }
 
@@ -81,8 +81,8 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when an error occurs" do
-      let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
-      let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
+      let(:error) { Generic::Error.new(:field => "name", :message => "Boom!") }
+      let(:response) { Generic::Remote::Tag.new(:errors => [error]) }
 
       before { allow(rpc).to receive(:execute).and_return(response) }
 
@@ -106,8 +106,8 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the response has errors" do
-      let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
-      let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
+      let(:error) { Generic::Error.new(:field => "name", :message => "Boom!") }
+      let(:response) { Generic::Remote::Tag.new(:errors => [error]) }
 
       before { allow(rpc).to receive(:execute).and_return(response) }
 
@@ -129,8 +129,8 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when an error occurs" do
-      let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
-      let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
+      let(:error) { Generic::Error.new(:field => "name", :message => "Boom!") }
+      let(:response) { Generic::Remote::Tag.new(:errors => [error]) }
 
       before { allow(rpc).to receive(:execute).and_return(response) }
 
@@ -142,7 +142,7 @@ describe ::ActiveRemote::Persistence do
 
   describe "#readonly?" do
     context "when the record is created through instantiate with options[:readonly]" do
-      subject { Tag.instantiate({:guid => 'foo'}, :readonly => true) }
+      subject { Tag.instantiate({ :guid => "foo" }, :readonly => true) }
 
       its(:new_record?) { should be_falsey }
       its(:readonly?) { should be_truthy }
@@ -165,13 +165,13 @@ describe ::ActiveRemote::Persistence do
 
   describe "#new_record?" do
     context "when the record is created through instantiate" do
-      subject { Tag.instantiate(:guid => 'foo') }
+      subject { Tag.instantiate(:guid => "foo") }
 
       its(:new_record?) { should be_falsey }
     end
 
     context "when the record is persisted" do
-      subject { Tag.allocate.instantiate(:guid => 'foo') }
+      subject { Tag.allocate.instantiate(:guid => "foo") }
 
       its(:new_record?) { should be_falsey }
     end
@@ -185,7 +185,7 @@ describe ::ActiveRemote::Persistence do
 
   describe "#persisted?" do
     context "when the record is persisted" do
-      subject { Tag.allocate.instantiate(:guid => 'foo') }
+      subject { Tag.allocate.instantiate(:guid => "foo") }
 
       its(:persisted?) { should be_truthy }
     end
@@ -215,7 +215,7 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the record is not new" do
-      let(:attributes) { { 'guid' => 'foo' } }
+      let(:attributes) { { "guid" => "foo" } }
 
       subject { Tag.allocate.instantiate(attributes) }
 
@@ -259,16 +259,9 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the record is not saved" do
-      let(:errors) {
-        [Generic::Error.new(:field => "name", :message => "Error one!"),
-         Generic::Error.new(:field => "name", :message => "Error two!")]
-      }
-      let(:response) { Generic::Remote::Tag.new(:errors => errors) }
-      before { allow(rpc).to receive(:execute).and_return(response) }
-
       it "raises an exception" do
-        expect { subject.save! }
-          .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Name Error one!, Name Error two!")
+        allow(subject).to receive(:save).and_return(false)
+        expect { subject.save! }.to raise_error(ActiveRemote::RemoteRecordNotSaved)
       end
     end
   end
@@ -288,7 +281,7 @@ describe ::ActiveRemote::Persistence do
   end
 
   describe "#update_attribute" do
-    let(:tag) { Tag.allocate.instantiate({:guid => "123"}) }
+    let(:tag) { Tag.allocate.instantiate(:guid => "123") }
 
     it "runs update callbacks" do
       expect(tag).to receive(:after_update_callback)
@@ -296,7 +289,7 @@ describe ::ActiveRemote::Persistence do
     end
 
     it "updates a remote record" do
-      expect(rpc).to receive(:execute).with(:update, {"name" => "foo", "guid" => "123"})
+      expect(rpc).to receive(:execute).with(:update, "name" => "foo", "guid" => "123")
       tag.update_attribute(:name, "foo")
     end
 
@@ -315,8 +308,8 @@ describe ::ActiveRemote::Persistence do
   end
 
   describe "#update_attributes" do
-    let(:attributes) { HashWithIndifferentAccess.new(:name => 'bar') }
-    let(:tag) { Tag.allocate.instantiate({:guid => "123"}) }
+    let(:attributes) { HashWithIndifferentAccess.new(:name => "bar") }
+    let(:tag) { Tag.allocate.instantiate(:guid => "123") }
 
     it "runs update callbacks" do
       expect(tag).to receive(:after_update_callback)
@@ -343,7 +336,7 @@ describe ::ActiveRemote::Persistence do
   end
 
   describe "#update_attributes!" do
-    let(:attributes) { HashWithIndifferentAccess.new(:name => 'bar') }
+    let(:attributes) { HashWithIndifferentAccess.new(:name => "bar") }
 
     before { allow(subject).to receive(:save!) }
     after { allow(subject).to receive(:save!).and_call_original }

data/spec/lib/active_remote/primary_key_spec.rb

@@ -1,12 +1,12 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::PrimaryKey do
-  let(:tag) { Tag.new(:id => '1234', :guid => 'TAG-123', :user_guid => 'USR-123') }
+  let(:tag) { Tag.new(:id => "1234", :guid => "TAG-123", :user_guid => "USR-123") }
 
   after { Tag.instance_variable_set :@primary_key, nil }
 
   describe ".default_primary_key" do
-    it 'returns array of :guid' do
+    it "returns array of :guid" do
       expect(Tag.default_primary_key).to eq(:guid)
     end
   end

data/spec/lib/active_remote/query_attribute_spec.rb

@@ -47,125 +47,5 @@ describe ::ActiveRemote::QueryAttributes do
       subject.name = 1
       expect(subject.name?).to eq true
     end
-
-    it "is false when the attribute is 0.0" do
-      subject.name = 0.0
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is 0.1" do
-      subject.name = 0.1
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is a zero BigDecimal" do
-      subject.name = BigDecimal.new("0.0")
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is a non-zero BigDecimal" do
-      subject.name = BigDecimal.new("0.1")
-      expect(subject.name?).to eq true
-    end
-
-    it "is true when the attribute is -1" do
-      subject.name = -1
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is -0.0" do
-      subject.name = -0.0
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is -0.1" do
-      subject.name = -0.1
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is a negative zero BigDecimal" do
-      subject.name = BigDecimal.new("-0.0")
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is a negative BigDecimal" do
-      subject.name = BigDecimal.new("-0.1")
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is '0'" do
-      subject.name = "0"
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is '1'" do
-      subject.name = "1"
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is '0.0'" do
-      subject.name = "0.0"
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is '0.1'" do
-      subject.name = "0.1"
-      expect(subject.name?).to eq true
-    end
-
-    it "is true when the attribute is '-1'" do
-      subject.name = "-1"
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is '-0.0'" do
-      subject.name = "-0.0"
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is '-0.1'" do
-      subject.name = "-0.1"
-      expect(subject.name?).to eq true
-    end
-
-    it "is true when the attribute is 'true'" do
-      subject.name = "true"
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is 'false'" do
-      subject.name = "false"
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is 't'" do
-      subject.name = "t"
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is 'f'" do
-      subject.name = "f"
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is 'T'" do
-      subject.name = "T"
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is 'F'" do
-      subject.name = "F"
-      expect(subject.name?).to eq false
-    end
-
-    it "is true when the attribute is 'TRUE'" do
-      subject.name = "TRUE"
-      expect(subject.name?).to eq true
-    end
-
-    it "is false when the attribute is 'FALSE" do
-      subject.name = "FALSE"
-      expect(subject.name?).to eq false
-    end
   end
 end