active_record_doctor 1.7.2 → 1.8.0

data/test/active_record_doctor/tasks/missing_foreign_keys_test.rb

@@ -1,23 +0,0 @@
-class ActiveRecordDoctor::Tasks::MissingForeignKeysTest < Minitest::Test
-  def test_missing_foreign_key_is_reported
-    Temping.create(:companies, temporary: false)
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.references :company, foreign_key: false
-      end
-    end
-
-    assert_equal({'users' => ['company_id']}, run_task)
-  end
-
-  def test_present_foreign_key_is_not_reported
-    Temping.create(:companies, temporary: false)
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.references :company, foreign_key: true
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-end

data/test/active_record_doctor/tasks/missing_non_null_constraint_test.rb

@@ -1,113 +0,0 @@
-class ActiveRecordDoctor::Tasks::MissingNonNullConstraintTest < Minitest::Test
-  def test_presence_true_and_null_true
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true
-
-      with_columns do |t|
-        t.string :name, null: true
-      end
-    end
-
-    assert_equal({ 'users' => ['name'] }, run_task)
-  end
-
-  def test_association_presence_true_and_null_true
-    Temping.create(:companies, temporary: false)
-    Temping.create(:users, temporary: false) do
-      belongs_to :company, required: true
-
-      with_columns do |t|
-        t.references :company
-      end
-    end
-
-    assert_equal({ 'users' => ['company_id'] }, run_task)
-  end
-
-  def test_presence_true_and_null_false
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true
-
-      with_columns do |t|
-        t.string :name, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_presence_false_and_null_true
-    Temping.create(:users, temporary: false) do
-      # The age validator is a form of regression test against a bug that
-      # caused false positives. In this test case, name is NOT validated
-      # for presence so it does NOT need be marked non-NULL. However, the
-      # bug would match the age presence validator with the NULL-able name
-      # column which would result in a false positive error report.
-      validates :age, presence: true
-      validates :name, presence: false
-
-      with_columns do |t|
-        t.string :name, null: true
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_presence_false_and_null_false
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: false
-
-      with_columns do |t|
-        t.string :name, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_presence_true_with_if
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true, if: -> { false }
-
-      with_columns do |t|
-        t.string :name, null: true
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_presence_true_with_unless
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true, unless: -> { false }
-
-      with_columns do |t|
-        t.string :name, null: true
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_presence_true_with_allow_nil
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true, allow_nil: true
-
-      with_columns do |t|
-        t.string :name, null: true
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_models_with_non_existent_tables_are_skipped
-    klass = Class.new(ActiveRecord::Base) do
-      self.table_name = 'action_text_rich_texts'
-    end
-
-    # No need to assert anything as merely not raising an exception is a success.
-    run_task
-  end
-end

data/test/active_record_doctor/tasks/missing_presence_validation_test.rb

@@ -1,115 +0,0 @@
-class ActiveRecordDoctor::Tasks::MissingPresenceValidationTest < Minitest::Test
-  def test_null_column_is_not_reported_if_validation_absent
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :name
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_non_null_column_is_reported_if_validation_absent
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :name, null: false
-      end
-    end
-
-    assert_equal({ 'User' => ['name'] }, run_task)
-  end
-
-  def test_non_null_column_is_not_reported_if_validation_present
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true
-
-      with_columns do |t|
-        t.string :name, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_non_null_column_is_not_reported_if_association_validation_present
-    Temping.create(:companies, temporary: false)
-    Temping.create(:users, temporary: false) do
-      belongs_to :company, required: true
-
-      with_columns do |t|
-        t.references :company, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_non_null_boolean_is_reported_if_nil_included
-    Temping.create(:users, temporary: false) do
-      validates :active, inclusion: { in: [nil, true, false] }
-
-      with_columns do |t|
-        t.boolean :active, null: false
-      end
-    end
-
-    assert_equal({ 'User' => ['active'] }, run_task)
-  end
-
-  def test_non_null_boolean_is_not_reported_if_nil_not_included
-    Temping.create(:users, temporary: false) do
-      validates :active, inclusion: { in: [true, false] }
-
-      with_columns do |t|
-        t.boolean :active, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_non_null_boolean_is_not_reported_if_nil_excluded
-    Temping.create(:users, temporary: false) do
-      validates :active, exclusion: { in: [nil] }
-
-      with_columns do |t|
-        t.boolean :active, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_non_null_boolean_is_reported_if_nil_not_excluded
-    Temping.create(:users, temporary: false) do
-      validates :active, exclusion: { in: [false] }
-
-      with_columns do |t|
-        t.boolean :active, null: false
-      end
-    end
-
-    assert_equal({ 'User' => ['active'] }, run_task)
-  end
-
-  def test_timestamps_are_not_reported
-    Temping.create(:users, temporary: false) do
-      validates :name, presence: true
-
-      with_columns do |t|
-        t.timestamps null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_models_with_non_existent_tables_are_skipped
-    klass = Class.new(ActiveRecord::Base) do
-      self.table_name = 'action_text_rich_texts'
-    end
-
-    # No need to assert anything as merely not raising an exception is a success.
-    run_task
-  end
-end

data/test/active_record_doctor/tasks/missing_unique_indexes_test.rb

@@ -1,126 +0,0 @@
-class ActiveRecordDoctor::Tasks::MissingUniqueIndexesTest < Minitest::Test
-  def test_missing_unique_index
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.index :email
-      end
-
-      validates :email, uniqueness: true
-    end
-
-    assert_result([
-      ['users', [['email']]]
-    ])
-  end
-
-  def test_present_unique_index
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.index :email, unique: true
-      end
-
-      validates :email, uniqueness: true
-    end
-
-    assert_result([])
-  end
-
-  def test_missing_unique_index_with_scope
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.integer :company_id
-        t.integer :department_id
-        t.index [:company_id, :department_id, :email]
-      end
-
-      validates :email, uniqueness: { scope: [:company_id, :department_id] }
-    end
-
-    assert_result([
-      ['users', [['company_id', 'department_id', 'email']]]
-    ])
-  end
-
-  def test_present_unique_index_with_scope
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.integer :company_id
-        t.integer :department_id
-        t.index [:company_id, :department_id, :email], unique: true
-      end
-
-      validates :email, uniqueness: { scope: [:company_id, :department_id] }
-    end
-
-    assert_result([])
-  end
-
-  def test_column_order_is_ignored
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.integer :organization_id
-
-        t.index [:email, :organization_id], unique: true
-      end
-
-      validates :email, uniqueness: { scope: :organization_id }
-    end
-
-    assert_result([])
-  end
-
-  def test_conditions_is_skipped
-    assert_skipped(conditions: -> { where.not(email: nil) })
-  end
-
-  def test_case_insensitive_is_skipped
-    assert_skipped(case_sensitive: false)
-  end
-
-  def test_if_is_skipped
-    assert_skipped(if: ->(model) { true })
-  end
-
-  def test_unless_is_skipped
-    assert_skipped(unless: ->(model) { true })
-  end
-
-  def test_skips_validator_without_attributes
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.index :email
-      end
-
-      validates_with DummyValidator
-    end
-
-    # There's no need for assert/refute as it's enough the line below doesn't
-    # raise an exception.
-    run_task
-  end
-
-  class DummyValidator < ActiveModel::Validator
-    def validate(record)
-    end
-  end
-
-  private
-
-  def assert_skipped(options)
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :email
-      end
-
-      validates :email, uniqueness: options
-    end
-
-    assert_result([])
-  end
-end

data/test/active_record_doctor/tasks/undefined_table_references_test.rb

@@ -1,47 +0,0 @@
-class ActiveRecordDoctor::Tasks::UndefinedTableReferencesTest < Minitest::Test
-  def test_table_exists
-    # No columns needed, just the table.
-    Temping.create(:users, temporary: false)
-
-    assert_equal([[], true], run_task)
-  end
-
-  def test_table_does_not_exist
-    # No columns needed, just the table.
-    Temping.create(:users, temporary: false)
-
-    # We drop the underlying table to make the model invalid.
-    ActiveRecord::Base.connection.drop_table(User.table_name)
-
-    # We wrap the assertion in begin/ensure because we must recreate the
-    # table as otherwise Temping will raise an error. Assertion errors are
-    # signalled via exceptions which we shouldn't swallow if we don't want to
-    # break the test suite hence the choice of begin/ensure.
-    begin
-      assert_equal([[[User.name, User.table_name]], true], run_task)
-    ensure
-      ActiveRecord::Base.connection.create_table(User.table_name)
-    end
-  end
-
-  def test_view_instead_of_table
-    # No columns needed, just the table.
-    Temping.create(:users, temporary: false)
-
-    # We replace the underlying table with a view. The view doesn't have to be
-    # backed by an actual table - it can simply return a predefined tuple.
-    ActiveRecord::Base.connection.drop_table(User.table_name)
-    ActiveRecord::Base.connection.execute("CREATE VIEW users AS SELECT 1")
-
-    # We wrap the assertion in begin/ensure because we must recreate the
-    # table as otherwise Temping will raise an error. Assertion errors are
-    # signalled via exceptions which we shouldn't swallow if we don't want to
-    # break the test suite hence the choice of begin/ensure.
-    begin
-      assert_equal([[], true], run_task)
-    ensure
-      ActiveRecord::Base.connection.execute("DROP VIEW users")
-      ActiveRecord::Base.connection.create_table(User.table_name)
-    end
-  end
-end

data/test/active_record_doctor/tasks/unindexed_deleted_at_test.rb

@@ -1,59 +0,0 @@
-class ActiveRecordDoctor::Tasks::UnindexedDeletedAtTest < Minitest::Test
-  def test_indexed_deleted_at_is_not_reported
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :first_name
-        t.string :last_name
-        t.datetime :deleted_at
-        t.index [:first_name, :last_name],
-          name: 'index_profiles_on_first_name_and_last_name',
-          where: 'deleted_at IS NULL'
-      end
-    end
-
-    assert_result([])
-  end
-
-  def test_unindexed_deleted_at_is_reported
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :first_name
-        t.string :last_name
-        t.datetime :deleted_at
-        t.index [:first_name, :last_name],
-          name: 'index_profiles_on_first_name_and_last_name'
-      end
-    end
-
-    assert_result(['index_profiles_on_first_name_and_last_name'])
-  end
-
-  def test_indexed_discarded_at_is_not_reported
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :first_name
-        t.string :last_name
-        t.datetime :discarded_at
-        t.index [:first_name, :last_name],
-          name: 'index_profiles_on_first_name_and_last_name',
-          where: 'discarded_at IS NULL'
-      end
-    end
-
-    assert_result([])
-  end
-
-  def test_unindexed_discarded_at_is_reported
-    Temping.create(:users, temporary: false) do
-      with_columns do |t|
-        t.string :first_name
-        t.string :last_name
-        t.datetime :discarded_at
-        t.index [:first_name, :last_name],
-          name: 'index_profiles_on_first_name_and_last_name'
-      end
-    end
-
-    assert_result(['index_profiles_on_first_name_and_last_name'])
-  end
-end