active_record_doctor 1.7.2 → 1.8.0

metadata

@@ -1,100 +1,100 @@
 --- !ruby/object:Gem::Specification
 name: active_record_doctor
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.8.0
 platform: ruby
 authors:
 - Greg Navis
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-27 00:00:00.000000000 Z
+date: 2021-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 4.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 4.2.0
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: minitest-fork_executor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
-  type: :runtime
+        version: 1.0.2
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 1.0.2
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
-  type: :runtime
+        version: 0.5.3
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 0.5.3
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 1.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 1.1.4
 - !ruby/object:Gem::Dependency
-  name: temping
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
-  name: minitest-fork_executor
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-description: 
+        version: 1.14.0
+description:
 email:
 - contact@gregnavis.com
 executables: []
@@ -104,40 +104,44 @@ files:
 - MIT-LICENSE.txt
 - README.md
 - lib/active_record_doctor.rb
+- lib/active_record_doctor/detectors.rb
+- lib/active_record_doctor/detectors/base.rb
+- lib/active_record_doctor/detectors/extraneous_indexes.rb
+- lib/active_record_doctor/detectors/incorrect_boolean_presence_validation.rb
+- lib/active_record_doctor/detectors/incorrect_dependent_option.rb
+- lib/active_record_doctor/detectors/missing_foreign_keys.rb
+- lib/active_record_doctor/detectors/missing_non_null_constraint.rb
+- lib/active_record_doctor/detectors/missing_presence_validation.rb
+- lib/active_record_doctor/detectors/missing_unique_indexes.rb
+- lib/active_record_doctor/detectors/undefined_table_references.rb
+- lib/active_record_doctor/detectors/unindexed_deleted_at.rb
+- lib/active_record_doctor/detectors/unindexed_foreign_keys.rb
 - lib/active_record_doctor/printers.rb
 - lib/active_record_doctor/printers/io_printer.rb
 - lib/active_record_doctor/railtie.rb
-- lib/active_record_doctor/tasks.rb
-- lib/active_record_doctor/tasks/base.rb
-- lib/active_record_doctor/tasks/extraneous_indexes.rb
-- lib/active_record_doctor/tasks/incorrect_boolean_presence_validation.rb
-- lib/active_record_doctor/tasks/missing_foreign_keys.rb
-- lib/active_record_doctor/tasks/missing_non_null_constraint.rb
-- lib/active_record_doctor/tasks/missing_presence_validation.rb
-- lib/active_record_doctor/tasks/missing_unique_indexes.rb
-- lib/active_record_doctor/tasks/undefined_table_references.rb
-- lib/active_record_doctor/tasks/unindexed_deleted_at.rb
-- lib/active_record_doctor/tasks/unindexed_foreign_keys.rb
+- lib/active_record_doctor/task.rb
 - lib/active_record_doctor/version.rb
 - lib/generators/active_record_doctor/add_indexes/USAGE
 - lib/generators/active_record_doctor/add_indexes/add_indexes_generator.rb
 - lib/tasks/active_record_doctor.rake
+- test/active_record_doctor/detectors/extraneous_indexes_test.rb
+- test/active_record_doctor/detectors/incorrect_boolean_presence_validation_test.rb
+- test/active_record_doctor/detectors/incorrect_dependent_option_test.rb
+- test/active_record_doctor/detectors/missing_foreign_keys_test.rb
+- test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
+- test/active_record_doctor/detectors/missing_presence_validation_test.rb
+- test/active_record_doctor/detectors/missing_unique_indexes_test.rb
+- test/active_record_doctor/detectors/undefined_table_references_test.rb
+- test/active_record_doctor/detectors/unindexed_deleted_at_test.rb
+- test/active_record_doctor/detectors/unindexed_foreign_keys_test.rb
 - test/active_record_doctor/printers/io_printer_test.rb
-- test/active_record_doctor/tasks/extraneous_indexes_test.rb
-- test/active_record_doctor/tasks/incorrect_boolean_presence_validation_test.rb
-- test/active_record_doctor/tasks/missing_foreign_keys_test.rb
-- test/active_record_doctor/tasks/missing_non_null_constraint_test.rb
-- test/active_record_doctor/tasks/missing_presence_validation_test.rb
-- test/active_record_doctor/tasks/missing_unique_indexes_test.rb
-- test/active_record_doctor/tasks/undefined_table_references_test.rb
-- test/active_record_doctor/tasks/unindexed_deleted_at_test.rb
-- test/active_record_doctor/tasks/unindexed_foreign_keys_test.rb
+- test/model_factory.rb
 - test/setup.rb
 homepage: https://github.com/gregnavis/active_record_doctor
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -145,26 +149,28 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubygems_version: 3.2.15
+signing_key:
 specification_version: 4
 summary: Identify database issues before they hit production.
 test_files:
-- test/setup.rb
+- test/active_record_doctor/detectors/extraneous_indexes_test.rb
+- test/active_record_doctor/detectors/incorrect_boolean_presence_validation_test.rb
+- test/active_record_doctor/detectors/incorrect_dependent_option_test.rb
+- test/active_record_doctor/detectors/missing_foreign_keys_test.rb
+- test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
+- test/active_record_doctor/detectors/missing_presence_validation_test.rb
+- test/active_record_doctor/detectors/missing_unique_indexes_test.rb
+- test/active_record_doctor/detectors/undefined_table_references_test.rb
+- test/active_record_doctor/detectors/unindexed_deleted_at_test.rb
+- test/active_record_doctor/detectors/unindexed_foreign_keys_test.rb
 - test/active_record_doctor/printers/io_printer_test.rb
-- test/active_record_doctor/tasks/incorrect_boolean_presence_validation_test.rb
-- test/active_record_doctor/tasks/unindexed_deleted_at_test.rb
-- test/active_record_doctor/tasks/extraneous_indexes_test.rb
-- test/active_record_doctor/tasks/unindexed_foreign_keys_test.rb
-- test/active_record_doctor/tasks/missing_unique_indexes_test.rb
-- test/active_record_doctor/tasks/missing_non_null_constraint_test.rb
-- test/active_record_doctor/tasks/missing_presence_validation_test.rb
-- test/active_record_doctor/tasks/undefined_table_references_test.rb
-- test/active_record_doctor/tasks/missing_foreign_keys_test.rb
+- test/model_factory.rb
+- test/setup.rb

data/lib/active_record_doctor/tasks.rb

@@ -1,10 +0,0 @@
-require "active_support"
-require "active_support/core_ext/class/subclasses"
-
-module ActiveRecordDoctor
-  module Tasks
-    def self.all
-      ActiveRecordDoctor::Tasks::Base.subclasses
-    end
-  end
-end

data/lib/active_record_doctor/tasks/base.rb

@@ -1,86 +0,0 @@
-require "active_record_doctor/printers/io_printer"
-
-module ActiveRecordDoctor
-  module Tasks
-    class Base
-      def self.run
-        new.run
-      end
-
-      def self.description
-        @description
-      end
-
-      def initialize(printer = ActiveRecordDoctor::Printers::IOPrinter.new)
-        @printer = printer
-      end
-
-      private
-
-      def success(result)
-        [result, true]
-      end
-
-      def connection
-        @connection ||= ActiveRecord::Base.connection
-      end
-
-      def indexes(table_name)
-        connection.indexes(table_name)
-      end
-
-      def tables
-        @tables ||=
-          if ActiveRecord::VERSION::MAJOR == 5
-            connection.data_sources
-          else
-            connection.tables
-          end
-      end
-
-      def table_exists?(table_name)
-        connection.table_exists?(table_name)
-      end
-
-      def views
-        @views ||=
-          if ActiveRecord::VERSION::MAJOR == 5
-            connection.views
-          elsif connection.is_a?(ActiveRecord::ConnectionAdapters::PostgreSQLAdapter)
-            ActiveRecord::Base.connection.execute(<<-SQL).map { |tuple| tuple.fetch("relname") }
-              SELECT c.relname FROM pg_class c WHERE c.relkind IN ('m', 'v')
-            SQL
-          else
-            # We don't support this Rails/database combination yet.
-            nil
-          end
-      end
-
-      def hash_from_pairs(pairs)
-        Hash[*pairs.flatten(1)]
-      end
-
-      def eager_load!
-        # We call GC.start to make the test suite work. It's (probably) not
-        # needed for use during development. However, if we remove it then the
-        # test suite will start accumulating temporary model classes in the
-        # object space. Running the garbage collector gets rid of them.
-        GC.start
-
-        Rails.application.eager_load!
-      end
-
-      def models
-        descendants(ActiveRecord::Base)
-      end
-
-      def descendants(superclass)
-        superclass.descendants
-      end
-
-      def descendant?(klass, superclass)
-        !klass.nil? && (klass.superclass == superclass || descendant?(klass.superclass, superclass))
-      end
-    end
-  end
-end

data/test/active_record_doctor/tasks/extraneous_indexes_test.rb

@@ -1,77 +0,0 @@
-class ActiveRecordDoctor::Tasks::ExtraneousIndexesTest < Minitest::Test
-  def test_index_on_primary_key_is_duplicate
-    Temping.create(:user, temporary: false) do
-      with_columns do |t|
-        t.index :id
-      end
-    end
-
-    assert_result([['index_users_on_id', [:primary_key, 'users']]])
-  end
-
-  def test_non_unique_version_of_index_is_duplicate
-    Temping.create(:user, temporary: false) do
-      with_columns do |t|
-        t.string :email
-        t.index :email, name: 'index_users_on_email'
-        t.index :email, unique: true, name: 'unique_index_on_users_email'
-      end
-    end
-
-    assert_result([
-      ['index_users_on_email', [:multi_column, 'unique_index_on_users_email']]
-    ])
-  end
-
-  def test_single_column_covered_by_unique_and_non_unique_multi_column_is_duplicate
-    Temping.create(:user, temporary: false) do
-      with_columns do |t|
-        t.string :first_name
-        t.string :last_name
-        t.string :email
-        t.index [:last_name, :first_name, :email]
-        t.index [:last_name, :first_name],
-          unique: true,
-          name: 'unique_index_on_users_last_name_and_first_name'
-        t.index :last_name
-      end
-    end
-
-    assert_result([
-      [
-        'index_users_on_last_name',
-        [
-          :multi_column,
-          'index_users_on_last_name_and_first_name_and_email',
-          'unique_index_on_users_last_name_and_first_name'
-        ]
-      ]
-    ])
-  end
-
-  def test_multi_column_covered_by_unique_and_non_unique_multi_column_is_duplicate
-    Temping.create(:user, temporary: false) do
-      with_columns do |t|
-        t.string :first_name
-        t.string :last_name
-        t.string :email
-        t.index [:last_name, :first_name, :email]
-        t.index [:last_name, :first_name],
-          unique: true,
-          name: 'unique_index_on_users_last_name_and_first_name'
-        t.index [:last_name, :first_name]
-      end
-    end
-
-    assert_result([
-      [
-        'index_users_on_last_name_and_first_name',
-        [
-          :multi_column,
-          'index_users_on_last_name_and_first_name_and_email',
-          'unique_index_on_users_last_name_and_first_name'
-        ]
-      ]
-    ])
-  end
-end

data/test/active_record_doctor/tasks/incorrect_boolean_presence_validation_test.rb

@@ -1,38 +0,0 @@
-class ActiveRecordDoctor::Tasks::IncorrectBooleanPresenceValidationTest < Minitest::Test
-  def test_presence_true_is_reported_on_boolean_only
-    Temping.create(:users, temporary: false) do
-      # email is a non-boolean column whose presence CAN be validated in the
-      # usual way. We include it in the test model to ensure the task reports
-      # only boolean columns.
-      validates :email, :active, presence: true
-
-      with_columns do |t|
-        t.string :email, null: false
-        t.boolean :active, null: false
-      end
-    end
-
-    assert_equal({ 'User' => ['active'] }, run_task)
-  end
-
-  def test_inclusion_is_not_reported
-    Temping.create(:users, temporary: false) do
-      validates :active, inclusion: { in: [true, false] }
-
-      with_columns do |t|
-        t.boolean :active, null: false
-      end
-    end
-
-    assert_equal({}, run_task)
-  end
-
-  def test_models_with_non_existent_tables_are_skipped
-    klass = Class.new(ActiveRecord::Base) do
-      self.table_name = 'action_text_rich_texts'
-    end
-
-    # No need to assert anything as merely not raising an exception is a success.
-    run_task
-  end
-end