active_model_serializers 0.10.0.rc3 → 0.10.0.rc4

data/test/adapter/json_api/has_many_embed_ids_test.rb

@@ -2,9 +2,9 @@ require 'test_helper'
 
 module ActiveModel
   class Serializer
-    class Adapter
+    module Adapter
       class JsonApi
-        class HasManyEmbedIdsTest < Minitest::Test
+        class HasManyEmbedIdsTest < ActiveSupport::TestCase
           def setup
             @author = Author.new(name: 'Steve K.')
             @author.bio = nil

data/test/adapter/json_api/has_many_explicit_serializer_test.rb

@@ -2,10 +2,10 @@ require 'test_helper'
 
 module ActiveModel
   class Serializer
-    class Adapter
+    module Adapter
       class JsonApi
         # Test 'has_many :assocs, serializer: AssocXSerializer'
-        class HasManyExplicitSerializerTest < Minitest::Test
+        class HasManyExplicitSerializerTest < ActiveSupport::TestCase
           def setup
             @post = Post.new(title: 'New Post', body: 'Body')
             @author = Author.new(name: 'Jane Blogger')

data/test/adapter/json_api/has_many_test.rb

@@ -2,9 +2,9 @@ require 'test_helper'
 
 module ActiveModel
   class Serializer
-    class Adapter
+    module Adapter
       class JsonApi
-        class HasManyTest < Minitest::Test
+        class HasManyTest < ActiveSupport::TestCase
           def setup
             ActionController::Base.cache_store.clear
             @author = Author.new(id: 1, name: 'Steve K.')
@@ -68,7 +68,7 @@ module ActiveModel
           end
 
           def test_limit_fields_of_linked_comments
-            @adapter = ActiveModel::Serializer::Adapter::JsonApi.new(@serializer, include: [:comments], fields: { comment: [:id] })
+            @adapter = ActiveModel::Serializer::Adapter::JsonApi.new(@serializer, include: [:comments], fields: { comment: [:id, :post, :author] })
             expected = [{
               id: '1',
               type: 'comments',

data/test/adapter/json_api/has_one_test.rb

@@ -2,9 +2,9 @@ require 'test_helper'
 
 module ActiveModel
   class Serializer
-    class Adapter
+    module Adapter
       class JsonApi
-        class HasOneTest < Minitest::Test
+        class HasOneTest < ActiveSupport::TestCase
           def setup
             @author = Author.new(id: 1, name: 'Steve K.')
             @bio = Bio.new(id: 43, content: 'AMS Contributor')

data/test/adapter/json_api/json_api_test.rb

@@ -2,8 +2,8 @@ require 'test_helper'
 
 module ActiveModel
   class Serializer
-    class Adapter
-      class JsonApiTest < Minitest::Test
+    module Adapter
+      class JsonApiTest < ActiveSupport::TestCase
         def setup
           ActionController::Base.cache_store.clear
           @author = Author.new(id: 1, name: 'Steve K.')

data/test/adapter/json_api/linked_test.rb

@@ -1,11 +1,16 @@
 require 'test_helper'
+
+NestedPost = Class.new(Model)
+class NestedPostSerializer < ActiveModel::Serializer
+  has_many :nested_posts
+end
+
 module ActiveModel
   class Serializer
-    class Adapter
+    module Adapter
       class JsonApi
-        class LinkedTest < Minitest::Test
+        class LinkedTest < ActiveSupport::TestCase
           def setup
-            ActionController::Base.cache_store.clear
             @author1 = Author.new(id: 1, name: 'Steve K.')
             @author2 = Author.new(id: 2, name: 'Tenderlove')
             @bio1 = Bio.new(id: 1, content: 'AMS Contributor')
@@ -40,7 +45,7 @@ module ActiveModel
           end
 
           def test_include_multiple_posts_and_linked_array
-            serializer = ArraySerializer.new([@first_post, @second_post])
+            serializer = CollectionSerializer.new([@first_post, @second_post])
             adapter = ActiveModel::Serializer::Adapter::JsonApi.new(
               serializer,
               include: [:comments, author: [:bio]]
@@ -221,7 +226,7 @@ module ActiveModel
           end
 
           def test_multiple_references_to_same_resource
-            serializer = ArraySerializer.new([@first_comment, @second_comment])
+            serializer = CollectionSerializer.new([@first_comment, @second_comment])
             adapter = ActiveModel::Serializer::Adapter::JsonApi.new(
               serializer,
               include: [:post]
@@ -277,6 +282,112 @@ module ActiveModel
             assert_equal expected, adapter.serializable_hash
           end
         end
+
+        class NoDuplicatesTest < ActiveSupport::TestCase
+          Post = Class.new(::Model)
+          Author = Class.new(::Model)
+
+          class PostSerializer < ActiveModel::Serializer
+            type 'posts'
+            belongs_to :author
+          end
+
+          class AuthorSerializer < ActiveModel::Serializer
+            type 'authors'
+            has_many :posts
+          end
+
+          def setup
+            @author = Author.new(id: 1, posts: [], roles: [], bio: nil)
+            @post1 = Post.new(id: 1, author: @author)
+            @post2 = Post.new(id: 2, author: @author)
+            @author.posts << @post1
+            @author.posts << @post2
+
+            @nestedpost1 = ::NestedPost.new(id: 1, nested_posts: [])
+            @nestedpost2 = ::NestedPost.new(id: 2, nested_posts: [])
+            @nestedpost1.nested_posts << @nestedpost1
+            @nestedpost1.nested_posts << @nestedpost2
+            @nestedpost2.nested_posts << @nestedpost1
+            @nestedpost2.nested_posts << @nestedpost2
+          end
+
+          def test_no_duplicates
+            hash = ActiveModel::SerializableResource.new(@post1, adapter: :json_api,
+                                                                 include: '*.*')
+                   .serializable_hash
+            expected = [
+              {
+                type: 'authors', id: '1',
+                relationships: {
+                  posts: {
+                    data: [
+                      { type: 'posts', id: '1' },
+                      { type: 'posts', id: '2' }
+                    ]
+                  }
+                }
+              },
+              {
+                type: 'posts', id: '2',
+                relationships: {
+                  author: {
+                    data: { type: 'authors', id: '1' }
+                  }
+                }
+              }
+            ]
+            assert_equal(expected, hash[:included])
+          end
+
+          def test_no_duplicates_collection
+            hash = ActiveModel::SerializableResource.new(
+              [@post1, @post2], adapter: :json_api,
+                                include: '*.*')
+                   .serializable_hash
+            expected = [
+              {
+                type: 'authors', id: '1',
+                relationships: {
+                  posts: {
+                    data: [
+                      { type: 'posts', id: '1' },
+                      { type: 'posts', id: '2' }
+                    ]
+                  }
+                }
+              }
+            ]
+            assert_equal(expected, hash[:included])
+          end
+
+          def test_no_duplicates_global
+            hash = ActiveModel::SerializableResource.new(
+              @nestedpost1,
+              adapter: :json_api,
+              include: '*').serializable_hash
+            expected = [
+              type: 'nested_posts', id: '2',
+              relationships: {
+                nested_posts: {
+                  data: [
+                    { type: 'nested_posts', id: '1' },
+                    { type: 'nested_posts', id: '2' }
+                  ]
+                }
+              }
+            ]
+            assert_equal(expected, hash[:included])
+          end
+
+          def test_no_duplicates_collection_global
+            hash = ActiveModel::SerializableResource.new(
+              [@nestedpost1, @nestedpost2],
+              adapter: :json_api,
+              include: '*').serializable_hash
+            assert_nil(hash[:included])
+          end
+        end
       end
     end
   end

data/test/adapter/json_api/links_test.rb

@@ -0,0 +1,68 @@
+require 'test_helper'
+
+module ActiveModel
+  class Serializer
+    module Adapter
+      class JsonApi
+        class LinksTest < ActiveSupport::TestCase
+          LinkAuthor = Class.new(::Model)
+          class LinkAuthorSerializer < ActiveModel::Serializer
+            link :self do
+              href "//example.com/link_author/#{object.id}"
+              meta stuff: 'value'
+            end
+
+            link :other, '//example.com/resource'
+
+            link :yet_another do
+              "//example.com/resource/#{object.id}"
+            end
+          end
+
+          def setup
+            @post = Post.new(id: 1337, comments: [], author: nil)
+            @author = LinkAuthor.new(id: 1337)
+          end
+
+          def test_toplevel_links
+            hash = ActiveModel::SerializableResource.new(
+              @post,
+              adapter: :json_api,
+              links: {
+                self: {
+                  href: '//example.com/posts',
+                  meta: {
+                    stuff: 'value'
+                  }
+                }
+              }).serializable_hash
+            expected = {
+              self: {
+                href: '//example.com/posts',
+                meta: {
+                  stuff: 'value'
+                }
+              }
+            }
+            assert_equal(expected, hash[:links])
+          end
+
+          def test_resource_links
+            hash = serializable(@author, adapter: :json_api).serializable_hash
+            expected = {
+              self: {
+                href: '//example.com/link_author/1337',
+                meta: {
+                  stuff: 'value'
+                }
+              },
+              other: '//example.com/resource',
+              yet_another: '//example.com/resource/1337'
+            }
+            assert_equal(expected, hash[:data][:links])
+          end
+        end
+      end
+    end
+  end
+end

data/test/adapter/json_api/pagination_links_test.rb

@@ -6,9 +6,9 @@ require 'kaminari/hooks'
 
 module ActiveModel
   class Serializer
-    class Adapter
+    module Adapter
       class JsonApi
-        class PaginationLinksTest < Minitest::Test
+        class PaginationLinksTest < ActiveSupport::TestCase
           URI = 'http://example.com'
 
           def setup
@@ -22,10 +22,10 @@ module ActiveModel
 
           def mock_request(query_parameters = {}, original_url = URI)
             context = Minitest::Mock.new
-            context.expect(:original_url, original_url)
+            context.expect(:request_url, original_url)
             context.expect(:query_parameters, query_parameters)
             @options = {}
-            @options[:context] = context
+            @options[:serialization_context] = context
           end
 
           def load_adapter(paginated_collection, options = {})

data/test/adapter/json_api/parse_test.rb

@@ -0,0 +1,139 @@
+require 'test_helper'
+module ActiveModel
+  class Serializer
+    module Adapter
+      class JsonApi
+        module Deserialization
+          class ParseTest < Minitest::Test
+            def setup
+              @hash = {
+                'data' => {
+                  'type' => 'photos',
+                  'id' => 'zorglub',
+                  'attributes' => {
+                    'title' => 'Ember Hamster',
+                    'src' => 'http://example.com/images/productivity.png'
+                  },
+                  'relationships' => {
+                    'author' => {
+                      'data' => nil
+                    },
+                    'photographer' => {
+                      'data' => { 'type' => 'people', 'id' => '9' }
+                    },
+                    'comments' => {
+                      'data' => [
+                        { 'type' => 'comments', 'id' => '1' },
+                        { 'type' => 'comments', 'id' => '2' }
+                      ]
+                    }
+                  }
+                }
+              }
+              @params = ActionController::Parameters.new(@hash)
+              @expected = {
+                id: 'zorglub',
+                title: 'Ember Hamster',
+                src: 'http://example.com/images/productivity.png',
+                author_id: nil,
+                photographer_id: '9',
+                comment_ids: %w(1 2)
+              }
+
+              @illformed_payloads = [nil,
+                                     {},
+                                     {
+                                       'data' => nil
+                                     }, {
+                                       'data' => { 'attributes' => [] }
+                                     }, {
+                                       'data' => { 'relationships' => [] }
+                                     }, {
+                                       'data' => {
+                                         'relationships' => { 'rel' => nil }
+                                       }
+                                     }, {
+                                       'data' => {
+                                         'relationships' => { 'rel' => {} }
+                                       }
+                                     }]
+            end
+
+            def test_hash
+              parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(@hash)
+              assert_equal(@expected, parsed_hash)
+            end
+
+            def test_actioncontroller_parameters
+              assert_equal(false, @params.permitted?)
+              parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(@params)
+              assert_equal(@expected, parsed_hash)
+            end
+
+            def test_illformed_payloads_safe
+              @illformed_payloads.each do |p|
+                parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse(p)
+                assert_equal({}, parsed_hash)
+              end
+            end
+
+            def test_illformed_payloads_unsafe
+              @illformed_payloads.each do |p|
+                assert_raises(InvalidDocument) do
+                  ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(p)
+                end
+              end
+            end
+
+            def test_filter_fields_only
+              parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(@hash, only: [:id, :title, :author])
+              expected = {
+                id: 'zorglub',
+                title: 'Ember Hamster',
+                author_id: nil
+              }
+              assert_equal(expected, parsed_hash)
+            end
+
+            def test_filter_fields_except
+              parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(@hash, except: [:id, :title, :author])
+              expected = {
+                src: 'http://example.com/images/productivity.png',
+                photographer_id: '9',
+                comment_ids: %w(1 2)
+              }
+              assert_equal(expected, parsed_hash)
+            end
+
+            def test_keys
+              parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(@hash, keys: { author: :user, title: :post_title })
+              expected = {
+                id: 'zorglub',
+                post_title: 'Ember Hamster',
+                src: 'http://example.com/images/productivity.png',
+                user_id: nil,
+                photographer_id: '9',
+                comment_ids: %w(1 2)
+              }
+              assert_equal(expected, parsed_hash)
+            end
+
+            def test_polymorphic
+              parsed_hash = ActiveModel::Serializer::Adapter::JsonApi::Deserialization.parse!(@hash, polymorphic: [:photographer])
+              expected = {
+                id: 'zorglub',
+                title: 'Ember Hamster',
+                src: 'http://example.com/images/productivity.png',
+                author_id: nil,
+                photographer_id: '9',
+                photographer_type: 'people',
+                comment_ids: %w(1 2)
+              }
+              assert_equal(expected, parsed_hash)
+            end
+          end
+        end
+      end
+    end
+  end
+end