active_interaction 3.7.1 → 4.0.0

data/spec/active_interaction/filters/date_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::DateFilter, :filter do
@@ -15,7 +13,7 @@ describe ActiveInteraction::DateFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Date' do
       let(:value) { Date.new }
@@ -63,6 +61,48 @@ describe ActiveInteraction::DateFilter, :filter do
       end
     end
 
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '2011-12-13'
+          end
+        end.new
+      end
+
+      it 'returns a Date' do
+        expect(result).to eql Date.parse(value)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
+
     context 'with a GroupedInput' do
       let(:year) { 2012 }
       let(:month) { 1 }

data/spec/active_interaction/filters/date_time_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::DateTimeFilter, :filter do
@@ -15,7 +13,7 @@ describe ActiveInteraction::DateTimeFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Datetime' do
       let(:value) { DateTime.new }
@@ -63,6 +61,48 @@ describe ActiveInteraction::DateTimeFilter, :filter do
       end
     end
 
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '2011-12-13T14:15:16+17:18'
+          end
+        end.new
+      end
+
+      it 'returns a DateTime' do
+        expect(result).to eql DateTime.parse(value)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
+
     context 'with a GroupedInput' do
       let(:year) { 2012 }
       let(:month) { 1 }

data/spec/active_interaction/filters/decimal_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::DecimalFilter, :filter do
@@ -15,7 +13,7 @@ describe ActiveInteraction::DecimalFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Float' do
       let(:value) { rand }
@@ -35,6 +33,20 @@ describe ActiveInteraction::DecimalFilter, :filter do
       end
     end
 
+    context 'with an implicit Integer' do
+      let(:value) do
+        Class.new do
+          def to_int
+            @to_int ||= rand(1 << 16)
+          end
+        end.new
+      end
+
+      it 'returns a BigDecimal' do
+        expect(result).to eql BigDecimal(value.to_int)
+      end
+    end
+
     context 'with a Numeric' do
       let(:value) { rand(1 << 16) }
 
@@ -60,6 +72,48 @@ describe ActiveInteraction::DecimalFilter, :filter do
         end.to raise_error ActiveInteraction::InvalidValueError
       end
     end
+
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '1.1'
+          end
+        end.new
+      end
+
+      it 'returns a BigDecimal' do
+        expect(result).to eql BigDecimal(value)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
   end
 
   describe '#database_column_type' do

data/spec/active_interaction/filters/file_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::FileFilter, :filter do
@@ -7,7 +5,7 @@ describe ActiveInteraction::FileFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a File' do
       let(:value) { File.new(__FILE__) }

data/spec/active_interaction/filters/float_filter_spec.rb

@@ -1,5 +1,4 @@
-# coding: utf-8
-
+require 'bigdecimal'
 require 'spec_helper'
 
 describe ActiveInteraction::FloatFilter, :filter do
@@ -7,7 +6,7 @@ describe ActiveInteraction::FloatFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Float' do
       let(:value) { rand }
@@ -17,8 +16,22 @@ describe ActiveInteraction::FloatFilter, :filter do
       end
     end
 
+    context 'with an implicit Integer' do
+      let(:value) do
+        Class.new do
+          def to_int
+            @to_int ||= rand(1 << 16)
+          end
+        end.new
+      end
+
+      it 'returns a Float' do
+        expect(result).to eql value.to_int.to_f
+      end
+    end
+
     context 'with a Numeric' do
-      let(:value) { rand(1 << 16) }
+      let(:value) { BigDecimal('1.2') }
 
       it 'returns a Float' do
         expect(result).to eql value.to_f
@@ -42,6 +55,49 @@ describe ActiveInteraction::FloatFilter, :filter do
         end.to raise_error ActiveInteraction::InvalidValueError
       end
     end
+
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '1.1'
+          end
+        end.new
+      end
+
+      it 'returns a Float' do
+        # apparently `Float()` doesn't do this even though `Integer()` does
+        expect(result).to eql Float(value.to_str)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
   end
 
   describe '#database_column_type' do

data/spec/active_interaction/filters/hash_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::HashFilter, :filter do
@@ -15,7 +13,7 @@ describe ActiveInteraction::HashFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with a Hash' do
       let(:value) { {} }
@@ -25,6 +23,20 @@ describe ActiveInteraction::HashFilter, :filter do
       end
     end
 
+    context 'with an implicit Hash' do
+      let(:value) do
+        Class.new do
+          def to_hash
+            {}
+          end
+        end.new
+      end
+
+      it 'returns the Hash' do
+        expect(result).to eql value.to_hash
+      end
+    end
+
     context 'with a non-empty Hash' do
       let(:value) { { a: {} } }
 
@@ -66,12 +78,10 @@ describe ActiveInteraction::HashFilter, :filter do
         end
 
         it 'populates the error' do
-          begin
-            result
-          rescue ActiveInteraction::InvalidNestedValueError => e
-            expect(e.filter_name).to eql k
-            expect(e.input_value).to eql v
-          end
+          result
+        rescue ActiveInteraction::InvalidNestedValueError => e
+          expect(e.filter_name).to eql k
+          expect(e.input_value).to eql v
         end
       end
     end

data/spec/active_interaction/filters/integer_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::IntegerFilter, :filter do
@@ -7,7 +5,7 @@ describe ActiveInteraction::IntegerFilter, :filter do
   it_behaves_like 'a filter'
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with an Integer' do
       let(:value) { rand(1 << 16) }
@@ -29,7 +27,7 @@ describe ActiveInteraction::IntegerFilter, :filter do
       let(:value) { rand(1 << 16).to_s }
 
       it 'returns an Integer' do
-        expect(result).to eql Integer(value)
+        expect(result).to eql Integer(value, 10)
       end
     end
 
@@ -43,12 +41,56 @@ describe ActiveInteraction::IntegerFilter, :filter do
       end
     end
 
+    context 'with an implicit String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            '1'
+          end
+        end.new
+      end
+
+      it 'returns an Integer' do
+        # jRuby freezes on the implicit string value
+        expect(result).to eql Integer(value.to_str, 10)
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(result).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            result
+          end.to raise_error ActiveInteraction::MissingValueError
+        end
+      end
+    end
+
     it 'supports different bases' do
-      expect(filter.cast('07', nil)).to eql 7
+      expect(
+        described_class.new(name, base: 8).send(:cast, '071', nil)
+      ).to eql 57
       expect do
-        filter.cast('08', nil)
+        described_class.new(name, base: 8).send(:cast, '081', nil)
       end.to raise_error ActiveInteraction::InvalidValueError
-      expect(described_class.new(name, base: 10).cast('08', nil)).to eql 8
     end
   end