active_interaction 3.7.1 → 4.0.0

data/spec/active_interaction/concerns/active_modelable_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 shared_examples_for 'ActiveModel' do

data/spec/active_interaction/concerns/active_recordable_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 InteractionWithFloatFilter = Class.new(TestInteraction) do

data/spec/active_interaction/concerns/hashable_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::Hashable do
@@ -27,7 +25,7 @@ describe ActiveInteraction::Hashable do
       end
 
       context 'with a block' do
-        let(:block) { proc {} }
+        let(:block) { proc {} } # rubocop:disable Lint/EmptyBlock
         let(:hash) { subject.hash(*arguments, &block) }
 
         it 'calls method_missing' do

data/spec/active_interaction/concerns/missable_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::Missable do

data/spec/active_interaction/concerns/runnable_spec.rb

@@ -1,11 +1,9 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::Runnable do
   include_context 'concerns', ActiveInteraction::Runnable
 
-  class WrappableFailingInteraction
+  class WrappableFailingInteraction # rubocop:disable Lint/ConstantDefinitionInBlock
     include ActiveInteraction::Runnable
 
     def execute
@@ -72,7 +70,7 @@ describe ActiveInteraction::Runnable do
       include_examples 'set_callback examples', :execute
 
       context 'execute with composed interaction' do
-        class WithFailingCompose
+        class WithFailingCompose # rubocop:disable Lint/ConstantDefinitionInBlock
           include ActiveInteraction::Runnable
 
           def execute
@@ -107,11 +105,9 @@ describe ActiveInteraction::Runnable do
           context 'using if' do
             it 'yields errors to the if' do
               has_run = false
-              # rubocop:disable Metic/LineLength
               WithFailingCompose.set_callback :execute, :after, if: -> { errors.any? } do
                 has_run = true
               end
-              # rubocop:enable Metic/LineLength
 
               WithFailingCompose.run
               expect(has_run).to be_truthy
@@ -237,10 +233,10 @@ describe ActiveInteraction::Runnable do
     context 'caches the validity and result of the run' do
       let(:klass) do
         Class.new(ActiveInteraction::Base) do
-          INVALID = [false, true].cycle
+          invalid = [false, true].cycle
 
           validate do |interaction|
-            interaction.errors.add(:base, 'failed') unless INVALID.next
+            interaction.errors.add(:base, 'failed') unless invalid.next
           end
 
           def execute
@@ -260,10 +256,10 @@ describe ActiveInteraction::Runnable do
     context 'caches the validity and result of the run' do
       let(:klass) do
         Class.new(ActiveInteraction::Base) do
-          VALID = [true, false].cycle
+          valid = [true, false].cycle
 
           validate do |interaction|
-            interaction.errors.add(:base, 'failed') unless VALID.next
+            interaction.errors.add(:base, 'failed') unless valid.next
           end
 
           def execute
@@ -327,14 +323,14 @@ describe ActiveInteraction::Runnable do
     end
 
     context 'with failing composition' do
-      class CheckInnerForFailure
+      class CheckInnerForFailure # rubocop:disable Lint/ConstantDefinitionInBlock
         include ActiveInteraction::Runnable
 
         attr_reader :caught_error
 
         def execute
           compose(WrappableFailingInteraction)
-        rescue
+        rescue StandardError
           @caught_error = true
           raise
         end
@@ -345,6 +341,24 @@ describe ActiveInteraction::Runnable do
         expect(outcome.caught_error).to be true
       end
     end
+
+    context 'with block not called and error in execute around callback' do
+      class CheckExecuteAroundCallbackForFailure # rubocop:disable Lint/ConstantDefinitionInBlock
+        include ActiveInteraction::ActiveModelable
+        include ActiveInteraction::Runnable
+
+        set_callback :execute, :around, -> { errors.add(:base, 'invalid') }
+
+        def execute
+          true
+        end
+      end
+
+      it 'is invalid' do
+        outcome = CheckExecuteAroundCallbackForFailure.run
+        expect(outcome).to_not be_valid
+      end
+    end
   end
 
   describe '.run!' do
@@ -369,6 +383,12 @@ describe ActiveInteraction::Runnable do
             result
           end.to raise_error ActiveInteraction::InvalidInteractionError
         end
+
+        it 'adds interaction instance to this error' do
+          expect { result }.to raise_error do |error|
+            expect(error.interaction).to be_a klass
+          end
+        end
       end
     end
   end

data/spec/active_interaction/errors_spec.rb

@@ -1,6 +1,15 @@
-# coding: utf-8
-
 require 'spec_helper'
+require 'active_record'
+unless defined?(JRUBY_VERSION) # rubocop:disable Style/IfUnlessModifier
+  require 'sqlite3'
+end
+
+unless defined?(JRUBY_VERSION)
+  ActiveRecord::Base.establish_connection(
+    adapter: 'sqlite3',
+    database: ':memory:'
+  )
+end
 
 describe ActiveInteraction::Errors do
   let(:klass) do
@@ -17,25 +26,6 @@ describe ActiveInteraction::Errors do
 
   subject(:errors) { described_class.new(klass.new) }
 
-  context 'backports' do
-    describe '#delete' do
-      it 'deletes the detailed error' do
-        errors.add(:attribute)
-        errors.delete(:attribute)
-        expect(errors.details).to_not have_key :attribute
-      end
-    end
-
-    describe '#initialize_dup' do
-      it 'duplicates the detailed errors' do
-        errors.add(:attribute)
-        other = errors.dup
-        expect(other.details).to eql errors.details
-        expect(other.details).to_not be errors.details
-      end
-    end
-  end
-
   describe '#merge!' do
     let(:other) { described_class.new(klass.new) }
 
@@ -117,7 +107,7 @@ describe ActiveInteraction::Errors do
                 klass.name => {
                   attributes: {
                     attribute: {
-                      invalid_type: 'is not a valid %{type}'
+                      invalid_type: 'is not a valid %<type>s'
                     }
                   }
                 }
@@ -148,5 +138,42 @@ describe ActiveInteraction::Errors do
         expect(errors.messages[:base]).to include message
       end
     end
+
+    unless defined?(JRUBY_VERSION)
+      context 'with nested errors' do
+        before do
+          # suppress create_table output
+          allow($stdout).to receive(:puts)
+          ActiveRecord::Schema.define do
+            create_table(:as)
+            create_table(:bs) do |t|
+              t.column :a_id, :integer
+              t.column :name, :string
+            end
+          end
+
+          class A < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinitionInBlock
+            has_one :b
+            accepts_nested_attributes_for :b
+          end
+
+          class B < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinitionInBlock
+            belongs_to :a
+
+            validates :name, presence: true
+          end
+        end
+
+        let(:a) { A.create(b_attributes: { name: nil }) }
+
+        it 'merges the nested errors' do
+          a.valid?
+          expect(a.errors.messages).to eq('b.name': ["can't be blank"])
+          expect(a.errors.size).to eql 1
+          expect { errors.merge!(a.errors) }.to_not raise_error
+          expect(errors.size).to eql 1
+        end
+      end
+    end
   end
 end

data/spec/active_interaction/filter_column_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::FilterColumn do

data/spec/active_interaction/filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::Filter, :filter do

data/spec/active_interaction/filters/abstract_date_time_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::AbstractDateTimeFilter, :filter do
@@ -9,7 +7,7 @@ describe ActiveInteraction::AbstractDateTimeFilter, :filter do
     let(:value) { nil }
 
     it 'raises an error' do
-      expect { filter.cast(value, nil) }.to raise_error NameError
+      expect { filter.send(:cast, value, nil) }.to raise_error NameError
     end
   end
 end

data/spec/active_interaction/filters/abstract_numeric_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::AbstractNumericFilter, :filter do
@@ -9,7 +7,7 @@ describe ActiveInteraction::AbstractNumericFilter, :filter do
     let(:value) { nil }
 
     it 'raises an error' do
-      expect { filter.cast(value, nil) }.to raise_error NameError
+      expect { filter.send(:cast, value, nil) }.to raise_error NameError
     end
   end
 end

data/spec/active_interaction/filters/array_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::ArrayFilter, :filter do
@@ -36,7 +34,7 @@ describe ActiveInteraction::ArrayFilter, :filter do
   end
 
   describe '#cast' do
-    let(:result) { filter.cast(value, nil) }
+    let(:result) { filter.send(:cast, value, nil) }
 
     context 'with an Array' do
       let(:value) { [] }
@@ -46,6 +44,20 @@ describe ActiveInteraction::ArrayFilter, :filter do
       end
     end
 
+    context 'with an implicit Array' do
+      let(:value) do
+        Class.new do
+          def to_ary
+            [1, 2, 3]
+          end
+        end.new
+      end
+
+      it 'returns the Array' do
+        expect(result).to eql value.to_ary
+      end
+    end
+
     context 'with a heterogenous Array' do
       let(:value) { [[], false, 0.0, {}, 0, '', :''] }
 
@@ -84,21 +96,35 @@ describe ActiveInteraction::ArrayFilter, :filter do
       end
     end
 
-    context 'with a nested object filter' do
-      let(:block) { proc { object } }
-      let(:name) { :objects }
-      let(:value) { [Object.new] }
+    [
+      %i[object class],
+      %i[record class],
+      %i[interface from]
+    ].each do |(type, option)|
+      context "with a nested #{type} filter" do
+        let(:block) { proc { public_send(type) } }
+        let(:name) { :objects }
+        let(:value) { [''] }
+
+        it 'does not raise an error' do
+          expect { result }.to_not raise_error
+        end
 
-      it 'does not raise an error' do
-        expect { result }.to_not raise_error
-      end
+        it 'has a filter with the right key' do
+          expect(filter.filters).to have_key(:'0')
+        end
 
-      it 'has a filter with the right key' do
-        expect(filter.filters).to have_key(:object)
-      end
+        it 'has a filter with the right option' do
+          expect(filter.filters[:'0'].options).to have_key(option)
+        end
+
+        context 'with a class set' do
+          let(:block) { proc { public_send(type, "#{option}": String) } }
 
-      it 'has a filter with the right name' do
-        expect(filter.filters[:object].name).to eql(:object)
+          it "does not override the #{option}" do
+            expect(filter.filters[:'0'].options[option]).to eql String
+          end
+        end
       end
     end
   end

data/spec/active_interaction/filters/boolean_filter_spec.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require 'spec_helper'
 
 describe ActiveInteraction::BooleanFilter, :filter do
@@ -10,7 +8,21 @@ describe ActiveInteraction::BooleanFilter, :filter do
     context 'falsey' do
       [false, '0', 'false', 'FALSE', 'off', 'OFF'].each do |value|
         it "returns false for #{value.inspect}" do
-          expect(filter.cast(value, nil)).to be_falsey
+          expect(filter.send(:cast, value, nil)).to be_falsey
+        end
+      end
+
+      context 'with an implicit string' do
+        let(:value) do
+          Class.new do
+            def to_str
+              'false'
+            end
+          end.new
+        end
+
+        it 'returns false' do
+          expect(filter.send(:cast, value, nil)).to be_falsey
         end
       end
     end
@@ -18,7 +30,49 @@ describe ActiveInteraction::BooleanFilter, :filter do
     context 'truthy' do
       [true, '1', 'true', 'TRUE', 'on', 'ON'].each do |value|
         it "returns true for #{value.inspect}" do
-          expect(filter.cast(value, nil)).to be_truthy
+          expect(filter.send(:cast, value, nil)).to be_truthy
+        end
+      end
+
+      context 'with an implicit string' do
+        let(:value) do
+          Class.new do
+            def to_str
+              'true'
+            end
+          end.new
+        end
+
+        it 'returns true' do
+          expect(filter.send(:cast, value, nil)).to be_truthy
+        end
+      end
+    end
+
+    context 'with a blank String' do
+      let(:value) do
+        Class.new do
+          def to_str
+            ' '
+          end
+        end.new
+      end
+
+      context 'optional' do
+        include_context 'optional'
+
+        it 'returns the default' do
+          expect(filter.send(:cast, value, nil)).to eql options[:default]
+        end
+      end
+
+      context 'required' do
+        include_context 'required'
+
+        it 'raises an error' do
+          expect do
+            filter.send(:cast, value, nil)
+          end.to raise_error ActiveInteraction::MissingValueError
         end
       end
     end