active_attr 0.4.1 → 0.5.0.alpha1

data/spec/unit/active_attr/typecasting/string_typecaster_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+require "active_attr/typecasting/string_typecaster"
+require "active_support/basic_object"
+
+module ActiveAttr
+  module Typecasting
+    describe StringTypecaster do
+      describe "#call" do
+        it "returns the original string for a String" do
+          value = "abc"
+          subject.call(value).should equal value
+        end
+
+        it "casts nil to an empty String" do
+          subject.call(nil).should eql ""
+        end
+
+        it "returns the string version of a Symbol" do
+          subject.call(:value).should eql "value"
+        end
+      end
+    end
+  end
+end

data/spec/unit/active_attr/typecasting_spec.rb

@@ -0,0 +1,87 @@
+require "spec_helper"
+require "active_attr/typecasting"
+
+module ActiveAttr
+  describe Typecasting do
+    subject { model_class.new }
+
+    let :model_class do
+      Class.new do
+        include Typecasting
+      end
+    end
+
+    describe "#typecast_attribute" do
+      let(:type) { String }
+
+      it "raises an ArgumentError when a nil type is given" do
+        expect { subject.typecast_attribute(nil, "foo") }.to raise_error(ArgumentError, "a Class must be given")
+      end
+
+      context "when there is no way to typecast the value" do
+        let(:value) { mock("SomeRandomValue") }
+
+        it "returns nil" do
+          subject.stub(:typecast_value).and_return(nil)
+          subject.typecast_attribute(type, value).should be_nil
+        end
+      end
+
+      context "when the value is nil" do
+        let(:name) { nil }
+        let(:model) { model_class.new }
+        subject { model.typecast_attribute(type, name) }
+
+        it "returns the original value" do
+          should eql name
+        end
+
+        it "does not call try to convert the value" do
+          model.should_not_receive(:typecast_value)
+          subject
+        end
+      end
+    end
+
+    describe "#typecast_value" do
+      let(:model) { model_class.new }
+      subject { model.typecast_value(type, value) }
+      let(:value) { mock }
+
+      it "calls BooleanTypecaster when typecasting to Boolean" do
+        Typecasting::BooleanTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(Typecasting::Boolean, value)
+      end
+
+      it "calls DateTypecaster when typecasting to Date" do
+        Typecasting::DateTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(Date, value)
+      end
+
+      it "calls DateTypecaster when typecasting to Date" do
+        Typecasting::DateTimeTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(DateTime, value)
+      end
+
+      it "calls FloatTypecaster when typecasting to Float" do
+        Typecasting::FloatTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(Float, value)
+      end
+
+      it "calls IntegerTypecaster when typecasting to Integer" do
+        Typecasting::IntegerTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(Integer, value)
+      end
+
+      it "calls StringTypecaster when typecasting to String" do
+        Typecasting::StringTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(String, value)
+      end
+
+      it "calls ObjectTypecaster when typecasting to Object" do
+        Typecasting::ObjectTypecaster.any_instance.should_receive(:call).with(value)
+        model.typecast_value(Object, value)
+      end
+    end
+  end
+end

data/spec/unit/active_attr/version_spec.rb

@@ -11,7 +11,8 @@ module ActiveAttr
       let(:gem_version) { Gem::Version.new VERSION }
       subject { gem_version }
 
-      it { subject.should have(3).segments }
+      it { subject.should have_at_least(3).segments }
+      it { subject.should have_at_most(5).segments }
 
       describe "major version" do
         subject { gem_version.segments[0] }
@@ -28,7 +29,15 @@ module ActiveAttr
       describe "patch version" do
         subject { gem_version.segments[2] }
 
-        it { subject.to_s.should =~ /\d+([A-Za-z][0-9A-Za-z-]*)?/ }
+        it { should be_a_kind_of Fixnum }
+      end
+
+      describe "pre-release version" do
+        subject { VERSION.split(".")[3] }
+
+        it "is nil or starts with a letter and is alphanumeric" do
+          (subject.nil? || subject =~ /^[A-Za-z][0-9A-Za-z]*?/).should be_true
+        end
       end
     end
   end

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: active_attr
 version: !ruby/object:Gem::Version
-  version: 0.4.1
-  prerelease: 
+  version: 0.5.0.alpha1
+  prerelease: 6
 platform: ruby
 authors:
 - Chris Griego
@@ -10,33 +10,39 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-27 00:00:00.000000000Z
+date: 2012-01-30 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70212854595820 !ruby/object:Gem::Requirement
+  requirement: &70156170094480 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70212854595820
+  version_requirements: *70156170094480
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70212854610300 !ruby/object:Gem::Requirement
+  requirement: &70156170093260 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70212854610300
+  version_requirements: *70156170093260
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70212854618100 !ruby/object:Gem::Requirement
+  requirement: &70156170091500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,10 +50,10 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70212854618100
+  version_requirements: *70156170091500
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &70212854630340 !ruby/object:Gem::Requirement
+  requirement: &70156170090500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -55,10 +61,10 @@ dependencies:
         version: '2.2'
   type: :development
   prerelease: false
-  version_requirements: *70212854630340
+  version_requirements: *70156170090500
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70212858706240 !ruby/object:Gem::Requirement
+  requirement: &70156170089280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -66,10 +72,10 @@ dependencies:
         version: 0.9.0
   type: :development
   prerelease: false
-  version_requirements: *70212858706240
+  version_requirements: *70156170089280
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70212863308060 !ruby/object:Gem::Requirement
+  requirement: &70156170087680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -77,7 +83,18 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70212863308060
+  version_requirements: *70156170087680
+- !ruby/object:Gem::Dependency
+  name: tzinfo
+  requirement: &70156170086620 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.3.29
+  type: :development
+  prerelease: false
+  version_requirements: *70156170086620
 description: Create plain old ruby models without reinventing the wheel.
 email:
 - cgriego@gmail.com
@@ -98,8 +115,10 @@ files:
 - README.md
 - Rakefile
 - active_attr.gemspec
+- gemfiles/rails_3_1.gemfile
 - gemfiles/rails_head.gemfile
 - lib/active_attr.rb
+- lib/active_attr/attribute_defaults.rb
 - lib/active_attr/attribute_definition.rb
 - lib/active_attr/attributes.rb
 - lib/active_attr/basic_model.rb
@@ -116,18 +135,29 @@ files:
 - lib/active_attr/query_attributes.rb
 - lib/active_attr/railtie.rb
 - lib/active_attr/rspec.rb
-- lib/active_attr/strict_mass_assignment.rb
+- lib/active_attr/typecasted_attributes.rb
+- lib/active_attr/typecasting.rb
+- lib/active_attr/typecasting/boolean.rb
+- lib/active_attr/typecasting/boolean_typecaster.rb
+- lib/active_attr/typecasting/date_time_typecaster.rb
+- lib/active_attr/typecasting/date_typecaster.rb
+- lib/active_attr/typecasting/float_typecaster.rb
+- lib/active_attr/typecasting/integer_typecaster.rb
+- lib/active_attr/typecasting/object_typecaster.rb
+- lib/active_attr/typecasting/string_typecaster.rb
 - lib/active_attr/unknown_attribute_error.rb
-- lib/active_attr/unknown_attributes_error.rb
 - lib/active_attr/version.rb
+- spec/functional/active_attr/attribute_defaults_spec.rb
 - spec/functional/active_attr/attributes_spec.rb
 - spec/functional/active_attr/chainable_initialization_spec.rb
 - spec/functional/active_attr/model_spec.rb
 - spec/functional/active_attr/query_attributes_spec.rb
+- spec/functional/active_attr/typecasted_attributes_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model_lint.rb
 - spec/support/initialization_verifier.rb
 - spec/support/mass_assignment_shared_examples.rb
+- spec/unit/active_attr/attribute_defaults_spec.rb
 - spec/unit/active_attr/attribute_definition_spec.rb
 - spec/unit/active_attr/attributes_spec.rb
 - spec/unit/active_attr/basic_model_spec.rb
@@ -139,9 +169,17 @@ files:
 - spec/unit/active_attr/mass_assignment_spec.rb
 - spec/unit/active_attr/matchers/have_attribute_matcher_spec.rb
 - spec/unit/active_attr/query_attributes_spec.rb
-- spec/unit/active_attr/strict_mass_assignment_spec.rb
+- spec/unit/active_attr/typecasted_attributes_spec.rb
+- spec/unit/active_attr/typecasting/boolean_spec.rb
+- spec/unit/active_attr/typecasting/boolean_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/date_time_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/date_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/float_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/integer_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/object_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/string_typecaster_spec.rb
+- spec/unit/active_attr/typecasting_spec.rb
 - spec/unit/active_attr/unknown_attribute_error_spec.rb
-- spec/unit/active_attr/unknown_attributes_error_spec.rb
 - spec/unit/active_attr/version_spec.rb
 homepage: https://github.com/cgriego/active_attr
 licenses: []
@@ -157,16 +195,13 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3302118214315982046
+      hash: -4291119495453604965
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: 3302118214315982046
+      version: 1.3.1
 requirements: []
 rubyforge_project: active_attr
 rubygems_version: 1.8.10
@@ -174,14 +209,17 @@ signing_key:
 specification_version: 3
 summary: What ActiveModel left out
 test_files:
+- spec/functional/active_attr/attribute_defaults_spec.rb
 - spec/functional/active_attr/attributes_spec.rb
 - spec/functional/active_attr/chainable_initialization_spec.rb
 - spec/functional/active_attr/model_spec.rb
 - spec/functional/active_attr/query_attributes_spec.rb
+- spec/functional/active_attr/typecasted_attributes_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model_lint.rb
 - spec/support/initialization_verifier.rb
 - spec/support/mass_assignment_shared_examples.rb
+- spec/unit/active_attr/attribute_defaults_spec.rb
 - spec/unit/active_attr/attribute_definition_spec.rb
 - spec/unit/active_attr/attributes_spec.rb
 - spec/unit/active_attr/basic_model_spec.rb
@@ -193,8 +231,16 @@ test_files:
 - spec/unit/active_attr/mass_assignment_spec.rb
 - spec/unit/active_attr/matchers/have_attribute_matcher_spec.rb
 - spec/unit/active_attr/query_attributes_spec.rb
-- spec/unit/active_attr/strict_mass_assignment_spec.rb
+- spec/unit/active_attr/typecasted_attributes_spec.rb
+- spec/unit/active_attr/typecasting/boolean_spec.rb
+- spec/unit/active_attr/typecasting/boolean_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/date_time_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/date_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/float_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/integer_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/object_typecaster_spec.rb
+- spec/unit/active_attr/typecasting/string_typecaster_spec.rb
+- spec/unit/active_attr/typecasting_spec.rb
 - spec/unit/active_attr/unknown_attribute_error_spec.rb
-- spec/unit/active_attr/unknown_attributes_error_spec.rb
 - spec/unit/active_attr/version_spec.rb
 has_rdoc: 

data/lib/active_attr/strict_mass_assignment.rb

@@ -1,44 +0,0 @@
-require "active_attr/mass_assignment"
-require "active_attr/unknown_attributes_error"
-require "active_support/concern"
-
-module ActiveAttr
-  # StrictMassAssignment allows mass assignment of attributes, but raises an
-  # exception when assigning unknown attributes
-  #
-  # Attempting to assign any unknown or private attribute through any of the
-  # mass assignment methods ({#assign_attributes}, {#attributes=}, and
-  # {#initialize}) will raise an {ActiveAttr::UnknownAttributesError}
-  # exception.
-  #
-  # @example Usage
-  #   class Person
-  #     include ActiveAttr::StrictMassAssignment
-  #   end
-  #
-  # @since 0.2.0
-  module StrictMassAssignment
-    extend ActiveSupport::Concern
-    include MassAssignment
-
-    # Mass update a model's attributes, but raise an error if an attempt is
-    # made to assign an unknown attribute
-    #
-    # @param (see MassAssignment#assign_attributes)
-    #
-    # @raise [ActiveAttr::UnknownAttributesError]
-    #
-    # @since 0.2.0
-    def assign_attributes(new_attributes, options={})
-      unknown_attribute_names = (new_attributes || {}).reject do |name, value|
-        respond_to? "#{name}="
-      end.map { |name, value| name.to_s }.sort
-
-      if unknown_attribute_names.any?
-        raise UnknownAttributesError, "unknown attribute(s): #{unknown_attribute_names.join(", ")}"
-      else
-        super
-      end
-    end
-  end
-end

data/lib/active_attr/unknown_attributes_error.rb

@@ -1,18 +0,0 @@
-require "active_attr/error"
-
-module ActiveAttr
-  # This exception is raised if attempting to mass assign unknown attributes
-  # when using {StrictMassAssignment}
-  #
-  # @example Rescuing an UnknownAttributesError error
-  #   begin
-  #     Person.new(attributes)
-  #   rescue ActiveAttr::UnknownAttributesError
-  #     Person.new
-  #   end
-  #
-  # @since 0.2.0
-  class UnknownAttributesError < NoMethodError
-    include Error
-  end
-end

data/spec/unit/active_attr/strict_mass_assignment_spec.rb

@@ -1,38 +0,0 @@
-require "spec_helper"
-require "active_attr/strict_mass_assignment"
-
-module ActiveAttr
-  describe StrictMassAssignment, :mass_assignment do
-    subject do
-      model_class.class_eval do
-        include StrictMassAssignment
-      end
-    end
-
-    shared_examples "strict mass assignment method", :strict_mass_assignment_method => true do
-      include_examples "mass assignment method"
-
-      it "raises when assigning an unknown attribute" do
-        expect do
-          mass_assign_attributes(:middle_initial => "J")
-        end.to raise_error UnknownAttributesError, "unknown attribute(s): middle_initial"
-      end
-
-      it "raises when trying to assign a private attribute" do
-        expect do
-          mass_assign_attributes(:middle_name => "J")
-        end.to raise_error UnknownAttributesError, "unknown attribute(s): middle_name"
-      end
-
-      it "raises when assigning multiple unknown attributes with a message referencing both in alphabetical order" do
-        expect do
-          mass_assign_attributes(:middle_name => "J", :middle_initial => "J")
-        end.to raise_error UnknownAttributesError, "unknown attribute(s): middle_initial, middle_name"
-      end
-    end
-
-    describe "#assign_attributes", :assign_attributes, :strict_mass_assignment_method
-    describe "#attributes=", :attributes=, :strict_mass_assignment_method
-    describe "#initialize", :initialize, :strict_mass_assignment_method
-  end
-end