active_attr 0.4.1 → 0.5.0.alpha1

data/spec/functional/active_attr/attributes_spec.rb

@@ -11,12 +11,16 @@ module ActiveAttr
           include Attributes
 
           attribute :parent
+          attribute :redefined, :type => Symbol
         end
       end
 
       let! :child_class do
-        Class.new(parent_class) do
-          attribute :child
+        Class.new(parent_class).tap do |child_class|
+          child_class.instance_eval do
+            attribute :child
+            attribute :redefined, :type => String
+          end
         end
       end
 
@@ -32,7 +36,7 @@ module ActiveAttr
         end
 
         it "add attribute definitions to the child" do
-          child_class.attributes.map(&:name).should include :parent
+          child_class.attribute_names.should include "parent"
         end
       end
 
@@ -48,7 +52,17 @@ module ActiveAttr
         end
 
         it "don't add attribute definitions to the parent" do
-          parent_class.attributes.map(&:name).should_not include :child
+          parent_class.attribute_names.should_not include "child"
+        end
+      end
+
+      context "attributes redefined on the child" do
+        it "redefines the child attribute" do
+          child_class.attributes[:redefined].should == AttributeDefinition.new(:redefined, :type => String)
+        end
+
+        it "does not redefine the parent attribute" do
+          parent_class.attributes[:redefined].should == AttributeDefinition.new(:redefined, :type => Symbol)
         end
       end
     end
@@ -145,7 +159,7 @@ module ActiveAttr
       end
 
       it "sets the attributes" do
-        subject.first_name.should == "Chris"
+        subject.first_name.should eq "Chris"
         subject.last_name.should == "Griego"
       end
     end

data/spec/functional/active_attr/model_spec.rb

@@ -25,7 +25,7 @@ module ActiveAttr
 
     it "reads and writes attributes" do
       subject.first_name = "Chris"
-      subject.first_name.should == "Chris"
+      subject.first_name.should eq "Chris"
       subject.attributes["first_name"].should == "Chris"
     end
 
@@ -41,7 +41,7 @@ module ActiveAttr
       end.read_attribute(:first_name).should == "Chris"
     end
 
-    it "processes mass assignment yielding an initialization block" do
+    it "processes mass assignment before yielding to an initialization block" do
       model_class.new(:first_name => "Chris") do |person|
         person.first_name.should == "Chris"
       end
@@ -55,14 +55,14 @@ module ActiveAttr
       model_class.logger = logger
 
       model_class.logger?.should be_true
-      model_class.logger.should == logger
+      model_class.logger.should eq logger
       subject.logger?.should be_true
       subject.logger.should == logger
     end
 
     it "supports mass assignment with security" do
       person = model_class.new(:first_name => "Chris", :last_name => "Griego")
-      person.first_name.should == "Chris"
+      person.first_name.should eq "Chris"
       person.last_name.should be_nil
     end
 
@@ -83,5 +83,35 @@ module ActiveAttr
     it "supports attribute name translation" do
       model_class.human_attribute_name(:first_name).should == "First name"
     end
+
+    context "attribute defaults" do
+      let :model_class do
+        Class.new do
+          include Model
+
+          attribute :start_date
+          attribute :end_date, :default => lambda { start_date }
+          attribute :age_limit, :default => 21
+        end
+      end
+
+      it "are applied" do
+        subject.age_limit.should == 21
+      end
+
+      it "are overridden by mass assigned attributes" do
+        model_class.new(:age_limit => 18).age_limit.should == 18
+      end
+
+      it "can access mass assigned attributes" do
+        model_class.new(:start_date => Date.today).end_date.should == Date.today
+      end
+
+      it "can access attributes assigned in the initialization block" do
+        model_class.new do |event|
+          event.start_date = Date.today
+        end.end_date.should == Date.today
+      end
+    end
   end
 end

data/spec/functional/active_attr/typecasted_attributes_spec.rb

@@ -0,0 +1,116 @@
+require "spec_helper"
+require "active_attr/typecasted_attributes"
+require "active_attr/mass_assignment"
+
+module ActiveAttr
+  describe TypecastedAttributes do
+    subject { model_class.new }
+
+    let :model_class do
+      Class.new do
+        include TypecastedAttributes
+
+        attribute :typeless
+        attribute :object,    :type => Object
+        attribute :boolean,   :type => Typecasting::Boolean
+        attribute :date,      :type => Date
+        attribute :date_time, :type => DateTime
+        attribute :float,     :type => Float
+        attribute :integer,   :type => Integer
+        attribute :string,    :type => String
+      end
+    end
+
+    context "when assigning nil" do
+      it "a typeless attribute returns nil" do
+        subject.typeless = nil
+        subject.typeless.should be_nil
+      end
+
+      it "an Object attribute returns nil" do
+        subject.object = nil
+        subject.object.should be_nil
+      end
+
+      it "a Boolean attribute returns nil" do
+        subject.boolean = nil
+        subject.boolean.should be_nil
+      end
+
+      it "a Date attribute returns nil" do
+        subject.date = nil
+        subject.date.should be_nil
+      end
+
+      it "a DateTime attribute returns nil" do
+        subject.date_time = nil
+        subject.date_time.should be_nil
+      end
+
+      it "a Float attribute returns nil" do
+        subject.float = nil
+        subject.float.should be_nil
+      end
+
+      it "an Integer attribute returns nil" do
+        subject.integer = nil
+        subject.integer.should be_nil
+      end
+
+      it "a String attribute returns nil" do
+        subject.string = nil
+        subject.string.should be_nil
+      end
+    end
+
+    context "when assigning a valid String" do
+      it "a typeless attribute returns the original String" do
+        value = "test"
+        subject.typeless = value
+        subject.typeless.should equal value
+      end
+
+      it "an Object attribute returns the original String" do
+        value = "test"
+        subject.object = value
+        subject.object.should equal value
+      end
+
+      it "a Boolean attribute returns a Boolean" do
+        subject.boolean = "false"
+        subject.boolean.should eql false
+      end
+
+      it "a Date attribute returns a Date" do
+        subject.date = "2012-01-01"
+        subject.date.should eql Date.new(2012, 1, 1)
+      end
+
+      it "a Date attribute before typecasting returns the original String" do
+        value = "2012-01-01"
+        subject.date = value
+        subject.date_before_type_cast.should equal value
+      end
+
+      it "a DateTime attribute returns a DateTime" do
+        subject.date_time = "2012-01-01"
+        subject.date_time.should eql DateTime.new(2012, 1, 1)
+      end
+
+      it "a Float attribute returns a Float" do
+        subject.float = "1.1"
+        subject.float.should eql 1.1
+      end
+
+      it "an Integer attribute returns an Integer" do
+        subject.integer = "1"
+        subject.integer.should eql 1
+      end
+
+      it "a String attribute returns the String" do
+        subject.string = "1.0"
+        subject.string.should eql "1.0"
+      end
+    end
+  end
+end

data/spec/support/mass_assignment_shared_examples.rb

@@ -17,7 +17,7 @@ shared_examples "mass assignment class", :mass_assignment => true do
   let(:last_name) { "Griego" }
 
   def should_assign_names_to(person)
-    person.first_name.should == first_name
+    person.first_name.should eq first_name
     person.last_name.should == last_name
   end
 end

data/spec/unit/active_attr/attribute_defaults_spec.rb

@@ -0,0 +1,43 @@
+require "spec_helper"
+require "active_attr/attribute_defaults"
+
+module ActiveAttr
+  describe AttributeDefaults do
+    subject { model_class.new }
+
+    let :model_class do
+      Class.new do
+        include InitializationVerifier
+        include AttributeDefaults
+        attribute :first_name, :default => "John"
+        attribute :age, :default => nil
+        attribute :created_at, :default => lambda { Time.now }
+      end
+    end
+
+    describe "#attribute_defaults" do
+      subject { model_class.new.attribute_defaults }
+
+      it { should be_a_kind_of Hash }
+
+      it "includes declared literal string attribute defaults" do
+        subject["first_name"].should == "John"
+      end
+
+      it "includes declared nil attribute defaults" do
+        subject.should include "age"
+        subject['age'].should be_nil
+      end
+
+      it "includes declared dynamic attribute defaults" do
+        subject['created_at'].should be_a_kind_of Time
+      end
+    end
+
+    describe "#initialize" do
+      it "invokes the superclass initializer" do
+        should be_initialized
+      end
+    end
+  end
+end

data/spec/unit/active_attr/attribute_definition_spec.rb

@@ -3,14 +3,14 @@ require "active_attr/attribute_definition"
 
 module ActiveAttr
   describe AttributeDefinition do
-    subject { described_class.new(:amount) }
+    subject { described_class.new(:amount, :default => "default") }
 
     describe "#<=>" do
       it "is nil if the right side is not an #{described_class}" do
         (subject <=> nil).should be_nil
       end
 
-      it "prefers neither when both sides use the same attribute name" do
+      it "prefers neither when both sides use the same attribute name and options" do
         (subject <=> subject).should == 0
       end
 
@@ -31,6 +31,16 @@ module ActiveAttr
       it "returns false when another object is compared" do
         described_class.new(:amount).should_not == Struct.new(:name).new(:amount)
       end
+
+      it "returns false when options differ" do
+        described_class.new(:amount).should_not == described_class.new(:amount, :type => String)
+      end
+    end
+
+    describe "#[]" do
+      it "reads an attribute option" do
+        subject[:default].should == "default"
+      end
     end
 
     describe "#initialize" do
@@ -51,12 +61,6 @@ module ActiveAttr
       end
     end
 
-    describe "#inspect" do
-      it "renders the name" do
-        subject.inspect.should == "amount"
-      end
-    end
-
     describe "#name" do
       it { should respond_to(:name) }
     end

data/spec/unit/active_attr/attributes_spec.rb

@@ -8,7 +8,6 @@ module ActiveAttr
 
     let :model_class do
       Class.new do
-        include InitializationVerifier
         include Attributes
         attribute :first_name
         attribute :last_name
@@ -35,7 +34,7 @@ module ActiveAttr
         end
 
         def initialize(first_name=nil)
-          super
+          super()
           write_attribute(:first_name, first_name)
         end
       end
@@ -53,7 +52,7 @@ module ActiveAttr
 
     describe ".attribute" do
       it "creates an attribute with no options" do
-        model_class.attributes.should include(AttributeDefinition.new(:first_name))
+        model_class.attributes.values.should include(AttributeDefinition.new(:first_name))
       end
 
       it "returns the attribute definition" do
@@ -87,11 +86,30 @@ module ActiveAttr
           attribute :name
         end.should have(1).attributes
       end
+
+      it "redefining an attribute replaces the attribute definition" do
+        klass = Class.new do
+          include Attributes
+          attribute :name, :type => Symbol
+          attribute :name, :type => String
+        end
+
+        klass.should have(1).attributes
+        klass.attributes[:name].should == AttributeDefinition.new(:name, :type => String)
+      end
     end
 
     describe ".attributes" do
       it { model_class.should respond_to(:attributes) }
 
+      it "can access AttributeDefinition with a Symbol" do
+        model_class.attributes[:first_name].should == AttributeDefinition.new(:first_name)
+      end
+
+      it "can access AttributeDefinition with a String" do
+        model_class.attributes['first_name'].should == AttributeDefinition.new(:first_name)
+      end
+
       context "when no attributes exist" do
         it { attributeless.attributes.should be_empty }
       end
@@ -99,7 +117,7 @@ module ActiveAttr
 
     describe ".inspect" do
       it "renders the class name" do
-        model_class.inspect.should match /^Foo\(.*\)$/
+        model_class.inspect.should match(/^Foo\(.*\)$/)
       end
 
       it "renders the attribute names in alphabetical order" do
@@ -153,12 +171,6 @@ module ActiveAttr
       end
     end
 
-    describe "#initialize" do
-      it "invokes the superclass initializer" do
-        should be_initialized
-      end
-    end
-
     describe "#inspect" do
       before { subject.first_name = "Ben" }
 

data/spec/unit/active_attr/mass_assignment_spec.rb

@@ -14,6 +14,7 @@ module ActiveAttr
 
       it "ignores attributes which do not have a writer" do
         person = mass_assign_attributes(:middle_initial => "J")
+        person.instance_eval { @middle_initial ||= nil }
         person.instance_variable_get("@middle_initial").should be_nil
         person.should_not respond_to :middle_initial
       end

data/spec/unit/active_attr/matchers/have_attribute_matcher_spec.rb

@@ -10,14 +10,14 @@ module ActiveAttr
     it { should respond_to(:have_attribute).with(1).argument }
 
     describe "#have_attribute" do
-      subject { dsl.have_attribute(:name) }
+      subject { dsl.have_attribute(:first_name) }
 
-      it "builds a HaveAttributeMatcher with the given attribute name" do
+      it "builds a HaveAttributeMatcher" do
         should be_a_kind_of Matchers::HaveAttributeMatcher
       end
 
       it "uses the given attribute name to construct the matcher" do
-        subject.attribute_name.should == :name
+        subject.send(:attribute_name).should == :first_name
       end
     end
   end
@@ -27,7 +27,9 @@ module ActiveAttr
       let :model_class do
         Class.new do
           include Attributes
-          attribute :name
+          attribute :first_name, :default => "John"
+          attribute :last_name
+          attribute :admin, :default => false
 
           def self.to_s
             "Person"
@@ -36,24 +38,27 @@ module ActiveAttr
       end
 
       subject { positive_matcher }
-      let(:positive_matcher) { described_class.new(:name) }
+      let(:positive_matcher) { described_class.new(:first_name) }
       let(:negative_matcher) { described_class.new(:age) }
+      let(:positive_matcher_with_default) { described_class.new(:first_name).with_default_value_of("John") }
+      let(:positive_matcher_with_false_default) { described_class.new(:admin).with_default_value_of(false) }
+      let(:negative_matcher_with_wrong_default) { described_class.new(:first_name).with_default_value_of("Doe") }
+      let(:negative_matcher_with_default_no_attribute) { described_class.new(:age).with_default_value_of(21) }
+      let(:negative_matcher_with_nil_default) { described_class.new(:first_name).with_default_value_of(nil) }
 
       it { described_class.should respond_to(:new).with(1).argument }
 
-      describe "#attribute_name" do
-        it "returns the value used to initialize the matcher" do
-          subject.attribute_name.should == :name
+      describe "#description" do
+        it "returns a description appropriate to the expectation" do
+          subject.description.should == "have attribute named first_name"
         end
 
-        it "converts the value used to initialize the matcher to a symbol" do
-          described_class.new('name').attribute_name.should == :name
+        it "mentions the default value if set" do
+          positive_matcher_with_default.description.should == %{have attribute named first_name with a default value of "John"}
         end
-      end
 
-      describe "#description" do
-        it "returns a description appropriate to the expectation" do
-          subject.description.should == "have attribute named name"
+        it "mentions the default value if set to false" do
+          positive_matcher_with_false_default.description.should == %{have attribute named admin with a default value of false}
         end
       end
 
@@ -63,6 +68,18 @@ module ActiveAttr
             matcher.matches? model_class
           end.failure_message.should == "Expected Person to have attribute named age"
         end
+
+        it "mentions the default value if set" do
+          negative_matcher_with_wrong_default.tap do |matcher|
+            matcher.matches? model_class
+          end.failure_message.should == %{Expected Person to have attribute named first_name with a default value of "Doe"}
+        end
+
+        it "mentions the default value if set to false" do
+          negative_matcher_with_nil_default.tap do |matcher|
+            matcher.matches? model_class
+          end.failure_message.should == %{Expected Person to have attribute named first_name with a default value of nil}
+        end
       end
 
       describe "#initialize" do
@@ -89,13 +106,75 @@ module ActiveAttr
         it "is false with a model class that does not have the attribute" do
           negative_matcher.matches?(model_class).should be_false
         end
+
+        context "when the matcher specifies a default value" do
+          it "is true with an instance of a model class that has the attribute with the default value" do
+            positive_matcher_with_default.matches?(model_class).should be_true
+          end
+
+          it "is true with a model class that has the attribute with the default value" do
+            positive_matcher_with_default.matches?(model_class).should be_true
+          end
+
+          it "is false with an instance of a model class that does not have the attribute" do
+            negative_matcher_with_default_no_attribute.matches?(model_instance).should be_false
+          end
+
+          it "is false with a model class that does not have the attribute" do
+            negative_matcher_with_default_no_attribute.matches?(model_class).should be_false
+          end
+
+          it "is false with an instance of a model class that has the attribute but not with the specified default value" do
+            negative_matcher_with_wrong_default.matches?(model_instance).should be_false
+          end
+
+          it "is false with a model class that has the attribute but not with the specified default value" do
+            negative_matcher_with_wrong_default.matches?(model_class).should be_false
+          end
+
+          it "is true with an instance of a model class that has the attribute with the default value of false" do
+            positive_matcher_with_false_default.matches?(model_class).should be_true
+          end
+
+          it "is true with a model class that has the attribute with the default value where the default value is false" do
+            positive_matcher_with_false_default.matches?(model_class).should be_true
+          end
+
+          it "is true with an instance of a model class that has the attribute with the default value where the default value is false" do
+            positive_matcher_with_false_default.matches?(model_class).should be_true
+          end
+
+          it "is true with a model class that has the attribute with the default value false" do
+            positive_matcher_with_false_default.matches?(model_class).should be_true
+          end
+
+          it "is false with an instance of a model class that has the attribute but not with the specified default value where the specified default value is nil" do
+            negative_matcher_with_nil_default.matches?(model_instance).should be_false
+          end
+
+          it "is false with a model class that has the attribute but not with the specified default value where the specified default value is nil" do
+            negative_matcher_with_nil_default.matches?(model_class).should be_false
+          end
+        end
       end
 
       describe "#negative_failure_message" do
         it "returns a failure message appropriate to the expectation and subject" do
           positive_matcher.tap do |matcher|
             matcher.matches? model_class
-          end.negative_failure_message.should == "Expected Person to not have attribute named name"
+          end.negative_failure_message.should == "Expected Person to not have attribute named first_name"
+        end
+
+        it "mentions the default value if set" do
+          positive_matcher_with_default.tap do |matcher|
+            matcher.matches? model_class
+          end.negative_failure_message.should == %{Expected Person to not have attribute named first_name with a default value of "John"}
+        end
+
+        it "mentions the default value if set to false" do
+          positive_matcher_with_false_default.tap do |matcher|
+            matcher.matches? model_class
+          end.negative_failure_message.should == %{Expected Person to not have attribute named admin with a default value of false}
         end
       end
     end