action_kit_rest 0.4.4 → 0.4.5

data/spec/lib/action_kit_rest/logger_spec.rb

@@ -1,20 +1,22 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest do
   describe 'logging' do
-    it "should have a logger" do
+    it 'should have a logger' do
       ActionKitRest.respond_to?(:logger).should be_truthy
     end
 
-    it "should be able to log debug methods" do
+    it 'should be able to log debug methods' do
       ActionKitRest.logger.respond_to?(:debug).should be_truthy
     end
 
-    it "should be settable" do
+    it 'should be settable' do
       ActionKitRest.respond_to?(:logger=).should be_truthy
-      log = double()
+      log = double
       ActionKitRest.logger = log
       ActionKitRest.logger.should == log
     end
   end
-end
+end

data/spec/lib/action_kit_rest/page_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::Page do
@@ -16,7 +18,7 @@ describe ActionKitRest::Page do
       subject.connection.configuration.host.should == 'test.com'
     end
 
-    it "should have a client" do
+    it 'should have a client' do
       subject.page.client.should_not be_nil
     end
 
@@ -29,82 +31,80 @@ describe ActionKitRest::Page do
     end
   end
 
-
-  describe "retrieval" do
+  describe 'retrieval' do
     before(:each) do
-      stub_get(request_path).to_return(:body => body, :status => status,
-                                       :headers => {:content_type => "application/json; charset=utf-8"})
+      stub_get(request_path).to_return(body: body, status: status,
+                                       headers: { content_type: 'application/json; charset=utf-8' })
     end
 
-    describe ".list" do
+    describe '.list' do
       let(:status) { 200 }
       let(:body) { fixture('page/collection.json') }
       let(:request_path) { 'page/' }
 
-      it "should allow listing the objects" do
+      it 'should allow listing the objects' do
         pages = subject.page.list
 
         pages.should be_an_instance_of(ActionKitRest::Response::Wrapper)
 
-        pages.each do | obj |
+        pages.each do |obj|
           obj.should be_an_instance_of(Hashie::Mash)
           obj.should respond_to(:goal)
         end
       end
     end
 
-    describe ".page" do
-
+    describe '.page' do
       let(:body) { fixture('page/object.json') }
       let(:request_path) { 'page/1/' }
 
-      describe "success" do
+      describe 'success' do
         let(:status) { 200 }
-        it "should return a single object" do
+        it 'should return a single object' do
           page = subject.page.get(1)
           page.goal.should == 10
         end
       end
 
-      describe "not found" do
+      describe 'not found' do
         let(:status) { 404 }
 
-        it "should return nil" do
-          lambda{ subject.page.get(1).should == nil }.should raise_exception(ActionKitRest::Response::NotFound)
+        it 'should return nil' do
+          -> { subject.page.get(1).should.nil? }.should raise_exception(ActionKitRest::Response::NotFound)
         end
       end
-      
-      describe "error" do
+
+      describe 'error' do
         let(:status) { 400 }
         let(:body) { fixture('error.json') }
-        
-        it "should raise an ak validation response error" do
-          lambda{ subject.page.get(1) }.should raise_exception(ActionKitRest::Response::ValidationError)
-        end  
+
+        it 'should raise an ak validation response error' do
+          -> { subject.page.get(1) }.should raise_exception(ActionKitRest::Response::ValidationError)
+        end
       end
 
       describe 'mailing ID error' do
         let(:status) { 400 }
         let(:body) { '{"errors": {"mailing_id": ["Unable to associate this mailing ID with account."]}}' }
 
-        it "should raise an Invalid AKID response error" do
-          lambda{ subject.page.get(1) }.should raise_exception(ActionKitRest::Response::InvalidAkidError)
+        it 'should raise an Invalid AKID response error' do
+          -> { subject.page.get(1) }.should raise_exception(ActionKitRest::Response::InvalidAkidError)
         end
       end
 
-      describe "an error" do
+      describe 'an error' do
         let(:status) { 500 }
 
-        it "should return nil" do
-          lambda{ subject.page.get(1).should == nil }.should raise_exception(StandardError)
+        it 'should return nil' do
+          -> { subject.page.get(1).should.nil? }.should raise_exception(StandardError)
         end
       end
 
       describe 'try again' do
         let(:status) { 500 }
         let(:body) { '{"error": "Sorry, this request could not be processed. Please try again later."}' }
-        it "should return nil" do
-          lambda{ subject.page.get(1).should == nil }.should raise_exception(ActionKitRest::Response::TryAgainLater)
+        it 'should return nil' do
+          -> { subject.page.get(1).should.nil? }.should raise_exception(ActionKitRest::Response::TryAgainLater)
         end
       end
     end

data/spec/lib/action_kit_rest/pages/event_campaign_page_spec.rb

@@ -1,34 +1,38 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'support/shared_contexts/stub_logger'
 
 describe ActionKitRest::Pages::EventCampaignPage do
-  include_context "stub_logger"
+  include_context 'stub_logger'
 
   describe 'create' do
-    let(:actionkit) { ActionKitRest.new(host: 'test.com')  }
+    let(:actionkit) { ActionKitRest.new(host: 'test.com') }
 
-    let(:event_campaign_title) { "Climate Change Paris 2015" }
-    let(:event_campaign_name) { "climate-change-paris-2015" }
+    let(:event_campaign_title) { 'Climate Change Paris 2015' }
+    let(:event_campaign_name) { 'climate-change-paris-2015' }
 
     before :each do
       stub_request(:post, 'https://test.com/rest/v1/campaign/')
         .with(body: "{\"title\":\"#{event_campaign_title}\",\"name\":\"#{event_campaign_name}\"}")
-        .to_return({status: '200', headers: {location: 'https://test.com/rest/v1/campaign/88/'} })
+        .to_return({ status: '200', headers: { location: 'https://test.com/rest/v1/campaign/88/' } })
 
       stub_request(:get, 'https://test.com/rest/v1/campaign/88/')
-        .to_return({body: fixture('page/campaign.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"}})
+        .to_return({ body: fixture('page/campaign.json'), status: '200',
+                     headers: { content_type: 'application/json; charset=utf-8' } })
 
       stub_request(:post, 'https://test.com/rest/v1/eventcreatepage/')
-        .with(:body => "{\"campaign\":\"/rest/v1/campaign/88/\",\"name\":\"climate-change-paris-2015-event-create\",\"title\":\"Climate Change Paris 2015: event create\",\"tags\":[\"/rest/v1/tag/1/\",\"/rest/v1/tag/5/\"]}")
-        .to_return({status: '200', headers: {location: "https://test.com/rest/v1/eventcreatepage/99/"}})
+        .with(body: '{"campaign":"/rest/v1/campaign/88/","name":"climate-change-paris-2015-event-create","title":"Climate Change Paris 2015: event create","tags":["/rest/v1/tag/1/","/rest/v1/tag/5/"]}')
+        .to_return({ status: '200', headers: { location: 'https://test.com/rest/v1/eventcreatepage/99/' } })
 
       stub_request(:post, 'https://test.com/rest/v1/eventsignuppage/')
-        .with(:body => "{\"campaign\":\"/rest/v1/campaign/88/\",\"name\":\"climate-change-paris-2015-event-signup\",\"title\":\"Climate Change Paris 2015: event signup\",\"tags\":[\"/rest/v1/tag/1/\",\"/rest/v1/tag/5/\"]}")
-        .to_return({status: '200', headers: {location: "https://test.com/rest/v1/eventsignuppage/111/"}})
+        .with(body: '{"campaign":"/rest/v1/campaign/88/","name":"climate-change-paris-2015-event-signup","title":"Climate Change Paris 2015: event signup","tags":["/rest/v1/tag/1/","/rest/v1/tag/5/"]}')
+        .to_return({ status: '200', headers: { location: 'https://test.com/rest/v1/eventsignuppage/111/' } })
     end
 
     it 'should create an event campaign' do
-      resp = actionkit.event_campaign_page.create({title: 'Climate Change Paris 2015', name: 'climate-change-paris-2015', event_pages_tags: ['/rest/v1/tag/1/', '/rest/v1/tag/5/']})
+      resp = actionkit.event_campaign_page.create({ title: 'Climate Change Paris 2015',
+                                                    name: 'climate-change-paris-2015', event_pages_tags: ['/rest/v1/tag/1/', '/rest/v1/tag/5/'] })
       expect(resp.title).to eq event_campaign_title
       expect(resp.name).to eq event_campaign_name
 
@@ -37,7 +41,8 @@ describe ActionKitRest::Pages::EventCampaignPage do
     end
 
     it 'should create associated event and signup create pages' do
-      resp = actionkit.event_campaign_page.create({title: 'Climate Change Paris 2015', name: 'climate-change-paris-2015', event_pages_tags: ['/rest/v1/tag/1/', '/rest/v1/tag/5/']})
+      resp = actionkit.event_campaign_page.create({ title: 'Climate Change Paris 2015',
+                                                    name: 'climate-change-paris-2015', event_pages_tags: ['/rest/v1/tag/1/', '/rest/v1/tag/5/'] })
       expect(resp.event_create_page_name).to eq 'climate-change-paris-2015-event-create'
       expect(resp.event_signup_page_name).to eq 'climate-change-paris-2015-event-signup'
 
@@ -47,18 +52,18 @@ describe ActionKitRest::Pages::EventCampaignPage do
   end
 
   describe 'find' do
-    let(:actionkit) { ActionKitRest.new(host: 'test.com')  }
+    let(:actionkit) { ActionKitRest.new(host: 'test.com') }
 
-    let(:event_campaign_title) { "Climate Change Paris 2015" }
-    let(:event_campaign_name) { "climate-change-paris-2015" }
+    let(:event_campaign_title) { 'Climate Change Paris 2015' }
+    let(:event_campaign_name) { 'climate-change-paris-2015' }
 
     before :each do
       stub_request(:get, 'https://test.com/rest/v1/campaign/?name=climate-change-paris-2015')
-        .to_return(body: fixture('page/find_campaign.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
-      stub_request(:get, "https://test.com/rest/v1/eventcreatepage/?name=climate-change-paris-2015-event-create")
-        .to_return(body: fixture('page/find_event_create.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
-      stub_request(:get, "https://test.com/rest/v1/eventsignuppage/?name=climate-change-paris-2015-event-signup")
-        .to_return(body: fixture('page/find_event_signup.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
+        .to_return(body: fixture('page/find_campaign.json'), status: '200', headers: { content_type: 'application/json; charset=utf-8' })
+      stub_request(:get, 'https://test.com/rest/v1/eventcreatepage/?name=climate-change-paris-2015-event-create')
+        .to_return(body: fixture('page/find_event_create.json'), status: '200', headers: { content_type: 'application/json; charset=utf-8' })
+      stub_request(:get, 'https://test.com/rest/v1/eventsignuppage/?name=climate-change-paris-2015-event-signup')
+        .to_return(body: fixture('page/find_event_signup.json'), status: '200', headers: { content_type: 'application/json; charset=utf-8' })
     end
 
     it 'should retrieve event campaign by name' do

data/spec/lib/action_kit_rest/pages/import_page_spec.rb

@@ -1,27 +1,30 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'support/shared_contexts/stub_logger'
 
 describe ActionKitRest::Pages::ImportPage do
-  include_context "stub_logger"
+  include_context 'stub_logger'
 
-  let(:actionkit) { ActionKitRest.new(host: 'test.com')  }
+  let(:actionkit) { ActionKitRest.new(host: 'test.com') }
   let(:status) { 200 }
 
-  describe "create" do
-    let(:body) { "" }
-    let(:request_body) { {title: "Title", name: "name"}.to_json  }
+  describe 'create' do
+    let(:body) { '' }
+    let(:request_body) { { title: 'Title', name: 'name' }.to_json }
     let(:request_path) { 'importpage/' }
 
     before(:each) do
-      stub_post(request_path).with(body: request_body).to_return(:body => body, :status => status,
-                                                                 :headers => {location: 'https://test.com/rest/v1/importpage/1093/', content_type: "application/json; charset=utf-8"})
+      stub_post(request_path).with(body: request_body).to_return(body: body, status: status,
+                                                                 headers: { location: 'https://test.com/rest/v1/importpage/1093/', content_type: 'application/json; charset=utf-8' })
 
-      stub_request(:get, "https://test.com/rest/v1/importpage/1093/").to_return(body: fixture('page/object.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, 'https://test.com/rest/v1/importpage/1093/').to_return(body: fixture('page/object.json'),
+                                                                                status: '200', headers: { content_type: 'application/json; charset=utf-8' })
     end
 
-    describe ".create" do
-      it "should allow creation" do
-        resp = actionkit.import_page.create(title: "Title", name: "name")
+    describe '.create' do
+      it 'should allow creation' do
+        resp = actionkit.import_page.create(title: 'Title', name: 'name')
         expect(resp.title).to eq 'Demand a Sustainable USDA'
       end
     end
@@ -29,21 +32,22 @@ describe ActionKitRest::Pages::ImportPage do
 
   describe 'update' do
     let(:body) { '' }
-    let(:request_body) { {title: "Title", name: "name"}.to_json  }
+    let(:request_body) { { title: 'Title', name: 'name' }.to_json }
     let(:request_path) { 'importpage/1093/' }
 
     before(:each) do
-      stub_put(request_path).with(body: request_body).to_return(:body => body, :status => status,
-                                                                 :headers => { content_type: "application/json; charset=utf-8"})
+      stub_put(request_path).with(body: request_body).to_return(body: body, status: status,
+                                                                headers: { content_type: 'application/json; charset=utf-8' })
 
-      stub_request(:get, "https://test.com/rest/v1/importpage/1093/").to_return(body: fixture('page/object.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, 'https://test.com/rest/v1/importpage/1093/').to_return(body: fixture('page/object.json'),
+                                                                                status: '200', headers: { content_type: 'application/json; charset=utf-8' })
     end
 
     describe '.update' do
       it 'should allow updates' do
-        resp = actionkit.import_page.update('1093', title: "Title", name: "name")
+        resp = actionkit.import_page.update('1093', title: 'Title', name: 'name')
         expect(resp.title).to eq 'Demand a Sustainable USDA'
       end
     end
   end
-end
+end

data/spec/lib/action_kit_rest/response/collection_spec.rb

@@ -1,26 +1,28 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe ActionKitRest::Response::Collection  do
-  let(:meta) { double() }
-  let(:objects) { double() }
+describe ActionKitRest::Response::Collection do
+  let(:meta) { double }
+  let(:objects) { double }
   subject { ActionKitRest::Response::Collection.new(meta, objects) }
 
   describe 'initialization' do
     it 'should set meta and objects' do
-      subject.meta.should == meta
-      subject.objects.should == objects
+      expect(subject.meta).to eq(meta)
+      expect(subject.objects).to eq(objects)
     end
   end
 
   describe 'each' do
     let(:item1) { double }
     let(:item2) { double }
-    let(:objects) { [ item1, item2 ] }
+    let(:objects) { [item1, item2] }
 
-    it "should return all collection items" do
-      subject.count.should == 2
-      subject.any? { |i| i == item1 }
-      subject.any? { |i| i == item2 }
+    it 'should return all collection items' do
+      expect(subject.count).to eq(2)
+      expect(subject.any? { |i| i == item1 }).to be_truthy
+      expect(subject.any? { |i| i == item2 }).to be_truthy
     end
   end
-end
+end

data/spec/lib/action_kit_rest/response/validation_error_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::Response::ValidationError do
@@ -6,8 +8,8 @@ describe ActionKitRest::Response::ValidationError do
 
     context 'with a normal URL and body' do
       let(:url) { 'https://actionkit.example.com/rest/v1/page/1' }
-      let(:errors) { {'zip' => 'invalid zip code'} }
-      let(:body) { {errors: errors}.to_json }
+      let(:errors) { { 'zip' => 'invalid zip code' } }
+      let(:body) { { errors: errors }.to_json }
 
       it 'should put information in the string' do
         expect(subject.to_s).to eq "ActionKitRest::Response::ValidationError \n url: #{url} \n body: #{body} \n errors: #{errors.inspect}"
@@ -16,8 +18,8 @@ describe ActionKitRest::Response::ValidationError do
 
     context 'with special characters in the body' do
       let(:url) { 'https://actionkit.example.com/rest/v1/page/1' }
-      let(:errors) { {'zip' => '☃'} }
-      let(:body) { {errors: errors}.to_json }
+      let(:errors) { { 'zip' => '☃' } }
+      let(:body) { { errors: errors }.to_json }
 
       it 'should put information in the string' do
         expect(subject.to_s).to eq "ActionKitRest::Response::ValidationError \n url: #{url} \n body: #{body} \n errors: #{errors.inspect}"

data/spec/lib/action_kit_rest/response/wrapper_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::Response::Wrapper do
   describe 'initialization' do
     it "should be kind 'object' for objects" do
       body = double
-      response = double(:body => body)
+      response = double(body: body)
 
       wrapper = ActionKitRest::Response::Wrapper.new(response)
 
@@ -13,8 +15,8 @@ describe ActionKitRest::Response::Wrapper do
     end
 
     it "should be kind 'collection' for collections" do
-      body = double(:meta => '', :objects => [])
-      response = double(:body => body)
+      body = double(meta: '', objects: [])
+      response = double(body: body)
 
       wrapper = ActionKitRest::Response::Wrapper.new(response)
 
@@ -22,4 +24,4 @@ describe ActionKitRest::Response::Wrapper do
       wrapper.collection?.should be_truthy
     end
   end
-end
+end

data/spec/lib/action_kit_rest/user_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::User do
@@ -11,16 +13,16 @@ describe ActionKitRest::User do
 
   subject { ActionKitRest.new(host: 'test.com') }
 
-  describe "retrieval" do
+  describe 'retrieval' do
     let(:request_path) { 'user/1/' }
 
     context 'without basic auth' do
       before(:each) do
-        stub_get(request_path).to_return(:body => body, :status => status,
-                                         :headers => {:content_type => "application/json; charset=utf-8"})
+        stub_get(request_path).to_return(body: body, status: status,
+                                         headers: { content_type: 'application/json; charset=utf-8' })
       end
 
-      describe ".get" do
+      describe '.get' do
         let(:status) { 200 }
 
         context 'without phones' do
@@ -36,9 +38,9 @@ describe ActionKitRest::User do
           let(:phone_body) { fixture('phone/object.json') }
 
           it 'should include phones' do
-            stub_get('phone/?user=1').to_return(:body => phone_body, :status => 200)
+            stub_get('phone/?user=1').to_return(body: phone_body, status: 200)
             expect(subject.user.get(1).phones.count).to eq 3
-            expect(subject.user.get(1).phones.map(&:phone)).to match_array(['7755555555', '7755555577', '310-310-3310'])
+            expect(subject.user.get(1).phones.map(&:phone)).to match_array(%w[7755555555 7755555577 310-310-3310])
           end
         end
       end
@@ -47,7 +49,7 @@ describe ActionKitRest::User do
         let(:body) { '' }
         let(:status) { 404 }
 
-        it "should raise an exception" do
+        it 'should raise an exception' do
           expect { subject.user.get(1) }.to raise_error(ActionKitRest::Response::NotFound)
         end
       end
@@ -59,8 +61,8 @@ describe ActionKitRest::User do
       subject { ActionKitRest.new(host: 'test.com', username: 'alice', password: 'somesecret') }
 
       before(:each) do
-        stub_get(request_path).with(basic_auth: ['alice', 'somesecret'])
-          .to_return(body: body, status: 200, headers: {content_type: "application/json; charset=utf-8"})
+        stub_get(request_path).with(basic_auth: %w[alice somesecret])
+                              .to_return(body: body, status: 200, headers: { content_type: 'application/json; charset=utf-8' })
       end
 
       it 'should return a user object' do