action_kit_rest 0.4.4 → 0.4.5

data/lib/action_kit_rest/language.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Language < Base
     def base_path
@@ -9,4 +11,4 @@ module ActionKitRest
       response.obj.first
     end
   end
-end
+end

data/lib/action_kit_rest/list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class List < Base
     def base_path
@@ -9,4 +11,4 @@ module ActionKitRest
       response.obj.first
     end
   end
-end
+end

data/lib/action_kit_rest/page.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Page < Vertebrae::Model
     def list
-      client.get_request("page/")
+      client.get_request('page/')
     end
 
     def get(id)
       client.get_request("page/#{id}/")
     end
   end
-end
+end

data/lib/action_kit_rest/pages/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Pages
     class Base < ActionKitRest::Base
@@ -6,15 +8,12 @@ module ActionKitRest
         response = list(name: name)
         response.obj.first
       end
-      
+
       def find_or_create(params)
         page = find(params[:name])
-        if page.blank?
-          page = create(params)
-        end
+        page = create(params) if page.blank?
         page
       end
     end
   end
 end
-

data/lib/action_kit_rest/pages/donation_page.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Pages
     class DonationPage < ActionKitRest::Pages::Base
@@ -6,4 +8,4 @@ module ActionKitRest
       end
     end
   end
-end
+end

data/lib/action_kit_rest/pages/event_campaign_page.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Pages
     class EventCampaignPage < ActionKitRest::Pages::Base
@@ -41,7 +43,7 @@ module ActionKitRest
 
       def create_event_create_page(event_campaign, tags)
         params = event_create_page_params(event_campaign, tags)
-        response = client.post_json_request('eventcreatepage/', params)
+        _response = client.post_json_request('eventcreatepage/', params)
 
         params[:name]
       end
@@ -57,7 +59,7 @@ module ActionKitRest
 
       def create_event_signup_page(event_campaign, tags)
         params = event_signup_page_params(event_campaign, tags)
-        response = client.post_json_request('eventsignuppage/', params)
+        _response = client.post_json_request('eventsignuppage/', params)
 
         params[:name]
       end

data/lib/action_kit_rest/pages/import_page.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Pages
     class ImportPage < ActionKitRest::Pages::Base
@@ -6,4 +8,4 @@ module ActionKitRest
       end
     end
   end
-end
+end

data/lib/action_kit_rest/pages/signup_page.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Pages
     class SignupPage < ActionKitRest::Pages::Base
@@ -6,4 +8,4 @@ module ActionKitRest
       end
     end
   end
-end
+end

data/lib/action_kit_rest/pages/unsubscribe_page.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Pages
     class UnsubscribePage < ActionKitRest::Pages::Base
@@ -6,4 +8,4 @@ module ActionKitRest
       end
     end
   end
-end
+end

data/lib/action_kit_rest/phone.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Phone < Base
     def base_path

data/lib/action_kit_rest/railties.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Railties < ::Rails::Railtie
     initializer 'Rails logger' do
       ActionKitRest.logger = Rails.logger
     end
   end
-end
+end

data/lib/action_kit_rest/response/collection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A class responsible for proxing to faraday response &
 # or a pagination collection.
 module ActionKitRest
@@ -5,9 +7,7 @@ module ActionKitRest
     class Collection
       include Enumerable
 
-      attr_reader :meta
-      attr_reader :objects
-
+      attr_reader :meta, :objects
 
       def initialize(meta, objects)
         @meta = meta
@@ -15,7 +15,7 @@ module ActionKitRest
       end
 
       def each(&block)
-        # todo handle pagination somehow!
+        # TODO: handle pagination somehow!
         objects.each do |o|
           block.call(o)
         end

data/lib/action_kit_rest/response/raise_error.rb

@@ -1,43 +1,46 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Response
     class RaiseError < Faraday::Response::Middleware
-
       def on_complete(response)
         status_code = response[:status].to_i
         if (400...600).include? status_code
           if status_code == 400
             response_body = response[:body]
-            if JSON.parse(response_body)['errors'] == {'mailing_id' => ['Unable to associate this mailing ID with account.']}
+            if JSON.parse(response_body)['errors'] == { 'mailing_id' => ['Unable to associate this mailing ID with account.'] }
               raise ActionKitRest::Response::InvalidAkidError.new(url: response[:url].to_s, body: response_body)
             else
               raise ActionKitRest::Response::ValidationError.new(url: response[:url].to_s, body: response_body)
             end
           elsif status_code == 404
-            raise ActionKitRest::Response::NotFound.new(response[:url].to_s)
+            raise ActionKitRest::Response::NotFound, response[:url].to_s
           elsif status_code == 401
-            raise ActionKitRest::Response::Unauthorized.new(response[:url].to_s)
-          elsif status_code == 500 && response[:body] =~ /\"error\"/
+            raise ActionKitRest::Response::Unauthorized, response[:url].to_s
+          elsif status_code == 500 && response[:body] =~ /"error"/
             error_hsh = JSON.parse(response[:body])
             error_message = error_hsh['error']
 
             if error_message == 'Sorry, this request could not be processed. Please try again later.'
-              raise ActionKitRest::Response::TryAgainLater.new(error_message(response))
+              raise ActionKitRest::Response::TryAgainLater, error_message(response)
             else
-              raise StandardError.new(error_message(response))
+              raise StandardError, error_message(response)
             end
           else
-            raise StandardError.new(error_message(response))
+            raise StandardError, error_message(response)
           end
         end
       end
 
       def error_message(response)
-        "#{response[:method].to_s.upcase} #{response[:url].to_s}: #{response[:status]} \n\n #{response[:body] if response[:body]}"
+        "#{response[:method].to_s.upcase} #{response[:url]}: #{response[:status]} \n\n #{response[:body]}"
       end
     end
 
-    class TryAgainLater < StandardError ; end
-    class NotFound < StandardError ; end
-    class Unauthorized < StandardError ; end
+    class TryAgainLater < StandardError; end
+
+    class NotFound < StandardError; end
+
+    class Unauthorized < StandardError; end
   end
 end

data/lib/action_kit_rest/response/validation_error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Response
     class ValidationError < StandardError
@@ -11,14 +13,12 @@ module ActionKitRest
       end
 
       def to_s
-        begin
-          "#{super()} \n url: #{url} \n body: #{body} \n errors: #{errors}"
-        rescue Encoding::CompatibilityError
-          # Something went gravely wrong trying to construct the error message, so give up on the extra info
-          # and just raise the name of the exception.
-          # This will let us at least raise with a backtrace.
-          super
-        end
+        "#{super()} \n url: #{url} \n body: #{body} \n errors: #{errors}"
+      rescue Encoding::CompatibilityError
+        # Something went gravely wrong trying to construct the error message, so give up on the extra info
+        # and just raise the name of the exception.
+        # This will let us at least raise with a backtrace.
+        super
       end
     end
 

data/lib/action_kit_rest/response/wrapper.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Response
     class Wrapper
       include Enumerable
       extend Forwardable
 
-      attr_reader :response
-      attr_reader :kind
-      attr_reader :obj
+      attr_reader :response, :kind, :obj
 
       def_delegators :body, :empty?, :size, :include?, :length, :to_a, :first, :flatten, :include?, :keys, :[]
 
       def initialize(response)
-        @response    = response
+        @response = response
 
         if response.body.respond_to?(:meta) && response.body.meta
           @kind = :collection
@@ -42,7 +42,7 @@ module ActionKitRest
 
       # Response raw body
       def body
-        @body ? @body : response.body
+        @body || response.body
       end
 
       # Response status
@@ -70,10 +70,10 @@ module ActionKitRest
       # Convert any key to string before calling.
       #
       def [](key)
-        if self.body.is_a?(Array)
-          self.body[key]
+        if body.is_a?(Array)
+          body[key]
         else
-          self.body.send(:"#{key}")
+          body.send(:"#{key}")
         end
       end
 
@@ -112,9 +112,9 @@ module ActionKitRest
             block.call(o)
           end
         else
-          raise("can only iterate over collections")
+          raise('can only iterate over collections')
         end
       end
     end
   end
-end
+end

data/lib/action_kit_rest/tag.rb

@@ -1,20 +1,20 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Tag < Base
     def base_path
       'tag'
     end
-    
+
     def find(name)
       response = list(name: name)
       response.obj.first
     end
-    
+
     def find_or_create(name)
       tag = find(name)
-      if tag.blank?
-        tag = create(name: name)
-      end
+      tag = create(name: name) if tag.blank?
       tag
     end
   end
-end
+end

data/lib/action_kit_rest/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class User < Base
     def base_path
@@ -17,4 +19,4 @@ module ActionKitRest
       user
     end
   end
-end
+end

data/lib/action_kit_rest/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module VERSION
     MAJOR = 0
     MINOR = 4
-    PATCH = 4
+    PATCH = 5
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')

data/spec/lib/action_kit_rest/actions/event_create_action_spec.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::Actions::EventCreateAction do
   describe '#get' do
-    let(:actionkit) { ActionKitRest.new(host: 'test.com')  }
+    let(:actionkit) { ActionKitRest.new(host: 'test.com') }
 
     before :each do
-      stub_request(:get, "https://test.com/rest/v1/eventcreateaction/123/")
-        .to_return(body: fixture('action/event_create_action.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, 'https://test.com/rest/v1/eventcreateaction/123/')
+        .to_return(body: fixture('action/event_create_action.json'), status: '200', headers: { content_type: 'application/json; charset=utf-8' })
     end
 
     it 'should retrieve eventcreateaction and aggregate parsed event and user IDs' do
       ak_event_create_action = actionkit.event_create_action.get('123')
 
-      expect(ak_event_create_action.id).to eq(12345)
+      expect(ak_event_create_action.id).to eq(12_345)
       expect(ak_event_create_action.event_id).to eq('999')
       expect(ak_event_create_action.user_id).to eq('112233')
     end

data/spec/lib/action_kit_rest/actions/event_signup_action_spec.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::Actions::EventSignupAction do
   describe '#get' do
-    let(:actionkit) { ActionKitRest.new(host: 'test.com')  }
+    let(:actionkit) { ActionKitRest.new(host: 'test.com') }
 
     before :each do
-      stub_request(:get, "https://test.com/rest/v1/eventsignupaction/54321/")
-        .to_return(body: fixture('action/event_signup_action.json'), status: '200', headers: {content_type: "application/json; charset=utf-8"})
+      stub_request(:get, 'https://test.com/rest/v1/eventsignupaction/54321/')
+        .to_return(body: fixture('action/event_signup_action.json'), status: '200', headers: { content_type: 'application/json; charset=utf-8' })
     end
 
     it 'should retrieve eventsignupaction and aggregate parsed event sign-up and user IDs' do
       ak_event_signup_action = actionkit.event_signup_action.get('54321')
 
-      expect(ak_event_signup_action.id).to eq(54321)
+      expect(ak_event_signup_action.id).to eq(54_321)
       expect(ak_event_signup_action.event_signup_id).to eq('888')
       expect(ak_event_signup_action.user_id).to eq('111')
     end

data/spec/lib/action_kit_rest/allowed_user_field_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::AllowedUserField do
   let(:status) { 200 }
-  let(:standard_headers) { {content_type: "application/json; charset=utf-8"} }
+  let(:standard_headers) { { content_type: 'application/json; charset=utf-8' } }
 
   subject { ActionKitRest.new(host: 'test.com', username: 'alice', password: 'somesecret') }
 
@@ -19,7 +21,7 @@ describe ActionKitRest::AllowedUserField do
     let(:response_body) { fixture('allowed_user_field/list.json') }
 
     before :each do
-      stub_get(request_path).with(basic_auth: ['alice', 'somesecret'])
+      stub_get(request_path).with(basic_auth: %w[alice somesecret])
                             .to_return(body: response_body,
                                        status: status,
                                        headers: standard_headers)
@@ -38,7 +40,7 @@ describe ActionKitRest::AllowedUserField do
     let(:response_body) { fixture('allowed_user_field/list_filtered.json') }
 
     before :each do
-      stub_get(request_path).with(basic_auth: ['alice', 'somesecret'])
+      stub_get(request_path).with(basic_auth: %w[alice somesecret])
                             .to_return(body: response_body,
                                        status: status,
                                        headers: standard_headers)
@@ -52,26 +54,26 @@ describe ActionKitRest::AllowedUserField do
 
   describe '#create' do
     let(:create_request_path) { 'alloweduserfield/' }
-    let(:create_request_body) { {name: 'foo'}.to_json }
+    let(:create_request_body) { { name: 'foo' }.to_json }
     let(:create_status) { 201 }
     let(:created_url) { 'https://test.com/rest/v1/alloweduserfield/foo/' }
     let(:get_request_path) { 'alloweduserfield/foo/' }
     let(:get_response_body) { fixture('allowed_user_field/get.json') }
 
     before :each do
-      stub_post(create_request_path).with(basic_auth: ['alice', 'somesecret'],
+      stub_post(create_request_path).with(basic_auth: %w[alice somesecret],
                                           body: create_request_body)
                                     .to_return(status: create_status,
                                                headers: standard_headers.merge(Location: created_url))
 
-      stub_get(get_request_path).with(basic_auth: ['alice', 'somesecret'])
+      stub_get(get_request_path).with(basic_auth: %w[alice somesecret])
                                 .to_return(body: get_response_body,
                                            status: status,
                                            headers: standard_headers)
     end
 
     it 'should POST to the endpoint, then do a GET on the created object' do
-      field = subject.allowed_user_field.create({name: 'foo'})
+      field = subject.allowed_user_field.create({ name: 'foo' })
       expect(field.display_name).to eq 'Foo'
     end
   end