action_args 1.5.4 → 2.0.0

data/spec/controllers/hooks_spec.rb

@@ -1,31 +0,0 @@
-require 'spec_helper'
-
-describe BooksController, 'action hooks' do
-  before do
-    Book.delete_all
-    @book = Book.create! title: 'Head First ActionArgs'
-    get :show, id: @book.id
-  end
-
-  describe 'before_action' do
-    context 'via Symbol' do
-      subject { assigns :book }
-      it { should == @book }
-    end
-
-    context 'via String' do
-      subject { assigns :string_filter_executed }
-      it { should be_true }
-    end
-
-    context 'via Proc' do
-      subject { assigns :proc_filter_executed }
-      it { should be_true }
-    end
-  end
-
-  describe 'around_action' do
-    subject { assigns :elapsed_time }
-    it { should be }
-  end
-end

data/spec/controllers/kwargs_controller_spec.rb

@@ -1,34 +0,0 @@
-require 'spec_helper'
-
-describe KwBooksController do
-  describe 'GET index (having an optional parameter)' do
-    context 'without giving any kw parameter (not even giving :required one)' do
-      if ActionPack::VERSION::MAJOR >= 4
-        it { expect { get :index }.to raise_error ActionController::BadRequest }
-      else
-        it { expect { get :index }.to raise_error ArgumentError }
-      end
-    end
-
-    context 'without giving any optional kw parameter' do
-      before { get :index, author_name: 'nari' }
-      its(:response) { should be_success }
-    end
-
-    context 'with kw parameter defaults to non-nil value' do
-      before { get :index, author_name: 'nari', page: 3 }
-      subject { eval response.body }
-      its([:author_name]) { should == 'nari' }
-      its([:page]) { should == '3' }
-      its([:q]) { should == nil }
-    end
-
-    context 'with kw parameter defaults to nil' do
-      before { get :index, author_name: 'nari', q: 'Rails' }
-      subject { eval response.body }
-      its([:author_name]) { should == 'nari' }
-      its([:page]) { should == '1' }
-      its([:q]) { should == 'Rails' }
-    end
-  end
-end if RUBY_VERSION >= '2'

data/spec/controllers/kwargs_keyreq_controller_spec.rb

@@ -1,34 +0,0 @@
-require 'spec_helper'
-
-describe KwKeyreqBooksController do
-  describe 'GET index (having an optional parameter)' do
-    context 'without giving any kw parameter (not even giving :required one)' do
-      if ActionPack::VERSION::MAJOR >= 4
-        it { expect { get :index }.to raise_error ActionController::BadRequest }
-      else
-        it { expect { get :index }.to raise_error ArgumentError }
-      end
-    end
-
-    context 'without giving any kw parameter' do
-      before { get :index, author_name: 'nari' }
-      its(:response) { should be_success }
-    end
-
-    context 'with kw parameter defaults to non-nil value' do
-      before { get :index, author_name: 'nari', page: 3 }
-      subject { eval response.body }
-      its([:author_name]) { should == 'nari' }
-      its([:page]) { should == '3' }
-      its([:q]) { should == nil }
-    end
-
-    context 'with kw parameter defaults to nil' do
-      before { get :index, author_name: 'nari', q: 'Rails' }
-      subject { eval response.body }
-      its([:author_name]) { should == 'nari' }
-      its([:page]) { should == '1' }
-      its([:q]) { should == 'Rails' }
-    end
-  end
-end if RUBY_VERSION >= '2.1'

data/spec/controllers/ordinal_controller_spec.rb

@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-describe AuthorsController do
-  describe 'GET show' do
-    let(:matz) { Author.create! name: 'Matz' }
-    it 'assigns the requested author as @author' do
-      get :show, :id => matz.id
-      assigns(:author).should eq(matz)
-    end
-  end
-end

data/spec/controllers/strong_parameters_spec.rb

@@ -1,34 +0,0 @@
-require 'spec_helper'
-
-if Rails::VERSION::MAJOR >= 4
-  describe StoresController do
-    describe 'GET show' do
-      let(:tatsu_zine) { Store.create! name: 'Tatsu-zine' }
-      before { get :show, :id => tatsu_zine.id }
-      subject { assigns :store }
-      it { should == tatsu_zine }
-    end
-
-    describe 'POST create' do
-      it { expect { post :create, :store => {name: 'Tatsu-zine', url: 'http://tatsu-zine.com'} }.to change(Store, :count).by(1) }
-    end
-  end
-
-  describe Admin::BooksController do
-    context "this controller doesn't permit price of new book" do
-      describe 'POST create' do
-        before { post :create, :book => {title: 'naruhoUnix', price: 30} }
-
-        it 'should not save price of the book' do
-          expect(Book.last.price).to be_nil
-        end
-      end
-    end
-  end
-
-  describe Admin::AccountsController do
-    describe 'POST create' do
-      it { expect { post :create, :admin_account => {name: 'amatsuda'} }.to change(Admin::Account, :count).by(1) }
-    end
-  end
-end

data/spec/mailers/action_mailer_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe UserMailer do
-  describe '#send_email_without_args' do
-    it "should not raise NameError: undefined local variable or method `params' for ..." do
-      expect{ UserMailer.send_email_without_args }.to_not raise_error
-    end
-  end
-end

data/spec/params_handler/params_handler_spec.rb

@@ -1,218 +0,0 @@
-require 'spec_helper'
-
-describe ActionArgs::ParamsHandler do
-  # ActionArgs::ParamsHandler.extract_method_arguments_from_params(method_parameters, params)
-  describe 'extract_method_arguments_from_params' do
-    let(:params) { {a: '1', b: '2'} }
-    subject { ActionArgs::ParamsHandler.extract_method_arguments_from_params method(:m).parameters, params }
-    context 'no parameters' do
-      before do
-        def m() end
-      end
-      it { should == [] }
-    end
-
-    context '1 req' do
-      before do
-        def m(a) end
-      end
-      it { should == ['1'] }
-    end
-
-    context '2 reqs' do
-      before do
-        def m(a, b) end
-      end
-      it { should == ['1', '2'] }
-    end
-
-    context '1 opt with value' do
-      before do
-        def m(a = 'a') end
-      end
-      it { should == ['1'] }
-    end
-
-    context '1 opt without value' do
-      before do
-        def m(x = 'x') end
-      end
-      it { should == [] }
-    end
-
-    context 'req, opt with value' do
-      before do
-        def m(a, b = 'b') end
-      end
-      it { should == ['1', '2'] }
-    end
-
-    context 'req, opt without value' do
-      before do
-        def m(a, x = 'x') end
-      end
-      it { should == ['1'] }
-    end
-
-    context 'opt with value, opt with value' do
-      before do
-        def m(a = 'a', b = 'b') end
-      end
-      it { should == ['1', '2'] }
-    end
-
-    context 'opt with value, opt without value' do
-      before do
-        def m(a = 'a', x = 'x') end
-      end
-      it { should == ['1'] }
-    end
-
-    context 'opt without value, opt with value' do
-      before do
-        def m(x = 'x', a = 'a') end
-      end
-      it { should == [nil, '1'] }
-    end
-
-    context 'opt without value, opt without value' do
-      before do
-        def m(x = 'x', y = 'y') end
-      end
-      it { should == [] }
-    end
-
-    context 'opt with value, req' do
-      before do
-        def m(a = 'a', b) end
-      end
-      it { should == ['1', '2'] }
-    end
-
-    context 'opt without value, req' do
-      before do
-        def m(x = 'x', a) end
-      end
-      it { should == ['1'] }
-    end
-
-    context 'opt without value, opt with value, req' do
-      before do
-        def m(x = 'x', b = 'b', a) end
-      end
-      it { should == [nil, '2', '1'] }
-    end
-
-    context 'opt with value, opt without value, req' do
-      before do
-        def m(b = 'b', x = 'x', a) end
-      end
-      it { should == ['2', '1'] }
-    end
-
-    if Rails::VERSION::MAJOR >= 4
-      context 'req without a value' do
-        before do
-          def m(x) end
-        end
-        it { expect { subject }.to raise_error ActionController::BadRequest }
-      end
-    end
-
-    if RUBY_VERSION >= '2'
-      eval <<-KWARGS_TEST
-        context 'key' do
-          before do
-            def m(a: nil) end
-          end
-          it { should == [a: '1'] }
-        end
-
-        context 'key, key without value' do
-          before do
-            def m(a: nil, x: 'x') end
-          end
-          it { should == [a: '1'] }
-        end
-      KWARGS_TEST
-    end
-
-    if RUBY_VERSION >= '2.1'
-      eval <<-KWARGS_KEYREQ_TEST
-        context 'keyreq' do
-          before do
-            def m(a:) end
-          end
-          it { should == [a: '1'] }
-        end
-
-        if Rails::VERSION::MAJOR >= 4
-          context 'keyreq, keyreq without value' do
-            before do
-              def m(a:, x:) end
-            end
-            it { expect { subject }.to raise_error ::ActionController::BadRequest }
-          end
-        end
-      KWARGS_KEYREQ_TEST
-    end
-  end
-
-  if defined? ActionController::StrongParameters
-    # strengthen_params!(controller_class, method_parameters, params)
-    describe 'strengthen_params!' do
-      before { ActionArgs::ParamsHandler.strengthen_params! controller, controller.new.method(:a).parameters, params }
-      let(:params) { ActionController::Parameters.new(x: '1', y: '2', foo: {a: 'a', b: 'b'}, bar: {a: 'a', b: 'b'}, baz: {a: 'a', b: 'b'}, hoge: {a: 'a', b: 'b'}, fuga: {a: 'a', b: 'b'}) }
-
-      context 'requiring via :req, permitting all scalars' do
-        let(:controller) { FooController ||= Class.new(ApplicationController) { permits :a, :b; def a(foo) end } }
-        subject { params[:foo] }
-        it { should be_permitted }
-        its([:a]) { should be }
-        its([:b]) { should be }
-      end
-
-      context 'requiring via :req, not permitting all scalars' do
-        let(:controller) { BarController ||= Class.new(ApplicationController) { permits :a; def a(bar, x = 'x') end } }
-        subject { params[:bar] }
-        it { should be_permitted }
-        its([:a]) { should be }
-        its([:b]) { should_not be }
-      end
-
-      context 'requiring via :req, not permitting any scalars' do
-        let(:controller) { BazController ||= Class.new(ApplicationController) { def a(baz, aho = 'omg') end } }
-        subject { params[:baz] }
-        it { should_not be_permitted }
-      end
-
-      context 'requiring via :opt, permitting all scalars' do
-        let(:controller) { HogeController ||= Class.new(ApplicationController) { permits :a, :b; def a(hoge = {}) end } }
-        subject { params[:hoge] }
-        it { should be_permitted }
-        its([:a]) { should be }
-        its([:b]) { should be }
-      end
-
-      if RUBY_VERSION >= '2'
-        eval <<-KWARGS_TEST
-          context 'requiring via :key, permitting all scalars' do
-            let(:controller) { FugaController ||= Class.new(ApplicationController) { permits :a, :b; def a(fuga: {}) end } }
-            subject { params[:fuga] }
-            it { should be_permitted }
-            its([:a]) { should be }
-            its([:b]) { should be }
-          end
-        KWARGS_TEST
-      end
-
-      describe '"model_name" option' do
-        let(:controller) { PiyoController ||= Class.new(ApplicationController) { permits :a, :b, model_name: 'Foo'; def a(foo) end } }
-        subject { params[:foo] }
-        it { should be_permitted }
-        its([:a]) { should be }
-        its([:b]) { should be }
-      end
-    end
-  end
-end