action_args 1.5.4 → 2.0.0

data/test/controllers/action_args_controller_test.rb

@@ -0,0 +1,43 @@
+require 'test_helper'
+
+class BooksControllerTest < ActionController::TestCase
+  sub_test_case 'GET index (having an optional parameter)' do
+    setup do
+      @books = []
+      Book.delete_all
+      100.times {|i| @books << Book.create!(title: 'book'+i.to_s) }
+    end
+
+    test 'without page parameter' do
+      get :index
+      assert 200, response.code
+      assert_equal @books[0..9], assigns(:books)
+    end
+
+    test 'with page parameter' do
+      get :index, page: 3
+      assert 200, response.code
+      assert_equal @books[20..29], assigns(:books)
+    end
+
+    test 'first param is nil and second is not nil' do
+      rhg = Book.create! title: 'RHG'
+      Book.create! title: 'AWDwR'
+      get :index, q: 'RH'
+      assert_equal [rhg], assigns(:books)
+    end
+  end
+
+  test 'GET show' do
+    rhg = Book.create! title: 'RHG'
+    get :show, :id => rhg.id
+    assert_equal rhg, assigns(:book)
+  end
+
+  test 'POST create' do
+    Book.create! title: 'RHG'
+    books_count_was = Book.count
+    post :create, :book => {title: 'AWDwR', price: 24}
+    assert_equal 1, Book.count - books_count_was
+  end
+end

data/test/controllers/hooks_test.rb

@@ -0,0 +1,27 @@
+require 'test_helper'
+
+class BooksControllerTest < ActionController::TestCase
+  setup do
+    Book.delete_all
+    @book = Book.create! title: 'Head First ActionArgs'
+    get :show, id: @book.id
+  end
+
+  sub_test_case 'before_action' do
+    test 'via Symbol' do
+      assert_equal @book, assigns(:book)
+    end
+
+    test 'via String' do
+      assert assigns(:string_filter_executed)
+    end
+
+    test 'via Proc' do
+      assert assigns(:proc_filter_executed)
+    end
+  end
+
+  test 'around_action' do
+    assert_not_nil assigns(:elapsed_time)
+  end
+end

data/test/controllers/kwargs_controller_test.rb

@@ -0,0 +1,30 @@
+require 'test_helper'
+
+class KwBooksControllerTest < ActionController::TestCase
+  sub_test_case 'GET index (having an optional parameter)' do
+    test 'without giving any kw parameter (not even giving :required one)' do
+      assert_raises(ActionController::BadRequest) { get :index }
+    end
+
+    test 'without giving any optional kw parameter' do
+      get :index, author_name: 'nari'
+      assert 200, response.code
+    end
+
+    test 'with kw parameter defaults to non-nil value' do
+      get :index, author_name: 'nari', page: 3
+      body = eval response.body
+      assert_equal 'nari', body[:author_name]
+      assert_equal '3', body[:page]
+      assert_nil body[:q]
+    end
+
+    test 'with kw parameter defaults to nil' do
+      get :index, author_name: 'nari', q: 'Rails'
+      body = eval response.body
+      assert_equal 'nari', body[:author_name]
+      assert_equal '1', body[:page]
+      assert_equal 'Rails', body[:q]
+    end
+  end
+end

data/test/controllers/kwargs_keyreq_controller_test.rb

@@ -0,0 +1,30 @@
+require 'test_helper'
+
+class KwKeyreqBooksControllerTest < ActionController::TestCase
+  sub_test_case 'GET index (having an optional parameter)' do
+    test 'without giving any kw parameter (not even giving :required one)' do
+      assert_raises(ActionController::BadRequest) { get :index }
+    end
+
+    test 'without giving any kw parameter' do
+      get :index, author_name: 'nari'
+      assert 200, response.code
+    end
+
+    test 'with kw parameter defaults to non-nil value' do
+      get :index, author_name: 'nari', page: 3
+      body = eval response.body
+      assert_equal 'nari', body[:author_name]
+      assert_equal '3', body[:page]
+      assert_nil body[:q]
+    end
+
+    test 'with kw parameter defaults to nil' do
+      get :index, author_name: 'nari', q: 'Rails'
+      body = eval response.body
+      assert_equal 'nari', body[:author_name]
+      assert_equal '1', body[:page]
+      assert_equal 'Rails', body[:q]
+    end
+  end
+end if RUBY_VERSION >= '2.1'

data/test/controllers/ordinal_controller_test.rb

@@ -0,0 +1,9 @@
+require 'test_helper'
+
+class AuthorsControllerTest < ActionController::TestCase
+  test 'GET show' do
+    matz = Author.create! name: 'Matz'
+    get :show, :id => matz.id
+    assert_equal matz, assigns(:author)
+  end
+end

data/test/controllers/strong_parameters_test.rb

@@ -0,0 +1,35 @@
+require 'test_helper'
+
+class StoresControllerTest < ActionController::TestCase
+  test 'GET show' do
+    tatsu_zine = Store.create! name: 'Tatsu-zine'
+    get :show, :id => tatsu_zine.id
+
+    assert_equal tatsu_zine, assigns(:store)
+  end
+
+  test 'POST create' do
+    store_count_was = Store.count
+    post :create, :store => {name: 'Tatsu-zine', url: 'http://tatsu-zine.com'}
+
+    assert_equal 1, Store.count - store_count_was
+  end
+end
+
+# this controller doesn't permit price of new book do
+class Admin::BooksControllerTest < ActionController::TestCase
+  test 'POST create' do
+    post :create, :book => {title: 'naruhoUnix', price: 30}
+
+    assert_nil Book.last.price
+  end
+end
+
+class Admin::AccountsControllerTest < ActionController::TestCase
+  test 'POST create' do
+    admin_account_count_was = Admin::Account.count
+    post :create, :admin_account => {name: 'amatsuda'}
+
+    assert_equal 1, Admin::Account.count - admin_account_count_was
+  end
+end

data/{spec → test}/fake_app.rb

@@ -66,21 +66,12 @@ class AuthorsController < ApplicationController
   end
 end
 class BooksController < ApplicationController
-  if Rails::VERSION::MAJOR >= 4
-    before_action :set_book, only: :show
-    before_action -> { @proc_filter_executed = true }, only: :show
-    before_action '@string_filter_executed = true', only: :show
-    around_action :benchmark_action
-    before_action :omg
-    skip_before_action :omg
-  else
-    before_filter :set_book, only: :show
-    before_filter -> { @proc_filter_executed = true }, only: :show
-    before_filter '@string_filter_executed = true', only: :show
-    around_filter :benchmark_action
-    before_filter :omg
-    skip_before_filter :omg
-  end
+  before_action :set_book, only: :show
+  before_action -> { @proc_filter_executed = true }, only: :show
+  before_action '@string_filter_executed = true', only: :show
+  around_action :benchmark_action
+  before_action :omg
+  skip_before_action :omg
 
   # optional parameter
   def index(page = 1, q = nil, limit = 10)
@@ -94,7 +85,7 @@ class BooksController < ApplicationController
   end
 
   def create(book)
-    book = book.permit :title, :price if Rails::VERSION::MAJOR >= 4
+    book = book.permit :title, :price
     @book = Book.create! book
     render text: @book.title
   end
@@ -114,42 +105,40 @@ class BooksController < ApplicationController
       raise '💣'
     end
 end
-if Rails::VERSION::MAJOR >= 4
-  class StoresController < ApplicationController
-    permits :name, :url
+class StoresController < ApplicationController
+  permits :name, :url
 
-    def show(id)
-      @store = Store.find(id)
-      render text: @store.name
-    end
+  def show(id)
+    @store = Store.find(id)
+    render text: @store.name
+  end
 
-    def create(store)
-      @store = Store.create! store
-      render text: @store.name
-    end
+  def create(store)
+    @store = Store.create! store
+    render text: @store.name
   end
-  module Admin
-    class AccountsController < ::ApplicationController
-      permits :name, model_name: 'Admin::Account'
-
-      def create(admin_account)
-        @admin_account = Admin::Account.create! admin_account
-        render text: @admin_account.name
-      end
+end
+module Admin
+  class AccountsController < ::ApplicationController
+    permits :name, model_name: 'Admin::Account'
+
+    def create(admin_account)
+      @admin_account = Admin::Account.create! admin_account
+      render text: @admin_account.name
     end
+  end
 
-    class BooksController < ::ApplicationController
-      permits :title
+  class BooksController < ::ApplicationController
+    permits :title
 
-      def create(book)
-        @book = Book.create! book
-        render text: @book.title
-      end
+    def create(book)
+      @book = Book.create! book
+      render text: @book.title
     end
   end
 end
 
-require_relative 'kwargs_controllers' if RUBY_VERSION >= '2'
+require_relative 'kwargs_controllers'
 require_relative 'kwargs_keyreq_controllers' if RUBY_VERSION >= '2.1'
 
 # migrations
@@ -161,3 +150,5 @@ class CreateAllTables < ActiveRecord::Migration
     create_table(:admin_accounts) {|t| t.string :name}
   end
 end
+
+CreateAllTables.up unless ActiveRecord::Base.connection.table_exists? 'authors'

data/test/mailers/action_mailer_test.rb

@@ -0,0 +1,8 @@
+require 'test_helper'
+
+class UserMailerTest < ActionMailer::TestCase
+  test '#send_email_without_args' do
+    #it should not raise NameError: undefined local variable or method `params' for ...
+    assert UserMailer.send_email_without_args
+  end
+end

data/test/params_handler/params_handler_test.rb

@@ -0,0 +1,192 @@
+require 'test_helper'
+using ActionArgs::ParamsHandler
+
+class ActionArgs::ParamsHandlerTest < ActiveSupport::TestCase
+  sub_test_case 'extract_method_arguments_from_params' do
+    setup do
+      params = {a: '1', b: '2'}
+      @controller = Class.new(ApplicationController).new.tap {|c| c.params = params }
+    end
+    test 'no parameters' do
+      def @controller.m() end
+
+      assert_equal [], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test '1 req' do
+      def @controller.m(a) end
+
+      assert_equal ['1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test '2 reqs' do
+      def @controller.m(a, b) end
+
+      assert_equal ['1', '2'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test '1 opt with value' do
+      def @controller.m(a = 'a') end
+
+      assert_equal ['1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test '1 opt without value' do
+      def @controller.m(x = 'x') end
+
+      assert_equal [], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'req, opt with value' do
+      def @controller.m(a, b = 'b') end
+
+      assert_equal ['1', '2'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'req, opt without value' do
+      def @controller.m(a, x = 'x') end
+
+      assert_equal ['1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt with value, opt with value' do
+      def @controller.m(a = 'a', b = 'b') end
+
+      assert_equal ['1', '2'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt with value, opt without value' do
+      def @controller.m(a = 'a', x = 'x') end
+
+      assert_equal ['1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt without value, opt with value' do
+      def @controller.m(x = 'x', a = 'a') end
+
+      assert_equal [nil, '1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt without value, opt without value' do
+      def @controller.m(x = 'x', y = 'y') end
+
+      assert_equal [], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt with value, req' do
+      def @controller.m(a = 'a', b) end
+
+      assert_equal ['1', '2'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt without value, req' do
+      def @controller.m(x = 'x', a) end
+
+      assert_equal ['1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt without value, opt with value, req' do
+      def @controller.m(x = 'x', b = 'b', a) end
+
+      assert_equal [nil, '2', '1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'opt with value, opt without value, req' do
+      def @controller.m(b = 'b', x = 'x', a) end
+
+      assert_equal ['2', '1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'req without a value' do
+      def @controller.m(x) end
+
+      assert_raises(ActionController::BadRequest) { @controller.extract_method_arguments_from_params(:m) }
+    end
+
+    test 'key' do
+      def @controller.m(a: nil) end
+
+      assert_equal [a: '1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    test 'key, key without value' do
+      def @controller.m(a: nil, x: 'x') end
+
+      assert_equal [a: '1'], @controller.extract_method_arguments_from_params(:m)
+    end
+
+    if RUBY_VERSION >= '2.1'
+      eval <<-KWARGS_KEYREQ_TEST
+        test 'keyreq' do
+          def @controller.m(a:) end
+
+          assert_equal [a: '1'], @controller.extract_method_arguments_from_params(:m)
+        end
+
+        test 'keyreq, keyreq without value' do
+          def @controller.m(a:, x:) end
+
+          assert_raises(ActionController::BadRequest) { @controller.extract_method_arguments_from_params(:m) }
+        end
+      KWARGS_KEYREQ_TEST
+    end
+  end
+
+  sub_test_case 'strengthen_params!' do
+    setup do
+      @params = ActionController::Parameters.new(x: '1', y: '2', foo: {a: 'a', b: 'b'}, bar: {a: 'a', b: 'b'}, baz: {a: 'a', b: 'b'}, hoge: {a: 'a', b: 'b'}, fuga: {a: 'a', b: 'b'})
+    end
+
+    def execute_strengthen_params!(controller)
+      c = controller.new
+      c.instance_variable_set :@_params, @params
+      c.strengthen_params! :a
+    end
+
+    test 'requiring via :req, permitting all scalars' do
+      execute_strengthen_params! FooController ||= Class.new(ApplicationController) { permits :a, :b; def a(foo) end }
+
+      assert @params[:foo].permitted?
+      assert_not_nil @params[:foo][:a]
+      assert_not_nil @params[:foo][:b]
+    end
+
+    test 'requiring via :req, not permitting all scalars' do
+      execute_strengthen_params! BarController ||= Class.new(ApplicationController) { permits :a; def a(bar, x = 'x') end }
+
+      assert @params[:bar].permitted?
+      assert_not_nil @params[:bar][:a]
+      assert_nil @params[:bar][:b]
+    end
+
+    test 'requiring via :req, not permitting any scalars' do
+      execute_strengthen_params! BazController ||= Class.new(ApplicationController) { def a(baz, aho = 'omg') end }
+
+      refute @params[:baz].permitted?
+    end
+
+    test 'requiring via :opt, permitting all scalars' do
+      execute_strengthen_params! HogeController ||= Class.new(ApplicationController) { permits :a, :b; def a(hoge = {}) end }
+
+      assert @params[:hoge].permitted?
+      assert_not_nil @params[:hoge][:a]
+      assert_not_nil @params[:hoge][:b]
+    end
+
+    test 'requiring via :key, permitting all scalars' do
+      execute_strengthen_params! FugaController ||= Class.new(ApplicationController) { permits :a, :b; def a(fuga: {}) end }
+
+      assert @params[:fuga].permitted?
+      assert_not_nil @params[:fuga][:a]
+      assert_not_nil @params[:fuga][:b]
+    end
+
+    test '"model_name" option' do
+      execute_strengthen_params! PiyoController ||= Class.new(ApplicationController) { permits :a, :b, model_name: 'Foo'; def a(foo) end }
+
+      assert @params[:foo].permitted?
+      assert_not_nil @params[:foo][:a]
+      assert_not_nil @params[:foo][:b]
+    end
+  end
+end