acfs 1.3.0 → 1.4.0

data/spec/acfs/middleware/json_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Middleware::JSON do

data/spec/acfs/middleware/msgpack_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Middleware::MessagePack do

data/spec/acfs/operation_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ::Acfs::Operation do

data/spec/acfs/request/callbacks_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Request::Callbacks do

data/spec/acfs/request_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Request do
@@ -18,7 +20,7 @@ describe Acfs::Request do
       let(:params) { {id: 10} }
 
       it 'should return URL without query' do
-        expect(request.url).to be == "#{url}"
+        expect(request.url).to be == url.to_s
       end
     end
   end

data/spec/acfs/resource/attributes/boolean_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::Boolean do

data/spec/acfs/resource/attributes/date_time_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::DateTime do

data/spec/acfs/resource/attributes/dict_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::Dict do
@@ -13,12 +15,12 @@ describe Acfs::Resource::Attributes::Dict do
 
     context 'with blank string (I)' do
       let(:value) { '' }
-      it { expect(subject.call).to eq Hash.new }
+      it { expect(subject.call).to eq({}) }
     end
 
     context 'with blank string (II)' do
       let(:value) { "  \t" }
-      it { expect(subject.call).to eq Hash.new }
+      it { expect(subject.call).to eq({}) }
     end
 
     context 'with hash' do

data/spec/acfs/resource/attributes/float_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::Float do

data/spec/acfs/resource/attributes/integer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::Integer do

data/spec/acfs/resource/attributes/list_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::List do
@@ -13,16 +15,16 @@ describe Acfs::Resource::Attributes::List do
 
     context 'with blank string (I)' do
       let(:value) { '' }
-      it { expect(subject.call).to eq Array.new }
+      it { expect(subject.call).to eq [] }
     end
 
     context 'with blank string (II)' do
       let(:value) { "  \t" }
-      it { expect(subject.call).to eq Array.new }
+      it { expect(subject.call).to eq [] }
     end
 
     context 'with array' do
-      let(:value) { %w(abc cde efg) }
+      let(:value) { %w[abc cde efg] }
       it { expect(subject.call).to eq value }
     end
 

data/spec/acfs/resource/attributes/uuid_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes::UUID do

data/spec/acfs/resource/attributes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Attributes do
@@ -52,7 +54,7 @@ describe Acfs::Resource::Attributes do
     let(:action) { -> { m.write_attributes(*args) } }
     subject { action }
 
-    it 'should update attributes'  do
+    it 'should update attributes' do
       should change(m, :attributes)
         .from(name: 'The Great John', age: 25)
         .to(name: 'The Great James', age: 25)
@@ -70,7 +72,7 @@ describe Acfs::Resource::Attributes do
 
       it { should_not raise_error }
 
-      it 'should update known attributes and store unknown'  do
+      it 'should update known attributes and store unknown' do
         should change(m, :attributes)
           .from(name: 'The Great John', age: 25)
           .to(name: 'The Great James', age: 25, born_at: 'today')
@@ -85,7 +87,7 @@ describe Acfs::Resource::Attributes do
           expect do
             begin
               subject.call
-            rescue
+            rescue StandardError
               true
             end
           end.to_not change(m, :attributes)
@@ -171,7 +173,7 @@ describe Acfs::Resource::Attributes do
         end
 
         it 'includes superclass attributes' do
-          expect(submodel.attributes.keys).to match_array %w(age born_at)
+          expect(submodel.attributes.keys).to match_array %w[age born_at]
         end
       end
     end

data/spec/acfs/resource/dirty_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Dirty do

data/spec/acfs/resource/initialization_spec.rb

@@ -1,11 +1,17 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'Acfs::Resource::Initialization' do
   let(:model) do
     Class.new(Acfs::Resource).tap do |c|
       c.class_eval do
-        attr_accessor :name, :age
-        private :age=
+        attr_accessor :name
+        attr_reader :age
+
+        private
+
+        attr_writer :age
       end
     end
   end

data/spec/acfs/resource/loadable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Loadable do

data/spec/acfs/resource/locatable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Locatable do

data/spec/acfs/resource/persistance_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Persistence do
@@ -226,8 +228,12 @@ describe Acfs::Resource::Persistence do
 
       it 'should set local errors hash' do
         model.name = ''
-        model.save! rescue nil
-        expect(model.errors.to_hash).to be == {name: %w(required)}
+        begin
+          model.save!
+        rescue StandardError
+          nil
+        end
+        expect(model.errors.to_hash).to be == {name: %w[required]}
       end
     end
 
@@ -265,7 +271,7 @@ describe Acfs::Resource::Persistence do
       it 'should raise an error' do
         expect { model_class.create! data }.to \
           raise_error(::Acfs::InvalidResource) do |error|
-            expect(error.errors).to be == {'name' => %w(required)}
+            expect(error.errors).to be == {'name' => %w[required]}
           end
       end
     end
@@ -295,7 +301,7 @@ describe Acfs::Resource::Persistence do
       end
 
       it 'should contain error hash' do
-        expect(subject.errors.to_hash).to eq name: %w(required)
+        expect(subject.errors.to_hash).to eq name: %w[required]
       end
     end
 

data/spec/acfs/resource/query_methods_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::QueryMethods do
@@ -158,7 +160,8 @@ describe Acfs::Resource::QueryMethods do
         .to_return response [
           {id: 1, type: 'PC'},
           {id: 2, type: 'Computer'},
-          {id: 3, type: 'Mac'}]
+          {id: 3, type: 'Mac'}
+        ]
     end
 
     it 'should invoke multiple callback after all models are loaded' do
@@ -209,7 +212,8 @@ describe Acfs::Resource::QueryMethods do
               .to_return response [
                 {id: 1, type: 'MyUser'},
                 {id: 2, type: 'Computer'},
-                {id: 3, type: 'Mac'}]
+                {id: 3, type: 'Mac'}
+              ]
           end
           it_behaves_like 'with invalid type'
         end
@@ -220,7 +224,8 @@ describe Acfs::Resource::QueryMethods do
               .to_return response [
                 {id: 1, type: 'PC'},
                 {id: 2, type: 'noValidType'},
-                {id: 3, type: 'Mac'}]
+                {id: 3, type: 'Mac'}
+              ]
           end
           it_behaves_like 'with invalid type'
         end
@@ -231,7 +236,8 @@ describe Acfs::Resource::QueryMethods do
               .to_return response [
                 {id: 1, type: 'PC'},
                 {id: 2, type: 'Computer'},
-                {id: 3, type: 42}]
+                {id: 3, type: 42}
+              ]
           end
           it_behaves_like 'with invalid type'
         end
@@ -270,7 +276,8 @@ describe Acfs::Resource::QueryMethods do
             .to_return response [
               {id: 1, name: 'Mike', age: 24},
               {id: 4, type: 'Maria', age: 24},
-              {id: 7, type: 'James', age: 24}]
+              {id: 7, type: 'James', age: 24}
+            ]
         end
 
         it 'should invoke callback after model is loaded' do
@@ -398,7 +405,7 @@ describe Acfs::Resource::QueryMethods do
           expect(block).not_to receive(:call)
 
           model.find_by! age: 24, &block
-          expect { Acfs.run }.to raise_error
+          expect { Acfs.run }.to raise_error Acfs::ResourceNotFound
         end
       end
     end
@@ -410,25 +417,25 @@ describe Acfs::Resource::QueryMethods do
             .to_return response([{id: 1, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=2>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=2>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=2')
             .to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=3>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=3>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=3')
             .to_return response([{id: 3, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=4>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=4>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=4')
             .to_return response([{id: 4, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => ''
+                'Link' => ''
               })
         end
 
@@ -452,25 +459,25 @@ describe Acfs::Resource::QueryMethods do
             .to_return response([{id: 1, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?where=fuu&page=2>; rel="next"'
+                'Link' => '<http://users.example.org/users?where=fuu&page=2>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?where=fuu&page=2')
             .to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=3>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=3>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=3')
             .to_return response([{id: 3, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=4>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=4>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=4')
             .to_return response([{id: 4, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => ''
+                'Link' => ''
               })
         end
 
@@ -496,25 +503,25 @@ describe Acfs::Resource::QueryMethods do
             .to_return response([{id: 1, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=2>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=2>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=2')
             .to_return response([{id: 2, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=3>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=3>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=3')
             .to_return response([{id: 3, name: 'Anno', age: 1604, born_at: 'Santa Maria'}, {id: 4, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => '<http://users.example.org/users?page=4>; rel="next"'
+                'Link' => '<http://users.example.org/users?page=4>; rel="next"'
               })
           stub_request(:get, 'http://users.example.org/users?page=4')
             .to_return response([{id: 5, name: 'Anno', age: 1604, born_at: 'Santa Maria'}],
               headers: {
                 'X-Total-Pages' => '4',
-                'Link'          => ''
+                'Link' => ''
               })
         end
 

data/spec/acfs/resource/validation_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Resource::Validation do

data/spec/acfs/response/formats_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Response::Formats do
@@ -9,7 +11,7 @@ describe Acfs::Response::Formats do
   let(:response)  { Acfs::Response.new request, status: status, headers: headers, body: body }
 
   context 'without Content-Type header' do
-    let(:headers)   { {} }
+    let(:headers) { {} }
 
     it "should fallback on 'text/plain'" do
       expect(response.content_type).to be == Mime[:text]

data/spec/acfs/response/status_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Acfs::Response::Status do

data/spec/acfs/runner_spec.rb

@@ -1,25 +1,23 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 class NullAdapter < Acfs::Adapter::Base
   # Start processing queued requests.
   #
-  def start
-  end
+  def start; end
 
   # Abort running and queued requests.
   #
-  def abort
-  end
+  def abort; end
 
   # Run request right now skipping queue.
   #
-  def run(_)
-  end
+  def run(_); end
 
   # Enqueue request to be run later.
   #
-  def queue(_)
-  end
+  def queue(_); end
 end
 
 class NotificationCollector