acfs 1.3.0 → 1.4.0

data/lib/acfs/middleware/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs
   module Middleware
     # A base middleware that does not modify request or response.
@@ -12,7 +14,9 @@ module Acfs
       end
 
       def call(request)
-        request.on_complete {|res, nxt| response(res, nxt) } if respond_to? :response
+        if respond_to? :response
+          request.on_complete {|res, nxt| response(res, nxt) }
+        end
         app.call(request)
       end
     end

data/lib/acfs/middleware/json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'multi_json'
 
 module Acfs

data/lib/acfs/middleware/logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'logger'
 
 module Acfs

data/lib/acfs/middleware/msgpack.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'msgpack'
 require 'action_dispatch'
 

data/lib/acfs/middleware/print.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs
   module Middleware
     # Print resquests and response on terminal

data/lib/acfs/middleware/serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs
   module Middleware
     # A base middleware that does not modify request or response.

data/lib/acfs/operation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs
   # @api private
   #
@@ -19,7 +21,7 @@ module Acfs
       @data     = (opts[:data]   || {}).dup
 
       if opts[:url]
-        @url      = opts[:url]
+        @url = opts[:url]
       else
         @location = resource.location(action: @action).extract_from(@params, @data)
         @url      = location.str
@@ -29,11 +31,11 @@ module Acfs
     end
 
     def single?
-      [:read, :update, :delete].include? action
+      %i[read update delete].include? action
     end
 
     def synchronous?
-      [:update, :delete, :create].include? action
+      %i[update delete create].include? action
     end
 
     def id

data/lib/acfs/request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'acfs/request/callbacks'
 
 module Acfs
@@ -29,6 +31,7 @@ module Acfs
     class << self
       def new(*attrs)
         return attrs[0] if attrs[0].is_a? self
+
         super
       end
     end

data/lib/acfs/request/callbacks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs
   class Request
     # Module containing callback handling for Requests.
@@ -43,7 +45,9 @@ module Acfs
       private
 
       def call_callback(res, index)
-        callbacks[index].call res, proc {|bres| call_callback bres, index + 1 } if index < callbacks.size
+        if index < callbacks.size
+          callbacks[index].call res, proc {|bres| call_callback bres, index + 1 }
+        end
       end
     end
   end

data/lib/acfs/resource.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_model'
 
 # @api public

data/lib/acfs/resource/attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   #
   # = Acfs Attributes
@@ -176,9 +178,8 @@ class Acfs::Resource
       attributes[name.to_s] = value
     end
 
-    #
     module ClassMethods
-      ATTR_CLASS_BASE = '::Acfs::Resource::Attributes'.freeze
+      ATTR_CLASS_BASE = '::Acfs::Resource::Attributes'
 
       #
       # @api public

data/lib/acfs/resource/attributes/base.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
-  #
   class Base
     attr_reader :default
 

data/lib/acfs/resource/attributes/boolean.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #

data/lib/acfs/resource/attributes/date_time.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #
@@ -10,7 +12,6 @@ module Acfs::Resource::Attributes
   #   end
   #
   class DateTime < Base
-
     # @api public
     #
     # Cast given object to DateTime.

data/lib/acfs/resource/attributes/dict.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #

data/lib/acfs/resource/attributes/float.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #
@@ -21,9 +23,9 @@ module Acfs::Resource::Attributes
 
       case value
         when ::Float then value
-        when "Infinity" then ::Float::INFINITY
-        when "-Infinity" then -::Float::INFINITY
-        when "NaN" then ::Float::NAN
+        when 'Infinity' then ::Float::INFINITY
+        when '-Infinity' then -::Float::INFINITY
+        when 'NaN' then ::Float::NAN
         else Float(value)
       end
     end

data/lib/acfs/resource/attributes/integer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #

data/lib/acfs/resource/attributes/list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #

data/lib/acfs/resource/attributes/string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #

data/lib/acfs/resource/attributes/uuid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Acfs::Resource::Attributes
   # @api public
   #
@@ -9,8 +11,7 @@ module Acfs::Resource::Attributes
   #   end
   #
   class UUID < Base
-    #
-    UUID_REGEXP = /[0-9a-f]{8}(-[0-9a-f]{4}){3}-[0-9a-f]{12}/i
+    UUID_REGEXP = /[0-9a-f]{8}(-[0-9a-f]{4}){3}-[0-9a-f]{12}/i.freeze
 
     # @api public
     #
@@ -37,7 +38,7 @@ module Acfs::Resource::Attributes
       elsif value.to_s =~ UUID_REGEXP
         value
       else
-        raise TypeError.new "Invalid UUID: `#{value.to_s}'"
+        raise TypeError.new "Invalid UUID: `#{value}'"
       end
     end
   end

data/lib/acfs/resource/dirty.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   #
   # Thin wrapper around ActiveModel::Dirty

data/lib/acfs/resource/initialization.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   #
   # Initialization drop-in for pre-4.0 ActiveModel.

data/lib/acfs/resource/loadable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   # Provides method to check for loading state of resources.
   # A resource that is created but not yet fetched will be loaded

data/lib/acfs/resource/locatable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   # Provide methods for generation URLs for resources.
   #
@@ -11,7 +13,6 @@ class Acfs::Resource
   module Locatable
     extend ActiveSupport::Concern
 
-    #
     module ClassMethods
       # @overload url(suffix)
       #   @deprecated
@@ -40,7 +41,10 @@ class Acfs::Resource
       #   @return [String] Generated URL.
       #
       def url(suffix = nil, opts = {})
-        opts, suffix = suffix, nil if suffix.is_a? Hash
+        if suffix.is_a? Hash
+          opts = suffix
+          suffix = nil
+        end
 
         opts[:action] = :list if suffix
 
@@ -85,9 +89,9 @@ class Acfs::Resource
       def location_default_path(action, path)
         case action
           when :list, :create
-            return path
+            path
           when :read, :update, :delete
-            return "#{path}/:id"
+            "#{path}/:id"
         end
       end
     end
@@ -109,8 +113,8 @@ class Acfs::Resource
       return nil if need_primary_key? && !primary_key?
 
       self.class.service
-        .location(self.class, opts.reverse_merge(action: :read))
-        .build(attributes).str
+          .location(self.class, opts.reverse_merge(action: :read))
+          .build(attributes).str
     end
 
     # @api private

data/lib/acfs/resource/operational.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   # @api private
   #
@@ -11,7 +13,6 @@ class Acfs::Resource
     extend ActiveSupport::Concern
     delegate :operation, to: :'self.class'
 
-    #
     module ClassMethods
       # Invoke CRUD operation.
       def operation(action, opts = {}, &block)

data/lib/acfs/resource/persistence.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   #
   # Allow to track the persistence state of a model.
@@ -40,7 +42,7 @@ class Acfs::Resource
     def new?
       !loaded?
     end
-    alias_method :new_record?, :new?
+    alias new_record? new?
 
     # @api public
     #
@@ -86,9 +88,9 @@ class Acfs::Resource
       operation((new? ? :create : :update), opts) do |data|
         update_with data
       end
-    rescue ::Acfs::InvalidResource => err
-      self.remote_errors = err.errors
-      raise err
+    rescue ::Acfs::InvalidResource => e
+      self.remote_errors = e.errors
+      raise e
     end
 
     # @api public
@@ -251,6 +253,7 @@ class Acfs::Resource
 
     def check_loaded!(opts = {})
       return if loaded? || opts[:force]
+
       raise ::Acfs::ResourceNotLoaded.new resource: self
     end
   end

data/lib/acfs/resource/query_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   # Methods providing the query interface for finding resouces.
   #
@@ -14,7 +16,6 @@ class Acfs::Resource
   module QueryMethods
     extend ActiveSupport::Concern
 
-    #
     module ClassMethods
       # @api public
       #
@@ -89,7 +90,7 @@ class Acfs::Resource
 
         collection
       end
-      alias_method :where, :all
+      alias where all
 
       # @api public
       #
@@ -140,7 +141,7 @@ class Acfs::Resource
             raise Acfs::ResourceNotFound.new message: 'Received erroneous ' \
               "response: no `#{name}` with params #{params} found"
           end
-          block.call m unless block.nil?
+          block&.call m
         end
       end
 
@@ -249,6 +250,7 @@ class Acfs::Resource
 
       def resource_class_lookup(type)
         return self if type.nil?
+
         klass = type.camelize.constantize
 
         unless klass <= self

data/lib/acfs/resource/service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
   # Included by Acfs::Model. Allows to configure the service
   # a resource belongs to.
@@ -5,7 +7,6 @@ class Acfs::Resource
   module Service
     extend ActiveSupport::Concern
 
-    #
     module ClassMethods
       # @api public
       #
@@ -35,6 +36,7 @@ class Acfs::Resource
       #
       def service(klass = nil, options = {})
         return (@service = klass.new options) if klass
+
         @service || superclass.service
       end
     end

data/lib/acfs/resource/validation.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 class Acfs::Resource
-  #
   module Validation
     def valid?(*args)
       super
@@ -31,6 +32,7 @@ class Acfs::Resource
       unless valid?(new? ? :create : :save)
         raise ::Acfs::InvalidResource.new resource: self, errors: errors.to_a
       end
+
       super
     end
   end

data/lib/acfs/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'acfs/response/formats'
 require 'acfs/response/status'
 require 'active_support/core_ext/module/delegation'

data/lib/acfs/response/formats.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'action_dispatch'
 
 module Acfs