LittleWeasel 5.0.4 → 5.0.6

data/spec/lib/LittleWeasel/metadata/dictionary_metadata_spec.rb

@@ -14,17 +14,17 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
   let(:invalid_words_metadata_key) { invalid_words_metadata_class.metadata_key }
   let(:invalid_words_metadata_class) { LittleWeasel::Metadata::InvalidWordsMetadata }
 
-  #.new
+  # .new
   describe '#.new' do
     context 'with valid arguments' do
       it 'instantiates the object' do
-        expect { subject }.to_not raise_error
+        expect { subject }.not_to raise_error
       end
     end
 
     context 'with invalid arguments' do
       context 'when dictionary_words is nil' do
-        # Note: do not use the factory for this spec becasue
+        # NOTE: do not use the factory for this spec becasue
         # it creates a dictionary if a nil dictionay is passed
         # so the test will never pass if using the factory.
         subject { described_class.new(dictionary_words: dictionary_words, dictionary_key: dictionary_key, dictionary_cache: dictionary_cache, dictionary_metadata: dictionary_metadata) }
@@ -37,7 +37,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
       end
 
       context 'when dictionary_words is not a Hash' do
-        let(:dictionary_words) { %w(I am a bad dictionary) }
+        let(:dictionary_words) { %w[I am a bad dictionary] }
 
         it 'raises an error' do
           expect { subject }.to raise_error(/Argument dictionary_words is not a Hash/)
@@ -46,7 +46,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
     end
   end
 
-  #[]
+  # []
   describe '#[]' do
     context 'when passing a valid metadata_key' do
       context 'when it is a key that points to a valid metadata observer' do
@@ -55,7 +55,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
         end
 
         it 'returns the metadata observer object' do
-          expect(subject[invalid_words_metadata_key]).to be_kind_of invalid_words_metadata_class
+          expect(subject[invalid_words_metadata_key]).to be_a invalid_words_metadata_class
         end
       end
 
@@ -73,7 +73,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
     end
   end
 
-  #init
+  # init
   describe '#init' do
     context 'when there are observers attached' do
       before do
@@ -94,7 +94,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
       it 'observers are NOT notified to init' do
         # Sanity check.
         expect(subject.count_observers).to eq 0
-        expect(subject.observers[invalid_words_metadata_key]).to_not receive(:init)
+        expect(subject.observers[invalid_words_metadata_key]).not_to receive(:init)
         subject.init
       end
     end
@@ -105,7 +105,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
     end
   end
 
-  #refresh
+  # refresh
   describe '#refresh' do
     context 'when there are observers attached' do
       before do
@@ -124,7 +124,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
       it 'observers are NOT notified to refresh' do
         # Sanity check.
         expect(subject.count_observers).to eq 0
-        expect(subject.observers[invalid_words_metadata_key]).to_not receive(:refresh)
+        expect(subject.observers[invalid_words_metadata_key]).not_to receive(:refresh)
         subject.refresh
       end
     end
@@ -135,7 +135,7 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
     end
   end
 
-  #delete_observer
+  # delete_observer
   describe '#delete_observer' do
     context 'when a valid observer object is passed' do
       before do
@@ -157,12 +157,12 @@ RSpec.describe LittleWeasel::Metadata::DictionaryMetadata do
 
       it 'raises an error' do
         expect { subject.delete_observer(bad_observer) }.to raise_error 'Argument metadata_observable is not a ' \
-            "Metadata::MetadataObserverable object: #{bad_observer.class}"
+                                                                        "Metadata::MetadataObserverable object: #{bad_observer.class}"
       end
     end
   end
 
-  #add_observers
+  # add_observers
   describe '#add_observers' do
     it 'returns the same object that was called' do
       expect(subject.add_observers).to be subject

data/spec/lib/LittleWeasel/metadata/invalid_words_metadata_spec.rb

@@ -29,7 +29,7 @@ RSpec.describe LittleWeasel::Metadata::InvalidWordsMetadata do
 
   let(:configuration) { LittleWeasel.configuration }
 
-  #new
+  # new
   describe '#new' do
     context 'with invalid arguments' do
       subject { invalid_words_metadata }
@@ -39,7 +39,7 @@ RSpec.describe LittleWeasel::Metadata::InvalidWordsMetadata do
       end
 
       context 'with invalid dictionary metadata object' do
-        let(:dictionary_words) { { 'a' => true, 'b' => true } }
+        let(:dictionary_words) { { a: true, b: true } }
         let(:dictionary_metadata_object) { :wrong_type }
 
         it 'raises an error' do
@@ -48,7 +48,7 @@ RSpec.describe LittleWeasel::Metadata::InvalidWordsMetadata do
       end
 
       context 'with invalid dictionary metadata' do
-        let(:dictionary_words) { { 'a' => true, 'b' => true } }
+        let(:dictionary_words) { { a: true, b: true } }
         let(:dictionary_metadata) { :wrong_type }
 
         it 'raises an error' do
@@ -75,16 +75,16 @@ RSpec.describe LittleWeasel::Metadata::InvalidWordsMetadata do
       let(:word_results2) { create(:word_results, original_word: 'badword2') }
 
       it 'instantiates without error' do
-        expect { subject }.to_not raise_error
+        expect { subject }.not_to raise_error
       end
 
       it 'initializes the necessary object attributes' do
-        expect(subject.on?).to eq true
-        expect(subject.off?).to eq false
+        expect(subject.on?).to be true
+        expect(subject.off?).to be false
         expect(subject.value).to eq configuration.max_invalid_words_bytesize
-        expect(subject.value_exceeded?).to eq false
+        expect(subject.value_exceeded?).to be false
         expect(subject.current_invalid_word_bytesize).to eq 16
-        expect(subject.cache_invalid_words?).to eq true
+        expect(subject.cache_invalid_words?).to be true
       end
     end
 
@@ -109,30 +109,30 @@ RSpec.describe LittleWeasel::Metadata::InvalidWordsMetadata do
     end
   end
 
-  #refresh
+  # refresh
   describe '#refresh' do
     it 'the metadata is refreshed' do
       expect(subject.current_invalid_word_bytesize).to eq 0
       expect do
         dictionary.word_results('badword')
         subject.refresh
-      end.to change { subject.current_invalid_word_bytesize }
-      .from(0).to(7)
+      end.to change(subject, :current_invalid_word_bytesize)
+        .from(0).to(7)
     end
   end
 
-  #init
+  # init
   describe '#init' do
     it 'the metadata is initialized' do
       expect do
         subject.dictionary_metadata_object.dictionary_words['not-found'] = false
         subject.init
-      end.to change { subject.current_invalid_word_bytesize }
-      .from(0).to(9)
+      end.to change(subject, :current_invalid_word_bytesize)
+        .from(0).to(9)
     end
   end
 
-  #Update
+  # Update
   describe '#update' do
     context 'with an action NOT on the whitelist' do
       let(:action) { :bad_action! }
@@ -147,8 +147,8 @@ RSpec.describe LittleWeasel::Metadata::InvalidWordsMetadata do
       it 'carries out the requested action' do
         expect do
           dictionary.word_results 'not-found'
-        end.to change { subject.current_invalid_word_bytesize }
-        .from(0).to(9)
+        end.to change(subject, :current_invalid_word_bytesize)
+          .from(0).to(9)
       end
     end
   end

data/spec/lib/LittleWeasel/metadata/metadata_observerable_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe LittleWeasel::Metadata::MetadataObserverable, type: :module do
 
   describe '#observe?' do
     it 'returns false by default' do
-      expect(subject.observe?).to eq false
+      expect(subject.observe?).to be false
     end
   end
 

data/spec/lib/LittleWeasel/modules/dictionary_file_loader_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe LittleWeasel::Modules::DictionaryFileLoader, type: :module do
   let(:dictionary_file_key) { file }
   let(:dictionary_cache) { {} }
 
-  #load
+  # load
   describe '#load' do
     context 'with an invalid dictionary file' do
       context 'when it cannot be found' do
@@ -52,7 +52,7 @@ RSpec.describe LittleWeasel::Modules::DictionaryFileLoader, type: :module do
         let(:dictionary_path) { dictionary_path_for file_name: 'empty-dictionary' }
 
         it 'raises an error' do
-          expect { subject.load dictionary_path  }.to raise_error LittleWeasel::Errors::DictionaryFileEmptyError
+          expect { subject.load dictionary_path }.to raise_error LittleWeasel::Errors::DictionaryFileEmptyError
         end
       end
 
@@ -64,7 +64,7 @@ RSpec.describe LittleWeasel::Modules::DictionaryFileLoader, type: :module do
         let(:dictionary_path) { language_dictionary_path language: :en }
 
         it 'raises an error' do
-          expect { subject.load dictionary_path  }.to raise_error LittleWeasel::Errors::DictionaryFileTooLargeError
+          expect { subject.load dictionary_path }.to raise_error LittleWeasel::Errors::DictionaryFileTooLargeError
         end
       end
     end
@@ -78,39 +78,39 @@ RSpec.describe LittleWeasel::Modules::DictionaryFileLoader, type: :module do
         before { subject }
 
         it 'does not raise an error' do
-          expect { subject }.to_not raise_error
+          expect { subject }.not_to raise_error
         end
       end
 
       context 'when the dictionary is NOT already loaded/cached' do
         let(:expected_dictionary_key_key) { LittleWeasel::DictionaryKey.new(language: language, region: region, tag: tag).key }
         let(:expected_results) do
-          ['apple',
-           'better',
-           'cat',
-           'dog',
-           'everyone',
-           'fat',
-           'game',
-           'help',
-           'italic',
-           'jasmine',
-           'kelp',
-           'love',
-           'man',
-           'nope',
-           'octopus',
-           'popeye',
-           'queue',
-           'ruby',
-           'stop',
-           'top',
-           'ultimate',
-           'very',
-           'was',
-           'xylophone',
-           'yes',
-           'zebra']
+          %w[apple
+             better
+             cat
+             dog
+             everyone
+             fat
+             game
+             help
+             italic
+             jasmine
+             kelp
+             love
+             man
+             nope
+             octopus
+             popeye
+             queue
+             ruby
+             stop
+             top
+             ultimate
+             very
+             was
+             xylophone
+             yes
+             zebra]
         end
 
         it 'returns an Array of dictionary words loaded from the file' do

data/spec/lib/LittleWeasel/modules/dictionary_sourceable_spec.rb

@@ -18,63 +18,63 @@ RSpec.describe LittleWeasel::Modules::DictionarySourceable, type: :module do
   let(:dictionary_memory_source) { described_class.memory_source }
   let(:dictionary_file_source) { language_dictionary_path language: :en }
 
-  #.MEMORY_SOURCE
+  # .MEMORY_SOURCE
   describe '::MEMORY_SOURCE' do
     it 'returns the memory source prefix' do
       expect(described_class::MEMORY_SOURCE).to eq '*'
     end
   end
 
-  #.memory_source
+  # .memory_source
   describe '.memory_source' do
     it 'returns a new memory source' do
       expect(described_class.memory_source).to be_truthy
     end
   end
 
-  #.file_source?
+  # .file_source?
   describe '.file_source?' do
     context 'when dictionary_source is a file source' do
       it 'returns truthy' do
-        expect(described_class.file_source? dictionary_file_source).to be_truthy
+        expect(described_class).to be_file_source(dictionary_file_source)
       end
     end
 
     context 'when dictionary_source is NOT a file source' do
       it 'returns falsey' do
-        expect(described_class.file_source? dictionary_memory_source).to be_falsey
+        expect(described_class).not_to be_file_source(dictionary_memory_source)
       end
     end
   end
 
-  #.memory_source?
+  # .memory_source?
   describe '.memory_source?' do
     context 'when dictionary_source is a memory source' do
       it 'returns truthy if argument is a valid memory source' do
-        expect(described_class.memory_source? '*12345678').to be_truthy
-        expect(described_class.memory_source? '*abcdef00').to be_truthy
-        expect(described_class.memory_source? '*ABCDEF00').to be_truthy
-        expect(described_class.memory_source? '*aBcDeF00').to be_truthy
+        expect(described_class).to be_memory_source('*12345678')
+        expect(described_class).to be_memory_source('*abcdef00')
+        expect(described_class).to be_memory_source('*ABCDEF00')
+        expect(described_class).to be_memory_source('*aBcDeF00')
       end
 
       it 'returns falsey if argument is NOT a memory source' do
-        expect(described_class.memory_source? '*123456789').to be_falsey
-        expect(described_class.memory_source? '*abcdefg0').to be_falsey
-        expect(described_class.memory_source? '*ABCDEFG0').to be_falsey
-        expect(described_class.memory_source? '*aBcDeFg0').to be_falsey
-        expect(described_class.memory_source? '$12345678').to be_falsey
+        expect(described_class).not_to be_memory_source('*123456789')
+        expect(described_class).not_to be_memory_source('*abcdefg0')
+        expect(described_class).not_to be_memory_source('*ABCDEFG0')
+        expect(described_class).not_to be_memory_source('*aBcDeFg0')
+        expect(described_class).not_to be_memory_source('$12345678')
 
-        expect(described_class.memory_source? '123456789').to be_falsey
-        expect(described_class.memory_source? 'abcdefg0').to be_falsey
-        expect(described_class.memory_source? 'ABCDEFG0').to be_falsey
-        expect(described_class.memory_source? 'aBcDeFg0').to be_falsey
-        expect(described_class.memory_source? '123456789').to be_falsey
+        expect(described_class).not_to be_memory_source('123456789')
+        expect(described_class).not_to be_memory_source('abcdefg0')
+        expect(described_class).not_to be_memory_source('ABCDEFG0')
+        expect(described_class).not_to be_memory_source('aBcDeFg0')
+        expect(described_class).not_to be_memory_source('123456789')
       end
     end
 
     context 'when dictionary_source is a file source' do
       it 'returns falsey' do
-        expect(described_class.memory_source? dictionary_file_source).to be_falsey
+        expect(described_class).not_to be_memory_source(dictionary_file_source)
       end
     end
   end

data/spec/lib/LittleWeasel/modules/language_spec.rb

@@ -23,24 +23,24 @@ RSpec.describe LittleWeasel::Modules::Language, type: :module do
 
   let(:language) {}
 
-  #language?
+  # language?
   describe '#language?' do
     context 'when language is present?' do
       let(:language) { :es }
 
       it 'returns true' do
-        expect(subject.language?).to eq true
+        expect(subject.language?).to be true
       end
     end
 
     context 'when language is NOT present?' do
       it 'returns false' do
-        expect(subject.language?).to eq false
+        expect(subject.language?).to be false
       end
     end
   end
 
-  #normalize_language!
+  # normalize_language!
   describe '#normalize_language!' do
     context 'when language is present?' do
       context 'when language responds to #upcase!' do
@@ -75,7 +75,7 @@ RSpec.describe LittleWeasel::Modules::Language, type: :module do
     end
   end
 
-  #.normalize_language
+  # .normalize_language
   describe '#.normalize_language' do
     context 'with a non-nil language' do
       context 'when passing a Symbol' do

data/spec/lib/LittleWeasel/modules/locale_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe LittleWeasel::Modules::Locale, type: :module do
   let(:language) {}
   let(:region) {}
 
-  #locale
+  # locale
   describe '#locale' do
     context 'with valid arguments' do
       context 'with valid language' do

data/spec/lib/LittleWeasel/modules/region_spec.rb

@@ -23,24 +23,24 @@ RSpec.describe LittleWeasel::Modules::Region, type: :module do
 
   let(:region) {}
 
-  #region?
+  # region?
   describe '#region?' do
     context 'when region is present?' do
       let(:region) { :es }
 
       it 'returns true' do
-        expect(subject.region?).to eq true
+        expect(subject.region?).to be true
       end
     end
 
     context 'when region is NOT present?' do
       it 'returns false' do
-        expect(subject.region?).to eq false
+        expect(subject.region?).to be false
       end
     end
   end
 
-  #normalize_region!
+  # normalize_region!
   describe '#normalize_region!' do
     context 'when region is present?' do
       context 'when region responds to #upcase' do
@@ -75,7 +75,7 @@ RSpec.describe LittleWeasel::Modules::Region, type: :module do
     end
   end
 
-  #.normalize_region
+  # .normalize_region
   describe '#.normalize_region' do
     context 'with a non-nil region' do
       context 'when passing a Symbol' do

data/spec/lib/LittleWeasel/preprocessors/en_us/capitalize_preprocessor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # frozen_string_literals: true
 
 require 'spec_helper'
@@ -5,10 +7,10 @@ require 'spec_helper'
 RSpec.describe LittleWeasel::Preprocessors::EnUs::CapitalizePreprocessor do
   subject { described_class.new }
 
-  #.new
+  # .new
   describe '.new' do
     it 'instantiates the object' do
-      expect { subject }.to_not raise_error
+      expect { subject }.not_to raise_error
     end
 
     describe '#order' do
@@ -19,16 +21,16 @@ RSpec.describe LittleWeasel::Preprocessors::EnUs::CapitalizePreprocessor do
 
     describe '#preprocessor_on' do
       it 'sets #preprocessor_on to true by default' do
-        expect(subject.preprocessor_on).to eq true
+        expect(subject.preprocessor_on).to be true
       end
     end
   end
 
-  #.preprocess
+  # .preprocess
   describe '.preprocess' do
     it 'processes and capitalizes the word' do
-      expect(described_class.preprocess 'wOrD').to eq [true, 'Word']
-      expect(described_class.preprocess 'Word').to eq [true, 'Word']
+      expect(described_class.preprocess('wOrD')).to eq [true, 'Word']
+      expect(described_class.preprocess('Word')).to eq [true, 'Word']
     end
   end
 end

data/spec/lib/LittleWeasel/preprocessors/preprocessed_word_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWord do
   let(:preprocessed) { true }
   let(:preprocessor_order) { :preprocessor_order }
 
-  #.new
+  # .new
   describe '.new' do
     context 'initializes the attributes' do
       describe '#original_word' do
@@ -89,7 +89,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWord do
     describe '#preprocessed?' do
       context 'when preprocessed is true' do
         it 'returns true' do
-          expect(subject.preprocessed?).to eq true
+          expect(subject.preprocessed?).to be true
         end
       end
 
@@ -97,7 +97,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWord do
         let(:preprocessed) { false }
 
         it 'returns false' do
-          expect(subject.preprocessed?).to eq false
+          expect(subject.preprocessed?).to be false
         end
       end
     end

data/spec/lib/LittleWeasel/preprocessors/preprocessed_word_validatable_spec.rb

@@ -27,21 +27,22 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
   end
   let(:original_word) { 'word' }
   let(:preprocessed) { true }
-  let(:preprocessed_word) { 'preprocessed-word0'}
+  let(:preprocessed_word) { 'preprocessed-word0' }
   let(:preprocessor) { :preprocesor0 }
   let(:preprocessor_order) { 0 }
 
-  #.validate_prepreprocessed_word
+  # .validate_prepreprocessed_word
   describe '.validate_prepreprocessed_word' do
     context 'when the object is valid' do
       it 'does not raise an error' do
-        expect { PreprocessedWordValidatable.validate_prepreprocessed_word(preprocessed_word: preprocessed_word_object) }.to_not raise_error
+        expect { PreprocessedWordValidatable.validate_prepreprocessed_word(preprocessed_word: preprocessed_word_object) }.not_to raise_error
       end
     end
 
     context 'when the object is INVALID' do
       context 'when #original_word is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :original_word }
 
         it 'raises an eror' do
@@ -51,6 +52,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #original_word= is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :original_word= }
 
         it 'raises an eror' do
@@ -60,6 +62,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessed_word is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessed_word }
 
         it 'raises an eror' do
@@ -69,6 +72,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessed_word= is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessed_word= }
 
         it 'raises an eror' do
@@ -78,6 +82,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessed is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessed }
 
         it 'raises an eror' do
@@ -87,6 +92,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessed= is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessed= }
 
         it 'raises an eror' do
@@ -96,6 +102,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessed? is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessed? }
 
         it 'raises an eror' do
@@ -105,6 +112,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessor is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessor }
 
         it 'raises an eror' do
@@ -114,6 +122,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessor= is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessor= }
 
         it 'raises an eror' do
@@ -123,6 +132,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessor_order is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessor_order }
 
         it 'raises an eror' do
@@ -132,6 +142,7 @@ RSpec.describe LittleWeasel::Preprocessors::PreprocessedWordValidatable, type: :
 
       context 'when #preprocessor_order= is missing' do
         before { allow(preprocessed_word_object).to receive(:respond_to?).with(method).and_return(false) }
+
         let(:method) { :preprocessor_order= }
 
         it 'raises an eror' do