LittleWeasel 5.0.4 → 5.0.6

data/spec/lib/LittleWeasel/filters/en_us/numeric_filter_spec.rb

@@ -5,34 +5,34 @@ require 'spec_helper'
 RSpec.describe LittleWeasel::Filters::EnUs::NumericFilter do
   subject { described_class.new }
 
-  #filter_match?
+  # filter_match?
   describe 'filter_match?' do
+    let(:word) { 1 }
+
     context 'when word is a number' do
       it 'returns true' do
-        expect(subject.filter_match?('-1.00')).to eq true
-        expect(subject.filter_match?('-1')).to eq true
-        expect(subject.filter_match?('0')).to eq true
-        expect(subject.filter_match?('1')).to eq true
-        expect(subject.filter_match?('100')).to eq true
-        expect(subject.filter_match?('100.10')).to eq true
-        expect(subject.filter_match?(1234_56)).to eq true
-        expect(subject.filter_match?('+100.0')).to eq true
-        expect(subject.filter_match?(1_000_000.00)).to eq true
-        expect(subject.filter_match?(1_000_000.10)).to eq true
-        expect(subject.filter_match?(1_000_000.01)).to eq true
+        expect(subject.filter_match?('-1.00')).to be true
+        expect(subject.filter_match?('-1')).to be true
+        expect(subject.filter_match?('0')).to be true
+        expect(subject.filter_match?('1')).to be true
+        expect(subject.filter_match?('100')).to be true
+        expect(subject.filter_match?('100.10')).to be true
+        expect(subject.filter_match?(123_456)).to be true
+        expect(subject.filter_match?('+100.0')).to be true
+        expect(subject.filter_match?(1_000_000.00)).to be true
+        expect(subject.filter_match?(1_000_000.10)).to be true
+        expect(subject.filter_match?(1_000_000.01)).to be true
       end
     end
 
     context 'when word is NOT a number' do
       it 'returns false' do
-        expect(subject.filter_match? 'a').to eq false
-        expect(subject.filter_match? :a).to eq false
-        expect(subject.filter_match? Object.new).to eq false
+        expect(subject.filter_match?('a')).to be false
+        expect(subject.filter_match?(:a)).to be false
+        expect(subject.filter_match?(Object.new)).to be false
       end
     end
 
-    let(:word) { 1 }
-
     context 'when #filter_match? returns true' do
       before { allow(subject.class).to receive(:filter_match?).and_return(true) }
 

data/spec/lib/LittleWeasel/filters/en_us/single_character_word_filter_spec.rb

@@ -5,26 +5,26 @@ require 'spec_helper'
 RSpec.describe LittleWeasel::Filters::EnUs::SingleCharacterWordFilter do
   subject { described_class.new }
 
-  #filter_match?
+  # filter_match?
   describe '#filter_match?' do
+    let(:word) { 'x' }
+
     context 'when word single character word' do
       it 'returns true' do
-        %w(a A I).each do |number|
-          expect(subject.filter_match? number).to eq true
+        %w[a A I].each do |number|
+          expect(subject.filter_match?(number)).to be true
         end
       end
     end
 
     context 'when word is NOT a single character word' do
       it 'returns false' do
-        expect(subject.filter_match? 'X').to eq false
-        expect(subject.filter_match? :a).to eq false
-        expect(subject.filter_match? Object.new).to eq false
+        expect(subject.filter_match?('X')).to be false
+        expect(subject.filter_match?(:a)).to be false
+        expect(subject.filter_match?(Object.new)).to be false
       end
     end
 
-    let(:word) { 'x' }
-
     context 'when #filter_match? returns true' do
       before { allow(subject.class).to receive(:filter_match?).and_return(true) }
 

data/spec/lib/LittleWeasel/filters/word_filter_managable_spec.rb

@@ -3,10 +3,6 @@
 require 'spec_helper'
 
 RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
-  include_context 'mock word filters'
-
-  WordFilterManagable = described_class
-
   subject do
     Class.new do
       include WordFilterManagable
@@ -18,10 +14,14 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
     end.new(word_filters)
   end
 
+  include_context 'mock word filters'
+
+  WordFilterManagable = described_class
+
   let(:word_filters) { [numeric_filter] }
   let(:numeric_filter) { LittleWeasel::Filters::EnUs::NumericFilter.new }
 
-  #clear_filters
+  # clear_filters
   describe '#clear_filters' do
     it 'sets #word_filters to an empty Array ([])' do
       expect { subject.clear_filters }.to \
@@ -29,7 +29,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
     end
   end
 
-  #add_filters
+  # add_filters
   describe '#add_filters' do
     context 'when argument word_filters is nil' do
       context 'when no block is passed' do
@@ -57,7 +57,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
 
     context 'when argument word_filters is a blank Array ([])' do
       it 'nothing is changed' do
-        expect { subject.add_filters(word_filters: []) }.to_not change { subject.word_filters.count }.from(subject.word_filters.count)
+        expect { subject.add_filters(word_filters: []) }.not_to change { subject.word_filters.count }.from(subject.word_filters.count)
       end
     end
 
@@ -93,7 +93,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
     end
   end
 
-  #replace_filters
+  # replace_filters
   describe '#replace_filters' do
     it 'replaces any existing word filters' do
       expect(subject.word_filters.count).to eq 1
@@ -104,7 +104,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
     end
   end
 
-  #filters_on=
+  # filters_on=
   describe '#filters_on=' do
     context 'when a boolean is not passed' do
       it 'raises an error' do
@@ -114,10 +114,10 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
 
     context 'when true is assigned' do
       it 'turns all the filters on' do
-        expect(subject.word_filters.count).to_not be_zero
-        expect(subject.word_filters.all? { |word_filter| word_filter.filter_on? })
+        expect(subject.word_filters.count).not_to be_zero
+        expect(subject.word_filters.all?(&:filter_on?))
         subject.filters_on = true
-        expect(subject.word_filters.all? { |word_filter| word_filter.filter_off? })
+        expect(subject.word_filters.all?(&:filter_off?))
       end
     end
 
@@ -127,15 +127,15 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
       end
 
       it 'turns all the filters off' do
-        expect(subject.word_filters.count).to_not be_zero
-        expect(subject.word_filters.all? { |word_filter| word_filter.filter_off? })
+        expect(subject.word_filters.count).not_to be_zero
+        expect(subject.word_filters.all?(&:filter_off?))
         subject.filters_on = false
-        expect(subject.word_filters.all? { |word_filter| word_filter.filter_on? })
+        expect(subject.word_filters.all?(&:filter_on?))
       end
     end
   end
 
-  #filter_match?
+  # filter_match?
   describe '#filter_match?' do
     context 'when argument word is not a String' do
       let(:word) { :not_a_string }
@@ -149,7 +149,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
       let(:word) { '' }
 
       it 'returns false' do
-        expect(subject.filter_match? word).to eq false
+        expect(subject.filter_match?(word)).to be false
       end
     end
 
@@ -161,7 +161,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
       let(:word) { '123456789' }
 
       it 'returns true' do
-        expect(subject.filter_match? word).to eq true
+        expect(subject.filter_match?(word)).to be true
       end
     end
 
@@ -173,7 +173,7 @@ RSpec.describe LittleWeasel::Filters::WordFilterManagable, type: :module do
       let(:word) { '123456789' }
 
       it 'returns false' do
-        expect(subject.filter_match? word).to eq false
+        expect(subject.filter_match?(word)).to be false
       end
     end
   end

data/spec/lib/LittleWeasel/filters/word_filter_spec.rb

@@ -5,29 +5,29 @@ require 'spec_helper'
 RSpec.describe LittleWeasel::Filters::WordFilter do
   subject { described_class.new }
 
-  #.new
+  # .new
   describe '.new' do
     it 'instantiates the object' do
-      expect { subject }.to_not raise_error
+      expect { subject }.not_to raise_error
     end
 
     it 'sets #filter_on to true by default' do
-      expect(subject.filter_on).to eq true
+      expect(subject.filter_on).to be true
     end
   end
 
-  #filter_off!
+  # filter_off!
   describe '#filter_off!' do
     before do
       subject.filter_off!
     end
 
     it 'sets the filter off' do
-      expect(subject.filter_off?).to eq true
+      expect(subject.filter_off?).to be true
     end
   end
 
-  #filter_on
+  # filter_on
   describe '#filter_on' do
     context 'when set to true' do
       before do
@@ -35,7 +35,7 @@ RSpec.describe LittleWeasel::Filters::WordFilter do
       end
 
       it 'returns true' do
-        expect(subject.filter_on).to eq true
+        expect(subject.filter_on).to be true
       end
     end
 
@@ -45,35 +45,35 @@ RSpec.describe LittleWeasel::Filters::WordFilter do
       end
 
       it 'returns false' do
-        expect(subject.filter_on).to eq false
+        expect(subject.filter_on).to be false
       end
     end
   end
 
-  #filter_on=
+  # filter_on=
   describe '#filter_on=' do
     context 'when argument value is valid' do
       context 'when true' do
         before do
           subject.filter_on = false
-          expect(subject.filter_off?).to eq true
+          expect(subject.filter_off?).to be true
         end
 
         it 'sets #filter_on to true' do
           subject.filter_on = true
-          expect(subject.filter_on).to eq true
+          expect(subject.filter_on).to be true
         end
       end
 
       context 'when false' do
         before do
           subject.filter_on = true
-          expect(subject.filter_on?).to eq true
+          expect(subject.filter_on?).to be true
         end
 
         it 'sets #filter_on to false' do
           subject.filter_on = false
-          expect(subject.filter_on).to eq false
+          expect(subject.filter_on).to be false
         end
       end
     end
@@ -89,24 +89,24 @@ RSpec.describe LittleWeasel::Filters::WordFilter do
     end
   end
 
-  #filter_on?
+  # filter_on?
   describe '#filter_on?' do
     context 'when #filter_on is true' do
       it 'returns true' do
         subject.filter_on = true
-        expect(subject.filter_on?).to eq true
+        expect(subject.filter_on?).to be true
       end
     end
 
     context 'when #filter_on is false' do
       it 'returns false' do
         subject.filter_on = false
-        expect(subject.filter_on?).to eq false
+        expect(subject.filter_on?).to be false
       end
     end
   end
 
-  #filter_match?
+  # filter_match?
   describe '#filter_match?' do
     let(:word) { 'word' }
 

data/spec/lib/LittleWeasel/filters/word_filter_validatable_spec.rb

@@ -13,12 +13,23 @@ RSpec.describe LittleWeasel::Filters::WordFilterValidatable, type: :module do
 
   let(:filter_class) do
     filter = Class.new do
-      def filter_on?; end
-      def filter_off?; end
-      def filter_on; end
-      def filter_on=; end
-      def filter_match?; end
-      def self.filter_match?; end
+      def filter_on?
+      end
+
+      def filter_off?
+      end
+
+      def filter_on
+      end
+
+      def filter_on=
+      end
+
+      def filter_match?
+      end
+
+      def self.filter_match?
+      end
     end
     filter
   end
@@ -28,17 +39,18 @@ RSpec.describe LittleWeasel::Filters::WordFilterValidatable, type: :module do
   end
   let(:expected_error_message) { "Argument word_filter does not quack right: #{numeric_filter.class}" }
 
-  #validate_word_filter
+  # validate_word_filter
   describe '#validate_word_filter' do
     context 'when argument word_filter quacks correctly' do
       it 'does not raise an error' do
-        expect { subject.validate_word_filter(word_filter: numeric_filter) }.to_not raise_error
+        expect { subject.validate_word_filter(word_filter: numeric_filter) }.not_to raise_error
       end
     end
 
     context 'when argument word_filter DOES NOT quack correctly to the right instance methods' do
       context 'when word_filter does not respond to #filter_on?' do
-        before { numeric_filter.instance_eval("undef #{method_to_check}") }
+        before { numeric_filter.instance_eval("undef #{method_to_check}", __FILE__, __LINE__) }
+
         let(:method_to_check) { :filter_on? }
 
         it 'raises an error' do
@@ -48,7 +60,8 @@ RSpec.describe LittleWeasel::Filters::WordFilterValidatable, type: :module do
       end
 
       context 'when word_filter does not respond to #filter_on' do
-        before { numeric_filter.instance_eval("undef #{method_to_check}") }
+        before { numeric_filter.instance_eval("undef #{method_to_check}", __FILE__, __LINE__) }
+
         let(:method_to_check) { :filter_on }
 
         it 'raises an error' do
@@ -58,7 +71,8 @@ RSpec.describe LittleWeasel::Filters::WordFilterValidatable, type: :module do
       end
 
       context 'when word_filter does not respond to #filter_on=' do
-        before { numeric_filter.instance_eval("undef #{method_to_check}") }
+        before { numeric_filter.instance_eval("undef #{method_to_check}", __FILE__, __LINE__) }
+
         let(:method_to_check) { :filter_on= }
 
         it 'raises an error' do
@@ -68,7 +82,8 @@ RSpec.describe LittleWeasel::Filters::WordFilterValidatable, type: :module do
       end
 
       context 'when word_filter does not respond to #filter_match?' do
-        before { numeric_filter.instance_eval("undef #{method_to_check}") }
+        before { numeric_filter.instance_eval("undef #{method_to_check}", __FILE__, __LINE__) }
+
         let(:method_to_check) { :filter_match? }
 
         it 'raises an error' do

data/spec/lib/LittleWeasel/filters/word_filters_validatable_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe LittleWeasel::Filters::WordFiltersValidatable, type: :module do
+  subject { Subject.new }
+
   include_context 'mock word filters'
 
   WordFiltersValidatable = described_class
@@ -11,8 +13,6 @@ RSpec.describe LittleWeasel::Filters::WordFiltersValidatable, type: :module do
     include WordFiltersValidatable
   end
 
-  subject { Subject.new }
-
   let(:word_filters) do
     [
       WordFilter01.new,
@@ -21,10 +21,10 @@ RSpec.describe LittleWeasel::Filters::WordFiltersValidatable, type: :module do
   end
   let(:expected_error_message) { "Argument word_filter does not quack right: #{numeric_filter.class}" }
 
-  #validate_word_filters
+  # validate_word_filters
   describe '#validate_word_filters' do
     context 'when argument word_filters is not an Array' do
-      let(:word_filters) { :not_an_array}
+      let(:word_filters) { :not_an_array }
 
       it 'raises an error' do
         expect { subject.validate_word_filters(word_filters: word_filters) }.to raise_error "Argument word_filters is not an Array: #{word_filters.class}"
@@ -33,7 +33,7 @@ RSpec.describe LittleWeasel::Filters::WordFiltersValidatable, type: :module do
 
     context 'when argument word_filters contains valid word filters' do
       it 'does not raise an error' do
-        expect { subject.validate_word_filters(word_filters: word_filters) }.to_not raise_error
+        expect { subject.validate_word_filters(word_filters: word_filters) }.not_to raise_error
       end
     end
 
@@ -41,7 +41,7 @@ RSpec.describe LittleWeasel::Filters::WordFiltersValidatable, type: :module do
       let(:word_filters) { [Object.new] }
 
       it 'does not raise an error' do
-        expect { subject.validate_word_filters(word_filters: word_filters) }.to raise_error  "Argument word_filter does not quack right: #{word_filters[0].class}"
+        expect { subject.validate_word_filters(word_filters: word_filters) }.to raise_error "Argument word_filter does not quack right: #{word_filters[0].class}"
       end
     end
   end

data/spec/lib/LittleWeasel/integraton_tests/dictionary_integration_spec.rb

@@ -3,12 +3,12 @@
 require 'spec_helper'
 
 RSpec.describe 'Dictionary integration', type: :integration do
+  subject { create(:dictionary_manager) }
+
   include_context 'dictionary keys'
   include_context 'mock word preprocessors'
 
-  subject { create(:dictionary_manager) }
-
-  before(:each) { LittleWeasel.configure { |config| config.reset } }
+  before { LittleWeasel.configure(&:reset) }
 
   let(:dictionary) do
     subject.create_dictionary_from_file(dictionary_key: dictionary_key, file: dictionary_file_path,
@@ -22,7 +22,7 @@ RSpec.describe 'Dictionary integration', type: :integration do
   let(:word_filters) {}
   let(:word_preprocessors) {}
 
-  #word_results
+  # word_results
   describe '#word_results' do
     describe 'when using word filters' do
       let(:word_filters) { [LittleWeasel::Filters::EnUs::NumericFilter.new] }
@@ -32,11 +32,11 @@ RSpec.describe 'Dictionary integration', type: :integration do
         let(:word_results) { dictionary.word_results(number) }
 
         it '#success? returns true' do
-          expect(word_results.success?).to eq true
+          expect(word_results.success?).to be true
         end
 
         it '#filter_match? returns true' do
-          expect(word_results.filter_match?).to eq true
+          expect(word_results.filter_match?).to be true
         end
 
         it '#filters_matched returns the filter(s) that were matched' do
@@ -44,7 +44,7 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_valid? returns false' do
-          expect(word_results.word_valid?).to eq false
+          expect(word_results.word_valid?).to be false
         end
 
         it '#original_word returns the original word' do
@@ -60,12 +60,12 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_cached? returns false if the word is not in the dictionary' do
-          expect(word_results.word_cached?).to eq false
+          expect(word_results.word_cached?).to be false
         end
 
         it '#word_cached? returns true 2nd-nth time the word was searched if invalid words are being cached by any metadata processing' do
           dictionary.word_results(number)
-          expect(word_results.word_cached?).to eq true
+          expect(word_results.word_cached?).to be true
         end
       end
 
@@ -77,11 +77,11 @@ RSpec.describe 'Dictionary integration', type: :integration do
         let(:word_results) { dictionary.word_results(number) }
 
         it '#success? returns false' do
-          expect(word_results.success?).to eq false
+          expect(word_results.success?).to be false
         end
 
         it '#filter_match? returns false' do
-          expect(word_results.filter_match?).to eq false
+          expect(word_results.filter_match?).to be false
         end
 
         it '#filters_matched returns an empty Array' do
@@ -89,7 +89,7 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_valid? returns false' do
-          expect(word_results.word_valid?).to eq false
+          expect(word_results.word_valid?).to be false
         end
 
         it '#original_word returns the original word' do
@@ -105,12 +105,12 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_cached? returns false if the word is not in the dictionary' do
-          expect(word_results.word_cached?).to eq false
+          expect(word_results.word_cached?).to be false
         end
 
         it '#word_cached? returns true 2nd-nth time the word was searched if invalid words are being cached by any metadata processing' do
           dictionary.word_results(number)
-          expect(word_results.word_cached?).to eq true
+          expect(word_results.word_cached?).to be true
         end
       end
     end
@@ -122,11 +122,11 @@ RSpec.describe 'Dictionary integration', type: :integration do
 
       context 'with preprocessors turned on' do
         it '#success? returns true' do
-          expect(word_results.success?).to eq true
+          expect(word_results.success?).to be true
         end
 
         it '#filter_match? returns false' do
-          expect(word_results.filter_match?).to eq false
+          expect(word_results.filter_match?).to be false
         end
 
         it '#filters_matched returns the filter(s) that were matched' do
@@ -134,7 +134,7 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_valid? returns true' do
-          expect(word_results.word_valid?).to eq true
+          expect(word_results.word_valid?).to be true
         end
 
         it '#original_word returns the original word' do
@@ -150,7 +150,7 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_cached? returns true if the word is in the dictionary' do
-          expect(word_results.word_cached?).to eq true
+          expect(word_results.word_cached?).to be true
         end
       end
 
@@ -160,11 +160,11 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#success? returns false' do
-          expect(word_results.success?).to eq false
+          expect(word_results.success?).to be false
         end
 
         it '#filter_match? returns false' do
-          expect(word_results.filter_match?).to eq false
+          expect(word_results.filter_match?).to be false
         end
 
         it '#filters_matched returns the filter(s) that were matched' do
@@ -172,7 +172,7 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_valid? returns false' do
-          expect(word_results.word_valid?).to eq false
+          expect(word_results.word_valid?).to be false
         end
 
         it '#original_word returns the original word' do
@@ -188,12 +188,12 @@ RSpec.describe 'Dictionary integration', type: :integration do
         end
 
         it '#word_cached? returns false if the word is not in the dictionary' do
-          expect(word_results.word_cached?).to eq false
+          expect(word_results.word_cached?).to be false
         end
 
         it '#word_cached? returns true 2nd-nth time the word was searched if invalid words are being cached by any metadata processing' do
           dictionary.word_results(word)
-          expect(word_results.word_cached?).to eq true
+          expect(word_results.word_cached?).to be true
         end
       end
     end

data/spec/lib/LittleWeasel/metadata/dictionary_creator_servicable_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe LittleWeasel::Modules::DictionaryCreatorServicable, type: :module do
+  subject { SubjectMock.new(dictionary_key: dictionary_key, dictionary_cache: dictionary_cache, dictionary_metadata: dictionary_metadata, word_filters: word_filters) }
+
   include_context 'dictionary keys'
 
   DictionaryCreatorServicable = described_class
@@ -21,8 +23,6 @@ RSpec.describe LittleWeasel::Modules::DictionaryCreatorServicable, type: :module
     end
   end
 
-  subject { SubjectMock.new(dictionary_key: dictionary_key, dictionary_cache: dictionary_cache, dictionary_metadata: dictionary_metadata, word_filters: word_filters) }
-
   let(:en_us_dictionary_key) { dictionary_key_for(language: :en, region: :us) }
   let(:dictionary_key) { en_us_dictionary_key }
   let(:key) { dictionary_key.key }
@@ -31,24 +31,25 @@ RSpec.describe LittleWeasel::Modules::DictionaryCreatorServicable, type: :module
   let(:dictionary_metadata) { {} }
   let(:word_filters) {}
 
-  #attributes
+  # attributes
   describe 'attributes' do
     it 'responds to the correct attributes' do
       expect(subject).to respond_to(
         :dictionary_key,
         :dictionary_cache,
-        :word_filters)
+        :word_filters
+      )
     end
   end
 
-  #dictionary_creator_service
+  # dictionary_creator_service
   describe '#dictionary_creator_service' do
     it 'responds to #dictionary_creator_service' do
       expect(subject).to respond_to(:dictionary_creator_service)
     end
 
     it 'returns a Services::DictionaryCreatorService object' do
-      expect(subject.dictionary_creator_service).to be_kind_of LittleWeasel::Services::DictionaryCreatorService
+      expect(subject.dictionary_creator_service).to be_a LittleWeasel::Services::DictionaryCreatorService
     end
   end
 end