3llo 1.0.0.pre.rc.0 → 1.0.0

data/lib/3llo/command/board.rb

@@ -1,6 +1,6 @@
-require '3llo/command/board/list'
-require '3llo/command/board/select'
-require '3llo/command/board/invalid'
+require "3llo/command/board/list"
+require "3llo/command/board/select"
+require "3llo/command/board/invalid"
 
 module Tr3llo
   module Command
@@ -9,12 +9,12 @@ module Tr3llo
 
       def execute(subcommand, args)
         case subcommand
-        when 'list'
+        when "list"
           user = Application.fetch_user!()
 
           Command::Board::List.execute(user[:id])
-        when 'select'
-          board_key, _ = args
+        when "select"
+          board_key, = args
           Utils.assert_string!(board_key, "board key is missing")
 
           Command::Board::Select.execute(board_key)

data/lib/3llo/command/card.rb

@@ -1,22 +1,23 @@
-require '3llo/command/card/list'
-require '3llo/command/card/list_mine'
-require '3llo/command/card/show'
-require '3llo/command/card/move'
-require '3llo/command/card/self_assign'
-require '3llo/command/card/assign'
-require '3llo/command/card/invalid'
-require '3llo/command/card/comments'
-require '3llo/command/card/comment'
-require '3llo/command/card/add'
-require '3llo/command/card/archive'
-require '3llo/command/card/add_checklist'
-require '3llo/command/card/edit_checklist'
-require '3llo/command/card/remove_checklist'
-require '3llo/command/card/add_item'
-require '3llo/command/card/check_item'
-require '3llo/command/card/uncheck_item'
-require '3llo/command/card/edit_item'
-require '3llo/command/card/remove_item'
+require "3llo/command/card/list"
+require "3llo/command/card/list_mine"
+require "3llo/command/card/edit"
+require "3llo/command/card/show"
+require "3llo/command/card/move"
+require "3llo/command/card/self_assign"
+require "3llo/command/card/assign"
+require "3llo/command/card/invalid"
+require "3llo/command/card/comments"
+require "3llo/command/card/comment"
+require "3llo/command/card/add"
+require "3llo/command/card/archive"
+require "3llo/command/card/add_checklist"
+require "3llo/command/card/edit_checklist"
+require "3llo/command/card/remove_checklist"
+require "3llo/command/card/add_item"
+require "3llo/command/card/check_item"
+require "3llo/command/card/uncheck_item"
+require "3llo/command/card/edit_item"
+require "3llo/command/card/remove_item"
 
 module Tr3llo
   module Command
@@ -25,100 +26,101 @@ module Tr3llo
 
       def execute(subcommand, args)
         case subcommand
-        when 'list'
-          is_mine, _ = *args
+        when "list"
           board = Application.fetch_board!()
 
-          if is_mine == 'mine'
-            user = Application.fetch_user!()
-            Command::Card::ListMine.execute(board[:id], user[:id])
-          elsif is_mine.nil?
-            Command::Card::List.execute(board[:id])
-          else
-            command_string = "card list #{is_mine}"
-            raise InvalidArgumentError.new("#{command_string.inspect} is not a valid command")
-          end
-        when 'add'
+          Command::Card::List.execute(board.id)
+        when "list-mine"
+          board = Application.fetch_board!()
+          user = Application.fetch_user!()
+
+          Command::Card::ListMine.execute(board.id, user.id)
+        when "add"
           board = Application.fetch_board!()
           Command::Card::Add.execute(board[:id])
-        when 'show'
-          card_key, _ = args
+        when "show"
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::Show.execute(card_key)
-        when 'comments'
-          card_key, _ = args
+        when "edit"
+          card_key, = args
+          Utils.assert_string!(card_key, "card key is missing")
+
+          Command::Card::Edit.execute(card_key)
+        when "comments"
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::Comments.execute(card_key)
-        when 'comment'
-          card_key, _ = args
+        when "comment"
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::Comment.execute(card_key)
-        when 'move'
+        when "move"
           board = Application.fetch_board!()
-          card_key, _ = args
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::Move.execute(card_key, board[:id])
-        when 'self-assign'
+        when "self-assign"
           user = Application.fetch_user!()
-          card_key, _ = args
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::SelfAssign.execute(card_key, user[:id])
-        when 'assign'
+        when "assign"
           board = Application.fetch_board!()
-          card_key, _ = args
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::Assign.execute(card_key, board[:id])
-        when 'archive'
-          card_key, _ = args
+        when "archive"
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::Archive.execute(card_key)
         when "add-checklist"
-          card_key, _ = args
+          card_key, = args
           Utils.assert_string!(card_key, "card key is missing")
 
           Command::Card::AddChecklist.execute(card_key)
         when "edit-checklist"
-          checklist_key, _ = args
+          checklist_key, = args
           Utils.assert_string!(checklist_key, "checklist key is missing")
 
           Command::Card::EditChecklist.execute(checklist_key)
         when "remove-checklist"
-          checklist_key, _ = args
+          checklist_key, = args
           Utils.assert_string!(checklist_key, "checklist key is missing")
 
           Command::Card::RemoveChecklist.execute(checklist_key)
         when "add-item"
-          checklist_key, _ = args
+          checklist_key, = args
           Utils.assert_string!(checklist_key, "checklist key is missing")
 
           Command::Card::AddItem.execute(checklist_key)
         when "check-item"
-          card_key, check_item_key, _ = args
+          card_key, check_item_key, = args
           Utils.assert_string!(card_key, "card key is missing")
           Utils.assert_string!(check_item_key, "item key is missing")
 
           Command::Card::CheckItem.execute(card_key, check_item_key)
         when "uncheck-item"
-          card_key, check_item_key, _ = args
+          card_key, check_item_key, = args
           Utils.assert_string!(card_key, "card key is missing")
           Utils.assert_string!(check_item_key, "item key is missing")
 
           Command::Card::UncheckItem.execute(card_key, check_item_key)
         when "edit-item"
-          card_key, check_item_key, _ = args
+          card_key, check_item_key, = args
           Utils.assert_string!(card_key, "card key is missing")
           Utils.assert_string!(check_item_key, "item key is missing")
 
           Command::Card::EditItem.execute(card_key, check_item_key)
         when "remove-item"
-          card_key, check_item_key, _ = args
+          card_key, check_item_key, = args
           Utils.assert_string!(card_key, "card key is missing")
           Utils.assert_string!(check_item_key, "item key is missing")
 

data/lib/3llo/command/card/assign.rb

@@ -33,14 +33,14 @@ module Tr3llo
         def select_user(interface, card, board_id)
           user_options =
             API::User.find_all_by_board(board_id)
-            .map { |user| [user.username, user.id] }
-            .to_h()
+              .map { |user| [user.username, user.id] }
+              .to_h()
 
           member_ids =
             card.members.flat_map do |member|
               index = user_options.find_index { |_username, user_id| user_id == member.id }
 
-              if index then [index + 1] else [] end
+              index ? [index + 1] : []
             end
 
           interface.input.multi_select(

data/lib/3llo/command/card/edit.rb

@@ -0,0 +1,33 @@
+module Tr3llo
+  module Command
+    module Card
+      module Edit
+        extend self
+
+        def execute(card_key)
+          card_id = Entities.parse_id(:card, card_key)
+          assert_card_id!(card_id, card_key)
+
+          card = API::Card.find(card_id)
+
+          interface = Application.fetch_interface!()
+
+          interface.print_frame do
+            name = interface.input.ask("Name:", required: true, value: card.name)
+            description = interface.input.ask("Description:", value: card.description)
+
+            API::Card.update(card_id, {"name" => name, "desc" => description})
+
+            interface.puts("Card has been updated.")
+          end
+        end
+
+        private
+
+        def assert_card_id!(card_id, key)
+          raise InvalidArgumentError.new("#{key.inspect} is not a valid list key") unless card_id
+        end
+      end
+    end
+  end
+end

data/lib/3llo/command/card/move.rb

@@ -23,9 +23,9 @@ module Tr3llo
         def select_list(interface, board_id)
           list_options =
             API::List
-            .find_all_by_board(board_id)
-            .map { |list| [list.name, list.id] }
-            .to_h()
+              .find_all_by_board(board_id)
+              .map { |list| [list.name, list.id] }
+              .to_h()
 
           interface.input.select(
             "Choose the list to be moved to",

data/lib/3llo/command/card/self_assign.rb

@@ -8,7 +8,7 @@ module Tr3llo
           card_id = Entities.parse_id(:card, key)
           assert_card_id!(card_id, key)
 
-          card = assign_card(card_id, user_id)
+          assign_card(card_id, user_id)
 
           interface = Application.fetch_interface!()
 
@@ -21,7 +21,7 @@ module Tr3llo
 
         def assign_card(card_id, user_id)
           card = API::Card.find(card_id)
-          members = card.members.map { |member| member.id } + [user_id]
+          members = card.members.map(&:id) + [user_id]
 
           API::Card.assign_members(card_id, members)
         end

data/lib/3llo/command/list.rb

@@ -1,7 +1,7 @@
-require '3llo/command/list/list'
-require '3llo/command/list/cards'
-require '3llo/command/list/invalid'
-require '3llo/command/list/archive_cards'
+require "3llo/command/list/list"
+require "3llo/command/list/cards"
+require "3llo/command/list/invalid"
+require "3llo/command/list/archive_cards"
 
 module Tr3llo
   module Command
@@ -10,17 +10,17 @@ module Tr3llo
 
       def execute(subcommand, args)
         case subcommand
-        when 'list'
+        when "list"
           board = Application.fetch_board!()
 
           Command::List::List.execute(board[:id])
-        when 'cards'
-          list_key, _ = args
+        when "cards"
+          list_key, = args
           Utils.assert_string!(list_key, "list key is missing")
 
           Command::List::Cards.execute(list_key)
-        when 'archive-cards'
-          list_key, _ = args
+        when "archive-cards"
+          list_key, = args
           Utils.assert_string!(list_key, "list key is missing")
 
           Command::List::ArchiveCards.execute(list_key)

data/lib/3llo/controller.rb

@@ -1,37 +1,36 @@
-require 'readline'
+require "readline"
 
 module Tr3llo
   module Controller
     extend self
 
     def start(init_command)
-      list = %w(board card help list mine move select self-assign show)
-      auto_completion = proc { |s| list.grep( /^#{Regexp.escape(s)}/ ) }
-
-      Readline.completion_append_character = " "
-      Readline.completion_proc = auto_completion
+      Readline.completion_append_character = "   "
+      Readline.completion_proc = lambda { |buffer|
+        Command.generate_suggestions(buffer, Readline.line_buffer)
+      }
 
       interface = Application.fetch_interface!()
 
       if init_command && init_command != ""
         interface.puts("Executing " + Utils.format_highlight(init_command) + " command")
 
-        execute_command!(init_command, interface)
+        execute_command!(init_command)
       end
 
       loop do
         command_buffer = Readline.readline("\e[15;48;5;27m 3llo \e[0m > ", true)
 
-        execute_command!(command_buffer, interface)
+        execute_command!(command_buffer)
       end
     rescue Interrupt
       Command::Exit.execute()
     end
 
-    def execute_command!(command_buffer, interface)
+    private
+
+    def execute_command!(command_buffer)
       Tr3llo::Command.execute(command_buffer.strip())
-    rescue Tr3llo::HTTP::Client::RequestError => e
-      interface.print_frame { interface.print_error(e.message) }
     end
   end
 end

data/lib/3llo/entities.rb

@@ -2,7 +2,7 @@ module Tr3llo
   module Entities
     extend self
 
-    SHORTCUT_PREFIX = "#"
+    SHORTCUT_PREFIX = "#".freeze
 
     InvalidKeyError = Class.new(ArgumentError)
     InvalidIDError = Class.new(ArgumentError)

data/lib/3llo/interface.rb

@@ -1,7 +1,8 @@
 module Tr3llo
   class Interface
     def initialize(input, output)
-      @input, @output = input, output
+      @input = input
+      @output = output
     end
 
     def print_frame
@@ -15,7 +16,7 @@ module Tr3llo
       output.puts(str)
     end
 
-    alias :puts :print_line
+    alias puts print_line
 
     def print(str)
       output.print(str)

data/lib/3llo/registry.rb

@@ -16,11 +16,10 @@ module Tr3llo
             shortcut_to_id: {}
           })
 
-        id_to_key = data[:id_to_shortcut]
-        key_to_id = data[:shortcut_to_id]
+        id_to_shortcut = data[:id_to_shortcut]
 
-        if id_to_key.key?(id)
-          id_to_key.fetch(id)
+        if id_to_shortcut.has_key?(id)
+          id_to_shortcut.fetch(id)
         else
           counter = data[:counter] + 1
           shortcut = counter.to_s

data/lib/3llo/remote_server.rb

@@ -0,0 +1,97 @@
+require "net/http"
+
+module Tr3llo
+  class RemoteServer
+    attr_reader :endpoint_url
+
+    EXPECTED_CODES = ["200"].freeze
+
+    class RequestError < ::StandardError
+      attr_reader :response
+
+      def initialize(response)
+        @response = response
+        super()
+      end
+
+      def message
+        formatted_response = "status: " + response.code.inspect() + ", body: " + response.body.inspect()
+
+        "Received unexpected response from remote server: " + formatted_response
+      end
+    end
+
+    def initialize(endpoint_url)
+      @endpoint_url = endpoint_url
+    end
+
+    def get(req_path, req_headers, expected_codes = EXPECTED_CODES)
+      req_uri = build_request_uri(req_path)
+      req_headers = {"accept" => "application/json"}.merge(req_headers)
+
+      dispatch(Net::HTTP::Get.new(req_uri, req_headers), expected_codes)
+    end
+
+    def post(req_path, req_headers, payload, expected_codes = EXPECTED_CODES)
+      req_uri = build_request_uri(req_path)
+
+      req_headers = {
+        "accept" => "application/json",
+        "content-type" => "application/json"
+      }.merge(req_headers)
+
+      request = Net::HTTP::Post.new(req_uri, req_headers)
+      request.body = JSON.dump(payload)
+
+      dispatch(request, expected_codes)
+    end
+
+    def put(req_path, req_headers, payload, expected_codes = EXPECTED_CODES)
+      req_uri = build_request_uri(req_path)
+
+      req_headers = {
+        "Accept" => "application/json",
+        "Content-Type" => "application/json"
+      }.merge(req_headers)
+
+      request = Net::HTTP::Put.new(req_uri, req_headers)
+      request.body = JSON.dump(payload)
+
+      dispatch(request, expected_codes)
+    end
+
+    def delete(req_path, req_headers, payload, expected_codes = EXPECTED_CODES)
+      req_uri = build_request_uri(req_path)
+
+      req_headers = {
+        "Accept" => "application/json",
+        "Content-Type" => "application/json"
+      }.merge(req_headers)
+
+      request = Net::HTTP::Delete.new(req_uri, req_headers)
+      request.body = JSON.dump(payload)
+
+      dispatch(request, expected_codes)
+    end
+
+    private
+
+    def build_request_uri(req_path)
+      URI.parse(endpoint_url + req_path)
+    end
+
+    def dispatch(request, expected_status_codes)
+      req_uri = request.uri
+
+      Net::HTTP.start(req_uri.host, req_uri.port, use_ssl: req_uri.scheme == "https") do |http|
+        response = http.request(request)
+
+        if expected_status_codes.include?(response.code)
+          JSON.parse(response.body)
+        else
+          raise RequestError.new(response)
+        end
+      end
+    end
+  end
+end