3llo 1.0.0.pre.rc.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c80cabc5ec119676b74fbcc4bc8690d1a2bf55b2f53358f8069e788e36e4049
-  data.tar.gz: a1690b3ce4cbdb9ded4421f168037f458064769c802def01d21faf1e7f0bbab1
+  metadata.gz: 8e6ca4c800b73fb0a5514e1a87204547c243045b9e3a0b5842f327513b726073
+  data.tar.gz: c6bc2f0e09bd27a558c8914d34734863efce9d6b534d2bae38d5d1267d378eb7
 SHA512:
-  metadata.gz: e4aae96a782fda12b5f87ada27e76a173e04f6dc707f46a45779e2b3c9440833c90e9ab099e35717ad49d55132664f94207f1e9b26c68df1371c7dafd539a70b
-  data.tar.gz: 1d0a9482ace979945ff7f8f25ec6b92cb07e8d1733c9b9a97624aeeeaa319ad29e73eda694c5618a1ef2efe665d51d1be4923e20efea98f03e724d355b403ce9
+  metadata.gz: 035ff3a48dcfe77e558d5eec4e341dcfc78caf0b6d55fa60c91f8a9d56b32a8d8221634e78ec3f34e26fc13c9d10df130017483fd3b9bcfb5aa0c64ce3d19e0f
+  data.tar.gz: 152e793d22f7db0ab50d9504c3d2c2d36051dcfa74293931d368a5e58ec9b176fa34f77215498566947fc6851a33bc9eadc3f891fbe43fa0221be13407d1c9b7

data/.github/workflows/ci.yml

@@ -25,5 +25,9 @@ jobs:
       run: |
         gem install bundler
         bundle install --jobs 4 --retry 3
+    - name: Start httpbin container
+      run: docker run -d -p 8080:80 kennethreitz/httpbin
+    - name: Run Rubocop
+      run: bundle exec rubocop
     - name: Run test
       run: bundle exec rspec

data/.rubocop.yml

@@ -0,0 +1,113 @@
+# The behavior of RuboCop can be controlled via the .rubocop.yml
+# configuration file. It makes it possible to enable/disable
+# certain cops (checks) and to alter their behavior if they accept
+# any parameters. The file can be placed either in your home
+# directory or in some project directory.
+#
+# RuboCop will start looking for the configuration file in the directory
+# where the inspected file is and continue its way up to the root directory.
+#
+# See https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md
+
+AllCops:
+  TargetRubyVersion: 2.5
+
+Layout/LineLength:
+  Max: 120
+
+Layout/DotPosition:
+  EnforcedStyle: leading
+
+Layout/EmptyLinesAroundBlockBody:
+  EnforcedStyle: no_empty_lines
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/HeredocIndentation:
+  Enabled: false
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Layout/SpaceInsideBlockBraces:
+  EnforcedStyle: space
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+Layout/SpaceInsideParens:
+  EnforcedStyle: no_space
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Metrics:
+  Enabled: false
+
+Naming/RescuedExceptionsVariableName:
+  Enabled: false
+
+Security/JSONLoad:
+  Enabled: false
+
+Style/Alias:
+  EnforcedStyle: prefer_alias
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Style/DefWithParentheses:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/GlobalVars:
+  AllowedVariables: ['$application']
+
+Style/GuardClause:
+  Enabled: false
+
+Style/HashSyntax:
+  EnforcedStyle: ruby19
+
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: false
+
+Style/ModuleFunction:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/PreferredHashMethods:
+  EnforcedStyle: verbose
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: no_comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: no_comma
+
+Style/WordArray:
+  EnforcedStyle: percent
+  MinSize: 3
+
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_english_names
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+Style/RaiseArgs:
+  EnforcedStyle: compact

data/3llo.gemspec

@@ -1,7 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require '3llo/version'
+require "3llo/version"
 
 Gem::Specification.new do |spec|
   spec.name = "3llo"
@@ -9,13 +8,13 @@ Gem::Specification.new do |spec|
   spec.authors = ["Cẩm Huỳnh"]
   spec.email = ["huynhquancam@gmail.com"]
 
-  spec.summary = %q{Trello CLI app}
-  spec.description = %q{Interactive CLI application for Trello}
+  spec.summary = "Trello CLI app"
+  spec.description = "Interactive CLI application for Trello"
   spec.homepage = "https://github.com/qcam/3llo"
   spec.license = "MIT"
 
   if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "https://rubygems.org"
+    spec.metadata["allowed_push_host"] = "https://rubygems.org"
   else
     raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
   end
@@ -25,9 +24,10 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^bin/}) { |filename| File.basename(filename) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = '~> 2.5'
+  spec.required_ruby_version = "~> 2.5"
 
-  spec.add_runtime_dependency 'tty-prompt', '~> 0.20'
+  spec.add_runtime_dependency "tty-prompt", "~> 0.20"
 
-  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rubocop", "~> 0.79"
 end

data/CHANGELOG.md

@@ -10,6 +10,8 @@
 * Improve performance of several commands.
 * Support checklist related commands.
 * Support Ruby 2.5+.
+* Introduce `card edit` command.
+* Improve command auto completion.
 
 ## v0.3.1
 

data/Gemfile

@@ -1,7 +1,7 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in trecli.gemspec
 gemspec
 
-gem 'bundler'
-gem 'rake'
+gem "bundler"
+gem "rake"

data/Rakefile

@@ -4,7 +4,7 @@ require "rake/testtask"
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
-  t.test_files = FileList['test/**/*_test.rb']
+  t.test_files = FileList["test/**/*_test.rb"]
 end
 
-task :default => :test
+task default: :test

data/bin/3llo

@@ -1,9 +1,9 @@
 #!/usr/bin/env ruby
 
-$:.unshift File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.unshift File.expand_path("../lib", __dir__)
 require "3llo"
-require 'container'
-require 'tty-prompt'
-require 'optparse'
+require "container"
+require "tty-prompt"
+require "optparse"
 
 Tr3llo::Application.start(ARGV)

data/lib/3llo.rb

@@ -1,17 +1,17 @@
 require "3llo/version"
-require "3llo/http/client"
+require "3llo/remote_server"
 require "3llo/interface"
-require 'container'
-require 'json'
-require 'erb'
+require "container"
+require "json"
+require "erb"
 
-require '3llo/application'
-require '3llo/configuration'
-require '3llo/utils'
-require '3llo/controller'
-require '3llo/errors'
-require '3llo/api'
-require '3llo/view'
-require '3llo/command'
-require '3llo/registry'
-require '3llo/entities'
+require "3llo/application"
+require "3llo/configuration"
+require "3llo/utils"
+require "3llo/controller"
+require "3llo/errors"
+require "3llo/api"
+require "3llo/view"
+require "3llo/command"
+require "3llo/registry"
+require "3llo/entities"

data/lib/3llo/api.rb

@@ -1,6 +1,6 @@
-require '3llo/api/board'
-require '3llo/api/card'
-require '3llo/api/list'
-require '3llo/api/user'
-require '3llo/api/checklist'
-require '3llo/api/token'
+require "3llo/api/board"
+require "3llo/api/card"
+require "3llo/api/list"
+require "3llo/api/user"
+require "3llo/api/checklist"
+require "3llo/api/token"

data/lib/3llo/api/board.rb

@@ -4,45 +4,29 @@ module Tr3llo
       extend self
 
       def find_all_by_user(user_id)
-        JSON.parse(
-          client.get(
+        client = Application.fetch_client!()
+        req_path =
+          Utils.build_req_path(
             "/members/#{user_id}/boards",
-            key: api_key,
-            token: api_token,
-            filter: "open"
+            {"filter" => "open"}
           )
-        ).map do |board_payload|
-          make_struct(board_payload)
-        end
+
+        client
+          .get(req_path, {})
+          .map do |board_payload|
+            make_struct(board_payload)
+          end
       end
 
       def find(board_id)
-        payload =
-          JSON.parse(
-            client.get(
-              "/boards/#{board_id}",
-              key: api_key,
-              token: api_token,
-            )
-          )
+        client = Application.fetch_client!()
+        req_path = Utils.build_req_path("/boards/#{board_id}")
 
-        make_struct(payload)
+        make_struct(client.get(req_path, {}))
       end
 
       private
 
-      def client
-        Application.fetch_client!()
-      end
-
-      def api_key
-        Application.fetch_configuration!().api_key
-      end
-
-      def api_token
-        Application.fetch_configuration!().api_token
-      end
-
       def make_struct(payload)
         id, name = payload.fetch_values("id", "name")
         shortcut = Entities.make_shortcut(:board, id)

data/lib/3llo/api/card.rb

@@ -4,131 +4,116 @@ module Tr3llo
       extend self
 
       def find_all_by_list(list_id)
-        JSON.parse(
-          client.get(
+        req_path =
+          Utils.build_req_path(
             "/lists/#{list_id}/cards",
-            key: api_key,
-            token: api_token,
-            members: 'true',
-            member_fields: "id,username"
+            {"members" => "true", "member_fields" => "id,username"}
           )
-        ).map do |card_payload|
-          make_struct(card_payload)
-        end
+
+        client
+          .get(req_path, {})
+          .map do |card_payload|
+            make_struct(card_payload)
+          end
       end
 
       def find_all_by_user(board_id, user_id)
-        JSON.parse(
-          client.get(
+        req_path =
+          Utils.build_req_path(
             "/boards/#{board_id}/members/#{user_id}/cards",
-            list: true,
-            key: api_key,
-            token: api_token
+            {"list" => "true"}
           )
-        ).map do |card_payload|
-          make_struct(card_payload)
-        end
+
+        client
+          .get(req_path, {})
+          .map do |card_payload|
+            make_struct(card_payload)
+          end
       end
 
       def create(name, description, list_id)
-        client.post(
-          "/cards",
-          key: api_key,
-          token: api_token,
-          name: name,
-          desc: description,
-          idList: list_id
-        )
+        req_path = Utils.build_req_path("/cards", {})
+        payload = {
+          "name" => name,
+          "desc" => description,
+          "idList" => list_id
+        }
+
+        client.post(req_path, {}, payload)
+      end
+
+      def update(card_id, data)
+        req_path = Utils.build_req_path("/cards/#{card_id}")
+
+        client.put(req_path, {}, data)
       end
 
       def find(card_id)
-        card_payload =
-          JSON.parse(
-            client.get(
-              "/cards/#{card_id}",
-              list: true,
-              members: true,
-              key: api_key,
-              token: api_token
-            )
+        req_path =
+          Utils.build_req_path(
+            "/cards/#{card_id}",
+            {"list" => "true", "members" => "true"}
           )
 
+        card_payload = client.get(req_path, {})
+
         make_struct(card_payload)
       end
 
+      # TODO: Use ".update".
       def move_to_list(card_id, list_id)
-        url = "/cards/#{card_id}/idList"
-        JSON.parse(
-          client.put(
-            url,
-            key: api_key,
-            token: api_token,
-            value: list_id
-          )
-        )
+        req_path = Utils.build_req_path("/cards/#{card_id}/idList")
+
+        client.put(req_path, {}, {"value" => list_id})
       end
 
+      # TODO: Use ".update".
       def assign_members(card_id, members)
-        url = "/cards/#{card_id}/idMembers"
-        JSON.parse(
-          client.put(
-            url,
-            key: api_key,
-            token: api_token,
-            value: members.join(',')
-          )
-        )
+        req_path = Utils.build_req_path("/cards/#{card_id}/idMembers")
+
+        client.put(req_path, {}, {"value" => members.join(",")})
       end
 
       def list_comments(card_id)
-        url = "/cards/#{card_id}/actions"
-
-        JSON.parse(
-          client.get(
-            url,
-            key: api_key,
-            token: api_token,
-            filter: "commentCard",
+        req_path =
+          Utils.build_req_path(
+            "/cards/#{card_id}/actions",
+            {"filter" => "commentCard"}
           )
-        ).map do |comment_payload|
-          id, creator_payload, date = comment_payload.fetch_values("id", "memberCreator", "date")
-          text = comment_payload.dig("data", "text")
 
-          created_at = DateTime.iso8601(date)
+        client
+          .get(req_path, {})
+          .map do |comment_payload|
+            id, creator_payload, date = comment_payload.fetch_values("id", "memberCreator", "date")
+            text = comment_payload.dig("data", "text")
 
-          creator_id, creator_username = creator_payload.fetch_values("id", "username")
-          creator = Entities::User.new(creator_id, _creator_shortcut = nil, creator_username)
+            created_at = DateTime.iso8601(date)
 
-          Entities::Comment.new(
-            id: id,
-            creator: creator,
-            created_at: created_at,
-            text: text
-          )
-        end
+            creator_id, creator_username = creator_payload.fetch_values("id", "username")
+            creator = Entities::User.new(creator_id, _creator_shortcut = nil, creator_username)
+
+            Entities::Comment.new(
+              id: id,
+              creator: creator,
+              created_at: created_at,
+              text: text
+            )
+          end
       end
 
       def comment(card_id, text)
-        url = "/cards/#{card_id}/actions/comments"
-        JSON.parse(
-          client.post(
-            url,
-            key: api_key,
-            token: api_token,
-            text: text
-          )
-        )
+        req_path = Utils.build_req_path("/cards/#{card_id}/actions/comments")
+        payload = {"text" => text}
+
+        client.post(req_path, {}, payload)
       end
 
+      # TODO: Use ".update".
       def archive(card_id)
-        url = "/cards/#{card_id}?closed=true"
-        JSON.parse(
-          client.put(
-            url,
-            key: api_key,
-            token: api_token
-          )
-        )
+        req_path = Utils.build_req_path("/cards/#{card_id}")
+        payload = {"closed" => "true"}
+
+        client.put(req_path, {}, payload)
       end
 
       private
@@ -139,8 +124,8 @@ module Tr3llo
 
         members =
           payload
-          .fetch("members", [])
-          .map do |member_payload|
+            .fetch("members", [])
+            .map do |member_payload|
             user_id, username = member_payload.fetch_values("id", "username")
 
             Entities::User.new(user_id, _user_shortcut = nil, username)
@@ -148,8 +133,8 @@ module Tr3llo
 
         labels =
           payload
-          .fetch("labels", [])
-          .map do |label_payload|
+            .fetch("labels", [])
+            .map do |label_payload|
             label_name = label_payload.fetch("name")
             label_color = label_payload["color"]
 
@@ -175,14 +160,6 @@ module Tr3llo
         card
       end
 
-      def api_key
-        Application.fetch_configuration!().api_key
-      end
-
-      def api_token
-        Application.fetch_configuration!().api_token
-      end
-
       def client
         Application.fetch_client!()
       end