zepben.ewb 1.0.0b9__py3-none-any.whl → 1.1.0b1__py3-none-any.whl

zepben/ewb/model/cim/iec61970/base/core/curve.py

@@ -76,7 +76,8 @@ class Curve(IdentifiedObject):
         require(all([it.x_value != x for it in self.data]),
                 lambda: f"Unable to add datapoint to {self}. x_value {x} is invalid, as data with same x_value already exist in this Curve.")
 
-        self._data = self._data or []
+        if self._data is None:
+            self._data = []
         self._data.append(CurveData(x, y1, y2, y3))
         self._data.sort(key=lambda it: it.x_value)
 

zepben/ewb/model/cim/iec61970/base/core/identified_object.py

@@ -34,14 +34,16 @@ class IdentifiedObject(object, metaclass=ABCMeta):
     """Master resource identifier issued by a model authority. The mRID is unique within an exchange context. 
     Global uniqueness is easily achieved by using a UUID, as specified in RFC 4122, for the mRID. The use of UUID is strongly recommended."""
 
-    name: str = ""
+    name: Optional[str] = None
     """The name is any free human readable and possibly non unique text naming the object."""
 
-    description: str = ""
+    description: Optional[str] = None
     """a free human readable text describing or naming the object. It may be non unique and may not correlate to a naming hierarchy."""
 
     _names: Optional[List[Name]] = None
 
+    # TODO: Missing num_diagram_objects: int = None  def has_diagram_objects(self): return (self.num_diagram_objects or 0) > 0
+
     def __init__(self, names: Optional[List[Name]] = None, **kwargs):
         super(IdentifiedObject, self).__init__(**kwargs)
         if names:
@@ -49,7 +51,10 @@ class IdentifiedObject(object, metaclass=ABCMeta):
                 self.add_name(name.type, name.name)
 
     def __str__(self):
-        return f"{self.__class__.__name__}{{{'|'.join(a for a in (str(self.mrid), str(self.name)) if a)}}}"
+        class_name = f'{self.__class__.__name__}'
+        if self.name:
+            return f'{class_name}{{{self.mrid}|{self.name}}}'
+        return f'{class_name}{{{self.mrid}}}'
 
     @property
     def names(self) -> Generator[Name, None, None]:

zepben/ewb/model/cim/iec61970/base/core/name_type.py

@@ -7,7 +7,7 @@ from __future__ import annotations
 
 __all__ = ["NameType"]
 
-from typing import Dict, List, Generator, overload, TYPE_CHECKING, Callable
+from typing import Dict, List, Generator, overload, TYPE_CHECKING, Callable, Optional
 
 from zepben.ewb.dataclassy import dataclass
 from zepben.ewb.model.cim.iec61970.base.core.name import Name
@@ -30,7 +30,7 @@ class NameType:
     name: str
     """Name of the name type."""
 
-    description: str = ""
+    description: Optional[str] = None
     """Description of the name type."""
 
     _names_index: Dict[str, Name] = dict()

zepben/ewb/model/cim/iec61970/base/core/power_system_resource.py

@@ -32,7 +32,7 @@ class PowerSystemResource(IdentifiedObject):
     asset_info: Optional[AssetInfo] = None
     """A subclass of `zepben.ewb.model.cim.iec61968.assets.asset_info.AssetInfo` providing information about the asset associated with this PowerSystemResource."""
 
-    num_controls: int = 0
+    num_controls: Optional[int] = None
     """Number of Control's known to associate with this [PowerSystemResource]"""
 
     _assets: Optional[List[Asset]] = None
@@ -48,7 +48,7 @@ class PowerSystemResource(IdentifiedObject):
         """
         * :return: True if this [PowerSystemResource] has at least 1 Control associated with it, false otherwise.
         """
-        return self.num_controls > 0
+        return nlen(self.num_controls) > 0
 
     def num_assets(self) -> int:
         """

zepben/ewb/model/cim/iec61970/base/meas/analog.py

@@ -5,12 +5,14 @@
 
 __all__ = ["Analog"]
 
+from typing import Optional
+
 from zepben.ewb.model.cim.iec61970.base.meas.measurement import Measurement
 
 
 class Analog(Measurement):
     """Analog represents an analog Measurement."""
 
-    positive_flow_in: bool = False
+    positive_flow_in: Optional[bool] = None
     """If true then this measurement is an active power, reactive power or current with the convention that a positive value measured at the 
     Terminal means power is flowing into the related PowerSystemResource."""

zepben/ewb/model/cim/iec61970/base/wires/energy_consumer.py

@@ -26,7 +26,7 @@ class EnergyConsumer(EnergyConnection):
     customer_count: Optional[int] = None
     """Number of individual customers represented by this demand."""
 
-    grounded: bool = False
+    grounded: Optional[bool] = None
     """Used for Yn and Zn connections. True if the neutral is solidly grounded."""
 
     phase_connection: PhaseShuntConnectionKind = PhaseShuntConnectionKind.D

zepben/ewb/model/cim/iec61970/base/wires/energy_source.py

@@ -69,7 +69,7 @@ class EnergySource(EnergyConnection):
     xn: Optional[float] = None
     """Negative sequence Thevenin reactance."""
 
-    is_external_grid: bool = False
+    is_external_grid: Optional[bool] = None
     """
     True if this energy source represents the higher-level power grid connection to an external grid
     that normally is modelled as the slack bus for power flow calculations.

zepben/ewb/model/cim/iec61970/base/wires/regulating_cond_eq.py

@@ -21,7 +21,7 @@ class RegulatingCondEq(EnergyConnection):
     de-energized. Note that zero-impedance branches can potentially be modeled by other equipment types.
     """
 
-    control_enabled: bool = True
+    control_enabled: Optional[bool] = None
     """Specifies the regulation status of the equipment.  True is regulating, false is not regulating."""
 
     _regulating_control: Optional[RegulatingControl] = None

zepben/ewb/model/cim/iec61970/base/wires/shunt_compensator.py

@@ -20,7 +20,7 @@ class ShuntCompensator(RegulatingCondEq):
     is an individual capacitor or reactor.  A negative value for reactivePerSection indicates that the compensator is
     a reactor. ShuntCompensator is a single terminal device.  Ground is implied.
     """
-    grounded: bool = False
+    grounded: Optional[bool] = None
     """Used for Yn and Zn connections. True if the neutral is solidly grounded. nom_u : The voltage at which the nominal reactive power may be calculated. 
     This should normally be within 10% of the voltage at which the capacitor is connected to the network."""
 

zepben/ewb/model/cim/iec61970/base/wires/synchronous_machine.py

@@ -29,7 +29,7 @@ class SynchronousMachine(RotatingMachine):
     condenser_p: Optional[int] = None
     """Active power consumed (watts) when in condenser mode operation."""
 
-    earthing: bool = False
+    earthing: Optional[bool] = None
     """Indicates whether the generator is earthed. Used for short circuit data exchange according to IEC 60909."""
 
     earthing_star_point_r: Optional[float] = None

zepben/ewb/model/cim/iec61970/base/wires/tap_changer.py

@@ -19,7 +19,7 @@ class TapChanger(PowerSystemResource):
     Mechanism for changing transformer winding tap positions.
     """
 
-    control_enabled: bool = True
+    control_enabled: Optional[bool] = None
     """Specifies the regulation status of the equipment.  True is regulating, false is not regulating."""
 
     neutral_u: Optional[int] = None

zepben/ewb/model/cim/iec61970/base/wires/transformer_end.py

@@ -24,7 +24,7 @@ class TransformerEnd(IdentifiedObject):
     In earlier CIM versions, the TransformerWinding class served a similar purpose, but this class is more flexible
     because it associates to terminal but is not a specialization of ConductingEquipment.
     """
-    grounded: bool = False
+    grounded: Optional[bool] = None
     """(for Yn and Zn connections) True if the neutral is solidly grounded."""
 
     r_ground: Optional[float] = None

zepben/ewb/model/cim/iec61970/base/wires/transformer_star_impedance.py

@@ -21,16 +21,16 @@ class TransformerStarImpedance(IdentifiedObject):
     For transmission networks use PowerTransformerEnd impedances (r, r0, x, x0, b, b0, g and g0).
     """
 
-    r: Optional[float] = 0.0
+    r: Optional[float] = None
     """ r : Resistance of the transformer end. Unit: Ohms  """
 
-    r0: Optional[float] = 0.0
+    r0: Optional[float] = None
     """ r0 : Zero sequence series resistance of the transformer end. Unit: Ohms"""
 
-    x: Optional[float] = 0.0
+    x: Optional[float] = None
     """ x : Positive sequence series reactance  of the transformer end. Unit: Ohms"""
 
-    x0: Optional[float] = 0.0
+    x0: Optional[float] = None
     """ x0 : Zero sequence series reactance of the transformer end. Unit: Ohms"""
 
     transformer_end_info: Optional['TransformerEndInfo'] = None

zepben/ewb/services/common/translator/base_cim2proto.py

@@ -6,10 +6,11 @@
 __all__ = ["identified_object_to_pb", "document_to_pb", "organisation_role_to_pb", "organisation_to_pb"]
 
 import inspect
-from typing import ParamSpec, TypeVar, Callable
+from typing import ParamSpec, TypeVar, Callable, Generator
 
 # noinspection PyPackageRequirements,PyUnresolvedReferences
 from google.protobuf.timestamp_pb2 import Timestamp as PBTimestamp
+from google.protobuf.struct_pb2 import NullValue
 from zepben.protobuf.cim.iec61968.common.Document_pb2 import Document as PBDocument
 from zepben.protobuf.cim.iec61968.common.OrganisationRole_pb2 import OrganisationRole as PBOrganisationRole
 from zepben.protobuf.cim.iec61968.common.Organisation_pb2 import Organisation as PBOrganisation
@@ -38,6 +39,11 @@ def bind_to_pb(func: Callable[P, R]) -> Callable[P, R]:
     inspect.get_annotations(func, eval_str=True)[func.__code__.co_varnames[0]].to_pb = func
     return func
 
+
+def set_or_null(**kwargs):
+    return {f'{k}{"Null" if v is None else "Set"}': v if v is not None else NullValue.NULL_VALUE for k, v in kwargs.items()}
+
+
 ###################
 # IEC61968 Common #
 ###################
@@ -51,12 +57,14 @@ def document_to_pb(cim: Document) -> PBDocument:
 
     return PBDocument(
         io=identified_object_to_pb(cim),
-        title=cim.title,
         createdDateTime=timestamp,
-        authorName=cim.author_name,
-        type=cim.type,
-        status=cim.status,
-        comment=cim.comment
+        **set_or_null(
+            title=cim.title,
+            authorName=cim.author_name,
+            type=cim.type,
+            status=cim.status,
+            comment=cim.comment
+        )
     )
 
 
@@ -81,8 +89,10 @@ def organisation_role_to_pb(cim: OrganisationRole) -> PBOrganisationRole:
 def identified_object_to_pb(cim: IdentifiedObject) -> PBIdentifiedObject:
     return PBIdentifiedObject(
         mRID=str(cim.mrid),
-        name=cim.name,
-        description=cim.description,
+        **set_or_null(
+            name=cim.name,
+            description=cim.description
+        ),
         names=[name_to_pb(name) for name in cim.names]
     )
 
@@ -99,5 +109,7 @@ def name_to_pb(cim: Name) -> PBName:
 def name_type_to_pb(cim: NameType) -> PBNameType:
     return PBNameType(
         name=cim.name,
-        description=cim.description
+        **set_or_null(
+            description=cim.description
+        )
     )

zepben/ewb/services/common/translator/base_proto2cim.py

@@ -54,6 +54,11 @@ def bind_to_cim(func: Callable[P, R]) -> Callable[P, R]:
     inspect.get_annotations(func, eval_str=True)[func.__code__.co_varnames[0]].to_cim = func
     return func
 
+T = TypeVar("T")
+
+def get_nullable(pb: Message, field: str) -> Optional[T]:
+    return getattr(pb, f'{field}Set') if pb.HasField(f'{field}Set') else None
+
 
 ###################
 # IEC61968 Common #
@@ -61,12 +66,12 @@ def bind_to_cim(func: Callable[P, R]) -> Callable[P, R]:
 
 @bind_to_cim
 def document_to_cim(pb: PBDocument, cim: Document, service: BaseService):
-    cim.title = pb.title
+    cim.title = get_nullable(pb, 'title')
     cim.created_date_time = pb.createdDateTime.ToDatetime() if pb.HasField("createdDateTime") else None
-    cim.author_name = pb.authorName
-    cim.type = pb.type
-    cim.status = pb.status
-    cim.comment = pb.comment
+    cim.author_name = get_nullable(pb, 'authorName')
+    cim.type = get_nullable(pb, 'type')
+    cim.status = get_nullable(pb, 'status')
+    cim.comment = get_nullable(pb, 'comment')
 
     identified_object_to_cim(pb.io, cim, service)
 
@@ -94,8 +99,8 @@ def organisation_role_to_cim(pb: PBOrganisationRole, cim: OrganisationRole, serv
 @bind_to_cim
 def identified_object_to_cim(pb: PBIdentifiedObject, cim: IdentifiedObject, service: BaseService):
     cim.mrid = pb.mRID
-    cim.name = pb.name
-    cim.description = pb.description
+    cim.name = get_nullable(pb, 'name')
+    cim.description = get_nullable(pb, 'description')
     [cim.add_name(name_to_cim(name, cim, service).type, name.name) for name in pb.names]
 
 
@@ -120,7 +125,7 @@ def name_type_to_cim(pb: PBNameType, service: BaseService):
         nt = NameType(pb.name)
         service.add_name_type(nt)
 
-    nt.description = pb.description
+    nt.description = get_nullable(pb, 'description')
     return nt
 
 

zepben/ewb/services/customer/translator/customer_cim2proto.py

@@ -16,7 +16,7 @@ from zepben.ewb.model.cim.iec61968.customers.customer import Customer
 from zepben.ewb.model.cim.iec61968.customers.customer_agreement import CustomerAgreement
 from zepben.ewb.model.cim.iec61968.customers.pricing_structure import PricingStructure
 from zepben.ewb.model.cim.iec61968.customers.tariff import Tariff
-from zepben.ewb.services.common.translator.base_cim2proto import document_to_pb, organisation_role_to_pb
+from zepben.ewb.services.common.translator.base_cim2proto import document_to_pb, organisation_role_to_pb, set_or_null, bind_to_pb
 from zepben.ewb.services.common.translator.util import mrid_or_empty
 # noinspection PyProtectedMember
 from zepben.ewb.services.customer.translator.customer_enum_mappers import _map_customer_kind
@@ -26,6 +26,7 @@ from zepben.ewb.services.customer.translator.customer_enum_mappers import _map_c
 # IEC61968 Common #
 ###################
 
+@bind_to_pb
 def agreement_to_pb(cim: Agreement) -> PBAgreement:
     return PBAgreement(doc=document_to_pb(cim))
 
@@ -34,17 +35,21 @@ def agreement_to_pb(cim: Agreement) -> PBAgreement:
 # IEC61968 Customers #
 ######################
 
+@bind_to_pb
 def customer_to_pb(cim: Customer) -> PBCustomer:
     customer = PBCustomer(
         kind=_map_customer_kind.to_pb(cim.kind),
-        specialNeed=cim.special_need,
-        customerAgreementMRIDs=[str(io.mrid) for io in cim.agreements]
+        customerAgreementMRIDs=[str(io.mrid) for io in cim.agreements],
+        **set_or_null(
+            specialNeed=cim.special_need,
+        )
     )
 
     getattr(customer, 'or').CopyFrom(organisation_role_to_pb(cim))
     return customer
 
 
+@bind_to_pb
 def customer_agreement_to_pb(cim: CustomerAgreement) -> PBCustomerAgreement:
     return PBCustomerAgreement(
         agr=agreement_to_pb(cim),
@@ -53,6 +58,7 @@ def customer_agreement_to_pb(cim: CustomerAgreement) -> PBCustomerAgreement:
     )
 
 
+@bind_to_pb
 def pricing_structure_to_pb(cim: PricingStructure) -> PBPricingStructure:
     return PBPricingStructure(
         doc=document_to_pb(cim),
@@ -60,12 +66,6 @@ def pricing_structure_to_pb(cim: PricingStructure) -> PBPricingStructure:
     )
 
 
+@bind_to_pb
 def tariff_to_pb(cim: Tariff) -> PBTariff:
     return PBTariff(doc=document_to_pb(cim))
-
-
-Agreement.to_pb = agreement_to_pb
-Customer.to_pb = customer_to_pb
-CustomerAgreement.to_pb = customer_agreement_to_pb
-PricingStructure.to_pb = pricing_structure_to_pb
-Tariff.to_pb = tariff_to_pb

zepben/ewb/services/customer/translator/customer_proto2cim.py

@@ -16,12 +16,13 @@ from zepben.protobuf.cim.iec61968.customers.PricingStructure_pb2 import PricingS
 from zepben.protobuf.cim.iec61968.customers.Tariff_pb2 import Tariff as PBTariff
 
 import zepben.ewb.services.common.resolver as resolver
-from zepben.ewb import organisation_role_to_cim, document_to_cim, BaseService, CustomerKind
+from zepben.ewb import organisation_role_to_cim, document_to_cim, BaseService, CustomerKind, bind_to_cim
 from zepben.ewb.model.cim.iec61968.common.agreement import Agreement
 from zepben.ewb.model.cim.iec61968.customers.customer import Customer
 from zepben.ewb.model.cim.iec61968.customers.customer_agreement import CustomerAgreement
 from zepben.ewb.model.cim.iec61968.customers.pricing_structure import PricingStructure
 from zepben.ewb.model.cim.iec61968.customers.tariff import Tariff
+from zepben.ewb.services.common.translator.base_proto2cim import get_nullable
 from zepben.ewb.services.customer.customers import CustomerService
 
 
@@ -29,6 +30,7 @@ from zepben.ewb.services.customer.customers import CustomerService
 # IEC61968 Common #
 ###################
 
+@bind_to_cim
 def agreement_to_cim(pb: PBAgreement, cim: Agreement, service: BaseService):
     document_to_cim(pb.doc, cim, service)
 
@@ -37,11 +39,13 @@ def agreement_to_cim(pb: PBAgreement, cim: Agreement, service: BaseService):
 # IEC61968 Customers #
 ######################
 
+@bind_to_cim
 def customer_to_cim(pb: PBCustomer, service: CustomerService) -> Optional[Customer]:
     cim = Customer(
         mrid=pb.mrid(),
         kind=CustomerKind(pb.kind),
-        special_need=pb.specialNeed if pb.specialNeed else None
+        # TODO: missing num_end_devices from jvm sdk
+        special_need=get_nullable(pb, 'specialNeed')
     )
 
     for mrid in pb.customerAgreementMRIDs:
@@ -51,6 +55,7 @@ def customer_to_cim(pb: PBCustomer, service: CustomerService) -> Optional[Custom
     return cim if service.add(cim) else None
 
 
+@bind_to_cim
 def customer_agreement_to_cim(pb: PBCustomerAgreement, service: CustomerService) -> Optional[CustomerAgreement]:
     cim = CustomerAgreement(mrid=pb.mrid())
 
@@ -62,6 +67,7 @@ def customer_agreement_to_cim(pb: PBCustomerAgreement, service: CustomerService)
     return cim if service.add(cim) else None
 
 
+@bind_to_cim
 def pricing_structure_to_cim(pb: PBPricingStructure, service: CustomerService) -> Optional[PricingStructure]:
     cim = PricingStructure(mrid=pb.mrid())
 
@@ -72,16 +78,10 @@ def pricing_structure_to_cim(pb: PBPricingStructure, service: CustomerService) -
     return cim if service.add(cim) else None
 
 
+@bind_to_cim
 def tariff_to_cim(pb: PBTariff, service: CustomerService) -> Optional[Tariff]:
     # noinspection PyArgumentList
     cim = Tariff(mrid=pb.mrid())
 
     document_to_cim(pb.doc, cim, service)
     return cim if service.add(cim) else None
-
-
-PBAgreement.to_cim = agreement_to_cim
-PBCustomer.to_cim = customer_to_cim
-PBCustomerAgreement.to_cim = customer_agreement_to_cim
-PBPricingStructure.to_cim = pricing_structure_to_cim
-PBTariff.to_cim = tariff_to_cim

zepben/ewb/services/diagram/translator/diagram_cim2proto.py

@@ -12,7 +12,7 @@ from zepben.protobuf.cim.iec61970.base.diagramlayout.Diagram_pb2 import Diagram
 from zepben.ewb.model.cim.iec61970.base.diagramlayout.diagram import Diagram
 from zepben.ewb.model.cim.iec61970.base.diagramlayout.diagram_object import DiagramObject
 from zepben.ewb.model.cim.iec61970.base.diagramlayout.diagram_object_point import DiagramObjectPoint
-from zepben.ewb.services.common.translator.base_cim2proto import identified_object_to_pb
+from zepben.ewb.services.common.translator.base_cim2proto import identified_object_to_pb, set_or_null, bind_to_pb
 from zepben.ewb.services.common.translator.util import mrid_or_empty
 # noinspection PyProtectedMember
 from zepben.ewb.services.diagram.translator.diagram_enum_mappers import _map_diagram_style, _map_orientation_kind
@@ -22,6 +22,7 @@ from zepben.ewb.services.diagram.translator.diagram_enum_mappers import _map_dia
 # IEC61970 Base Diagram Layout #
 ################################
 
+@bind_to_pb
 def diagram_to_pb(cim: Diagram) -> PBDiagram:
     return PBDiagram(
         io=identified_object_to_pb(cim),
@@ -31,21 +32,20 @@ def diagram_to_pb(cim: Diagram) -> PBDiagram:
     )
 
 
+@bind_to_pb
 def diagram_object_to_pb(cim: DiagramObject) -> PBDiagramObject:
     return PBDiagramObject(
         io=identified_object_to_pb(cim),
         diagramMRID=mrid_or_empty(cim.diagram),
         identifiedObjectMRID=cim.identified_object_mrid,
-        diagramObjectStyle=cim.style,
+        diagramObjectPoints=[diagram_object_point_to_pb(io) for io in cim.points],
         rotation=cim.rotation,
-        diagramObjectPoints=[diagram_object_point_to_pb(io) for io in cim.points]
+        **set_or_null(
+            diagramObjectStyle=cim.style,
+        )
     )
 
 
+@bind_to_pb
 def diagram_object_point_to_pb(cim: DiagramObjectPoint) -> PBDiagramObjectPoint:
     return PBDiagramObjectPoint(xPosition=cim.x_position, yPosition=cim.y_position)
-
-
-Diagram.to_pb = diagram_to_pb
-DiagramObject.to_pb = diagram_object_to_pb
-DiagramObjectPoint.to_pb = diagram_object_point_to_pb

zepben/ewb/services/diagram/translator/diagram_proto2cim.py

@@ -10,10 +10,11 @@ from zepben.protobuf.cim.iec61970.base.diagramlayout.DiagramObject_pb2 import Di
 from zepben.protobuf.cim.iec61970.base.diagramlayout.Diagram_pb2 import Diagram as PBDiagram
 
 import zepben.ewb.services.common.resolver as resolver
-from zepben.ewb import identified_object_to_cim, OrientationKind, DiagramStyle
+from zepben.ewb import identified_object_to_cim, OrientationKind, DiagramStyle, add_to_network_or_none, bind_to_cim
 from zepben.ewb.model.cim.iec61970.base.diagramlayout.diagram import Diagram
 from zepben.ewb.model.cim.iec61970.base.diagramlayout.diagram_object import DiagramObject
 from zepben.ewb.model.cim.iec61970.base.diagramlayout.diagram_object_point import DiagramObjectPoint
+from zepben.ewb.services.common.translator.base_proto2cim import get_nullable
 from zepben.ewb.services.diagram.diagrams import DiagramService
 
 
@@ -21,6 +22,8 @@ from zepben.ewb.services.diagram.diagrams import DiagramService
 # IEC61970 Base Diagram Layout #
 ################################
 
+@bind_to_cim
+@add_to_network_or_none
 def diagram_to_cim(pb: PBDiagram, service: DiagramService):
     cim = Diagram(
         mrid=pb.mrid(),
@@ -32,14 +35,15 @@ def diagram_to_cim(pb: PBDiagram, service: DiagramService):
         service.resolve_or_defer_reference(resolver.diagram_objects(cim), mrid)
 
     identified_object_to_cim(pb.io, cim, service)
-    return cim if service.add(cim) else None
+    return cim
 
 
+@bind_to_cim
 def diagram_object_to_cim(pb: PBDiagramObject, service: DiagramService):
     cim = DiagramObject(
         mrid=pb.mrid(),
         identified_object_mrid=pb.identifiedObjectMRID if pb.identifiedObjectMRID else None,
-        style=pb.diagramObjectStyle if pb.diagramObjectStyle else None,
+        style=get_nullable(pb, 'diagramObjectStyle'),
         rotation=pb.rotation,
     )
 
@@ -51,11 +55,7 @@ def diagram_object_to_cim(pb: PBDiagramObject, service: DiagramService):
     return cim if service.add_diagram_object(cim) else None
 
 
+@bind_to_cim
 def diagram_object_point_to_cim(pb: PBDiagramObjectPoint) -> DiagramObjectPoint:
     # noinspection PyArgumentList
     return DiagramObjectPoint(pb.xPosition, pb.yPosition)
-
-
-PBDiagram.to_cim = diagram_to_cim
-PBDiagramObject.to_cim = diagram_object_to_cim
-PBDiagramObjectPoint.to_cim = diagram_object_point_to_cim

zepben/ewb/services/network/tracing/phases/phase_inferrer.py

@@ -36,9 +36,9 @@ class PhaseInferrer:
         @property
         def description(self) -> str:
             if self.suspect:
-                _inner_desc = f"phases for '{self.conducting_equipment.name}' [{self.conducting_equipment.mrid}] which may not be correct. The phases were inferred"
+                _inner_desc = f"phases for '{str(self.conducting_equipment)}' which may not be correct. The phases were inferred"
             else:
-                _inner_desc = f"phase for '{self.conducting_equipment.name}' [{self.conducting_equipment.mrid}] which should be correct. The phase was inferred"
+                _inner_desc = f"phase for '{str(self.conducting_equipment)}' which should be correct. The phase was inferred"
             return (f'Inferred missing {_inner_desc} due to a disconnected nominal phase because of an '
                     f'upstream error in the source data. Phasing information for the upstream equipment should be fixed in the source system.')