yearn-treasury 0.0.14__cp310-cp310-win_amd64.whl → 0.0.44__cp310-cp310-win_amd64.whl

yearn_treasury/rules/expense/security.py

@@ -1,3 +1,11 @@
+"""
+Expense rules for security, audits, and bug bounties.
+
+This module defines matching logic for security-related expenses,
+including audits (yAcademy, ChainSec, StateMind, MixBytes, unspecified),
+bug bounties, and other security-related deliverables.
+"""
+
 from typing import Final
 
 from dao_treasury import TreasuryTx, expense
@@ -6,6 +14,7 @@ from y import Network
 
 security: Final = expense("Security")
 audits: Final = security("Audits")
+grants: Final = security("Grants")
 
 
 @audits("yAcademy", Network.Mainnet)
@@ -128,3 +137,11 @@ def is_warroom_help(tx: TreasuryTx) -> bool:
         tx.hash == "0xca61496c32806ba34f0deb331c32969eda11c947fdd6235173e6fa13d9a1c288"
         and tx.log_index == 152
     )
+
+
+@grants("ySecurity", Network.Mainnet)
+def is_ysecurity(tx: TreasuryTx) -> bool:
+    """
+    https://github.com/yearn/budget/issues/145
+    """
+    return tx.to_address == "0x4851C7C7163bdF04A22C9e12Ab77e184a5dB8F0E"

yearn_treasury/rules/ignore/__init__.py

@@ -1,6 +1,8 @@
 from yearn_treasury.rules.ignore.general import *
 from yearn_treasury.rules.ignore.maker import *
+from yearn_treasury.rules.ignore.passthru import *
 from yearn_treasury.rules.ignore.staking import *
 from yearn_treasury.rules.ignore.swaps import *
+from yearn_treasury.rules.ignore.unit import *
 from yearn_treasury.rules.ignore.weth import *
 from yearn_treasury.rules.ignore.ygov import *

yearn_treasury/rules/ignore/general.py

@@ -4,7 +4,8 @@ from dao_treasury import TreasuryTx, ignore
 @ignore("Returned Funds")
 def is_returned_fundus(tx: TreasuryTx) -> bool:
     """A user accientally refunded their yield to yChad, yChad sent it back."""
-    return tx.hash == "0x2c2fb9d88a7a25b100ae3ba08bdb1cafbbd6a63386a08fdcfe32d077836defa3" or (
-        tx.hash == "0xd7e7abe600aad4a3181a3a410bef2539389579d2ed28f3e75dbbf3a7d8613688"
+    txhash = tx.hash
+    return txhash == "0x2c2fb9d88a7a25b100ae3ba08bdb1cafbbd6a63386a08fdcfe32d077836defa3" or (
+        txhash == "0xd7e7abe600aad4a3181a3a410bef2539389579d2ed28f3e75dbbf3a7d8613688"
         and tx.log_index == 556
     )

yearn_treasury/rules/ignore/maker.py

@@ -1,3 +1,11 @@
+"""
+Ignore rules for Maker protocol.
+
+This module defines matching logic for Maker protocol transactions,
+including DAI minting/burning, DSR deposit/withdrawal, and CDP
+deposit/withdrawal for YFI and USDC.
+"""
+
 from decimal import Decimal
 from typing import Final
 
@@ -26,55 +34,59 @@ dsr("Withdrawal").match(from_nickname="Contract: DsrManager")
 
 @cdp("YFI Deposit")
 def is_yfi_cdp_deposit(tx: TreasuryTx) -> bool:
-    if tx.symbol == "YFI" and TreasuryWallet._get_instance(
-        tx.from_address.address  # type: ignore [union-attr, arg-type]
+    if tx.symbol == "YFI" and TreasuryWallet.check_membership(
+        tx.from_address.address, tx.block  # type: ignore [union-attr, arg-type]
     ):
         for event in tx.get_events("slip"):
-            if (
-                all(arg in event for arg in DEPOSIT_EVENT_ARGS)
-                and Decimal(event["wad"]) / 10**18 == tx.amount
-            ):
-                return True
+            if all(arg in event for arg in DEPOSIT_EVENT_ARGS):
+                # TODO: remove this rounding once we move to postgres
+                scaled = round(Decimal(event["wad"]) / 10**18, 12)
+                rounded = round(tx.amount, 12)
+                if scaled == rounded:
+                    return True
+                print(f"yfi cdp deposit amount no match [{scaled}, {rounded}]")
     return False
 
 
 @cdp("YFI Withdrawal")
 def is_yfi_cdp_withdrawal(tx: TreasuryTx) -> bool:
-    if tx.symbol == "YFI" and TreasuryWallet._get_instance(
-        tx.to_address.address  # type: ignore [union-attr, arg-type]
+    if tx.symbol == "YFI" and TreasuryWallet.check_membership(
+        tx.to_address.address, tx.block  # type: ignore [union-attr, arg-type]
     ):
         for event in tx.get_events("flux"):
-            if (
-                all(arg in event for arg in WITHDRAWAL_EVENT_ARGS)
-                and Decimal(event["wad"]) / 10**18 == tx.amount
-            ):
-                return True
+            if all(arg in event for arg in WITHDRAWAL_EVENT_ARGS):
+                # TODO: remove this rounding once we move to postgres
+                scaled = round(Decimal(event["wad"]) / 10**18, 12)
+                rounded = round(tx.amount, 12)
+                if scaled == rounded:
+                    return True
+                print(f"yfi cdp withdrawal amount no match [{scaled}, {rounded}]")
     return False
 
 
 @cdp("USDC Deposit")
 def is_usdc_cdp_deposit(tx: TreasuryTx) -> bool:
-    if tx.symbol == "USDC" and TreasuryWallet._get_instance(
-        tx.from_address.address  # type: ignore [union-attr, arg-type]
+    if tx.symbol == "USDC" and TreasuryWallet.check_membership(
+        tx.from_address.address, tx.block  # type: ignore [union-attr, arg-type]
     ):
         for event in tx.get_events("slip"):
-            if (
-                all(arg in event for arg in DEPOSIT_EVENT_ARGS)
-                and Decimal(event["wad"]) / 10**18 == tx.amount
-            ):
-                return True
+            if all(arg in event for arg in DEPOSIT_EVENT_ARGS):
+                scaled = Decimal(event["wad"]) / 10**18
+                if scaled == tx.amount:
+                    return True
+                print(f"usdc cdp deposit amount no match [{scaled}, {tx.amount}]")
     return False
 
 
 @cdp("USDC Withdrawal")
 def is_usdc_cdp_withdrawal(tx: TreasuryTx) -> bool:
-    if tx.symbol == "USDC" and TreasuryWallet._get_instance(
-        tx.to_address.address  # type: ignore [union-attr, arg-type]
+    if tx.symbol == "USDC" and TreasuryWallet.check_membership(
+        tx.to_address.address, tx.block  # type: ignore [union-attr, arg-type]
     ):
         for event in tx.get_events("flux"):
-            if (
-                all(arg in event for arg in WITHDRAWAL_EVENT_ARGS)
-                and Decimal(event["wad"]) / 10**18 == tx.amount
-            ):
-                return True
+            if all(arg in event for arg in WITHDRAWAL_EVENT_ARGS):
+                scaled = Decimal(event["wad"]) / 10**18
+                if scaled == tx.amount:
+                    return True
+                print(f"usdc cdp withdrawal amount no match [{scaled}, {tx.amount}]")
     return False

yearn_treasury/rules/ignore/passthru.py

@@ -0,0 +1,310 @@
+from decimal import Decimal
+from typing import Final, Tuple
+
+from dao_treasury import TreasuryTx, TreasuryWallet, ignore
+from eth_typing import BlockNumber, ChecksumAddress
+from y import Network
+
+from yearn_treasury.constants import CHAINID, YSWAP_MULTISIG, ZERO_ADDRESS
+
+
+passthru: Final = ignore("Pass-Thru")
+
+cowswap_router: Final = "0x9008D19f58AAbD9eD0D60971565AA8510560ab41"
+ycrv: Final = "0xFCc5c47bE19d06BF83eB04298b026F81069ff65b"
+
+
+@passthru("Sent to dinobots to dump", Network.Mainnet)
+def is_sent_to_dinoswap(tx: TreasuryTx) -> bool:
+    """These tokens are dumpped and the proceeds sent back to the origin strategy."""
+    return tx.from_nickname == "Contract: Strategy" and tx.to_nickname == "yMechs Multisig"
+
+
+@passthru("Bribes for yCRV", Network.Mainnet)
+def is_ycrv(tx: TreasuryTx) -> bool:
+    """These are routed thru cowswap with dai as the purchase token."""
+    ymechs = "0x2C01B4AD51a67E2d8F02208F54dF9aC4c0B778B6"
+
+    from_address = tx.from_address
+    symbol = tx.symbol
+    if (from_address == YSWAP_MULTISIG and symbol == "DAI") or (
+        from_address == ymechs and symbol == "3Crv"
+    ):
+        if tx.to_address == cowswap_router:
+            for trade in tx.get_events("Trade"):
+                (
+                    owner,
+                    sell_token,
+                    buy_token,
+                    sell_amount,
+                    buy_amount,
+                    fee_amount,
+                    order_uid,
+                ) = trade.values()
+                if tx.from_address == owner and tx.token == sell_token and buy_token == ycrv:
+                    scaled = Decimal(sell_amount) / 10**18
+                    # TODO: remove this rounding when we implement postgres
+                    if round(scaled, 11) == round(tx.amount, 11):
+                        return True
+                    print(f"bribes for ycrv amount no match: [{scaled}, {tx.amount}]")
+
+    elif tx.hash in {
+        # one off exception case to correct accounting mix-up
+        "0x1578f3b0d3158d305167c39dc29ada08914e1ddb67ef9698e1b0421432f9aed6",
+        # A few donations from ySwap
+        "0xb2e335500b33b42edd8a97f57db35e0561df9a3a811d0cd73dce9767c23da0c4",
+        "0xc02aab3a84b3bbfbc18f0ee6aa742f233d97511f653b4a40e7cd8f822851e10a",
+        "0x8a2dba62eac44fdfc7ff189016ac601c9da664f5dea42d647f2e552319db2f7d",
+        "0xd2c0a137d03811c5e4c27be19c7893f7fdd5851bdd6f825ee7301f3634033035",
+    }:
+        return True
+    return is_dola_bribe(tx)
+
+
+def is_dola_bribe(tx: TreasuryTx) -> bool:
+    return (
+        tx.from_nickname == "ySwap Multisig"
+        and tx.to_nickname == "Contract: GPv2Settlement"
+        and tx.symbol == "DOLA"
+    )
+
+
+passthru("BAL Rewards", Network.Mainnet).match(
+    hash="0xf4677cce1a08ecd54272cdc1b23bc64693450f8bb5d6de59b8e58e288ec3b2a7",
+    symbol="BAL",
+)
+
+
+@passthru("StrategyAuraUSDClonable", Network.Mainnet)
+def is_aura(tx: TreasuryTx) -> bool:
+    txhash = tx.hash
+    if (
+        txhash == "0x1621ba5c9b57930c97cc43d5d6d401ee9c69fed435b0b458ee031544a10bfa75"
+        and tx.symbol in ["BAL", "AURA"]
+    ):
+        return True
+    return (
+        txhash == "0x996b5911a48319133f50f72904e70ed905c08c81e2c03770e0ccc896be873bd4"
+        and tx.symbol == "AURA"
+    )
+
+
+@passthru("yPrisma Strategy Migration", Network.Mainnet)
+def is_yprisma_migration(tx: TreasuryTx) -> bool:
+    # strategies were changed a few times
+    txhash = tx.hash
+    if txhash in (
+        "0x4c19259ff9e23c2f23653b7560526c2dbd5adef2d53c297b63d8c1fa6f4906f1",
+        "0xed39b66c01e25b053117778c80e544c985d962522233b49ce6f7fe136b1a4474",
+    ):
+        return True
+    return (
+        txhash == "0x45bb5d7c25393c5bb8ad9647ae60ff39ddc39d695f0e427eb45f91b04f42c636"
+        and tx.symbol == "yPRISMA"
+    )
+
+
+@passthru("rKP3R", Network.Mainnet)
+def is_rkp3r(tx: TreasuryTx) -> bool:
+    if tx.symbol == "rKP3R":
+        from_nickname = tx.from_nickname
+        to_nickname = tx.to_nickname
+        if (
+            from_nickname == "Contract: StrategyConvexFixedForexClonable"
+            and to_nickname == "Yearn yChad Multisig"
+        ):
+            return True
+        elif (
+            from_nickname == "Yearn yChad Multisig"
+            and to_nickname == "Contract: StrategyConvexFixedForexClonable"
+        ):
+            return True
+    return False
+
+
+@passthru("Inverse-earned YearnFed Fees", Network.Mainnet)
+def is_inverse_fees_from_yearn_fed(tx: TreasuryTx) -> bool:
+    return tx.symbol == "yvDOLA-U" and tx.to_nickname == "Contract: YearnFed"
+
+
+@passthru("stkAAVE", Network.Mainnet)
+def is_stkaave(tx: TreasuryTx) -> bool:
+    """stkAAVE is sent from a strategy to ychad, then to sms for unwrapping."""
+    if tx.symbol == "stkAAVE":
+        from_nickname = tx.from_nickname
+        to_nickname = tx.to_nickname
+        if "Strategy" in from_nickname and to_nickname == "Yearn yChad Multisig":
+            return True
+        elif from_nickname == "Yearn yChad Multisig" and to_nickname == "Yearn Strategist Multisig":
+            return True
+    return False
+
+
+@passthru("StrategyIdle", Network.Mainnet)
+def is_idle(tx: TreasuryTx) -> bool:
+    return tx.hash in {
+        "0x59595773ee4304ba4e7e06d2c02541781d93867f74c6c83056e7295b684036c7",
+        "0x4c7685aa3dfa9f375c612a2773951b9edbe059102b505423ed28a97d2692e75a",
+        "0xb17317686b57229aeb7f06103097b47dc2eafa34489c40af70d2ac57bcf8f455",
+        "0xfd9e6fd303fdbb358207bf3ba069b7f6a21f82f6b082605056d54948127e81e8",
+        "0x41c8428fd361c54bb80cdac752e31622915ac626dd1e9270f02af1dc2c84d1f9",
+        "0x9c0d169c7362a7fe436ae852c1aee58a5905d10569abbd50261f65cb0574dc3a",
+        "0x55d89a5890cfe80da06f6831fdfa3a366c0ed9cf9b7f1b4d53f5007bb9698fa0",
+        "0x6c6fc43dca1841af82b517bc5fc53ea8607e3f95512e4dd3009c0dbb425669f7",
+    }
+
+
+_factory_strat_to_yield_tokens = {
+    "Contract: StrategyCurveBoostedFactoryClonable": ("CRV", "LDO"),
+    "Contract: StrategyConvexFactoryClonable": ("CRV", "CVX"),
+    "Contract: StrategyConvexFraxFactoryClonable": ("CRV", "CVX", "FXS"),
+}
+
+
+@passthru("Factory Vault Yield", Network.Mainnet)
+def is_factory_vault_yield(tx: TreasuryTx) -> bool:
+    return tx.to_nickname == "yMechs Multisig" and tx.symbol in _factory_strat_to_yield_tokens.get(
+        tx.from_nickname, ()
+    )
+
+
+@passthru("CowSwap Migration", Network.Mainnet)
+def is_cowswap_migration(tx: TreasuryTx) -> bool:
+    """A one-time tx that transferred tokens from an old contract to its replacement."""
+    return tx.hash == "0xb50341d3db2ff4a39b9bfa21753893035554ae44abb7d104ab650753db1c4855"
+
+
+def is_curve_bribe(tx: TreasuryTx) -> bool:
+    """All present and future curve bribes are committed to yveCRV holders."""
+    from_nickname = tx.from_nickname
+    if from_nickname == "Contract: CurveYCRVVoter" and tx.hash not in [
+        # took place before bribes were committed to yveCRV
+        "0x6824345c8a0c1f0b801d8050bb6f587032c4a9fa153faa113d723a2068d844f4",
+        # was a whitehat hack of the v1 bribe contract, necessary to safeguard user funds
+        "0xfcef3911809770fe351b2b526e4ee0274589a3f7d6ef9408a8f5643fa006b771",
+    ]:
+        return True
+
+    # Bribe V3
+    elif from_nickname == "Contract: yBribe" and tx.to_nickname in [
+        "Yearn Treasury",
+        "ySwap Multisig",
+    ]:
+        return True
+
+    # NOTE: I added this one-off to capture tokens sent to BribeSplitter 0x527e80008D212E2891C737Ba8a2768a7337D7Fd2
+    return tx.hash == "0xce45da7e3a7616ed0c0d356d6dfa8a784606c9a8034bae9faa40abf7b52be114"
+
+
+_pass_thru_hashes: Tuple[str, ...] = {
+    Network.Mainnet: ("0xf662c68817c56a64b801181a3175c8a7e7a5add45f8242990c695d418651e50d",),
+    Network.Fantom: (
+        "0x411d0aff42c3862d06a0b04b5ffd91f4593a9a8b2685d554fe1fbe5dc7e4fc04",
+        "0xa347da365286cc912e4590fc71e97a5bcba9e258c98a301f85918826538aa021",
+    ),
+}.get(
+    CHAINID, ()
+)  # type: ignore [call-overload]
+
+
+@passthru("Misc.", Network.Mainnet)
+def is_misc_passthru_mainnet(tx: TreasuryTx) -> bool:
+    # not sure if we still need this, TODO figure it out
+    # NOTE skipped the hashmatcher to do strange things ... there is probably a better way to do this
+    if tx.hash in _pass_thru_hashes and str(tx.log_index).lower() != "nan":
+        return True
+
+    txhash = tx.hash
+    if txhash in {
+        "0xae6797ad466de75731117df46ccea5c263265dd6258d596b9d6d8cf3a7b1e3c2",
+        "0x2a6191ba8426d3ae77e2a6c91de10a6e76d1abdb2d0f831c6c5aad52be3d6246",
+        # https://github.com/yearn/chief-multisig-officer/pull/924
+        "0x25b54e113e58a3a4bbffc011cdfcb8c07a0424f33b0dbda921803d82b88f1429",
+        "0xcb000dd2b623f9924fe0234831800950a3269b2d412ce9eeabb0ec65cd737059",
+    }:
+        return True
+    # do these need hueristics? build real sort logic if these keep reoccurring
+    elif txhash == "0x14faeac8ee0734875611e68ce0614eaf39db94a5ffb5bc6f9739da6daf58282a" and (
+        tx.symbol in ("CRV", "CVX", "yPRISMA") or tx.log_index == 254
+    ):
+        return True
+    return False
+
+
+@passthru("Misc.", Network.Fantom)
+def is_misc_passthru_fantom(tx: TreasuryTx) -> bool:
+    # not sure if we still need this, TODO figure it out
+    # NOTE skipped the hashmatcher to do strange things ... there is probably a better way to do this
+    if tx.hash in _pass_thru_hashes and str(tx.log_index).lower() != "nan":
+        return True
+
+    if tx.hash == "0x14faeac8ee0734875611e68ce0614eaf39db94a5ffb5bc6f9739da6daf58282a":
+        return True
+    # Passing thru to yvWFTM
+    if (
+        tx.symbol == "WFTM"
+        and TreasuryWallet.check_membership(tx.from_address.address, tx.block)  # type: ignore [arg-type, union-attr]
+        and tx.to_address == "0x0DEC85e74A92c52b7F708c4B10207D9560CEFaf0"
+    ):
+        # dont want to accidenally sort a vault deposit here
+        is_deposit = False
+        for event in tx.get_events("Transfer"):
+            sender, receiver, _ = event.values()
+            if (
+                tx.to_address == event.address
+                and sender == ZERO_ADDRESS
+                and tx.from_address == receiver
+            ):
+                is_deposit = True
+        if not is_deposit:
+            return True
+    return False
+
+
+@passthru("yvBoost INCOMPLETE", Network.Mainnet)
+def is_buying_yvboost(tx: TreasuryTx) -> bool:
+    """Bought back yvBoost is unwrapped and sent back to vault holders."""
+    symbol = tx.symbol
+    block: BlockNumber = tx.block  # type: ignore [assignment]
+    from_address: ChecksumAddress = tx.from_address.address  # type: ignore [union-attr, assignment]
+    to_address: ChecksumAddress = tx.to_address.address  # type: ignore [union-attr, assignment]
+    if (
+        symbol == "SPELL"
+        and TreasuryWallet.check_membership(from_address, block)
+        and to_address == cowswap_router
+    ):
+        return True
+
+    elif (
+        symbol == "yveCRV-DAO"
+        and TreasuryWallet.check_membership(from_address, block)
+        and to_address
+        in (
+            "0xd7240B32d24B814fE52946cD44d94a2e3532E63d",
+            "0x7fe508eE30316e3261079e2C81f4451E0445103b",
+        )
+    ):
+        return True
+
+    elif (
+        symbol == "3Crv"
+        and from_address == "0xd7240B32d24B814fE52946cD44d94a2e3532E63d"
+        and TreasuryWallet.check_membership(to_address, block)
+    ):
+        return True
+
+    # SPELL bribe handling
+    elif symbol == "SPELL":
+        if tx.to_nickname in ("Abracadabra Treasury", "Contract: BribeSplitter"):
+            return True
+
+    return tx in (
+        "0x9eabdf110efbfb44aab7a50eb4fe187f68deae7c8f28d78753c355029f2658d3",
+        "0x5a80f5ff90fc6f4f4597290b2432adbb62ab4154ead68b515accdf19b01c1086",
+        "0x848b4d629e137ad8d8eefe5db40eab895c9959b9c210d0ae0fef16a04bfaaee1",
+        "0x896663aa9e2633b5d152028bdf84d7f4b1137dd27a8e61daca3863db16bebc4f",
+        "0xd8aa1e5d093a89515530b7267a9fd216b97fddb6478b3027b2f5c1d53070cd5f",
+        "0x169aab84b408fce76e0b776ebf412c796240300c5610f0263d5c09d0d3f1b062",
+        "0xe6fefbf061f4489cd967cdff6aa8aca616f0c709e08c3696f12b0027e9e166c9",
+        "0x10be8a3345660f3c51b695e8716f758b1a91628bd612093784f0516a604f79c1",
+    )

yearn_treasury/rules/ignore/swaps/__init__.py

@@ -7,5 +7,19 @@ swaps: Final[SortRuleFactory[IgnoreSortRule]] = ignore("Swaps")
 
 
 from yearn_treasury.rules.ignore.swaps.aave import *
+from yearn_treasury.rules.ignore.swaps.auctions import *
 from yearn_treasury.rules.ignore.swaps.compound import *
+from yearn_treasury.rules.ignore.swaps.conversion_factory import *
+from yearn_treasury.rules.ignore.swaps.cowswap import *
+from yearn_treasury.rules.ignore.swaps.curve import *
+from yearn_treasury.rules.ignore.swaps.gearbox import *
+from yearn_treasury.rules.ignore.swaps.iearn import *
+from yearn_treasury.rules.ignore.swaps.otc import *
+from yearn_treasury.rules.ignore.swaps.pooltogether import *
+from yearn_treasury.rules.ignore.swaps.synthetix import *
 from yearn_treasury.rules.ignore.swaps.uniswap import *
+from yearn_treasury.rules.ignore.swaps.unwrapper import *
+from yearn_treasury.rules.ignore.swaps.vaults import *
+from yearn_treasury.rules.ignore.swaps.woofy import *
+from yearn_treasury.rules.ignore.swaps.yfi import *
+from yearn_treasury.rules.ignore.swaps.yla import *

yearn_treasury/rules/ignore/swaps/aave.py

@@ -1,6 +1,16 @@
+"""
+Ignore rules for Aave-related transactions.
+
+This module defines rules for identifying and ignoring Aave-related
+transactions in the Yearn Treasury system. It provides matching logic
+for deposit and withdrawal events, so these transactions can be
+ignored in analytics and reporting.
+"""
+
 from typing import Final
 
 from dao_treasury import TreasuryTx, TreasuryWallet
+from eth_typing import ChecksumAddress
 
 from yearn_treasury.rules.constants import ZERO_ADDRESS
 from yearn_treasury.rules.ignore.swaps import swaps
@@ -20,29 +30,40 @@ def is_aave_deposit(tx: TreasuryTx) -> bool:
 
 @aave("Withdrawal")
 async def is_aave_withdrawal(tx: TreasuryTx) -> bool:
+    from_address: ChecksumAddress = tx.from_address.address  # type: ignore [union-attr, assignment]
+    to_address: ChecksumAddress = tx.to_address.address  # type: ignore [union-attr, assignment]
     # Atoken side
     if (
-        TreasuryWallet._get_instance(tx.from_address.address)  # type: ignore [union-attr, arg-type]
-        and tx.to_address == ZERO_ADDRESS
-        and hasattr(tx.token.contract, "underlyingAssetAddress")
+        TreasuryWallet.check_membership(from_address, tx.block)  # type: ignore [union-attr, arg-type]
+        and to_address == ZERO_ADDRESS
     ):
-        for event in tx.get_events("RedeemUnderlying"):
-            if (
-                tx.from_address == event["_user"]
-                and await tx.token.contract.underlyingAssetAddress == event["_reserve"]
-                and tx.token.scale_value(event["_amount"]) == tx.amount
-            ):
-                return True
+        token = tx.token
+        if hasattr(token.contract, "underlyingAssetAddress"):
+            for event in await tx.get_events("RedeemUnderlying", sync=False):
+                if (
+                    from_address == event["_user"]
+                    and await token.contract.underlyingAssetAddress == event["_reserve"]
+                ):
+                    # TODO get rid of this rounding when we migrate the db to postgres
+                    event_amount = round(token.scale_value(event["_amount"]), 11)
+                    if event_amount == round(tx.amount, 11):
+                        return True
+                    print(
+                        f"Aave Withdrawal atoken side does not match: {round(tx.amount, 14)}  {event_amount}"
+                    )
 
     # Underlying side
-    if TreasuryWallet._get_instance(tx.to_address.address):  # type: ignore [union-attr, arg-type]
-        for event in tx.get_events("RedeemUnderlying"):
-            if (
-                tx.token == event["_reserve"]
-                and tx.to_address == event["_user"]
-                and tx.token.scale_value(event["_amount"]) == tx.amount
-            ):
-                return True
+    if TreasuryWallet.check_membership(tx.to_address.address, tx.block):  # type: ignore [union-attr, arg-type]
+        token = tx.token
+        for event in await tx.get_events("RedeemUnderlying", sync=False):
+            if token == event["_reserve"] and to_address == event["_user"]:
+                # TODO get rid of this rounding when we migrate the db to postgres
+                event_amount = round(token.scale_value(event["_amount"]), 11)
+                if event_amount == round(tx.amount, 11):
+                    return True
+                print(
+                    f"Aave Withdrawal underlying side does not match: {round(tx.amount, 14)}  {event_amount}"
+                )
 
     # TODO: If these end up becoming more frequent, figure out sorting hueristics.
     return tx.hash == "0x36ee5631859a15f57b44e41b8590023cf6f0c7b12d28ea760e9d8f8003f4fc50"

yearn_treasury/rules/ignore/swaps/auctions.py

@@ -0,0 +1,31 @@
+from typing import Final
+
+from dao_treasury import TreasuryTx
+from y import Network
+
+from yearn_treasury.rules.ignore.swaps import swaps
+
+
+auctions: Final = swaps("Auctions")
+
+YEARNFI_DUTCH_AUCTIONS: Final = "0x861fE45742f70054917B65bE18904662bD0dBd30"
+
+
+@auctions("Auction Proceeds", Network.Mainnet)
+async def is_auction_proceeds(tx: TreasuryTx) -> bool:
+    # NOTE: the other side of these swaps is currently recorded under
+    # 'Ignore:Internal Transfer' when it goes to the Generic bucket contract
+    if tx.from_nickname != "Contract: GPv2Settlement":
+        return False
+
+    for trade in await tx.get_events("Trade", sync=False):
+        if trade["owner"] != YEARNFI_DUTCH_AUCTIONS or tx.token != trade["buyToken"]:
+            continue
+        buy_amount = tx.token.scale_value(trade["buyAmount"])
+        if round(buy_amount, 14) == round(tx.amount, 14):
+            return True
+        print(
+            f"auction proceeds amount does not match: {round(buy_amount, 14)}  {round(tx.amount, 14)}"
+        )
+
+    return False