yamlgraph 0.3.9__py3-none-any.whl

tests/unit/test_reliability.py

@@ -0,0 +1,298 @@
+"""Tests for Section 1: Reliability & Error Handling.
+
+TDD tests for on_error behaviors and fallback provider chains.
+"""
+
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from yamlgraph.graph_loader import GraphConfig
+from yamlgraph.models import PipelineError
+from yamlgraph.node_factory import create_node_function
+
+# =============================================================================
+# Test: on_error Configuration Parsing
+# =============================================================================
+
+
+class TestOnErrorConfigParsing:
+    """Tests for parsing on_error config from YAML."""
+
+    def test_parses_on_error_from_node_config(self):
+        """Node config includes on_error field."""
+        config_dict = {
+            "version": "1.0",
+            "name": "test",
+            "nodes": {
+                "generate": {
+                    "prompt": "generate",
+                    "on_error": "skip",
+                }
+            },
+            "edges": [
+                {"from": "START", "to": "generate"},
+                {"from": "generate", "to": "END"},
+            ],
+        }
+        config = GraphConfig(config_dict)
+        assert config.nodes["generate"]["on_error"] == "skip"
+
+    def test_parses_max_retries_from_node_config(self):
+        """Node config includes max_retries field."""
+        config_dict = {
+            "version": "1.0",
+            "name": "test",
+            "nodes": {
+                "generate": {
+                    "prompt": "generate",
+                    "max_retries": 5,
+                }
+            },
+            "edges": [
+                {"from": "START", "to": "generate"},
+                {"from": "generate", "to": "END"},
+            ],
+        }
+        config = GraphConfig(config_dict)
+        assert config.nodes["generate"]["max_retries"] == 5
+
+    def test_parses_fallback_provider_from_node_config(self):
+        """Node config includes fallback provider."""
+        config_dict = {
+            "version": "1.0",
+            "name": "test",
+            "nodes": {
+                "generate": {
+                    "prompt": "generate",
+                    "on_error": "fallback",
+                    "fallback": {"provider": "anthropic"},
+                }
+            },
+            "edges": [
+                {"from": "START", "to": "generate"},
+                {"from": "generate", "to": "END"},
+            ],
+        }
+        config = GraphConfig(config_dict)
+        assert config.nodes["generate"]["fallback"]["provider"] == "anthropic"
+
+    def test_validates_on_error_values(self):
+        """Invalid on_error value raises ValueError."""
+        config_dict = {
+            "version": "1.0",
+            "name": "test",
+            "nodes": {
+                "generate": {
+                    "prompt": "generate",
+                    "on_error": "invalid_value",
+                }
+            },
+            "edges": [
+                {"from": "START", "to": "generate"},
+                {"from": "generate", "to": "END"},
+            ],
+        }
+        with pytest.raises(ValueError, match="on_error"):
+            GraphConfig(config_dict)
+
+
+# =============================================================================
+# Test: on_error: skip Behavior
+# =============================================================================
+
+
+class TestOnErrorSkip:
+    """Tests for on_error: skip behavior."""
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_skip_returns_empty_on_failure(self, mock_execute):
+        """Node with on_error: skip returns empty dict on failure."""
+        mock_execute.side_effect = Exception("LLM failed")
+
+        node_config = {
+            "prompt": "generate",
+            "on_error": "skip",
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        result = node_fn({"topic": "test"})
+
+        # Should NOT have error, should continue pipeline
+        assert "error" not in result
+        assert result.get("current_step") == "generate"
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_skip_logs_warning(self, mock_execute):
+        """Node with on_error: skip logs a warning."""
+        mock_execute.side_effect = Exception("LLM failed")
+
+        node_config = {
+            "prompt": "generate",
+            "on_error": "skip",
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        with patch("yamlgraph.error_handlers.logger") as mock_logger:
+            node_fn({"topic": "test"})
+            mock_logger.warning.assert_called()
+
+
+# =============================================================================
+# Test: on_error: retry Behavior
+# =============================================================================
+
+
+class TestOnErrorRetry:
+    """Tests for on_error: retry behavior."""
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_retry_uses_node_max_retries(self, mock_execute):
+        """Node uses its own max_retries, not global."""
+        # Fail first 2 times, succeed on 3rd
+        mock_execute.side_effect = [
+            Exception("Retry 1"),
+            Exception("Retry 2"),
+            MagicMock(content="Success"),
+        ]
+
+        node_config = {
+            "prompt": "generate",
+            "on_error": "retry",
+            "max_retries": 3,
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        result = node_fn({"topic": "test"})
+
+        assert mock_execute.call_count == 3
+        assert "generated" in result
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_retry_exhausted_returns_error(self, mock_execute):
+        """After max_retries exhausted, returns error."""
+        mock_execute.side_effect = Exception("Always fails")
+
+        node_config = {
+            "prompt": "generate",
+            "on_error": "retry",
+            "max_retries": 2,
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        result = node_fn({"topic": "test"})
+
+        # 1 initial attempt + 2 retries = 3 total calls
+        assert mock_execute.call_count == 3
+        assert "errors" in result
+        assert isinstance(result["errors"][0], PipelineError)
+
+
+# =============================================================================
+# Test: on_error: fail Behavior
+# =============================================================================
+
+
+class TestOnErrorFail:
+    """Tests for on_error: fail behavior."""
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_fail_raises_exception(self, mock_execute):
+        """Node with on_error: fail raises exception."""
+        mock_execute.side_effect = Exception("LLM failed")
+
+        node_config = {
+            "prompt": "generate",
+            "on_error": "fail",
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        with pytest.raises(Exception, match="LLM failed"):
+            node_fn({"topic": "test"})
+
+
+# =============================================================================
+# Test: on_error: fallback Behavior
+# =============================================================================
+
+
+class TestOnErrorFallback:
+    """Tests for on_error: fallback behavior."""
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_fallback_tries_alternate_provider(self, mock_execute):
+        """Node tries fallback provider on primary failure."""
+        # First call (mistral) fails, second call (anthropic) succeeds
+        mock_execute.side_effect = [
+            Exception("Mistral failed"),
+            MagicMock(content="Anthropic success"),
+        ]
+
+        node_config = {
+            "prompt": "generate",
+            "provider": "mistral",
+            "on_error": "fallback",
+            "fallback": {"provider": "anthropic"},
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        result = node_fn({"topic": "test"})
+
+        assert mock_execute.call_count == 2
+        # Second call should use anthropic
+        second_call = mock_execute.call_args_list[1]
+        assert second_call.kwargs.get("provider") == "anthropic"
+        assert "generated" in result
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_all_providers_fail_returns_error(self, mock_execute):
+        """When all providers fail, returns error with all attempts."""
+        mock_execute.side_effect = Exception("All fail")
+
+        node_config = {
+            "prompt": "generate",
+            "provider": "mistral",
+            "on_error": "fallback",
+            "fallback": {"provider": "anthropic"},
+            "state_key": "generated",
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        result = node_fn({"topic": "test"})
+
+        assert mock_execute.call_count == 2
+        assert "errors" in result
+        assert isinstance(result["errors"][0], PipelineError)
+
+
+# =============================================================================
+# Test: Default on_error Behavior
+# =============================================================================
+
+
+class TestDefaultOnError:
+    """Tests for default error behavior (no on_error specified)."""
+
+    @patch("yamlgraph.node_factory.execute_prompt")
+    def test_default_behavior_returns_error(self, mock_execute):
+        """Without on_error config, current behavior returns error in state."""
+        mock_execute.side_effect = Exception("LLM failed")
+
+        node_config = {
+            "prompt": "generate",
+            "state_key": "generated",
+            # No on_error specified
+        }
+        node_fn = create_node_function("generate", node_config, {})
+
+        result = node_fn({"topic": "test"})
+
+        # Current default behavior: return error in state (as list for consistency)
+        assert "errors" in result
+        assert isinstance(result["errors"][0], PipelineError)

tests/unit/test_result_export.py

@@ -0,0 +1,234 @@
+"""Tests for Phase 6.4: Result Export.
+
+Tests field-based result export with multiple formats.
+"""
+
+import json
+from pathlib import Path
+
+from pydantic import BaseModel, Field
+
+
+class SampleModel(BaseModel):
+    """Sample model for testing."""
+
+    title: str
+    content: str
+    tags: list[str] = Field(default_factory=list)
+
+
+class TestExportResult:
+    """Tests for export_result function."""
+
+    def test_export_json_field(self, tmp_path: Path):
+        """Export field as JSON file."""
+        from yamlgraph.storage.export import export_result
+
+        state = {
+            "thread_id": "test-123",
+            "generated": SampleModel(title="Test", content="Body", tags=["a", "b"]),
+        }
+        config = {
+            "generated": {"format": "json", "filename": "content.json"},
+        }
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        assert len(paths) == 1
+        assert paths[0].name == "content.json"
+        assert paths[0].exists()
+
+        data = json.loads(paths[0].read_text())
+        assert data["title"] == "Test"
+        assert data["content"] == "Body"
+        assert data["tags"] == ["a", "b"]
+
+    def test_export_markdown_field(self, tmp_path: Path):
+        """Export field as Markdown file."""
+        from yamlgraph.storage.export import export_result
+
+        state = {
+            "thread_id": "test-456",
+            "summary": "This is the summary content.",
+        }
+        config = {
+            "summary": {"format": "markdown", "filename": "summary.md"},
+        }
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        assert len(paths) == 1
+        assert paths[0].name == "summary.md"
+        content = paths[0].read_text()
+        assert "This is the summary content." in content
+
+    def test_export_text_field(self, tmp_path: Path):
+        """Export field as plain text."""
+        from yamlgraph.storage.export import export_result
+
+        state = {
+            "thread_id": "test-789",
+            "output": "Plain text output",
+        }
+        config = {
+            "output": {"format": "text", "filename": "output.txt"},
+        }
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        assert len(paths) == 1
+        content = paths[0].read_text()
+        assert content == "Plain text output"
+
+    def test_export_creates_thread_directory(self, tmp_path: Path):
+        """Files are created in thread-specific subdirectory."""
+        from yamlgraph.storage.export import export_result
+
+        state = {
+            "thread_id": "my-thread-id",
+            "result": "data",
+        }
+        config = {"result": {"format": "text", "filename": "result.txt"}}
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        # Check directory structure
+        assert paths[0].parent.name == "my-thread-id"
+        assert paths[0].parent.parent == tmp_path
+
+    def test_export_skips_none_fields(self, tmp_path: Path):
+        """Fields with None value are skipped."""
+        from yamlgraph.storage.export import export_result
+
+        state = {
+            "thread_id": "test",
+            "present": "value",
+            "missing": None,
+        }
+        config = {
+            "present": {"format": "text", "filename": "present.txt"},
+            "missing": {"format": "text", "filename": "missing.txt"},
+        }
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        # Only one file created
+        assert len(paths) == 1
+        assert paths[0].name == "present.txt"
+
+    def test_export_skips_missing_fields(self, tmp_path: Path):
+        """Fields not in state are skipped."""
+        from yamlgraph.storage.export import export_result
+
+        state = {"thread_id": "test"}  # No 'data' field
+        config = {"data": {"format": "text", "filename": "data.txt"}}
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        assert len(paths) == 0
+
+    def test_export_multiple_fields(self, tmp_path: Path):
+        """Export multiple fields in one call."""
+        from yamlgraph.storage.export import export_result
+
+        state = {
+            "thread_id": "multi",
+            "summary": "Summary text",
+            "data": {"key": "value"},
+        }
+        config = {
+            "summary": {"format": "markdown", "filename": "summary.md"},
+            "data": {"format": "json", "filename": "data.json"},
+        }
+
+        paths = export_result(state, config, base_path=tmp_path)
+
+        assert len(paths) == 2
+        names = {p.name for p in paths}
+        assert "summary.md" in names
+        assert "data.json" in names
+
+
+class TestSerializeToJson:
+    """Tests for JSON serialization helper."""
+
+    def test_serializes_pydantic_model(self):
+        """Pydantic models serialize properly."""
+        from yamlgraph.storage.export import _serialize_to_json
+
+        model = SampleModel(title="Test", content="Body")
+        result = _serialize_to_json(model)
+        data = json.loads(result)
+
+        assert data["title"] == "Test"
+        assert data["content"] == "Body"
+
+    def test_serializes_dict(self):
+        """Regular dicts serialize properly."""
+        from yamlgraph.storage.export import _serialize_to_json
+
+        result = _serialize_to_json({"a": 1, "b": [1, 2, 3]})
+        data = json.loads(result)
+
+        assert data["a"] == 1
+        assert data["b"] == [1, 2, 3]
+
+    def test_serializes_with_indent(self):
+        """JSON output is indented."""
+        from yamlgraph.storage.export import _serialize_to_json
+
+        result = _serialize_to_json({"key": "value"})
+        # Indented JSON has newlines
+        assert "\n" in result
+
+
+class TestPydanticToMarkdown:
+    """Tests for Pydantic to Markdown conversion."""
+
+    def test_includes_model_name_as_title(self):
+        """Model name becomes the markdown title."""
+        from yamlgraph.storage.export import _pydantic_to_markdown
+
+        model = SampleModel(title="Test", content="Body")
+        result = _pydantic_to_markdown(model)
+
+        assert result.startswith("# SampleModel")
+
+    def test_formats_list_fields_as_bullets(self):
+        """List fields become bullet points."""
+        from yamlgraph.storage.export import _pydantic_to_markdown
+
+        model = SampleModel(title="Test", content="Body", tags=["one", "two"])
+        result = _pydantic_to_markdown(model)
+
+        assert "- one" in result
+        assert "- two" in result
+
+    def test_formats_scalar_fields_bold(self):
+        """Scalar fields use bold labels."""
+        from yamlgraph.storage.export import _pydantic_to_markdown
+
+        model = SampleModel(title="Test", content="Body")
+        result = _pydantic_to_markdown(model)
+
+        assert "**Title**: Test" in result
+
+
+class TestSerializeToMarkdown:
+    """Tests for markdown serialization."""
+
+    def test_pydantic_model_uses_pydantic_to_markdown(self):
+        """Pydantic models use _pydantic_to_markdown."""
+        from yamlgraph.storage.export import _serialize_to_markdown
+
+        model = SampleModel(title="Test", content="Body")
+        result = _serialize_to_markdown(model)
+
+        assert "# SampleModel" in result
+
+    def test_string_value_returns_as_is(self):
+        """String values return as-is."""
+        from yamlgraph.storage.export import _serialize_to_markdown
+
+        result = _serialize_to_markdown("Just a string")
+        assert result == "Just a string"