xai-review 0.37.0__py3-none-any.whl → 0.39.0__py3-none-any.whl

ai_review/tests/suites/services/vcs/{bitbucket → bitbucket_cloud}/test_client.py

@@ -1,18 +1,18 @@
 import pytest
 
-from ai_review.services.vcs.bitbucket.client import BitbucketVCSClient
+from ai_review.services.vcs.bitbucket_cloud.client import BitbucketCloudVCSClient
 from ai_review.services.vcs.types import ReviewInfoSchema, ReviewCommentSchema, ReviewThreadSchema, ThreadKind
-from ai_review.tests.fixtures.clients.bitbucket import FakeBitbucketPullRequestsHTTPClient
+from ai_review.tests.fixtures.clients.bitbucket_cloud import FakeBitbucketCloudPullRequestsHTTPClient
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_get_review_info_returns_valid_schema(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should return detailed PR info with branches, author, reviewers, and files."""
-    info = await bitbucket_vcs_client.get_review_info()
+    info = await bitbucket_cloud_vcs_client.get_review_info()
 
     assert isinstance(info, ReviewInfoSchema)
     assert info.id == 1
@@ -20,7 +20,7 @@ async def test_get_review_info_returns_valid_schema(
     assert info.description == "This is a fake PR for testing"
 
     assert info.author.username == "tester"
-    assert {r.username for r in info.reviewers} == {"reviewer"}
+    assert {reviewer.username for reviewer in info.reviewers} == {"reviewer"}
 
     assert info.source_branch.ref == "feature/test"
     assert info.target_branch.ref == "main"
@@ -30,20 +30,20 @@ async def test_get_review_info_returns_valid_schema(
     assert "app/main.py" in info.changed_files
     assert len(info.changed_files) == 2
 
-    called_methods = [name for name, _ in fake_bitbucket_pull_requests_http_client.calls]
+    called_methods = [name for name, _ in fake_bitbucket_cloud_pull_requests_http_client.calls]
     assert called_methods == ["get_pull_request", "get_files"]
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_get_general_comments_filters_inline(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should return only general comments (without inline info)."""
-    comments = await bitbucket_vcs_client.get_general_comments()
+    comments = await bitbucket_cloud_vcs_client.get_general_comments()
 
-    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert all(isinstance(comment, ReviewCommentSchema) for comment in comments)
     assert len(comments) == 1
 
     first = comments[0]
@@ -51,20 +51,20 @@ async def test_get_general_comments_filters_inline(
     assert first.file is None
     assert first.line is None
 
-    called_methods = [name for name, _ in fake_bitbucket_pull_requests_http_client.calls]
+    called_methods = [name for name, _ in fake_bitbucket_cloud_pull_requests_http_client.calls]
     assert called_methods == ["get_comments"]
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_get_inline_comments_filters_general(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should return only inline comments with file and line references."""
-    comments = await bitbucket_vcs_client.get_inline_comments()
+    comments = await bitbucket_cloud_vcs_client.get_inline_comments()
 
-    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert all(isinstance(comment, ReviewCommentSchema) for comment in comments)
     assert len(comments) == 1
 
     first = comments[0]
@@ -72,22 +72,22 @@ async def test_get_inline_comments_filters_general(
     assert first.file == "file.py"
     assert first.line == 5
 
-    called_methods = [name for name, _ in fake_bitbucket_pull_requests_http_client.calls]
+    called_methods = [name for name, _ in fake_bitbucket_cloud_pull_requests_http_client.calls]
     assert called_methods == ["get_comments"]
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_create_general_comment_posts_comment(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should post a general (non-inline) comment."""
     message = "Hello from Bitbucket test!"
 
-    await bitbucket_vcs_client.create_general_comment(message)
+    await bitbucket_cloud_vcs_client.create_general_comment(message)
 
-    calls = [args for name, args in fake_bitbucket_pull_requests_http_client.calls if name == "create_comment"]
+    calls = [args for name, args in fake_bitbucket_cloud_pull_requests_http_client.calls if name == "create_comment"]
     assert len(calls) == 1
     call_args = calls[0]
     assert call_args["content"]["raw"] == message
@@ -96,19 +96,19 @@ async def test_create_general_comment_posts_comment(
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_create_inline_comment_posts_comment(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should post an inline comment with correct file and line."""
     file = "file.py"
     line = 10
     message = "Looks good"
 
-    await bitbucket_vcs_client.create_inline_comment(file, line, message)
+    await bitbucket_cloud_vcs_client.create_inline_comment(file, line, message)
 
-    calls = [args for name, args in fake_bitbucket_pull_requests_http_client.calls if name == "create_comment"]
+    calls = [args for name, args in fake_bitbucket_cloud_pull_requests_http_client.calls if name == "create_comment"]
     assert len(calls) == 1
 
     call_args = calls[0]
@@ -118,18 +118,18 @@ async def test_create_inline_comment_posts_comment(
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_create_inline_reply_posts_comment(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should post a reply to an existing inline thread."""
     thread_id = 42
     message = "I agree with this inline comment."
 
-    await bitbucket_vcs_client.create_inline_reply(thread_id, message)
+    await bitbucket_cloud_vcs_client.create_inline_reply(thread_id, message)
 
-    calls = [args for name, args in fake_bitbucket_pull_requests_http_client.calls if name == "create_comment"]
+    calls = [args for name, args in fake_bitbucket_cloud_pull_requests_http_client.calls if name == "create_comment"]
     assert len(calls) == 1
 
     call_args = calls[0]
@@ -140,18 +140,18 @@ async def test_create_inline_reply_posts_comment(
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_create_summary_reply_posts_comment_with_parent(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should post a reply to a general thread (same API with parent id)."""
     thread_id = 7
     message = "Thanks for the clarification."
 
-    await bitbucket_vcs_client.create_summary_reply(thread_id, message)
+    await bitbucket_cloud_vcs_client.create_summary_reply(thread_id, message)
 
-    calls = [args for name, args in fake_bitbucket_pull_requests_http_client.calls if name == "create_comment"]
+    calls = [args for name, args in fake_bitbucket_cloud_pull_requests_http_client.calls if name == "create_comment"]
     assert len(calls) == 1
 
     call_args = calls[0]
@@ -162,13 +162,13 @@ async def test_create_summary_reply_posts_comment_with_parent(
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_get_inline_threads_groups_by_thread_id(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should group inline comments into threads."""
-    threads = await bitbucket_vcs_client.get_inline_threads()
+    threads = await bitbucket_cloud_vcs_client.get_inline_threads()
 
     assert all(isinstance(thread, ReviewThreadSchema) for thread in threads)
     assert len(threads) == 1
@@ -180,25 +180,25 @@ async def test_get_inline_threads_groups_by_thread_id(
     assert len(thread.comments) == 1
     assert isinstance(thread.comments[0], ReviewCommentSchema)
 
-    called_methods = [name for name, _ in fake_bitbucket_pull_requests_http_client.calls]
+    called_methods = [name for name, _ in fake_bitbucket_cloud_pull_requests_http_client.calls]
     assert "get_comments" in called_methods
 
 
 @pytest.mark.asyncio
-@pytest.mark.usefixtures("bitbucket_http_client_config")
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
 async def test_get_general_threads_groups_by_thread_id(
-        bitbucket_vcs_client: BitbucketVCSClient,
-        fake_bitbucket_pull_requests_http_client: FakeBitbucketPullRequestsHTTPClient,
+        bitbucket_cloud_vcs_client: BitbucketCloudVCSClient,
+        fake_bitbucket_cloud_pull_requests_http_client: FakeBitbucketCloudPullRequestsHTTPClient,
 ):
     """Should group general (non-inline) comments into SUMMARY threads."""
-    threads = await bitbucket_vcs_client.get_general_threads()
+    threads = await bitbucket_cloud_vcs_client.get_general_threads()
 
-    assert all(isinstance(t, ReviewThreadSchema) for t in threads)
+    assert all(isinstance(thread, ReviewThreadSchema) for thread in threads)
     assert len(threads) == 1
     thread = threads[0]
     assert thread.kind == ThreadKind.SUMMARY
     assert len(thread.comments) == 1
     assert isinstance(thread.comments[0], ReviewCommentSchema)
 
-    called_methods = [name for name, _ in fake_bitbucket_pull_requests_http_client.calls]
+    called_methods = [name for name, _ in fake_bitbucket_cloud_pull_requests_http_client.calls]
     assert "get_comments" in called_methods

ai_review/tests/suites/services/vcs/bitbucket_server/test_adapter.py

@@ -0,0 +1,115 @@
+from ai_review.clients.bitbucket_server.pr.schema.comments import (
+    BitbucketServerCommentSchema,
+    BitbucketServerCommentAnchorSchema,
+)
+from ai_review.clients.bitbucket_server.pr.schema.user import BitbucketServerUserSchema
+from ai_review.services.vcs.bitbucket_server.adapter import get_review_comment_from_bitbucket_server_comment
+from ai_review.services.vcs.types import ReviewCommentSchema, UserSchema
+
+
+def test_maps_all_fields_correctly():
+    """Should map Bitbucket Server comment with all fields correctly."""
+    comment = BitbucketServerCommentSchema(
+        id=101,
+        text="Looks good",
+        author=BitbucketServerUserSchema(
+            id=1,
+            name="alice",
+            slug="alice",
+            display_name="Alice",
+        ),
+        anchor=BitbucketServerCommentAnchorSchema(path="src/utils.py", line=10, line_type="ADDED"),
+        comments=[],
+        created_date=1690000000,
+        updated_date=1690000001,
+    )
+
+    result = get_review_comment_from_bitbucket_server_comment(comment)
+
+    assert isinstance(result, ReviewCommentSchema)
+    assert result.id == 101
+    assert result.body == "Looks good"
+    assert result.file == "src/utils.py"
+    assert result.line == 10
+    assert result.parent_id is None
+    assert result.thread_id == 101
+
+    assert isinstance(result.author, UserSchema)
+    assert result.author.id == 1
+    assert result.author.name == "Alice"
+    assert result.author.username == "alice"
+
+
+def test_maps_author_with_missing_fields():
+    """Should handle partially filled author fields gracefully."""
+    comment = BitbucketServerCommentSchema(
+        id=202,
+        text="Anonymous-like comment",
+        author=BitbucketServerUserSchema(
+            id=None,
+            name="",
+            slug=None,
+            display_name="",
+        ),
+        anchor=BitbucketServerCommentAnchorSchema(path="src/app.py", line=15, line_type="ADDED"),
+        comments=[],
+        created_date=1690000004,
+        updated_date=1690000005,
+    )
+
+    result = get_review_comment_from_bitbucket_server_comment(comment)
+
+    assert isinstance(result, ReviewCommentSchema)
+    assert result.author.id is None
+    assert result.author.name == ""
+    assert result.author.username == ""
+
+
+def test_maps_without_anchor():
+    """Should handle missing anchor gracefully."""
+    comment = BitbucketServerCommentSchema(
+        id=303,
+        text="General feedback",
+        author=BitbucketServerUserSchema(
+            id=4,
+            name="dave",
+            slug="dave",
+            display_name="Dave",
+        ),
+        anchor=None,
+        comments=[],
+        created_date=1690000006,
+        updated_date=1690000007,
+    )
+
+    result = get_review_comment_from_bitbucket_server_comment(comment)
+
+    assert result.file is None
+    assert result.line is None
+    assert result.thread_id == 303
+
+
+def test_maps_empty_text_defaults_to_empty_body():
+    """Should default empty text to empty body."""
+    comment = BitbucketServerCommentSchema(
+        id=404,
+        text="",
+        author=BitbucketServerUserSchema(
+            id=7,
+            name="ghost",
+            slug="ghost",
+            display_name="Ghost",
+        ),
+        anchor=None,
+        comments=[],
+        created_date=1690000008,
+        updated_date=1690000009,
+    )
+
+    result = get_review_comment_from_bitbucket_server_comment(comment)
+
+    assert isinstance(result, ReviewCommentSchema)
+    assert result.body == ""
+    assert result.file is None
+    assert result.line is None
+    assert result.thread_id == 404

ai_review/tests/suites/services/vcs/bitbucket_server/test_client.py

@@ -0,0 +1,201 @@
+import pytest
+
+from ai_review.services.vcs.bitbucket_server.client import BitbucketServerVCSClient
+from ai_review.services.vcs.types import ReviewInfoSchema, ReviewCommentSchema, ReviewThreadSchema, ThreadKind
+from ai_review.tests.fixtures.clients.bitbucket_server import FakeBitbucketServerPullRequestsHTTPClient
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_get_review_info_returns_valid_schema(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should return detailed PR info with branches, author, reviewers, and files."""
+    info = await bitbucket_server_vcs_client.get_review_info()
+
+    assert isinstance(info, ReviewInfoSchema)
+    assert info.id == 1
+    assert info.title == "Fake Bitbucket Server PR"
+    assert info.description == "PR for testing server client"
+
+    assert info.author.username == "author"
+    assert {reviewer.username for reviewer in info.reviewers} == {"reviewer"}
+
+    assert info.source_branch.ref == "feature/test"
+    assert info.target_branch.ref == "main"
+    assert info.base_sha == "abc123"
+    assert info.head_sha == "def456"
+
+    assert "src/main.py" in info.changed_files
+    assert len(info.changed_files) == 1
+
+    called_methods = [name for name, _ in fake_bitbucket_server_pull_requests_http_client.calls]
+    assert called_methods == ["get_pull_request", "get_changes"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_get_general_comments_filters_inline(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should return only general comments (without anchor)."""
+    comments = await bitbucket_server_vcs_client.get_general_comments()
+
+    assert all(isinstance(comment, ReviewCommentSchema) for comment in comments)
+    assert len(comments) == 1
+
+    first = comments[0]
+    assert first.body == "General comment"
+    assert first.file is None
+    assert first.line is None
+
+    called_methods = [name for name, _ in fake_bitbucket_server_pull_requests_http_client.calls]
+    assert called_methods == ["get_comments"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_get_inline_comments_filters_general(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should return only inline comments with file and line references."""
+    comments = await bitbucket_server_vcs_client.get_inline_comments()
+
+    assert all(isinstance(comment, ReviewCommentSchema) for comment in comments)
+    assert len(comments) == 1
+
+    first = comments[0]
+    assert first.body == "Inline comment"
+    assert first.file == "src/main.py"
+    assert first.line == 5
+
+    called_methods = [name for name, _ in fake_bitbucket_server_pull_requests_http_client.calls]
+    assert called_methods == ["get_comments"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_create_general_comment_posts_comment(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should post a general (non-inline) comment."""
+    message = "Hello from Bitbucket Server test!"
+
+    await bitbucket_server_vcs_client.create_general_comment(message)
+
+    calls = [args for name, args in fake_bitbucket_server_pull_requests_http_client.calls if name == "create_comment"]
+    assert len(calls) == 1
+    call_args = calls[0]
+    assert call_args["text"] == message
+    assert call_args["project_key"] == "PRJ"
+    assert call_args["repo_slug"] == "repo"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_create_inline_comment_posts_comment(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should post an inline comment with correct file and line."""
+    file = "src/app.py"
+    line = 10
+    message = "Looks good"
+
+    await bitbucket_server_vcs_client.create_inline_comment(file, line, message)
+
+    calls = [args for name, args in fake_bitbucket_server_pull_requests_http_client.calls if name == "create_comment"]
+    assert len(calls) == 1
+
+    call_args = calls[0]
+    assert call_args["text"] == message
+    assert call_args["anchor"]["path"] == file
+    assert call_args["anchor"]["line"] == line
+    assert call_args["anchor"]["lineType"] == "ADDED"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_create_inline_reply_posts_comment(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should post a reply to an existing inline thread."""
+    thread_id = 42
+    message = "Reply inline comment"
+
+    await bitbucket_server_vcs_client.create_inline_reply(thread_id, message)
+
+    calls = [args for name, args in fake_bitbucket_server_pull_requests_http_client.calls if name == "create_comment"]
+    assert len(calls) == 1
+
+    call_args = calls[0]
+    assert call_args["parent"]["id"] == thread_id
+    assert call_args["text"] == message
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_create_summary_reply_posts_comment(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should post a reply to a general thread (same API with parent id)."""
+    thread_id = 7
+    message = "Thanks for the clarification."
+
+    await bitbucket_server_vcs_client.create_summary_reply(thread_id, message)
+
+    calls = [args for name, args in fake_bitbucket_server_pull_requests_http_client.calls if name == "create_comment"]
+    assert len(calls) == 1
+
+    call_args = calls[0]
+    assert call_args["parent"]["id"] == thread_id
+    assert call_args["text"] == message
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_get_inline_threads_groups_by_thread_id(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should group inline comments into threads."""
+    threads = await bitbucket_server_vcs_client.get_inline_threads()
+
+    assert all(isinstance(thread, ReviewThreadSchema) for thread in threads)
+    assert len(threads) == 1
+
+    thread = threads[0]
+    assert thread.kind == ThreadKind.INLINE
+    assert thread.file == "src/main.py"
+    assert thread.line == 5
+    assert len(thread.comments) == 1
+    assert isinstance(thread.comments[0], ReviewCommentSchema)
+
+    called_methods = [name for name, _ in fake_bitbucket_server_pull_requests_http_client.calls]
+    assert "get_comments" in called_methods
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+async def test_get_general_threads_groups_by_thread_id(
+        bitbucket_server_vcs_client: BitbucketServerVCSClient,
+        fake_bitbucket_server_pull_requests_http_client: FakeBitbucketServerPullRequestsHTTPClient,
+):
+    """Should group general (non-inline) comments into SUMMARY threads."""
+    threads = await bitbucket_server_vcs_client.get_general_threads()
+
+    assert all(isinstance(thread, ReviewThreadSchema) for thread in threads)
+    assert len(threads) == 1
+    thread = threads[0]
+    assert thread.kind == ThreadKind.SUMMARY
+    assert len(thread.comments) == 1
+    assert isinstance(thread.comments[0], ReviewCommentSchema)
+
+    called_methods = [name for name, _ in fake_bitbucket_server_pull_requests_http_client.calls]
+    assert "get_comments" in called_methods

ai_review/tests/suites/services/vcs/test_factory.py

@@ -1,6 +1,7 @@
 import pytest
 
-from ai_review.services.vcs.bitbucket.client import BitbucketVCSClient
+from ai_review.services.vcs.bitbucket_cloud.client import BitbucketCloudVCSClient
+from ai_review.services.vcs.bitbucket_server.client import BitbucketServerVCSClient
 from ai_review.services.vcs.factory import get_vcs_client
 from ai_review.services.vcs.gitea.client import GiteaVCSClient
 from ai_review.services.vcs.github.client import GitHubVCSClient
@@ -25,10 +26,16 @@ def test_get_vcs_client_returns_gitlab(monkeypatch: pytest.MonkeyPatch):
     assert isinstance(client, GitLabVCSClient)
 
 
-@pytest.mark.usefixtures("bitbucket_http_client_config")
-def test_get_vcs_client_returns_bitbucket(monkeypatch: pytest.MonkeyPatch):
+@pytest.mark.usefixtures("bitbucket_cloud_http_client_config")
+def test_get_vcs_client_returns_bitbucket_cloud(monkeypatch: pytest.MonkeyPatch):
     client = get_vcs_client()
-    assert isinstance(client, BitbucketVCSClient)
+    assert isinstance(client, BitbucketCloudVCSClient)
+
+
+@pytest.mark.usefixtures("bitbucket_server_http_client_config")
+def test_get_vcs_client_returns_bitbucket_server(monkeypatch: pytest.MonkeyPatch):
+    client = get_vcs_client()
+    assert isinstance(client, BitbucketServerVCSClient)
 
 
 def test_get_vcs_client_unsupported_provider(monkeypatch: pytest.MonkeyPatch):

{xai_review-0.37.0.dist-info → xai_review-0.39.0.dist-info}/METADATA

@@ -1,8 +1,8 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.37.0
-Summary: AI-powered code review tool for GitHub, GitLab, Bitbucket and Gitea — built with LLMs like OpenAI, Claude, Gemini, Ollama, and OpenRouter
-Author-email: Nikita Filonov <nikita.filonov@example.com>
+Version: 0.39.0
+Summary: AI-powered code review tool for GitHub, GitLab, Bitbucket Cloud, Bitbucket Server and Gitea — built with LLMs like OpenAI, Claude, Gemini, Ollama, and OpenRouter
+Author-email: Nikita Filonov <nikita.filonov@gmail.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
 License:                                  Apache License
                                    Version 2.0, January 2004
@@ -208,7 +208,7 @@ License:                                  Apache License
 Project-URL: Issues, https://github.com/Nikita-Filonov/ai-review/issues
 Project-URL: Homepage, https://github.com/Nikita-Filonov/ai-review
 Project-URL: Repository, https://github.com/Nikita-Filonov/ai-review
-Keywords: ai,code review,llm,openai,claude,gemini,ollama,openrouter,ci/cd,gitlab,github,gitea,bitbucket
+Keywords: ai,code review,llm,openai,claude,gemini,ollama,openrouter,ci/cd,gitlab,github,gitea,bitbucket,bitbucket cloud,bitbucket server
 Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
@@ -268,7 +268,8 @@ improve code quality, enforce consistency, and speed up the review process.
 
 - **Multiple LLM providers** — choose between **OpenAI**, **Claude**, **Gemini**, **Ollama**, or **OpenRouter**, and
   switch anytime.
-- **VCS integration** — works out of the box with **GitLab**, **GitHub**, **Bitbucket**, and **Gitea**.
+- **VCS integration** — works out of the box with **GitLab**, **GitHub**, **Bitbucket Cloud**, **Bitbucket Server**,
+  and **Gitea**.
 - **Customizable prompts** — adapt inline, context, and summary reviews to match your team’s coding guidelines.
 - **Reply modes** — AI can now **participate in existing review threads**, adding follow-up replies in both inline and
   summary discussions.
@@ -379,7 +380,8 @@ Key things you can customize:
 
 - **LLM provider** — OpenAI, Gemini, Claude, Ollama, or OpenRouter
 - **Model settings** — model name, temperature, max tokens
-- **VCS integration** — works out of the box with **GitLab**, **GitHub**, **Bitbucket**, and **Gitea**
+- **VCS integration** — works out of the box with **GitLab**, **GitHub**, **Bitbucket Cloud**, **Bitbucket Server**, and
+  **Gitea**
 - **Review policy** — which files to include/exclude, review modes
 - **Prompts** — inline/context/summary prompt templates
 
@@ -421,7 +423,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: Nikita-Filonov/ai-review@v0.37.0
+      - uses: Nikita-Filonov/ai-review@v0.39.0
         with:
           review-command: ${{ inputs.review-command }}
         env: