xai-review 0.3.0__py3-none-any.whl

ai_review/tests/suites/services/diff/test_renderers.py

@@ -0,0 +1,168 @@
+# ai_review/tests/services/diff/test_renderers.py
+
+import pytest
+
+from ai_review.libs.diff.models import (
+    DiffFile,
+    DiffHunk,
+    DiffRange,
+    DiffLine,
+    DiffLineType,
+    FileMode,
+)
+from ai_review.services.diff import renderers, tools
+
+
+# ---------- fixtures ----------
+
+@pytest.fixture
+def sample_diff_file() -> DiffFile:
+    """
+    Build a synthetic DiffFile with one hunk that simulates:
+
+    Original file:
+      1: keep A       (UNCHANGED)
+      2: remove me    (REMOVED)
+      3: keep B       (UNCHANGED)
+
+    New file:
+      1: keep A       (UNCHANGED)
+      2: keep B       (UNCHANGED)
+      3: added me     (ADDED)
+
+    The hunk.lines sequence (like in unified diff) is:
+      UNCHANGED("keep A"),
+      REMOVED("remove me"),
+      UNCHANGED("keep B"),
+      ADDED("added me")
+    """
+    # unified view for hunk.lines
+    line_u1 = DiffLine(DiffLineType.UNCHANGED, number=None, content="keep A", position=1)
+    line_r2 = DiffLine(DiffLineType.REMOVED, number=None, content="remove me", position=2)
+    line_u2 = DiffLine(DiffLineType.UNCHANGED, number=None, content="keep B", position=3)
+    line_a3 = DiffLine(DiffLineType.ADDED, number=None, content="added me", position=4)
+
+    # original and new ranges with numbering
+    orig_u1 = DiffLine(DiffLineType.UNCHANGED, number=1, content="keep A", position=1)
+    orig_r2 = DiffLine(DiffLineType.REMOVED, number=2, content="remove me", position=2)
+    orig_u3 = DiffLine(DiffLineType.UNCHANGED, number=3, content="keep B", position=3)
+
+    new_u1 = DiffLine(DiffLineType.UNCHANGED, number=1, content="keep A", position=1)
+    new_u2 = DiffLine(DiffLineType.UNCHANGED, number=2, content="keep B", position=2)
+    new_a3 = DiffLine(DiffLineType.ADDED, number=3, content="added me", position=3)
+
+    hunk = DiffHunk(
+        header="",
+        orig_range=DiffRange(start=1, length=3, lines=[orig_u1, orig_r2, orig_u3]),
+        new_range=DiffRange(start=1, length=3, lines=[new_u1, new_u2, new_a3]),
+        lines=[line_u1, line_r2, line_u2, line_a3],
+    )
+
+    return DiffFile(
+        header="diff --git a/x b/x",
+        mode=FileMode.MODIFIED,
+        orig_name="a/x",
+        new_name="b/x",
+        hunks=[hunk],
+    )
+
+
+@pytest.fixture(autouse=True)
+def patch_marker(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Patch marker_for_line to use simple markers (# added / # removed)."""
+
+    def fake_marker(line_type=None, *, added: bool = False, removed: bool = False) -> str:
+        if added or line_type is DiffLineType.ADDED:
+            return " # added"
+        if removed or line_type is DiffLineType.REMOVED:
+            return " # removed"
+        return ""
+
+    monkeypatch.setattr(tools, "marker_for_line", fake_marker)
+
+
+# ---------- tests: FULL FILE ----------
+
+def test_build_full_file_current(monkeypatch: pytest.MonkeyPatch, sample_diff_file: DiffFile) -> None:
+    monkeypatch.setattr(
+        "ai_review.services.diff.renderers.read_snapshot",
+        lambda *_, **__: "keep A\nkeep B\nadded me",
+    )
+    out = renderers.build_full_file_current(sample_diff_file, "x", head_sha="HEAD")
+    assert out == "1: keep A\n2: keep B\n3: added me # added"
+
+
+def test_build_full_file_previous(monkeypatch: pytest.MonkeyPatch, sample_diff_file: DiffFile) -> None:
+    monkeypatch.setattr(
+        "ai_review.services.diff.renderers.read_snapshot",
+        lambda *_, **__: "keep A\nremove me\nkeep B",
+    )
+    out = renderers.build_full_file_previous(sample_diff_file, "x", base_sha="BASE")
+    assert out == "1: keep A\n2: remove me # removed\n3: keep B"
+
+
+def test_build_full_file_diff(sample_diff_file: DiffFile) -> None:
+    out = renderers.build_full_file_diff(sample_diff_file)
+    assert out == (
+        " 1: keep A\n"
+        "-2: remove me # removed\n"
+        " 2: keep B\n"
+        "+3: added me # added"
+    )
+
+
+# ---------- tests: ONLY_* ----------
+
+def test_build_only_added(sample_diff_file: DiffFile) -> None:
+    """
+    Should render only added lines.
+    """
+    out = renderers.build_only_added(sample_diff_file)
+    assert out == "+3: added me # added"
+
+
+def test_build_only_removed(sample_diff_file: DiffFile) -> None:
+    """
+    Should render only removed lines.
+    """
+    out = renderers.build_only_removed(sample_diff_file)
+    assert out == "-2: remove me # removed"
+
+
+def test_build_added_and_removed(sample_diff_file: DiffFile) -> None:
+    """
+    Should render both removed and added lines, in hunk order.
+    """
+    out = renderers.build_added_and_removed(sample_diff_file)
+    assert out == "-2: remove me # removed\n+3: added me # added"
+
+
+# ---------- tests: *_WITH_CONTEXT ----------
+
+def test_build_only_added_with_context(sample_diff_file: DiffFile) -> None:
+    """
+    Should render added lines plus unchanged context lines within ±1.
+    """
+    out = renderers.build_only_added_with_context(sample_diff_file, context=1)
+    assert out == " 2: keep B\n+3: added me # added"
+
+
+def test_build_only_removed_with_context(sample_diff_file: DiffFile) -> None:
+    """
+    Should render removed lines plus unchanged context lines within ±1.
+    """
+    out = renderers.build_only_removed_with_context(sample_diff_file, context=1)
+    assert out == " 1: keep A\n-2: remove me # removed\n 2: keep B"
+
+
+def test_build_added_and_removed_with_context(sample_diff_file: DiffFile) -> None:
+    """
+    Should render both added and removed lines, plus unchanged context within ±1.
+    """
+    out = renderers.build_added_and_removed_with_context(sample_diff_file, context=1)
+    assert out == (
+        " 1: keep A\n"
+        "-2: remove me # removed\n"
+        " 2: keep B\n"
+        "+3: added me # added"
+    )

ai_review/tests/suites/services/diff/test_service.py

@@ -0,0 +1,84 @@
+import pytest
+
+from ai_review import config
+from ai_review.libs.config.review import ReviewMode
+from ai_review.libs.diff.models import Diff, DiffFile, FileMode
+from ai_review.services.diff.service import DiffService
+from ai_review.tests.fixtures.git import FakeGitService
+
+
+@pytest.fixture
+def fake_diff_file() -> DiffFile:
+    return DiffFile(
+        header="diff --git a/x b/x",
+        mode=FileMode.MODIFIED,
+        orig_name="a/x",
+        new_name="b/x",
+        hunks=[]
+    )
+
+
+@pytest.fixture
+def fake_diff(fake_diff_file: DiffFile) -> Diff:
+    return Diff(files=[fake_diff_file], raw="raw-diff")
+
+
+def test_parse_empty_returns_empty_diff():
+    diff = DiffService.parse("")
+    assert diff.files == []
+    assert diff.raw == ""
+
+
+def test_parse_nonempty(monkeypatch: pytest.MonkeyPatch, fake_diff: Diff):
+    monkeypatch.setattr("ai_review.services.diff.service.DiffParser.parse", lambda _: fake_diff)
+    diff = DiffService.parse("something")
+    assert diff.files[0].new_name == "b/x"
+
+
+@pytest.mark.parametrize("mode,expected_prefix", [
+    (ReviewMode.FULL_FILE_CURRENT, "# Failed to read current snapshot"),
+    (ReviewMode.FULL_FILE_PREVIOUS, "# Failed to read previous snapshot"),
+    (ReviewMode.FULL_FILE_DIFF, "# No matching lines for mode"),
+    (ReviewMode.ONLY_ADDED, "# No matching lines for mode"),
+    (ReviewMode.ONLY_REMOVED, "# No matching lines for mode"),
+    (ReviewMode.ADDED_AND_REMOVED, "# No matching lines for mode"),
+    (ReviewMode.ONLY_ADDED_WITH_CONTEXT, "# No matching lines for mode"),
+    (ReviewMode.ONLY_REMOVED_WITH_CONTEXT, "# No matching lines for mode"),
+    (ReviewMode.ADDED_AND_REMOVED_WITH_CONTEXT, "# No matching lines for mode"),
+])
+def test_render_file_routes_to_right_builder(
+        mode: ReviewMode,
+        fake_diff: Diff,
+        monkeypatch: pytest.MonkeyPatch,
+        expected_prefix: str
+):
+    monkeypatch.setattr("ai_review.services.diff.service.DiffParser.parse", lambda _: fake_diff)
+    monkeypatch.setattr(config.settings.review, "mode", mode)
+
+    out = DiffService.render_file(raw_diff="fake", file="b/x")
+    assert out.file == "b/x"
+    assert out.diff.startswith(expected_prefix)
+
+
+def test_render_file_returns_unsupported(monkeypatch: pytest.MonkeyPatch, fake_diff: Diff):
+    monkeypatch.setattr("ai_review.services.diff.service.DiffParser.parse", lambda _: fake_diff)
+    monkeypatch.setattr(config.settings.review, "mode", "NON_EXISTING")
+    out = DiffService.render_file(raw_diff="fake", file="b/x")
+    assert out.file == "b/x"
+    assert "# Unsupported mode" in out.diff
+
+
+def test_render_files_invokes_render_file(
+        fake_git: FakeGitService,
+        fake_diff: Diff,
+        monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr("ai_review.services.diff.service.DiffParser.parse", lambda _: fake_diff)
+    monkeypatch.setattr(config.settings.review, "mode", ReviewMode.FULL_FILE_DIFF)
+
+    fake_git.responses["get_diff_for_file"] = "fake-diff"
+
+    out = DiffService.render_files(git=fake_git, base_sha="A", head_sha="B", files=["b/x"])
+    assert out
+    assert out[0].file == "b/x"
+    assert out[0].diff.startswith("# No matching lines for mode")

ai_review/tests/suites/services/diff/test_tools.py

@@ -0,0 +1,108 @@
+# ai_review/tests/services/diff/test_tools.py
+from pathlib import Path
+
+import pytest
+
+from ai_review.libs.diff.models import Diff, DiffFile, DiffHunk, DiffRange, DiffLineType, FileMode
+from ai_review.services.diff import tools
+from ai_review.tests.fixtures.git import FakeGitService
+
+
+# ---------- normalize_file_path ----------
+
+@pytest.mark.parametrize(
+    ("inp", "expected"),
+    [
+        ("", ""),
+        ("./foo/bar.py", "foo/bar.py"),
+        ("a/foo.py", "foo.py"),
+        ("b\\foo.py", "foo.py"),
+        ("plain.py", "plain.py"),
+    ],
+)
+def test_normalize_file_path_variants(inp: str, expected: str) -> None:
+    assert tools.normalize_file_path(inp) == expected
+
+
+# ---------- find_diff_file ----------
+
+def make_dummy_file(orig: str = "a/x.py", new: str = "b/x.py") -> DiffFile:
+    hunk = DiffHunk(
+        header="",
+        orig_range=DiffRange(1, 0, []),
+        new_range=DiffRange(1, 0, []),
+        lines=[],
+    )
+    return DiffFile(header="hdr", mode=FileMode.MODIFIED, orig_name=orig, new_name=new, hunks=[hunk])
+
+
+def test_find_diff_file_found_by_newname() -> None:
+    f = make_dummy_file(new="b/test.py")
+    diff = Diff(files=[f], raw="raw")
+    assert tools.find_diff_file(diff, "test.py") is f
+
+
+def test_find_diff_file_found_by_orig_name() -> None:
+    f = make_dummy_file(orig="a/old.py")
+    diff = Diff(files=[f], raw="raw")
+    assert tools.find_diff_file(diff, "old.py") is f
+
+
+def test_find_diff_file_not_found_returns_none() -> None:
+    diff = Diff(files=[make_dummy_file()], raw="raw")
+    assert tools.find_diff_file(diff, "not_exist.py") is None
+
+
+# ---------- read_snapshot ----------
+
+def test_read_snapshot_prefers_git(monkeypatch: pytest.MonkeyPatch, fake_git: FakeGitService) -> None:
+    fake_git.responses["get_file_at_commit"] = "from git"
+    monkeypatch.setattr(tools, "GitService", lambda: fake_git)
+
+    assert tools.read_snapshot("foo.py", head_sha="HEAD") == "from git"
+
+
+def test_read_snapshot_fallback_to_filesystem(
+        tmp_path: Path,
+        fake_git: FakeGitService,
+        monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    file = tmp_path / "file.txt"
+    file.write_text("hello")
+
+    fake_git.responses["get_file_at_commit"] = None
+    monkeypatch.setattr(tools, "GitService", lambda: fake_git)
+
+    result = tools.read_snapshot(str(file))
+    assert result == "hello"
+
+
+def test_read_snapshot_returns_none_if_missing(
+        tmp_path: Path,
+        fake_git: FakeGitService,
+        monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    fake_git.responses["get_file_at_commit"] = None
+    monkeypatch.setattr(tools, "GitService", lambda: fake_git)
+
+    assert tools.read_snapshot(str(tmp_path / "nope.txt")) is None
+
+
+# ---------- marker_for_line ----------
+
+def test_marker_for_line_added(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.setattr(tools.settings.review, "review_added_marker", "# A")
+    assert "# A" in tools.marker_for_line(DiffLineType.ADDED)
+    assert "# A" in tools.marker_for_line(added=True)
+
+
+def test_marker_for_line_removed(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.setattr(tools.settings.review, "review_removed_marker", "# R")
+    assert "# R" in tools.marker_for_line(DiffLineType.REMOVED)
+    assert "# R" in tools.marker_for_line(removed=True)
+
+
+def test_marker_for_line_empty(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.setattr(tools.settings.review, "review_added_marker", "# A")
+    monkeypatch.setattr(tools.settings.review, "review_removed_marker", "# R")
+    assert tools.marker_for_line() == ""

ai_review/tests/suites/services/prompt/test_schema.py

@@ -0,0 +1,38 @@
+from ai_review.services.prompt.schema import PromptContextSchema
+
+
+def test_apply_format_inserts_variables() -> None:
+    context = PromptContextSchema(
+        merge_request_title="My MR",
+        merge_request_author_username="nikita"
+    )
+    template = "Title: {merge_request_title}, Author: @{merge_request_author_username}"
+    result = context.apply_format(template)
+    assert result == "Title: My MR, Author: @nikita"
+
+
+def test_apply_format_with_lists() -> None:
+    context = PromptContextSchema(
+        merge_request_reviewers=["Alice", "Bob"],
+        merge_request_reviewers_usernames=["alice", "bob"],
+        labels=["bug", "feature"],
+        changed_files=["a.py", "b.py"],
+    )
+    template = (
+        "Reviewers: {merge_request_reviewers}\n"
+        "Usernames: {merge_request_reviewers_usernames}\n"
+        "Labels: {labels}\n"
+        "Files: {changed_files}"
+    )
+    result = context.apply_format(template)
+    assert "Alice, Bob" in result
+    assert "alice, bob" in result
+    assert "bug, feature" in result
+    assert "a.py, b.py" in result
+
+
+def test_apply_format_handles_missing_fields() -> None:
+    context = PromptContextSchema()
+    template = "Title: {merge_request_title}, Reviewer: {merge_request_reviewer}"
+    result = context.apply_format(template)
+    assert result == "Title: , Reviewer: "

ai_review/tests/suites/services/prompt/test_service.py

@@ -0,0 +1,128 @@
+import pytest
+
+from ai_review.libs.config.prompt import PromptConfig
+from ai_review.services.diff.schema import DiffFileSchema
+from ai_review.services.prompt.schema import PromptContextSchema
+from ai_review.services.prompt.service import PromptService
+
+
+@pytest.fixture(autouse=True)
+def patch_prompts(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Patch methods of settings.prompt to return dummy values."""
+    monkeypatch.setattr(PromptConfig, "load_inline", lambda self: ["GLOBAL_INLINE", "INLINE_PROMPT"])
+    monkeypatch.setattr(PromptConfig, "load_context", lambda self: ["GLOBAL_CONTEXT", "CONTEXT_PROMPT"])
+    monkeypatch.setattr(PromptConfig, "load_summary", lambda self: ["GLOBAL_SUMMARY", "SUMMARY_PROMPT"])
+    monkeypatch.setattr(PromptConfig, "load_system_inline", lambda self: ["SYS_INLINE_A", "SYS_INLINE_B"])
+    monkeypatch.setattr(PromptConfig, "load_system_context", lambda self: ["SYS_CONTEXT_A", "SYS_CONTEXT_B"])
+    monkeypatch.setattr(PromptConfig, "load_system_summary", lambda self: ["SYS_SUMMARY_A", "SYS_SUMMARY_B"])
+
+
+@pytest.fixture
+def dummy_context() -> PromptContextSchema:
+    return PromptContextSchema(
+        merge_request_title="Fix login bug",
+        merge_request_description="Some description",
+        merge_request_author_name="Nikita",
+        merge_request_author_username="nikita.filonov",
+        merge_request_reviewers=["Alice", "Bob"],
+        merge_request_reviewers_usernames=["alice", "bob"],
+        merge_request_assignees=["Charlie"],
+        merge_request_assignees_usernames=["charlie"],
+        source_branch="feature/login-fix",
+        target_branch="main",
+        labels=["bug", "critical"],
+        changed_files=["foo.py", "bar.py"],
+    )
+
+
+def test_build_inline_request_includes_prompts_and_diff(dummy_context: PromptContextSchema) -> None:
+    diff = DiffFileSchema(file="foo.py", diff="+ added line\n- removed line")
+    result = PromptService.build_inline_request(diff, dummy_context)
+
+    assert "GLOBAL_INLINE" in result
+    assert "INLINE_PROMPT" in result
+    assert "# File: foo.py" in result
+    assert "+ added line" in result
+    assert "- removed line" in result
+
+
+def test_build_summary_request_includes_prompts_and_diffs(dummy_context: PromptContextSchema) -> None:
+    diffs = [
+        DiffFileSchema(file="a.py", diff="+ foo"),
+        DiffFileSchema(file="b.py", diff="- bar"),
+    ]
+    result = PromptService.build_summary_request(diffs, dummy_context)
+
+    assert "GLOBAL_SUMMARY" in result
+    assert "SUMMARY_PROMPT" in result
+    assert "# File: a.py" in result
+    assert "# File: b.py" in result
+    assert "+ foo" in result
+    assert "- bar" in result
+
+
+def test_build_summary_request_empty_list(dummy_context: PromptContextSchema) -> None:
+    """Empty diffs list should still produce valid prompt with no diff content."""
+    result = PromptService.build_summary_request([], dummy_context)
+
+    assert "GLOBAL_SUMMARY" in result
+    assert "SUMMARY_PROMPT" in result
+    assert "## Changes" in result
+    assert result.strip().endswith("## Changes")
+
+
+def test_build_context_request_includes_prompts_and_diffs(dummy_context: PromptContextSchema) -> None:
+    diffs = [
+        DiffFileSchema(file="a.py", diff="+ foo"),
+        DiffFileSchema(file="b.py", diff="- bar"),
+    ]
+    result = PromptService.build_context_request(diffs, dummy_context)
+
+    assert "GLOBAL_CONTEXT" in result
+    assert "CONTEXT_PROMPT" in result
+    assert "# File: a.py" in result
+    assert "# File: b.py" in result
+    assert "+ foo" in result
+    assert "- bar" in result
+
+
+def test_build_system_inline_request_returns_joined_prompts(dummy_context: PromptContextSchema) -> None:
+    result = PromptService.build_system_inline_request(dummy_context)
+    assert result == "SYS_INLINE_A\n\nSYS_INLINE_B".replace("SYS_INLINE_A", "SYS_INLINE_A")
+
+
+def test_build_system_context_request_returns_joined_prompts(dummy_context: PromptContextSchema) -> None:
+    result = PromptService.build_system_context_request(dummy_context)
+    assert result == "SYS_CONTEXT_A\n\nSYS_CONTEXT_B"
+
+
+def test_build_system_summary_request_returns_joined_prompts(dummy_context: PromptContextSchema) -> None:
+    result = PromptService.build_system_summary_request(dummy_context)
+    assert result == "SYS_SUMMARY_A\n\nSYS_SUMMARY_B"
+
+
+def test_build_system_inline_request_empty(
+        monkeypatch: pytest.MonkeyPatch,
+        dummy_context: PromptContextSchema
+) -> None:
+    monkeypatch.setattr(PromptConfig, "load_system_inline", lambda self: [])
+    result = PromptService.build_system_inline_request(dummy_context)
+    assert result == ""
+
+
+def test_build_system_context_request_empty(
+        monkeypatch: pytest.MonkeyPatch,
+        dummy_context: PromptContextSchema
+) -> None:
+    monkeypatch.setattr(PromptConfig, "load_system_context", lambda self: [])
+    result = PromptService.build_system_context_request(dummy_context)
+    assert result == ""
+
+
+def test_build_system_summary_request_empty(
+        monkeypatch: pytest.MonkeyPatch,
+        dummy_context: PromptContextSchema
+) -> None:
+    monkeypatch.setattr(PromptConfig, "load_system_summary", lambda self: [])
+    result = PromptService.build_system_summary_request(dummy_context)
+    assert result == ""

ai_review/tests/suites/services/review/inline/test_schema.py

@@ -0,0 +1,65 @@
+from ai_review.config import settings
+from ai_review.services.review.inline.schema import (
+    InlineCommentSchema,
+    InlineCommentListSchema,
+)
+
+
+def test_normalize_file_and_message():
+    comment = InlineCommentSchema(file=" \\src\\main.py ", line=10, message="  fix bug  ")
+    assert comment.file == "src/main.py"  # нормализуется и слеши, и пробелы
+    assert comment.message == "fix bug"  # пробелы убраны
+
+
+def test_body_without_suggestion():
+    comment = InlineCommentSchema(file="a.py", line=1, message="use f-string")
+    assert comment.body == "use f-string"
+    assert settings.review.inline_tag not in comment.body  # тег ещё не добавлен
+
+
+def test_body_with_suggestion():
+    comment = InlineCommentSchema(
+        file="a.py",
+        line=2,
+        message="replace concatenation with f-string",
+        suggestion='print(f"Hello {name}")',
+    )
+    expected = (
+        "replace concatenation with f-string\n\n"
+        "```suggestion\nprint(f\"Hello {name}\")\n```"
+    )
+    assert comment.body == expected
+
+
+def test_body_with_tag(monkeypatch):
+    monkeypatch.setattr(settings.review, "inline_tag", "#ai-inline")
+    comment = InlineCommentSchema(file="a.py", line=3, message="something")
+    assert comment.body_with_tag.endswith("\n\n#ai-inline")
+
+
+def test_fallback_body_with_tag(monkeypatch):
+    monkeypatch.setattr(settings.review, "inline_tag", "#ai-inline")
+    comment = InlineCommentSchema(file="a.py", line=42, message="missing check")
+    body = comment.fallback_body_with_tag
+    assert body.startswith("**a.py:42** — missing check")
+    assert "#ai-inline" in body
+
+
+def test_dedup_key_differs_on_message_and_suggestion():
+    c1 = InlineCommentSchema(file="a.py", line=1, message="msg one")
+    c2 = InlineCommentSchema(file="a.py", line=1, message="msg one", suggestion="x = 1")
+    assert c1.dedup_key != c2.dedup_key
+
+
+def test_list_dedupe_removes_duplicates():
+    c1 = InlineCommentSchema(file="a.py", line=1, message="msg one")
+    c2 = InlineCommentSchema(file="a.py", line=1, message="msg one")  # дубликат
+    c3 = InlineCommentSchema(file="a.py", line=2, message="msg two")
+
+    comment_list = InlineCommentListSchema(root=[c1, c2, c3])
+    comment_list = comment_list.dedupe()
+
+    assert len(comment_list.root) == 2
+    dedup_messages = [c.message for c in comment_list.root]
+    assert "msg one" in dedup_messages
+    assert "msg two" in dedup_messages

ai_review/tests/suites/services/review/inline/test_service.py

@@ -0,0 +1,49 @@
+from ai_review.services.review.inline.schema import InlineCommentListSchema
+from ai_review.services.review.inline.service import InlineCommentService
+
+
+def test_empty_output_returns_empty_list():
+    result = InlineCommentService.parse_model_output("")
+    assert isinstance(result, InlineCommentListSchema)
+    assert result.root == []
+
+
+def test_valid_json_array_parsed():
+    json_output = '[{"file": "a.py", "line": 1, "message": "use f-string"}]'
+    result = InlineCommentService.parse_model_output(json_output)
+    assert len(result.root) == 1
+    assert result.root[0].file == "a.py"
+    assert result.root[0].line == 1
+    assert result.root[0].message == "use f-string"
+
+
+def test_json_inside_code_block_parsed():
+    output = """```json
+    [
+      {"file": "b.py", "line": 42, "message": "check for None"}
+    ]
+    ```"""
+    result = InlineCommentService.parse_model_output(output)
+    assert len(result.root) == 1
+    assert result.root[0].file == "b.py"
+    assert result.root[0].line == 42
+
+
+def test_non_json_but_array_inside_text():
+    output = "some explanation...\n[ {\"file\": \"c.py\", \"line\": 7, \"message\": \"fix this\"} ]\nend"
+    result = InlineCommentService.parse_model_output(output)
+    assert len(result.root) == 1
+    assert result.root[0].file == "c.py"
+    assert result.root[0].line == 7
+
+
+def test_invalid_json_array_logs_and_returns_empty():
+    output = '[{"file": "d.py", "line": "oops", "message": "bad"}]'
+    result = InlineCommentService.parse_model_output(output)
+    assert result.root == []
+
+
+def test_no_json_array_found_logs_and_returns_empty():
+    output = "this is not json at all"
+    result = InlineCommentService.parse_model_output(output)
+    assert result.root == []