xai-review 0.29.0__py3-none-any.whl → 0.30.0__py3-none-any.whl
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Potentially problematic release.
This version of xai-review might be problematic. Click here for more details.
- ai_review/libs/config/review.py +1 -0
- ai_review/services/review/gateway/review_dry_run_comment_gateway.py +42 -0
- ai_review/services/review/service.py +9 -3
- ai_review/tests/fixtures/services/review/gateway/{comment.py → review_comment_gateway.py} +1 -1
- ai_review/tests/fixtures/services/review/gateway/review_dry_run_comment_gateway.py +103 -0
- ai_review/tests/fixtures/services/review/gateway/review_llm_gateway.py +34 -0
- ai_review/tests/suites/services/review/gateway/{test_comment.py → test_review_comment_gateway.py} +1 -1
- ai_review/tests/suites/services/review/gateway/test_review_dry_run_comment_gateway.py +93 -0
- ai_review/tests/suites/services/review/gateway/{test_llm.py → test_review_llm_gateway.py} +1 -15
- ai_review/tests/suites/services/review/runner/test_context.py +2 -2
- ai_review/tests/suites/services/review/runner/test_inline.py +2 -2
- ai_review/tests/suites/services/review/runner/test_inline_reply.py +2 -2
- ai_review/tests/suites/services/review/runner/test_summary.py +2 -2
- ai_review/tests/suites/services/review/runner/test_summary_reply.py +2 -2
- ai_review/tests/suites/services/review/test_service.py +18 -0
- {xai_review-0.29.0.dist-info → xai_review-0.30.0.dist-info}/METADATA +2 -2
- {xai_review-0.29.0.dist-info → xai_review-0.30.0.dist-info}/RECORD +23 -20
- ai_review/tests/fixtures/services/review/gateway/llm.py +0 -17
- /ai_review/services/review/gateway/{comment.py → review_comment_gateway.py} +0 -0
- /ai_review/services/review/gateway/{llm.py → review_llm_gateway.py} +0 -0
- {xai_review-0.29.0.dist-info → xai_review-0.30.0.dist-info}/WHEEL +0 -0
- {xai_review-0.29.0.dist-info → xai_review-0.30.0.dist-info}/entry_points.txt +0 -0
- {xai_review-0.29.0.dist-info → xai_review-0.30.0.dist-info}/licenses/LICENSE +0 -0
- {xai_review-0.29.0.dist-info → xai_review-0.30.0.dist-info}/top_level.txt +0 -0
ai_review/libs/config/review.py
CHANGED
|
@@ -19,6 +19,7 @@ class ReviewMode(StrEnum):
|
|
|
19
19
|
|
|
20
20
|
class ReviewConfig(BaseModel):
|
|
21
21
|
mode: ReviewMode = ReviewMode.FULL_FILE_DIFF
|
|
22
|
+
dry_run: bool = False
|
|
22
23
|
inline_tag: str = Field(default="#ai-review-inline")
|
|
23
24
|
inline_reply_tag: str = Field(default="#ai-review-inline-reply")
|
|
24
25
|
summary_tag: str = Field(default="#ai-review-summary")
|
|
@@ -0,0 +1,42 @@
|
|
|
1
|
+
from ai_review.libs.asynchronous.gather import bounded_gather
|
|
2
|
+
from ai_review.libs.logger import get_logger
|
|
3
|
+
from ai_review.services.hook import hook
|
|
4
|
+
from ai_review.services.review.gateway.review_comment_gateway import ReviewCommentGateway
|
|
5
|
+
from ai_review.services.review.internal.inline.schema import InlineCommentListSchema, InlineCommentSchema
|
|
6
|
+
from ai_review.services.review.internal.inline_reply.schema import InlineCommentReplySchema
|
|
7
|
+
from ai_review.services.review.internal.summary.schema import SummaryCommentSchema
|
|
8
|
+
from ai_review.services.review.internal.summary_reply.schema import SummaryCommentReplySchema
|
|
9
|
+
from ai_review.services.vcs.types import VCSClientProtocol
|
|
10
|
+
|
|
11
|
+
logger = get_logger("REVIEW_DRY_RUN_COMMENT_GATEWAY")
|
|
12
|
+
|
|
13
|
+
|
|
14
|
+
class ReviewDryRunCommentGateway(ReviewCommentGateway):
|
|
15
|
+
def __init__(self, vcs: VCSClientProtocol):
|
|
16
|
+
super().__init__(vcs)
|
|
17
|
+
logger.warning("Running in DRY RUN mode — no comments will be posted to VCS")
|
|
18
|
+
|
|
19
|
+
async def process_inline_reply(self, thread_id: str, reply: InlineCommentReplySchema) -> None:
|
|
20
|
+
await hook.emit_inline_comment_reply_start(reply)
|
|
21
|
+
logger.info(f"[dry-run] Would create inline reply for thread {thread_id}:\n{reply.body_with_tag}")
|
|
22
|
+
await hook.emit_inline_comment_reply_complete(reply)
|
|
23
|
+
|
|
24
|
+
async def process_summary_reply(self, thread_id: str, reply: SummaryCommentReplySchema) -> None:
|
|
25
|
+
await hook.emit_summary_comment_reply_start(reply)
|
|
26
|
+
logger.info(f"[dry-run] Would create summary reply for thread {thread_id}:\n{reply.body_with_tag}")
|
|
27
|
+
await hook.emit_summary_comment_reply_complete(reply)
|
|
28
|
+
|
|
29
|
+
async def process_inline_comment(self, comment: InlineCommentSchema) -> None:
|
|
30
|
+
await hook.emit_inline_comment_start(comment)
|
|
31
|
+
logger.info(
|
|
32
|
+
f"[dry-run] Would create inline comment for {comment.file}:{comment.line}:\n{comment.body_with_tag}"
|
|
33
|
+
)
|
|
34
|
+
await hook.emit_inline_comment_complete(comment)
|
|
35
|
+
|
|
36
|
+
async def process_summary_comment(self, comment: SummaryCommentSchema) -> None:
|
|
37
|
+
await hook.emit_summary_comment_start(comment)
|
|
38
|
+
logger.info(f"[dry-run] Would create summary comment:\n{comment.body_with_tag}")
|
|
39
|
+
await hook.emit_summary_comment_complete(comment)
|
|
40
|
+
|
|
41
|
+
async def process_inline_comments(self, comments: InlineCommentListSchema) -> None:
|
|
42
|
+
await bounded_gather([self.process_inline_comment(comment) for comment in comments.root])
|
|
@@ -1,3 +1,4 @@
|
|
|
1
|
+
from ai_review.config import settings
|
|
1
2
|
from ai_review.libs.logger import get_logger
|
|
2
3
|
from ai_review.services.artifacts.service import ArtifactsService
|
|
3
4
|
from ai_review.services.cost.service import CostService
|
|
@@ -5,8 +6,9 @@ from ai_review.services.diff.service import DiffService
|
|
|
5
6
|
from ai_review.services.git.service import GitService
|
|
6
7
|
from ai_review.services.llm.factory import get_llm_client
|
|
7
8
|
from ai_review.services.prompt.service import PromptService
|
|
8
|
-
from ai_review.services.review.gateway.
|
|
9
|
-
from ai_review.services.review.gateway.
|
|
9
|
+
from ai_review.services.review.gateway.review_comment_gateway import ReviewCommentGateway
|
|
10
|
+
from ai_review.services.review.gateway.review_dry_run_comment_gateway import ReviewDryRunCommentGateway
|
|
11
|
+
from ai_review.services.review.gateway.review_llm_gateway import ReviewLLMGateway
|
|
10
12
|
from ai_review.services.review.internal.inline.service import InlineCommentService
|
|
11
13
|
from ai_review.services.review.internal.inline_reply.service import InlineCommentReplyService
|
|
12
14
|
from ai_review.services.review.internal.policy.service import ReviewPolicyService
|
|
@@ -42,7 +44,11 @@ class ReviewService:
|
|
|
42
44
|
cost=self.cost,
|
|
43
45
|
artifacts=self.artifacts
|
|
44
46
|
)
|
|
45
|
-
self.review_comment_gateway =
|
|
47
|
+
self.review_comment_gateway = (
|
|
48
|
+
ReviewDryRunCommentGateway(vcs=self.vcs)
|
|
49
|
+
if settings.review.dry_run
|
|
50
|
+
else ReviewCommentGateway(vcs=self.vcs)
|
|
51
|
+
)
|
|
46
52
|
|
|
47
53
|
self.inline_review_runner = InlineReviewRunner(
|
|
48
54
|
vcs=self.vcs,
|
|
@@ -2,7 +2,7 @@ from typing import Any
|
|
|
2
2
|
|
|
3
3
|
import pytest
|
|
4
4
|
|
|
5
|
-
from ai_review.services.review.gateway.
|
|
5
|
+
from ai_review.services.review.gateway.review_comment_gateway import ReviewCommentGateway
|
|
6
6
|
from ai_review.services.review.gateway.types import ReviewCommentGatewayProtocol
|
|
7
7
|
from ai_review.services.review.internal.inline.schema import InlineCommentSchema, InlineCommentListSchema
|
|
8
8
|
from ai_review.services.review.internal.inline_reply.schema import InlineCommentReplySchema
|
|
@@ -0,0 +1,103 @@
|
|
|
1
|
+
from typing import Any
|
|
2
|
+
|
|
3
|
+
import pytest
|
|
4
|
+
|
|
5
|
+
from ai_review.services.review.gateway.review_dry_run_comment_gateway import ReviewDryRunCommentGateway
|
|
6
|
+
from ai_review.services.review.gateway.types import ReviewCommentGatewayProtocol
|
|
7
|
+
from ai_review.services.review.internal.inline.schema import InlineCommentSchema, InlineCommentListSchema
|
|
8
|
+
from ai_review.services.review.internal.inline_reply.schema import InlineCommentReplySchema
|
|
9
|
+
from ai_review.services.review.internal.summary.schema import SummaryCommentSchema
|
|
10
|
+
from ai_review.services.review.internal.summary_reply.schema import SummaryCommentReplySchema
|
|
11
|
+
from ai_review.services.vcs.types import (
|
|
12
|
+
UserSchema,
|
|
13
|
+
ThreadKind,
|
|
14
|
+
ReviewThreadSchema,
|
|
15
|
+
ReviewCommentSchema,
|
|
16
|
+
VCSClientProtocol,
|
|
17
|
+
)
|
|
18
|
+
|
|
19
|
+
|
|
20
|
+
class FakeReviewDryRunCommentGateway(ReviewCommentGatewayProtocol):
|
|
21
|
+
def __init__(self, responses: dict[str, Any] | None = None):
|
|
22
|
+
self.calls: list[tuple[str, dict]] = []
|
|
23
|
+
|
|
24
|
+
fake_user = UserSchema(id="u1", username="tester", name="Tester")
|
|
25
|
+
|
|
26
|
+
fake_inline_thread = ReviewThreadSchema(
|
|
27
|
+
id="t1",
|
|
28
|
+
kind=ThreadKind.INLINE,
|
|
29
|
+
file="file.py",
|
|
30
|
+
line=10,
|
|
31
|
+
comments=[
|
|
32
|
+
ReviewCommentSchema(
|
|
33
|
+
id="c1",
|
|
34
|
+
body="#ai-review-inline some comment",
|
|
35
|
+
file="file.py",
|
|
36
|
+
line=10,
|
|
37
|
+
author=fake_user,
|
|
38
|
+
),
|
|
39
|
+
],
|
|
40
|
+
)
|
|
41
|
+
|
|
42
|
+
fake_summary_thread = ReviewThreadSchema(
|
|
43
|
+
id="t2",
|
|
44
|
+
kind=ThreadKind.SUMMARY,
|
|
45
|
+
comments=[
|
|
46
|
+
ReviewCommentSchema(
|
|
47
|
+
id="c2",
|
|
48
|
+
body="#ai-review-summary summary comment",
|
|
49
|
+
author=fake_user,
|
|
50
|
+
),
|
|
51
|
+
],
|
|
52
|
+
)
|
|
53
|
+
|
|
54
|
+
self.responses = responses or {
|
|
55
|
+
"get_inline_threads": [fake_inline_thread],
|
|
56
|
+
"get_summary_threads": [fake_summary_thread],
|
|
57
|
+
"has_existing_inline_comments": False,
|
|
58
|
+
"has_existing_summary_comments": False,
|
|
59
|
+
}
|
|
60
|
+
|
|
61
|
+
# --- Методы чтения ---
|
|
62
|
+
async def get_inline_threads(self) -> list[ReviewThreadSchema]:
|
|
63
|
+
self.calls.append(("get_inline_threads", {}))
|
|
64
|
+
return self.responses["get_inline_threads"]
|
|
65
|
+
|
|
66
|
+
async def get_summary_threads(self) -> list[ReviewThreadSchema]:
|
|
67
|
+
self.calls.append(("get_summary_threads", {}))
|
|
68
|
+
return self.responses["get_summary_threads"]
|
|
69
|
+
|
|
70
|
+
async def has_existing_inline_comments(self) -> bool:
|
|
71
|
+
self.calls.append(("has_existing_inline_comments", {}))
|
|
72
|
+
return self.responses["has_existing_inline_comments"]
|
|
73
|
+
|
|
74
|
+
async def has_existing_summary_comments(self) -> bool:
|
|
75
|
+
self.calls.append(("has_existing_summary_comments", {}))
|
|
76
|
+
return self.responses["has_existing_summary_comments"]
|
|
77
|
+
|
|
78
|
+
async def process_inline_reply(self, thread_id: str, reply: InlineCommentReplySchema) -> None:
|
|
79
|
+
self.calls.append(("process_inline_reply", {"thread_id": thread_id, "reply": reply}))
|
|
80
|
+
|
|
81
|
+
async def process_summary_reply(self, thread_id: str, reply: SummaryCommentReplySchema) -> None:
|
|
82
|
+
self.calls.append(("process_summary_reply", {"thread_id": thread_id, "reply": reply}))
|
|
83
|
+
|
|
84
|
+
async def process_inline_comment(self, comment: InlineCommentSchema) -> None:
|
|
85
|
+
self.calls.append(("process_inline_comment", {"comment": comment}))
|
|
86
|
+
|
|
87
|
+
async def process_summary_comment(self, comment: SummaryCommentSchema) -> None:
|
|
88
|
+
self.calls.append(("process_summary_comment", {"comment": comment}))
|
|
89
|
+
|
|
90
|
+
async def process_inline_comments(self, comments: InlineCommentListSchema) -> None:
|
|
91
|
+
self.calls.append(("process_inline_comments", {"comments": comments}))
|
|
92
|
+
for comment in comments.root:
|
|
93
|
+
await self.process_inline_comment(comment)
|
|
94
|
+
|
|
95
|
+
|
|
96
|
+
@pytest.fixture
|
|
97
|
+
def fake_review_dry_run_comment_gateway() -> FakeReviewDryRunCommentGateway:
|
|
98
|
+
return FakeReviewDryRunCommentGateway()
|
|
99
|
+
|
|
100
|
+
|
|
101
|
+
@pytest.fixture
|
|
102
|
+
def review_dry_run_comment_gateway(fake_vcs_client: VCSClientProtocol) -> ReviewDryRunCommentGateway:
|
|
103
|
+
return ReviewDryRunCommentGateway(vcs=fake_vcs_client)
|
|
@@ -0,0 +1,34 @@
|
|
|
1
|
+
import pytest
|
|
2
|
+
|
|
3
|
+
from ai_review.services.review.gateway.review_llm_gateway import ReviewLLMGateway
|
|
4
|
+
from ai_review.services.review.gateway.types import ReviewLLMGatewayProtocol
|
|
5
|
+
from ai_review.tests.fixtures.services.artifacts import FakeArtifactsService
|
|
6
|
+
from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
7
|
+
from ai_review.tests.fixtures.services.llm import FakeLLMClient
|
|
8
|
+
|
|
9
|
+
|
|
10
|
+
class FakeReviewLLMGateway(ReviewLLMGatewayProtocol):
|
|
11
|
+
def __init__(self):
|
|
12
|
+
self.calls: list[tuple[str, dict]] = []
|
|
13
|
+
|
|
14
|
+
async def ask(self, prompt: str, prompt_system: str) -> str:
|
|
15
|
+
self.calls.append(("ask", {"prompt": prompt, "prompt_system": prompt_system}))
|
|
16
|
+
return "FAKE_LLM_RESPONSE"
|
|
17
|
+
|
|
18
|
+
|
|
19
|
+
@pytest.fixture
|
|
20
|
+
def fake_review_llm_gateway() -> FakeReviewLLMGateway:
|
|
21
|
+
return FakeReviewLLMGateway()
|
|
22
|
+
|
|
23
|
+
|
|
24
|
+
@pytest.fixture
|
|
25
|
+
def review_llm_gateway(
|
|
26
|
+
fake_llm_client: FakeLLMClient,
|
|
27
|
+
fake_cost_service: FakeCostService,
|
|
28
|
+
fake_artifacts_service: FakeArtifactsService,
|
|
29
|
+
) -> ReviewLLMGateway:
|
|
30
|
+
return ReviewLLMGateway(
|
|
31
|
+
llm=fake_llm_client,
|
|
32
|
+
cost=fake_cost_service,
|
|
33
|
+
artifacts=fake_artifacts_service,
|
|
34
|
+
)
|
ai_review/tests/suites/services/review/gateway/{test_comment.py → test_review_comment_gateway.py}
RENAMED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
import pytest
|
|
2
2
|
|
|
3
3
|
from ai_review.config import settings
|
|
4
|
-
from ai_review.services.review.gateway.
|
|
4
|
+
from ai_review.services.review.gateway.review_comment_gateway import ReviewCommentGateway
|
|
5
5
|
from ai_review.services.review.internal.inline.schema import InlineCommentSchema, InlineCommentListSchema
|
|
6
6
|
from ai_review.services.review.internal.inline_reply.schema import InlineCommentReplySchema
|
|
7
7
|
from ai_review.services.review.internal.summary.schema import SummaryCommentSchema
|
|
@@ -0,0 +1,93 @@
|
|
|
1
|
+
import pytest
|
|
2
|
+
|
|
3
|
+
from ai_review.services.review.gateway.review_dry_run_comment_gateway import ReviewDryRunCommentGateway
|
|
4
|
+
from ai_review.services.review.internal.inline.schema import InlineCommentSchema, InlineCommentListSchema
|
|
5
|
+
from ai_review.services.review.internal.inline_reply.schema import InlineCommentReplySchema
|
|
6
|
+
from ai_review.services.review.internal.summary.schema import SummaryCommentSchema
|
|
7
|
+
from ai_review.services.review.internal.summary_reply.schema import SummaryCommentReplySchema
|
|
8
|
+
from ai_review.tests.fixtures.services.vcs import FakeVCSClient
|
|
9
|
+
|
|
10
|
+
|
|
11
|
+
@pytest.mark.asyncio
|
|
12
|
+
async def test_process_inline_reply_dry_run_logs_and_no_vcs_calls(
|
|
13
|
+
capsys,
|
|
14
|
+
fake_vcs_client: FakeVCSClient,
|
|
15
|
+
review_dry_run_comment_gateway: ReviewDryRunCommentGateway
|
|
16
|
+
):
|
|
17
|
+
"""Dry-run: should log the inline reply but not call VCS."""
|
|
18
|
+
reply = InlineCommentReplySchema(message="AI reply dry-run")
|
|
19
|
+
await review_dry_run_comment_gateway.process_inline_reply("t1", reply)
|
|
20
|
+
output = capsys.readouterr().out
|
|
21
|
+
|
|
22
|
+
assert "[dry-run]" in output
|
|
23
|
+
assert "Would create inline reply" in output
|
|
24
|
+
assert not any(call[0].startswith("create_") for call in fake_vcs_client.calls)
|
|
25
|
+
|
|
26
|
+
|
|
27
|
+
@pytest.mark.asyncio
|
|
28
|
+
async def test_process_summary_reply_dry_run_logs_and_no_vcs_calls(
|
|
29
|
+
capsys,
|
|
30
|
+
fake_vcs_client: FakeVCSClient,
|
|
31
|
+
review_dry_run_comment_gateway: ReviewDryRunCommentGateway
|
|
32
|
+
):
|
|
33
|
+
"""Dry-run: should log the summary reply but not call VCS."""
|
|
34
|
+
reply = SummaryCommentReplySchema(text="Dry-run summary reply")
|
|
35
|
+
await review_dry_run_comment_gateway.process_summary_reply("t2", reply)
|
|
36
|
+
output = capsys.readouterr().out
|
|
37
|
+
|
|
38
|
+
assert "[dry-run]" in output
|
|
39
|
+
assert "Would create summary reply" in output
|
|
40
|
+
assert not any(call[0].startswith("create_") for call in fake_vcs_client.calls)
|
|
41
|
+
|
|
42
|
+
|
|
43
|
+
@pytest.mark.asyncio
|
|
44
|
+
async def test_process_inline_comment_dry_run_logs_and_no_vcs_calls(
|
|
45
|
+
capsys,
|
|
46
|
+
fake_vcs_client: FakeVCSClient,
|
|
47
|
+
review_dry_run_comment_gateway: ReviewDryRunCommentGateway
|
|
48
|
+
):
|
|
49
|
+
"""Dry-run: should log inline comment without creating one."""
|
|
50
|
+
comment = InlineCommentSchema(file="a.py", line=10, message="Test comment")
|
|
51
|
+
await review_dry_run_comment_gateway.process_inline_comment(comment)
|
|
52
|
+
output = capsys.readouterr().out
|
|
53
|
+
|
|
54
|
+
assert "[dry-run]" in output
|
|
55
|
+
assert "Would create inline comment" in output
|
|
56
|
+
assert "a.py" in output
|
|
57
|
+
assert not any(call[0].startswith("create_") for call in fake_vcs_client.calls)
|
|
58
|
+
|
|
59
|
+
|
|
60
|
+
@pytest.mark.asyncio
|
|
61
|
+
async def test_process_summary_comment_dry_run_logs_and_no_vcs_calls(
|
|
62
|
+
capsys,
|
|
63
|
+
fake_vcs_client: FakeVCSClient,
|
|
64
|
+
review_dry_run_comment_gateway: ReviewDryRunCommentGateway
|
|
65
|
+
):
|
|
66
|
+
"""Dry-run: should log summary comment but not send it."""
|
|
67
|
+
comment = SummaryCommentSchema(text="Dry-run summary comment")
|
|
68
|
+
await review_dry_run_comment_gateway.process_summary_comment(comment)
|
|
69
|
+
output = capsys.readouterr().out
|
|
70
|
+
|
|
71
|
+
assert "[dry-run]" in output
|
|
72
|
+
assert "Would create summary comment" in output
|
|
73
|
+
assert not any(call[0].startswith("create_") for call in fake_vcs_client.calls)
|
|
74
|
+
|
|
75
|
+
|
|
76
|
+
@pytest.mark.asyncio
|
|
77
|
+
async def test_process_inline_comments_iterates_all(
|
|
78
|
+
capsys,
|
|
79
|
+
fake_vcs_client: FakeVCSClient,
|
|
80
|
+
review_dry_run_comment_gateway: ReviewDryRunCommentGateway
|
|
81
|
+
):
|
|
82
|
+
"""Dry-run: should iterate through all inline comments and log each."""
|
|
83
|
+
comments = InlineCommentListSchema(root=[
|
|
84
|
+
InlineCommentSchema(file="a.py", line=1, message="C1"),
|
|
85
|
+
InlineCommentSchema(file="b.py", line=2, message="C2"),
|
|
86
|
+
])
|
|
87
|
+
await review_dry_run_comment_gateway.process_inline_comments(comments)
|
|
88
|
+
output = capsys.readouterr().out
|
|
89
|
+
|
|
90
|
+
assert "[dry-run]" in output
|
|
91
|
+
assert "a.py" in output
|
|
92
|
+
assert "b.py" in output
|
|
93
|
+
assert not any(call[0].startswith("create_") for call in fake_vcs_client.calls)
|
|
@@ -1,26 +1,12 @@
|
|
|
1
1
|
import pytest
|
|
2
2
|
|
|
3
3
|
from ai_review.services.llm.types import ChatResultSchema
|
|
4
|
-
from ai_review.services.review.gateway.
|
|
4
|
+
from ai_review.services.review.gateway.review_llm_gateway import ReviewLLMGateway
|
|
5
5
|
from ai_review.tests.fixtures.services.artifacts import FakeArtifactsService
|
|
6
6
|
from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
7
7
|
from ai_review.tests.fixtures.services.llm import FakeLLMClient
|
|
8
8
|
|
|
9
9
|
|
|
10
|
-
@pytest.fixture
|
|
11
|
-
def review_llm_gateway(
|
|
12
|
-
fake_llm_client: FakeLLMClient,
|
|
13
|
-
fake_cost_service: FakeCostService,
|
|
14
|
-
fake_artifacts_service: FakeArtifactsService,
|
|
15
|
-
) -> ReviewLLMGateway:
|
|
16
|
-
"""Fixture providing ReviewLLMGateway with fake dependencies."""
|
|
17
|
-
return ReviewLLMGateway(
|
|
18
|
-
llm=fake_llm_client,
|
|
19
|
-
cost=fake_cost_service,
|
|
20
|
-
artifacts=fake_artifacts_service,
|
|
21
|
-
)
|
|
22
|
-
|
|
23
|
-
|
|
24
10
|
@pytest.mark.asyncio
|
|
25
11
|
async def test_ask_happy_path(
|
|
26
12
|
review_llm_gateway: ReviewLLMGateway,
|
|
@@ -4,8 +4,8 @@ from ai_review.services.review.runner.context import ContextReviewRunner
|
|
|
4
4
|
from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
5
5
|
from ai_review.tests.fixtures.services.diff import FakeDiffService
|
|
6
6
|
from ai_review.tests.fixtures.services.prompt import FakePromptService
|
|
7
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
8
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
7
|
+
from ai_review.tests.fixtures.services.review.gateway.review_comment_gateway import FakeReviewCommentGateway
|
|
8
|
+
from ai_review.tests.fixtures.services.review.gateway.review_llm_gateway import FakeReviewLLMGateway
|
|
9
9
|
from ai_review.tests.fixtures.services.review.internal.inline import FakeInlineCommentService
|
|
10
10
|
from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
|
|
11
11
|
from ai_review.tests.fixtures.services.vcs import FakeVCSClient
|
|
@@ -6,8 +6,8 @@ from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
|
6
6
|
from ai_review.tests.fixtures.services.diff import FakeDiffService
|
|
7
7
|
from ai_review.tests.fixtures.services.git import FakeGitService
|
|
8
8
|
from ai_review.tests.fixtures.services.prompt import FakePromptService
|
|
9
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
10
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
9
|
+
from ai_review.tests.fixtures.services.review.gateway.review_comment_gateway import FakeReviewCommentGateway
|
|
10
|
+
from ai_review.tests.fixtures.services.review.gateway.review_llm_gateway import FakeReviewLLMGateway
|
|
11
11
|
from ai_review.tests.fixtures.services.review.internal.inline import FakeInlineCommentService
|
|
12
12
|
from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
|
|
13
13
|
from ai_review.tests.fixtures.services.vcs import FakeVCSClient
|
|
@@ -6,8 +6,8 @@ from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
|
6
6
|
from ai_review.tests.fixtures.services.diff import FakeDiffService
|
|
7
7
|
from ai_review.tests.fixtures.services.git import FakeGitService
|
|
8
8
|
from ai_review.tests.fixtures.services.prompt import FakePromptService
|
|
9
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
10
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
9
|
+
from ai_review.tests.fixtures.services.review.gateway.review_comment_gateway import FakeReviewCommentGateway
|
|
10
|
+
from ai_review.tests.fixtures.services.review.gateway.review_llm_gateway import FakeReviewLLMGateway
|
|
11
11
|
from ai_review.tests.fixtures.services.review.internal.inline_reply import FakeInlineCommentReplyService
|
|
12
12
|
from ai_review.tests.fixtures.services.vcs import FakeVCSClient
|
|
13
13
|
|
|
@@ -5,8 +5,8 @@ from ai_review.services.review.runner.summary import SummaryReviewRunner
|
|
|
5
5
|
from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
6
6
|
from ai_review.tests.fixtures.services.diff import FakeDiffService
|
|
7
7
|
from ai_review.tests.fixtures.services.prompt import FakePromptService
|
|
8
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
9
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
8
|
+
from ai_review.tests.fixtures.services.review.gateway.review_comment_gateway import FakeReviewCommentGateway
|
|
9
|
+
from ai_review.tests.fixtures.services.review.gateway.review_llm_gateway import FakeReviewLLMGateway
|
|
10
10
|
from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
|
|
11
11
|
from ai_review.tests.fixtures.services.review.internal.summary import FakeSummaryCommentService
|
|
12
12
|
from ai_review.tests.fixtures.services.vcs import FakeVCSClient
|
|
@@ -5,8 +5,8 @@ from ai_review.services.vcs.types import ReviewInfoSchema, ReviewThreadSchema, R
|
|
|
5
5
|
from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
6
6
|
from ai_review.tests.fixtures.services.diff import FakeDiffService
|
|
7
7
|
from ai_review.tests.fixtures.services.prompt import FakePromptService
|
|
8
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
9
|
-
from ai_review.tests.fixtures.services.review.gateway.
|
|
8
|
+
from ai_review.tests.fixtures.services.review.gateway.review_comment_gateway import FakeReviewCommentGateway
|
|
9
|
+
from ai_review.tests.fixtures.services.review.gateway.review_llm_gateway import FakeReviewLLMGateway
|
|
10
10
|
from ai_review.tests.fixtures.services.review.internal.policy import FakeReviewPolicyService
|
|
11
11
|
from ai_review.tests.fixtures.services.review.internal.summary_reply import FakeSummaryCommentReplyService
|
|
12
12
|
from ai_review.tests.fixtures.services.vcs import FakeVCSClient
|
|
@@ -1,6 +1,8 @@
|
|
|
1
1
|
import pytest
|
|
2
2
|
|
|
3
3
|
from ai_review.services.llm.types import ChatResultSchema
|
|
4
|
+
from ai_review.services.review.gateway.review_comment_gateway import ReviewCommentGateway
|
|
5
|
+
from ai_review.services.review.gateway.review_dry_run_comment_gateway import ReviewDryRunCommentGateway
|
|
4
6
|
from ai_review.services.review.service import ReviewService
|
|
5
7
|
from ai_review.tests.fixtures.services.cost import FakeCostService
|
|
6
8
|
from ai_review.tests.fixtures.services.review.runner.context import FakeContextReviewRunner
|
|
@@ -91,3 +93,19 @@ def test_report_total_cost_no_data(capsys, review_service: ReviewService):
|
|
|
91
93
|
output = capsys.readouterr().out
|
|
92
94
|
|
|
93
95
|
assert "No cost data collected" in output
|
|
96
|
+
|
|
97
|
+
|
|
98
|
+
def test_review_service_uses_dry_run_comment_gateway(monkeypatch: pytest.MonkeyPatch):
|
|
99
|
+
"""Should use ReviewDryRunCommentGateway when settings.review.dry_run=True."""
|
|
100
|
+
monkeypatch.setattr("ai_review.config.settings.review.dry_run", True)
|
|
101
|
+
|
|
102
|
+
service = ReviewService()
|
|
103
|
+
assert type(service.review_comment_gateway) is ReviewDryRunCommentGateway
|
|
104
|
+
|
|
105
|
+
|
|
106
|
+
def test_review_service_uses_real_comment_gateway(monkeypatch: pytest.MonkeyPatch):
|
|
107
|
+
"""Should use normal ReviewCommentGateway when dry_run=False."""
|
|
108
|
+
monkeypatch.setattr("ai_review.config.settings.review.dry_run", False)
|
|
109
|
+
|
|
110
|
+
service = ReviewService()
|
|
111
|
+
assert type(service.review_comment_gateway) is ReviewCommentGateway
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
Metadata-Version: 2.4
|
|
2
2
|
Name: xai-review
|
|
3
|
-
Version: 0.
|
|
3
|
+
Version: 0.30.0
|
|
4
4
|
Summary: AI-powered code review tool
|
|
5
5
|
Author-email: Nikita Filonov <nikita.filonov@example.com>
|
|
6
6
|
Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
|
|
@@ -211,7 +211,7 @@ jobs:
|
|
|
211
211
|
runs-on: ubuntu-latest
|
|
212
212
|
steps:
|
|
213
213
|
- uses: actions/checkout@v4
|
|
214
|
-
- uses: Nikita-Filonov/ai-review@v0.
|
|
214
|
+
- uses: Nikita-Filonov/ai-review@v0.30.0
|
|
215
215
|
with:
|
|
216
216
|
review-command: ${{ inputs.review-command }}
|
|
217
217
|
env:
|
|
@@ -74,7 +74,7 @@ ai_review/libs/config/core.py,sha256=ZQ2QtYr7vAF0tXbVLvVwk9QFE5h6JjAKAUQWcb9gHws
|
|
|
74
74
|
ai_review/libs/config/http.py,sha256=dx5PwgnGbPocUwf9QRhFmXmjfFDoeerOM04yB3B6S8w,398
|
|
75
75
|
ai_review/libs/config/logger.py,sha256=oPmjpjf6EZwW7CgOjT8mOQdGnT98CLwXepiGB_ajZvU,384
|
|
76
76
|
ai_review/libs/config/prompt.py,sha256=jPBYvi75u6BUIHOZnXCg5CiL0XRONDfW5T4WaYlxPEE,6066
|
|
77
|
-
ai_review/libs/config/review.py,sha256=
|
|
77
|
+
ai_review/libs/config/review.py,sha256=jCfHfGfHs7Sc6H92hVUBd8bMRbLiIiThVmk6lFNlv40,1224
|
|
78
78
|
ai_review/libs/config/llm/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
79
79
|
ai_review/libs/config/llm/base.py,sha256=ovvULFhfwH66_705D1O87ZGMeaQOZO7ZQhRUzzfzguU,2089
|
|
80
80
|
ai_review/libs/config/llm/claude.py,sha256=MoalXkBA6pEp01znS8ohTRopfea9RUcqhZX5lOIuek8,293
|
|
@@ -162,10 +162,11 @@ ai_review/services/prompt/service.py,sha256=AvhLMfwmIxbnPWdViSSclwUUqnHGx2V-hSMs
|
|
|
162
162
|
ai_review/services/prompt/tools.py,sha256=7yKQmHajlwFE37tvmMbbBYDmFObFVOb1ubHhNXBdAnE,1229
|
|
163
163
|
ai_review/services/prompt/types.py,sha256=9p1RHuR5-5DNV0AtR_VtiT5OHo6eNqKzGggQoPWiSh8,1572
|
|
164
164
|
ai_review/services/review/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
165
|
-
ai_review/services/review/service.py,sha256=
|
|
165
|
+
ai_review/services/review/service.py,sha256=aqt0dlA77_MPT4lcq1qbTjOZOKE-7y83I-7J5jwvro4,5579
|
|
166
166
|
ai_review/services/review/gateway/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
167
|
-
ai_review/services/review/gateway/
|
|
168
|
-
ai_review/services/review/gateway/
|
|
167
|
+
ai_review/services/review/gateway/review_comment_gateway.py,sha256=gOFoEFXIJ9SX7B05dTO605dUOnrchCtB-a2ExXCfUxE,5019
|
|
168
|
+
ai_review/services/review/gateway/review_dry_run_comment_gateway.py,sha256=3CLUBGt8ExX-r_d3PDUxhgaw-yUMqYYOvJbRzs-W63I,2420
|
|
169
|
+
ai_review/services/review/gateway/review_llm_gateway.py,sha256=5BQU8Vmo55pzWkVk6s_w5B3qX4tSkjjtj7wWWhLyc9s,1534
|
|
169
170
|
ai_review/services/review/gateway/types.py,sha256=C9zOUF0ZDnSa568T3AIWIxpNdnpcB8QUxU1rVqx7lZc,1795
|
|
170
171
|
ai_review/services/review/internal/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
171
172
|
ai_review/services/review/internal/inline/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
@@ -231,8 +232,9 @@ ai_review/tests/fixtures/services/vcs.py,sha256=RXfbuW0Ffx7km7q2Zck__1qTZdZ-_vNr
|
|
|
231
232
|
ai_review/tests/fixtures/services/review/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
232
233
|
ai_review/tests/fixtures/services/review/base.py,sha256=10LaT6xi5IP0CrR6LfatirVKnZ7D0n8Q1dV99nOBEuE,1501
|
|
233
234
|
ai_review/tests/fixtures/services/review/gateway/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
234
|
-
ai_review/tests/fixtures/services/review/gateway/
|
|
235
|
-
ai_review/tests/fixtures/services/review/gateway/
|
|
235
|
+
ai_review/tests/fixtures/services/review/gateway/review_comment_gateway.py,sha256=aclYEHKS7Kd0TK6_AGvkYsdMFhESHAGhk4Xpblxy1bQ,4078
|
|
236
|
+
ai_review/tests/fixtures/services/review/gateway/review_dry_run_comment_gateway.py,sha256=3E-fDONV4j8GJlSaumqN90Rayoe8yKjnn6APwOrpDDs,4125
|
|
237
|
+
ai_review/tests/fixtures/services/review/gateway/review_llm_gateway.py,sha256=tm3ktE5wFVIFFvHPSUO1wQG7LC3Ekta2PwWky9ugL98,1146
|
|
236
238
|
ai_review/tests/fixtures/services/review/internal/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
237
239
|
ai_review/tests/fixtures/services/review/internal/inline.py,sha256=D-npuBMSsP_ng5RgplaUZnANl3q5f7GD4OkE8IvQv2M,1038
|
|
238
240
|
ai_review/tests/fixtures/services/review/internal/inline_reply.py,sha256=NRfcVBHavyHvoxOiqMhYhcf6YWDLfT367ZoXeUZIieU,1047
|
|
@@ -312,10 +314,11 @@ ai_review/tests/suites/services/prompt/test_schema.py,sha256=rm2__LA2_4qQwSmNAZ_
|
|
|
312
314
|
ai_review/tests/suites/services/prompt/test_service.py,sha256=jfpmM--eZH43NylwltX-ijmF58ZJ4WA83kmGshUbJfs,8312
|
|
313
315
|
ai_review/tests/suites/services/prompt/test_tools.py,sha256=SmweFvrpxd-3RO5v18vCl7zonEqFE1n4eqHH7-6auYM,4511
|
|
314
316
|
ai_review/tests/suites/services/review/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
315
|
-
ai_review/tests/suites/services/review/test_service.py,sha256=
|
|
317
|
+
ai_review/tests/suites/services/review/test_service.py,sha256=9XBywDoVTzLXlfqMmrxwJbPoj8QoGFW5wDwirqu2UHI,4206
|
|
316
318
|
ai_review/tests/suites/services/review/gateway/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
317
|
-
ai_review/tests/suites/services/review/gateway/
|
|
318
|
-
ai_review/tests/suites/services/review/gateway/
|
|
319
|
+
ai_review/tests/suites/services/review/gateway/test_review_comment_gateway.py,sha256=eueGnKY3YcLvLQ8hSdhKQuVfOlFwxP82cwgEHKyRPiQ,8831
|
|
320
|
+
ai_review/tests/suites/services/review/gateway/test_review_dry_run_comment_gateway.py,sha256=YGSCZRyyV9BJaKpI66viHYZdM-GtuODJt4ZzEW1-29g,3862
|
|
321
|
+
ai_review/tests/suites/services/review/gateway/test_review_llm_gateway.py,sha256=m4HKvqDQYNesY5F2wuOMeHqXwQe99K4K_depdyTs37Q,2508
|
|
319
322
|
ai_review/tests/suites/services/review/internal/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
320
323
|
ai_review/tests/suites/services/review/internal/inline/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
321
324
|
ai_review/tests/suites/services/review/internal/inline/test_schema.py,sha256=2SGF8yNHsNv8lwG-MUlgO3RT4juTt0PQSl10qNhSt7o,2377
|
|
@@ -332,11 +335,11 @@ ai_review/tests/suites/services/review/internal/summary_reply/__init__.py,sha256
|
|
|
332
335
|
ai_review/tests/suites/services/review/internal/summary_reply/test_schema.py,sha256=_2kfcHjB-thIFTIhdDBR7PsEl8beIAu4FtEkQjb0Ljk,859
|
|
333
336
|
ai_review/tests/suites/services/review/internal/summary_reply/test_service.py,sha256=VlVr9wXXwmpp9qxy_4dMZnFHSZ12j2QSP_m58Vs_wXE,709
|
|
334
337
|
ai_review/tests/suites/services/review/runner/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
335
|
-
ai_review/tests/suites/services/review/runner/test_context.py,sha256=
|
|
336
|
-
ai_review/tests/suites/services/review/runner/test_inline.py,sha256=
|
|
337
|
-
ai_review/tests/suites/services/review/runner/test_inline_reply.py,sha256=
|
|
338
|
-
ai_review/tests/suites/services/review/runner/test_summary.py,sha256=
|
|
339
|
-
ai_review/tests/suites/services/review/runner/test_summary_reply.py,sha256=
|
|
338
|
+
ai_review/tests/suites/services/review/runner/test_context.py,sha256=tuOntcwvgnH89mlFXAnwmERPbw3AMk4NgZ6rnRmWA98,3978
|
|
339
|
+
ai_review/tests/suites/services/review/runner/test_inline.py,sha256=rnnfXqxeEYuzi7n3G9iscAfYst607LzovbtEwV6z0cQ,4681
|
|
340
|
+
ai_review/tests/suites/services/review/runner/test_inline_reply.py,sha256=Q3gsOdWvA1fYKRn-8BII19XAylAKK3B1i20xeP_Z1u4,4918
|
|
341
|
+
ai_review/tests/suites/services/review/runner/test_summary.py,sha256=VLIcKffScWSaxUztYHNLAsNUMGiJQWn7j_Le8Zcrizo,3974
|
|
342
|
+
ai_review/tests/suites/services/review/runner/test_summary_reply.py,sha256=UExBEkWh-EG0akVchgLdnnpcd7HFqEnDyMAVbFY_rtU,4576
|
|
340
343
|
ai_review/tests/suites/services/vcs/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
341
344
|
ai_review/tests/suites/services/vcs/test_factory.py,sha256=EergKSHW4b7RZg9vJJ5Cj0XfPsDTLEclV1kq2_9greA,1138
|
|
342
345
|
ai_review/tests/suites/services/vcs/bitbucket/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
@@ -348,9 +351,9 @@ ai_review/tests/suites/services/vcs/github/test_client.py,sha256=mNt1bA6aVU3REsJ
|
|
|
348
351
|
ai_review/tests/suites/services/vcs/gitlab/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
|
|
349
352
|
ai_review/tests/suites/services/vcs/gitlab/test_adapter.py,sha256=BYBP2g1AKF_jCSJYJj16pW7M_6PprwD9reYEpdw3StU,4340
|
|
350
353
|
ai_review/tests/suites/services/vcs/gitlab/test_client.py,sha256=dnI-YxYADmVF2GS9rp6-JPkcqsn4sN8Fjbe4MkeYMaE,8476
|
|
351
|
-
xai_review-0.
|
|
352
|
-
xai_review-0.
|
|
353
|
-
xai_review-0.
|
|
354
|
-
xai_review-0.
|
|
355
|
-
xai_review-0.
|
|
356
|
-
xai_review-0.
|
|
354
|
+
xai_review-0.30.0.dist-info/licenses/LICENSE,sha256=p-v8m7Kmz4KKc7PcvsGiGEmCw9AiSXY4_ylOPy_u--Y,11343
|
|
355
|
+
xai_review-0.30.0.dist-info/METADATA,sha256=-Tmw1DyUEv-KEMfBUJCj59yzMM8STdCO-A-ZrCRet6Y,11358
|
|
356
|
+
xai_review-0.30.0.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
|
|
357
|
+
xai_review-0.30.0.dist-info/entry_points.txt,sha256=JyC5URanMi5io5P_PXQf7H_I1OGIpk5cZQhaPQ0g4Zs,53
|
|
358
|
+
xai_review-0.30.0.dist-info/top_level.txt,sha256=sTsZbfzLoqvRZKdKa-BcxWvjlHdrpbeJ6DrGY0EuR0E,10
|
|
359
|
+
xai_review-0.30.0.dist-info/RECORD,,
|
|
@@ -1,17 +0,0 @@
|
|
|
1
|
-
import pytest
|
|
2
|
-
|
|
3
|
-
from ai_review.services.review.gateway.types import ReviewLLMGatewayProtocol
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
class FakeReviewLLMGateway(ReviewLLMGatewayProtocol):
|
|
7
|
-
def __init__(self):
|
|
8
|
-
self.calls: list[tuple[str, dict]] = []
|
|
9
|
-
|
|
10
|
-
async def ask(self, prompt: str, prompt_system: str) -> str:
|
|
11
|
-
self.calls.append(("ask", {"prompt": prompt, "prompt_system": prompt_system}))
|
|
12
|
-
return "FAKE_LLM_RESPONSE"
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
@pytest.fixture
|
|
16
|
-
def fake_review_llm_gateway() -> FakeReviewLLMGateway:
|
|
17
|
-
return FakeReviewLLMGateway()
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|
|
File without changes
|