xai-review 0.22.0__py3-none-any.whl → 0.23.0__py3-none-any.whl

ai_review/services/diff/renderers.py

@@ -116,14 +116,14 @@ def render_unified(
     added_new_positions = file.added_line_numbers()
     removed_old_positions = file.removed_line_numbers()
 
-    def in_context(old_no: int | None, new_no: int | None) -> bool:
+    def in_context(inner_old_no: int | None, inner_new_no: int | None) -> bool:
         """Check if an unchanged line falls within context radius."""
         if context <= 0:
             return False
-        if include_added and new_no is not None:
+        if include_added and inner_new_no is not None:
             if any(abs(new_no - a) <= context for a in added_new_positions):
                 return True
-        if include_removed and old_no is not None:
+        if include_removed and inner_old_no is not None:
             if any(abs(old_no - r) <= context for r in removed_old_positions):
                 return True
         return False

ai_review/services/prompt/schema.py

@@ -1,4 +1,4 @@
-from pydantic import BaseModel, Field
+from pydantic import BaseModel, Field, field_serializer
 
 from ai_review.config import settings
 from ai_review.libs.template.render import render_template
@@ -24,29 +24,18 @@ class PromptContextSchema(BaseModel):
     labels: list[str] = Field(default_factory=list)
     changed_files: list[str] = Field(default_factory=list)
 
-    @property
-    def render_values(self) -> dict[str, str]:
-        return {
-            "review_title": self.review_title,
-            "review_description": self.review_description,
-
-            "review_author_name": self.review_author_name,
-            "review_author_username": self.review_author_username,
-
-            "review_reviewer": self.review_reviewer,
-            "review_reviewers": ", ".join(self.review_reviewers),
-            "review_reviewers_usernames": ", ".join(self.review_reviewers_usernames),
-
-            "review_assignees": ", ".join(self.review_assignees),
-            "review_assignees_usernames": ", ".join(self.review_assignees_usernames),
-
-            "source_branch": self.source_branch,
-            "target_branch": self.target_branch,
-
-            "labels": ", ".join(self.labels),
-            "changed_files": ", ".join(self.changed_files),
-        }
+    @field_serializer(
+        "review_reviewers",
+        "review_reviewers_usernames",
+        "review_assignees",
+        "review_assignees_usernames",
+        "labels",
+        "changed_files",
+        when_used="always"
+    )
+    def list_of_strings_serializer(self, value: list[str]) -> str:
+        return ", ".join(value)
 
     def apply_format(self, prompt: str) -> str:
-        values = {**self.render_values, **settings.prompt.context}
+        values = {**self.model_dump(), **settings.prompt.context}
         return render_template(prompt, values, settings.prompt.context_placeholder)

ai_review/tests/suites/services/prompt/test_schema.py

@@ -5,6 +5,7 @@ from ai_review.services.prompt.schema import PromptContextSchema
 
 
 def test_apply_format_inserts_variables() -> None:
+    """Ensures simple string fields are correctly substituted into the template."""
     context = PromptContextSchema(
         review_title="My Review",
         review_author_username="nikita"
@@ -15,6 +16,7 @@ def test_apply_format_inserts_variables() -> None:
 
 
 def test_apply_format_with_lists() -> None:
+    """Ensures list fields are serialized as CSV strings and substituted into the template."""
     context = PromptContextSchema(
         review_reviewers=["Alice", "Bob"],
         review_reviewers_usernames=["alice", "bob"],
@@ -35,6 +37,7 @@ def test_apply_format_with_lists() -> None:
 
 
 def test_apply_format_handles_missing_fields() -> None:
+    """Ensures missing fields are replaced with empty strings."""
     context = PromptContextSchema()
     template = "Title: <<review_title>>, Reviewer: <<review_reviewer>>"
     result = context.apply_format(template)
@@ -42,6 +45,7 @@ def test_apply_format_handles_missing_fields() -> None:
 
 
 def test_apply_format_unknown_placeholder_kept() -> None:
+    """Ensures unknown placeholders remain unchanged in the template."""
     context = PromptContextSchema()
     template = "Unknown: <<does_not_exist>>"
     result = context.apply_format(template)
@@ -49,6 +53,7 @@ def test_apply_format_unknown_placeholder_kept() -> None:
 
 
 def test_apply_format_multiple_occurrences() -> None:
+    """Ensures multiple occurrences of the same placeholder are all replaced."""
     context = PromptContextSchema(review_title="My Review")
     template = "<<review_title>> again <<review_title>>"
     result = context.apply_format(template)
@@ -56,6 +61,7 @@ def test_apply_format_multiple_occurrences() -> None:
 
 
 def test_apply_format_override_from_settings(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Ensures values from settings.prompt.context override local model values."""
     monkeypatch.setitem(settings.prompt.context, "review_title", "Overridden")
     context = PromptContextSchema(review_title="Local Value")
     template = "Title: <<review_title>>"
@@ -64,8 +70,67 @@ def test_apply_format_override_from_settings(monkeypatch: pytest.MonkeyPatch) ->
 
 
 def test_apply_format_prefers_override_even_if_empty(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Ensures overrides take precedence even if the override value is empty."""
     monkeypatch.setitem(settings.prompt.context, "review_title", "")
     context = PromptContextSchema(review_title="Local Value")
     template = "Title: <<review_title>>"
     result = context.apply_format(template)
     assert result == "Title: "
+
+
+def test_apply_format_empty_list_serializes_to_empty_string() -> None:
+    """Ensures empty lists are serialized to empty strings."""
+    context = PromptContextSchema(labels=[])
+    template = "Labels: <<labels>>"
+    result = context.apply_format(template)
+    assert result == "Labels: "
+
+
+def test_apply_format_single_element_list() -> None:
+    """Ensures lists with a single element are serialized without extra separators."""
+    context = PromptContextSchema(labels=["bug"])
+    template = "Labels: <<labels>>"
+    result = context.apply_format(template)
+    assert result == "Labels: bug"
+
+
+def test_apply_format_list_with_spaces() -> None:
+    """Ensures list items containing spaces are preserved in serialization."""
+    context = PromptContextSchema(labels=[" bug ", " feature "])
+    template = "Labels: <<labels>>"
+    result = context.apply_format(template)
+    assert result == "Labels:  bug ,  feature "
+
+
+def test_apply_format_placeholder_case_sensitive() -> None:
+    """Ensures placeholder matching is case-sensitive."""
+    context = PromptContextSchema(review_title="My Review")
+    template = "Title: <<Review_Title>>"
+    result = context.apply_format(template)
+    assert result == "Title: <<Review_Title>>"
+
+
+def test_apply_format_override_with_none(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Ensures None in overrides is treated as an empty string."""
+    monkeypatch.setitem(settings.prompt.context, "review_title", None)
+    context = PromptContextSchema(review_title="Local Value")
+    template = "Title: <<review_title>>"
+    result = context.apply_format(template)
+    assert result == "Title: "
+
+
+def test_apply_format_placeholder_inside_word() -> None:
+    """Ensures placeholders inside words are still replaced correctly."""
+    context = PromptContextSchema(review_title="REV")
+    template = "prefix-<<review_title>>-suffix"
+    result = context.apply_format(template)
+    assert result == "prefix-REV-suffix"
+
+
+def test_apply_format_large_list() -> None:
+    """Ensures large lists are serialized correctly without truncation."""
+    context = PromptContextSchema(labels=[str(index) for index in range(100)])
+    template = "Labels: <<labels>>"
+    result = context.apply_format(template)
+    assert result.startswith("Labels: 0, 1, 2")
+    assert "99" in result

{xai_review-0.22.0.dist-info → xai_review-0.23.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.22.0
+Version: 0.23.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
@@ -209,7 +209,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: Nikita-Filonov/ai-review@v0.22.0
+      - uses: Nikita-Filonov/ai-review@v0.23.0
         with:
           review-command: ${{ inputs.review-command }}
         env:

{xai_review-0.22.0.dist-info → xai_review-0.23.0.dist-info}/RECORD

@@ -94,7 +94,7 @@ ai_review/services/cost/schema.py,sha256=K3uCIMMxGL8AaIPh4a-d0mT5uIJuk3f805DkP8o
 ai_review/services/cost/service.py,sha256=-qbGePoL0oYnEC60Q5gQtd1IH8ucsOiF4349ueZl7Ts,2186
 ai_review/services/cost/types.py,sha256=VyQiF5uH5T7wYlOqkvxlCOjHnjWRu4CMo8j26hQ2Alo,341
 ai_review/services/diff/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-ai_review/services/diff/renderers.py,sha256=tEUml-uqsi5FNoU2NYjxehsZHU61dTPR2VnFi7QVzV4,5861
+ai_review/services/diff/renderers.py,sha256=Z5_ViB9KJu0o3k8TBtymbUqLv9QATt1gbqT2hrysJMQ,5885
 ai_review/services/diff/schema.py,sha256=17GAQY1-ySwREJ1-NKNKgBcstMJ5Hb42FcFG2p7i6Rs,94
 ai_review/services/diff/service.py,sha256=yRb4e0fZcgFTGkAZKm5q8Gw4rWxc3nyFtpBw7ahlnw8,3581
 ai_review/services/diff/tools.py,sha256=YHmH6Ult_rucCd563UhG0geMzqrPhqKFZKyug79xNuA,1963
@@ -117,7 +117,7 @@ ai_review/services/llm/openai/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5N
 ai_review/services/llm/openai/client.py,sha256=c3DWwLnwTheERdSGnMiQIbg5SaICouUAGClcQZSh1fE,1159
 ai_review/services/prompt/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ai_review/services/prompt/adapter.py,sha256=YgD8Cf73pwPOnKxq9QSlbYr8wySfDxJE_3fIrRWfkUo,984
-ai_review/services/prompt/schema.py,sha256=x-1KRFOK3HdZozXJNPh-Bp_JrZ2AIdAPD44lhWG5g9k,1863
+ai_review/services/prompt/schema.py,sha256=ttla_lkvBQ-jfaZXzWSAAUrJROYRsozHHd5IoZc59zA,1324
 ai_review/services/prompt/service.py,sha256=58OJ6nIPSgXQyAqUXkWAXYAbNz7vMRemtllvD7bvQv0,2218
 ai_review/services/prompt/tools.py,sha256=-gS74mVM3OZPKWQkY9_QfStkfxaUfssDbJ3Bdi4AQ74,636
 ai_review/services/prompt/types.py,sha256=uVcvW8ZuwmM02MjCmw6Rg-IW5pIT3MeEYl0Vl-jzV4M,913
@@ -203,7 +203,7 @@ ai_review/tests/suites/services/llm/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQ
 ai_review/tests/suites/services/llm/test_factory.py,sha256=_i_UFtG_WGT3jpBDm20Hb0rFTFrfPuiFJhhSrlvUlVQ,1120
 ai_review/tests/suites/services/prompt/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ai_review/tests/suites/services/prompt/test_adapter.py,sha256=9KZOFQmZUs3l_cW7Q5LIMPs4i4J-gOCQ6VrlDPR0ImU,2156
-ai_review/tests/suites/services/prompt/test_schema.py,sha256=DQyv5gUJ2VkxaD9wiKLS18ECopvvdKvF4sg3MTGcKs8,2547
+ai_review/tests/suites/services/prompt/test_schema.py,sha256=rm2__LA2_4qQwSmNAZ_Wnpy11T3yYRkYUkRUrqxUQKE,5421
 ai_review/tests/suites/services/prompt/test_service.py,sha256=WXYKwDHMmWD6ew1awiEzmoxEJtQBqxvOgiyK8Ii9Mhw,6755
 ai_review/tests/suites/services/prompt/test_tools.py,sha256=_yNZoBATvPU5enWNIopbjY8lVVjfaB_46kNIKODhCW4,1981
 ai_review/tests/suites/services/review/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -222,9 +222,9 @@ ai_review/tests/suites/services/vcs/github/__init__.py,sha256=47DEQpj8HBSa-_TImW
 ai_review/tests/suites/services/vcs/github/test_service.py,sha256=c2sjecm4qzqYXuO9j6j35NQyJzqDpnXIJImRTcpkyHo,4378
 ai_review/tests/suites/services/vcs/gitlab/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ai_review/tests/suites/services/vcs/gitlab/test_service.py,sha256=0dqgL5whzjcP-AQ4adP_12QfkYm_ZtdtMotmYm8Se7Y,4449
-xai_review-0.22.0.dist-info/licenses/LICENSE,sha256=p-v8m7Kmz4KKc7PcvsGiGEmCw9AiSXY4_ylOPy_u--Y,11343
-xai_review-0.22.0.dist-info/METADATA,sha256=EiToDxby1doaJtTzkJKs23egzQ2umboze9sYLcPTGgg,10872
-xai_review-0.22.0.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
-xai_review-0.22.0.dist-info/entry_points.txt,sha256=JyC5URanMi5io5P_PXQf7H_I1OGIpk5cZQhaPQ0g4Zs,53
-xai_review-0.22.0.dist-info/top_level.txt,sha256=sTsZbfzLoqvRZKdKa-BcxWvjlHdrpbeJ6DrGY0EuR0E,10
-xai_review-0.22.0.dist-info/RECORD,,
+xai_review-0.23.0.dist-info/licenses/LICENSE,sha256=p-v8m7Kmz4KKc7PcvsGiGEmCw9AiSXY4_ylOPy_u--Y,11343
+xai_review-0.23.0.dist-info/METADATA,sha256=6GjvVteV4O_MPSSgTB4dNhlbS7iNKlGO5Uei0Y6JAuQ,10872
+xai_review-0.23.0.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
+xai_review-0.23.0.dist-info/entry_points.txt,sha256=JyC5URanMi5io5P_PXQf7H_I1OGIpk5cZQhaPQ0g4Zs,53
+xai_review-0.23.0.dist-info/top_level.txt,sha256=sTsZbfzLoqvRZKdKa-BcxWvjlHdrpbeJ6DrGY0EuR0E,10
+xai_review-0.23.0.dist-info/RECORD,,