xai-review 0.20.0__py3-none-any.whl → 0.22.0__py3-none-any.whl

ai_review/tests/suites/services/review/summary/test_service.py

@@ -4,13 +4,16 @@ from ai_review.services.review.summary.schema import SummaryCommentSchema
 from ai_review.services.review.summary.service import SummaryCommentService
 
 
-@pytest.mark.parametrize("raw, expected", [
-    ("Some summary", "Some summary"),
-    ("   padded summary   ", "padded summary"),
-    ("", ""),
-    (None, ""),
-])
-def test_parse_model_output_normalizes_and_wraps(raw, expected):
+@pytest.mark.parametrize(
+    "raw, expected",
+    [
+        ("Some summary", "Some summary"),
+        ("   padded summary   ", "padded summary"),
+        ("", ""),
+        (None, ""),
+    ]
+)
+def test_parse_model_output_normalizes_and_wraps(raw: str | None, expected: str):
     result = SummaryCommentService.parse_model_output(raw)
     assert isinstance(result, SummaryCommentSchema)
     assert result.text == expected

ai_review/tests/suites/services/review/test_service.py

@@ -0,0 +1,126 @@
+import pytest
+
+from ai_review.services.review.service import ReviewService
+from ai_review.tests.fixtures.services.artifacts import FakeArtifactsService
+from ai_review.tests.fixtures.services.cost import FakeCostService
+from ai_review.tests.fixtures.services.diff import FakeDiffService
+from ai_review.tests.fixtures.services.git import FakeGitService
+from ai_review.tests.fixtures.services.llm import FakeLLMClient
+from ai_review.tests.fixtures.services.prompt import FakePromptService
+from ai_review.tests.fixtures.services.review.inline import FakeInlineCommentService
+from ai_review.tests.fixtures.services.review.summary import FakeSummaryCommentService
+from ai_review.tests.fixtures.services.vcs import FakeVCSClient
+
+
+@pytest.fixture
+def review_service(
+        monkeypatch: pytest.MonkeyPatch,
+        fake_vcs_client: FakeVCSClient,
+        fake_llm_client: FakeLLMClient,
+        fake_git_service: FakeGitService,
+        fake_diff_service: FakeDiffService,
+        fake_cost_service: FakeCostService,
+        fake_prompt_service: FakePromptService,
+        fake_artifacts_service: FakeArtifactsService,
+        fake_inline_comment_service: FakeInlineCommentService,
+        fake_summary_comment_service: FakeSummaryCommentService,
+):
+    monkeypatch.setattr("ai_review.services.review.service.get_llm_client", lambda: fake_llm_client)
+    monkeypatch.setattr("ai_review.services.review.service.get_vcs_client", lambda: fake_vcs_client)
+    monkeypatch.setattr("ai_review.services.review.service.GitService", lambda: fake_git_service)
+    monkeypatch.setattr("ai_review.services.review.service.DiffService", lambda: fake_diff_service)
+    monkeypatch.setattr("ai_review.services.review.service.PromptService", lambda: fake_prompt_service)
+    monkeypatch.setattr("ai_review.services.review.service.InlineCommentService", lambda: fake_inline_comment_service)
+    monkeypatch.setattr("ai_review.services.review.service.SummaryCommentService", lambda: fake_summary_comment_service)
+    monkeypatch.setattr("ai_review.services.review.service.ArtifactsService", lambda: fake_artifacts_service)
+    monkeypatch.setattr("ai_review.services.review.service.CostService", lambda: fake_cost_service)
+    return ReviewService()
+
+
+@pytest.mark.asyncio
+async def test_run_inline_review_happy_path(
+        review_service: ReviewService,
+        fake_vcs_client: FakeVCSClient,
+        fake_llm_client: FakeLLMClient,
+        fake_prompt_service: FakePromptService,
+        fake_git_service: FakeGitService,
+        fake_diff_service: FakeDiffService,
+        fake_cost_service: FakeCostService,
+        fake_artifacts_service: FakeArtifactsService,
+):
+    """Should perform inline review for changed files and create inline comments via VCS."""
+    fake_git_service.responses["get_diff_for_file"] = "FAKE_DIFF"
+
+    await review_service.run_inline_review()
+
+    vcs_calls = [c[0] for c in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert "create_inline_comment" in vcs_calls
+
+    assert (
+               "get_diff_for_file",
+               {"base_sha": "A", "head_sha": "B", "file": "file.py", "unified": 3}
+           ) in fake_git_service.calls
+    assert any(call[0] == "render_file" for call in fake_diff_service.calls)
+
+    assert any(call[0] == "build_inline_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "chat" for call in fake_llm_client.calls)
+
+    assert len(fake_cost_service.reports) == 1
+    assert any(call[0] == "save_llm_interaction" for call in fake_artifacts_service.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_inline_review_skips_when_no_diff(
+        review_service: ReviewService,
+        fake_vcs_client: FakeVCSClient,
+        fake_git_service: FakeGitService,
+        fake_llm_client: FakeLLMClient,
+):
+    """Should skip inline review when no diffs exist."""
+    fake_git_service.responses["get_diff_for_file"] = ""
+
+    await review_service.run_inline_review()
+
+    assert not any(call[0] == "chat" for call in fake_llm_client.calls)
+    assert not any(call[0] == "create_inline_comment" for call in fake_vcs_client.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_context_review_happy_path(
+        review_service: ReviewService,
+        fake_vcs_client: FakeVCSClient,
+        fake_llm_client: FakeLLMClient,
+        fake_prompt_service: FakePromptService,
+        fake_diff_service: FakeDiffService,
+):
+    """Should perform context review and post inline comments based on rendered files."""
+    await review_service.run_context_review()
+
+    vcs_calls = [c[0] for c in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert "create_inline_comment" in vcs_calls
+
+    assert any(call[0] == "render_files" for call in fake_diff_service.calls)
+    assert any(call[0] == "build_context_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "chat" for call in fake_llm_client.calls)
+
+
+@pytest.mark.asyncio
+async def test_run_summary_review_happy_path(
+        review_service: ReviewService,
+        fake_vcs_client: FakeVCSClient,
+        fake_llm_client: FakeLLMClient,
+        fake_prompt_service: FakePromptService,
+        fake_diff_service: FakeDiffService,
+):
+    """Should perform summary review and post a single summary comment."""
+    await review_service.run_summary_review()
+
+    vcs_calls = [c[0] for c in fake_vcs_client.calls]
+    assert "get_review_info" in vcs_calls
+    assert "create_general_comment" in vcs_calls
+
+    assert any(call[0] == "render_files" for call in fake_diff_service.calls)
+    assert any(call[0] == "build_summary_request" for call in fake_prompt_service.calls)
+    assert any(call[0] == "chat" for call in fake_llm_client.calls)

ai_review/tests/suites/services/vcs/github/test_service.py

@@ -0,0 +1,114 @@
+import pytest
+
+from ai_review.services.vcs.github.client import GitHubVCSClient
+from ai_review.services.vcs.types import ReviewInfoSchema, ReviewCommentSchema
+from ai_review.tests.fixtures.clients.github import FakeGitHubPullRequestsHTTPClient
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("github_http_client_config")
+async def test_get_review_info_returns_valid_schema(
+        github_vcs_client: GitHubVCSClient,
+        fake_github_pull_requests_http_client: FakeGitHubPullRequestsHTTPClient,
+):
+    """Should return detailed PR info with branches, author, and files."""
+    info = await github_vcs_client.get_review_info()
+
+    assert isinstance(info, ReviewInfoSchema)
+    assert info.id == 1
+    assert info.title == "Fake Pull Request"
+    assert info.description == "This is a fake PR for testing"
+
+    assert info.author.username == "tester"
+    assert {a.username for a in info.assignees} == {"dev1", "dev2"}
+    assert {r.username for r in info.reviewers} == {"reviewer"}
+
+    assert info.source_branch.ref == "feature/test"
+    assert info.target_branch.ref == "main"
+    assert info.base_sha == "abc123"
+    assert info.head_sha == "def456"
+
+    assert "app/main.py" in info.changed_files
+    assert len(info.changed_files) == 2
+
+    called_methods = [name for name, _ in fake_github_pull_requests_http_client.calls]
+    assert called_methods == ["get_pull_request", "get_files"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("github_http_client_config")
+async def test_get_general_comments_returns_expected_list(
+        github_vcs_client: GitHubVCSClient,
+        fake_github_pull_requests_http_client: FakeGitHubPullRequestsHTTPClient,
+):
+    """Should return general (issue-level) comments."""
+    comments = await github_vcs_client.get_general_comments()
+
+    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert len(comments) == 2
+
+    bodies = [c.body for c in comments]
+    assert "General comment" in bodies
+    assert "Another general comment" in bodies
+
+    called_methods = [name for name, _ in fake_github_pull_requests_http_client.calls]
+    assert called_methods == ["get_issue_comments"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("github_http_client_config")
+async def test_get_inline_comments_returns_expected_list(
+        github_vcs_client: GitHubVCSClient,
+        fake_github_pull_requests_http_client: FakeGitHubPullRequestsHTTPClient,
+):
+    """Should return inline comments with file and line references."""
+    comments = await github_vcs_client.get_inline_comments()
+
+    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert len(comments) == 2
+
+    first = comments[0]
+    assert first.body == "Inline comment"
+    assert first.file == "file.py"
+    assert first.line == 5
+
+    called_methods = [name for name, _ in fake_github_pull_requests_http_client.calls]
+    assert called_methods == ["get_review_comments"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("github_http_client_config")
+async def test_create_general_comment_posts_comment(
+        github_vcs_client: GitHubVCSClient,
+        fake_github_pull_requests_http_client: FakeGitHubPullRequestsHTTPClient,
+):
+    """Should post a general (non-inline) comment."""
+    message = "Hello from test!"
+
+    await github_vcs_client.create_general_comment(message)
+
+    calls = [args for name, args in fake_github_pull_requests_http_client.calls if name == "create_issue_comment"]
+    assert len(calls) == 1
+    call_args = calls[0]
+    assert call_args["body"] == message
+    assert call_args["repo"] == "repo"
+    assert call_args["owner"] == "owner"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("github_http_client_config")
+async def test_create_inline_comment_posts_comment(
+        github_vcs_client: GitHubVCSClient,
+        fake_github_pull_requests_http_client: FakeGitHubPullRequestsHTTPClient,
+):
+    """Should post an inline comment with correct path, line and commit_id."""
+    await github_vcs_client.create_inline_comment("file.py", 10, "Looks good")
+
+    calls = [args for name, args in fake_github_pull_requests_http_client.calls if name == "create_review_comment"]
+    assert len(calls) == 1
+
+    call_args = calls[0]
+    assert call_args["path"] == "file.py"
+    assert call_args["line"] == 10
+    assert call_args["body"] == "Looks good"
+    assert call_args["commit_id"] == "def456"  # from fake PR head

ai_review/tests/suites/services/vcs/gitlab/test_service.py

@@ -0,0 +1,123 @@
+import pytest
+
+from ai_review.services.vcs.gitlab.client import GitLabVCSClient
+from ai_review.services.vcs.types import ReviewInfoSchema, ReviewCommentSchema
+from ai_review.tests.fixtures.clients.gitlab import FakeGitLabMergeRequestsHTTPClient
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_get_review_info_returns_valid_schema(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should return valid MR info with author, branches and changed files."""
+    info = await gitlab_vcs_client.get_review_info()
+
+    assert isinstance(info, ReviewInfoSchema)
+    assert info.id == 1
+    assert info.title == "Fake Merge Request"
+    assert info.description == "This is a fake MR for testing"
+
+    assert info.author.username == "tester"
+    assert info.author.name == "Tester"
+    assert info.author.id == 42
+
+    assert info.source_branch.ref == "feature/test"
+    assert info.target_branch.ref == "main"
+    assert info.base_sha == "abc123"
+    assert info.head_sha == "def456"
+    assert info.start_sha == "ghi789"
+
+    assert len(info.changed_files) == 1
+    assert info.changed_files[0] == "main.py"
+
+    called_methods = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
+    assert called_methods == ["get_changes"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_get_general_comments_returns_expected_list(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should return general MR-level notes."""
+    comments = await gitlab_vcs_client.get_general_comments()
+
+    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert len(comments) == 2
+
+    bodies = [c.body for c in comments]
+    assert "General comment" in bodies
+    assert "Another note" in bodies
+
+    called_methods = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
+    assert called_methods == ["get_notes"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_get_inline_comments_returns_expected_list(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should return inline comments from MR discussions."""
+    comments = await gitlab_vcs_client.get_inline_comments()
+
+    assert all(isinstance(c, ReviewCommentSchema) for c in comments)
+    assert len(comments) == 2
+
+    first = comments[0]
+    assert first.body == "Inline comment A"
+
+    called_methods = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
+    assert called_methods == ["get_discussions"]
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_create_general_comment_posts_comment(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should post a general note to MR."""
+    message = "Hello, GitLab!"
+
+    await gitlab_vcs_client.create_general_comment(message)
+
+    calls = [
+        args for name, args in fake_gitlab_merge_requests_http_client.calls
+        if name == "create_note"
+    ]
+    assert len(calls) == 1
+    call_args = calls[0]
+
+    assert call_args["body"] == message
+    assert call_args["project_id"] == "project-id"
+    assert call_args["merge_request_id"] == "merge-request-id"
+
+
+@pytest.mark.asyncio
+@pytest.mark.usefixtures("gitlab_http_client_config")
+async def test_create_inline_comment_posts_comment(
+        gitlab_vcs_client: GitLabVCSClient,
+        fake_gitlab_merge_requests_http_client: FakeGitLabMergeRequestsHTTPClient,
+):
+    """Should create an inline discussion at specific file and line."""
+    await gitlab_vcs_client.create_inline_comment("main.py", 5, "Looks good!")
+
+    called_names = [name for name, _ in fake_gitlab_merge_requests_http_client.calls]
+    assert "get_changes" in called_names
+    assert "create_discussion" in called_names
+
+    calls = [
+        args for name, args in fake_gitlab_merge_requests_http_client.calls
+        if name == "create_discussion"
+    ]
+    assert len(calls) == 1
+
+    call_args = calls[0]
+    assert call_args["body"] == "Looks good!"
+    assert call_args["project_id"] == "project-id"
+    assert call_args["merge_request_id"] == "merge-request-id"

ai_review/tests/suites/services/vcs/test_factory.py

@@ -0,0 +1,23 @@
+import pytest
+
+from ai_review.services.vcs.factory import get_vcs_client
+from ai_review.services.vcs.github.client import GitHubVCSClient
+from ai_review.services.vcs.gitlab.client import GitLabVCSClient
+
+
+@pytest.mark.usefixtures("github_http_client_config")
+def test_get_vcs_client_returns_github(monkeypatch: pytest.MonkeyPatch):
+    client = get_vcs_client()
+    assert isinstance(client, GitHubVCSClient)
+
+
+@pytest.mark.usefixtures("gitlab_http_client_config")
+def test_get_vcs_client_returns_gitlab(monkeypatch: pytest.MonkeyPatch):
+    client = get_vcs_client()
+    assert isinstance(client, GitLabVCSClient)
+
+
+def test_get_vcs_client_unsupported_provider(monkeypatch: pytest.MonkeyPatch):
+    monkeypatch.setattr("ai_review.services.vcs.factory.settings.vcs.provider", "BITBUCKET")
+    with pytest.raises(ValueError):
+        get_vcs_client()

{xai_review-0.20.0.dist-info → xai_review-0.22.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: xai-review
-Version: 0.20.0
+Version: 0.22.0
 Summary: AI-powered code review tool
 Author-email: Nikita Filonov <nikita.filonov@example.com>
 Maintainer-email: Nikita Filonov <nikita.filonov@example.com>
@@ -29,6 +29,7 @@ Requires-Dist: pydantic
 Requires-Dist: pydantic-settings
 Provides-Extra: test
 Requires-Dist: pytest; extra == "test"
+Requires-Dist: pytest-asyncio; extra == "test"
 Dynamic: license-file
 
 # AI Review
@@ -192,6 +193,7 @@ Add a workflow like this (manual trigger from **Actions** tab):
 
 ```yaml
 name: AI Review
+
 on:
   workflow_dispatch:
     inputs:
@@ -207,7 +209,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: Nikita-Filonov/ai-review@v0.20.0
+      - uses: Nikita-Filonov/ai-review@v0.22.0
         with:
           review-command: ${{ inputs.review-command }}
         env:
@@ -272,6 +274,7 @@ ai-review:
 See these folders for reference templates and full configuration options:
 
 - [./docs/ci](./docs/ci) — CI/CD integration templates (GitHub Actions, GitLab CI)
+- [./docs/hooks](./docs/hooks) — hook reference and lifecycle events
 - [./docs/configs](./docs/configs) — full configuration examples (`.yaml`, `.json`, `.env`)
 - [./docs/prompts](./docs/prompts) — prompt templates for Python/Go (light & strict modes)