wmglobalqueue 2.3.10__py3-none-any.whl

WMCore/WMSpec/WMWorkloadTools.py

@@ -0,0 +1,370 @@
+"""
+_WMWorkloadTools_
+
+Define some generic tools used by the StdSpecs and WMWorkload
+to validate arguments that modify a WMWorkload and/or WMTask.
+
+Created on Jun 13, 2013
+
+@author: dballest
+"""
+from builtins import str, bytes
+from future.utils import viewitems, viewvalues
+
+import json
+import re
+import inspect
+
+from Utils.Utilities import makeList
+from WMCore.DataStructs.LumiList import LumiList
+from WMCore.WMSpec.WMSpecErrors import WMSpecFactoryException
+
+def checkMemCore(paramInfo, minValue=1):
+    """
+    Spec validation function for the Memory/Multicore parameters
+    :param memInfo: memory provided by the user (can be an int/float/dict)
+    :param minValue: base value to be used to validate user's values
+    :return: True if validation is successful, raise an exception otherwise
+    """
+    try:
+        if isinstance(paramInfo, dict):
+            for value in viewvalues(paramInfo):
+                assert value >= minValue
+        else:
+            assert paramInfo >= minValue
+    except Exception:
+        return False
+    return True
+
+
+def checkEventStreams(streamsInfo):
+    """
+    Spec validation function for the EventStreams parameter
+    :param streamsInfo: event streams provided by the user (can be either int or a dict)
+    :return: True if validation is successful, raise an exception otherwise
+    """
+    return checkMemCore(streamsInfo, 0)
+
+
+def checkTimePerEvent(tpEvtInfo):
+    """
+    Spec validation function for the TimePerEvent parameter
+    :param tpEvtInfo: time per event provided by the user (can be either float or a dict)
+    :return: True if validation is successful, raise an exception otherwise
+    """
+    return checkMemCore(tpEvtInfo, 0)
+
+
+def makeLumiList(lumiDict):
+    try:
+        if isinstance(lumiDict, (str, bytes)):
+            lumiDict = json.loads(lumiDict)
+        ll = LumiList(compactList=lumiDict)
+        return ll.getCompactList()
+    except:
+        raise WMSpecFactoryException("Could not parse LumiList, %s: %s" % (type(lumiDict), lumiDict))
+
+
+def parsePileupConfig(mcPileup, dataPileup):
+    """
+    _parsePileupConfig_
+
+    If the pileup config is defined as MCPileup and DataPileup
+    then make sure we get the usual dictionary as
+    PileupConfig : {'mc': ['/mc_pd/procds/tier'], 'data': ['/data_pd/procds/tier']}
+    """
+    pileUpConfig = {}
+    if mcPileup is not None:
+        pileUpConfig['mc'] = [mcPileup]
+    if dataPileup is not None:
+        pileUpConfig['data'] = [dataPileup]
+    return pileUpConfig
+
+
+def _validateArgument(argument, value, argumentDefinition):
+    """
+    Validate a single argument against its definition in the spec
+    """
+    validNull = argumentDefinition["null"]
+    if not validNull and value is None:
+        raise WMSpecFactoryException("Argument '%s' cannot be None" % argument)
+    elif value is None:
+        return value
+
+    try:
+        value = argumentDefinition["type"](value)
+    except Exception:
+        msg = "Argument '%s' with value %r, has an incorrect data type: " % (argument, value)
+        msg += "%s. It must be %s" % (type(value), argumentDefinition["type"])
+        raise WMSpecFactoryException(msg)
+
+    _validateArgFunction(argument, value, argumentDefinition["validate"])
+    return value
+
+
+def _validateArgumentDict(argument, argValue, argumentDefinition):
+    """
+    Validate only the basic structure of dict arguments, we anyways
+    don't have the definition of the internal arguments.
+    """
+    # make sure we're not going to cast a dict to string and let that unnoticed
+    if isinstance(argumentDefinition["type"], type(dict)) and not isinstance(argValue, dict):
+        msg = "Argument '%s' with value %r, has an incorrect data type: " % (argument, argValue)
+        msg += "%s. It must be %s" % (type(argValue), argumentDefinition["type"])
+        raise WMSpecFactoryException(msg)
+
+    # still an exception, make sure it has the correct format
+    if argument == "LumiList":
+        argValue = argumentDefinition["type"](argValue)
+
+    _validateArgFunction(argument, argValue, argumentDefinition["validate"])
+    return argValue
+
+
+def _validateArgFunction(argument, value, valFunction):
+    """
+    Perform the validation function as in the argument definition
+    """
+    if valFunction:
+        try:
+            if not valFunction(value):
+                msg = "Argument '%s' with value %r, doesn't pass the validate function." % (argument, value)
+                msg += "\nIt's definition is:\n%s" % inspect.getsource(valFunction)
+                raise WMSpecFactoryException(msg)
+        except WMSpecFactoryException:
+            # just re-raise it to keep the error message clear
+            raise
+        except Exception as ex:
+            # Some validation functions (e.g. Lexicon) will raise errors instead of returning False
+            raise WMSpecFactoryException(str(ex))
+    return
+
+
+def _validateArgumentOptions(arguments, argumentDefinition, optionKey=None):
+    """
+    Check whether create or assign mandatory parameters were properly
+    set in the request schema.
+    """
+    for arg, argDef in viewitems(argumentDefinition):
+        optional = argDef.get(optionKey, True)
+        if not optional and arg not in arguments:
+            msg = "Argument '{}' is mandatory and must be provided by the user.".format(arg)
+            msg += " Its definition is: {}".format(argDef)
+            raise WMSpecFactoryException(msg)
+        # specific case when user GUI returns empty string for optional arguments
+        elif arg not in arguments:
+            continue
+        elif isinstance(arguments[arg], dict):
+            arguments[arg] = _validateArgumentDict(arg, arguments[arg], argDef)
+        else:
+            arguments[arg] = _validateArgument(arg, arguments[arg], argDef)
+    return
+
+
+def validateInputDatasSetAndParentFlag(arguments):
+    """
+    Check if the InputDataset value provided corresponds to an actual dataset in DBS.
+    If parent flag is provided, then check whether the input dataset has a parent.
+    the InputDataset existence in DBS and its parent, if needed.
+    """
+    inputdataset = _getChainKey(arguments, "InputDataset")
+    mcpileup = _getChainKey(arguments, "MCPileup")
+    datapileup = _getChainKey(arguments, "DataPileup")
+    includeParents = _getChainKey(arguments, "IncludeParents")
+    # TODO: this replace can be removed in one year from now, thus March 2022
+    dbsURL = arguments.get("DbsUrl")
+    if dbsURL:
+        dbsURL = dbsURL.replace("cmsweb.cern.ch", "cmsweb-prod.cern.ch")
+        dbsURL = dbsURL.rstrip("/")
+
+    if includeParents and not inputdataset:
+        msg = "IncludeParents flag is True but InputDataset value has not been provided"
+        raise WMSpecFactoryException(msg)
+
+    if dbsURL and inputdataset or mcpileup or datapileup:
+        # import DBS3Reader here, since Runtime code import this module and worker
+        # node doesn't have dbs3 client
+        from WMCore.Services.DBS.DBS3Reader import DBS3Reader
+        from WMCore.Services.DBS.DBSErrors import DBSReaderError
+        dbsInst = DBS3Reader(dbsURL)
+
+        try:
+            _datasetExists(dbsInst, inputdataset)
+            _datasetExists(dbsInst, mcpileup)
+            _datasetExists(dbsInst, datapileup)
+        except DBSReaderError as ex:
+            # we need to Wrap the exception to WMSpecFactoryException to be caught in reqmgr validation
+            raise WMSpecFactoryException(str(ex))
+
+        if includeParents:
+            try:
+                result = dbsInst.listDatasetParents(inputdataset)
+                if len(result) == 0:
+                    msg = "IncludeParents flag is True but the input dataset %s has no parents" % inputdataset
+                    raise DBSReaderError(msg)
+            except DBSReaderError as ex:
+                raise WMSpecFactoryException(str(ex))
+
+    return
+
+
+def _datasetExists(dbsInst, inputData):
+    """
+    __datasetExists_
+
+    Check if dataset exists in DBS. Exception is raised in case it does not exist.
+    """
+    if inputData is None:
+        return
+    dbsInst.checkDatasetPath(inputData)
+    return
+
+
+def _getChainKey(arguments, keyName):
+    """
+    Given a request arguments dictionary and a key name, properly returns its
+    value regardless of the request type.
+    """
+    if "TaskChain" in arguments:
+        value = arguments['Task1'].get(keyName)
+    elif "StepChain" in arguments:
+        value = arguments['Step1'].get(keyName)
+    else:
+        value = arguments.get(keyName)
+    return value
+
+
+def _validateMoveSubscription(subType, sites):
+    """
+    Move subscriptions are only allowed to T0 or T1s, see #7760
+    """
+    invalidSites = [site for site in sites if re.match("^T[2-3]", site)]
+    if invalidSites:
+        msg = "Move subscription (%s) not allowed to T2/T3 sites: %s" % (subType, invalidSites)
+        raise WMSpecFactoryException(msg)
+
+
+def validateSiteLists(arguments):
+    whiteList = arguments.get("SiteWhitelist", [])
+    blackList = arguments.get("SiteBlacklist", [])
+    whiteList = makeList(whiteList)
+    blackList = makeList(blackList)
+    res = (set(whiteList) & set(blackList))
+    if len(res):
+        msg = "Validation failed: The same site cannot be white and blacklisted: %s" % list(res)
+        raise WMSpecFactoryException(msg)
+    # store the properly formatted values (list instead of string)
+    arguments["SiteWhitelist"] = whiteList
+    arguments["SiteBlacklist"] = blackList
+    return
+
+
+def validateArgumentsCreate(arguments, argumentDefinition, checkInputDset=True):
+    """
+    _validateArguments_
+
+    Validate a set of arguments - for spec creation - against their
+    definition in StdBase.getWorkloadCreateArgs.
+
+    When validating Step/Task dictionary, checkInputDset should be usually
+    false since the input dataset validation already happened at top level.
+
+    It returns an error message if the validation went wrong,
+    otherwise returns None.
+    """
+    validateUnknownArgs(arguments, argumentDefinition)
+    _validateArgumentOptions(arguments, argumentDefinition, "optional")
+    if checkInputDset:
+        validateInputDatasSetAndParentFlag(arguments)
+    return
+
+
+def validateArgumentsUpdate(arguments, argumentDefinition, optionKey="assign_optional"):
+    """
+    _validateArgumentsUpdate_
+
+    Validate a set of arguments - for spec assignment/update - against
+    their definition in StdBase.getWorkloadAssignArgs.
+
+    It returns an error message if the validation went wrong,
+    otherwise returns None.
+    """
+    validateUnknownArgs(arguments, argumentDefinition)
+    _validateArgumentOptions(arguments, argumentDefinition, optionKey)
+    validateSiteLists(arguments)
+
+    return
+
+def validateUnknownArgs(arguments, argumentDefinition):
+    """
+    Make sure user is sending only arguments that are known by
+    StdBase.getWorkloadCreateArgs, otherwise fail spec creation.
+
+    It returns an error message if the validation went wrong,
+    otherwise returns None.
+    """
+    unknownArgs = set(arguments) - set(argumentDefinition.keys())
+    if unknownArgs:
+        # now onto the exceptions...
+        if arguments.get("RequestType") == "ReReco":
+            unknownArgs = unknownArgs - set([x for x in unknownArgs if x.startswith("Skim")])
+        elif arguments.get("RequestType") == "StepChain":
+            unknownArgs = unknownArgs - set([x for x in unknownArgs if x.startswith("Step")])
+        elif arguments.get("RequestType") == "TaskChain":
+            unknownArgs = unknownArgs - set([x for x in unknownArgs if x.startswith("Task")])
+        elif arguments.get("RequestType") == "Resubmission":
+            # oh well, then we have to skip all possible obscure arguments
+            unknownArgs = unknownArgs - set([x for x in unknownArgs if x.startswith("Skim")])
+            unknownArgs = unknownArgs - set([x for x in unknownArgs if x.startswith("Step")])
+            unknownArgs = unknownArgs - set([x for x in unknownArgs if x.startswith("Task")])
+
+        if unknownArgs:
+            msg = "There are unknown/unsupported arguments in your request spec: %s" % list(unknownArgs)
+            raise WMSpecFactoryException(msg)
+    return
+
+
+def setArgumentsWithDefault(arguments, argumentDefinition):
+    """
+    Set arguments not provided by the user with a default spec value
+    """
+    for argument in argumentDefinition:
+        if argument not in arguments:
+            arguments[argument] = argumentDefinition[argument]["default"]
+
+    # set the Campaign default value to the same as AcquisitionEra if Campaign is not specified
+    if "Campaign" in argumentDefinition and not arguments.get("Campaign"):
+        if "AcquisitionEra" in arguments and isinstance(arguments["AcquisitionEra"], (str, bytes)):
+            arguments["Campaign"] = arguments["AcquisitionEra"]
+
+    return
+
+def setAssignArgumentsWithDefault(arguments, argumentDefinition):
+    """
+    Set arguments not provided by the user with a default assign spec value,
+    unless the default value is None (read don't set default).
+    """
+    for argument in argumentDefinition:
+        if argument not in arguments and argumentDefinition[argument]["default"] is not None:
+            arguments[argument] = argumentDefinition[argument]["default"]
+
+    return
+
+def loadSpecClassByType(specType):
+    factoryName = "%sWorkloadFactory" % specType
+    mod = __import__("WMCore.WMSpec.StdSpecs.%s" % specType,
+                     globals(), locals(), [factoryName])
+    specClass = getattr(mod, factoryName)
+
+    return specClass
+
+
+def loadSpecByType(specType):
+    specClass = loadSpecClassByType(specType)
+    return specClass()
+
+
+def checkDBSURL(url):
+    # import DBS3Reader here, since Runtime code import this module and worker node doesn't have dbs3 client
+    from WMCore.Services.DBS.DBS3Reader import DBS3Reader
+    return DBS3Reader(url).checkDBSServer()

WMCore/WMSpec/__init__.py

@@ -0,0 +1,9 @@
+#!/usr/bin/env python
+"""
+_WMCore.WMSpec_
+
+"""
+
+
+
+__all__ = []

WMCore/WorkQueue/DataLocationMapper.py

@@ -0,0 +1,273 @@
+#!/usr/bin/env python
+"""Map data to locations for WorkQueue"""
+
+from future.utils import viewitems, viewvalues, listvalues
+from builtins import object
+from future import standard_library
+standard_library.install_aliases()
+
+from collections import defaultdict
+import logging
+
+from urllib.parse import urlparse
+
+from WMCore.Services.DBS.DBSReader import DBSReader
+from WMCore.Services.MSUtils.MSUtils import getPileupDocs
+from WMCore.WorkQueue.DataStructs.ACDCBlock import ACDCBlock
+
+# TODO: Combine with existing dls so DBSreader can do this kind of thing transparently
+# TODO: Known Issue: Can't have same item in multiple dbs's at the same time.
+
+
+def isGlobalDBS(dbs):
+    """
+    Receives a DBSReader object and finds out whether it's
+    pointing to Global DBS (no matter whether it's production
+    or the pre-production instance).
+    """
+    try:
+        url = urlparse(dbs.dbsURL)
+        if url.hostname.startswith('cmsweb'):
+            if url.path.startswith('/dbs/prod/global') or url.path.startswith('/dbs/int/global'):
+                return True
+    except Exception as ex:
+        logging.error("Failed to find out whether DBS is Global or not. Error: %s", str(ex))
+    return False
+
+
+def isDataset(inputData):
+    """Check whether we're handling a block or a dataset"""
+    if '#' in inputData.split('/')[-1]:
+        return False
+    return True
+
+
+class DataLocationMapper(object):
+    """Map data to locations for WorkQueue"""
+
+    def __init__(self, logger=None, **kwargs):
+        self.params = kwargs
+        self.logger = logger or logging.getLogger()
+        self.params.setdefault('locationFrom', 'subscription')
+        self.params.setdefault('incompleteBlocks', False)
+        self.params.setdefault('requireBlocksSubscribed', True)
+        self.params.setdefault('rucioAccount', "wmcore_transferor")
+        self.params.setdefault('rucioAccountPU', "wmcore_pileup")
+
+        validLocationFrom = ('subscription', 'location')
+        if self.params['locationFrom'] not in validLocationFrom:
+            msg = "Invalid value for locationFrom: '%s'. Valid values are: %s" % (
+                self.params['locationFrom'], validLocationFrom)
+            raise ValueError(msg)
+
+        self.rucio = self.params.get('rucio')
+        if self.params.get('cric'):
+            self.cric = self.params['cric']
+
+        # save each DBSReader instance in the class object, such that
+        # the same object is not shared amongst multiple threads
+        self.dbses = {}
+
+    def __call__(self, dataItems, rucioAcct=None):
+        rucioAcct = rucioAcct or self.params['rucioAccount']
+        result = {}
+
+        dataByDbs = self.organiseByDbs(dataItems)
+
+        for dbs, dataItems in viewitems(dataByDbs):
+            # if global use Rucio, else use dbs
+            if "pileup" in rucioAcct:
+                output = self.locationsFromMSPileup(dataItems, dbs.dbsURL)
+            elif isGlobalDBS(dbs):
+                output = self.locationsFromRucio(dataItems, rucioAcct)
+            else:
+                output = self.locationsFromDBS(dbs, dataItems)
+            result[dbs] = output
+
+        return result
+
+    def locationsFromRucio(self, dataItems, rucioAcct):
+        """
+        Get data location from Rucio. Location is mapped to the actual
+        sites associated with them, so PSNs are actually returned
+        :param dataItems: list of datasets/blocks names
+        :param rucioAcct: string with the Rucio account name to check the rules against
+        :return: dictionary key'ed by the dataset/block, with a list of PSNs as value
+        """
+        result = defaultdict(set)
+        self.logger.info("Fetching location from Rucio for account: %s", rucioAcct)
+        for dataItem in dataItems:
+            try:
+                dataLocations = self.rucio.getDataLockedAndAvailable(name=dataItem,
+                                                                     account=rucioAcct)
+                # resolve the PNNs into PSNs
+                result[dataItem] = self.cric.PNNstoPSNs(dataLocations)
+            except Exception as ex:
+                self.logger.error('Error getting block location from Rucio for %s: %s', dataItem, str(ex))
+
+        return result
+
+    def locationsFromDBS(self, dbs, dataItems):
+        """Get data location from dbs"""
+        result = defaultdict(set)
+        for dataItem in dataItems:
+            try:
+                if isDataset(dataItem):
+                    phedexNodeNames = dbs.listDatasetLocation(dataItem)
+                else:
+                    phedexNodeNames = dbs.listFileBlockLocation(dataItem)
+                result[dataItem].update(phedexNodeNames)
+            except Exception as ex:
+                self.logger.error('Error getting block location from dbs for %s: %s', dataItem, str(ex))
+
+        # convert the sets to lists
+        for name, nodes in viewitems(result):
+            psns = set()
+            psns.update(self.cric.PNNstoPSNs(nodes))
+            result[name] = list(psns)
+
+        return result
+
+    def locationsFromMSPileup(self, dataItems, dbsUrl):
+        """
+        Get data location from MSPileup.
+
+        :param dataItems: list, list of pileup names to query
+        :param dbsUrl: str, dbs url to check which dbs server
+        :return: dict, dict of pileup name keys with location set values
+        """
+        self.logger.info(f'Fetching locations from MSPileup for {len(dataItems)} containers')
+
+        result = defaultdict(set)
+        # TODO: Fetch multiple pileups in single request
+        for dataItem in dataItems:
+            try:
+                queryDict = {'query': {'pileupName': dataItem},
+                             'filters': ['currentRSEs', 'pileupName', 'containerFraction', 'ruleIds']}
+                pileupInstance = '-testbed' if 'cmsweb-testbed' in dbsUrl else '-prod'
+                msPileupUrl = f"https://cmsweb{pileupInstance}.cern.ch/ms-pileup/data/pileup"
+                doc = getPileupDocs(msPileupUrl, queryDict, method='POST')[0]
+                self.logger.info(f'locationsFromPileup - name: {dataItem}, currentRSEs: {doc["currentRSEs"]}, containerFraction: {doc["containerFraction"]}')
+                # resolve PNNs into PSNs
+                result[dataItem] = self.cric.PNNstoPSNs(doc['currentRSEs'])
+            except IndexError:
+                self.logger.error('Did not find any pileup document for query: %s', queryDict['query'])
+            except Exception as ex:
+                self.logger.error('Error getting block location from MSPileup for %s: %s', dataItem, str(ex))
+
+        return result
+
+    def organiseByDbs(self, dataItems):
+        """Sort items by dbs instances - return dict with DBSReader as key & data items as values"""
+        itemsByDbs = defaultdict(list)
+        for item in dataItems:
+            if ACDCBlock.checkBlockName(item['name']):
+                # if it is acdc block don't update location. location should be
+                # inserted when block is queued and not supposed to change
+                continue
+
+            if item['dbs_url'] not in self.dbses:
+                self.dbses[item['dbs_url']] = DBSReader(item['dbs_url'])
+            itemsByDbs[self.dbses[item['dbs_url']]].append(item['name'])
+
+        return itemsByDbs
+
+
+class WorkQueueDataLocationMapper(DataLocationMapper):
+    """WorkQueue data location functionality"""
+
+    def __init__(self, logger, backend, **kwargs):
+        self.backend = backend
+        self.logger = logger
+        super(WorkQueueDataLocationMapper, self).__init__(logger, **kwargs)
+
+    def __call__(self):
+        elemUpdated = 0
+        elemUpdated += self.updatePrimaryLocation()
+        elemUpdated += self.updateParentLocation()
+        elemUpdated += self.updatePileupLocation()
+
+        return elemUpdated
+
+    def updatePrimaryLocation(self):
+        dataItems = self.backend.getActiveData()
+        dataLocations = super(WorkQueueDataLocationMapper, self).__call__(dataItems)
+        self.logger.info("Found %d unique input data to update location", len(dataItems))
+
+        # elements with multiple changed data items will fail fix this, or move to store data outside element
+        modified = []
+        for dataMapping in viewvalues(dataLocations):
+            for data, locations in viewitems(dataMapping):
+                elements = self.backend.getElementsForData(data)
+                for element in elements:
+                    if element.get('NoInputUpdate', False):
+                        continue
+                    if sorted(locations) != sorted(element['Inputs'][data]):
+                        self.logger.info("%s, setting location to: %s", data, locations)
+                        element['Inputs'][data] = locations
+                        modified.append(element)
+        self.logger.info("Updating %d elements for Input location update", len(modified))
+        self.backend.saveElements(*modified)
+
+        return len(modified)
+
+    def updateParentLocation(self):
+        dataItems = self.backend.getActiveParentData()
+
+        # fullResync incorrect with multiple dbs's - fix!!!
+        dataLocations = DataLocationMapper.__call__(self, dataItems)
+        self.logger.info("Found %d unique parent data to update location", len(dataItems))
+
+        # Given that there might be multiple data items to be updated
+        # handle it like a dict such that element lookup becomes easier
+        modified = {}
+        for dataMapping in viewvalues(dataLocations):
+            for data, locations in viewitems(dataMapping):
+                elements = self.backend.getElementsForParentData(data)
+                for element in elements:
+                    if element.get('NoInputUpdate', False):
+                        continue
+                    if element.id in modified:
+                        element = modified[element.id]
+                    for pData in element['ParentData']:
+                        if pData == data:
+                            if sorted(locations) != sorted(element['ParentData'][pData]):
+                                self.logger.info("%s, setting location to: %s", data, locations)
+                                element['ParentData'][pData] = locations
+                                modified[element.id] = element
+                                break
+        self.logger.info("Updating %d elements for Parent location update", len(modified))
+        self.backend.saveElements(*listvalues(modified))
+
+        return len(modified)
+
+    def updatePileupLocation(self):
+        dataItems = self.backend.getActivePileupData()
+
+        # fullResync incorrect with multiple dbs's - fix!!!
+        dataLocations = DataLocationMapper.__call__(self, dataItems, self.params['rucioAccountPU'])
+        self.logger.info("Found %d unique pileup data to update location", len(dataItems))
+
+        # Given that there might be multiple data items to be updated
+        # handle it like a dict such that element lookup becomes easier
+        modified = {}
+        for dataMapping in listvalues(dataLocations):
+            for data, locations in viewitems(dataMapping):
+                elements = self.backend.getElementsForPileupData(data)
+                self.logger.info("Found %d elements using pileup: %s", len(elements), data)
+                for element in elements:
+                    if element.get('NoPileupUpdate', False):
+                        continue
+                    if element.id in modified:
+                        element = modified[element.id]
+                    for pData in element['PileupData']:
+                        if pData == data:
+                            if sorted(locations) != sorted(element['PileupData'][pData]):
+                                self.logger.info("%s, setting location to: %s", data, locations)
+                                element['PileupData'][pData] = locations
+                                modified[element.id] = element
+                                break
+        self.logger.info("Updating %d elements for Pileup location update", len(modified))
+        self.backend.saveElements(*listvalues(modified))
+
+        return len(modified)