wagtail 6.2.2__py3-none-any.whl → 6.3rc2__py3-none-any.whl

wagtail/locales/locale/en/LC_MESSAGES/django.po

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-08-07 10:06+0100\n"
+"POT-Creation-Date: 2024-10-21 17:53+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -79,24 +79,24 @@ msgstr ""
 msgid "The locale could not be saved due to errors."
 msgstr ""
 
-#: views.py:57 views.py:64
-msgid "Delete locale"
+#: views.py:62
+#, python-format
+msgid "Locale '%(object)s' deleted."
 msgstr ""
 
 #: views.py:63
-#, python-format
-msgid "Locale '%(object)s' deleted."
+msgid "Delete locale"
 msgstr ""
 
-#: views.py:65
+#: views.py:64
 msgid "Are you sure you want to delete this locale?"
 msgstr ""
 
-#: views.py:71
+#: views.py:70
 msgid "This locale cannot be deleted because there are no other locales."
 msgstr ""
 
-#: views.py:77
+#: views.py:76
 msgid ""
 "This locale cannot be deleted because there are pages and/or other objects "
 "using it."

wagtail/locales/views.py

@@ -54,7 +54,6 @@ class CreateView(generic.CreateView):
 class EditView(generic.EditView):
     success_message = gettext_lazy("Locale '%(object)s' updated.")
     error_message = gettext_lazy("The locale could not be saved due to errors.")
-    delete_item_label = gettext_lazy("Delete locale")
     context_object_name = "locale"
     queryset = Locale.all_objects.all()
 
@@ -104,6 +103,10 @@ class LocaleViewSet(ModelViewSet):
     edit_view_class = EditView
     delete_view_class = DeleteView
 
+    # It does not make sense to copy Locale objects as they only contain the
+    # language code and are meant to be unique.
+    copy_view_enabled = False
+
     template_prefix = "wagtaillocales/"
 
     def get_common_view_kwargs(self, **kwargs):

wagtail/migrations/0089_log_entry_data_json_null_to_object.py

@@ -1,6 +1,5 @@
 # Generated by Django 4.2.3 on 2023-07-31 11:00
 
-from django import VERSION as DJANGO_VERSION
 from django.db import migrations, models
 
 
@@ -8,12 +7,7 @@ def replace_json_null_with_empty_object(apps, schema_editor):
     ModelLogEntry = apps.get_model("wagtailcore.ModelLogEntry")
     PageLogEntry = apps.get_model("wagtailcore.PageLogEntry")
 
-    # https://github.com/django/django/pull/16245
-    # The way to express a JSON `null` value was changed in Django 4.2.
-    if DJANGO_VERSION >= (4, 2):
-        null = models.Value(None, models.JSONField())
-    else:
-        null = models.Value("null")
+    null = models.Value(None, models.JSONField())
 
     ModelLogEntry.objects.filter(data=null).update(data={})
     PageLogEntry.objects.filter(data=null).update(data={})

wagtail/models/__init__.py

@@ -193,7 +193,7 @@ def get_default_page_content_type():
     return ContentType.objects.get_for_model(Page)
 
 
-@functools.lru_cache(maxsize=None)
+@functools.cache
 def get_streamfield_names(model_class):
     return tuple(
         field.name
@@ -235,6 +235,36 @@ class BasePageManager(models.Manager):
 
         return self.get(path=common_parent_path)
 
+    def annotate_parent_page(self, pages):
+        """
+        Annotates each page with its parent page. This is implemented as a
+        manager-only method instead of a QuerySet method so it can be used with
+        search results.
+
+        If given a QuerySet, this method will evaluate it. Only use this method
+        when you are ready to consume the queryset, e.g. after pagination has
+        been applied. This is typically done in the view's `get_context_data`
+        using `context["object_list"]`.
+
+        This method does not return a new queryset, but modifies the existing one,
+        to ensure any references to the queryset in the view's context are updated
+        (e.g. when using `context_object_name`).
+        """
+        parent_page_paths = {
+            Page._get_parent_path_from_path(page.path) for page in pages
+        }
+        parent_pages_by_path = {
+            page.path: page
+            for page in Page.objects.filter(path__in=parent_page_paths).specific(
+                defer=True
+            )
+        }
+        for page in pages:
+            parent_page = parent_pages_by_path.get(
+                Page._get_parent_path_from_path(page.path)
+            )
+            page._parent_page = parent_page
+
 
 PageManager = BasePageManager.from_queryset(PageQuerySet)
 
@@ -642,7 +672,7 @@ class DraftStateMixin(models.Model):
 
     def get_lock(self):
         # Scheduled publishing lock should take precedence over other locks
-        if self.scheduled_revision:
+        if self.approved_schedule:
             return ScheduledForPublishLock(self)
         return super().get_lock()
 
@@ -775,6 +805,26 @@ class PreviewableMixin:
     full_url = property(get_full_url)
 
     DEFAULT_PREVIEW_MODES = [("", _("Default"))]
+    DEFAULT_PREVIEW_SIZES = [
+        {
+            "name": "mobile",
+            "icon": "mobile-alt",
+            "device_width": 375,
+            "label": _("Preview in mobile size"),
+        },
+        {
+            "name": "tablet",
+            "icon": "tablet-alt",
+            "device_width": 768,
+            "label": _("Preview in tablet size"),
+        },
+        {
+            "name": "desktop",
+            "icon": "desktop",
+            "device_width": 1280,
+            "label": _("Preview in desktop size"),
+        },
+    ]
 
     @property
     def preview_modes(self):
@@ -798,6 +848,43 @@ class PreviewableMixin:
         """
         return self.preview_modes[0][0]
 
+    @property
+    def preview_sizes(self):
+        """
+        A list of dictionaries, each representing a preview size option for this object.
+        Override this property to customize the preview sizes.
+        Each dictionary in the list should include the following keys:
+
+        - ``name``: A string representing the internal name of the preview size.
+        - ``icon``: A string specifying the icon's name for the preview size button.
+        - ``device_width``: An integer indicating the device's width in pixels.
+        - ``label``: A string for the aria label on the preview size button.
+
+        .. code-block:: python
+
+            @property
+            def preview_sizes(self):
+                return [
+                    {
+                        "name": "mobile",
+                        "icon": "mobile-icon",
+                        "device_width": 320,
+                        "label": "Preview in mobile size"
+                    },
+                    # Add more preview size dictionaries as needed.
+                ]
+        """
+        return PreviewableMixin.DEFAULT_PREVIEW_SIZES
+
+    @property
+    def default_preview_size(self):
+        """
+        The default preview size name to use in live preview.
+        Defaults to ``"mobile"``, which is the first one defined in ``preview_sizes``.
+        If ``preview_sizes`` is empty, an ``IndexError`` will be raised.
+        """
+        return self.preview_sizes[0]["name"]
+
     def is_previewable(self):
         """Returns ``True`` if at least one preview mode is specified in ``preview_modes``."""
         return bool(self.preview_modes)
@@ -1295,7 +1382,7 @@ class Page(AbstractPage, index.Indexed, ClusterableModel, metaclass=PageBase):
     private_page_options = ["password", "groups", "login"]
 
     @staticmethod
-    def route_for_request(request: "HttpRequest", path: str) -> RouteResult | None:
+    def route_for_request(request: HttpRequest, path: str) -> RouteResult | None:
         """
         Find the page route for the given HTTP request object, and URL path. The route
         result (`page`, `args`, and `kwargs`) will be cached via
@@ -1322,7 +1409,7 @@ class Page(AbstractPage, index.Indexed, ClusterableModel, metaclass=PageBase):
         return request._wagtail_route_for_request
 
     @staticmethod
-    def find_for_request(request: "HttpRequest", path: str) -> "Page" | None:
+    def find_for_request(request: HttpRequest, path: str) -> Page | None:
         """
         Find the page for the given HTTP request object, and URL path. The full
         page route will be cached via `request._wagtail_route_for_request`
@@ -2792,12 +2879,20 @@ class RevisionQuerySet(models.QuerySet):
         return self.exclude(self.page_revisions_q())
 
     def for_instance(self, instance):
-        return self.filter(
-            content_type=ContentType.objects.get_for_model(
-                instance, for_concrete_model=False
-            ),
-            object_id=str(instance.pk),
-        )
+        try:
+            # Use RevisionMixin.get_base_content_type() if available
+            return self.filter(
+                base_content_type=instance.get_base_content_type(),
+                object_id=str(instance.pk),
+            )
+        except AttributeError:
+            # Fallback to ContentType for the model
+            return self.filter(
+                content_type=ContentType.objects.get_for_model(
+                    instance, for_concrete_model=False
+                ),
+                object_id=str(instance.pk),
+            )
 
 
 class RevisionsManager(models.Manager.from_queryset(RevisionQuerySet)):
@@ -3228,10 +3323,13 @@ class PagePermissionTester:
 
     def can_reorder_children(self):
         """
-        Keep reorder permissions the same as publishing, since it immediately affects published pages
-        (and the use-cases for a non-admin needing to do it are fairly obscure...)
+        Reorder permission checking is similar to publishing a subpage, since it immediately
+        affects published pages. However, it shouldn't care about the 'creatability' of
+        page types, because the action only ever updates existing pages.
         """
-        return self.can_publish_subpage()
+        if not self.user.is_active:
+            return False
+        return self.user.is_superuser or ("publish" in self.permissions)
 
     def can_move(self):
         """
@@ -3251,7 +3349,17 @@ class PagePermissionTester:
 
         # reject moves that are forbidden by subpage_types / parent_page_types rules
         # (these rules apply to superusers too)
-        if not self.page.specific.can_move_to(destination):
+        # – but only check this if the page is not already under the target parent.
+        # If it already is, then the user is just reordering the page, and we want
+        # to allow it even if the page currently violates the subpage_type /
+        # parent_page_type rules. This can happen if it was either created before
+        # the rules were specified, or it was done programmatically (e.g. to
+        # predefine a set of pages and disallow the creation of new subpages by
+        # setting subpage_types = []).
+
+        if (not self.page.is_child_of(destination)) and (
+            not self.page.specific.can_move_to(destination)
+        ):
             return False
 
         # shortcut the trivial 'everything' / 'nothing' permissions

wagtail/models/audit_log.py

@@ -158,9 +158,7 @@ class BaseLogEntryManager(models.Manager):
                 content_type = ContentType.objects.get_for_id(
                     permission.content_type_id
                 )
-                if user.has_perm(
-                    "%s.%s" % (content_type.app_label, permission.codename)
-                ):
+                if user.has_perm(f"{content_type.app_label}.{permission.codename}"):
                     allowed_content_type_ids.add(permission.content_type_id)
 
             user._allowed_content_type_ids = allowed_content_type_ids

wagtail/models/i18n.py

@@ -1,5 +1,4 @@
 import uuid
-from typing import Dict
 
 from django.apps import apps
 from django.conf import settings
@@ -98,7 +97,7 @@ class Locale(models.Model):
     def __str__(self):
         return force_str(self.get_display_name())
 
-    def _get_language_info(self) -> Dict[str, str]:
+    def _get_language_info(self) -> dict[str, str]:
         return translation.get_language_info(self.language_code)
 
     @property

wagtail/project_template/Dockerfile

@@ -1,5 +1,5 @@
-# Use an official Python runtime based on Debian 10 "buster" as a parent image.
-FROM python:3.8.1-slim-buster
+# Use an official Python runtime based on Debian 12 "bookworm" as a parent image.
+FROM python:3.12-slim-bookworm
 
 # Add user that will be used in the container.
 RUN useradd wagtail
@@ -18,7 +18,7 @@ ENV PYTHONUNBUFFERED=1 \
 RUN apt-get update --yes --quiet && apt-get install --yes --quiet --no-install-recommends \
     build-essential \
     libpq-dev \
-    libmariadbclient-dev \
+    libmariadb-dev \
     libjpeg62-turbo-dev \
     zlib1g-dev \
     libwebp-dev \

wagtail/project_template/requirements.txt

@@ -1,2 +1,2 @@
-Django>=4.2,<5.1
-wagtail>=6.2,<6.3
+Django>=5.1,<5.2
+wagtail==6.3rc2

wagtail/query.py

@@ -1,16 +1,18 @@
 import posixpath
 import warnings
 from collections import defaultdict
-from typing import Any, Dict, Iterable, Tuple
+from collections.abc import Iterable
+from typing import Any
 
 from django.apps import apps
 from django.contrib.contenttypes.models import ContentType
 from django.db.models import CharField, Prefetch, Q
 from django.db.models.expressions import Exists, OuterRef
 from django.db.models.functions import Cast, Length, Substr
-from django.db.models.query import BaseIterable, ModelIterable
+from django.db.models.query import ModelIterable
 from treebeard.mp_tree import MP_NodeQuerySet
 
+from wagtail.models.i18n import Locale
 from wagtail.models.sites import Site
 from wagtail.search.queryset import SearchableQuerySetMixin
 
@@ -507,8 +509,19 @@ class PageQuerySet(SearchableQuerySetMixin, SpecificQuerySetMixin, TreeQuerySet)
             )
         )
 
+    def annotate_has_untranslated_locale(self):
+        return self.annotate(
+            _has_untranslated_locale=Exists(
+                Locale.objects.exclude(
+                    id__in=self.model.objects.filter(
+                        translation_key=OuterRef(OuterRef("translation_key"))
+                    ).values("locale_id")
+                )
+            )
+        )
+
 
-class SpecificIterable(BaseIterable):
+class SpecificIterable(ModelIterable):
     def __iter__(self):
         """
         Identify and return all specific items in a queryset, and return them
@@ -588,7 +601,7 @@ class SpecificIterable(BaseIterable):
                         setattr(item, annotation, value)
                 yield item
 
-    def _get_chunks(self, queryset) -> Iterable[Tuple[Dict[str, Any]]]:
+    def _get_chunks(self, queryset) -> Iterable[tuple[dict[str, Any]]]:
         if not self.chunked_fetch:
             # The entire result will be stored in memory, so there is no
             # benefit to splitting the result

wagtail/rich_text/__init__.py

@@ -1,7 +1,6 @@
 import re
 from functools import lru_cache
 from html import unescape
-from typing import List
 
 from django.core.validators import MaxLengthValidator
 from django.db.models import Model
@@ -132,7 +131,7 @@ class EntityHandler:
         return model._default_manager.get(id=attrs["id"])
 
     @classmethod
-    def get_many(cls, attrs_list: List[dict]) -> List[Model]:
+    def get_many(cls, attrs_list: list[dict]) -> list[Model]:
         model = cls.get_model()
         instance_ids = [attrs.get("id") for attrs in attrs_list]
         instances_by_id = model._default_manager.in_bulk(instance_ids)
@@ -148,7 +147,7 @@ class EntityHandler:
         raise NotImplementedError
 
     @classmethod
-    def expand_db_attributes_many(cls, attrs_list: List[dict]) -> List[str]:
+    def expand_db_attributes_many(cls, attrs_list: list[dict]) -> list[str]:
         """
         Given a list of attribute dicts from a list of entity tags stored in
         the database, return the real HTML representation of each one.

wagtail/rich_text/pages.py

@@ -1,5 +1,3 @@
-from typing import List
-
 from django.db.models import Model
 from django.utils.html import escape
 
@@ -15,7 +13,7 @@ class PageLinkHandler(LinkHandler):
         return Page
 
     @classmethod
-    def get_many(cls, attrs_list: List[dict]) -> List[Model]:
+    def get_many(cls, attrs_list: list[dict]) -> list[Model]:
         # Override LinkHandler.get_many to reduce database queries through the
         # use of PageQuerySet.specific() instead of QuerySet.in_bulk().
         instance_ids = [attrs.get("id") for attrs in attrs_list]
@@ -28,7 +26,7 @@ class PageLinkHandler(LinkHandler):
         return cls.expand_db_attributes_many([attrs])[0]
 
     @classmethod
-    def expand_db_attributes_many(cls, attrs_list: List[dict]) -> List[str]:
+    def expand_db_attributes_many(cls, attrs_list: list[dict]) -> list[str]:
         return [
             '<a href="%s">' % escape(page.localized.url) if page else "<a>"
             for page in cls.get_many(attrs_list)

wagtail/rich_text/rewriters.py

@@ -4,7 +4,7 @@ Utility classes for rewriting elements of HTML-like strings
 
 import re
 from collections import defaultdict
-from typing import Callable, Dict, List
+from typing import Callable
 
 from django.utils.functional import cached_property
 
@@ -101,7 +101,7 @@ class TagRewriter:
 
         return html
 
-    def extract_tags(self, html: str) -> Dict[str, List[TagMatch]]:
+    def extract_tags(self, html: str) -> dict[str, list[TagMatch]]:
         """Helper method to extract and group HTML tags and their attributes.
 
         Returns a dict of TagMatch objects, mapping tag types to a list of all TagMatch objects of that tag type.

wagtail/search/backends/database/mysql/query.py

@@ -1,5 +1,5 @@
 import re
-from typing import Any, List, Tuple, Union
+from typing import Any, Union
 
 from django.db.backends.base.base import BaseDatabaseWrapper
 from django.db.models.expressions import CombinedExpression, Expression, Value
@@ -166,7 +166,7 @@ class SearchQuery(SearchQueryCombinable, Expression):
         compiler: SQLCompiler,
         connection: BaseDatabaseWrapper,
         **extra_context: Any,
-    ) -> Tuple[str, List[Any]]:
+    ) -> tuple[str, list[Any]]:
         sql, params = compiler.compile(self.value)
         return (sql, params)
 
@@ -229,7 +229,7 @@ class MatchExpression(Expression):
     def __init__(
         self,
         query: SearchQueryCombinable,
-        columns: List[str] = None,
+        columns: list[str] = None,
         output_field: Field = BooleanField(),
     ) -> None:
         super().__init__(output_field=output_field)

wagtail/search/backends/database/sqlite/query.py

@@ -1,4 +1,4 @@
-from typing import Any, List, Tuple
+from typing import Any
 
 from django.db.backends.base.base import BaseDatabaseWrapper
 from django.db.models.expressions import CombinedExpression, Expression, Func, Value
@@ -149,7 +149,7 @@ class SearchQueryExpression(SearchQueryCombinable, Expression):
         compiler: SQLCompiler,
         connection: BaseDatabaseWrapper,
         **extra_context: Any,
-    ) -> Tuple[str, List[Any]]:
+    ) -> tuple[str, list[Any]]:
         sql, params = compiler.compile(self.value)
         return (sql, params)
 
@@ -172,7 +172,7 @@ class MatchExpression(Expression):
     )
     output_field = BooleanField()
 
-    def __init__(self, columns: List[str], query: SearchQueryCombinable) -> None:
+    def __init__(self, columns: list[str], query: SearchQueryCombinable) -> None:
         super().__init__(output_field=self.output_field)
         self.columns = columns
         self.query = query
@@ -211,7 +211,7 @@ class AndNot(SearchQuery):
         return f"<{repr(self.subquery_a)} AndNot {repr(self.subquery_b)}>"
 
 
-def normalize(search_query: SearchQuery) -> Tuple[SearchQuery]:
+def normalize(search_query: SearchQuery) -> tuple[SearchQuery]:
     """
     Turns this query into a normalized version.
     For example, And(Not(PlainText("Arepa")), PlainText("Crepe")) would be turned into AndNot(PlainText("Crepe"), PlainText("Arepa")): "Crepe AND NOT Arepa".
@@ -222,7 +222,7 @@ def normalize(search_query: SearchQuery) -> Tuple[SearchQuery]:
     if isinstance(search_query, PlainText):
         return search_query  # We can't normalize a PlainText.
     if isinstance(search_query, And):
-        normalized_subqueries: List[SearchQuery] = [
+        normalized_subqueries: list[SearchQuery] = [
             normalize(subquery) for subquery in search_query.subqueries
         ]  # This builds a list of normalized subqueries.
 
@@ -255,7 +255,7 @@ def normalize(search_query: SearchQuery) -> Tuple[SearchQuery]:
 
         return AndNot(And(not_negated_subqueries), Or(negated_subqueries))
     if isinstance(search_query, Or):
-        normalized_subqueries: List[SearchQuery] = [
+        normalized_subqueries: list[SearchQuery] = [
             normalize(subquery) for subquery in search_query.subqueries
         ]  # This builds a list of (subquery, negated) tuples.
 

wagtail/search/locale/en/LC_MESSAGES/django.po

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-08-07 10:06+0100\n"
+"POT-Creation-Date: 2024-10-21 17:53+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"

wagtail/sites/locale/en/LC_MESSAGES/django.po

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-08-07 10:06+0100\n"
+"POT-Creation-Date: 2024-10-21 17:53+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -68,15 +68,15 @@ msgstr ""
 msgid "Site '%(object)s' updated."
 msgstr ""
 
-#: views.py:44 views.py:50
-msgid "Delete site"
+#: views.py:48
+#, python-format
+msgid "Site '%(object)s' deleted."
 msgstr ""
 
 #: views.py:49
-#, python-format
-msgid "Site '%(object)s' deleted."
+msgid "Delete site"
 msgstr ""
 
-#: views.py:51
+#: views.py:50
 msgid "Are you sure you want to delete this site?"
 msgstr ""

wagtail/sites/views.py

@@ -41,7 +41,6 @@ class CreateView(generic.CreateView):
 class EditView(generic.EditView):
     success_message = _("Site '%(object)s' updated.")
     error_message = _("The site could not be saved due to errors.")
-    delete_item_label = _("Delete site")
     context_object_name = "site"
 
 

wagtail/snippets/action_menu.py

@@ -1,5 +1,6 @@
 """Handles rendering of the list of actions in the footer of the snippet create/edit views."""
 from functools import lru_cache
+from warnings import warn
 
 from django.conf import settings
 from django.contrib.admin.utils import quote
@@ -13,6 +14,7 @@ from wagtail import hooks
 from wagtail.admin.ui.components import Component
 from wagtail.models import DraftStateMixin, LockableMixin, WorkflowMixin
 from wagtail.snippets.permissions import get_permission_name
+from wagtail.utils.deprecation import RemovedInWagtail70Warning
 
 
 class ActionMenuItem(Component):
@@ -197,7 +199,6 @@ class UnpublishMenuItem(ActionMenuItem):
     label = _("Unpublish")
     name = "action-unpublish"
     icon_name = "download"
-    classname = "action-secondary"
 
     def is_shown(self, context):
         if context.get("locked_for_user"):
@@ -217,7 +218,14 @@ class DeleteMenuItem(ActionMenuItem):
     name = "action-delete"
     label = _("Delete")
     icon_name = "bin"
-    classname = "action-secondary"
+
+    def __init__(self, order=None):
+        super().__init__(order)
+        warn(
+            "DeleteMenuItem is deprecated. "
+            "The delete option is now provided via EditView.get_header_more_buttons().",
+            RemovedInWagtail70Warning,
+        )
 
     def is_shown(self, context):
         delete_permission = get_permission_name("delete", context["model"])
@@ -258,7 +266,6 @@ def get_base_snippet_action_menu_items(model):
     """
     menu_items = [
         SaveMenuItem(order=0),
-        DeleteMenuItem(order=10),
     ]
     if issubclass(model, DraftStateMixin):
         menu_items += [
@@ -341,6 +348,9 @@ class SnippetActionMenu:
             self.default_item = None
 
     def render_html(self):
+        if not self.default_item:
+            return ""
+
         rendered_menu_items = [
             menu_item.render_html(self.context) for menu_item in self.menu_items
         ]
@@ -358,7 +368,7 @@ class SnippetActionMenu:
 
     @cached_property
     def media(self):
-        media = Media()
+        media = self.default_item.media if self.default_item else Media()
         for item in self.menu_items:
             media += item.media
         return media