vellum-ai 0.13.19__py3-none-any.whl → 0.13.21__py3-none-any.whl

vellum_ee/workflows/display/workflows/tests/test_workflow_display.py

@@ -0,0 +1,65 @@
+import pytest
+
+from vellum.workflows.nodes.bases.base import BaseNode
+from vellum.workflows.workflows.base import BaseWorkflow
+from vellum_ee.workflows.display.workflows import VellumWorkflowDisplay
+from vellum_ee.workflows.display.workflows.get_vellum_workflow_display_class import get_workflow_display
+
+
+def test_serialize_workflow__node_referenced_in_workflow_outputs_not_in_graph():
+    # GIVEN a couple of nodes
+    class InNode(BaseNode):
+        pass
+
+    class OutNode(BaseNode):
+        class Outputs(BaseNode.Outputs):
+            foo: str
+
+    # AND A workflow that references the OutNode in its outputs but only has the InNode in its graph
+    class Workflow(BaseWorkflow):
+        graph = InNode
+
+        class Outputs(BaseWorkflow.Outputs):
+            final = OutNode.Outputs.foo
+
+    # WHEN we serialize it
+    workflow_display = get_workflow_display(
+        base_display_class=VellumWorkflowDisplay,
+        workflow_class=Workflow,
+    )
+
+    # THEN it should raise an error
+    with pytest.raises(ValueError) as exc_info:
+        workflow_display.serialize()
+
+    # AND the error message should be user friendly
+    assert str(exc_info.value) == "Failed to serialize output 'final': Reference to node 'OutNode' not found in graph."
+
+
+def test_serialize_workflow__workflow_outputs_reference_non_node_outputs():
+    # GIVEN one Workflow
+    class FirstWorkflow(BaseWorkflow):
+        class Outputs(BaseWorkflow.Outputs):
+            foo = "bar"
+
+    # AND A workflow that references the Outputs of that Workflow
+    class Workflow(BaseWorkflow):
+        class Outputs(BaseWorkflow.Outputs):
+            final = FirstWorkflow.Outputs.foo
+
+    # WHEN we serialize it
+    workflow_display = get_workflow_display(
+        base_display_class=VellumWorkflowDisplay,
+        workflow_class=Workflow,
+    )
+
+    # THEN it should raise an error
+    with pytest.raises(ValueError) as exc_info:
+        workflow_display.serialize()
+
+    # AND the error message should be user friendly
+    assert (
+        str(exc_info.value)
+        == """Failed to serialize output 'final': Reference to outputs \
+'test_serialize_workflow__workflow_outputs_reference_non_node_outputs.<locals>.FirstWorkflow.Outputs' is invalid."""
+    )

vellum_ee/workflows/display/workflows/vellum_workflow_display.py

@@ -129,14 +129,16 @@ class VellumWorkflowDisplay(
 
             if workflow_output.instance not in final_output_node_outputs:
                 # Create a synthetic terminal node only if there is no terminal node for this output
-                node_input = create_node_input(
-                    final_output_node_id,
-                    "node_input",
-                    # This is currently the wrapper node's output, but we want the wrapped node
-                    workflow_output.instance,
-                    self.display_context,
-                    workflow_output_display.node_input_id,
-                )
+                try:
+                    node_input = create_node_input(
+                        final_output_node_id,
+                        "node_input",
+                        # This is currently the wrapper node's output, but we want the wrapped node
+                        workflow_output.instance,
+                        self.display_context,
+                    )
+                except ValueError as e:
+                    raise ValueError(f"Failed to serialize output '{workflow_output.name}': {str(e)}") from e
 
                 source_node_display: Optional[BaseNodeDisplay]
                 first_rule = node_input.value.rules[0]
@@ -182,7 +184,7 @@ class VellumWorkflowDisplay(
 
                     synthetic_output_edges.append(
                         {
-                            "id": str(workflow_output_display.edge_id),
+                            "id": str(uuid4_from_hash(f"{self.workflow_id}|edge_id|{workflow_output_display.name}")),
                             "source_node_id": str(source_node_display.node_id),
                             "source_handle_id": str(source_handle_id),
                             "target_node_id": str(workflow_output_display.node_id),
@@ -323,26 +325,20 @@ class VellumWorkflowDisplay(
                 name=overrides.name,
                 label=overrides.label,
                 node_id=overrides.node_id,
-                node_input_id=overrides.node_input_id,
                 target_handle_id=overrides.target_handle_id,
-                edge_id=overrides.edge_id,
                 display_data=overrides.display_data,
             )
 
         output_id = uuid4_from_hash(f"{self.workflow_id}|id|{output.name}")
-        edge_id = uuid4_from_hash(f"{self.workflow_id}|edge_id|{output.name}")
         node_id = uuid4_from_hash(f"{self.workflow_id}|node_id|{output.name}")
-        node_input_id = uuid4_from_hash(f"{self.workflow_id}|node_input_id|{output.name}")
         target_handle_id = uuid4_from_hash(f"{self.workflow_id}|target_handle_id|{output.name}")
 
         return WorkflowOutputVellumDisplay(
             id=output_id,
             node_id=node_id,
-            node_input_id=node_input_id,
             name=output.name,
             label="Final Output",
             target_handle_id=target_handle_id,
-            edge_id=edge_id,
             display_data=NodeDisplayData(),
         )
 

vellum_ee/workflows/tests/local_workflow/display/workflow.py

@@ -48,11 +48,9 @@ class WorkflowDisplay(VellumWorkflowDisplay[Workflow]):
         Workflow.Outputs.final_output: WorkflowOutputVellumDisplayOverrides(
             id=UUID("5469b810-6ea6-4362-9e79-e360d44a1405"),
             node_id=UUID("f3ef4b2b-fec9-4026-9cc6-e5eac295307f"),
-            node_input_id=UUID("fe6cba85-2423-4b5e-8f85-06311a8be5fb"),
             name="final-output",
             label="Final Output",
             target_handle_id=UUID("3ec34f6e-da48-40d5-a65b-a48fefa75763"),
             display_data=NodeDisplayData(position=NodeDisplayPosition(x=2750, y=210), width=459, height=234),
-            edge_id=UUID("417c56a4-cdc1-4f9d-a10c-b535163f51e8"),
         )
     }