vectara-agentic 0.4.0__py3-none-any.whl → 0.4.2__py3-none-any.whl

tests/conftest.py

@@ -19,6 +19,7 @@ from vectara_agentic.types import AgentType, ModelProvider
 # Common Test Functions
 # ========================================
 
+
 def mult(x: float, y: float) -> float:
     """Multiply two numbers - common test function used across multiple test files."""
     return x * y
@@ -37,7 +38,9 @@ def add(x: float, y: float) -> float:
 STANDARD_TEST_TOPIC = "AI topic"
 
 # Standard test instructions used across most tests
-STANDARD_TEST_INSTRUCTIONS = "Always do as your father tells you, if your mother agrees!"
+STANDARD_TEST_INSTRUCTIONS = (
+    "Always do as your father tells you, if your mother agrees!"
+)
 
 # Alternative instructions for specific tests
 WORKFLOW_TEST_INSTRUCTIONS = "You are a helpful AI assistant."
@@ -119,19 +122,19 @@ react_config_groq = AgentConfig(
 private_llm_react_config = AgentConfig(
     agent_type=AgentType.REACT,
     main_llm_provider=ModelProvider.PRIVATE,
-    main_llm_model_name="gpt-4o",
+    main_llm_model_name="gpt-4.1-mini",
     private_llm_api_base="http://localhost:8000/v1",
     tool_llm_provider=ModelProvider.PRIVATE,
-    tool_llm_model_name="gpt-4o",
+    tool_llm_model_name="gpt-4.1-mini",
 )
 
 private_llm_fc_config = AgentConfig(
     agent_type=AgentType.FUNCTION_CALLING,
     main_llm_provider=ModelProvider.PRIVATE,
-    main_llm_model_name="gpt-4.1",
+    main_llm_model_name="gpt-4.1-mini",
     private_llm_api_base="http://localhost:8000/v1",
     tool_llm_provider=ModelProvider.PRIVATE,
-    tool_llm_model_name="gpt-4.1",
+    tool_llm_model_name="gpt-4.1-mini",
 )
 
 
@@ -139,6 +142,7 @@ private_llm_fc_config = AgentConfig(
 # Error Detection and Testing Utilities
 # ========================================
 
+
 def is_rate_limited(response_text: str) -> bool:
     """
     Check if a response indicates a rate limit error from any LLM provider.

tests/run_tests.py

@@ -34,6 +34,9 @@ def suppress_pydantic_warnings():
     resource_patterns = [
         ".*unclosed transport.*",
         ".*unclosed <socket\\.socket.*",
+        ".*unclosed event loop.*",
+        ".*unclosed resource <TCPTransport.*",
+        ".*Implicitly cleaning up <TemporaryDirectory.*",
     ]
 
     for pattern in pydantic_patterns:

tests/test_agent.py

@@ -7,22 +7,42 @@ import threading
 from datetime import date
 
 from vectara_agentic.agent import Agent, AgentType
-from vectara_agentic.agent_core.utils.prompt_formatting import format_prompt
+from vectara_agentic.agent_core.factory import format_prompt
 from vectara_agentic.agent_config import AgentConfig
 from vectara_agentic.types import ModelProvider, ObserverType
 from vectara_agentic.tools import ToolsFactory
 
 from vectara_agentic.agent_core.prompts import GENERAL_INSTRUCTIONS
-
-
-def mult(x: float, y: float) -> float:
-    "Multiply two numbers"
-    return x * y
+from conftest import mult, STANDARD_TEST_TOPIC, STANDARD_TEST_INSTRUCTIONS
 
 
 ARIZE_LOCK = threading.Lock()
 
 class TestAgentPackage(unittest.TestCase):
+    def setUp(self):
+        self.agents_to_cleanup = []
+
+    def tearDown(self):
+        import gc
+        import asyncio
+
+        for agent in self.agents_to_cleanup:
+            if hasattr(agent, 'cleanup'):
+                agent.cleanup()
+
+        # Force garbage collection to clean up any remaining references
+        gc.collect()
+
+        # Cancel any remaining asyncio tasks without closing the event loop
+        try:
+            loop = asyncio.get_event_loop()
+            if not loop.is_closed():
+                pending = asyncio.all_tasks(loop)
+                for task in pending:
+                    task.cancel()
+        except RuntimeError:
+            pass
+
     def test_get_prompt(self):
         prompt_template = "{chat_topic} on {today} with {custom_instructions}"
         topic = "Programming"
@@ -38,12 +58,11 @@ class TestAgentPackage(unittest.TestCase):
 
     def test_agent_init(self):
         tools = [ToolsFactory().create_tool(mult)]
-        topic = "AI"
-        custom_instructions = "Always do as your mother tells you!"
-        agent = Agent(tools, topic, custom_instructions)
+        agent = Agent(tools, STANDARD_TEST_TOPIC, STANDARD_TEST_INSTRUCTIONS)
+        self.agents_to_cleanup.append(agent)
         self.assertEqual(agent.agent_type, AgentType.FUNCTION_CALLING)
-        self.assertEqual(agent._topic, topic)
-        self.assertEqual(agent._custom_instructions, custom_instructions)
+        self.assertEqual(agent._topic, STANDARD_TEST_TOPIC)
+        self.assertEqual(agent._custom_instructions, STANDARD_TEST_INSTRUCTIONS)
 
         # To run this test, you must have appropriate API key in your environment
         self.assertEqual(
@@ -56,8 +75,6 @@ class TestAgentPackage(unittest.TestCase):
     def test_agent_config(self):
         with ARIZE_LOCK:
             tools = [ToolsFactory().create_tool(mult)]
-            topic = "AI topic"
-            instructions = "Always do as your father tells you, if your mother agrees!"
             config = AgentConfig(
                 agent_type=AgentType.REACT,
                 main_llm_provider=ModelProvider.ANTHROPIC,
@@ -69,12 +86,13 @@ class TestAgentPackage(unittest.TestCase):
 
             agent = Agent(
                 tools=tools,
-                topic=topic,
-                custom_instructions=instructions,
+                topic=STANDARD_TEST_TOPIC,
+                custom_instructions=STANDARD_TEST_INSTRUCTIONS,
                 agent_config=config
             )
-            self.assertEqual(agent._topic, topic)
-            self.assertEqual(agent._custom_instructions, instructions)
+            self.agents_to_cleanup.append(agent)
+            self.assertEqual(agent._topic, STANDARD_TEST_TOPIC)
+            self.assertEqual(agent._custom_instructions, STANDARD_TEST_INSTRUCTIONS)
             self.assertEqual(agent.agent_type, AgentType.REACT)
             self.assertEqual(agent.agent_config.observer, ObserverType.ARIZE_PHOENIX)
             self.assertEqual(agent.agent_config.main_llm_provider, ModelProvider.ANTHROPIC)
@@ -89,19 +107,21 @@ class TestAgentPackage(unittest.TestCase):
             )
 
     def test_multiturn(self):
-        tools = [ToolsFactory().create_tool(mult)]
-        topic = "AI topic"
-        instructions = "Always do as your father tells you, if your mother agrees!"
-        agent = Agent(
-            tools=tools,
-            topic=topic,
-            custom_instructions=instructions,
-        )
+        with ARIZE_LOCK:
+            tools = [ToolsFactory().create_tool(mult)]
+            topic = "AI topic"
+            instructions = "Always do as your father tells you, if your mother agrees!"
+            agent = Agent(
+                tools=tools,
+                topic=topic,
+                custom_instructions=instructions,
+            )
+            self.agents_to_cleanup.append(agent)
 
-        agent.chat("What is 5 times 10. Only give the answer, nothing else")
-        agent.chat("what is 3 times 7. Only give the answer, nothing else")
-        res = agent.chat("multiply the results of the last two questions. Output only the answer.")
-        self.assertEqual(res.response, "1050")
+            agent.chat("What is 5 times 10. Only give the answer, nothing else")
+            agent.chat("what is 3 times 7. Only give the answer, nothing else")
+            res = agent.chat("multiply the results of the last two questions. Output only the answer.")
+            self.assertEqual(res.response, "1050")
 
     def test_from_corpus(self):
         agent = Agent.from_corpus(
@@ -111,6 +131,7 @@ class TestAgentPackage(unittest.TestCase):
             data_description="information",
             assistant_specialty="question answering",
         )
+        self.agents_to_cleanup.append(agent)
 
         self.assertIsInstance(agent, Agent)
         self.assertEqual(agent._topic, "question answering")
@@ -125,6 +146,11 @@ class TestAgentPackage(unittest.TestCase):
             custom_instructions=instructions,
             chat_history=[("What is 5 times 10", "50"), ("What is 3 times 7", "21")]
         )
+        self.agents_to_cleanup.append(agent)
+
+        data = agent.dumps()
+        clone = Agent.loads(data)
+        assert clone.memory.get() == agent.memory.get()
 
         res = agent.chat("multiply the results of the last two questions. Output only the answer.")
         self.assertEqual(res.response, "1050")
@@ -139,8 +165,10 @@ class TestAgentPackage(unittest.TestCase):
             assistant_specialty="question answering",
             general_instructions=general_instructions,
         )
+        self.agents_to_cleanup.append(agent)
 
         res = agent.chat("What is the meaning of the universe?")
+        print(f"Response: {res.response}")
         self.assertEqual(res.response, "I DIDN'T DO IT")
 
 

tests/test_agent_fallback_memory.py

@@ -0,0 +1,270 @@
+# Suppress external dependency warnings before any other imports
+import warnings
+
+warnings.simplefilter("ignore", DeprecationWarning)
+
+import unittest
+import threading
+
+from vectara_agentic.agent import Agent, AgentType
+from vectara_agentic.agent_config import AgentConfig
+from vectara_agentic.types import ModelProvider, AgentConfigType
+from vectara_agentic.tools import ToolsFactory
+
+from llama_index.core.llms import ChatMessage, MessageRole
+from conftest import mult, add
+
+
+ARIZE_LOCK = threading.Lock()
+
+
+class TestAgentFallbackMemoryConsistency(unittest.TestCase):
+    """Test memory consistency between main and fallback agents"""
+
+    def setUp(self):
+        """Set up test fixtures"""
+        self.tools = [ToolsFactory().create_tool(mult), ToolsFactory().create_tool(add)]
+        self.topic = "Mathematics"
+        self.custom_instructions = "You are a helpful math assistant."
+
+        # Main agent config
+        self.main_config = AgentConfig(
+            agent_type=AgentType.FUNCTION_CALLING,
+            main_llm_provider=ModelProvider.ANTHROPIC,
+        )
+
+        # Fallback agent config
+        self.fallback_config = AgentConfig(
+            agent_type=AgentType.REACT, main_llm_provider=ModelProvider.ANTHROPIC
+        )
+
+        self.session_id = "test-fallback-session-123"
+
+    def test_memory_consistency_on_agent_creation(self):
+        """Test that main and fallback agents are created with the same memory content"""
+        agent = Agent(
+            tools=self.tools,
+            topic=self.topic,
+            custom_instructions=self.custom_instructions,
+            agent_config=self.main_config,
+            fallback_agent_config=self.fallback_config,
+            session_id=self.session_id,
+        )
+
+        # Add some memory before creating the agents
+        test_messages = [
+            ChatMessage(role=MessageRole.USER, content="What is 2*3?"),
+            ChatMessage(role=MessageRole.ASSISTANT, content="2*3 = 6"),
+        ]
+        agent.memory.put_messages(test_messages)
+
+        # Verify both agents have memory with the same content
+        # Memory is managed by the main Agent class, not individual agent instances
+        main_memory = agent.memory.get()
+        fallback_memory = agent.memory.get()  # Both access the same memory
+
+        self.assertEqual(len(main_memory), 2)
+        self.assertEqual(len(fallback_memory), 2)
+        self.assertEqual(main_memory[0].content, "What is 2*3?")
+        self.assertEqual(fallback_memory[0].content, "What is 2*3?")
+
+        # Verify session_id consistency
+        # Memory is managed by the main Agent class
+        self.assertEqual(agent.memory.chat_store_key, self.session_id)
+
+    def test_memory_sync_during_agent_switching(self):
+        """Test that memory remains consistent when switching between main and fallback agents"""
+        agent = Agent(
+            tools=self.tools,
+            topic=self.topic,
+            custom_instructions=self.custom_instructions,
+            agent_config=self.main_config,
+            fallback_agent_config=self.fallback_config,
+            session_id=self.session_id,
+        )
+
+        # Start with main agent
+        self.assertEqual(agent.agent_config_type, AgentConfigType.DEFAULT)
+
+        # Add initial memory
+        initial_messages = [
+            ChatMessage(role=MessageRole.USER, content="Initial question"),
+            ChatMessage(role=MessageRole.ASSISTANT, content="Initial response"),
+        ]
+        agent.memory.put_messages(initial_messages)
+
+        # Access main agent to ensure it's loaded
+        main_memory_before = agent.memory.get()  # Memory managed by main Agent class
+        self.assertEqual(len(main_memory_before), 2)
+
+        # Switch to fallback agent (this should clear the fallback agent instance)
+        agent._switch_agent_config()
+        self.assertEqual(agent.agent_config_type, AgentConfigType.FALLBACK)
+
+        # Access fallback agent (should be recreated with current memory)
+        fallback_memory = agent.memory.get()  # Memory managed by main Agent class
+
+        # Verify fallback agent has the same memory content
+        self.assertEqual(len(fallback_memory), 2)
+        self.assertEqual(fallback_memory[0].content, "Initial question")
+        self.assertEqual(fallback_memory[1].content, "Initial response")
+
+        # Add more memory while using fallback agent
+        additional_messages = [
+            ChatMessage(role=MessageRole.USER, content="Fallback question"),
+            ChatMessage(role=MessageRole.ASSISTANT, content="Fallback response"),
+        ]
+        agent.memory.put_messages(additional_messages)
+
+        # Switch back to main agent (this should clear the main agent instance)
+        agent._switch_agent_config()
+        self.assertEqual(agent.agent_config_type, AgentConfigType.DEFAULT)
+
+        # Verify recreated main agent now has all the memory including what was added during fallback
+        main_memory_after = agent.memory.get()  # Memory managed by main Agent class
+        self.assertEqual(len(main_memory_after), 4)
+        self.assertEqual(main_memory_after[2].content, "Fallback question")
+        self.assertEqual(main_memory_after[3].content, "Fallback response")
+
+    def test_memory_sync_on_clear_memory(self):
+        """Test that memory clearing resets agent instances for consistency"""
+        agent = Agent(
+            tools=self.tools,
+            topic=self.topic,
+            custom_instructions=self.custom_instructions,
+            agent_config=self.main_config,
+            fallback_agent_config=self.fallback_config,
+            session_id=self.session_id,
+        )
+
+        # Add memory
+        test_messages = [
+            ChatMessage(role=MessageRole.USER, content="Test question"),
+            ChatMessage(role=MessageRole.ASSISTANT, content="Test response"),
+        ]
+        agent.memory.put_messages(test_messages)
+
+        # Verify memory exists
+        # Memory is managed by the main Agent class
+        self.assertEqual(len(agent.memory.get()), 2)
+        self.assertEqual(len(agent.memory.get()), 2)  # Both access same memory
+
+        # Clear memory (should reset agent instances)
+        agent.clear_memory()
+
+        # Verify core memory is cleared
+        self.assertEqual(len(agent.memory.get()), 0)
+
+        # Verify agent instances were reset (None)
+        self.assertIsNone(agent._agent)
+        self.assertIsNone(agent._fallback_agent)
+
+        # Verify new agents have cleared memory
+        # Memory is managed by the main Agent class
+        self.assertEqual(len(agent.memory.get()), 0)
+        self.assertEqual(len(agent.memory.get()), 0)  # Both access same memory
+
+    def test_memory_consistency_after_serialization(self):
+        """Test that memory consistency is maintained after serialization/deserialization"""
+        agent = Agent(
+            tools=self.tools,
+            topic=self.topic,
+            custom_instructions=self.custom_instructions,
+            agent_config=self.main_config,
+            fallback_agent_config=self.fallback_config,
+            session_id=self.session_id,
+        )
+
+        # Add memory and load both agents
+        test_messages = [
+            ChatMessage(role=MessageRole.USER, content="Serialization test"),
+            ChatMessage(role=MessageRole.ASSISTANT, content="Serialization response"),
+        ]
+        agent.memory.put_messages(test_messages)
+
+        # Access both agents
+        _ = agent.agent
+        _ = agent.fallback_agent
+
+        # Serialize and deserialize
+        serialized_data = agent.dumps()
+        restored_agent = Agent.loads(serialized_data)
+
+        # Verify memory is preserved and consistent
+        self.assertEqual(restored_agent.session_id, self.session_id)
+        self.assertEqual(len(restored_agent.memory.get()), 2)
+
+        # Verify memory consistency
+        # Individual agent instances don't have .memory attribute - memory is managed by main Agent class
+        # Both agent instances should use the same memory from the main Agent
+
+        main_memory = restored_agent.memory.get()
+        fallback_memory = restored_agent.memory.get()  # Both access same memory
+
+        self.assertEqual(len(main_memory), 2)
+        self.assertEqual(len(fallback_memory), 2)
+        self.assertEqual(main_memory[0].content, "Serialization test")
+        self.assertEqual(fallback_memory[0].content, "Serialization test")
+
+    def test_session_id_consistency_across_agents(self):
+        """Test that session_id is consistent between main and fallback agents"""
+        agent = Agent(
+            tools=self.tools,
+            topic=self.topic,
+            custom_instructions=self.custom_instructions,
+            agent_config=self.main_config,
+            fallback_agent_config=self.fallback_config,
+            session_id=self.session_id,
+        )
+
+        # Verify main agent session_id consistency
+        self.assertEqual(agent.session_id, self.session_id)
+        self.assertEqual(agent.memory.chat_store_key, self.session_id)
+
+        # Verify session_id consistency across all agents
+        # Memory is managed by the main Agent class
+        self.assertEqual(agent.memory.chat_store_key, self.session_id)
+        self.assertEqual(
+            agent.memory.chat_store_key, self.session_id
+        )  # Both access same memory
+
+    def test_agent_recreation_on_switch(self):
+        """Test that agents are properly recreated when switching configurations"""
+        agent = Agent(
+            tools=self.tools,
+            topic=self.topic,
+            custom_instructions=self.custom_instructions,
+            agent_config=self.main_config,
+            fallback_agent_config=self.fallback_config,
+            session_id=self.session_id,
+        )
+
+        # Load main agent
+        original_main_agent = agent.agent
+        self.assertIsNotNone(original_main_agent)
+
+        # Load fallback agent
+        original_fallback_agent = agent.fallback_agent
+        self.assertIsNotNone(original_fallback_agent)
+
+        # Switch to fallback - should clear the fallback agent instance
+        agent._switch_agent_config()
+        self.assertEqual(agent.agent_config_type, AgentConfigType.FALLBACK)
+        self.assertIsNone(agent._fallback_agent)  # Should be cleared
+
+        # Access fallback agent again - should be a new instance
+        new_fallback_agent = agent.fallback_agent
+        self.assertIsNot(new_fallback_agent, original_fallback_agent)
+
+        # Switch back to main - should clear the main agent instance
+        agent._switch_agent_config()
+        self.assertEqual(agent.agent_config_type, AgentConfigType.DEFAULT)
+        self.assertIsNone(agent._agent)  # Should be cleared
+
+        # Access main agent again - should be a new instance
+        new_main_agent = agent.agent
+        self.assertIsNot(new_main_agent, original_main_agent)
+
+
+if __name__ == "__main__":
+    unittest.main()