umap-project 2.1.2__py3-none-any.whl → 2.2.0__py3-none-any.whl

umap/tests/integration/test_edit_map.py

@@ -0,0 +1,202 @@
+import re
+
+from playwright.sync_api import expect
+
+from umap.models import DataLayer, Map
+
+from ..base import DataLayerFactory
+
+
+def test_can_edit_name(page, live_server, tilelayer):
+    page.goto(f"{live_server.url}/en/map/new/")
+
+    page.get_by_title("Edit map name and caption").click()
+    name_input = page.locator('.map-metadata input[name="name"]')
+    expect(name_input).to_be_visible()
+    name_input.click()
+    name_input.press("Control+a")
+    name_input.fill("New map name")
+    expect(page.locator(".umap-main-edit-toolbox .map-name").nth(0)).to_have_text(
+        "New map name"
+    )
+
+
+def test_can_edit_name_on_click_on_toolbar(page, live_server, tilelayer):
+    page.goto(f"{live_server.url}/en/map/new/")
+    page.locator(".map-name").click()
+    name_input = page.locator('.map-metadata input[name="name"]')
+    expect(name_input).to_be_visible()
+
+
+def test_map_name_impacts_ui(live_server, page, tilelayer):
+    page.goto(f"{live_server.url}/en/map/new/")
+
+    gear_icon = page.get_by_title("Edit map name and caption")
+    expect(gear_icon).to_be_visible()
+    gear_icon.click()
+
+    name_input = page.locator("form").locator('input[name="name"]').first
+    expect(name_input).to_be_visible()
+
+    name_input.fill("something else")
+
+    expect(page.get_by_role("button", name="something else").nth(1)).to_be_visible()
+
+
+def test_zoomcontrol_impacts_ui(live_server, page, tilelayer):
+    page.goto(f"{live_server.url}/en/map/new/")
+
+    gear_icon = page.get_by_title("Map advanced properties")
+    expect(gear_icon).to_be_visible()
+    gear_icon.click()
+
+    # Should be visible by default
+    zoom_in = page.get_by_label("Zoom in")
+    zoom_out = page.get_by_label("Zoom out")
+
+    expect(zoom_in).to_be_visible()
+    expect(zoom_out).to_be_visible()
+
+    # Hide them
+    page.get_by_role("heading", name="User interface options").click()
+    hide_zoom_controls = (
+        page.locator("div")
+        .filter(has_text=re.compile(r"^Display the zoom control"))
+        .locator("label")
+        .nth(2)
+    )
+    hide_zoom_controls.click()
+
+    expect(zoom_in).to_be_hidden()
+    expect(zoom_out).to_be_hidden()
+
+
+def test_map_color_impacts_data(live_server, page, tilelayer):
+    page.goto(f"{live_server.url}/en/map/new/")
+
+    gear_icon = page.get_by_title("Map advanced properties")
+    expect(gear_icon).to_be_visible()
+    gear_icon.click()
+
+    # Click on the Draw a marker button on a new map.
+    create_marker_p1 = page.get_by_title("Draw a marker")
+    expect(create_marker_p1).to_be_visible()
+    create_marker_p1.click()
+
+    # Add a new marker
+    marker_pane_p1 = page.locator(".leaflet-marker-pane > div")
+    map_el = page.locator("#map")
+    map_el.click(position={"x": 200, "y": 200})
+    expect(marker_pane_p1).to_have_count(1)
+
+    # Change the default color
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator("#umap-feature-shape-properties").get_by_text("define").first.click()
+    page.get_by_title("Lime", exact=True).click()
+
+    # Assert the new color was used
+    marker_style = page.locator(".leaflet-marker-icon .icon_container").get_attribute(
+        "style"
+    )
+    assert "lime" in marker_style
+
+
+def test_limitbounds_impacts_ui(live_server, page, tilelayer):
+    page.goto(f"{live_server.url}/en/map/new/")
+
+    gear_icon = page.get_by_title("Map advanced properties")
+    expect(gear_icon).to_be_visible()
+    gear_icon.click()
+
+    page.get_by_role("heading", name="Limit bounds").click()
+    default_zoom_url = f"{live_server.url}/en/map/new/#5/51.110/7.053"
+    page.goto(default_zoom_url)
+    page.get_by_role("button", name="Use current bounds").click()
+
+    zoom_in = page.get_by_label("Zoom in")
+    zoom_out = page.get_by_label("Zoom out")
+
+    # It should be possible to zoom in
+    zoom_in.click()
+    page.wait_for_timeout(500)
+    assert page.url != default_zoom_url
+
+    # But not to zoom out of the window
+    zoom_out.click()  # back to normal
+    page.wait_for_timeout(500)
+    assert "leaflet-disabled" in zoom_out.get_attribute("class")
+
+
+def test_sortkey_impacts_datalayerindex(map, live_server, page):
+    # Create points with a "key" property.
+    # But we want them to sort by key (First, Second, Third)
+    DataLayerFactory(
+        map=map,
+        data={
+            "type": "FeatureCollection",
+            "features": [
+                {
+                    "type": "Feature",
+                    "geometry": {
+                        "type": "Point",
+                        "coordinates": [13.6, 48.5],
+                    },
+                    "properties": {"name": "Z First", "key": "1st Point"},
+                },
+                {
+                    "type": "Feature",
+                    "geometry": {
+                        "type": "Point",
+                        "coordinates": [13.7, 48.4],
+                    },
+                    "properties": {"name": "Y Second", "key": "2d Point"},
+                },
+                {
+                    "type": "Feature",
+                    "geometry": {
+                        "type": "Point",
+                        "coordinates": [13.5, 48.6],
+                    },
+                    "properties": {"name": "X Third", "key": "3rd Point"},
+                },
+            ],
+        },
+    )
+    map.edit_status = Map.ANONYMOUS
+    datalayer = map.datalayer_set.first()
+    datalayer.edit_status = DataLayer.ANONYMOUS
+    datalayer.save()
+    map.save()
+    page.goto(f"{live_server.url}{map.get_absolute_url()}")
+
+    # By default, features are sorted by name  (Third, Second, First)
+    page.get_by_role("button", name="See layers").click()
+    page.get_by_role("heading", name="Show/hide layer").locator("i").click()
+
+    first_listed_feature = page.locator(".umap-browser .datalayer ul > li").nth(0)
+    second_listed_feature = page.locator(".umap-browser .datalayer ul > li").nth(1)
+    third_listed_feature = page.locator(".umap-browser .datalayer ul > li").nth(2)
+    assert "X Third" == first_listed_feature.text_content()
+    assert "Y Second" == second_listed_feature.text_content()
+    assert "Z First" == third_listed_feature.text_content()
+
+    # Change the default sortkey to be "key"
+    page.get_by_role("button", name="Edit").click()
+    page.get_by_role("link", name="Map advanced properties").click()
+    page.get_by_role("heading", name="Default properties").click()
+
+    # Click "define"
+    page.locator(".panel .umap-field-sortKey .define").click()
+    page.locator('input[name="sortKey"]').click()
+    page.locator('input[name="sortKey"]').fill("key")
+
+    # Click the checkmark to apply the changes
+    page.locator(".panel .umap-field-sortKey .blur-button").click()
+
+    # Features should be sorted by key  (First, Second, Third)
+    first_listed_feature = page.locator(".umap-browser .datalayer ul > li").nth(0)
+    second_listed_feature = page.locator(".umap-browser .datalayer ul > li").nth(1)
+    third_listed_feature = page.locator(".umap-browser .datalayer ul > li").nth(2)
+    assert "Z First" == first_listed_feature.text_content()
+    assert "Y Second" == second_listed_feature.text_content()
+    assert "X Third" == third_listed_feature.text_content()

umap/tests/integration/test_edit_marker.py

@@ -0,0 +1,120 @@
+import platform
+from copy import deepcopy
+
+import pytest
+from playwright.sync_api import expect
+
+from ..base import DataLayerFactory
+
+pytestmark = pytest.mark.django_db
+
+DATALAYER_DATA = {
+    "type": "FeatureCollection",
+    "features": [
+        {
+            "type": "Feature",
+            "properties": {
+                "name": "test marker",
+                "description": "Some description",
+            },
+            "id": "QwNjg",
+            "geometry": {
+                "type": "Point",
+                "coordinates": [14.6889, 48.5529],
+            },
+        },
+    ],
+}
+
+
+@pytest.fixture
+def bootstrap(map, live_server):
+    DataLayerFactory(map=map, data=DATALAYER_DATA)
+
+
+def test_can_edit_on_shift_click(live_server, openmap, page, datalayer):
+    modifier = "Meta" if platform.system() == "Darwin" else "Control"
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    page.locator(".leaflet-marker-icon").click(modifiers=[modifier, "Shift"])
+    expect(page.get_by_role("heading", name="Layer properties")).to_be_visible()
+
+
+def test_marker_style_should_have_precedence(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+
+    # Change colour at layer level
+    page.get_by_role("link", name="Manage layers").click()
+    page.locator(".panel").get_by_title("Edit", exact=True).click()
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator(".umap-field-color .define").click()
+    expect(page.locator(".leaflet-marker-icon .icon_container")).to_have_css(
+        "background-color", "rgb(0, 0, 139)"
+    )
+    page.get_by_title("DarkRed").first.click()
+    expect(page.locator(".leaflet-marker-icon .icon_container")).to_have_css(
+        "background-color", "rgb(139, 0, 0)"
+    )
+
+    # Now change at marker level, it should take precedence
+    page.locator(".leaflet-marker-icon").click(modifiers=["Shift"])
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator("#umap-feature-shape-properties").get_by_text("define").first.click()
+    page.get_by_title("GoldenRod", exact=True).click()
+    expect(page.locator(".leaflet-marker-icon .icon_container")).to_have_css(
+        "background-color", "rgb(218, 165, 32)"
+    )
+
+    # Now change again at layer level again, it should not change the marker color
+    page.get_by_role("link", name="Manage layers").click()
+    page.locator(".panel").get_by_title("Edit", exact=True).click()
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator(".umap-field-color input").click()
+    page.get_by_title("DarkViolet").first.click()
+    expect(page.locator(".leaflet-marker-icon .icon_container")).to_have_css(
+        "background-color", "rgb(218, 165, 32)"
+    )
+
+
+def test_should_open_an_edit_toolbar_on_click(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    page.locator(".leaflet-marker-icon").click()
+    expect(page.get_by_role("link", name="Toggle edit mode")).to_be_visible()
+    expect(page.get_by_role("link", name="Delete this feature")).to_be_visible()
+
+
+def test_should_update_open_popup_on_edit(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}")
+    expect(page.locator(".umap-icon-active")).to_be_hidden()
+    page.locator(".leaflet-marker-icon").click()
+    expect(page.locator(".leaflet-popup-content-wrapper")).to_be_visible()
+    expect(page.get_by_role("heading", name="test marker")).to_be_visible()
+    expect(page.get_by_text("Some description")).to_be_visible()
+    page.get_by_role("button", name="Edit").click()
+    page.locator(".leaflet-marker-icon").click(modifiers=["Shift"])
+    page.locator('input[name="name"]').fill("test marker edited")
+    expect(page.get_by_role("heading", name="test marker edited")).to_be_visible()
+
+
+def test_should_follow_datalayer_style_when_changing_datalayer(
+    live_server, openmap, page
+):
+    data = deepcopy(DATALAYER_DATA)
+    data["_umap_options"] = {"color": "DarkCyan"}
+    DataLayerFactory(map=openmap, data=data)
+    DataLayerFactory(
+        map=openmap,
+        name="other datalayer",
+        data={
+            "type": "FeatureCollection",
+            "features": [],
+            "_umap_options": {"color": "DarkViolet"},
+        },
+    )
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    marker = page.locator(".leaflet-marker-icon .icon_container")
+    expect(marker).to_have_css("background-color", "rgb(0, 139, 139)")
+    # Change datalayer
+    marker.click()
+    page.get_by_role("link", name="Toggle edit mode (⇧+Click)").click()
+    page.locator(".umap-field-datalayer select").select_option(label="other datalayer")
+    expect(marker).to_have_css("background-color", "rgb(148, 0, 211)")

umap/tests/integration/test_edit_polygon.py

@@ -0,0 +1,122 @@
+import platform
+
+import pytest
+from playwright.sync_api import expect
+
+from ..base import DataLayerFactory
+
+pytestmark = pytest.mark.django_db
+
+DATALAYER_DATA = {
+    "type": "FeatureCollection",
+    "features": [
+        {
+            "type": "Feature",
+            "properties": {
+                "name": "name poly",
+            },
+            "id": "gyNzM",
+            "geometry": {
+                "type": "Polygon",
+                "coordinates": [
+                    [
+                        [11.25, 53.585984],
+                        [10.151367, 52.975108],
+                        [12.689209, 52.167194],
+                        [14.084473, 53.199452],
+                        [12.634277, 53.618579],
+                        [11.25, 53.585984],
+                        [11.25, 53.585984],
+                    ],
+                ],
+            },
+        },
+    ],
+}
+
+
+@pytest.fixture
+def bootstrap(map, live_server):
+    map.settings["properties"]["zoom"] = 6
+    map.settings["geometry"] = {
+        "type": "Point",
+        "coordinates": [8.429, 53.239],
+    }
+    map.save()
+    DataLayerFactory(map=map, data=DATALAYER_DATA)
+
+
+def test_can_edit_on_shift_click(live_server, openmap, page, datalayer):
+    modifier = "Meta" if platform.system() == "Darwin" else "Control"
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    page.locator(".leaflet-marker-icon").click(modifiers=[modifier, "Shift"])
+    expect(page.get_by_role("heading", name="Layer properties")).to_be_visible()
+
+
+def test_marker_style_should_have_precedence(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+
+    # Change colour at layer level
+    page.get_by_role("link", name="Manage layers").click()
+    page.locator(".panel").get_by_title("Edit", exact=True).click()
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator(".umap-field-color .define").click()
+    expect(page.locator(".leaflet-overlay-pane path[fill='DarkBlue']")).to_have_count(1)
+    page.get_by_title("DarkRed").first.click()
+    expect(page.locator(".leaflet-overlay-pane path[fill='DarkRed']")).to_have_count(1)
+
+    # Now change at polygon level, it should take precedence
+    page.locator("path").click(modifiers=["Shift"])
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator("#umap-feature-shape-properties").get_by_text("define").first.click()
+    page.get_by_title("GoldenRod", exact=True).first.click()
+    expect(page.locator(".leaflet-overlay-pane path[fill='GoldenRod']")).to_have_count(
+        1
+    )
+
+    # Now change again at layer level again, it should not change the marker color
+    page.get_by_role("link", name="Manage layers").click()
+    page.locator(".panel").get_by_title("Edit", exact=True).click()
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator(".umap-field-color input").click()
+    page.get_by_title("DarkViolet").first.click()
+    expect(page.locator(".leaflet-overlay-pane path[fill='GoldenRod']")).to_have_count(
+        1
+    )
+
+
+def test_should_open_an_edit_toolbar_on_click(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    page.locator("path").click()
+    expect(page.get_by_role("link", name="Toggle edit mode")).to_be_visible()
+    expect(page.get_by_role("link", name="Delete this feature")).to_be_visible()
+
+
+def test_can_remove_stroke(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    expect(page.locator(".leaflet-overlay-pane path[stroke='DarkBlue']")).to_have_count(
+        1
+    )
+    page.locator("path").click()
+    page.get_by_role("link", name="Toggle edit mode").click()
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator(".umap-field-stroke .define").first.click()
+    page.locator(".umap-field-stroke label").first.click()
+    expect(page.locator(".leaflet-overlay-pane path[stroke='DarkBlue']")).to_have_count(
+        0
+    )
+    expect(page.locator(".leaflet-overlay-pane path[stroke='none']")).to_have_count(1)
+
+
+def test_should_reset_style_on_cancel(live_server, openmap, page, bootstrap):
+    page.goto(f"{live_server.url}{openmap.get_absolute_url()}?edit")
+    page.locator("path").click(modifiers=["Shift"])
+    page.get_by_role("heading", name="Shape properties").click()
+    page.locator("#umap-feature-shape-properties").get_by_text("define").first.click()
+    page.get_by_title("GoldenRod", exact=True).first.click()
+    expect(page.locator(".leaflet-overlay-pane path[fill='GoldenRod']")).to_have_count(
+        1
+    )
+    page.once("dialog", lambda dialog: dialog.accept())
+    page.get_by_role("button", name="Cancel edits").click()
+    expect(page.locator(".leaflet-overlay-pane path[fill='DarkBlue']")).to_have_count(1)

umap/tests/integration/test_facets_browser.py

@@ -1,3 +1,5 @@
+import copy
+
 import pytest
 from playwright.sync_api import expect
 
@@ -11,12 +13,22 @@ DATALAYER_DATA1 = {
     "features": [
         {
             "type": "Feature",
-            "properties": {"mytype": "even", "name": "Point 2"},
+            "properties": {
+                "mytype": "even",
+                "name": "Point 2",
+                "mynumber": 10,
+                "mydate": "2024/04/14 12:19:17",
+            },
             "geometry": {"type": "Point", "coordinates": [0.065918, 48.385442]},
         },
         {
             "type": "Feature",
-            "properties": {"mytype": "odd", "name": "Point 1"},
+            "properties": {
+                "mytype": "odd",
+                "name": "Point 1",
+                "mynumber": 12,
+                "mydate": "2024/03/13 12:20:20",
+            },
             "geometry": {"type": "Point", "coordinates": [3.55957, 49.767074]},
         },
     ],
@@ -31,12 +43,22 @@ DATALAYER_DATA2 = {
     "features": [
         {
             "type": "Feature",
-            "properties": {"mytype": "even", "name": "Point 4"},
+            "properties": {
+                "mytype": "even",
+                "name": "Point 4",
+                "mynumber": 10,
+                "mydate": "2024/08/18 13:14:15",
+            },
             "geometry": {"type": "Point", "coordinates": [0.856934, 45.290347]},
         },
         {
             "type": "Feature",
-            "properties": {"mytype": "odd", "name": "Point 3"},
+            "properties": {
+                "mytype": "odd",
+                "name": "Point 3",
+                "mynumber": 14,
+                "mydate": "2024-04-14T10:19:17.000Z",
+            },
             "geometry": {"type": "Point", "coordinates": [4.372559, 47.945786]},
         },
     ],
@@ -46,19 +68,43 @@ DATALAYER_DATA2 = {
 }
 
 
-@pytest.fixture
-def bootstrap(map, live_server):
+DATALAYER_DATA3 = {
+    "type": "FeatureCollection",
+    "features": [
+        {
+            "type": "Feature",
+            "properties": {"name": "a polygon"},
+            "geometry": {
+                "type": "Polygon",
+                "coordinates": [
+                    [
+                        [2.12, 49.57],
+                        [1.08, 49.02],
+                        [2.51, 47.55],
+                        [3.19, 48.77],
+                        [2.12, 49.57],
+                    ]
+                ],
+            },
+        },
+    ],
+    "_umap_options": {"name": "Calque 2", "browsable": False},
+}
+
+
+def test_simple_facet_search(live_server, page, map):
     map.settings["properties"]["onLoadPanel"] = "facet"
-    map.settings["properties"]["facetKey"] = "mytype|My type"
+    map.settings["properties"]["facetKey"] = "mytype|My type,mynumber|My Number|number"
     map.settings["properties"]["showLabel"] = True
     map.save()
     DataLayerFactory(map=map, data=DATALAYER_DATA1)
     DataLayerFactory(map=map, data=DATALAYER_DATA2)
-
-
-def test_simple_facet_search(live_server, page, bootstrap, map):
-    page.goto(f"{live_server.url}{map.get_absolute_url()}")
+    DataLayerFactory(map=map, data=DATALAYER_DATA3)
+    page.goto(f"{live_server.url}{map.get_absolute_url()}#6/48.948/1.670")
     panel = page.locator(".umap-facet-search")
+    # From a non browsable datalayer, should not be impacted
+    paths = page.locator(".leaflet-overlay-pane path")
+    expect(paths).to_be_visible()
     expect(panel).to_be_visible()
     # Facet name
     expect(page.get_by_text("My type")).to_be_visible()
@@ -67,6 +113,7 @@ def test_simple_facet_search(live_server, page, bootstrap, map):
     odd = page.get_by_text("odd")
     expect(oven).to_be_visible()
     expect(odd).to_be_visible()
+    expect(paths).to_be_visible()
     markers = page.locator(".leaflet-marker-icon")
     expect(markers).to_have_count(4)
     # Tooltips
@@ -81,6 +128,80 @@ def test_simple_facet_search(live_server, page, bootstrap, map):
     expect(page.get_by_text("Point 4")).to_be_hidden()
     expect(page.get_by_text("Point 1")).to_be_visible()
     expect(page.get_by_text("Point 3")).to_be_visible()
+    expect(paths).to_be_visible
     # Now let's filter
     odd.click()
     expect(markers).to_have_count(4)
+    expect(paths).to_be_visible()
+
+    # Let's filter using the number facet
+    expect(page.get_by_text("My Number")).to_be_visible()
+    expect(page.get_by_label("Min")).to_have_value("10")
+    expect(page.get_by_label("Max")).to_have_value("14")
+    page.get_by_label("Min").fill("11")
+    page.keyboard.press("Tab")  # Move out of the input, so the "change" event is sent
+    expect(markers).to_have_count(2)
+    expect(paths).to_be_visible()
+    page.get_by_label("Max").fill("13")
+    page.keyboard.press("Tab")
+    expect(markers).to_have_count(1)
+
+    # Now let's combine
+    page.get_by_label("Min").fill("10")
+    page.keyboard.press("Tab")
+    expect(markers).to_have_count(3)
+    odd.click()
+    expect(markers).to_have_count(1)
+    expect(paths).to_be_visible()
+
+
+def test_date_facet_search(live_server, page, map):
+    map.settings["properties"]["onLoadPanel"] = "facet"
+    map.settings["properties"]["facetKey"] = "mydate|Date filter|date"
+    map.save()
+    DataLayerFactory(map=map, data=DATALAYER_DATA1)
+    DataLayerFactory(map=map, data=DATALAYER_DATA2)
+    page.goto(f"{live_server.url}{map.get_absolute_url()}")
+    markers = page.locator(".leaflet-marker-icon")
+    expect(markers).to_have_count(4)
+    expect(page.get_by_text("Date Filter")).to_be_visible()
+    expect(page.get_by_label("From")).to_have_value("2024-03-13")
+    expect(page.get_by_label("Until")).to_have_value("2024-08-18")
+    page.get_by_label("From").fill("2024-03-14")
+    expect(markers).to_have_count(3)
+    page.get_by_label("Until").fill("2024-08-17")
+    expect(markers).to_have_count(2)
+
+
+def test_choice_with_empty_value(live_server, page, map):
+    map.settings["properties"]["onLoadPanel"] = "facet"
+    map.settings["properties"]["facetKey"] = "mytype|My type"
+    map.save()
+    data = copy.deepcopy(DATALAYER_DATA1)
+    data["features"][0]["properties"]["mytype"] = ""
+    del data["features"][1]["properties"]["mytype"]
+    DataLayerFactory(map=map, data=data)
+    DataLayerFactory(map=map, data=DATALAYER_DATA2)
+    page.goto(f"{live_server.url}{map.get_absolute_url()}")
+    expect(page.get_by_text("<empty value>")).to_be_visible()
+    markers = page.locator(".leaflet-marker-icon")
+    expect(markers).to_have_count(4)
+    page.get_by_text("<empty value>").click()
+    expect(markers).to_have_count(2)
+
+
+def test_number_with_zero_value(live_server, page, map):
+    map.settings["properties"]["onLoadPanel"] = "facet"
+    map.settings["properties"]["facetKey"] = "mynumber|Filter|number"
+    map.save()
+    data = copy.deepcopy(DATALAYER_DATA1)
+    data["features"][0]["properties"]["mynumber"] = 0
+    DataLayerFactory(map=map, data=data)
+    DataLayerFactory(map=map, data=DATALAYER_DATA2)
+    page.goto(f"{live_server.url}{map.get_absolute_url()}")
+    expect(page.get_by_label("Min")).to_have_value("0")
+    expect(page.get_by_label("Max")).to_have_value("14")
+    page.get_by_label("Min").fill("1")
+    page.keyboard.press("Tab")  # Move out of the input, so the "change" event is sent
+    markers = page.locator(".leaflet-marker-icon")
+    expect(markers).to_have_count(3)