udata 14.4.1.dev7__py3-none-any.whl → 14.5.1.dev9__py3-none-any.whl

udata/tests/test_legal_mails.py

@@ -0,0 +1,359 @@
+import pytest
+from flask import url_for
+
+from udata.core.dataservices.factories import DataserviceFactory
+from udata.core.dataset.factories import DatasetFactory
+from udata.core.discussions.factories import DiscussionFactory, MessageDiscussionFactory
+from udata.core.organization.factories import OrganizationFactory
+from udata.core.reuse.factories import ReuseFactory
+from udata.core.user.factories import AdminFactory, UserFactory
+from udata.tests.api import APITestCase
+from udata.tests.helpers import capture_mails
+
+
+class AdminMailsOnDeleteTest(APITestCase):
+    """Test admin mails are sent on delete when send_legal_notice=True and user is sysadmin"""
+
+    modules = []
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataset_delete_with_mail_as_admin(self):
+        """Admin deleting dataset with send_legal_notice=True should send email to owner"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == owner.email
+        assert "deletion" in mails[0].subject.lower()
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataset_delete_without_mail_as_admin(self):
+        """Admin deleting dataset without send_mail should not send email"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            response = self.delete(url_for("api.dataset", dataset=dataset))
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataset_delete_with_mail_as_non_admin(self):
+        """Non-admin deleting their dataset with send_legal_notice=True should not send email"""
+        owner = self.login()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataset_delete_with_org_owner_sends_to_admins(self):
+        """Deleting org-owned dataset should send email to org admins"""
+        self.login(AdminFactory())
+        org_admin = UserFactory()
+        org = OrganizationFactory(members=[{"user": org_admin, "role": "admin"}])
+        dataset = DatasetFactory(organization=org)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == org_admin.email
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_reuse_delete_with_mail_as_admin(self):
+        """Admin deleting reuse with send_legal_notice=True should send email to owner"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        reuse = ReuseFactory(owner=owner)
+
+        with capture_mails() as mails:
+            response = self.delete(url_for("api.reuse", reuse=reuse) + "?send_legal_notice=true")
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == owner.email
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_reuse_delete_without_mail_as_admin(self):
+        """Admin deleting reuse without send_mail should not send email"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        reuse = ReuseFactory(owner=owner)
+
+        with capture_mails() as mails:
+            response = self.delete(url_for("api.reuse", reuse=reuse))
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataservice_delete_with_mail_as_admin(self):
+        """Admin deleting dataservice with send_legal_notice=True should send email to owner"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataservice = DataserviceFactory(owner=owner)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.dataservice", dataservice=dataservice) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == owner.email
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_organization_delete_with_mail_as_admin(self):
+        """Admin deleting organization with send_legal_notice=True should send email to org admins"""
+        self.login(AdminFactory())
+        org_admin = UserFactory()
+        org = OrganizationFactory(members=[{"user": org_admin, "role": "admin"}])
+
+        with capture_mails() as mails:
+            response = self.delete(url_for("api.organization", org=org) + "?send_legal_notice=true")
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == org_admin.email
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_user_delete_with_legal_notice_skips_simple_notification(self):
+        """Admin deleting user with send_legal_notice=True automatically skips simple notification"""
+        self.login(AdminFactory())
+        user_to_delete = UserFactory()
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.user", user=user_to_delete) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        # Only legal notice mail, simple notification is automatically skipped
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == user_to_delete.email
+        # Verify it's the legal notice (with appeal info), not the simple notification
+        assert "Deletion of your" in mails[0].subject  # Legal notice subject
+        assert "contest this decision" in mails[0].body  # Legal notice contains appeal info
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_discussion_delete_with_mail_as_admin(self):
+        """Admin deleting discussion with send_legal_notice=True should send email to author"""
+        self.login(AdminFactory())
+        author = UserFactory()
+        dataset = DatasetFactory()
+        discussion = DiscussionFactory(subject=dataset, user=author)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.discussion", id=discussion.id) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == author.email
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_message_delete_with_mail_as_admin(self):
+        """Admin deleting message with send_legal_notice=True should send email to author"""
+        self.login(AdminFactory())
+        author = UserFactory()
+        message_author = UserFactory()
+        dataset = DatasetFactory()
+        discussion = DiscussionFactory(
+            subject=dataset,
+            user=author,
+            discussion=[
+                MessageDiscussionFactory(posted_by=author),
+                MessageDiscussionFactory(posted_by=message_author),
+            ],
+        )
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.discussion_comment", id=discussion.id, cidx=1)
+                + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 1
+        assert mails[0].recipients[0] == message_author.email
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataset_delete_without_owner_no_mail_sent(self):
+        """Deleting dataset without owner or organization should not send email"""
+        self.login(AdminFactory())
+        dataset = DatasetFactory(owner=None, organization=None)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_reuse_delete_without_owner_no_mail_sent(self):
+        """Deleting reuse without owner or organization should not send email"""
+        self.login(AdminFactory())
+        reuse = ReuseFactory(owner=None, organization=None)
+
+        with capture_mails() as mails:
+            response = self.delete(url_for("api.reuse", reuse=reuse) + "?send_legal_notice=true")
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_dataservice_delete_without_owner_no_mail_sent(self):
+        """Deleting dataservice without owner or organization should not send email"""
+        self.login(AdminFactory())
+        dataservice = DataserviceFactory(owner=None, organization=None)
+
+        with capture_mails() as mails:
+            response = self.delete(
+                url_for("api.dataservice", dataservice=dataservice) + "?send_legal_notice=true"
+            )
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+    @pytest.mark.options(DEFAULT_LANGUAGE="en")
+    def test_organization_delete_without_admins_no_mail_sent(self):
+        """Deleting organization without admin members should not send email"""
+        self.login(AdminFactory())
+        editor = UserFactory()
+        org = OrganizationFactory(members=[{"user": editor, "role": "editor"}])
+
+        with capture_mails() as mails:
+            response = self.delete(url_for("api.organization", org=org) + "?send_legal_notice=true")
+
+        self.assertStatus(response, 204)
+        assert len(mails) == 0
+
+
+class MailContentVariantsTest(APITestCase):
+    """Test mail content varies based on settings"""
+
+    modules = []
+
+    @pytest.mark.options(
+        DEFAULT_LANGUAGE="en",
+        TERMS_OF_USE_URL="https://example.com/terms",
+        TERMS_OF_USE_DELETION_ARTICLE="5.1.2",
+        TELERECOURS_URL="https://telerecours.fr",
+    )
+    def test_mail_with_all_settings(self):
+        """Mail should contain terms of use reference and telerecours when all settings defined"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            self.delete(url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true")
+
+        assert len(mails) == 1
+        body = mails[0].body
+        assert "Our terms of use specify" in body
+        assert "5.1.2" in body
+        assert "Télérecours" in body
+
+    @pytest.mark.options(
+        DEFAULT_LANGUAGE="en",
+        TERMS_OF_USE_DELETION_ARTICLE=None,
+        TELERECOURS_URL=None,
+    )
+    def test_mail_without_settings(self):
+        """Mail should use generic text when settings are not defined"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            self.delete(url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true")
+
+        assert len(mails) == 1
+        body = mails[0].body
+        assert "Our terms of use specify" not in body
+        assert "Télérecours" not in body
+        assert "contacting us" in body
+
+    @pytest.mark.options(
+        DEFAULT_LANGUAGE="en",
+        TERMS_OF_USE_URL="https://example.com/terms",
+        TERMS_OF_USE_DELETION_ARTICLE="3.2",
+        TELERECOURS_URL=None,
+    )
+    def test_mail_with_terms_only(self):
+        """Mail should contain terms of use but generic appeal when only terms defined"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            self.delete(url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true")
+
+        assert len(mails) == 1
+        body = mails[0].body
+        assert "Our terms of use specify" in body
+        assert "3.2" in body
+        assert "Télérecours" not in body
+        assert "contacting us" in body
+
+    @pytest.mark.options(
+        DEFAULT_LANGUAGE="en",
+        TERMS_OF_USE_DELETION_ARTICLE=None,
+        TELERECOURS_URL="https://telerecours.fr",
+    )
+    def test_mail_with_telerecours_only(self):
+        """Mail should contain telerecours but generic terms when only telerecours defined"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            self.delete(url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true")
+
+        assert len(mails) == 1
+        body = mails[0].body
+        assert "Our terms of use specify" not in body
+        assert "Télérecours" in body
+        assert "contacting us" not in body
+
+    @pytest.mark.options(
+        DEFAULT_LANGUAGE="en",
+        TERMS_OF_USE_URL=None,
+        TERMS_OF_USE_DELETION_ARTICLE="5.1.2",
+        TELERECOURS_URL=None,
+    )
+    def test_mail_with_article_but_no_url(self):
+        """Mail should use generic terms when article is defined but URL is missing"""
+        self.login(AdminFactory())
+        owner = UserFactory()
+        dataset = DatasetFactory(owner=owner)
+
+        with capture_mails() as mails:
+            self.delete(url_for("api.dataset", dataset=dataset) + "?send_legal_notice=true")
+
+        assert len(mails) == 1
+        body = mails[0].body
+        assert "Our terms of use specify" not in body
+        assert "5.1.2" not in body

{udata-14.4.1.dev7.dist-info → udata-14.5.1.dev9.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: udata
-Version: 14.4.1.dev7
+Version: 14.5.1.dev9
 Summary: Open data portal
 Author-email: Opendata Team <opendatateam@data.gouv.fr>
 Maintainer-email: Opendata Team <opendatateam@data.gouv.fr>
@@ -85,7 +85,7 @@ Requires-Dist: tzdata
 Requires-Dist: urlextract<2.0.0,>=1.9.0
 Requires-Dist: urllib3<3.0.0,>=2.0.0
 Requires-Dist: voluptuous<1.0.0,>=0.15.2
-Requires-Dist: werkzeug<4.0.0,>=3.0.0
+Requires-Dist: werkzeug<3.1.4,>=3.0.0
 Requires-Dist: wtforms[email]<4.0.0,>=3.2.1
 Requires-Dist: wtforms-json<1.0.0,>=0.3.5
 Dynamic: license-file