udata 13.0.1.dev12__py3-none-any.whl → 14.4.1.dev7__py3-none-any.whl

udata/tests/api/test_reports_api.py

@@ -1,3 +1,5 @@
+from datetime import datetime
+
 from flask import url_for
 
 from udata.core.dataset.factories import DatasetFactory
@@ -148,6 +150,28 @@ class ReportsAPITest(APITestCase):
 
         self.assertEqual(payload["data"][1]["subject"]["id"], str(spam_reuse.id))
 
+    def test_reports_api_list_sort_by_reported_at(self):
+        user = UserFactory()
+
+        dataset1 = DatasetFactory.create(owner=user)
+        dataset2 = DatasetFactory.create(owner=user)
+        dataset3 = DatasetFactory.create(owner=user)
+
+        # Create reports with different reported_at times
+        report1 = Report(subject=dataset1, reason="spam", reported_at=datetime(2024, 1, 1)).save()
+        report2 = Report(subject=dataset2, reason="spam", reported_at=datetime(2024, 1, 3)).save()
+        report3 = Report(subject=dataset3, reason="spam", reported_at=datetime(2024, 1, 2)).save()
+
+        self.login(AdminFactory())
+
+        # Sort by -reported_at (most recent first)
+        response = self.get(url_for("api.reports", sort="-reported_at"))
+        self.assert200(response)
+        payload = response.json
+        self.assertEqual(payload["data"][0]["id"], str(report2.id))
+        self.assertEqual(payload["data"][1]["id"], str(report3.id))
+        self.assertEqual(payload["data"][2]["id"], str(report1.id))
+
     def test_reports_api_get(self):
         user = UserFactory()
 
@@ -165,3 +189,136 @@ class ReportsAPITest(APITestCase):
 
         payload = response.json
         self.assertEqual(payload["subject"]["id"], str(spam_dataset.id))
+
+    def test_reports_api_dismiss(self):
+        user = UserFactory()
+        admin = AdminFactory()
+
+        spam_dataset = DatasetFactory.create(owner=user)
+        report = Report(subject=spam_dataset, reason="spam").save()
+
+        dismiss_time = datetime.utcnow().isoformat()
+
+        # Should require admin
+        response = self.patch(url_for("api.report", report=report), {"dismissed_at": dismiss_time})
+        self.assert401(response)
+
+        self.login(user)
+        response = self.patch(url_for("api.report", report=report), {"dismissed_at": dismiss_time})
+        self.assert403(response)
+
+        self.login(admin)
+        response = self.patch(url_for("api.report", report=report), {"dismissed_at": dismiss_time})
+        self.assert200(response)
+
+        payload = response.json
+        self.assertIsNotNone(payload["dismissed_at"])
+        self.assertEqual(payload["dismissed_by"]["id"], str(admin.id))
+
+        report.reload()
+        self.assertIsNotNone(report.dismissed_at)
+        self.assertEqual(report.dismissed_by.id, admin.id)
+
+    def test_reports_api_undismiss(self):
+        user = UserFactory()
+        admin = AdminFactory()
+
+        spam_dataset = DatasetFactory.create(owner=user)
+        report = Report(
+            subject=spam_dataset,
+            reason="spam",
+            dismissed_at=datetime.utcnow(),
+            dismissed_by=admin,
+        ).save()
+
+        # Verify report is dismissed
+        self.assertIsNotNone(report.dismissed_at)
+        self.assertIsNotNone(report.dismissed_by)
+
+        # Should require admin
+        response = self.patch(url_for("api.report", report=report), {"dismissed_at": None})
+        self.assert401(response)
+
+        self.login(user)
+        response = self.patch(url_for("api.report", report=report), {"dismissed_at": None})
+        self.assert403(response)
+
+        self.login(admin)
+        response = self.patch(url_for("api.report", report=report), {"dismissed_at": None})
+        self.assert200(response)
+
+        payload = response.json
+        self.assertIsNone(payload["dismissed_at"])
+        self.assertIsNone(payload["dismissed_by"])
+
+        report.reload()
+        self.assertIsNone(report.dismissed_at)
+        self.assertIsNone(report.dismissed_by)
+
+    def test_reports_api_filter_by_handled(self):
+        user = UserFactory()
+        admin = AdminFactory()
+
+        dataset1 = DatasetFactory.create(owner=user)
+        dataset2 = DatasetFactory.create(owner=user)
+
+        # Unhandled report (not dismissed)
+        ongoing_report = Report(subject=dataset1, reason="spam").save()
+
+        # Handled report (dismissed)
+        dismissed_report = Report(
+            subject=dataset2, reason="spam", dismissed_at=datetime.utcnow(), dismissed_by=admin
+        ).save()
+
+        self.login(admin)
+
+        # Filter by unhandled
+        response = self.get(url_for("api.reports", handled="false"))
+        self.assert200(response)
+        payload = response.json
+        self.assertEqual(payload["total"], 1)
+        self.assertEqual(payload["data"][0]["id"], str(ongoing_report.id))
+
+        # Filter by handled
+        response = self.get(url_for("api.reports", handled="true"))
+        self.assert200(response)
+        payload = response.json
+        self.assertEqual(payload["total"], 1)
+        self.assertEqual(payload["data"][0]["id"], str(dismissed_report.id))
+
+        # No filter (all reports)
+        response = self.get(url_for("api.reports"))
+        self.assert200(response)
+        payload = response.json
+        self.assertEqual(payload["total"], 2)
+
+    def test_reports_api_filter_handled_with_deleted_subject(self):
+        """Reports with deleted subjects should appear when handled="true", not handled="false"."""
+        user = UserFactory()
+        admin = AdminFactory()
+
+        dataset1 = DatasetFactory.create(owner=user)
+        dataset2 = DatasetFactory.create(owner=user)
+
+        # Unhandled report (not dismissed, subject exists)
+        ongoing_report = Report(subject=dataset1, reason="spam").save()
+
+        # Report with deleted subject (should appear in "handled", not "unhandled")
+        deleted_subject_report = Report(subject=dataset2, reason="spam").save()
+        dataset2.delete()
+
+        self.login(admin)
+
+        # Filter by unhandled - should only return the report with existing subject
+        response = self.get(url_for("api.reports", handled="false"))
+        self.assert200(response)
+        payload = response.json
+        self.assertEqual(payload["total"], 1)
+        self.assertEqual(payload["data"][0]["id"], str(ongoing_report.id))
+
+        # Filter by handled - should return the report with deleted subject
+        response = self.get(url_for("api.reports", handled="true"))
+        self.assert200(response)
+        payload = response.json
+        self.assertEqual(payload["total"], 1)
+        self.assertEqual(payload["data"][0]["id"], str(deleted_subject_report.id))