udata 11.0.1.dev37741__py2.py3-none-any.whl → 11.0.1.dev37781__py2.py3-none-any.whl

udata/core/topic/forms.py

@@ -58,24 +58,27 @@ class TopicForm(ModelForm):
         """Custom save to handle TopicElement creation properly"""
         # Store elements data before parent save
         elements_data = self.elements.data
+        # Check if elements field was explicitly provided
+        elements_provided = self.elements.has_data
 
         # Use parent save method (elements field is excluded via populate_obj)
         topic = super().save(commit=commit, **kwargs)
 
-        # Clear existing elements before adding new ones
-        if commit:
-            TopicElement.objects(topic=topic).delete()
-
-        # Create elements and associate them with the topic
-        for element_data in elements_data or []:
-            # Create element form with only its own data, not inheriting from parent
-            element_form = TopicElementForm(meta={"csrf": False})
-            element_form.process(data=element_data)
-            if element_form.validate():
-                element = element_form.save(commit=False)
-                element.topic = topic
-                if commit:
-                    element.save()
+        # Only clear and recreate elements if they were explicitly provided in the payload
+        if elements_provided:
+            if commit:
+                TopicElement.objects(topic=topic).delete()
+
+            # Create elements and associate them with the topic
+            for element_data in elements_data or []:
+                # Create element form with only its own data, not inheriting from parent
+                element_form = TopicElementForm(meta={"csrf": False})
+                element_form.process(data=element_data)
+                if element_form.validate():
+                    element = element_form.save(commit=False)
+                    element.topic = topic
+                    if commit:
+                        element.save()
 
         return topic
 

udata/tests/apiv2/test_topics.py

@@ -295,6 +295,32 @@ class TopicAPITest(APITestCase):
         topic.reload()
         self.assertEqual(len(topic.elements), initial_length + 1)
 
+    def test_topic_api_update_without_elements(self):
+        """It should update a topic without affecting existing elements when elements field is not provided"""
+        user = self.login()
+        topic = TopicWithElementsFactory(owner=user)
+        initial_element_ids = [str(elt.id) for elt in topic.elements]
+
+        # Update topic without including elements field
+        data = {
+            "name": "Updated topic name",
+            "description": "Updated description",
+            "tags": ["updated-tag"],
+        }
+        response = self.put(url_for("apiv2.topic", topic=topic), data)
+        self.assert200(response)
+
+        # Reload and verify elements are preserved
+        topic.reload()
+        self.assertEqual(len(topic.elements), len(initial_element_ids))
+        current_element_ids = [str(elt.id) for elt in topic.elements]
+        self.assertEqual(set(current_element_ids), set(initial_element_ids))
+
+        # Verify other fields were updated
+        self.assertEqual(topic.name, "Updated topic name")
+        self.assertEqual(topic.description, "Updated description")
+        self.assertEqual(topic.tags, ["updated-tag"])
+
     def test_topic_api_delete(self):
         """It should delete a topic from the API"""
         owner = self.login()

{udata-11.0.1.dev37741.dist-info → udata-11.0.1.dev37781.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: udata
-Version: 11.0.1.dev37741
+Version: 11.0.1.dev37781
 Summary: Open data portal
 Home-page: https://github.com/opendatateam/udata
 Author: Opendata Team
@@ -144,7 +144,7 @@ It is collectively taken care of by members of the
 
 ## Current (in progress)
 
-- Nothing yet
+- fix: PUT topic without elements [#3424](https://github.com/opendatateam/udata/pull/3424)
 
 ## 11.0.0 (2025-09-12)
 

{udata-11.0.1.dev37741.dist-info → udata-11.0.1.dev37781.dist-info}/RECORD

@@ -243,7 +243,7 @@ udata/core/topic/activities.py,sha256=Pcqhs-OxmSV2NlN18GyV12z9AW8tfS8glgwwmchcbp
 udata/core/topic/api_fields.py,sha256=4H904dYR62uhW7XXgCgOrlBwKjFE7h878hQgLbMpRXk,3327
 udata/core/topic/apiv2.py,sha256=RyJIA9UEMURyyuh4gt_yHkAxIM2OwUroGctp-1PVk94,6393
 udata/core/topic/factories.py,sha256=6UYvt4Rf0dxP1pec1ySQySiq82A58VN0uo-7mnbFnuw,2767
-udata/core/topic/forms.py,sha256=UV5t9qU51EcqOa-mygEvqZ5wi4oWKO69KxffccFWRbw,3244
+udata/core/topic/forms.py,sha256=OkWFo0FkSnjZ2LURoq2i2cpingFz1TrOEI3TJ7qQ8pk,3465
 udata/core/topic/models.py,sha256=FdNJViwPNoPNfSdcvcCxI_dbQ71zdaj4wF9lRuGhd3I,3755
 udata/core/topic/parsers.py,sha256=leQtzLtEIV-0lCu_ibsygJoE2e6qAWzpDPer4BhPPjM,3878
 udata/core/topic/permissions.py,sha256=RtFPPlxuU_Bv7ip6LDO4AoPrKFnIOEs9cCMXaSSmEdk,118
@@ -675,7 +675,7 @@ udata/tests/apiv2/test_datasets.py,sha256=5HYB3UWWKRsIoLx007ZJ1Bx0IU7YzK-_z8VtoM
 udata/tests/apiv2/test_me_api.py,sha256=WgUjujSnIlISUkM5t-lfg-D0mmz-eX1hSsSwjuxqbJg,1417
 udata/tests/apiv2/test_organizations.py,sha256=os_43s-coSRqjgY-5fAjSiRlB3g2685u7d-Es0aOhks,6390
 udata/tests/apiv2/test_swagger.py,sha256=RKedaq-2UeyEuxlmUaAN7pmEe-lQYYmpDUVc8HF3CH4,785
-udata/tests/apiv2/test_topics.py,sha256=9-Szqw6B8647wOQgAUKN4BWzrdEc1g_iHufpgq_ZKd8,26710
+udata/tests/apiv2/test_topics.py,sha256=TFipUDUIWRY8oT20GAwk3wH-u6z5eG9MJ3h0ZZEViE0,27862
 udata/tests/cli/test_cli_base.py,sha256=0a3U_5ROp1lCTG8d6TpCjF4nbKVNerAeLO0VxU-NTUk,321
 udata/tests/cli/test_db_cli.py,sha256=xFVHQAk2bmQQzFr31TK2JThOP6p0wvxzexMhM_IcdME,2219
 udata/tests/contact_point/test_contact_point_models.py,sha256=b8vraZPPrs9LeQMWLnOCrpI02sXMEM_BcMJXKTeAuAw,923
@@ -766,9 +766,9 @@ udata/translations/pt/LC_MESSAGES/udata.mo,sha256=U0abG-nBwCIoYxRZNsc4KOLeIRSqTV
 udata/translations/pt/LC_MESSAGES/udata.po,sha256=eCG35rMzYLHXyLbsnLSexS1g0N_K-WpNHqrt_8y6I4E,48590
 udata/translations/sr/LC_MESSAGES/udata.mo,sha256=IBcCAdmcvkeK7ZeRBNRI-wJ0jzWNM0eXM5VXAc1frWI,28692
 udata/translations/sr/LC_MESSAGES/udata.po,sha256=yFxHEEB4behNwQ7JnyoYheiCKLNnMS_NV4guzgyzWcE,55332
-udata-11.0.1.dev37741.dist-info/LICENSE,sha256=V8j_M8nAz8PvAOZQocyRDX7keai8UJ9skgmnwqETmdY,34520
-udata-11.0.1.dev37741.dist-info/METADATA,sha256=__qV91M5Ik8dpRM4-p-W7-JraafQyVBtTDXGJCY3Qoc,155274
-udata-11.0.1.dev37741.dist-info/WHEEL,sha256=Kh9pAotZVRFj97E15yTA4iADqXdQfIVTHcNaZTjxeGM,110
-udata-11.0.1.dev37741.dist-info/entry_points.txt,sha256=v2u12qO11i2lyLNIp136WmLJ-NHT-Kew3Duu8J-AXPM,614
-udata-11.0.1.dev37741.dist-info/top_level.txt,sha256=39OCg-VWFWOq4gCKnjKNu-s3OwFlZIu_dVH8Gl6ndHw,12
-udata-11.0.1.dev37741.dist-info/RECORD,,
+udata-11.0.1.dev37781.dist-info/LICENSE,sha256=V8j_M8nAz8PvAOZQocyRDX7keai8UJ9skgmnwqETmdY,34520
+udata-11.0.1.dev37781.dist-info/METADATA,sha256=y_Q3fPaqKsst_77ALWIC6htfAaQ59xnOR46evnFeAlE,155351
+udata-11.0.1.dev37781.dist-info/WHEEL,sha256=Kh9pAotZVRFj97E15yTA4iADqXdQfIVTHcNaZTjxeGM,110
+udata-11.0.1.dev37781.dist-info/entry_points.txt,sha256=v2u12qO11i2lyLNIp136WmLJ-NHT-Kew3Duu8J-AXPM,614
+udata-11.0.1.dev37781.dist-info/top_level.txt,sha256=39OCg-VWFWOq4gCKnjKNu-s3OwFlZIu_dVH8Gl6ndHw,12
+udata-11.0.1.dev37781.dist-info/RECORD,,