udata 10.8.2.dev36872__py2.py3-none-any.whl → 10.8.2.dev36980__py2.py3-none-any.whl

udata/harvest/tests/test_actions.py

@@ -152,7 +152,7 @@ class HarvestActionsTest:
         data["url"] = new_url
 
         with assert_emit(signals.harvest_source_updated):
-            source = actions.update_source(source.id, data)
+            source = actions.update_source(source, data)
 
         assert source.url == new_url
         source.reload()
@@ -162,14 +162,14 @@ class HarvestActionsTest:
     def test_validate_source(self, mock):
         source = HarvestSourceFactory()
 
-        actions.validate_source(source.id)
+        actions.validate_source(source)
 
         source.reload()
         assert source.validation.state == VALIDATION_ACCEPTED
         assert source.validation.on is not None
         assert source.validation.by is None
         assert source.validation.comment is None
-        mock.assert_called_once_with(source.id)
+        mock.assert_called_once_with(source)
 
         assert source.periodic_task is not None
 
@@ -177,7 +177,7 @@ class HarvestActionsTest:
     def test_validate_source_with_comment(self, mock):
         source = HarvestSourceFactory()
 
-        actions.validate_source(source.id, "comment")
+        actions.validate_source(source, "comment")
 
         source.reload()
 
@@ -185,12 +185,12 @@ class HarvestActionsTest:
         assert source.validation.on is not None
         assert source.validation.by is None
         assert source.validation.comment == "comment"
-        mock.assert_called_once_with(source.id)
+        mock.assert_called_once_with(source)
 
     def test_reject_source(self):
         source = HarvestSourceFactory()
 
-        actions.reject_source(source.id, "comment")
+        actions.reject_source(source, "comment")
 
         source.reload()
         assert source.validation.state == VALIDATION_REFUSED
@@ -200,20 +200,16 @@ class HarvestActionsTest:
 
     def test_get_source_by_slug(self):
         source = HarvestSourceFactory()
-        assert actions.get_source(source.slug) == source
+        assert HarvestSource.get(source.slug) == source
 
     def test_get_source_by_id(self):
         source = HarvestSourceFactory()
-        assert actions.get_source(str(source.id)) == source
-
-    def test_get_source_by_objectid(self):
-        source = HarvestSourceFactory()
-        assert actions.get_source(source.id) == source
+        assert HarvestSource.get(str(source.id)) == source
 
     def test_delete_source_by_slug(self):
         source = HarvestSourceFactory()
         with assert_emit(signals.harvest_source_deleted):
-            deleted_source = actions.delete_source(source.slug)
+            deleted_source = actions.delete_source(source)
 
         assert deleted_source.deleted is not None
         assert deleted_source.id == source.id
@@ -223,7 +219,7 @@ class HarvestActionsTest:
     def test_delete_source_by_id(self):
         source = HarvestSourceFactory()
         with assert_emit(signals.harvest_source_deleted):
-            deleted_source = actions.delete_source(str(source.id))
+            deleted_source = actions.delete_source(source)
 
         assert deleted_source.deleted is not None
         assert deleted_source.id == source.id
@@ -233,19 +229,18 @@ class HarvestActionsTest:
     def test_delete_source_by_objectid(self):
         source = HarvestSourceFactory()
         with assert_emit(signals.harvest_source_deleted):
-            deleted_source = actions.delete_source(source.id)
+            deleted_source = actions.delete_source(source)
 
         assert deleted_source.deleted is not None
         assert deleted_source.id == source.id
         deleted_sources = HarvestSource.objects(deleted__exists=True)
         assert len(deleted_sources) == 1
 
-    @pytest.mark.parametrize("by_attr", ["source.id", "str(source.id)", "source.slug"])
-    def test_clean_source(self, by_attr):
+    def test_clean_source(self):
         source = HarvestSourceFactory()
         for _ in range(5):
             DatasetFactory(harvest=HarvestDatasetMetadata(source_id=str(source.id)))
-        actions.clean_source(eval(by_attr))
+        actions.clean_source(source)
         datasets = Dataset.objects.filter(harvest__source_id=str(source.id))
         assert len(datasets) == 5
         for dataset in datasets:
@@ -262,7 +257,7 @@ class HarvestActionsTest:
     def test_schedule(self):
         source = HarvestSourceFactory()
         with assert_emit(signals.harvest_source_scheduled):
-            source = actions.schedule(str(source.id), hour=0)
+            source = actions.schedule(source, hour=0)
 
         assert len(PeriodicTask.objects) == 1
         periodic_task = source.periodic_task
@@ -279,7 +274,7 @@ class HarvestActionsTest:
     def test_schedule_from_cron(self):
         source = HarvestSourceFactory()
         with assert_emit(signals.harvest_source_scheduled):
-            source = actions.schedule(str(source.id), "0 1 2 3 sunday")
+            source = actions.schedule(source, "0 1 2 3 sunday")
 
         assert len(PeriodicTask.objects) == 1
         periodic_task = source.periodic_task
@@ -296,10 +291,10 @@ class HarvestActionsTest:
     def test_reschedule(self):
         source = HarvestSourceFactory()
         with assert_emit(signals.harvest_source_scheduled):
-            source = actions.schedule(str(source.id), hour=0)
+            source = actions.schedule(source, hour=0)
 
         with assert_emit(signals.harvest_source_scheduled):
-            source = actions.schedule(str(source.id), minute=0)
+            source = actions.schedule(source, minute=0)
 
         assert len(PeriodicTask.objects) == 1
         periodic_task = source.periodic_task
@@ -323,7 +318,7 @@ class HarvestActionsTest:
         )
         source = HarvestSourceFactory(periodic_task=periodic_task)
         with assert_emit(signals.harvest_source_unscheduled):
-            actions.unschedule(str(source.id))
+            actions.unschedule(source)
 
         source.reload()
         assert len(PeriodicTask.objects) == 0
@@ -460,7 +455,7 @@ class ExecutionTestMixin(MockBackendsMixin):
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="factory", organization=org)
         with assert_emit(signals.before_harvest_job, signals.after_harvest_job):
-            self.action(source.slug)
+            self.action(source)
 
         source.reload()
         assert len(HarvestJob.objects(source=source)) == 1
@@ -496,7 +491,7 @@ class ExecutionTestMixin(MockBackendsMixin):
 
         source = HarvestSourceFactory(backend="factory")
         with assert_emit(signals.before_harvest_job), mock_initialize.connected_to(init):
-            self.action(source.slug)
+            self.action(source)
 
         source.reload()
         assert len(HarvestJob.objects(source=source)) == 1
@@ -523,7 +518,7 @@ class ExecutionTestMixin(MockBackendsMixin):
             assert_emit(signals.before_harvest_job, signals.after_harvest_job),
             mock_process.connected_to(process),
         ):
-            self.action(source.slug)
+            self.action(source)
 
         source.reload()
         assert len(HarvestJob.objects(source=source)) == 1
@@ -559,7 +554,7 @@ class ExecutionTestMixin(MockBackendsMixin):
     def test_empty(self):
         source = HarvestSourceFactory(backend="factory", config={"count": 0})
         with assert_emit(signals.before_harvest_job, signals.after_harvest_job):
-            self.action(source.slug)
+            self.action(source)
 
         source.reload()
         assert len(HarvestJob.objects(source=source)) == 1
@@ -580,7 +575,7 @@ class ExecutionTestMixin(MockBackendsMixin):
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="factory", organization=org, config={"count": 10})
 
-        self.action(source.slug)
+        self.action(source)
         assert len(Dataset.objects) == 5
 
 
@@ -599,7 +594,7 @@ class HarvestPreviewTest(MockBackendsMixin):
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="factory", organization=org)
 
-        job = actions.preview(source.slug)
+        job = actions.preview(source)
 
         assert job.status == "done"
         assert job.errors == []
@@ -628,7 +623,7 @@ class HarvestPreviewTest(MockBackendsMixin):
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="factory", organization=org, config={"count": 10})
 
-        job = actions.preview(source.slug)
+        job = actions.preview(source)
 
         assert len(job.items) == 5
 
@@ -639,7 +634,7 @@ class HarvestPreviewTest(MockBackendsMixin):
         source = HarvestSourceFactory(backend="factory")
 
         with mock_initialize.connected_to(init):
-            job = actions.preview(source.slug)
+            job = actions.preview(source)
 
         assert job.status == "failed"
         assert len(job.errors) == 1
@@ -660,7 +655,7 @@ class HarvestPreviewTest(MockBackendsMixin):
         source = HarvestSourceFactory(backend="factory")
 
         with mock_process.connected_to(process):
-            job = actions.preview(source.slug)
+            job = actions.preview(source)
 
         assert job.status == "done-errors"
         assert job.started is not None

udata/harvest/tests/test_api.py

@@ -395,7 +395,7 @@ class HarvestAPITest(MockBackendsMixin):
             "url": new_url,
             "backend": "factory",
         }
-        api_url = url_for("api.harvest_source", ident=str(source.id))
+        api_url = url_for("api.harvest_source", source=source)
         response = api.put(api_url, data)
         assert200(response)
         assert response.json["url"] == new_url
@@ -403,7 +403,7 @@ class HarvestAPITest(MockBackendsMixin):
         # Source is now owned by orga, with user as member
         source.organization = OrganizationFactory(members=[Member(user=user)])
         source.save()
-        api_url = url_for("api.harvest_source", ident=str(source.id))
+        api_url = url_for("api.harvest_source", source=source)
         response = api.put(api_url, data)
         assert200(response)
 
@@ -418,7 +418,7 @@ class HarvestAPITest(MockBackendsMixin):
             "url": new_url,
             "backend": "factory",
         }
-        api_url: str = url_for("api.harvest_source", ident=str(source.id))
+        api_url: str = url_for("api.harvest_source", source=source)
         response = api.put(api_url, data)
 
         assert403(response)
@@ -429,7 +429,7 @@ class HarvestAPITest(MockBackendsMixin):
         source = HarvestSourceFactory()
 
         data = {"state": VALIDATION_ACCEPTED}
-        url = url_for("api.validate_harvest_source", ident=str(source.id))
+        url = url_for("api.validate_harvest_source", source=source)
         response = api.post(url, data)
         assert200(response)
 
@@ -443,7 +443,7 @@ class HarvestAPITest(MockBackendsMixin):
         source = HarvestSourceFactory()
 
         data = {"state": VALIDATION_REFUSED, "comment": "Not valid"}
-        url = url_for("api.validate_harvest_source", ident=str(source.id))
+        url = url_for("api.validate_harvest_source", source=source)
         response = api.post(url, data)
         assert200(response)
 
@@ -458,22 +458,27 @@ class HarvestAPITest(MockBackendsMixin):
         source = HarvestSourceFactory()
 
         data = {"validate": True}
-        url = url_for("api.validate_harvest_source", ident=str(source.id))
+        url = url_for("api.validate_harvest_source", source=source)
         response = api.post(url, data)
         assert403(response)
 
     def test_get_source(self, api):
         source = HarvestSourceFactory()
 
-        url = url_for("api.harvest_source", ident=str(source.id))
+        url = url_for("api.harvest_source", source=source)
         response = api.get(url)
         assert200(response)
 
+    def test_get_missing_source(self, api):
+        url = url_for("api.harvest_source", source="685bb38b9cb9284b93fd9e72")
+        response = api.get(url)
+        assert404(response)
+
     def test_source_preview(self, api):
         api.login()
         source = HarvestSourceFactory(backend="factory")
 
-        url = url_for("api.preview_harvest_source", ident=str(source.id))
+        url = url_for("api.preview_harvest_source", source=source)
         response = api.get(url)
         assert200(response)
 
@@ -488,7 +493,7 @@ class HarvestAPITest(MockBackendsMixin):
             validation=HarvestSourceValidation(state=VALIDATION_ACCEPTED),
         )
 
-        url = url_for("api.run_harvest_source", ident=str(source.id))
+        url = url_for("api.run_harvest_source", source=source)
         response = api.post(url)
         assert200(response)
 
@@ -505,7 +510,7 @@ class HarvestAPITest(MockBackendsMixin):
             validation=HarvestSourceValidation(state=VALIDATION_ACCEPTED),
         )
 
-        url = url_for("api.run_harvest_source", ident=str(source.id))
+        url = url_for("api.run_harvest_source", source=source)
         response = api.post(url)
         assert400(response)
 
@@ -523,7 +528,7 @@ class HarvestAPITest(MockBackendsMixin):
             validation=HarvestSourceValidation(state=VALIDATION_ACCEPTED),
         )
 
-        url = url_for("api.run_harvest_source", ident=str(source.id))
+        url = url_for("api.run_harvest_source", source=source)
         response = api.post(url)
         assert403(response)
 
@@ -540,7 +545,7 @@ class HarvestAPITest(MockBackendsMixin):
             validation=HarvestSourceValidation(state=VALIDATION_PENDING),
         )
 
-        url = url_for("api.run_harvest_source", ident=str(source.id))
+        url = url_for("api.run_harvest_source", source=source)
         response = api.post(url)
         assert400(response)
 
@@ -556,7 +561,7 @@ class HarvestAPITest(MockBackendsMixin):
         user = api.login()
         source = HarvestSourceFactory(owner=user)
 
-        url = url_for("api.harvest_source", ident=str(source.id))
+        url = url_for("api.harvest_source", source=source)
         response = api.delete(url)
         assert204(response)
 
@@ -568,7 +573,7 @@ class HarvestAPITest(MockBackendsMixin):
         api.login()
         source = HarvestSourceFactory()
 
-        url = url_for("api.harvest_source", ident=str(source.id))
+        url = url_for("api.harvest_source", source=source)
         response = api.delete(url)
 
         assert403(response)
@@ -579,7 +584,7 @@ class HarvestAPITest(MockBackendsMixin):
         source = HarvestSourceFactory()
 
         data = "0 0 * * *"
-        url = url_for("api.schedule_harvest_source", ident=str(source.id))
+        url = url_for("api.schedule_harvest_source", source=source)
         response = api.post(url, data)
         assert200(response)
 
@@ -601,7 +606,7 @@ class HarvestAPITest(MockBackendsMixin):
         source = HarvestSourceFactory()
 
         data = "0 0 * * *"
-        url = url_for("api.schedule_harvest_source", ident=str(source.id))
+        url = url_for("api.schedule_harvest_source", source=source)
         response = api.post(url, data)
         assert403(response)
 
@@ -620,7 +625,7 @@ class HarvestAPITest(MockBackendsMixin):
         )
         source = HarvestSourceFactory(periodic_task=periodic_task)
 
-        url = url_for("api.schedule_harvest_source", ident=str(source.id))
+        url = url_for("api.schedule_harvest_source", source=source)
         response = api.delete(url)
         assert204(response)
 
@@ -639,7 +644,7 @@ class HarvestAPITest(MockBackendsMixin):
         )
         source = HarvestSourceFactory(periodic_task=periodic_task)
 
-        url = url_for("api.schedule_harvest_source", ident=str(source.id))
+        url = url_for("api.schedule_harvest_source", source=source)
         response = api.delete(url)
         assert403(response)
 

udata/harvest/tests/test_dcat_backend.py

@@ -74,7 +74,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -123,7 +123,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
 
@@ -154,7 +154,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
 
@@ -171,7 +171,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         dataservices = Dataservice.objects
 
@@ -192,7 +192,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
         assert len(datasets) == 8
@@ -244,7 +244,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
 
@@ -306,7 +306,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         assert Dataset.objects.count() == 2
         assert HarvestJob.objects.first().status == "done"
@@ -320,7 +320,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
 
@@ -345,7 +345,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
 
@@ -388,7 +388,7 @@ class DcatBackendTest:
         url = mock_dcat(rmock, filename)
         source = HarvestSourceFactory(backend="dcat", url=url, organization=OrganizationFactory())
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -416,8 +416,8 @@ class DcatBackendTest:
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
         # Run the same havester twice
-        actions.run(source.slug)
-        actions.run(source.slug)
+        actions.run(source)
+        actions.run(source)
 
         datasets = {d.harvest.dct_identifier: d for d in Dataset.objects}
 
@@ -431,7 +431,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -443,7 +443,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -456,7 +456,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -470,7 +470,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -493,7 +493,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         # test dct:license support
         dataset = Dataset.objects.get(harvest__dct_identifier="3")
@@ -587,7 +587,7 @@ class DcatBackendTest:
         url = mock_dcat(rmock, "geonetwork.xml", path="catalog.xml")
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
-        actions.run(source.slug)
+        actions.run(source)
         dataset = Dataset.objects.filter(organization=org).first()
         assert dataset is not None
         assert dataset.harvest is not None
@@ -616,7 +616,7 @@ class DcatBackendTest:
         url = mock_dcat(rmock, "sig.oreme.rdf")
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
-        actions.run(source.slug)
+        actions.run(source)
         dataset = Dataset.objects.filter(organization=org).first()
 
         assert dataset is not None
@@ -646,7 +646,7 @@ class DcatBackendTest:
         url = mock_dcat(rmock, "udata.xml")
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
         job = source.get_last_job()
@@ -712,7 +712,7 @@ class DcatBackendTest:
         get_mock = rmock.get(url)
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
-        actions.run(source.slug)
+        actions.run(source)
 
         assert "User-Agent" in get_mock.last_request.headers
         assert get_mock.last_request.headers["User-Agent"] == "uData/0.1 dcat"
@@ -723,7 +723,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -741,7 +741,7 @@ class DcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -773,7 +773,7 @@ class DcatBackendTest:
         rmock.head(url, headers={"Content-Type": "application/json"})
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="dcat", url=url, organization=org)
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -787,7 +787,7 @@ class DcatBackendTest:
         rmock.get(url, status_code=404)
 
         source = HarvestSourceFactory(backend="dcat", url=url, organization=OrganizationFactory())
-        actions.run(source.slug)
+        actions.run(source)
         source.reload()
 
         job = source.get_last_job()
@@ -800,7 +800,7 @@ class DcatBackendTest:
         rmock.head(url, status_code=404)
 
         source = HarvestSourceFactory(backend="dcat", url=url, organization=OrganizationFactory())
-        actions.run(source.slug)
+        actions.run(source)
         source.reload()
 
         job = source.get_last_job()
@@ -817,7 +817,7 @@ class CswDcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="csw-dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 
@@ -863,7 +863,7 @@ class CswDcatBackendTest:
         org = OrganizationFactory()
         source = HarvestSourceFactory(backend="csw-dcat", url=url, organization=org)
 
-        actions.run(source.slug)
+        actions.run(source)
 
         assert "User-Agent" in get_mock.last_request.headers
         assert get_mock.last_request.headers["User-Agent"] == "uData/0.1 csw-dcat"
@@ -902,7 +902,7 @@ class CswIso19139DcatBackendTest:
             },
         )
 
-        actions.run(source.slug)
+        actions.run(source)
 
         source.reload()
 

udata/routing.py

@@ -10,6 +10,7 @@ from werkzeug.urls import url_quote
 from udata import models
 from udata.core.dataservices.models import Dataservice
 from udata.core.spatial.models import GeoZone
+from udata.harvest.models import HarvestSource
 from udata.i18n import ISO_639_1_CODES
 from udata.mongo import db
 from udata.uris import cdata_url, homepage_url
@@ -136,6 +137,10 @@ class DataserviceConverter(ModelConverter):
     model = Dataservice
 
 
+class HarvestSourceConverter(ModelConverter):
+    model = HarvestSource
+
+
 class CommunityResourceConverter(ModelConverter):
     model = models.CommunityResource
 
@@ -239,6 +244,7 @@ def init_app(app):
     app.url_map.converters["dataset"] = DatasetConverter
     app.url_map.converters["dataset_without_resources"] = DatasetWithoutResourcesConverter
     app.url_map.converters["dataservice"] = DataserviceConverter
+    app.url_map.converters["harvest_source"] = HarvestSourceConverter
     app.url_map.converters["crid"] = CommunityResourceConverter
     app.url_map.converters["org"] = OrganizationConverter
     app.url_map.converters["reuse"] = ReuseConverter