truthound-dashboard 1.4.4__py3-none-any.whl → 1.5.0__py3-none-any.whl

truthound_dashboard/api/drift.py

@@ -1,6 +1,11 @@
 """Drift detection API endpoints.
 
 Provides endpoints for drift comparison between datasets.
+
+API Design: Direct Response Style
+- Single resources return the resource directly
+- List endpoints return PaginatedResponse with data, total, offset, limit
+- Errors are handled via HTTPException
 """
 
 from __future__ import annotations
@@ -13,6 +18,7 @@ from truthound_dashboard.core import DriftService
 from truthound_dashboard.schemas import (
     DriftCompareRequest,
     DriftComparisonListResponse,
+    DriftComparisonResponse,
 )
 
 from .deps import SessionDep
@@ -28,16 +34,34 @@ async def get_drift_service(session: SessionDep) -> DriftService:
 DriftServiceDep = Annotated[DriftService, Depends(get_drift_service)]
 
 
+def _comparison_to_response(comparison) -> DriftComparisonResponse:
+    """Convert comparison model to response schema."""
+    return DriftComparisonResponse(
+        id=comparison.id,
+        baseline_source_id=comparison.baseline_source_id,
+        current_source_id=comparison.current_source_id,
+        has_drift=comparison.has_drift,
+        has_high_drift=comparison.has_high_drift,
+        total_columns=comparison.total_columns,
+        drifted_columns=comparison.drifted_columns,
+        drift_percentage=comparison.drift_percentage,
+        result=comparison.result_json,
+        config=comparison.config,
+        created_at=comparison.created_at,
+        updated_at=comparison.updated_at,
+    )
+
+
 @router.post(
     "/drift/compare",
-    response_model=dict,
+    response_model=DriftComparisonResponse,
     summary="Compare datasets for drift",
     description="Compare two datasets to detect data drift.",
 )
 async def compare_datasets(
     request: DriftCompareRequest,
     service: DriftServiceDep,
-) -> dict:
+) -> DriftComparisonResponse:
     """Compare two datasets for drift detection.
 
     Args:
@@ -54,28 +78,9 @@ async def compare_datasets(
             columns=request.columns,
             method=request.method,
             threshold=request.threshold,
-            correction=request.correction,
             sample_size=request.sample_size,
         )
-
-        return {
-            "success": True,
-            "data": {
-                "id": comparison.id,
-                "baseline_source_id": comparison.baseline_source_id,
-                "current_source_id": comparison.current_source_id,
-                "has_drift": comparison.has_drift,
-                "has_high_drift": comparison.has_high_drift,
-                "total_columns": comparison.total_columns,
-                "drifted_columns": comparison.drifted_columns,
-                "drift_percentage": comparison.drift_percentage,
-                "result": comparison.result_json,
-                "config": comparison.config,
-                "created_at": (
-                    comparison.created_at.isoformat() if comparison.created_at else None
-                ),
-            },
-        }
+        return _comparison_to_response(comparison)
     except ValueError as e:
         raise HTTPException(status_code=404, detail=str(e))
     except Exception as e:
@@ -94,6 +99,7 @@ async def list_comparisons(
         None, description="Filter by baseline source"
     ),
     current_source_id: str | None = Query(None, description="Filter by current source"),
+    offset: int = Query(0, ge=0, description="Offset for pagination"),
     limit: int = Query(20, ge=1, le=100, description="Maximum results"),
 ) -> DriftComparisonListResponse:
     """List drift comparisons.
@@ -102,10 +108,11 @@ async def list_comparisons(
         service: Drift service.
         baseline_source_id: Optional baseline source ID filter.
         current_source_id: Optional current source ID filter.
+        offset: Offset for pagination.
         limit: Maximum results to return.
 
     Returns:
-        List of drift comparisons.
+        Paginated list of drift comparisons.
     """
     comparisons = await service.list_comparisons(
         baseline_source_id=baseline_source_id,
@@ -113,37 +120,40 @@ async def list_comparisons(
         limit=limit,
     )
 
+    from truthound_dashboard.schemas.drift import DriftComparisonListItem
+
     return DriftComparisonListResponse(
-        success=True,
         data=[
-            {
-                "id": c.id,
-                "baseline_source_id": c.baseline_source_id,
-                "current_source_id": c.current_source_id,
-                "has_drift": c.has_drift,
-                "has_high_drift": c.has_high_drift,
-                "total_columns": c.total_columns,
-                "drifted_columns": c.drifted_columns,
-                "drift_percentage": c.drift_percentage,
-                "created_at": c.created_at.isoformat() if c.created_at else None,
-                "updated_at": c.updated_at.isoformat() if c.updated_at else None,
-            }
+            DriftComparisonListItem(
+                id=c.id,
+                baseline_source_id=c.baseline_source_id,
+                current_source_id=c.current_source_id,
+                has_drift=c.has_drift,
+                has_high_drift=c.has_high_drift,
+                total_columns=c.total_columns,
+                drifted_columns=c.drifted_columns,
+                drift_percentage=c.drift_percentage,
+                created_at=c.created_at,
+                updated_at=c.updated_at,
+            )
             for c in comparisons
         ],
         total=len(comparisons),
+        offset=offset,
+        limit=limit,
     )
 
 
 @router.get(
     "/drift/comparisons/{comparison_id}",
-    response_model=dict,
+    response_model=DriftComparisonResponse,
     summary="Get drift comparison",
     description="Get a specific drift comparison by ID.",
 )
 async def get_comparison(
     comparison_id: str,
     service: DriftServiceDep,
-) -> dict:
+) -> DriftComparisonResponse:
     """Get a drift comparison by ID.
 
     Args:
@@ -157,24 +167,4 @@ async def get_comparison(
     if comparison is None:
         raise HTTPException(status_code=404, detail="Comparison not found")
 
-    return {
-        "success": True,
-        "data": {
-            "id": comparison.id,
-            "baseline_source_id": comparison.baseline_source_id,
-            "current_source_id": comparison.current_source_id,
-            "has_drift": comparison.has_drift,
-            "has_high_drift": comparison.has_high_drift,
-            "total_columns": comparison.total_columns,
-            "drifted_columns": comparison.drifted_columns,
-            "drift_percentage": comparison.drift_percentage,
-            "result": comparison.result_json,
-            "config": comparison.config,
-            "created_at": (
-                comparison.created_at.isoformat() if comparison.created_at else None
-            ),
-            "updated_at": (
-                comparison.updated_at.isoformat() if comparison.updated_at else None
-            ),
-        },
-    }
+    return _comparison_to_response(comparison)