thailint 0.15.6__py3-none-any.whl → 0.16.0__py3-none-any.whl

src/linters/print_statements/conditional_verbose_rule.py

@@ -0,0 +1,254 @@
+"""
+Purpose: Lint rule for detecting conditional verbose logging anti-patterns
+
+Scope: Detection of if verbose: logger.*() patterns in Python code
+
+Overview: Implements the ConditionalVerboseRule that detects logging calls conditionally guarded
+    by verbose flags. This is an anti-pattern because logging levels should be configured through
+    the logging framework (e.g., logger.setLevel(logging.DEBUG)) rather than through code
+    conditionals. The rule reports violations with suggestions to remove the conditional and
+    configure logging levels properly. Only applies to Python files as this pattern is specific
+    to Python logging practices.
+
+Dependencies: BaseLintContext and BaseLintRule from core, ast module, conditional_verbose_analyzer
+
+Exports: ConditionalVerboseRule class implementing BaseLintRule interface
+
+Interfaces: check(context) -> list[Violation] for rule validation, standard rule properties
+    (rule_id, rule_name, description)
+
+Implementation: AST-based analysis using ConditionalVerboseAnalyzer for pattern detection
+"""
+
+import ast
+from pathlib import Path
+
+from src.core.base import BaseLintContext, BaseLintRule
+from src.core.constants import Language
+from src.core.linter_utils import has_file_content, load_linter_config
+from src.core.types import Violation
+from src.core.violation_utils import get_violation_line, has_python_noqa
+from src.linter_config.ignore import get_ignore_parser
+
+from .conditional_verbose_analyzer import ConditionalVerboseAnalyzer
+from .config import PrintStatementConfig
+
+
+class ConditionalVerboseRule(BaseLintRule):
+    """Detects conditional verbose logging patterns that should use log level configuration."""
+
+    def __init__(self) -> None:
+        """Initialize the conditional verbose rule."""
+        self._ignore_parser = get_ignore_parser()
+
+    @property
+    def rule_id(self) -> str:
+        """Unique identifier for this rule."""
+        return "improper-logging.conditional-verbose"
+
+    @property
+    def rule_name(self) -> str:
+        """Human-readable name for this rule."""
+        return "Improper Logging - Conditional Verbose"
+
+    @property
+    def description(self) -> str:
+        """Description of what this rule checks."""
+        return "Conditional verbose logging should use log level configuration instead"
+
+    def check(self, context: BaseLintContext) -> list[Violation]:
+        """Check for conditional verbose logging violations.
+
+        Only applies to Python files, as this pattern is Python-specific.
+
+        Args:
+            context: Lint context with file information
+
+        Returns:
+            List of violations found
+        """
+        if not self._should_analyze(context):
+            return []
+
+        tree = self._parse_python_code(context.file_content)
+        if tree is None:
+            return []
+
+        analyzer = ConditionalVerboseAnalyzer()
+        conditional_calls = analyzer.find_conditional_verbose_calls(tree)
+
+        return self._collect_violations(conditional_calls, context)
+
+    def _should_analyze(self, context: BaseLintContext) -> bool:
+        """Check if this file should be analyzed."""
+        if not has_file_content(context):
+            return False
+        if context.language != Language.PYTHON:
+            return False
+        config = self._load_config(context)
+        if not config.enabled:
+            return False
+        return not self._is_file_ignored(context, config)
+
+    def _load_config(self, context: BaseLintContext) -> PrintStatementConfig:
+        """Load configuration from context.
+
+        Uses the same config as print-statements linter for consistency.
+
+        Args:
+            context: Lint context
+
+        Returns:
+            PrintStatementConfig instance
+        """
+        test_config = self._try_load_test_config(context)
+        if test_config is not None:
+            return test_config
+
+        prod_config = self._try_load_production_config(context)
+        if prod_config is not None:
+            return prod_config
+
+        return PrintStatementConfig()
+
+    def _try_load_test_config(self, context: BaseLintContext) -> PrintStatementConfig | None:
+        """Try to load test-style configuration."""
+        if not hasattr(context, "config"):
+            return None
+        config_attr = context.config
+        if config_attr is None or not isinstance(config_attr, dict):
+            return None
+        return PrintStatementConfig.from_dict(config_attr, context.language)
+
+    def _try_load_production_config(self, context: BaseLintContext) -> PrintStatementConfig | None:
+        """Try to load production configuration."""
+        if not hasattr(context, "metadata") or not isinstance(context.metadata, dict):
+            return None
+
+        metadata = context.metadata
+        config_keys = ("print_statements", "print-statements", "improper-logging")
+
+        for key in config_keys:
+            if key in metadata:
+                return load_linter_config(context, key, PrintStatementConfig)
+
+        return None
+
+    def _is_file_ignored(self, context: BaseLintContext, config: PrintStatementConfig) -> bool:
+        """Check if file matches ignore patterns."""
+        if not config.ignore:
+            return False
+        if not context.file_path:
+            return False
+
+        file_path = Path(context.file_path)
+        return any(self._matches_pattern(file_path, pattern) for pattern in config.ignore)
+
+    def _matches_pattern(self, file_path: Path, pattern: str) -> bool:
+        """Check if file path matches a glob pattern."""
+        if file_path.match(pattern):
+            return True
+        if pattern in str(file_path):
+            return True
+        return False
+
+    def _parse_python_code(self, code: str | None) -> ast.AST | None:
+        """Parse Python code into AST."""
+        try:
+            return ast.parse(code or "")
+        except SyntaxError:
+            return None
+
+    def _collect_violations(
+        self,
+        conditional_calls: list[tuple[ast.If, ast.Call, str, int]],
+        context: BaseLintContext,
+    ) -> list[Violation]:
+        """Collect violations from conditional verbose logging patterns.
+
+        Args:
+            conditional_calls: List of (if_node, call_node, method_name, line_number) tuples
+            context: Lint context
+
+        Returns:
+            List of violations
+        """
+        violations = []
+        for _if_node, _call_node, method_name, line_number in conditional_calls:
+            violation = self._create_violation(method_name, line_number, context)
+            if not self._should_ignore(violation, context):
+                violations.append(violation)
+        return violations
+
+    def _create_violation(
+        self,
+        method_name: str,
+        line: int,
+        context: BaseLintContext,
+    ) -> Violation:
+        """Create a violation for a conditional verbose logging pattern.
+
+        Args:
+            method_name: The logger method name (debug, info, etc.)
+            line: Line number where the violation occurs
+            context: Lint context
+
+        Returns:
+            Violation object with details about the pattern
+        """
+        message = f"Conditional verbose check around logger.{method_name}() should be removed"
+        suggestion = (
+            "Remove the 'if verbose:' condition and configure logging level instead. "
+            "Use logger.setLevel(logging.DEBUG) to control verbosity."
+        )
+
+        return Violation(
+            rule_id=self.rule_id,
+            file_path=str(context.file_path) if context.file_path else "",
+            line=line,
+            column=0,
+            message=message,
+            suggestion=suggestion,
+        )
+
+    def _should_ignore(self, violation: Violation, context: BaseLintContext) -> bool:
+        """Check if violation should be ignored based on inline directives.
+
+        Args:
+            violation: Violation to check
+            context: Lint context with file content
+
+        Returns:
+            True if violation should be ignored
+        """
+        if self._ignore_parser.should_ignore_violation(violation, context.file_content or ""):
+            return True
+        return self._check_generic_ignore(violation, context)
+
+    def _check_generic_ignore(self, violation: Violation, context: BaseLintContext) -> bool:
+        """Check for generic ignore directives.
+
+        Args:
+            violation: Violation to check
+            context: Lint context
+
+        Returns:
+            True if line has generic ignore directive
+        """
+        line_text = get_violation_line(violation, context)
+        if line_text is None:
+            return False
+        return self._has_generic_ignore_directive(line_text)
+
+    def _has_generic_ignore_directive(self, line_text: str) -> bool:
+        """Check if line has generic ignore directive."""
+        if self._has_generic_thailint_ignore(line_text):
+            return True
+        return has_python_noqa(line_text)
+
+    def _has_generic_thailint_ignore(self, line_text: str) -> bool:
+        """Check for generic thailint: ignore (no brackets)."""
+        if "# thailint: ignore" not in line_text:
+            return False
+        after_ignore = line_text.split("# thailint: ignore")[1].split("#")[0]
+        return "[" not in after_ignore

src/linters/print_statements/linter.py

@@ -54,12 +54,12 @@ class PrintStatementRule(MultiLanguageLintRule):  # thailint: ignore[srp]
     @property
     def rule_id(self) -> str:
         """Unique identifier for this rule."""
-        return "print-statements.detected"
+        return "improper-logging.print-statement"
 
     @property
     def rule_name(self) -> str:
         """Human-readable name for this rule."""
-        return "Print Statements"
+        return "Improper Logging - Print Statement"
 
     @property
     def description(self) -> str:

{thailint-0.15.6.dist-info → thailint-0.16.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: thailint
-Version: 0.15.6
+Version: 0.16.0
 Summary: The AI Linter - Enterprise-grade linting and governance for AI-generated code across multiple languages
 License: MIT
 License-File: LICENSE
@@ -24,6 +24,7 @@ Classifier: Topic :: Software Development :: Testing
 Classifier: Topic :: Utilities
 Classifier: Typing :: Typed
 Requires-Dist: click (>=8.1.0,<9.0.0)
+Requires-Dist: loguru (>=0.7.3,<0.8.0)
 Requires-Dist: pyprojroot (>=0.3.0,<0.4.0)
 Requires-Dist: pyyaml (>=6.0,<7.0)
 Requires-Dist: tree-sitter (>=0.25.2,<0.26.0)
@@ -83,7 +84,7 @@ That's it. See violations, fix them, ship better code.
 | **Method Property** | Methods that should be @property | `thailint method-property src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/method-property-linter/) |
 | **File Placement** | Files in wrong directories | `thailint file-placement src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/file-placement-linter/) |
 | **Lazy Ignores** | Unjustified linting suppressions | `thailint lazy-ignores src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/lazy-ignores-linter/) |
-| **Print Statements** | Debug prints left in code | `thailint print-statements src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/print-statements-linter/) |
+| **Improper Logging** | Print statements and conditional verbose patterns | `thailint improper-logging src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/improper-logging-linter/) |
 | **Stringly Typed** | Strings that should be enums | `thailint stringly-typed src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/stringly-typed-linter/) |
 | **LBYL** | Look Before You Leap anti-patterns | `thailint lbyl src/` | [Guide](https://thai-lint.readthedocs.io/en/latest/lbyl-linter/) |
 
@@ -152,10 +153,12 @@ See [How to Ignore Violations](https://thai-lint.readthedocs.io/en/latest/how-to
 - name: Run thailint
   run: |
     pip install thai-lint
-    thailint dry src/
-    thailint nesting src/
+    thailint --parallel dry src/
+    thailint --parallel nesting src/
 ```
 
+Use `--parallel` for faster linting on large codebases (2-4x speedup on multi-core systems).
+
 Exit codes: `0` = success, `1` = violations found, `2` = error.
 
 ## Documentation

{thailint-0.15.6.dist-info → thailint-0.16.0.dist-info}/RECORD

@@ -7,21 +7,21 @@ src/analyzers/typescript_base.py,sha256=Dtc_2jLSNoadh53MyeW2syrJMBIMVPvotcM8SeDE
 src/api.py,sha256=pJ5l3qxccKBEY-BkANwzTgLAl1ZFq7OP6hx6LSxbhDw,4664
 src/cli/__init__.py,sha256=nMxKv4D0t09LwUm4Z5w-b7vIuyn24SFzv78BKzE3AOQ,1272
 src/cli/__main__.py,sha256=xIKI57yqB1NOw9eXnGXfU8rC2UwcAJYjDxlZbt9eP0w,671
-src/cli/config.py,sha256=wh9lp0Z2FUEKbYawB65Y9vrlu1Yiqe8-CD_vnRDqwEg,14467
+src/cli/config.py,sha256=uAcc1NMe4uvC5619wyGIrSJtOWeOWT3No8_qBvowqXk,14293
 src/cli/config_merge.py,sha256=A1eCthiLwjj0SEhOcxa6t2hYwWMapGJpL9sCmYvUFw4,8464
-src/cli/linters/__init__.py,sha256=Dlx2CRHT5_QeIeCJ0horPXci9zRP_KzSz_-mg0VMbOw,2343
-src/cli/linters/code_patterns.py,sha256=2AcFdLPPdkJ8U883ozXE_0eLWRdiL_xfzXm4kmRn-Ro,11072
-src/cli/linters/code_smells.py,sha256=yrKqRD3JTVVqyPL8rwK9VPbHgccXoj2IfaLK3lBF4Jc,11782
-src/cli/linters/documentation.py,sha256=AhkyXfH2FbcxXT3BV6GIKkGbWCjyrz8qcKhz3sx7Yww,3289
-src/cli/linters/performance.py,sha256=qvCW6T84zNZi1TyuxHtsEksgCtMA5TUgt_UdSq0vqHo,9878
-src/cli/linters/shared.py,sha256=eVXhBDr69fRGAP4lApTR_M0gDfLeWlDAqx6VCEAWXsU,10117
-src/cli/linters/structure.py,sha256=EGjw0zMLdGi4lTwM1zd_FzxQ7A-AG3fNPcKcF5uGFSo,10748
-src/cli/linters/structure_quality.py,sha256=0npTcI6OUMVmvd-Ha6NjDZb2Dn1EhpfTLXmMRB69qaI,10739
-src/cli/main.py,sha256=mRyRN_IQI2WyqDCxI8vuzdhbkCkVrK6INfJPjU8ayIU,3844
-src/cli/utils.py,sha256=wFMvW7ScseHxKgvAmuQCWWHBGbtBzu8oPwATsCyNsfU,12610
+src/cli/linters/__init__.py,sha256=Gf3_Ksh4a1TB86j4O2weCwrdCujOYvJ_YSOLFeG60J4,2501
+src/cli/linters/code_patterns.py,sha256=0ajlHI9kesHryBjF_YBHltMi2gjkPPacMxYoJ1h0Qck,11463
+src/cli/linters/code_smells.py,sha256=9J_CPdCFDv6fHQwfLP01PgBnF1c8DwioeIICLA-N7Zo,11608
+src/cli/linters/documentation.py,sha256=bvrW4OfgeKOYlzzHv3Zl-XjGjItviX_zLlP94btlUkI,3211
+src/cli/linters/performance.py,sha256=TZoe8hs-5j68tUiiKRwnhdGEKm432QlmwAG4eAqgcVo,9747
+src/cli/linters/shared.py,sha256=dC8SS8UxJR3WvQr1SkWJAf-AZalN-u-eDrM-FXmKqtw,10043
+src/cli/linters/structure.py,sha256=4SxM2ekq2OPDQfEXxKuQAEn7pqt6cGrLgHLqZ4S57eQ,10636
+src/cli/linters/structure_quality.py,sha256=5cCPz9Jmtvzr3hZZjac3aVFmUIH7HLlkshv_rvs12xI,10627
+src/cli/main.py,sha256=VUtesVpLXeRP9fb2Ko_imGeUybO7JhImsJnHYxQTIN4,3852
+src/cli/utils.py,sha256=5IYu9KltZEg76wgbW-qfKwcXzCK3qsEuvgnr4i_UkqY,12437
 src/cli_main.py,sha256=C0Ey7YNlG3ipqb3KsJZ8rL8PJ4ueVp_45IUirGidvHI,1618
 src/config.py,sha256=O3ixzsYekGjlggmIsawCU1bctOa0MyG2IczHpg3mGyw,12753
-src/core/__init__.py,sha256=5FtsDvhMt4SNRx3pbcGURrxn135XRbeRrjSUxiXwkNc,381
+src/core/__init__.py,sha256=1iGdoUB15Hi7xT7jwxUybP3e5IbQ6yiM34IbFNJRCaE,703
 src/core/base.py,sha256=u5A8geprlKnsJk4ShiLHTKXRekZUB4I6rPQWxgiFeto,8019
 src/core/cli_utils.py,sha256=o7lWPSlic96lRyfcsmBf8S1ej25M1-wlclx8_Eup20g,7446
 src/core/config_parser.py,sha256=CRHV2-csxag6yQzx_4IYYz57QSUYjPkeSb0XvOyshRI,4272
@@ -29,6 +29,7 @@ src/core/constants.py,sha256=PKtPDqk6k9VuOSgjq1FAdi2CTvlnhdXvLj91dNaMDTA,1584
 src/core/linter_utils.py,sha256=StnKFzJgSvLyao1S0LpTKhsXo8nOwpdKpxo7mXl5PIg,8594
 src/core/python_lint_rule.py,sha256=OpdIDLPV1MDtmjy6GPrrOA3_rRV2_x14keHAQQtI_pc,3516
 src/core/registry.py,sha256=yRA8mQLiZwjmgxl1wSTgdj1cuo_QXuRdrXt3NpCBUgE,3285
+src/core/rule_aliases.py,sha256=EEPrI2syrK18Zg1oHZBMNiU1Z-zIdORJjXTAN738h1A,2570
 src/core/rule_discovery.py,sha256=tgRH-BJGKsQTxfa249yrY7UJuonRjobMCENqmhcbAeY,5496
 src/core/types.py,sha256=SElFzf_VSrAMsoiE0aU8ZYXuvKqdfwfM5umUHx4eT8w,3342
 src/core/violation_builder.py,sha256=dOPFfZx6U5_TMgaTop-4SUV2jHOZjBo67uwgiS_s-uE,6694
@@ -40,7 +41,7 @@ src/linter_config/directive_markers.py,sha256=nRc2Mp3B1mn6tu1XH88ugMxWffk1k8OUNo
 src/linter_config/ignore.py,sha256=40afiMsu1zC29RiwGX8hUPUqM056H_wcOgZZUNOwIes,13111
 src/linter_config/loader.py,sha256=K6mKRkP2jgwar-pwBoJGWgwynLVjqdez-l3Nd6bUCMk,3363
 src/linter_config/pattern_utils.py,sha256=BjV95SySST3HqZBwF1Og8yoHqFxuqQ16VPCacE21ks0,2056
-src/linter_config/rule_matcher.py,sha256=EWqSv4UY90fWps3AzDCSF7PZCbYyFTEBZT2h_txcRms,2779
+src/linter_config/rule_matcher.py,sha256=5q-cO9S2JbIB3Hr1BU4yAPmbS89eE7y7leiMfaMCKVk,4555
 src/linters/__init__.py,sha256=-nnNsL8E5-2p9qlLKp_TaShHAjPH-NacOEU1sXmAR9k,77
 src/linters/collection_pipeline/__init__.py,sha256=BcnbY3wgJB1XLfZ9J9qfUJQ1_yCo_THjGDTppxJEMZY,3231
 src/linters/collection_pipeline/any_all_analyzer.py,sha256=u8NGIYrJTuP3U6je5rkeEUV2Bh1yePC12vl-czAU5GU,7554
@@ -170,9 +171,11 @@ src/linters/performance/regex_analyzer.py,sha256=GZKf3jWWH28TxGlTqDeyd97JDbxjIT1
 src/linters/performance/regex_linter.py,sha256=velv84oQ3TxP9cJlYmSts3_DjS1h-RINuZDmQx-YatU,5078
 src/linters/performance/typescript_analyzer.py,sha256=t0jvLvVG97ffgC-4KhXobKa9iG9iGREOV5Kta7XsbFw,8740
 src/linters/performance/violation_builder.py,sha256=q4fy3SVVrveyYYg9O2-MZfWjlHlKRP3llH1-8VQ6sUU,5752
-src/linters/print_statements/__init__.py,sha256=yhvdTFSqBB4UDreeadTHKFzhayxeT6JkF3yxUHMgn1g,1893
+src/linters/print_statements/__init__.py,sha256=xvqQOc3Lp_YAJChFQh-DnX9KCkj4hksRBFFE_7i5nKA,2268
+src/linters/print_statements/conditional_verbose_analyzer.py,sha256=qhspk0WAC3zGBVGsLFogtbyQrVnb6doLnXhcgbZFdFc,6475
+src/linters/print_statements/conditional_verbose_rule.py,sha256=uGsKXDbuHBTHfFj3ScqK1xh-BvAJ7TrJhWgpHHthLoE,9290
 src/linters/print_statements/config.py,sha256=rth3XmzqZGzXkRXDIVZswdtNOXIe1vIRaF46tVLKnyQ,3041
-src/linters/print_statements/linter.py,sha256=CcKolaaHYJzhpxWXthYZ7xXhfTnxmyOIhuE40Ly3ofA,14351
+src/linters/print_statements/linter.py,sha256=er--FN_uu6C3wxxUti13-wG1GkjeVU0Mx_2uHGGFxcc,14376
 src/linters/print_statements/python_analyzer.py,sha256=48IDRQEv861B90qCl5w8ASxcXR7juZ429YX2ST9n2ic,5028
 src/linters/print_statements/typescript_analyzer.py,sha256=EFE3bjRENvCPEYmNNxZ4jiq1VCA-rEUAJ_VFWJApLqY,4935
 src/linters/print_statements/violation_builder.py,sha256=Vs5m3AnWjrQqQHf6JJDaPP5B1V3YNl5pepG_oiTJnx4,3333
@@ -220,8 +223,8 @@ src/orchestrator/language_detector.py,sha256=ALt2BEZKXQM2dWr1ChF9lZVj83YF4Bl9xwr
 src/templates/thailint_config_template.yaml,sha256=57ZtLxnIoOHtR5Ejq3clb4nhY9J4n6h36XFb79ZZPlc,12020
 src/utils/__init__.py,sha256=NiBtKeQ09Y3kuUzeN4O1JNfUIYPQDS2AP1l5ODq-Dec,125
 src/utils/project_root.py,sha256=aaxUM-LQ1okrPClmZWPFd_D09W3V1ArgJiidEEp_eU8,6262
-thailint-0.15.6.dist-info/METADATA,sha256=0ZW5TC2eyix3Bil_XocUFO4fcOCK037NB3d0CLvCdkI,7202
-thailint-0.15.6.dist-info/WHEEL,sha256=zp0Cn7JsFoX2ATtOhtaFYIiE2rmFAD4OcMhtUki8W3U,88
-thailint-0.15.6.dist-info/entry_points.txt,sha256=DNoGUlxpaMFqxQDgHp1yeGqohOjdFR-kH19uHYi3OUY,72
-thailint-0.15.6.dist-info/licenses/LICENSE,sha256=kxh1J0Sb62XvhNJ6MZsVNe8PqNVJ7LHRn_EWa-T3djw,1070
-thailint-0.15.6.dist-info/RECORD,,
+thailint-0.16.0.dist-info/METADATA,sha256=Q5acUtAfA1CtsNVOj3tdeyU8Ly05QycjyDW6QXBD7Pk,7381
+thailint-0.16.0.dist-info/WHEEL,sha256=zp0Cn7JsFoX2ATtOhtaFYIiE2rmFAD4OcMhtUki8W3U,88
+thailint-0.16.0.dist-info/entry_points.txt,sha256=DNoGUlxpaMFqxQDgHp1yeGqohOjdFR-kH19uHYi3OUY,72
+thailint-0.16.0.dist-info/licenses/LICENSE,sha256=kxh1J0Sb62XvhNJ6MZsVNe8PqNVJ7LHRn_EWa-T3djw,1070
+thailint-0.16.0.dist-info/RECORD,,