thailint 0.1.6__py3-none-any.whl → 0.2.1__py3-none-any.whl
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- src/__init__.py +7 -2
- src/analyzers/__init__.py +23 -0
- src/analyzers/typescript_base.py +148 -0
- src/api.py +1 -1
- src/cli.py +524 -141
- src/config.py +6 -31
- src/core/base.py +12 -0
- src/core/cli_utils.py +206 -0
- src/core/config_parser.py +99 -0
- src/core/linter_utils.py +168 -0
- src/core/registry.py +17 -92
- src/core/rule_discovery.py +132 -0
- src/core/violation_builder.py +122 -0
- src/linter_config/ignore.py +112 -40
- src/linter_config/loader.py +3 -13
- src/linters/dry/__init__.py +23 -0
- src/linters/dry/base_token_analyzer.py +76 -0
- src/linters/dry/block_filter.py +262 -0
- src/linters/dry/block_grouper.py +59 -0
- src/linters/dry/cache.py +218 -0
- src/linters/dry/cache_query.py +61 -0
- src/linters/dry/config.py +130 -0
- src/linters/dry/config_loader.py +44 -0
- src/linters/dry/deduplicator.py +120 -0
- src/linters/dry/duplicate_storage.py +126 -0
- src/linters/dry/file_analyzer.py +127 -0
- src/linters/dry/inline_ignore.py +140 -0
- src/linters/dry/linter.py +170 -0
- src/linters/dry/python_analyzer.py +517 -0
- src/linters/dry/storage_initializer.py +51 -0
- src/linters/dry/token_hasher.py +115 -0
- src/linters/dry/typescript_analyzer.py +590 -0
- src/linters/dry/violation_builder.py +74 -0
- src/linters/dry/violation_filter.py +91 -0
- src/linters/dry/violation_generator.py +174 -0
- src/linters/file_placement/config_loader.py +86 -0
- src/linters/file_placement/directory_matcher.py +80 -0
- src/linters/file_placement/linter.py +252 -472
- src/linters/file_placement/path_resolver.py +61 -0
- src/linters/file_placement/pattern_matcher.py +55 -0
- src/linters/file_placement/pattern_validator.py +106 -0
- src/linters/file_placement/rule_checker.py +229 -0
- src/linters/file_placement/violation_factory.py +177 -0
- src/linters/nesting/config.py +13 -3
- src/linters/nesting/linter.py +76 -152
- src/linters/nesting/typescript_analyzer.py +38 -102
- src/linters/nesting/typescript_function_extractor.py +130 -0
- src/linters/nesting/violation_builder.py +139 -0
- src/linters/srp/__init__.py +99 -0
- src/linters/srp/class_analyzer.py +113 -0
- src/linters/srp/config.py +76 -0
- src/linters/srp/heuristics.py +89 -0
- src/linters/srp/linter.py +225 -0
- src/linters/srp/metrics_evaluator.py +47 -0
- src/linters/srp/python_analyzer.py +72 -0
- src/linters/srp/typescript_analyzer.py +75 -0
- src/linters/srp/typescript_metrics_calculator.py +90 -0
- src/linters/srp/violation_builder.py +117 -0
- src/orchestrator/core.py +42 -7
- src/utils/__init__.py +4 -0
- src/utils/project_root.py +84 -0
- {thailint-0.1.6.dist-info → thailint-0.2.1.dist-info}/METADATA +414 -63
- thailint-0.2.1.dist-info/RECORD +75 -0
- src/.ai/layout.yaml +0 -48
- thailint-0.1.6.dist-info/RECORD +0 -28
- {thailint-0.1.6.dist-info → thailint-0.2.1.dist-info}/LICENSE +0 -0
- {thailint-0.1.6.dist-info → thailint-0.2.1.dist-info}/WHEEL +0 -0
- {thailint-0.1.6.dist-info → thailint-0.2.1.dist-info}/entry_points.txt +0 -0
|
@@ -1,57 +1,56 @@
|
|
|
1
1
|
"""
|
|
2
2
|
Purpose: File placement linter implementation
|
|
3
|
+
|
|
3
4
|
Scope: Validate file organization against allow/deny patterns
|
|
5
|
+
|
|
4
6
|
Overview: Implements file placement validation using regex patterns from JSON/YAML config.
|
|
5
|
-
|
|
6
|
-
|
|
7
|
+
Orchestrates configuration loading, pattern validation, path resolution, rule checking,
|
|
8
|
+
and violation creation through focused helper classes. Supports directory-specific rules,
|
|
9
|
+
global patterns, and generates helpful suggestions. Main linter class acts as coordinator.
|
|
10
|
+
|
|
11
|
+
Dependencies: src.core (base classes, types), pathlib, typing
|
|
12
|
+
|
|
7
13
|
Exports: FilePlacementLinter, FilePlacementRule
|
|
8
|
-
|
|
14
|
+
|
|
15
|
+
Implementation: Composition pattern with helper classes for each responsibility
|
|
16
|
+
|
|
17
|
+
SRP Exception: FilePlacementRule has 13 methods (exceeds max 8)
|
|
18
|
+
Justification: Framework adapter class that bridges BaseLintRule interface with
|
|
19
|
+
FilePlacementLinter implementation. Must handle multiple config sources (metadata vs file),
|
|
20
|
+
multiple config formats (wrapped vs unwrapped), project root detection with fallbacks,
|
|
21
|
+
and linter caching. This complexity is inherent to adapter pattern - splitting would
|
|
22
|
+
create unnecessary indirection between framework and implementation without improving
|
|
23
|
+
maintainability. All methods are focused on the single responsibility of integrating
|
|
24
|
+
file placement validation with the linting framework.
|
|
9
25
|
"""
|
|
10
26
|
|
|
11
27
|
import json
|
|
12
|
-
import re
|
|
13
28
|
from pathlib import Path
|
|
14
29
|
from typing import Any
|
|
15
30
|
|
|
16
31
|
import yaml
|
|
17
32
|
|
|
18
33
|
from src.core.base import BaseLintContext, BaseLintRule
|
|
19
|
-
from src.core.types import
|
|
34
|
+
from src.core.types import Violation
|
|
20
35
|
|
|
36
|
+
from .config_loader import ConfigLoader
|
|
37
|
+
from .path_resolver import PathResolver
|
|
38
|
+
from .pattern_matcher import PatternMatcher
|
|
39
|
+
from .pattern_validator import PatternValidator
|
|
40
|
+
from .rule_checker import RuleChecker
|
|
41
|
+
from .violation_factory import ViolationFactory
|
|
21
42
|
|
|
22
|
-
class PatternMatcher:
|
|
23
|
-
"""Handles regex pattern matching for file paths."""
|
|
24
43
|
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
) -> tuple[bool, str | None]:
|
|
28
|
-
"""Check if path matches any deny patterns.
|
|
44
|
+
class _Components:
|
|
45
|
+
"""Container for linter components to reduce instance attributes."""
|
|
29
46
|
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
for deny_item in deny_patterns:
|
|
38
|
-
pattern = deny_item["pattern"]
|
|
39
|
-
if re.search(pattern, path_str, re.IGNORECASE):
|
|
40
|
-
reason = deny_item.get("reason", "File not allowed in this location")
|
|
41
|
-
return True, reason
|
|
42
|
-
return False, None
|
|
43
|
-
|
|
44
|
-
def match_allow_patterns(self, path_str: str, allow_patterns: list[str]) -> bool:
|
|
45
|
-
"""Check if path matches any allow patterns.
|
|
46
|
-
|
|
47
|
-
Args:
|
|
48
|
-
path_str: File path to check
|
|
49
|
-
allow_patterns: List of regex patterns
|
|
50
|
-
|
|
51
|
-
Returns:
|
|
52
|
-
True if path matches any pattern
|
|
53
|
-
"""
|
|
54
|
-
return any(re.search(pattern, path_str, re.IGNORECASE) for pattern in allow_patterns)
|
|
47
|
+
def __init__(self, project_root: Path):
|
|
48
|
+
self.config_loader = ConfigLoader(project_root)
|
|
49
|
+
self.path_resolver = PathResolver(project_root)
|
|
50
|
+
self.pattern_matcher = PatternMatcher()
|
|
51
|
+
self.pattern_validator = PatternValidator()
|
|
52
|
+
self.violation_factory = ViolationFactory()
|
|
53
|
+
self.rule_checker = RuleChecker(self.pattern_matcher, self.violation_factory)
|
|
55
54
|
|
|
56
55
|
|
|
57
56
|
class FilePlacementLinter:
|
|
@@ -71,551 +70,332 @@ class FilePlacementLinter:
|
|
|
71
70
|
project_root: Project root directory
|
|
72
71
|
"""
|
|
73
72
|
self.project_root = project_root or Path.cwd()
|
|
74
|
-
self.
|
|
73
|
+
self._components = _Components(self.project_root)
|
|
75
74
|
|
|
76
|
-
# Load config
|
|
75
|
+
# Load and validate config
|
|
77
76
|
if config_obj:
|
|
78
|
-
|
|
77
|
+
# Handle both wrapped and unwrapped config formats
|
|
78
|
+
# Wrapped: {"file-placement": {...}}
|
|
79
|
+
# Unwrapped: {"directories": {...}, "global_deny": [...], ...}
|
|
80
|
+
self.config = config_obj.get("file-placement", config_obj)
|
|
79
81
|
elif config_file:
|
|
80
|
-
self.config = self.
|
|
82
|
+
self.config = self._components.config_loader.load_config_file(config_file)
|
|
81
83
|
else:
|
|
82
84
|
self.config = {}
|
|
83
85
|
|
|
84
86
|
# Validate regex patterns in config
|
|
85
|
-
self.
|
|
87
|
+
self._components.pattern_validator.validate_config(self.config)
|
|
86
88
|
|
|
87
|
-
def
|
|
88
|
-
"""
|
|
89
|
+
def lint_path(self, file_path: Path) -> list[Violation]:
|
|
90
|
+
"""Lint a single file path.
|
|
89
91
|
|
|
90
92
|
Args:
|
|
91
|
-
|
|
93
|
+
file_path: File to lint
|
|
92
94
|
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
"""
|
|
96
|
-
try:
|
|
97
|
-
re.compile(pattern)
|
|
98
|
-
except re.error as e:
|
|
99
|
-
raise ValueError(f"Invalid regex pattern '{pattern}': {e}") from e
|
|
100
|
-
|
|
101
|
-
def _validate_allow_patterns(self, rules: dict[str, Any]) -> None:
|
|
102
|
-
"""Validate allow patterns in a rules dict."""
|
|
103
|
-
if "allow" in rules:
|
|
104
|
-
for pattern in rules["allow"]:
|
|
105
|
-
self._validate_pattern(pattern)
|
|
106
|
-
|
|
107
|
-
def _validate_deny_patterns(self, rules: dict[str, Any]) -> None:
|
|
108
|
-
"""Validate deny patterns in a rules dict."""
|
|
109
|
-
if "deny" in rules:
|
|
110
|
-
for deny_item in rules["deny"]:
|
|
111
|
-
pattern = deny_item.get("pattern", "")
|
|
112
|
-
self._validate_pattern(pattern)
|
|
113
|
-
|
|
114
|
-
def _validate_directory_patterns(self, fp_config: dict[str, Any]) -> None:
|
|
115
|
-
"""Validate all directory-specific patterns."""
|
|
116
|
-
if "directories" in fp_config:
|
|
117
|
-
for _dir_path, rules in fp_config["directories"].items():
|
|
118
|
-
self._validate_allow_patterns(rules)
|
|
119
|
-
self._validate_deny_patterns(rules)
|
|
120
|
-
|
|
121
|
-
def _validate_global_patterns(self, fp_config: dict[str, Any]) -> None:
|
|
122
|
-
"""Validate global patterns section."""
|
|
123
|
-
if "global_patterns" in fp_config:
|
|
124
|
-
self._validate_allow_patterns(fp_config["global_patterns"])
|
|
125
|
-
self._validate_deny_patterns(fp_config["global_patterns"])
|
|
126
|
-
|
|
127
|
-
def _validate_global_deny_patterns(self, fp_config: dict[str, Any]) -> None:
|
|
128
|
-
"""Validate global_deny patterns."""
|
|
129
|
-
if "global_deny" in fp_config:
|
|
130
|
-
for deny_item in fp_config["global_deny"]:
|
|
131
|
-
pattern = deny_item.get("pattern", "")
|
|
132
|
-
self._validate_pattern(pattern)
|
|
133
|
-
|
|
134
|
-
def _validate_regex_patterns(self) -> None:
|
|
135
|
-
"""Validate all regex patterns in config.
|
|
136
|
-
|
|
137
|
-
Raises:
|
|
138
|
-
re.error: If any regex pattern is invalid
|
|
95
|
+
Returns:
|
|
96
|
+
List of violations found
|
|
139
97
|
"""
|
|
140
|
-
|
|
141
|
-
|
|
142
|
-
|
|
143
|
-
self.
|
|
144
|
-
self.
|
|
145
|
-
|
|
146
|
-
def _resolve_config_path(self, config_file: str) -> Path:
|
|
147
|
-
"""Resolve config file path relative to project root."""
|
|
148
|
-
config_path = Path(config_file)
|
|
149
|
-
if not config_path.is_absolute():
|
|
150
|
-
config_path = self.project_root / config_path
|
|
151
|
-
return config_path
|
|
152
|
-
|
|
153
|
-
def _parse_config_file(self, config_path: Path) -> dict[str, Any]:
|
|
154
|
-
"""Parse config file based on extension."""
|
|
155
|
-
with config_path.open(encoding="utf-8") as f:
|
|
156
|
-
if config_path.suffix in [".yaml", ".yml"]:
|
|
157
|
-
return yaml.safe_load(f) or {}
|
|
158
|
-
if config_path.suffix == ".json":
|
|
159
|
-
return json.load(f)
|
|
160
|
-
raise ValueError(f"Unsupported config format: {config_path.suffix}")
|
|
98
|
+
rel_path = self._components.path_resolver.get_relative_path(file_path)
|
|
99
|
+
path_str = self._components.path_resolver.normalize_path_string(rel_path)
|
|
100
|
+
# Config is already unwrapped from file-placement key in _load_layout_config
|
|
101
|
+
fp_config = self.config
|
|
102
|
+
return self._components.rule_checker.check_all_rules(path_str, rel_path, fp_config)
|
|
161
103
|
|
|
162
|
-
def
|
|
163
|
-
"""
|
|
104
|
+
def check_file_allowed(self, file_path: Path) -> bool:
|
|
105
|
+
"""Check if file is allowed (no violations).
|
|
164
106
|
|
|
165
107
|
Args:
|
|
166
|
-
|
|
108
|
+
file_path: File to check
|
|
167
109
|
|
|
168
110
|
Returns:
|
|
169
|
-
|
|
111
|
+
True if file is allowed (no violations)
|
|
112
|
+
"""
|
|
113
|
+
violations = self.lint_path(file_path)
|
|
114
|
+
return len(violations) == 0
|
|
115
|
+
|
|
116
|
+
def lint_directory(self, dir_path: Path, recursive: bool = True) -> list[Violation]:
|
|
117
|
+
"""Lint all files in directory.
|
|
118
|
+
|
|
119
|
+
Args:
|
|
120
|
+
dir_path: Directory to scan
|
|
121
|
+
recursive: Scan recursively
|
|
170
122
|
|
|
171
|
-
|
|
172
|
-
|
|
123
|
+
Returns:
|
|
124
|
+
List of all violations found
|
|
173
125
|
"""
|
|
174
|
-
|
|
175
|
-
if not config_path.exists():
|
|
176
|
-
return {}
|
|
177
|
-
return self._parse_config_file(config_path)
|
|
126
|
+
from src.linter_config.ignore import IgnoreDirectiveParser
|
|
178
127
|
|
|
179
|
-
|
|
180
|
-
""
|
|
181
|
-
|
|
182
|
-
|
|
183
|
-
|
|
184
|
-
|
|
185
|
-
|
|
186
|
-
|
|
187
|
-
|
|
188
|
-
|
|
189
|
-
|
|
190
|
-
def _check_all_rules(
|
|
191
|
-
self, path_str: str, rel_path: Path, fp_config: dict[str, Any]
|
|
192
|
-
) -> list[Violation]:
|
|
193
|
-
"""Check all file placement rules."""
|
|
194
|
-
violations: list[Violation] = []
|
|
195
|
-
|
|
196
|
-
if "directories" in fp_config:
|
|
197
|
-
dir_violations = self._check_directory_rules(
|
|
198
|
-
path_str, rel_path, fp_config["directories"]
|
|
199
|
-
)
|
|
200
|
-
violations.extend(dir_violations)
|
|
201
|
-
|
|
202
|
-
if "global_deny" in fp_config:
|
|
203
|
-
deny_violations = self._check_global_deny(path_str, rel_path, fp_config["global_deny"])
|
|
204
|
-
violations.extend(deny_violations)
|
|
205
|
-
|
|
206
|
-
if "global_patterns" in fp_config:
|
|
207
|
-
global_violations = self._check_global_patterns(
|
|
208
|
-
path_str, rel_path, fp_config["global_patterns"]
|
|
209
|
-
)
|
|
210
|
-
violations.extend(global_violations)
|
|
128
|
+
ignore_parser = IgnoreDirectiveParser(self.project_root)
|
|
129
|
+
pattern = "**/*" if recursive else "*"
|
|
130
|
+
|
|
131
|
+
violations = []
|
|
132
|
+
for file_path in dir_path.glob(pattern):
|
|
133
|
+
if not file_path.is_file():
|
|
134
|
+
continue
|
|
135
|
+
if ignore_parser.is_ignored(file_path):
|
|
136
|
+
continue
|
|
137
|
+
file_violations = self.lint_path(file_path)
|
|
138
|
+
violations.extend(file_violations)
|
|
211
139
|
|
|
212
140
|
return violations
|
|
213
141
|
|
|
214
|
-
def lint_path(self, file_path: Path) -> list[Violation]:
|
|
215
|
-
"""Lint a single file path.
|
|
216
142
|
|
|
217
|
-
|
|
218
|
-
|
|
143
|
+
class FilePlacementRule(BaseLintRule): # thailint: ignore[srp.violation]
|
|
144
|
+
"""File placement linting rule (integrates with framework).
|
|
219
145
|
|
|
220
|
-
|
|
221
|
-
|
|
146
|
+
SRP suppression: Framework adapter class requires 13 methods to bridge
|
|
147
|
+
BaseLintRule interface with FilePlacementLinter. See file header for justification.
|
|
148
|
+
"""
|
|
149
|
+
|
|
150
|
+
def __init__(self, config: dict[str, Any] | None = None):
|
|
151
|
+
"""Initialize rule with config.
|
|
152
|
+
|
|
153
|
+
Args:
|
|
154
|
+
config: Rule configuration
|
|
222
155
|
"""
|
|
223
|
-
|
|
224
|
-
|
|
225
|
-
fp_config = self.config.get("file-placement", {})
|
|
226
|
-
return self._check_all_rules(path_str, rel_path, fp_config)
|
|
227
|
-
|
|
228
|
-
def _create_deny_violation(self, rel_path: Path, matched_path: str, reason: str) -> Violation:
|
|
229
|
-
"""Create violation for denied file."""
|
|
230
|
-
message = f"File '{rel_path}' not allowed in {matched_path}: {reason}"
|
|
231
|
-
suggestion = self._get_suggestion(rel_path.name, matched_path)
|
|
232
|
-
return Violation(
|
|
233
|
-
rule_id="file-placement",
|
|
234
|
-
file_path=str(rel_path),
|
|
235
|
-
line=1,
|
|
236
|
-
column=0,
|
|
237
|
-
message=message,
|
|
238
|
-
severity=Severity.ERROR,
|
|
239
|
-
suggestion=suggestion,
|
|
240
|
-
)
|
|
241
|
-
|
|
242
|
-
def _create_allow_violation(self, rel_path: Path, matched_path: str) -> Violation:
|
|
243
|
-
"""Create violation for file not matching allow patterns."""
|
|
244
|
-
message = f"File '{rel_path}' does not match allowed patterns for {matched_path}"
|
|
245
|
-
suggestion = f"Move to {matched_path} or ensure file type is allowed"
|
|
246
|
-
return Violation(
|
|
247
|
-
rule_id="file-placement",
|
|
248
|
-
file_path=str(rel_path),
|
|
249
|
-
line=1,
|
|
250
|
-
column=0,
|
|
251
|
-
message=message,
|
|
252
|
-
severity=Severity.ERROR,
|
|
253
|
-
suggestion=suggestion,
|
|
254
|
-
)
|
|
255
|
-
|
|
256
|
-
def _check_deny_patterns(
|
|
257
|
-
self, path_str: str, rel_path: Path, dir_rule: dict[str, Any], matched_path: str
|
|
258
|
-
) -> list[Violation]:
|
|
259
|
-
"""Check deny patterns and return violations if denied."""
|
|
260
|
-
if "deny" not in dir_rule:
|
|
261
|
-
return []
|
|
156
|
+
self.config = config or {}
|
|
157
|
+
self._linter_cache: dict[Path, FilePlacementLinter] = {}
|
|
262
158
|
|
|
263
|
-
|
|
264
|
-
|
|
265
|
-
|
|
266
|
-
return
|
|
159
|
+
@property
|
|
160
|
+
def rule_id(self) -> str:
|
|
161
|
+
"""Return rule ID."""
|
|
162
|
+
return "file-placement"
|
|
267
163
|
|
|
268
|
-
|
|
269
|
-
|
|
270
|
-
|
|
271
|
-
|
|
272
|
-
if "allow" not in dir_rule:
|
|
273
|
-
return []
|
|
164
|
+
@property
|
|
165
|
+
def rule_name(self) -> str:
|
|
166
|
+
"""Return rule name."""
|
|
167
|
+
return "File Placement"
|
|
274
168
|
|
|
275
|
-
|
|
276
|
-
|
|
277
|
-
|
|
169
|
+
@property
|
|
170
|
+
def description(self) -> str:
|
|
171
|
+
"""Return rule description."""
|
|
172
|
+
return "Validate file organization against project structure rules"
|
|
278
173
|
|
|
279
|
-
def
|
|
280
|
-
|
|
281
|
-
) -> list[Violation]:
|
|
282
|
-
"""Check file against directory-specific rules.
|
|
174
|
+
def check(self, context: BaseLintContext) -> list[Violation]:
|
|
175
|
+
"""Check file placement.
|
|
283
176
|
|
|
284
177
|
Args:
|
|
285
|
-
|
|
286
|
-
rel_path: Relative path
|
|
287
|
-
directories: Directory rules config
|
|
178
|
+
context: Lint context
|
|
288
179
|
|
|
289
180
|
Returns:
|
|
290
181
|
List of violations
|
|
291
182
|
"""
|
|
292
|
-
|
|
293
|
-
if not dir_rule or not matched_path:
|
|
183
|
+
if not context.file_path:
|
|
294
184
|
return []
|
|
295
185
|
|
|
296
|
-
|
|
297
|
-
|
|
298
|
-
|
|
299
|
-
|
|
300
|
-
return self._check_allow_patterns(path_str, rel_path, dir_rule, matched_path)
|
|
301
|
-
|
|
302
|
-
def _check_root_match(self, dir_path: str, path_str: str) -> tuple[bool, int]:
|
|
303
|
-
"""Check if path matches root directory rule."""
|
|
304
|
-
if dir_path == "/" and "/" not in path_str:
|
|
305
|
-
return True, 0
|
|
306
|
-
return False, -1
|
|
307
|
-
|
|
308
|
-
def _check_path_match(self, dir_path: str, path_str: str) -> tuple[bool, int]:
|
|
309
|
-
"""Check if path matches directory rule."""
|
|
310
|
-
if dir_path == "/":
|
|
311
|
-
return self._check_root_match(dir_path, path_str)
|
|
312
|
-
if path_str.startswith(dir_path):
|
|
313
|
-
depth = len(dir_path.split("/"))
|
|
314
|
-
return True, depth
|
|
315
|
-
return False, -1
|
|
186
|
+
project_root = self._get_project_root(context)
|
|
187
|
+
linter = self._get_or_create_linter(project_root, context)
|
|
188
|
+
return linter.lint_path(context.file_path)
|
|
316
189
|
|
|
317
|
-
def
|
|
318
|
-
|
|
319
|
-
) -> tuple[dict[str, Any] | None, str | None]:
|
|
320
|
-
"""Find most specific directory rule matching the path.
|
|
190
|
+
def _get_project_root(self, context: BaseLintContext) -> Path:
|
|
191
|
+
"""Get project root from context or detect it.
|
|
321
192
|
|
|
322
193
|
Args:
|
|
323
|
-
|
|
324
|
-
directories: Directory rules
|
|
194
|
+
context: Lint context
|
|
325
195
|
|
|
326
196
|
Returns:
|
|
327
|
-
|
|
197
|
+
Project root directory path
|
|
328
198
|
"""
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
for dir_path, rules in directories.items():
|
|
334
|
-
matches, depth = self._check_path_match(dir_path, path_str)
|
|
335
|
-
if matches and depth > best_depth:
|
|
336
|
-
best_match = rules
|
|
337
|
-
best_path = dir_path
|
|
338
|
-
best_depth = depth
|
|
199
|
+
# Use project root from orchestrator metadata if available
|
|
200
|
+
metadata_root = self._get_root_from_metadata(context)
|
|
201
|
+
if metadata_root is not None:
|
|
202
|
+
return metadata_root
|
|
339
203
|
|
|
340
|
-
|
|
204
|
+
# Otherwise detect it from file path
|
|
205
|
+
return self._detect_project_root(context)
|
|
341
206
|
|
|
342
|
-
def
|
|
343
|
-
|
|
344
|
-
) -> list[Violation]:
|
|
345
|
-
"""Check file against global deny patterns.
|
|
207
|
+
def _get_root_from_metadata(self, context: BaseLintContext) -> Path | None:
|
|
208
|
+
"""Extract project root from context metadata.
|
|
346
209
|
|
|
347
210
|
Args:
|
|
348
|
-
|
|
349
|
-
rel_path: Relative path
|
|
350
|
-
global_deny: Global deny patterns
|
|
211
|
+
context: Lint context
|
|
351
212
|
|
|
352
213
|
Returns:
|
|
353
|
-
|
|
214
|
+
Project root from metadata, or None if not available
|
|
354
215
|
"""
|
|
355
|
-
|
|
356
|
-
|
|
357
|
-
if
|
|
358
|
-
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
line=1,
|
|
363
|
-
column=0,
|
|
364
|
-
message=reason or f"File '{rel_path}' matches denied pattern",
|
|
365
|
-
severity=Severity.ERROR,
|
|
366
|
-
suggestion=self._get_suggestion(rel_path.name, None),
|
|
367
|
-
)
|
|
368
|
-
)
|
|
369
|
-
return violations
|
|
216
|
+
if not hasattr(context, "metadata"):
|
|
217
|
+
return None
|
|
218
|
+
if not context.metadata:
|
|
219
|
+
return None
|
|
220
|
+
if "_project_root" not in context.metadata:
|
|
221
|
+
return None
|
|
222
|
+
return context.metadata["_project_root"]
|
|
370
223
|
|
|
371
|
-
def
|
|
372
|
-
|
|
373
|
-
) -> list[Violation]:
|
|
374
|
-
"""Check global deny patterns."""
|
|
375
|
-
if "deny" not in global_patterns:
|
|
376
|
-
return []
|
|
377
|
-
|
|
378
|
-
is_denied, reason = self.pattern_matcher.match_deny_patterns(
|
|
379
|
-
path_str, global_patterns["deny"]
|
|
380
|
-
)
|
|
381
|
-
if is_denied:
|
|
382
|
-
return [
|
|
383
|
-
Violation(
|
|
384
|
-
rule_id="file-placement",
|
|
385
|
-
file_path=str(rel_path),
|
|
386
|
-
line=1,
|
|
387
|
-
column=0,
|
|
388
|
-
message=reason or f"File '{rel_path}' matches denied pattern",
|
|
389
|
-
severity=Severity.ERROR,
|
|
390
|
-
suggestion=self._get_suggestion(rel_path.name, None),
|
|
391
|
-
)
|
|
392
|
-
]
|
|
393
|
-
return []
|
|
394
|
-
|
|
395
|
-
def _check_global_allow_patterns(
|
|
396
|
-
self, path_str: str, rel_path: Path, global_patterns: dict[str, Any]
|
|
397
|
-
) -> list[Violation]:
|
|
398
|
-
"""Check global allow patterns."""
|
|
399
|
-
if "allow" not in global_patterns:
|
|
400
|
-
return []
|
|
401
|
-
|
|
402
|
-
if not self.pattern_matcher.match_allow_patterns(path_str, global_patterns["allow"]):
|
|
403
|
-
return [
|
|
404
|
-
Violation(
|
|
405
|
-
rule_id="file-placement",
|
|
406
|
-
file_path=str(rel_path),
|
|
407
|
-
line=1,
|
|
408
|
-
column=0,
|
|
409
|
-
message=f"File '{rel_path}' does not match any allowed patterns",
|
|
410
|
-
severity=Severity.ERROR,
|
|
411
|
-
suggestion="Ensure file matches project structure patterns",
|
|
412
|
-
)
|
|
413
|
-
]
|
|
414
|
-
return []
|
|
415
|
-
|
|
416
|
-
def _check_global_patterns(
|
|
417
|
-
self, path_str: str, rel_path: Path, global_patterns: dict[str, Any]
|
|
418
|
-
) -> list[Violation]:
|
|
419
|
-
"""Check file against global patterns.
|
|
224
|
+
def _detect_project_root(self, context: BaseLintContext) -> Path:
|
|
225
|
+
"""Detect project root from file path.
|
|
420
226
|
|
|
421
227
|
Args:
|
|
422
|
-
|
|
423
|
-
rel_path: Relative path
|
|
424
|
-
global_patterns: Global patterns config
|
|
228
|
+
context: Lint context
|
|
425
229
|
|
|
426
230
|
Returns:
|
|
427
|
-
|
|
231
|
+
Detected project root directory path
|
|
428
232
|
"""
|
|
429
|
-
|
|
430
|
-
if deny_violations:
|
|
431
|
-
return deny_violations
|
|
233
|
+
from src.utils.project_root import get_project_root
|
|
432
234
|
|
|
433
|
-
|
|
235
|
+
if context.file_path is None:
|
|
236
|
+
return Path.cwd()
|
|
434
237
|
|
|
435
|
-
|
|
436
|
-
|
|
437
|
-
if "test" in filename.lower():
|
|
438
|
-
return "Move to tests/ directory"
|
|
439
|
-
return None
|
|
440
|
-
|
|
441
|
-
def _suggest_for_typescript_file(self, filename: str) -> str | None:
|
|
442
|
-
"""Get suggestion for TypeScript/JSX files."""
|
|
443
|
-
if filename.endswith((".ts", ".tsx", ".jsx")):
|
|
444
|
-
if "component" in filename.lower():
|
|
445
|
-
return "Move to src/components/"
|
|
446
|
-
return "Move to src/"
|
|
447
|
-
return None
|
|
238
|
+
start_path = context.file_path.parent if context.file_path.is_file() else context.file_path
|
|
239
|
+
return get_project_root(start_path)
|
|
448
240
|
|
|
449
|
-
def
|
|
450
|
-
"""
|
|
451
|
-
if filename.endswith(".py"):
|
|
452
|
-
return "Move to src/"
|
|
453
|
-
if filename.startswith(("debug", "temp")):
|
|
454
|
-
return "Move to debug/ or remove if not needed"
|
|
455
|
-
if filename.endswith(".log"):
|
|
456
|
-
return "Move to logs/ or add to .gitignore"
|
|
457
|
-
return "Review file organization and move to appropriate directory"
|
|
241
|
+
def _extract_inline_config(self, context: BaseLintContext | None) -> dict[str, Any] | None:
|
|
242
|
+
"""Extract file-placement config from context metadata.
|
|
458
243
|
|
|
459
|
-
|
|
460
|
-
""
|
|
244
|
+
Handles both wrapped format: {"file-placement": {...}}
|
|
245
|
+
and unwrapped format: {"global_deny": [...], "directories": {...}, ...}
|
|
461
246
|
|
|
462
247
|
Args:
|
|
463
|
-
|
|
464
|
-
current_location: Current directory location
|
|
248
|
+
context: Lint context
|
|
465
249
|
|
|
466
250
|
Returns:
|
|
467
|
-
|
|
251
|
+
File placement config dict, or None if no config in metadata
|
|
468
252
|
"""
|
|
469
|
-
|
|
470
|
-
|
|
471
|
-
return suggestion
|
|
253
|
+
if not self._has_valid_metadata(context):
|
|
254
|
+
return None
|
|
472
255
|
|
|
473
|
-
|
|
474
|
-
|
|
475
|
-
|
|
256
|
+
# Type narrowing: _has_valid_metadata ensures context is not None
|
|
257
|
+
# by checking: context and hasattr(context, "metadata") and context.metadata
|
|
258
|
+
if context is None:
|
|
259
|
+
return None # Should never happen after _has_valid_metadata check
|
|
476
260
|
|
|
477
|
-
|
|
261
|
+
# Check for wrapped format first
|
|
262
|
+
wrapped_config = self._get_wrapped_config(context)
|
|
263
|
+
if wrapped_config is not None:
|
|
264
|
+
return wrapped_config
|
|
478
265
|
|
|
479
|
-
|
|
480
|
-
|
|
266
|
+
# Check for unwrapped format
|
|
267
|
+
return self._get_unwrapped_config(context)
|
|
268
|
+
|
|
269
|
+
def _has_valid_metadata(self, context: BaseLintContext | None) -> bool:
|
|
270
|
+
"""Check if context has valid metadata.
|
|
481
271
|
|
|
482
272
|
Args:
|
|
483
|
-
|
|
273
|
+
context: Lint context
|
|
484
274
|
|
|
485
275
|
Returns:
|
|
486
|
-
True if
|
|
276
|
+
True if context has metadata dict
|
|
487
277
|
"""
|
|
488
|
-
|
|
489
|
-
return len(violations) == 0
|
|
278
|
+
return bool(context and hasattr(context, "metadata") and context.metadata)
|
|
490
279
|
|
|
491
|
-
|
|
492
|
-
|
|
280
|
+
@staticmethod
|
|
281
|
+
def _get_wrapped_config(context: BaseLintContext) -> dict[str, Any] | None:
|
|
282
|
+
"""Get config from wrapped format: {"file-placement": {...}}.
|
|
493
283
|
|
|
494
284
|
Args:
|
|
495
|
-
|
|
496
|
-
recursive: Scan recursively
|
|
285
|
+
context: Lint context with metadata
|
|
497
286
|
|
|
498
287
|
Returns:
|
|
499
|
-
|
|
288
|
+
Config dict or None if not in wrapped format
|
|
500
289
|
"""
|
|
501
|
-
|
|
502
|
-
|
|
503
|
-
|
|
504
|
-
|
|
505
|
-
|
|
506
|
-
violations = []
|
|
507
|
-
for file_path in dir_path.glob(pattern):
|
|
508
|
-
if not file_path.is_file():
|
|
509
|
-
continue
|
|
510
|
-
file_violations = self._lint_file_if_not_ignored(file_path, ignore_parser)
|
|
511
|
-
violations.extend(file_violations)
|
|
290
|
+
if not hasattr(context, "metadata"):
|
|
291
|
+
return None
|
|
292
|
+
if "file-placement" in context.metadata:
|
|
293
|
+
return context.metadata["file-placement"]
|
|
294
|
+
return None
|
|
512
295
|
|
|
513
|
-
|
|
296
|
+
@staticmethod
|
|
297
|
+
def _get_unwrapped_config(context: BaseLintContext) -> dict[str, Any] | None:
|
|
298
|
+
"""Get config from unwrapped format: {"directories": {...}, ...}.
|
|
514
299
|
|
|
515
|
-
|
|
516
|
-
|
|
517
|
-
if ignore_parser.is_ignored(file_path):
|
|
518
|
-
return []
|
|
519
|
-
return self.lint_path(file_path)
|
|
300
|
+
Args:
|
|
301
|
+
context: Lint context with metadata
|
|
520
302
|
|
|
303
|
+
Returns:
|
|
304
|
+
Config dict or None if not in unwrapped format
|
|
305
|
+
"""
|
|
306
|
+
if not hasattr(context, "metadata"):
|
|
307
|
+
return None
|
|
521
308
|
|
|
522
|
-
|
|
523
|
-
|
|
309
|
+
config_keys = {"directories", "global_deny", "global_allow", "global_patterns"}
|
|
310
|
+
matching_keys = {k: v for k, v in context.metadata.items() if k in config_keys}
|
|
311
|
+
return matching_keys if matching_keys else None
|
|
524
312
|
|
|
525
|
-
def
|
|
526
|
-
|
|
313
|
+
def _get_or_create_linter(
|
|
314
|
+
self, project_root: Path, context: BaseLintContext | None = None
|
|
315
|
+
) -> FilePlacementLinter:
|
|
316
|
+
"""Get cached linter or create new one.
|
|
527
317
|
|
|
528
318
|
Args:
|
|
529
|
-
|
|
319
|
+
project_root: Project root directory
|
|
320
|
+
context: Lint context (to extract inline config if present)
|
|
321
|
+
|
|
322
|
+
Returns:
|
|
323
|
+
FilePlacementLinter instance
|
|
530
324
|
"""
|
|
531
|
-
|
|
532
|
-
self._linter_cache:
|
|
325
|
+
# Check if cached linter exists for this project root
|
|
326
|
+
if project_root in self._linter_cache:
|
|
327
|
+
return self._linter_cache[project_root]
|
|
533
328
|
|
|
534
|
-
|
|
535
|
-
|
|
536
|
-
"""Return rule ID."""
|
|
537
|
-
return "file-placement"
|
|
329
|
+
# Try to get config from context metadata (orchestrator passes config here)
|
|
330
|
+
config_from_metadata = self._extract_inline_config(context) if context else None
|
|
538
331
|
|
|
539
|
-
|
|
540
|
-
|
|
541
|
-
|
|
542
|
-
|
|
332
|
+
if config_from_metadata:
|
|
333
|
+
# Use config from orchestrator's metadata
|
|
334
|
+
linter = FilePlacementLinter(config_obj=config_from_metadata, project_root=project_root)
|
|
335
|
+
else:
|
|
336
|
+
# Fall back to loading from file
|
|
337
|
+
layout_path = self._get_layout_path(project_root)
|
|
338
|
+
layout_config = self._load_layout_config(layout_path)
|
|
339
|
+
linter = FilePlacementLinter(config_obj=layout_config, project_root=project_root)
|
|
543
340
|
|
|
544
|
-
|
|
545
|
-
|
|
546
|
-
|
|
547
|
-
return "Validate file organization against project structure rules"
|
|
341
|
+
# Cache the linter
|
|
342
|
+
self._linter_cache[project_root] = linter
|
|
343
|
+
return linter
|
|
548
344
|
|
|
549
345
|
def _get_layout_path(self, project_root: Path) -> Path:
|
|
550
|
-
"""Get layout config file path.
|
|
346
|
+
"""Get layout config file path.
|
|
347
|
+
|
|
348
|
+
Args:
|
|
349
|
+
project_root: Project root directory
|
|
350
|
+
|
|
351
|
+
Returns:
|
|
352
|
+
Path to layout config file
|
|
353
|
+
"""
|
|
551
354
|
layout_file = self.config.get("layout_file")
|
|
552
355
|
if layout_file:
|
|
553
356
|
return project_root / layout_file
|
|
554
357
|
|
|
555
|
-
|
|
556
|
-
|
|
557
|
-
|
|
558
|
-
return yaml_path
|
|
559
|
-
if json_path.exists():
|
|
560
|
-
return json_path
|
|
561
|
-
return yaml_path
|
|
562
|
-
|
|
563
|
-
def _load_layout_config(self, layout_path: Path) -> dict[str, Any]:
|
|
564
|
-
"""Load layout configuration from file."""
|
|
565
|
-
try:
|
|
566
|
-
return self._parse_layout_file(layout_path)
|
|
567
|
-
except Exception:
|
|
568
|
-
return {}
|
|
358
|
+
# Check for standard config files at project root
|
|
359
|
+
thailint_yaml = project_root / ".thailint.yaml"
|
|
360
|
+
thailint_json = project_root / ".thailint.json"
|
|
569
361
|
|
|
570
|
-
|
|
571
|
-
|
|
572
|
-
|
|
573
|
-
if str(layout_path).endswith((".yaml", ".yml")):
|
|
574
|
-
return yaml.safe_load(f) or {}
|
|
575
|
-
return json.load(f)
|
|
362
|
+
for path in [thailint_yaml, thailint_json]:
|
|
363
|
+
if path.exists():
|
|
364
|
+
return path
|
|
576
365
|
|
|
577
|
-
|
|
578
|
-
|
|
579
|
-
if project_root not in self._linter_cache:
|
|
580
|
-
layout_path = self._get_layout_path(project_root)
|
|
581
|
-
layout_config = self._load_layout_config(layout_path)
|
|
582
|
-
self._linter_cache[project_root] = FilePlacementLinter(
|
|
583
|
-
config_obj=layout_config, project_root=project_root
|
|
584
|
-
)
|
|
585
|
-
return self._linter_cache[project_root]
|
|
366
|
+
# Return default path if no config exists
|
|
367
|
+
return thailint_yaml
|
|
586
368
|
|
|
587
|
-
def
|
|
588
|
-
"""
|
|
369
|
+
def _load_layout_config(self, layout_path: Path) -> dict[str, Any]:
|
|
370
|
+
"""Load layout configuration from file.
|
|
589
371
|
|
|
590
372
|
Args:
|
|
591
|
-
|
|
373
|
+
layout_path: Path to layout file
|
|
592
374
|
|
|
593
375
|
Returns:
|
|
594
|
-
|
|
376
|
+
Layout configuration dict (unwrapped from file-placement key), or empty dict on error
|
|
595
377
|
"""
|
|
596
|
-
|
|
597
|
-
|
|
378
|
+
try:
|
|
379
|
+
config = self._parse_layout_file(layout_path)
|
|
598
380
|
|
|
599
|
-
|
|
600
|
-
|
|
601
|
-
|
|
381
|
+
# Unwrap file-placement key if present
|
|
382
|
+
if "file-placement" in config:
|
|
383
|
+
return config["file-placement"]
|
|
384
|
+
|
|
385
|
+
return config
|
|
386
|
+
except Exception:
|
|
387
|
+
return {}
|
|
602
388
|
|
|
603
|
-
def
|
|
604
|
-
"""
|
|
389
|
+
def _parse_layout_file(self, layout_path: Path) -> dict[str, Any]:
|
|
390
|
+
"""Parse layout file based on extension.
|
|
605
391
|
|
|
606
392
|
Args:
|
|
607
|
-
|
|
393
|
+
layout_path: Path to layout file
|
|
608
394
|
|
|
609
395
|
Returns:
|
|
610
|
-
|
|
396
|
+
Parsed configuration dict
|
|
611
397
|
"""
|
|
612
|
-
|
|
613
|
-
|
|
614
|
-
|
|
615
|
-
|
|
616
|
-
if (current / ".ai").exists():
|
|
617
|
-
return current
|
|
618
|
-
current = current.parent
|
|
619
|
-
|
|
620
|
-
# Fallback to current directory if no .ai found
|
|
621
|
-
return Path.cwd()
|
|
398
|
+
with layout_path.open(encoding="utf-8") as f:
|
|
399
|
+
if str(layout_path).endswith((".yaml", ".yml")):
|
|
400
|
+
return yaml.safe_load(f) or {}
|
|
401
|
+
return json.load(f)
|