taxcalc 4.4.0__py3-none-any.whl → 4.4.1__py3-none-any.whl

taxcalc/tests/test_calculator.py

@@ -38,7 +38,7 @@ def test_make_calculator(cps_subsample):
     with pytest.raises(ValueError):
         Calculator(policy=pol, records=None)
     with pytest.raises(ValueError):
-        Calculator(policy=pol, records=rec, consumption=list())
+        Calculator(policy=pol, records=rec, consumption=[])
 
 
 def test_make_calculator_deepcopy(cps_subsample):
@@ -522,7 +522,7 @@ def test_read_bad_json_assump_file():
     with pytest.raises(ValueError):
         Calculator.read_json_param_objects(None, 'unknown_file_name')
     with pytest.raises(TypeError):
-        Calculator.read_json_param_objects(None, list())
+        Calculator.read_json_param_objects(None, [])
 
 
 def test_json_doesnt_exist():
@@ -629,7 +629,7 @@ def test_reform_documentation():
     dump = False  # set to True to print documentation and force test failure
     if dump:
         print(doc)
-        assert 1 == 2
+        assert False, 'ERROR: reform_documentation above'
 
 
 def test_distribution_tables(cps_subsample):
@@ -827,7 +827,7 @@ def test_itemded_component_amounts(year, cvname, hcname, puf_fullsample):
         itmded1 = calc1.weighted_total('c04470') * 1e-9
         itmded2 = calc2.weighted_total('c04470') * 1e-9
     else:
-        raise ValueError('illegal year value = {}'.format(year))
+        raise ValueError(f'illegal year value = {year}')
     difference_in_total_itmded = itmded1 - itmded2
     # calculate itemized component amount
     component_amt = calc1.weighted_total(cvname) * 1e-9
@@ -841,8 +841,11 @@ def test_itemded_component_amounts(year, cvname, hcname, puf_fullsample):
     else:
         atol = 0.00001
     if not np.allclose(component_amt, difference_in_total_itmded, atol=atol):
-        txt = '\n{}={:.3f}  !=  {:.3f}=difference_in_total_itemized_deductions'
-        msg = txt.format(cvname, component_amt, difference_in_total_itmded)
+        msg = (
+            f'\n{cvname}={component_amt:.3f}  !=  '
+            f'{difference_in_total_itmded:.3f}='
+            'difference_in_total_itemized_deductions'
+        )
         raise ValueError(msg)
 
 
@@ -928,6 +931,8 @@ def test_cg_top_rate():
     """
     Test top CG bracket and rate.
     """
+    # pylint: disable=too-many-locals
+
     cy = 2019
 
     # set NIIT and STD to zero to isolate CG tax rates

taxcalc/tests/test_compare.py

@@ -8,22 +8,21 @@ Compares Tax-Calculator PUF and CPS results with historical information.
 import os
 import pytest
 import numpy as np
-# pylint: disable=import-error,pointless-string-statement
-from taxcalc import Policy, Records, Calculator
-from taxcalc import add_income_table_row_variable, SOI_AGI_BINS
+from taxcalc.policy import Policy
+from taxcalc.records import Records
+from taxcalc.calculator import Calculator
+from taxcalc.utils import add_income_table_row_variable, SOI_AGI_BINS
 
 
-"""
-2015 IRS-SOI amounts by AGI category are from "Table 3.3 All Returns: Tax
-Liability, Tax Credits, and Tax Payments by Size of Adjusted Gross Income,
-Tax Year 2015" which is available as a spreadsheet at this URL:
-<https://www.irs.gov/statistics/soi-tax-stats-individual-
-statistical-tables-by-size-of-adjusted-gross-income>
-The IRS-SOI amounts are from 19 rows in the spreadsheet numbered from
-11 (AGI under one dollar) through 29 (AGI $10M or more).
-Dollar IRS-SOI amounts are expressed in billions of dollars and rounded
-to the nearest one-tenth of a million dollars.
-"""
+# 2015 IRS-SOI amounts by AGI category are from "Table 3.3 All Returns: Tax
+# Liability, Tax Credits, and Tax Payments by Size of Adjusted Gross Income,
+# Tax Year 2015" which is available as a spreadsheet at this URL:
+# <https://www.irs.gov/statistics/soi-tax-stats-individual-
+#  statistical-tables-by-size-of-adjusted-gross-income>
+# The IRS-SOI amounts are from 19 rows in the spreadsheet numbered from
+# 11 (AGI under one dollar) through 29 (AGI $10M or more).
+# Dollar IRS-SOI amounts are expressed in billions of dollars and rounded
+# to the nearest one-tenth of a million dollars.
 ITAX = {
     '0:EITC': {
         # Full earned income credit
@@ -204,11 +203,12 @@ def comparison(cname, calc, cmpdata, ofile):
     # construct AGI table
     vardf = add_income_table_row_variable(vardf, 'c00100', SOI_AGI_BINS)
     gbydf = vardf.groupby('table_row', as_index=False)
-    # write AGI table with ALL row at bottom to ofile
-    ofile.write('TABLE for {}\n'.format(cname.split(':')[1]))
+    # write AGI table with ALL row at bottom of ofile
+    ofile.write(f'TABLE for {cname.split(":")[1]}\n')
     results = '{:23s}\t{:8.3f}\t{:8.3f}\t{:+6.1f}\n'
-    colhead = '{:23s}\t{:>8s}\t{:>8s}\t{:>6s}\n'
-    ofile.write(colhead.format('AGI category', 'T-C', 'SOI', '%diff'))
+    colhead = f'{"AGIcategory":23s}\t{"T-C":>8s}\t{"SOI":>8s}\t{"%diff":>6s}\n'
+    ofile.write(colhead)
+    # pylint: disable=consider-using-f-string
     txc_tot = 0.
     soi_tot = 0.
     idx = 0
@@ -221,12 +221,12 @@ def comparison(cname, calc, cmpdata, ofile):
             pct_diff = 100. * ((txc / soi) - 1.)
         else:
             pct_diff = np.nan
-        glabel = '[{:.8g}, {:.8g})'.format(grp_interval.left,
-                                           grp_interval.right)
+        glabel = f'[{grp_interval.left:.8g}, {grp_interval.right:.8g})'
         ofile.write(results.format(glabel, txc, soi, pct_diff))
         idx += 1
     pct_diff = 100. * ((txc_tot / soi_tot) - 1.)
     ofile.write(results.format('ALL', txc_tot, soi_tot, pct_diff))
+    # pylint: enable=consider-using-f-string
 
 
 def nonsmall_diffs(linelist1, linelist2, small=0.0):
@@ -256,24 +256,20 @@ def nonsmall_diffs(linelist1, linelist2, small=0.0):
     for line1, line2 in zip(linelist1, linelist2):
         if line1 == line2:
             continue
-        else:
-            tokens1 = line1.replace(',', '').split()
-            tokens2 = line2.replace(',', '').split()
-            for tok1, tok2 in zip(tokens1, tokens2):
-                tok1_isfloat = isfloat(tok1)
-                tok2_isfloat = isfloat(tok2)
-                if tok1_isfloat and tok2_isfloat:
-                    if abs(float(tok1) - float(tok2)) <= smallamt:
-                        continue
-                    else:
-                        return True
-                elif not tok1_isfloat and not tok2_isfloat:
-                    if tok1 == tok2:
-                        continue
-                    else:
-                        return True
-                else:
-                    return True
+        tokens1 = line1.replace(',', '').split()
+        tokens2 = line2.replace(',', '').split()
+        for tok1, tok2 in zip(tokens1, tokens2):
+            tok1_isfloat = isfloat(tok1)
+            tok2_isfloat = isfloat(tok2)
+            if tok1_isfloat and tok2_isfloat:
+                if abs(float(tok1) - float(tok2)) <= smallamt:
+                    continue
+                return True
+            if not tok1_isfloat and not tok2_isfloat:
+                if tok1 == tok2:
+                    continue
+                return True
+            return True
         return False
 
 
@@ -281,9 +277,9 @@ def differences(afilename, efilename):
     """
     Check for differences between results in afilename and efilename files.
     """
-    with open(afilename, 'r') as afile:
+    with open(afilename, 'r', encoding='utf-8') as afile:
         actres = afile.read()
-    with open(efilename, 'r') as efile:
+    with open(efilename, 'r', encoding='utf-8') as efile:
         expres = efile.read()
     diffs = nonsmall_diffs(actres.splitlines(True),
                            expres.splitlines(True), 0.0)
@@ -292,12 +288,12 @@ def differences(afilename, efilename):
         efname = os.path.basename(efilename)
         msg = 'COMPARE RESULTS DIFFER\n'
         msg += '-------------------------------------------------\n'
-        msg += '--- NEW RESULTS IN {} FILE ---\n'
-        msg += '--- if new OK, copy {} to  ---\n'
-        msg += '---                 {}     ---\n'
+        msg += f'--- NEW RESULTS IN {afname} FILE   ---\n'
+        msg += f'--- if new OK, copy {afname} to    ---\n'
+        msg += f'---                 {efname}       ---\n'
         msg += '---            and rerun test.                ---\n'
         msg += '-------------------------------------------------\n'
-        raise ValueError(msg.format(afname, afname, efname))
+        raise ValueError(msg)
     os.remove(afilename)
 
 
@@ -325,12 +321,10 @@ def test_itax_compare(tests_path, using_puf, puf_fullsample, cps_fullsample):
         afilename = os.path.join(tests_path, 'cmpi_puf_actual.txt')
     else:
         afilename = os.path.join(tests_path, 'cmpi_cps_actual.txt')
-    afile = open(afilename, 'w')
-    # write compare results to afile
-    for cname in sorted(ITAX.keys()):
-        comparison(cname, calc, ITAX, afile)
-    # close actual output file
-    afile.close()
+    with open(afilename, 'w', encoding='utf-8') as afile:
+        # write compare results to afile
+        for cname in sorted(ITAX.keys()):
+            comparison(cname, calc, ITAX, afile)
     # check for differences between actual and expect output files
     efilename = afilename.replace('actual', 'expect')
     differences(afilename, efilename)

taxcalc/tests/test_compatible_data.py

@@ -12,7 +12,9 @@ plug-in pytest-xdist is able to run all parametrized functions in parallel
 import copy
 import pytest
 import numpy as np
-from taxcalc import Policy, Records, Calculator  # pylint: disable=import-error
+from taxcalc.policy import Policy
+from taxcalc.records import Records
+from taxcalc.calculator import Calculator
 
 
 @pytest.fixture(scope='module', name='allparams')
@@ -49,7 +51,7 @@ def test_compatible_data_presence(allparams):
         return True
 
     # Main logic of test_compatible_data_presence function
-    problem_pnames = list()
+    problem_pnames = []
     for pname in allparams:
         if 'compatible_data' in allparams[pname]:
             compatible_data = allparams[pname]['compatible_data']
@@ -61,7 +63,7 @@ def test_compatible_data_presence(allparams):
         msg = '{} has no or invalid compatible_data field'
         for pname in problem_pnames:
             print(msg.format(pname))
-        assert 'list of problem_pnames' == 'empty list'
+        assert False, 'ERROR: list of problem_pnames is above'
 
 
 XX_YEAR = 2019
@@ -142,7 +144,7 @@ BATCHES = int(np.floor(NPARAMS / BATCHSIZE)) + 1
 
 
 @pytest.fixture(scope='module', name='allparams_batch',
-                params=[i for i in range(0, BATCHES)])
+                params=list(range(0, BATCHES)))
 def fixture_allparams_batch(request, allparams, sorted_param_names):
     """
     Fixture for grouping Tax-Calculator parameters
@@ -229,8 +231,8 @@ def test_compatible_data(cps_subsample, puf_subsample,
     at least one of these reforms when using datasets marked compatible
     and does not differ when using datasets marked as incompatible.
     """
-    # pylint: disable=too-many-arguments,too-many-locals
-    # pylint: disable=too-many-statements,too-many-branches
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
+    # pylint: disable=too-many-statements,too-many-branches,too-many-locals
 
     # Check NPARAMS value
     assert NPARAMS == len(allparams)
@@ -335,4 +337,4 @@ def test_compatible_data(cps_subsample, puf_subsample,
     # test failure if any errors
     if errors:
         print(errors)
-        assert 'compatible_data' == 'invalid'
+        assert False, 'ERROR: compatible_data is invalid; see errors above'

taxcalc/tests/test_consumption.py

@@ -1,18 +1,24 @@
+"""
+Test Consumption class and its methods.
+"""
 # CODING-STYLE CHECKS:
 # pycodestyle test_consumption.py
+# pylint --disable=locally-disabled test_consumption.py
 
+import copy
 import numpy as np
-import paramtools
 import pytest
-import copy
+import paramtools
 from taxcalc import Policy, Records, Calculator, Consumption
 
 
 def test_start_year_consistency():
+    """Test docstring"""
     assert Consumption.JSON_START_YEAR == Policy.JSON_START_YEAR
 
 
 def test_validity_of_consumption_vars_set():
+    """Test docstring"""
     records_varinfo = Records(data=None)
     assert Consumption.RESPONSE_VARS.issubset(records_varinfo.USABLE_READ_VARS)
     useable_vars = set(['housing', 'snap', 'tanf', 'vet', 'wic',
@@ -21,6 +27,7 @@ def test_validity_of_consumption_vars_set():
 
 
 def test_update_consumption():
+    """Test docstring"""
     consump = Consumption()
     consump.update_consumption({})
     revision = {
@@ -33,21 +40,29 @@ def test_update_consumption():
     expected_mpc_e20400 = np.full((consump.num_years,), 0.06)
     expected_mpc_e20400[0] = 0.0
     expected_mpc_e20400[1] = 0.05
-    assert np.allclose(consump._MPC_e20400,
-                       expected_mpc_e20400,
-                       rtol=0.0)
-    assert np.allclose(consump._MPC_e17500,
-                       np.zeros((consump.num_years,)),
-                       rtol=0.0)
+    assert np.allclose(
+        consump._MPC_e20400,  # pylint: disable=protected-access
+        expected_mpc_e20400,
+        rtol=0.0
+    )
+    assert np.allclose(
+        consump._MPC_e17500,  # pylint: disable=protected-access
+        np.zeros((consump.num_years,)),
+        rtol=0.0
+    )
     expected_ben_mcare_value = np.full((consump.num_years,), 0.80)
     expected_ben_mcare_value[0] = 1.0
     expected_ben_mcare_value[1] = 0.75
-    assert np.allclose(consump._BEN_mcare_value,
-                       expected_ben_mcare_value,
-                       rtol=0.0)
-    assert np.allclose(consump._BEN_snap_value,
-                       np.ones((consump.num_years,)),
-                       rtol=0.0)
+    assert np.allclose(
+        consump._BEN_mcare_value,  # pylint: disable=protected-access
+        expected_ben_mcare_value,
+        rtol=0.0
+    )
+    assert np.allclose(
+        consump._BEN_snap_value,  # pylint: disable=protected-access
+        np.ones((consump.num_years,)),
+        rtol=0.0
+    )
     consump.set_year(2015)
     assert consump.current_year == 2015
     assert consump.MPC_e20400 == 0.06
@@ -57,6 +72,7 @@ def test_update_consumption():
 
 
 def test_incorrect_update_consumption():
+    """Test docstring"""
     with pytest.raises(paramtools.ValidationError):
         Consumption().update_consumption([])
     with pytest.raises(paramtools.ValidationError):
@@ -74,6 +90,7 @@ def test_incorrect_update_consumption():
 
 
 def test_future_update_consumption():
+    """Test docstring"""
     consump = Consumption()
     assert consump.current_year == consump.start_year
     assert consump.has_response() is False
@@ -97,6 +114,7 @@ def test_future_update_consumption():
 
 
 def test_consumption_default_data():
+    """Test docstring"""
     consump = Consumption()
     pdata = consump.specification(meta_data=True, ignore_state=True)
     for pname in pdata.keys():
@@ -107,24 +125,26 @@ def test_consumption_default_data():
 
 
 def test_consumption_response(cps_subsample):
+    """Test docstring"""
+    # pylint: disable=too-many-locals
     consump = Consumption()
     mpc = 0.5
     consumption_response = {'MPC_e20400': {2013: mpc}}
     consump.update_consumption(consumption_response)
     # test incorrect call to response method
     with pytest.raises(ValueError):
-        consump.response(list(), 1)
+        consump.response([], 1)
     # test correct call to response method
     rec = Records.cps_constructor(data=cps_subsample)
-    pre = copy.deepcopy(rec.e20400)
+    pre = copy.deepcopy(getattr(rec, 'e20400'))
     consump.response(rec, 1.0)
-    post = rec.e20400
+    post = getattr(rec, 'e20400')
     actual_diff = post - pre
     expected_diff = np.ones(rec.array_length) * mpc
     assert np.allclose(actual_diff, expected_diff)
     # compute earnings mtr with no consumption response
     rec = Records.cps_constructor(data=cps_subsample)
-    ided0 = copy.deepcopy(rec.e20400)
+    ided0 = copy.deepcopy(getattr(rec, 'e20400'))
     calc0 = Calculator(policy=Policy(), records=rec, consumption=None)
     (mtr0_ptax, mtr0_itax, _) = calc0.mtr(variable_str='e00200p',
                                           wrt_full_compensation=False)

taxcalc/tests/test_cpscsv.py

@@ -17,8 +17,11 @@ import json
 import pytest
 import numpy as np
 import pandas as pd
-# pylint: disable=import-error
-from taxcalc import GrowFactors, GrowDiff, Policy, Records, Calculator
+from taxcalc.growfactors import GrowFactors
+from taxcalc.growdiff import GrowDiff
+from taxcalc.policy import Policy
+from taxcalc.records import Records
+from taxcalc.calculator import Calculator
 
 
 START_YEAR = 2017
@@ -52,7 +55,7 @@ def test_agg(tests_path, cps_fullsample):
         if not np.allclose(adt[icol], edt[str(icol)]):
             diffs = True
     if diffs:
-        new_filename = '{}{}'.format(aggres_path[:-10], 'actual.csv')
+        new_filename = f'{aggres_path[:-10]}actual.csv'
         adt.to_csv(new_filename, float_format='%.1f')
         msg = 'CPSCSV AGG RESULTS DIFFER\n'
         msg += '-------------------------------------------------\n'
@@ -65,7 +68,7 @@ def test_agg(tests_path, cps_fullsample):
         raise ValueError(msg)
     # create aggregate diagnostic table using unweighted sub-sample of records
     rn_seed = 180  # to ensure sub-sample is always the same
-    subfrac = 0.07# 0.03  # sub-sample fraction
+    subfrac = 0.07  # sub-sample fraction
     subsample = cps_fullsample.sample(frac=subfrac, random_state=rn_seed)
     recs_subsample = Records.cps_constructor(data=subsample)
     calc_subsample = Calculator(policy=baseline_policy, records=recs_subsample)
@@ -84,14 +87,17 @@ def test_agg(tests_path, cps_fullsample):
         if not np.allclose(taxes_subsample[cyr], taxes_fullsample[cyr],
                            atol=0.0, rtol=reltol):
             reldiff = (taxes_subsample[cyr] / taxes_fullsample[cyr]) - 1.
-            line1 = '\nCPSCSV AGG SUB-vs-FULL RESULTS DIFFER IN {}'
-            line2 = '\n  when subfrac={:.3f}, rtol={:.4f}, seed={}'
-            line3 = '\n  with sub={:.3f}, full={:.3f}, rdiff={:.4f}'
-            msg += line1.format(cyr)
-            msg += line2.format(subfrac, reltol, rn_seed)
-            msg += line3.format(taxes_subsample[cyr],
-                                taxes_fullsample[cyr],
-                                reldiff)
+            line1 = f'\nCPSCSV AGG SUB-vs-FULL RESULTS DIFFER IN {cyr}'
+            line2 = (
+                f'\n  when subfrac={subfrac:.3f}, rtol={reltol:.4f}, '
+                f'seed={rn_seed}'
+            )
+            line3 = (
+                f'\n  with sub={taxes_subsample[cyr]:.3f}, '
+                f'full={taxes_fullsample[cyr]:.3f}, '
+                f'rdiff={reldiff:.4f}'
+            )
+            msg += line1 + line2 + line3
     if msg:
         raise ValueError(msg)
 
@@ -104,7 +110,7 @@ def test_cps_availability(tests_path, cps_path):
     cpsvars = set(list(cpsdf))
     # make set of variable names that are marked as cps.csv available
     rvpath = os.path.join(tests_path, '..', 'records_variables.json')
-    with open(rvpath, 'r') as rvfile:
+    with open(rvpath, 'r', encoding='utf-8') as rvfile:
         rvdict = json.load(rvfile)
     recvars = set()
     for vname, vdict in rvdict['read'].items():
@@ -142,24 +148,20 @@ def nonsmall_diffs(linelist1, linelist2, small=0.0):
     for line1, line2 in zip(linelist1, linelist2):
         if line1 == line2:
             continue
-        else:
-            tokens1 = line1.replace(',', '').split()
-            tokens2 = line2.replace(',', '').split()
-            for tok1, tok2 in zip(tokens1, tokens2):
-                tok1_isfloat = isfloat(tok1)
-                tok2_isfloat = isfloat(tok2)
-                if tok1_isfloat and tok2_isfloat:
-                    if abs(float(tok1) - float(tok2)) <= smallamt:
-                        continue
-                    else:
-                        return True
-                elif not tok1_isfloat and not tok2_isfloat:
-                    if tok1 == tok2:
-                        continue
-                    else:
-                        return True
-                else:
-                    return True
+        tokens1 = line1.replace(',', '').split()
+        tokens2 = line2.replace(',', '').split()
+        for tok1, tok2 in zip(tokens1, tokens2):
+            tok1_isfloat = isfloat(tok1)
+            tok2_isfloat = isfloat(tok2)
+            if tok1_isfloat and tok2_isfloat:
+                if abs(float(tok1) - float(tok2)) <= smallamt:
+                    continue
+                return True
+            if not tok1_isfloat and not tok2_isfloat:
+                if tok1 == tok2:
+                    continue
+                return True
+            return True
         return False
 
 

taxcalc/tests/test_data.py

@@ -1,5 +1,9 @@
+"""
+Test Data class and its methods.
+"""
 # CODING-STYLE CHECKS:
 # pycodestyle test_data.py
+# pylint --disable=locally-disabled test_data.py
 
 import os
 import tempfile
@@ -75,14 +79,17 @@ def test_recs_class(recs_varinfo_file, cps_subsample):
             super().__init__(data, start_year, gfactors, weights)
 
         def _extrapolate(self, year):
-            self.e00300 *= self.gfactors.factor_value('AINTS', year)
+            val = getattr(self, 'e00300')
+            setattr(
+                self, 'e00300', val * self.gfactors.factor_value('AINTS', year)
+            )
 
-    # test Recs class for incorrect instantiation
+    # test Recs class for incorrect instantiation:
     with pytest.raises(ValueError):
-        Recs(data=list(), start_year=2000,
+        Recs(data=[], start_year=2000,
              gfactors=None, weights=None)
     with pytest.raises(ValueError):
-        Recs(data=cps_subsample, start_year=list(),
+        Recs(data=cps_subsample, start_year=[],
              gfactors=None, weights=None)
     with pytest.raises(ValueError):
         Recs(data=cps_subsample, start_year=2000,
@@ -93,19 +100,18 @@ def test_recs_class(recs_varinfo_file, cps_subsample):
     with pytest.raises(ValueError):
         Recs(data=cps_subsample, start_year=2000,
              gfactors='', weights='')
-    # test Recs class for correct instantiation with no aging of data
+    # test Recs class for correct instantiation with no aging of data:
     syr = 2014
     rec = Recs(data=cps_subsample, start_year=syr,
                gfactors=None, weights=None)
-    assert isinstance(rec, Recs)
-    assert np.all(rec.MARS != 0)
-    assert rec.data_year == syr
-    assert rec.current_year == syr
-    sum_e00300_in_syr = rec.e00300.sum()
+    assert np.all(getattr(rec, 'MARS') != 0)
+    assert getattr(rec, 'data_year') == syr
+    assert getattr(rec, 'current_year') == syr
+    sum_e00300_in_syr = getattr(rec, 'e00300').sum()
     rec.increment_year()
-    assert rec.data_year == syr
-    assert rec.current_year == syr + 1
-    sum_e00300_in_syr_plus_one = rec.e00300.sum()
+    assert getattr(rec, 'data_year') == syr
+    assert getattr(rec, 'current_year') == syr + 1
+    sum_e00300_in_syr_plus_one = getattr(rec, 'e00300').sum()
     assert np.allclose([sum_e00300_in_syr], [sum_e00300_in_syr_plus_one])
     del rec
     # test Recs class for correct instantiation with aging of data
@@ -114,20 +120,21 @@ def test_recs_class(recs_varinfo_file, cps_subsample):
     rec = Recs(data=cps_subsample, start_year=syr,
                gfactors=GrowFactors(), weights=wghts_df)
     assert isinstance(rec, Recs)
-    assert np.all(rec.MARS != 0)
-    assert rec.data_year == syr
-    assert rec.current_year == syr
-    sum_s006_in_syr = rec.s006.sum()
-    sum_e00300_in_syr = rec.e00300.sum()
+    assert np.all(getattr(rec, 'MARS') != 0)
+    assert getattr(rec, 'data_year') == syr
+    assert getattr(rec, 'current_year') == syr
+    sum_s006_in_syr = getattr(rec, 's006').sum()
+    sum_e00300_in_syr = getattr(rec, 'e00300').sum()
     rec.increment_year()
-    assert rec.data_year == syr
-    assert rec.current_year == syr + 1
-    sum_s006_in_syr_plus_one = rec.s006.sum()
+    assert getattr(rec, 'data_year') == syr
+    assert getattr(rec, 'current_year') == syr + 1
+    sum_s006_in_syr_plus_one = getattr(rec, 's006').sum()
     assert sum_s006_in_syr_plus_one > sum_s006_in_syr
-    sum_e00300_in_syr_plus_one = rec.e00300.sum()
+    sum_e00300_in_syr_plus_one = getattr(rec, 'e00300').sum()
     assert sum_e00300_in_syr_plus_one > sum_e00300_in_syr
-    # test private methods
+    # test private methods:
+    # pylint: disable=protected-access
     rec._read_data(data=None)
     rec._read_weights(weights=None)
     with pytest.raises(ValueError):
-        rec._read_weights(weights=list())
+        rec._read_weights(weights=[])