superset-showtime 0.2.7__py3-none-any.whl → 0.2.8__py3-none-any.whl

showtime/__init__.py

@@ -4,7 +4,7 @@
 Circus tent emoji state tracking for Apache Superset ephemeral environments.
 """
 
-__version__ = "0.2.7"
+__version__ = "0.2.8"
 __author__ = "Maxime Beauchemin"
 __email__ = "maximebeauchemin@gmail.com"
 

showtime/core/github_messages.py

@@ -6,7 +6,9 @@ Centralized PR comment functions with type hints and clean formatting.
 
 import os
 import textwrap
-from typing import Dict, Optional
+from typing import Dict, List, Optional
+
+from .circus import Show
 
 # AWS Console URL constants
 BASE_AWS_URL = "https://us-west-2.console.aws.amazon.com/ecs/v2/clusters/superset-ci/services"
@@ -31,6 +33,57 @@ def get_showtime_footer() -> str:
     return "*Powered by [Superset Showtime](https://github.com/mistercrunch/superset-showtime)*"
 
 
+def _create_header_links(sha: str) -> Dict[str, str]:
+    """Create standard header links for comments
+
+    Args:
+        sha: Commit SHA for the environment
+
+    Returns:
+        Dict with showtime_link, gha_link, commit_link
+    """
+    from .circus import short_sha
+
+    repo_path = get_repo_path()
+    return {
+        "showtime_link": "[Showtime](https://github.com/mistercrunch/superset-showtime)",
+        "gha_link": f"[GHA]({get_github_workflow_url()})",
+        "commit_link": f"[{short_sha(sha)}]({get_commit_url(repo_path, sha)})",
+    }
+
+
+def _format_comment(header: str, bullets: List[str]) -> str:
+    """Format comment with header and bullet points
+
+    Args:
+        header: Comment header text
+        bullets: List of bullet point strings (without •)
+    """
+    bullet_text = "\n".join(f"• {bullet}" for bullet in bullets)
+    return textwrap.dedent(
+        f"""
+        {header}
+
+        {bullet_text}
+    """
+    ).strip()
+
+
+def get_commit_url(repo_path: str, sha: str) -> str:
+    """Get GitHub commit URL
+
+    Args:
+        repo_path: Repository path like 'apache/superset'
+        sha: Full or short commit SHA
+    """
+    return f"https://github.com/{repo_path}/commit/{sha}"
+
+
+def get_repo_path() -> str:
+    """Get current repository path from environment"""
+    return os.getenv("GITHUB_REPOSITORY", "apache/superset")
+
+
 def get_aws_console_urls(service_name: str) -> Dict[str, str]:
     """Get AWS Console URLs for a service"""
     return {
@@ -43,92 +96,76 @@ def get_aws_console_urls(service_name: str) -> Dict[str, str]:
 # Typed comment functions with clear parameter requirements
 
 
-def start_comment(show) -> str:
+def start_comment(show: Show) -> str:
     """Create environment start comment
 
     Args:
         show: Show object with SHA and other metadata
     """
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Creating ephemeral environment for commit `{show.short_sha}`
+    links = _create_header_links(show.sha)
+    return f"🎪 {links['showtime_link']} is building environment on {links['gha_link']} for {links['commit_link']}"
 
-        **Action:** [View workflow]({get_github_workflow_url()})
-        **Environment:** `{show.short_sha}`
-        **Powered by:** [Superset Showtime](https://github.com/mistercrunch/superset-showtime)
 
-        *Building and deploying... Watch the labels for progress updates.*
-    """
-    ).strip()
-
-
-def success_comment(show, feature_count: Optional[int] = None) -> str:
+def success_comment(show: Show, feature_count: Optional[int] = None) -> str:
     """Environment success comment
 
     Args:
         show: Show object with SHA, IP, TTL, etc.
         feature_count: Number of enabled feature flags (optional)
     """
-    feature_line = f"**Feature flags:** {feature_count} enabled\n" if feature_count else ""
+    links = _create_header_links(show.sha)
+    header = f"🎪 {links['showtime_link']} deployed environment on {links['gha_link']} for {links['commit_link']}"
 
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Environment ready at **http://{show.ip}:8080**
+    bullets = [
+        f"**Environment:** http://{show.ip}:8080 (admin/admin)",
+        f"**Lifetime:** {show.ttl} auto-cleanup",
+    ]
 
-        **Environment:** `{show.short_sha}`
-        **Credentials:** admin / admin
-        **TTL:** {show.ttl} (auto-cleanup)
-        {feature_line}
-        **Configuration:** Modify feature flags in your PR code for new SHA
-        **Updates:** Environment updates automatically on new commits
+    if feature_count:
+        bullets.insert(-1, f"**Features:** {feature_count} enabled")
 
-        {get_showtime_footer()}
-    """
-    ).strip()
+    bullets.append("**Updates:** New commits create fresh environments automatically")
 
+    return _format_comment(header, bullets)
 
-def failure_comment(show, error: str) -> str:
+
+def failure_comment(show: Show, error: str) -> str:
     """Environment failure comment
 
     Args:
         show: Show object with SHA and metadata
         error: Error message describing what went wrong
     """
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Environment creation failed.
-
-        **Error:** {error}
-        **Environment:** `{show.short_sha}`
+    links = _create_header_links(show.sha)
+    header = f"🎪 {links['showtime_link']} failed building environment on {links['gha_link']} for {links['commit_link']}"
 
-        Please check the logs and try again.
+    bullets = [
+        f"**Error:** {error}",
+        "**Action:** Check logs and try again with `🎪 ⚡ showtime-trigger-start`",
+    ]
 
-        {get_showtime_footer()}
-    """
-    ).strip()
+    return _format_comment(header, bullets)
 
 
-def cleanup_comment(show) -> str:
+def cleanup_comment(show: Show) -> str:
     """Environment cleanup comment
 
     Args:
         show: Show object with SHA and metadata
     """
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Environment `{show.short_sha}` cleaned up
+    links = _create_header_links(show.sha)
+    header = f"🎪 {links['showtime_link']} cleaned up environment on {links['gha_link']} for {links['commit_link']}"
 
-        **AWS Resources:** ECS service and ECR image deleted
-        **Cost Impact:** No further charges
+    bullets = [
+        "**Resources:** ECS service and ECR image deleted",
+        "**Cost:** No further charges",
+        "**Action:** Add `🎪 ⚡ showtime-trigger-start` to create new environment",
+    ]
 
-        Add `🎪 ⚡ showtime-trigger-start` to create a new environment.
+    return _format_comment(header, bullets)
 
-        {get_showtime_footer()}
-    """
-    ).strip()
 
-
-def rolling_start_comment(current_show, new_sha: str) -> str:
+def rolling_start_comment(current_show: Show, new_sha: str) -> str:
     """Rolling update start comment
 
     Args:
@@ -137,44 +174,38 @@ def rolling_start_comment(current_show, new_sha: str) -> str:
     """
     from .circus import short_sha
 
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Detected new commit - starting rolling update `{current_show.short_sha}` → `{short_sha(new_sha)}`
+    links = _create_header_links(new_sha)
+    header = f"🎪 {links['showtime_link']} is updating {current_show.short_sha}→{short_sha(new_sha)} on {links['gha_link']} for {links['commit_link']}"
 
-        **Action:** Zero-downtime blue-green deployment
-        **Progress:** [View workflow]({get_github_workflow_url()})
-        **Current:** `{current_show.short_sha}` at http://{current_show.ip}:8080
-        **New:** `{short_sha(new_sha)}` (building...)
+    bullets = [
+        f"**Current:** http://{current_show.ip}:8080 (still active)",
+        "**Update:** Zero-downtime blue-green deployment",
+    ]
 
-        *New environment will replace current one automatically.*
-    """
-    ).strip()
+    return _format_comment(header, bullets)
 
 
-def rolling_success_comment(old_show, new_show) -> str:
+def rolling_success_comment(old_show: Show, new_show: Show) -> str:
     """Rolling update success comment
 
     Args:
         old_show: Previous Show object
         new_show: New Show object with updated IP, SHA, TTL
     """
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Rolling update complete! `{old_show.short_sha}` → `{new_show.short_sha}`
+    links = _create_header_links(new_show.sha)
+    header = f"🎪 {links['showtime_link']} updated environment {old_show.short_sha}→{new_show.short_sha} on {links['gha_link']} for {links['commit_link']}"
 
-        **New Environment:** **http://{new_show.ip}:8080**
-        **Deployment:** Zero-downtime blue-green deployment
-        **Credentials:** admin / admin
-        **TTL:** {new_show.ttl} (auto-cleanup)
+    bullets = [
+        f"**Environment:** http://{new_show.ip}:8080 (admin/admin)",
+        f"**Lifetime:** {new_show.ttl} auto-cleanup",
+        "**Deployment:** Zero-downtime blue-green",
+        "**Updates:** New commits create fresh environments automatically",
+    ]
 
-        Your latest changes are now live.
-
-        {get_showtime_footer()}
-    """
-    ).strip()
+    return _format_comment(header, bullets)
 
 
-def rolling_failure_comment(current_show, new_sha: str, error: str) -> str:
+def rolling_failure_comment(current_show: Show, new_sha: str, error: str) -> str:
     """Rolling update failure comment
 
     Args:
@@ -184,15 +215,13 @@ def rolling_failure_comment(current_show, new_sha: str, error: str) -> str:
     """
     from .circus import short_sha
 
-    return textwrap.dedent(
-        f"""
-        🎪 @{get_github_actor()} Rolling update failed `{current_show.short_sha}` → `{short_sha(new_sha)}`
+    links = _create_header_links(new_sha)
+    header = f"🎪 {links['showtime_link']} failed updating to {short_sha(new_sha)} on {links['gha_link']} for {links['commit_link']}"
 
-        **Error:** {error}
-        **Current:** Environment `{current_show.short_sha}` remains active at http://{current_show.ip}:8080
+    bullets = [
+        f"**Error:** {error}",
+        f"**Current:** http://{current_show.ip}:8080 (still active)",
+        "**Action:** Check logs and try again with `🎪 ⚡ showtime-trigger-start`",
+    ]
 
-        Please check the logs and try again with `🎪 ⚡ showtime-trigger-start`.
-
-        {get_showtime_footer()}
-    """
-    ).strip()
+    return _format_comment(header, bullets)

{superset_showtime-0.2.7.dist-info → superset_showtime-0.2.8.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: superset-showtime
-Version: 0.2.7
+Version: 0.2.8
 Summary: 🎪 Apache Superset ephemeral environment management with circus tent emoji state tracking
 Project-URL: Homepage, https://github.com/apache/superset-showtime
 Project-URL: Documentation, https://superset-showtime.readthedocs.io/

{superset_showtime-0.2.7.dist-info → superset_showtime-0.2.8.dist-info}/RECORD

@@ -1,4 +1,4 @@
-showtime/__init__.py,sha256=pBsaci8fhtn2mWIys_2AKT2zpvBfW6-3cMwPhpKRwvM,420
+showtime/__init__.py,sha256=1wse0Q42I1-_VwF1AYaIDYvkqx4eC32omodFrMeStlE,420
 showtime/__main__.py,sha256=EVaDaTX69yIhCzChg99vqvFSCN4ELstEt7Mpb9FMZX8,109
 showtime/cli.py,sha256=gd8OIjdQov7ei8A9A2X8bdreOeWJVhc5FFhAN9u_spQ,62913
 showtime/commands/__init__.py,sha256=M2wn5hYgwNCryMjLT79ncobvK884r-xk3znkCmINN_0,28
@@ -8,10 +8,10 @@ showtime/core/aws.py,sha256=xWrje3MS3LpFeilH6jloWy_VgE9Wky_G5VkRCOB0ZNw,32535
 showtime/core/circus.py,sha256=dtYEU1YnmaE9oWhPwrPiMof1GF5tzckvcDrc9iJ9VpQ,9037
 showtime/core/emojis.py,sha256=MHEDuPIdfNiop4zbNLuviz3eY05QiftYSHHCVbkfKhw,2129
 showtime/core/github.py,sha256=HWhM8_Yq4P-AHq0FV3UfrfQHUHXxkhn74vvc_9RguKA,9822
-showtime/core/github_messages.py,sha256=4LZXsXp-tQ9NvIucCklNH4cfGU7giNdOcrpDPDW2VtE,5990
+showtime/core/github_messages.py,sha256=iKd3AS0uvTnCtR-2jPtEq_efuThC8HUzEAMmQt5c3y4,7187
 showtime/core/label_colors.py,sha256=efhbFnz_3nqEnEqmgyF6_hZbxtCu_fmb68BIIUpSsnk,3895
 showtime/data/ecs-task-definition.json,sha256=0ZaE0FZ8IWduXd2RyscMhXeVgxyym6qtjH02CK9mXBI,2235
-superset_showtime-0.2.7.dist-info/METADATA,sha256=8CIOONb3KbcoOP-B3iySqerxHHYng7pPGpATBWtccco,14635
-superset_showtime-0.2.7.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
-superset_showtime-0.2.7.dist-info/entry_points.txt,sha256=rDW7oZ57mqyBUS4N_3_R7bZNGVHB-104jwmY-hHC_ck,85
-superset_showtime-0.2.7.dist-info/RECORD,,
+superset_showtime-0.2.8.dist-info/METADATA,sha256=fMZkdKW3pgcxx-AXRP5rmTpmOBLEXtVcSaLr2L5A7xg,14635
+superset_showtime-0.2.8.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
+superset_showtime-0.2.8.dist-info/entry_points.txt,sha256=rDW7oZ57mqyBUS4N_3_R7bZNGVHB-104jwmY-hHC_ck,85
+superset_showtime-0.2.8.dist-info/RECORD,,