strawberry-graphql 0.183.2__py3-none-any.whl → 0.183.4__py3-none-any.whl

strawberry/codegen/query_codegen.py

@@ -504,7 +504,9 @@ class QueryCodegen:
         selected_field = self.schema.get_field_for_type(
             selection.name.value, parent_type.name
         )
-        assert selected_field
+        assert (
+            selected_field
+        ), f"Couldn't find {parent_type.name}.{selection.name.value}"
 
         selected_field_type, wrapper = self._unwrap_type(selected_field.type)
         name = capitalize_first(to_camel_case(selection.name.value))
@@ -638,14 +640,13 @@ class QueryCodegen:
 
         for fragment in fragments:
             fragment_class_name = class_name + fragment.type_condition.name.value
-            current_type = GraphQLObjectType(fragment_class_name, [])
+
+            current_type = GraphQLObjectType(fragment_class_name, list(common_fields))
 
             for sub_selection in fragment.selection_set.selections:
                 # TODO: recurse, use existing method ?
                 assert isinstance(sub_selection, FieldNode)
 
-                current_type.fields = list(common_fields)
-
                 parent_type = cast(
                     TypeDefinition,
                     self.schema.get_type_by_name(fragment.type_condition.name.value),

strawberry/utils/typing.py

@@ -1,5 +1,4 @@
 import ast
-import re
 import sys
 import typing
 from functools import lru_cache
@@ -12,6 +11,7 @@ from typing import (  # type: ignore
     Dict,
     ForwardRef,
     Generic,
+    List,
     Optional,
     Tuple,
     Type,
@@ -222,9 +222,66 @@ def _ast_replace_union_operation(
     return expr
 
 
-_annotated_re = re.compile(
-    r"(Annotated\[)(?P<type>\w*),(?P<args>.*)(\])",
-)
+def _get_namespace_from_ast(
+    expr: Union[ast.Expr, ast.expr],
+    globalns: Optional[Dict] = None,
+    localns: Optional[Dict] = None,
+) -> Dict[str, Type]:
+    from strawberry.lazy_type import StrawberryLazyReference
+
+    extra = {}
+
+    if isinstance(expr, ast.Expr) and isinstance(
+        expr.value, (ast.BinOp, ast.Subscript)
+    ):
+        extra.update(_get_namespace_from_ast(expr.value, globalns, localns))
+    elif isinstance(expr, ast.BinOp):
+        for elt in (expr.left, expr.right):
+            extra.update(_get_namespace_from_ast(elt, globalns, localns))
+    elif (
+        isinstance(expr, ast.Subscript)
+        and isinstance(expr.value, ast.Name)
+        and expr.value.id == "Union"
+    ):
+        if hasattr(ast, "Index") and isinstance(expr.slice, ast.Index):
+            # The cast is required for mypy on python 3.7 and 3.8
+            expr_slice = cast(Any, expr.slice).value
+        else:
+            expr_slice = expr.slice
+
+        for elt in cast(ast.Tuple, expr_slice).elts:
+            extra.update(_get_namespace_from_ast(elt, globalns, localns))
+    elif (
+        isinstance(expr, ast.Subscript)
+        and isinstance(expr.value, ast.Name)
+        and expr.value.id == "Annotated"
+    ):
+        assert ast_unparse
+
+        if hasattr(ast, "Index") and isinstance(expr.slice, ast.Index):
+            # The cast is required for mypy on python 3.7 and 3.8
+            expr_slice = cast(Any, expr.slice).value
+        else:
+            expr_slice = expr.slice
+
+        args: List[str] = []
+        for elt in cast(ast.Tuple, expr_slice).elts:
+            extra.update(_get_namespace_from_ast(elt, globalns, localns))
+            args.append(ast_unparse(elt))
+
+        # When using forward refs, the whole
+        # Annotated[SomeType, strawberry.lazy("type.module")] is a forward ref,
+        # and trying to _eval_type on it will fail. Take a different approach
+        # here to resolve lazy types by execing the annotated args, resolving the
+        # type directly and then adding it to extra namespace, so that _eval_type
+        # can properly resolve it later
+        type_name = args[0]
+        for arg in args[1:]:
+            evaled_arg = eval(arg, globalns, localns)  # noqa: PGH001
+            if isinstance(evaled_arg, StrawberryLazyReference):
+                extra[type_name] = evaled_arg.resolve_forward_ref(ForwardRef(type_name))
+
+    return extra
 
 
 def eval_type(
@@ -240,51 +297,22 @@ def eval_type(
     globalns = globalns or {}
     # If this is not a string, maybe its args are (e.g. List["Foo"])
     if isinstance(type_, ForwardRef):
+        ast_obj = cast(ast.Expr, ast.parse(type_.__forward_arg__).body[0])
+
         # For Python 3.10+, we can use the built-in _eval_type function directly.
         # It will handle "|" notations properly
         if sys.version_info < (3, 10):
-            parsed = _ast_replace_union_operation(
-                cast(ast.Expr, ast.parse(type_.__forward_arg__).body[0])
-            )
+            ast_obj = _ast_replace_union_operation(ast_obj)
 
             # We replaced "a | b" with "Union[a, b], so make sure Union can be resolved
             # at globalns because it may not be there
             if "Union" not in globalns:
                 globalns["Union"] = Union
 
-            assert ast_unparse
-            type_ = ForwardRef(ast_unparse(parsed))
-
-        # When using forward refs, the whole
-        # Annotated[SomeType, strabwerry.lazy("type.module")] is a forward ref,
-        # and trying to _eval_type on it will fail. Take a different approach
-        # here to resolve lazy types by execing the annotated args and resolving
-        # the type directly.
-        annotated_match = _annotated_re.search(type_.__forward_arg__)
-        if annotated_match:
-            gdict = annotated_match.groupdict()
-            # FIXME: Eval the remaining annotated args to get their real values
-            # We might want to refactor how we import lazy modules to avoid having
-            # to eval the code in here
-            args = eval(f'({gdict["args"]}, )', globalns, localns)  # noqa: PGH001
-            lazy_ref = next(
-                (arg for arg in args if isinstance(arg, StrawberryLazyReference)),
-                None,
-            )
-            if lazy_ref is not None:
-                remaining = [
-                    a for a in args if not isinstance(a, StrawberryLazyReference)
-                ]
-                type_ = lazy_ref.resolve_forward_ref(ForwardRef(gdict["type"]))
-                # If we only had a StrawberryLazyReference, we can return the type
-                # directly. It already did its job!
-                if not remaining:
-                    return type_
+        globalns.update(_get_namespace_from_ast(ast_obj, globalns, localns))
 
-                # Otherwise return the type annotated with the remaining annotations
-                return Annotated.__class_getitem__(  # type: ignore
-                    (type_, *remaining),
-                )
+        assert ast_unparse
+        type_ = ForwardRef(ast_unparse(ast_obj))
 
         return _eval_type(type_, globalns, localns)
 
@@ -302,7 +330,12 @@ def eval_type(
                         for a in args[1:]
                         if not isinstance(arg, StrawberryLazyReference)
                     ]
-                    args = (arg.resolve_forward_ref(args[0]), *remaining_args)
+                    type_arg = (
+                        arg.resolve_forward_ref(args[0])
+                        if isinstance(args[0], ForwardRef)
+                        else args[0]
+                    )
+                    args = (type_arg, *remaining_args)
                     break
                 if isinstance(arg, StrawberryAuto):
                     remaining_args = [

{strawberry_graphql-0.183.2.dist-info → strawberry_graphql-0.183.4.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: strawberry-graphql
-Version: 0.183.2
+Version: 0.183.4
 Summary: A library for creating GraphQL APIs
 Home-page: https://strawberry.rocks/
 License: MIT

{strawberry_graphql-0.183.2.dist-info → strawberry_graphql-0.183.4.dist-info}/RECORD

@@ -41,7 +41,7 @@ strawberry/codegen/plugins/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJ
 strawberry/codegen/plugins/print_operation.py,sha256=9ZKkYabiHj1qofIjim38Oa6Z8rHDAT2Wm4Lspq2Ka0Q,6423
 strawberry/codegen/plugins/python.py,sha256=qRLC73DRbWLEd_nPUjyVJR9LwoCeUMh8_S6ZfZzmi0U,4980
 strawberry/codegen/plugins/typescript.py,sha256=QhabDXIlgbGcb3U7Jr0HHRYcsFxPT86IH0MDIpe-6SQ,3610
-strawberry/codegen/query_codegen.py,sha256=oexvvXI8yCRXSgXAsEIirn0lGSbcpYjMGS4hlNTIm28,22178
+strawberry/codegen/query_codegen.py,sha256=dykbL-XAC1V6SCrzvjrcVfUkIjRqAy9Ac9wbChuUM2Q,22221
 strawberry/codegen/types.py,sha256=VgN5rVnP4RQ7xmEaU8SpiSlAWClEcc_ouKQh9e4NG6w,2916
 strawberry/custom_scalar.py,sha256=GCmiItYvLYL5nOHhij3e7AMGYz0aIiOkqQjHeZMZoyc,5671
 strawberry/dataloader.py,sha256=HO8pnK9kQEJfvpFaMHnpSESvkef2c6AZHCQSp_aZJno,7697
@@ -222,9 +222,9 @@ strawberry/utils/inspect.py,sha256=wax9UsOwBrVX0KZad61VOiqsyKgBrODWTAldxE_5woM,3
 strawberry/utils/logging.py,sha256=pz1pRJtx5xX2ejGKNN-fG8zPA4SJjnq1HK9xaQpjd4s,1106
 strawberry/utils/operation.py,sha256=Um-tBCPl3_bVFN2Ph7o1mnrxfxBes4HFCj6T0x4kZxE,1135
 strawberry/utils/str_converters.py,sha256=VdOnzaxhwJnmQl1Lon0VOjl72uXhM8tLfGxoGwn3arI,657
-strawberry/utils/typing.py,sha256=4xa5qGt8TVeknAmLZIcDekom-rh--0GU3qBMGRQhhVM,11697
-strawberry_graphql-0.183.2.dist-info/LICENSE,sha256=m-XnIVUKqlG_AWnfi9NReh9JfKhYOB-gJfKE45WM1W8,1072
-strawberry_graphql-0.183.2.dist-info/METADATA,sha256=oGt7jTJlya1NzIF_O9RsSnzraj-cuVB1IIGjvMTuri8,7644
-strawberry_graphql-0.183.2.dist-info/WHEEL,sha256=Zb28QaM1gQi8f4VCBhsUklF61CTlNYfs9YAZn-TOGFk,88
-strawberry_graphql-0.183.2.dist-info/entry_points.txt,sha256=Nk7-aT3_uEwCgyqtHESV9H6Mc31cK-VAvhnQNTzTb4k,49
-strawberry_graphql-0.183.2.dist-info/RECORD,,
+strawberry/utils/typing.py,sha256=MpKjtblkpDBCbjS-yeNSxnOo594_2FLHBOdXiYlAjLM,12716
+strawberry_graphql-0.183.4.dist-info/LICENSE,sha256=m-XnIVUKqlG_AWnfi9NReh9JfKhYOB-gJfKE45WM1W8,1072
+strawberry_graphql-0.183.4.dist-info/METADATA,sha256=wKAsyfxwdo9U3murKB1PeRmNJRIhWkdqjjHNGF-TM9c,7644
+strawberry_graphql-0.183.4.dist-info/WHEEL,sha256=Zb28QaM1gQi8f4VCBhsUklF61CTlNYfs9YAZn-TOGFk,88
+strawberry_graphql-0.183.4.dist-info/entry_points.txt,sha256=Nk7-aT3_uEwCgyqtHESV9H6Mc31cK-VAvhnQNTzTb4k,49
+strawberry_graphql-0.183.4.dist-info/RECORD,,