skypilot-nightly 1.0.0.dev20241222__py3-none-any.whl → 1.0.0.dev20241224__py3-none-any.whl

sky/data/storage.py

@@ -72,6 +72,8 @@ _BUCKET_EXTERNALLY_DELETED_DEBUG_MESSAGE = (
     'Bucket {bucket_name!r} does not exist. '
     'It may have been deleted externally.')
 
+_STORAGE_LOG_FILE_NAME = 'storage_sync.log'
+
 
 def get_cached_enabled_storage_clouds_or_refresh(
         raise_if_no_cloud_access: bool = False) -> List[str]:
@@ -1067,7 +1069,7 @@ class Storage(object):
         add_if_not_none('source', self.source)
 
         stores = None
-        if len(self.stores) > 0:
+        if self.stores:
             stores = ','.join([store.value for store in self.stores])
         add_if_not_none('store', stores)
         add_if_not_none('persistent', self.persistent)
@@ -1331,17 +1333,24 @@ class S3Store(AbstractStore):
         else:
             source_message = source_path_list[0]
 
+        log_path = sky_logging.generate_tmp_logging_file_path(
+            _STORAGE_LOG_FILE_NAME)
+        sync_path = f'{source_message} -> s3://{self.name}/'
         with rich_utils.safe_status(
-                ux_utils.spinner_message(f'Syncing {source_message} -> '
-                                         f's3://{self.name}/')):
+                ux_utils.spinner_message(f'Syncing {sync_path}',
+                                         log_path=log_path)):
             data_utils.parallel_upload(
                 source_path_list,
                 get_file_sync_command,
                 get_dir_sync_command,
+                log_path,
                 self.name,
                 self._ACCESS_DENIED_MESSAGE,
                 create_dirs=create_dirs,
                 max_concurrent_uploads=_MAX_CONCURRENT_UPLOADS)
+        logger.info(
+            ux_utils.finishing_message(f'Storage synced: {sync_path}',
+                                       log_path))
 
     def _transfer_to_s3(self) -> None:
         assert isinstance(self.source, str), self.source
@@ -1741,13 +1750,19 @@ class GcsStore(AbstractStore):
         gsutil_alias, alias_gen = data_utils.get_gsutil_command()
         sync_command = (f'{alias_gen}; echo "{copy_list}" | {gsutil_alias} '
                         f'cp -e -n -r -I gs://{self.name}')
-
+        log_path = sky_logging.generate_tmp_logging_file_path(
+            _STORAGE_LOG_FILE_NAME)
+        sync_path = f'{source_message} -> gs://{self.name}/'
         with rich_utils.safe_status(
-                ux_utils.spinner_message(f'Syncing {source_message} -> '
-                                         f'gs://{self.name}/')):
+                ux_utils.spinner_message(f'Syncing {sync_path}',
+                                         log_path=log_path)):
             data_utils.run_upload_cli(sync_command,
                                       self._ACCESS_DENIED_MESSAGE,
-                                      bucket_name=self.name)
+                                      bucket_name=self.name,
+                                      log_path=log_path)
+        logger.info(
+            ux_utils.finishing_message(f'Storage synced: {sync_path}',
+                                       log_path))
 
     def batch_gsutil_rsync(self,
                            source_path_list: List[Path],
@@ -1797,17 +1812,24 @@ class GcsStore(AbstractStore):
         else:
             source_message = source_path_list[0]
 
+        log_path = sky_logging.generate_tmp_logging_file_path(
+            _STORAGE_LOG_FILE_NAME)
+        sync_path = f'{source_message} -> gs://{self.name}/'
         with rich_utils.safe_status(
-                ux_utils.spinner_message(f'Syncing {source_message} -> '
-                                         f'gs://{self.name}/')):
+                ux_utils.spinner_message(f'Syncing {sync_path}',
+                                         log_path=log_path)):
             data_utils.parallel_upload(
                 source_path_list,
                 get_file_sync_command,
                 get_dir_sync_command,
+                log_path,
                 self.name,
                 self._ACCESS_DENIED_MESSAGE,
                 create_dirs=create_dirs,
                 max_concurrent_uploads=_MAX_CONCURRENT_UPLOADS)
+        logger.info(
+            ux_utils.finishing_message(f'Storage synced: {sync_path}',
+                                       log_path))
 
     def _transfer_to_gcs(self) -> None:
         if isinstance(self.source, str) and self.source.startswith('s3://'):
@@ -2535,17 +2557,24 @@ class AzureBlobStore(AbstractStore):
         container_endpoint = data_utils.AZURE_CONTAINER_URL.format(
             storage_account_name=self.storage_account_name,
             container_name=self.name)
+        log_path = sky_logging.generate_tmp_logging_file_path(
+            _STORAGE_LOG_FILE_NAME)
+        sync_path = f'{source_message} -> {container_endpoint}/'
         with rich_utils.safe_status(
-                ux_utils.spinner_message(
-                    f'Syncing {source_message} -> {container_endpoint}/')):
+                ux_utils.spinner_message(f'Syncing {sync_path}',
+                                         log_path=log_path)):
             data_utils.parallel_upload(
                 source_path_list,
                 get_file_sync_command,
                 get_dir_sync_command,
+                log_path,
                 self.name,
                 self._ACCESS_DENIED_MESSAGE,
                 create_dirs=create_dirs,
                 max_concurrent_uploads=_MAX_CONCURRENT_UPLOADS)
+        logger.info(
+            ux_utils.finishing_message(f'Storage synced: {sync_path}',
+                                       log_path))
 
     def _get_bucket(self) -> Tuple[str, bool]:
         """Obtains the AZ Container.
@@ -2938,17 +2967,24 @@ class R2Store(AbstractStore):
         else:
             source_message = source_path_list[0]
 
+        log_path = sky_logging.generate_tmp_logging_file_path(
+            _STORAGE_LOG_FILE_NAME)
+        sync_path = f'{source_message} -> r2://{self.name}/'
         with rich_utils.safe_status(
-                ux_utils.spinner_message(
-                    f'Syncing {source_message} -> r2://{self.name}/')):
+                ux_utils.spinner_message(f'Syncing {sync_path}',
+                                         log_path=log_path)):
             data_utils.parallel_upload(
                 source_path_list,
                 get_file_sync_command,
                 get_dir_sync_command,
+                log_path,
                 self.name,
                 self._ACCESS_DENIED_MESSAGE,
                 create_dirs=create_dirs,
                 max_concurrent_uploads=_MAX_CONCURRENT_UPLOADS)
+        logger.info(
+            ux_utils.finishing_message(f'Storage synced: {sync_path}',
+                                       log_path))
 
     def _transfer_to_r2(self) -> None:
         assert isinstance(self.source, str), self.source
@@ -3379,17 +3415,24 @@ class IBMCosStore(AbstractStore):
         else:
             source_message = source_path_list[0]
 
+        log_path = sky_logging.generate_tmp_logging_file_path(
+            _STORAGE_LOG_FILE_NAME)
+        sync_path = f'{source_message} -> cos://{self.region}/{self.name}/'
         with rich_utils.safe_status(
-                ux_utils.spinner_message(f'Syncing {source_message} -> '
-                                         f'cos://{self.region}/{self.name}/')):
+                ux_utils.spinner_message(f'Syncing {sync_path}',
+                                         log_path=log_path)):
             data_utils.parallel_upload(
                 source_path_list,
                 get_file_sync_command,
                 get_dir_sync_command,
+                log_path,
                 self.name,
                 self._ACCESS_DENIED_MESSAGE,
                 create_dirs=create_dirs,
                 max_concurrent_uploads=_MAX_CONCURRENT_UPLOADS)
+        logger.info(
+            ux_utils.finishing_message(f'Storage synced: {sync_path}',
+                                       log_path))
 
     def _get_bucket(self) -> Tuple[StorageHandle, bool]:
         """returns IBM COS bucket object if exists, otherwise creates it.

sky/jobs/core.py

@@ -347,8 +347,8 @@ def cancel(name: Optional[str] = None,
         stopped_message='All managed jobs should have finished.')
 
     job_id_str = ','.join(map(str, job_ids))
-    if sum([len(job_ids) > 0, name is not None, all]) != 1:
-        argument_str = f'job_ids={job_id_str}' if len(job_ids) > 0 else ''
+    if sum([bool(job_ids), name is not None, all]) != 1:
+        argument_str = f'job_ids={job_id_str}' if job_ids else ''
         argument_str += f' name={name}' if name is not None else ''
         argument_str += ' all' if all else ''
         with ux_utils.print_exception_no_traceback():

sky/jobs/state.py

@@ -591,7 +591,7 @@ def get_latest_task_id_status(
     If the job_id does not exist, (None, None) will be returned.
     """
     id_statuses = _get_all_task_ids_statuses(job_id)
-    if len(id_statuses) == 0:
+    if not id_statuses:
         return None, None
     task_id, status = id_statuses[-1]
     for task_id, status in id_statuses:
@@ -617,7 +617,7 @@ def get_failure_reason(job_id: int) -> Optional[str]:
             WHERE spot_job_id=(?)
             ORDER BY task_id ASC""", (job_id,)).fetchall()
         reason = [r[0] for r in reason if r[0] is not None]
-        if len(reason) == 0:
+        if not reason:
             return None
         return reason[0]
 

sky/jobs/utils.py

@@ -234,11 +234,11 @@ def cancel_jobs_by_id(job_ids: Optional[List[int]]) -> str:
     if job_ids is None:
         job_ids = managed_job_state.get_nonterminal_job_ids_by_name(None)
     job_ids = list(set(job_ids))
-    if len(job_ids) == 0:
+    if not job_ids:
         return 'No job to cancel.'
     job_id_str = ', '.join(map(str, job_ids))
     logger.info(f'Cancelling jobs {job_id_str}.')
-    cancelled_job_ids = []
+    cancelled_job_ids: List[int] = []
     for job_id in job_ids:
         # Check the status of the managed job status. If it is in
         # terminal state, we can safely skip it.
@@ -268,7 +268,7 @@ def cancel_jobs_by_id(job_ids: Optional[List[int]]) -> str:
             shutil.copy(str(signal_file), str(legacy_signal_file))
         cancelled_job_ids.append(job_id)
 
-    if len(cancelled_job_ids) == 0:
+    if not cancelled_job_ids:
         return 'No job to cancel.'
     identity_str = f'Job with ID {cancelled_job_ids[0]} is'
     if len(cancelled_job_ids) > 1:
@@ -281,7 +281,7 @@ def cancel_jobs_by_id(job_ids: Optional[List[int]]) -> str:
 def cancel_job_by_name(job_name: str) -> str:
     """Cancel a job by name."""
     job_ids = managed_job_state.get_nonterminal_job_ids_by_name(job_name)
-    if len(job_ids) == 0:
+    if not job_ids:
         return f'No running job found with name {job_name!r}.'
     if len(job_ids) > 1:
         return (f'{colorama.Fore.RED}Multiple running jobs found '
@@ -515,7 +515,7 @@ def stream_logs(job_id: Optional[int],
                 for job in managed_jobs
                 if job['job_name'] == job_name
             }
-            if len(managed_job_ids) == 0:
+            if not managed_job_ids:
                 return f'No managed job found with name {job_name!r}.'
             if len(managed_job_ids) > 1:
                 job_ids_str = ', '.join(
@@ -541,7 +541,7 @@ def stream_logs(job_id: Optional[int],
     if job_id is None:
         assert job_name is not None
         job_ids = managed_job_state.get_nonterminal_job_ids_by_name(job_name)
-        if len(job_ids) == 0:
+        if not job_ids:
             return f'No running managed job found with name {job_name!r}.'
         if len(job_ids) > 1:
             raise ValueError(

sky/optimizer.py

@@ -188,7 +188,7 @@ class Optimizer:
         """Removes special Source and Sink nodes."""
         source = [t for t in dag.tasks if t.name == _DUMMY_SOURCE_NAME]
         sink = [t for t in dag.tasks if t.name == _DUMMY_SINK_NAME]
-        if len(source) == len(sink) == 0:
+        if not source and not sink:
             return
         assert len(source) == len(sink) == 1, dag.tasks
         dag.remove(source[0])
@@ -1298,7 +1298,7 @@ def _fill_in_launchable_resources(
                 resources, num_nodes=task.num_nodes)
             if feasible_resources.hint is not None:
                 hints[cloud] = feasible_resources.hint
-            if len(feasible_resources.resources_list) > 0:
+            if feasible_resources.resources_list:
                 # Assume feasible_resources is sorted by prices. Guaranteed by
                 # the implementation of get_feasible_launchable_resources and
                 # the underlying service_catalog filtering
@@ -1310,7 +1310,7 @@ def _fill_in_launchable_resources(
             else:
                 all_fuzzy_candidates.update(
                     feasible_resources.fuzzy_candidate_list)
-        if len(launchable[resources]) == 0:
+        if not launchable[resources]:
             clouds_str = str(clouds_list) if len(clouds_list) > 1 else str(
                 clouds_list[0])
             num_node_str = ''

sky/provision/aws/config.py

@@ -279,7 +279,7 @@ def _is_subnet_public(ec2, subnet_id, vpc_id: Optional[str]) -> bool:
     logger.debug(f'subnet {subnet_id} route tables: {route_tables}')
     if _has_igw_route(route_tables):
         return True
-    if len(route_tables) > 0:
+    if route_tables:
         return False
 
     # Handle the case that a "main" route table is implicitly associated with
@@ -454,7 +454,7 @@ def _vpc_id_from_security_group_ids(ec2, sg_ids: List[str]) -> Any:
 
     no_sg_msg = ('Failed to detect a security group with id equal to any of '
                  'the configured SecurityGroupIds.')
-    assert len(vpc_ids) > 0, no_sg_msg
+    assert vpc_ids, no_sg_msg
 
     return vpc_ids[0]
 

sky/provision/gcp/config.py

@@ -397,7 +397,7 @@ def _check_firewall_rules(cluster_name: str, vpc_name: str, project_id: str,
     operation = compute.networks().getEffectiveFirewalls(project=project_id,
                                                          network=vpc_name)
     response = operation.execute()
-    if len(response) == 0:
+    if not response:
         return False
     effective_rules = response['firewalls']
 
@@ -515,7 +515,7 @@ def _create_rules(project_id: str, compute, rules, vpc_name):
         rule_list = _list_firewall_rules(project_id,
                                          compute,
                                          filter=f'(name={rule_name})')
-        if len(rule_list) > 0:
+        if rule_list:
             _delete_firewall_rule(project_id, compute, rule_name)
 
         body = rule.copy()
@@ -624,7 +624,7 @@ def get_usable_vpc_and_subnet(
     vpc_list = _list_vpcnets(project_id,
                              compute,
                              filter=f'name={constants.SKYPILOT_VPC_NAME}')
-    if len(vpc_list) == 0:
+    if not vpc_list:
         body = constants.VPC_TEMPLATE.copy()
         body['name'] = body['name'].format(VPC_NAME=constants.SKYPILOT_VPC_NAME)
         body['selfLink'] = body['selfLink'].format(

sky/provision/kubernetes/config.py

@@ -232,7 +232,7 @@ def _get_resource(container_resources: Dict[str, Any], resource_name: str,
     # Look for keys containing the resource_name. For example,
     # the key 'nvidia.com/gpu' contains the key 'gpu'.
     matching_keys = [key for key in resources if resource_name in key.lower()]
-    if len(matching_keys) == 0:
+    if not matching_keys:
         return float('inf')
     if len(matching_keys) > 1:
         # Should have only one match -- mostly relevant for gpu.
@@ -265,7 +265,7 @@ def _configure_autoscaler_service_account(
     field_selector = f'metadata.name={name}'
     accounts = (kubernetes.core_api(context).list_namespaced_service_account(
         namespace, field_selector=field_selector).items)
-    if len(accounts) > 0:
+    if accounts:
         assert len(accounts) == 1
         # Nothing to check for equality and patch here,
         # since the service_account.metadata.name is the only important
@@ -308,7 +308,7 @@ def _configure_autoscaler_role(namespace: str, context: Optional[str],
     field_selector = f'metadata.name={name}'
     roles = (kubernetes.auth_api(context).list_namespaced_role(
         namespace, field_selector=field_selector).items)
-    if len(roles) > 0:
+    if roles:
         assert len(roles) == 1
         existing_role = roles[0]
         # Convert to k8s object to compare
@@ -374,7 +374,7 @@ def _configure_autoscaler_role_binding(
     field_selector = f'metadata.name={name}'
     role_bindings = (kubernetes.auth_api(context).list_namespaced_role_binding(
         rb_namespace, field_selector=field_selector).items)
-    if len(role_bindings) > 0:
+    if role_bindings:
         assert len(role_bindings) == 1
         existing_binding = role_bindings[0]
         new_rb = kubernetes_utils.dict_to_k8s_object(binding, 'V1RoleBinding')
@@ -415,7 +415,7 @@ def _configure_autoscaler_cluster_role(namespace, context,
     field_selector = f'metadata.name={name}'
     cluster_roles = (kubernetes.auth_api(context).list_cluster_role(
         field_selector=field_selector).items)
-    if len(cluster_roles) > 0:
+    if cluster_roles:
         assert len(cluster_roles) == 1
         existing_cr = cluster_roles[0]
         new_cr = kubernetes_utils.dict_to_k8s_object(role, 'V1ClusterRole')
@@ -460,7 +460,7 @@ def _configure_autoscaler_cluster_role_binding(
     field_selector = f'metadata.name={name}'
     cr_bindings = (kubernetes.auth_api(context).list_cluster_role_binding(
         field_selector=field_selector).items)
-    if len(cr_bindings) > 0:
+    if cr_bindings:
         assert len(cr_bindings) == 1
         existing_binding = cr_bindings[0]
         new_binding = kubernetes_utils.dict_to_k8s_object(
@@ -639,7 +639,7 @@ def _configure_services(namespace: str, context: Optional[str],
         field_selector = f'metadata.name={name}'
         services = (kubernetes.core_api(context).list_namespaced_service(
             namespace, field_selector=field_selector).items)
-        if len(services) > 0:
+        if services:
             assert len(services) == 1
             existing_service = services[0]
             # Convert to k8s object to compare

sky/provision/kubernetes/network_utils.py

@@ -230,7 +230,7 @@ def get_ingress_external_ip_and_ports(
             namespace, _request_timeout=kubernetes.API_TIMEOUT).items
         if item.metadata.name == 'ingress-nginx-controller'
     ]
-    if len(ingress_services) == 0:
+    if not ingress_services:
         return (None, None)
 
     ingress_service = ingress_services[0]

sky/provision/kubernetes/utils.py

@@ -583,7 +583,7 @@ def check_instance_fits(context: Optional[str],
             node for node in nodes if gpu_label_key in node.metadata.labels and
             node.metadata.labels[gpu_label_key] == gpu_label_val
         ]
-        assert len(gpu_nodes) > 0, 'GPU nodes not found'
+        assert gpu_nodes, 'GPU nodes not found'
         if is_tpu_on_gke(acc_type):
             # If requested accelerator is a TPU type, check if the cluster
             # has sufficient TPU resource to meet the requirement.
@@ -1526,7 +1526,7 @@ def clean_zombie_ssh_jump_pod(namespace: str, context: Optional[str],
     def find(l, predicate):
         """Utility function to find element in given list"""
         results = [x for x in l if predicate(x)]
-        return results[0] if len(results) > 0 else None
+        return results[0] if results else None
 
     # Get the SSH jump pod name from the head pod
     try:

sky/provision/lambda_cloud/lambda_utils.py

@@ -50,7 +50,7 @@ class Metadata:
         if value is None:
             if instance_id in metadata:
                 metadata.pop(instance_id)  # del entry
-            if len(metadata) == 0:
+            if not metadata:
                 if os.path.exists(self.path):
                     os.remove(self.path)
                 return
@@ -69,7 +69,7 @@ class Metadata:
         for instance_id in list(metadata.keys()):
             if instance_id not in instance_ids:
                 del metadata[instance_id]
-        if len(metadata) == 0:
+        if not metadata:
             os.remove(self.path)
             return
         with open(self.path, 'w', encoding='utf-8') as f:
@@ -150,7 +150,7 @@ class LambdaCloudClient:
                              ['regions_with_capacity_available'])
         available_regions = [reg['name'] for reg in available_regions]
         if region not in available_regions:
-            if len(available_regions) > 0:
+            if available_regions:
                 aval_reg = ' '.join(available_regions)
             else:
                 aval_reg = 'None'

sky/provision/oci/query_utils.py

@@ -248,7 +248,7 @@ class QueryHelper:
                 limit=1)
 
         compartments = list_compartments_response.data
-        if len(compartments) > 0:
+        if compartments:
             skypilot_compartment = compartments[0].id
             return skypilot_compartment
 
@@ -274,7 +274,7 @@ class QueryHelper:
             display_name=oci_utils.oci_config.VCN_NAME,
             lifecycle_state='AVAILABLE')
         vcns = list_vcns_response.data
-        if len(vcns) > 0:
+        if vcns:
             # Found the VCN.
             skypilot_vcn = vcns[0].id
             list_subnets_response = net_client.list_subnets(
@@ -359,7 +359,7 @@ class QueryHelper:
                 if str(s.cidr_block).startswith('all-') and str(s.cidr_block).
                 endswith('-services-in-oracle-services-network')
             ]
-            if len(services) > 0:
+            if services:
                 # Create service gateway for regional services.
                 create_sg_response = net_client.create_service_gateway(
                     create_service_gateway_details=oci_adaptor.oci.core.models.

sky/provision/vsphere/common/vim_utils.py

@@ -56,7 +56,7 @@ def get_hosts_by_cluster_names(content, vcenter_name, cluster_name_dicts=None):
             'name': cluster.name
         } for cluster in cluster_view.view]
         cluster_view.Destroy()
-        if len(cluster_name_dicts) == 0:
+        if not cluster_name_dicts:
             logger.warning(f'vCenter \'{vcenter_name}\' has no clusters')
 
     # Retrieve all cluster names from the cluster_name_dicts

sky/provision/vsphere/instance.py

@@ -162,7 +162,7 @@ def _create_instances(
     if not gpu_instance:
         # Find an image for CPU
         images_df = images_df[images_df['GpuTags'] == '\'[]\'']
-        if len(images_df) == 0:
+        if not images_df:
             logger.error(
                 f'Can not find an image for instance type: {instance_type}.')
             raise Exception(
@@ -185,7 +185,7 @@ def _create_instances(
         image_instance_mapping_df = image_instance_mapping_df[
             image_instance_mapping_df['InstanceType'] == instance_type]
 
-        if len(image_instance_mapping_df) == 0:
+        if not image_instance_mapping_df:
             raise Exception(f"""There is no image can match instance type named
                 {instance_type}
                 If you are using CPU-only instance, assign an image with tag
@@ -218,10 +218,9 @@ def _create_instances(
     hosts_df = hosts_df[(hosts_df['AvailableCPUs'] /
                          hosts_df['cpuMhz']) >= cpus_needed]
     hosts_df = hosts_df[hosts_df['AvailableMemory(MB)'] >= memory_needed]
-    assert len(hosts_df) > 0, (
-        f'There is no host available to create the instance '
-        f'{vms_item["InstanceType"]}, at least {cpus_needed} '
-        f'cpus and {memory_needed}MB memory are required.')
+    assert hosts_df, (f'There is no host available to create the instance '
+                      f'{vms_item["InstanceType"]}, at least {cpus_needed} '
+                      f'cpus and {memory_needed}MB memory are required.')
 
     # Sort the hosts df by AvailableCPUs to get the compatible host with the
     # least resource
@@ -365,7 +364,7 @@ def _choose_vsphere_cluster_name(config: common.ProvisionConfig, region: str,
     skypilot framework-optimized availability_zones"""
     vsphere_cluster_name = None
     vsphere_cluster_name_str = config.provider_config['availability_zone']
-    if len(vc_object.clusters) > 0:
+    if vc_object.clusters:
         for optimized_cluster_name in vsphere_cluster_name_str.split(','):
             if optimized_cluster_name in [
                     item['name'] for item in vc_object.clusters

sky/provision/vsphere/vsphere_utils.py

@@ -257,7 +257,7 @@ class VsphereClient:
         # hard code here. should support configure later.
         profile_name = 'skypilot_policy'
         storage_profile_id = None
-        if len(profile_ids) > 0:
+        if profile_ids:
             profiles = pm.PbmRetrieveContent(profileIds=profile_ids)
             for profile in profiles:
                 if profile_name in profile.name:

sky/resources.py

@@ -661,7 +661,7 @@ class Resources:
                     continue
                 valid_clouds.append(cloud)
 
-            if len(valid_clouds) == 0:
+            if not valid_clouds:
                 if len(enabled_clouds) == 1:
                     cloud_str = f'for cloud {enabled_clouds[0]}'
                 else:
@@ -773,7 +773,7 @@ class Resources:
             for cloud in enabled_clouds:
                 if cloud.instance_type_exists(self._instance_type):
                     valid_clouds.append(cloud)
-            if len(valid_clouds) == 0:
+            if not valid_clouds:
                 if len(enabled_clouds) == 1:
                     cloud_str = f'for cloud {enabled_clouds[0]}'
                 else:
@@ -1008,7 +1008,7 @@ class Resources:
                         f'Label rejected due to {cloud}: {err_msg}'
                     ])
                     break
-        if len(invalid_table.rows) > 0:
+        if invalid_table.rows:
             with ux_utils.print_exception_no_traceback():
                 raise ValueError(
                     'The following labels are invalid:'
@@ -1283,7 +1283,7 @@ class Resources:
             _cluster_config_overrides=override.pop(
                 '_cluster_config_overrides', self._cluster_config_overrides),
         )
-        assert len(override) == 0
+        assert not override
         return resources
 
     def valid_on_region_zones(self, region: str, zones: List[str]) -> bool:

sky/serve/autoscalers.py

@@ -320,8 +320,8 @@ class RequestRateAutoscaler(Autoscaler):
         """Select outdated replicas to scale down."""
 
         if self.update_mode == serve_utils.UpdateMode.ROLLING:
-            latest_ready_replicas = []
-            old_nonterminal_replicas = []
+            latest_ready_replicas: List['replica_managers.ReplicaInfo'] = []
+            old_nonterminal_replicas: List['replica_managers.ReplicaInfo'] = []
             for info in replica_infos:
                 if info.version == self.latest_version:
                     if info.is_ready:

sky/serve/core.py

@@ -360,7 +360,7 @@ def update(
         raise RuntimeError(e.error_msg) from e
 
     service_statuses = serve_utils.load_service_status(serve_status_payload)
-    if len(service_statuses) == 0:
+    if not service_statuses:
         with ux_utils.print_exception_no_traceback():
             raise RuntimeError(f'Cannot find service {service_name!r}.'
                                f'To spin up a service, use {ux_utils.BOLD}'
@@ -491,9 +491,9 @@ def down(
         stopped_message='All services should have terminated.')
 
     service_names_str = ','.join(service_names)
-    if sum([len(service_names) > 0, all]) != 1:
-        argument_str = f'service_names={service_names_str}' if len(
-            service_names) > 0 else ''
+    if sum([bool(service_names), all]) != 1:
+        argument_str = (f'service_names={service_names_str}'
+                        if service_names else '')
         argument_str += ' all' if all else ''
         raise ValueError('Can only specify one of service_names or all. '
                          f'Provided {argument_str!r}.')

sky/serve/replica_managers.py

@@ -172,7 +172,7 @@ def _get_resources_ports(task_yaml: str) -> str:
     """Get the resources ports used by the task."""
     task = sky.Task.from_yaml(task_yaml)
     # Already checked all ports are the same in sky.serve.core.up
-    assert len(task.resources) >= 1, task
+    assert task.resources, task
     task_resources: 'resources.Resources' = list(task.resources)[0]
     # Already checked the resources have and only have one port
     # before upload the task yaml.

sky/serve/serve_state.py

@@ -226,7 +226,7 @@ class ServiceStatus(enum.Enum):
                for status in ReplicaStatus.failed_statuses()) > 0:
             return cls.FAILED
         # When min_replicas = 0, there is no (provisioning) replica.
-        if len(replica_statuses) == 0:
+        if not replica_statuses:
             return cls.NO_REPLICA
         return cls.REPLICA_INIT