skypilot-nightly 1.0.0.dev20241222__py3-none-any.whl → 1.0.0.dev20241223__py3-none-any.whl

sky/provision/kubernetes/utils.py

@@ -583,7 +583,7 @@ def check_instance_fits(context: Optional[str],
             node for node in nodes if gpu_label_key in node.metadata.labels and
             node.metadata.labels[gpu_label_key] == gpu_label_val
         ]
-        assert len(gpu_nodes) > 0, 'GPU nodes not found'
+        assert gpu_nodes, 'GPU nodes not found'
         if is_tpu_on_gke(acc_type):
             # If requested accelerator is a TPU type, check if the cluster
             # has sufficient TPU resource to meet the requirement.
@@ -1526,7 +1526,7 @@ def clean_zombie_ssh_jump_pod(namespace: str, context: Optional[str],
     def find(l, predicate):
         """Utility function to find element in given list"""
         results = [x for x in l if predicate(x)]
-        return results[0] if len(results) > 0 else None
+        return results[0] if results else None
 
     # Get the SSH jump pod name from the head pod
     try:

sky/provision/lambda_cloud/lambda_utils.py

@@ -50,7 +50,7 @@ class Metadata:
         if value is None:
             if instance_id in metadata:
                 metadata.pop(instance_id)  # del entry
-            if len(metadata) == 0:
+            if not metadata:
                 if os.path.exists(self.path):
                     os.remove(self.path)
                 return
@@ -69,7 +69,7 @@ class Metadata:
         for instance_id in list(metadata.keys()):
             if instance_id not in instance_ids:
                 del metadata[instance_id]
-        if len(metadata) == 0:
+        if not metadata:
             os.remove(self.path)
             return
         with open(self.path, 'w', encoding='utf-8') as f:
@@ -150,7 +150,7 @@ class LambdaCloudClient:
                              ['regions_with_capacity_available'])
         available_regions = [reg['name'] for reg in available_regions]
         if region not in available_regions:
-            if len(available_regions) > 0:
+            if available_regions:
                 aval_reg = ' '.join(available_regions)
             else:
                 aval_reg = 'None'

sky/provision/oci/query_utils.py

@@ -248,7 +248,7 @@ class QueryHelper:
                 limit=1)
 
         compartments = list_compartments_response.data
-        if len(compartments) > 0:
+        if compartments:
             skypilot_compartment = compartments[0].id
             return skypilot_compartment
 
@@ -274,7 +274,7 @@ class QueryHelper:
             display_name=oci_utils.oci_config.VCN_NAME,
             lifecycle_state='AVAILABLE')
         vcns = list_vcns_response.data
-        if len(vcns) > 0:
+        if vcns:
             # Found the VCN.
             skypilot_vcn = vcns[0].id
             list_subnets_response = net_client.list_subnets(
@@ -359,7 +359,7 @@ class QueryHelper:
                 if str(s.cidr_block).startswith('all-') and str(s.cidr_block).
                 endswith('-services-in-oracle-services-network')
             ]
-            if len(services) > 0:
+            if services:
                 # Create service gateway for regional services.
                 create_sg_response = net_client.create_service_gateway(
                     create_service_gateway_details=oci_adaptor.oci.core.models.

sky/provision/vsphere/common/vim_utils.py

@@ -56,7 +56,7 @@ def get_hosts_by_cluster_names(content, vcenter_name, cluster_name_dicts=None):
             'name': cluster.name
         } for cluster in cluster_view.view]
         cluster_view.Destroy()
-        if len(cluster_name_dicts) == 0:
+        if not cluster_name_dicts:
             logger.warning(f'vCenter \'{vcenter_name}\' has no clusters')
 
     # Retrieve all cluster names from the cluster_name_dicts

sky/provision/vsphere/instance.py

@@ -162,7 +162,7 @@ def _create_instances(
     if not gpu_instance:
         # Find an image for CPU
         images_df = images_df[images_df['GpuTags'] == '\'[]\'']
-        if len(images_df) == 0:
+        if not images_df:
             logger.error(
                 f'Can not find an image for instance type: {instance_type}.')
             raise Exception(
@@ -185,7 +185,7 @@ def _create_instances(
         image_instance_mapping_df = image_instance_mapping_df[
             image_instance_mapping_df['InstanceType'] == instance_type]
 
-        if len(image_instance_mapping_df) == 0:
+        if not image_instance_mapping_df:
             raise Exception(f"""There is no image can match instance type named
                 {instance_type}
                 If you are using CPU-only instance, assign an image with tag
@@ -218,10 +218,9 @@ def _create_instances(
     hosts_df = hosts_df[(hosts_df['AvailableCPUs'] /
                          hosts_df['cpuMhz']) >= cpus_needed]
     hosts_df = hosts_df[hosts_df['AvailableMemory(MB)'] >= memory_needed]
-    assert len(hosts_df) > 0, (
-        f'There is no host available to create the instance '
-        f'{vms_item["InstanceType"]}, at least {cpus_needed} '
-        f'cpus and {memory_needed}MB memory are required.')
+    assert hosts_df, (f'There is no host available to create the instance '
+                      f'{vms_item["InstanceType"]}, at least {cpus_needed} '
+                      f'cpus and {memory_needed}MB memory are required.')
 
     # Sort the hosts df by AvailableCPUs to get the compatible host with the
     # least resource
@@ -365,7 +364,7 @@ def _choose_vsphere_cluster_name(config: common.ProvisionConfig, region: str,
     skypilot framework-optimized availability_zones"""
     vsphere_cluster_name = None
     vsphere_cluster_name_str = config.provider_config['availability_zone']
-    if len(vc_object.clusters) > 0:
+    if vc_object.clusters:
         for optimized_cluster_name in vsphere_cluster_name_str.split(','):
             if optimized_cluster_name in [
                     item['name'] for item in vc_object.clusters

sky/provision/vsphere/vsphere_utils.py

@@ -257,7 +257,7 @@ class VsphereClient:
         # hard code here. should support configure later.
         profile_name = 'skypilot_policy'
         storage_profile_id = None
-        if len(profile_ids) > 0:
+        if profile_ids:
             profiles = pm.PbmRetrieveContent(profileIds=profile_ids)
             for profile in profiles:
                 if profile_name in profile.name:

sky/resources.py

@@ -661,7 +661,7 @@ class Resources:
                     continue
                 valid_clouds.append(cloud)
 
-            if len(valid_clouds) == 0:
+            if not valid_clouds:
                 if len(enabled_clouds) == 1:
                     cloud_str = f'for cloud {enabled_clouds[0]}'
                 else:
@@ -773,7 +773,7 @@ class Resources:
             for cloud in enabled_clouds:
                 if cloud.instance_type_exists(self._instance_type):
                     valid_clouds.append(cloud)
-            if len(valid_clouds) == 0:
+            if not valid_clouds:
                 if len(enabled_clouds) == 1:
                     cloud_str = f'for cloud {enabled_clouds[0]}'
                 else:
@@ -1008,7 +1008,7 @@ class Resources:
                         f'Label rejected due to {cloud}: {err_msg}'
                     ])
                     break
-        if len(invalid_table.rows) > 0:
+        if invalid_table.rows:
             with ux_utils.print_exception_no_traceback():
                 raise ValueError(
                     'The following labels are invalid:'
@@ -1283,7 +1283,7 @@ class Resources:
             _cluster_config_overrides=override.pop(
                 '_cluster_config_overrides', self._cluster_config_overrides),
         )
-        assert len(override) == 0
+        assert not override
         return resources
 
     def valid_on_region_zones(self, region: str, zones: List[str]) -> bool:

sky/serve/autoscalers.py

@@ -320,8 +320,8 @@ class RequestRateAutoscaler(Autoscaler):
         """Select outdated replicas to scale down."""
 
         if self.update_mode == serve_utils.UpdateMode.ROLLING:
-            latest_ready_replicas = []
-            old_nonterminal_replicas = []
+            latest_ready_replicas: List['replica_managers.ReplicaInfo'] = []
+            old_nonterminal_replicas: List['replica_managers.ReplicaInfo'] = []
             for info in replica_infos:
                 if info.version == self.latest_version:
                     if info.is_ready:

sky/serve/core.py

@@ -360,7 +360,7 @@ def update(
         raise RuntimeError(e.error_msg) from e
 
     service_statuses = serve_utils.load_service_status(serve_status_payload)
-    if len(service_statuses) == 0:
+    if not service_statuses:
         with ux_utils.print_exception_no_traceback():
             raise RuntimeError(f'Cannot find service {service_name!r}.'
                                f'To spin up a service, use {ux_utils.BOLD}'
@@ -491,9 +491,9 @@ def down(
         stopped_message='All services should have terminated.')
 
     service_names_str = ','.join(service_names)
-    if sum([len(service_names) > 0, all]) != 1:
-        argument_str = f'service_names={service_names_str}' if len(
-            service_names) > 0 else ''
+    if sum([bool(service_names), all]) != 1:
+        argument_str = (f'service_names={service_names_str}'
+                        if service_names else '')
         argument_str += ' all' if all else ''
         raise ValueError('Can only specify one of service_names or all. '
                          f'Provided {argument_str!r}.')

sky/serve/replica_managers.py

@@ -172,7 +172,7 @@ def _get_resources_ports(task_yaml: str) -> str:
     """Get the resources ports used by the task."""
     task = sky.Task.from_yaml(task_yaml)
     # Already checked all ports are the same in sky.serve.core.up
-    assert len(task.resources) >= 1, task
+    assert task.resources, task
     task_resources: 'resources.Resources' = list(task.resources)[0]
     # Already checked the resources have and only have one port
     # before upload the task yaml.

sky/serve/serve_state.py

@@ -226,7 +226,7 @@ class ServiceStatus(enum.Enum):
                for status in ReplicaStatus.failed_statuses()) > 0:
             return cls.FAILED
         # When min_replicas = 0, there is no (provisioning) replica.
-        if len(replica_statuses) == 0:
+        if not replica_statuses:
             return cls.NO_REPLICA
         return cls.REPLICA_INIT
 

sky/serve/serve_utils.py

@@ -110,7 +110,7 @@ ValueType = TypeVar('ValueType')
 class ThreadSafeDict(Generic[KeyType, ValueType]):
     """A thread-safe dict."""
 
-    def __init__(self, *args, **kwargs) -> None:
+    def __init__(self, *args: Any, **kwargs: Any) -> None:
         self._dict: Dict[KeyType, ValueType] = dict(*args, **kwargs)
         self._lock = threading.Lock()
 
@@ -383,7 +383,7 @@ def _get_service_status(
 
 
 def get_service_status_encoded(service_names: Optional[List[str]]) -> str:
-    service_statuses = []
+    service_statuses: List[Dict[str, str]] = []
     if service_names is None:
         # Get all service names
         service_names = serve_state.get_glob_service_names(None)
@@ -400,7 +400,7 @@ def get_service_status_encoded(service_names: Optional[List[str]]) -> str:
 
 def load_service_status(payload: str) -> List[Dict[str, Any]]:
     service_statuses_encoded = common_utils.decode_payload(payload)
-    service_statuses = []
+    service_statuses: List[Dict[str, Any]] = []
     for service_status in service_statuses_encoded:
         service_statuses.append({
             k: pickle.loads(base64.b64decode(v))
@@ -432,7 +432,7 @@ def _terminate_failed_services(
         A message indicating potential resource leak (if any). If no
         resource leak is detected, return None.
     """
-    remaining_replica_clusters = []
+    remaining_replica_clusters: List[str] = []
     # The controller should have already attempted to terminate those
     # replicas, so we don't need to try again here.
     for replica_info in serve_state.get_replica_infos(service_name):
@@ -459,8 +459,8 @@ def _terminate_failed_services(
 
 def terminate_services(service_names: Optional[List[str]], purge: bool) -> str:
     service_names = serve_state.get_glob_service_names(service_names)
-    terminated_service_names = []
-    messages = []
+    terminated_service_names: List[str] = []
+    messages: List[str] = []
     for service_name in service_names:
         service_status = _get_service_status(service_name,
                                              with_replica_info=False)
@@ -506,7 +506,7 @@ def terminate_services(service_names: Optional[List[str]], purge: bool) -> str:
                     f.write(UserSignal.TERMINATE.value)
                     f.flush()
         terminated_service_names.append(f'{service_name!r}')
-    if len(terminated_service_names) == 0:
+    if not terminated_service_names:
         messages.append('No service to terminate.')
     else:
         identity_str = f'Service {terminated_service_names[0]} is'
@@ -784,9 +784,9 @@ def get_endpoint(service_record: Dict[str, Any]) -> str:
     # Don't use backend_utils.is_controller_accessible since it is too slow.
     handle = global_user_state.get_handle_from_cluster_name(
         SKY_SERVE_CONTROLLER_NAME)
-    assert isinstance(handle, backends.CloudVmRayResourceHandle)
     if handle is None:
         return '-'
+    assert isinstance(handle, backends.CloudVmRayResourceHandle)
     load_balancer_port = service_record['load_balancer_port']
     if load_balancer_port is None:
         return '-'
@@ -816,7 +816,7 @@ def format_service_table(service_records: List[Dict[str, Any]],
         ])
     service_table = log_utils.create_table(service_columns)
 
-    replica_infos = []
+    replica_infos: List[Dict[str, Any]] = []
     for record in service_records:
         for replica in record['replica_info']:
             replica['service_name'] = record['name']
@@ -888,7 +888,8 @@ def _format_replica_table(replica_records: List[Dict[str, Any]],
         region = '-'
         zone = '-'
 
-        replica_handle: 'backends.CloudVmRayResourceHandle' = record['handle']
+        replica_handle: Optional['backends.CloudVmRayResourceHandle'] = record[
+            'handle']
         if replica_handle is not None:
             resources_str = resources_utils.get_readable_resources_repr(
                 replica_handle, simplify=not show_all)

sky/serve/service_spec.py

@@ -2,7 +2,7 @@
 import json
 import os
 import textwrap
-from typing import Any, Dict, Optional
+from typing import Any, Dict, List, Optional
 
 import yaml
 
@@ -186,9 +186,12 @@ class SkyServiceSpec:
         return SkyServiceSpec.from_yaml_config(config['service'])
 
     def to_yaml_config(self) -> Dict[str, Any]:
-        config = dict()
+        config: Dict[str, Any] = {}
 
-        def add_if_not_none(section, key, value, no_empty: bool = False):
+        def add_if_not_none(section: str,
+                            key: Optional[str],
+                            value: Any,
+                            no_empty: bool = False):
             if no_empty and not value:
                 return
             if value is not None:
@@ -231,8 +234,8 @@ class SkyServiceSpec:
                    ' with custom headers')
         return f'{method}{headers}'
 
-    def spot_policy_str(self):
-        policy_strs = []
+    def spot_policy_str(self) -> str:
+        policy_strs: List[str] = []
         if (self.dynamic_ondemand_fallback is not None and
                 self.dynamic_ondemand_fallback):
             policy_strs.append('Dynamic on-demand fallback')

sky/skylet/job_lib.py

@@ -586,7 +586,7 @@ def update_job_status(job_ids: List[int],
     This function should only be run on the remote instance with ray>=2.4.0.
     """
     echo = logger.info if not silent else logger.debug
-    if len(job_ids) == 0:
+    if not job_ids:
         return []
 
     statuses = []

sky/skylet/providers/ibm/node_provider.py

@@ -377,7 +377,7 @@ class IBMVPCNodeProvider(NodeProvider):
                 node["id"], nic_id
             ).get_result()
             floating_ips = res["floating_ips"]
-            if len(floating_ips) == 0:
+            if not floating_ips:
                 # not adding a node that's yet/failed to
                 # to get a floating ip provisioned
                 continue
@@ -485,7 +485,7 @@ class IBMVPCNodeProvider(NodeProvider):
         """Returns instance (node) information matching the specified name"""
 
         instances_data = self.ibm_vpc_client.list_instances(name=name).get_result()
-        if len(instances_data["instances"]) > 0:
+        if instances_data["instances"]:
             return instances_data["instances"][0]
         return None
 

sky/skylet/providers/scp/config.py

@@ -107,7 +107,7 @@ class ZoneConfig:
                 for item in subnet_contents
                 if item['subnetState'] == 'ACTIVE' and item["vpcId"] == vpc
             ]
-            if len(subnet_list) > 0:
+            if subnet_list:
                 vpc_subnets[vpc] = subnet_list
 
         return vpc_subnets

sky/skylet/providers/scp/node_provider.py

@@ -259,7 +259,7 @@ class SCPNodeProvider(NodeProvider):
                     for sg in sg_contents
                     if sg["securityGroupId"] == sg_id
                 ]
-                if len(sg) != 0 and sg[0] == "ACTIVE":
+                if sg and sg[0] == "ACTIVE":
                     break
                 time.sleep(5)
 
@@ -282,16 +282,16 @@ class SCPNodeProvider(NodeProvider):
                 for sg in sg_contents
                 if sg["securityGroupId"] == sg_id
             ]
-            if len(sg) == 0:
+            if not sg:
                 break
 
     def _refresh_security_group(self, vms):
-        if len(vms) > 0:
+        if vms:
             return
         # remove security group if vm does not exist
         keys = self.metadata.keys()
         security_group_id = self.metadata[
-            keys[0]]['creation']['securityGroupId'] if len(keys) > 0 else None
+            keys[0]]['creation']['securityGroupId'] if keys else None
         if security_group_id:
             try:
                 self._del_security_group(security_group_id)
@@ -308,7 +308,7 @@ class SCPNodeProvider(NodeProvider):
                 for vm in vm_contents
                 if vm["virtualServerId"] == vm_id
             ]
-            if len(vms) == 0:
+            if not vms:
                 break
 
     def _del_firwall_rules(self, firewall_id, rule_ids):
@@ -391,7 +391,7 @@ class SCPNodeProvider(NodeProvider):
             return None, None, None, None
 
     def _undo_funcs(self, undo_func_list):
-        while len(undo_func_list) > 0:
+        while undo_func_list:
             func = undo_func_list.pop()
             func()
 
@@ -468,7 +468,7 @@ class SCPNodeProvider(NodeProvider):
 
             zone_config = ZoneConfig(self.scp_client, node_config)
             vpc_subnets = zone_config.get_vcp_subnets()
-            if (len(vpc_subnets) == 0):
+            if not vpc_subnets:
                 raise SCPError("This region/zone does not have available VPCs.")
 
             instance_config = zone_config.bootstrap_instance_config(node_config)

sky/task.py

@@ -956,7 +956,7 @@ class Task:
         }``.
         """
         for storage in self.storage_mounts.values():
-            if len(storage.stores) == 0:
+            if not storage.stores:
                 store_type, store_region = self._get_preferred_store()
                 self.storage_plans[storage] = store_type
                 storage.add_store(store_type, store_region)

sky/utils/accelerator_registry.py

@@ -106,7 +106,7 @@ def canonicalize_accelerator_name(accelerator: str,
         return names[0]
 
     # Do not print an error message here. Optimizer will handle it.
-    if len(names) == 0:
+    if not names:
         return accelerator
 
     # Currently unreachable.

sky/utils/common_utils.py

@@ -633,7 +633,7 @@ def get_cleaned_username(username: str = '') -> str:
     return username
 
 
-def fill_template(template_name: str, variables: Dict,
+def fill_template(template_name: str, variables: Dict[str, Any],
                   output_path: str) -> None:
     """Create a file from a Jinja template and return the filename."""
     assert template_name.endswith('.j2'), template_name

sky/utils/dag_utils.py

@@ -89,7 +89,7 @@ def load_chain_dag_from_yaml(
     elif len(configs) == 1:
         dag_name = configs[0].get('name')
 
-    if len(configs) == 0:
+    if not configs:
         # YAML has only `name: xxx`. Still instantiate a task.
         configs = [{'name': dag_name}]
 

sky/utils/kubernetes/gpu_labeler.py

@@ -139,7 +139,7 @@ def label():
             # Create the job for this node`
             batch_v1.create_namespaced_job(namespace, job_manifest)
             print(f'Created GPU labeler job for node {node_name}')
-    if len(gpu_nodes) == 0:
+    if not gpu_nodes:
         print('No GPU nodes found in the cluster. If you have GPU nodes, '
               'please ensure that they have the label '
               f'`{kubernetes_utils.get_gpu_resource_key()}: <number of GPUs>`')

sky/utils/kubernetes/ssh_jump_lifecycle_manager.py

@@ -126,7 +126,7 @@ def manage_lifecycle():
                          f'error: {e}\n')
         raise
 
-    if len(ret.items) == 0:
+    if not ret.items:
         sys.stdout.write(
             f'[Lifecycle] Did not find pods with label '
             f'"{label_selector}" in namespace {current_namespace}\n')

{skypilot_nightly-1.0.0.dev20241222.dist-info → skypilot_nightly-1.0.0.dev20241223.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: skypilot-nightly
-Version: 1.0.0.dev20241222
+Version: 1.0.0.dev20241223
 Summary: SkyPilot: An intercloud broker for the clouds
 Author: SkyPilot Team
 License: Apache 2.0