shinestacker 1.2.0__py3-none-any.whl → 1.3.0__py3-none-any.whl

shinestacker/algorithms/align_parallel.py

@@ -0,0 +1,296 @@
+# pylint: disable=C0114, C0115, C0116, W0718, R0912, R0915, E1101, R0914, R0911, E0606, R0801, R0902
+import gc
+import copy
+import math
+import traceback
+import threading
+import logging
+from concurrent.futures import ThreadPoolExecutor, as_completed
+import numpy as np
+import cv2
+from ..config.constants import constants
+from .. core.exceptions import InvalidOptionError, RunStopException
+from .. core.colors import color_str
+from .. core.core_utils import make_chunks
+from .utils import read_img, img_subsample, img_bw
+from .align import (AlignFramesBase, detect_and_compute_matches, find_transform,
+                    check_transform, _cv2_border_mode_map, rescale_trasnsform)
+
+
+def compose_transforms(t1, t2, transform_type):
+    t1 = t1.astype(np.float64)
+    t2 = t2.astype(np.float64)
+    if transform_type == constants.ALIGN_RIGID:
+        t1_homo = np.vstack([t1, [0, 0, 1]])
+        t2_homo = np.vstack([t2, [0, 0, 1]])
+        result_homo = t2_homo @ t1_homo
+        return result_homo[:2, :]
+    return t2 @ t1
+
+
+class AlignFramesParallel(AlignFramesBase):
+    def __init__(self, enabled=True, feature_config=None, matching_config=None,
+                 alignment_config=None, **kwargs):
+        super().__init__(enabled=True, feature_config=None, matching_config=None,
+                         alignment_config=None, **kwargs)
+        self.max_threads = kwargs.get('max_threads', constants.DEFAULT_ALIGN_MAX_THREADS)
+        self.chunk_submit = kwargs.get('chunk_submit', constants.DEFAULT_ALIGN_CHUNK_SUBMIT)
+        self.bw_matching = kwargs.get('bw_matching', constants.DEFAULT_ALIGN_BW_MATCHING)
+        self._img_cache = None
+        self._img_locks = None
+        self._cache_locks = None
+        self._target_indices = None
+        self._transforms = None
+        self._cumulative_transforms = None
+        self.step_counter = 0
+
+    def cache_img(self, idx):
+        with self._cache_locks[idx]:
+            self._img_locks[idx] += 1
+            if self._img_cache[idx] is None:
+                img = read_img(self.process.input_filepath(idx))
+                if self.bw_matching:
+                    img = img_bw(img)
+                self._img_cache[idx] = img
+            return self._img_cache[idx]
+
+    def submit_threads(self, idxs, imgs):
+        with ThreadPoolExecutor(max_workers=len(imgs)) as executor:
+            future_to_index = {}
+            for idx in idxs:
+                self.print_message(
+                    f"submit alignment matches, {self.image_str(idx)}")
+                future = executor.submit(self.extract_features, idx)
+                future_to_index[future] = idx
+            for future in as_completed(future_to_index):
+                idx = future_to_index[future]
+                try:
+                    info_messages, warning_messages = future.result()
+                    message = f"{self.image_str(idx)}: " \
+                              f"matches found: {self._n_good_matches[idx]}"
+                    if len(info_messages) > 0:
+                        message += ", " + ", ".join(info_messages)
+                    color = constants.LOG_COLOR_LEVEL_3
+                    level = logging.INFO
+                    if len(warning_messages) > 0:
+                        message += ", " + color_str(", ".join(warning_messages), 'yellow')
+                        color = constants.LOG_COLOR_WARNING
+                        level = logging.WARNING
+                    self.print_message(message, color=color, level=level)
+                    self.step_counter += 1
+                    self.process.after_step(self.step_counter)
+                    self.process.check_running()
+                except RunStopException as e:
+                    raise e
+                except Exception as e:
+                    traceback.print_tb(e.__traceback__)
+                    self.print_message(
+                        f"failed processing {self.image_str(idx)}: {str(e)}")
+            cached_images = 0
+            for i in range(self.process.num_input_filepaths()):
+                if self._img_locks[i] >= 2:
+                    self._img_cache[i] = None
+                    self._img_locks[i] = 0
+                elif self._img_cache[i] is not None:
+                    cached_images += 1
+            # self.print_message(f"cached images: {cached_images}")
+        gc.collect()
+
+    def begin(self, process):
+        super().begin(process)
+        n_frames = self.process.num_input_filepaths()
+        self.process.callback(constants.CALLBACK_STEP_COUNTS,
+                              self.process.id, self.process.name, 2 * n_frames)
+        self.print_message(f"preprocess {n_frames} images in parallel, cores: {self.max_threads}")
+        input_filepaths = self.process.input_filepaths()
+        self._img_cache = [None] * n_frames
+        self._img_locks = [0] * n_frames
+        self._cache_locks = [threading.Lock() for _ in range(n_frames)]
+        self._target_indices = [None] * n_frames
+        self._n_good_matches = [0] * n_frames
+        self._transforms = [None] * n_frames
+        self._cumulative_transforms = [None] * n_frames
+        max_chunck_size = self.max_threads
+        ref_idx = self.process.ref_idx
+        self.print_message(f"reference: {self.image_str(ref_idx)}")
+        sub_indices = list(range(n_frames))
+        sub_indices.remove(ref_idx)
+        sub_img_filepaths = copy.deepcopy(input_filepaths)
+        sub_img_filepaths.remove(input_filepaths[ref_idx])
+        self.step_counter = 0
+        if self.chunk_submit:
+            img_chunks = make_chunks(sub_img_filepaths, max_chunck_size)
+            idx_chunks = make_chunks(sub_indices, max_chunck_size)
+            for idxs, imgs in zip(idx_chunks, img_chunks):
+                self.submit_threads(idxs, imgs)
+        else:
+            self.submit_threads(sub_indices, sub_img_filepaths)
+        for i in range(n_frames):
+            if self._img_cache[i] is not None:
+                self._img_cache[i] = None
+        gc.collect()
+        self.print_message("combining transformations")
+        transform_type = self.alignment_config['transform']
+        if transform_type == constants.ALIGN_RIGID:
+            identity = np.array([[1.0, 0.0, 0.0],
+                                 [0.0, 1.0, 0.0]], dtype=np.float64)
+        else:
+            identity = np.eye(3, dtype=np.float64)
+        self._cumulative_transforms[ref_idx] = identity
+        frames_to_process = []
+        for i in range(n_frames):
+            if i != ref_idx:
+                frames_to_process.append((i, abs(i - ref_idx)))
+        frames_to_process.sort(key=lambda x: x[1])
+        for i, _ in frames_to_process:
+            target_idx = self._target_indices[i]
+            if target_idx is not None and self._cumulative_transforms[target_idx] is not None:
+                self._cumulative_transforms[i] = compose_transforms(
+                    self._transforms[i], self._cumulative_transforms[target_idx], transform_type)
+            else:
+                self._cumulative_transforms[i] = None
+                self.print_message(
+                    f"warning: no cumulative transform for {self.image_str(i)}",
+                    color=constants.LOG_COLOR_WARNING, level=logging.WARNING)
+        missing_transforms = 0
+        for i in range(n_frames):
+            if self._cumulative_transforms[i] is not None:
+                self._cumulative_transforms[i] = self._cumulative_transforms[i].astype(np.float32)
+            else:
+                missing_transforms += 1
+        msg = "feature extaction completed"
+        if missing_transforms > 0:
+            msg += ", " + color_str(f"images not matched: {missing_transforms}",
+                                    constants.LOG_COLOR_WARNING)
+        self.print_message(msg)
+        self.process.add_begin_steps(n_frames)
+
+    def extract_features(self, idx, delta=1):
+        ref_idx = self.process.ref_idx
+        pass_ref_err_msg = "cannot find path to reference frame"
+        if idx < ref_idx:
+            target_idx = idx + delta
+            if target_idx > ref_idx:
+                self._target_indices[idx] = None
+                self._transforms[idx] = None
+                return [], [pass_ref_err_msg]
+        elif idx > ref_idx:
+            target_idx = idx - delta
+            if target_idx < ref_idx:
+                self._target_indices[idx] = None
+                self._transforms[idx] = None
+                return [], [pass_ref_err_msg]
+        else:
+            self._target_indices[idx] = None
+            self._transforms[idx] = None
+            return [], []
+        info_messages = []
+        warning_messages = []
+        img_0 = self.cache_img(idx)
+        img_ref = self.cache_img(target_idx)
+        h0, w0 = img_0.shape[:2]
+        subsample = self.alignment_config['subsample']
+        if subsample == 0:
+            img_res = (float(h0) / constants.ONE_KILO) * (float(w0) / constants.ONE_KILO)
+            target_res = constants.DEFAULT_ALIGN_RES_TARGET_MPX
+            subsample = int(1 + math.floor(img_res / target_res))
+        fast_subsampling = self.alignment_config['fast_subsampling']
+        min_good_matches = self.alignment_config['min_good_matches']
+        while True:
+            if subsample > 1:
+                img_0_sub = img_subsample(img_0, subsample, fast_subsampling)
+                img_ref_sub = img_subsample(img_ref, subsample, fast_subsampling)
+            else:
+                img_0_sub, img_ref_sub = img_0, img_ref
+            kp_0, kp_ref, good_matches = detect_and_compute_matches(
+                img_ref_sub, img_0_sub, self.feature_config, self.matching_config)
+            n_good_matches = len(good_matches)
+            if n_good_matches > min_good_matches or subsample == 1:
+                break
+            subsample = 1
+            warning_messages.append("too few matches, no subsampling applied")
+        self._n_good_matches[idx] = n_good_matches
+        m = None
+        min_matches = 4 if self.alignment_config['transform'] == constants.ALIGN_HOMOGRAPHY else 3
+        if n_good_matches < min_matches:
+            self.print_message(
+                f"warning: only {n_good_matches} found for "
+                f"{self.image_str(idx)}, trying next frame",
+                color=constants.LOG_COLOR_WARNING, level=logging.WARNING)
+            self._target_indices[idx] = None
+            self._transforms[idx] = None
+            return self.extract_features(idx, delta + 1)
+        transform = self.alignment_config['transform']
+        src_pts = np.float32([kp_0[m.queryIdx].pt for m in good_matches]).reshape(-1, 1, 2)
+        dst_pts = np.float32([kp_ref[m.trainIdx].pt for m in good_matches]).reshape(-1, 1, 2)
+        m, _msk = find_transform(src_pts, dst_pts, transform, self.alignment_config['align_method'],
+                                 *(self.alignment_config[k]
+                                   for k in ['rans_threshold', 'max_iters',
+                                             'align_confidence', 'refine_iters']))
+        h_sub, w_sub = img_0_sub.shape[:2]
+        if subsample > 1:
+            m = rescale_trasnsform(m, w0, h0, w_sub, h_sub, subsample, transform)
+            if m is None:
+                warning_messages.append(f"invalid option {transform}")
+                self._target_indices[idx] = None
+                self._transforms[idx] = None
+                return info_messages, warning_messages
+        transform_type = self.alignment_config['transform']
+        thresholds = self.get_transform_thresholds()
+        is_valid, reason = check_transform(m, img_0, transform_type, *thresholds)
+        if not is_valid:
+            self.print_message(
+                f"warning: invalid transformation for {self.image_str(idx)}: {reason}",
+                level=logging.WARNING)
+            if self.alignment_config['abort_abnormal']:
+                raise RuntimeError("invalid transformation: {reason}")
+            warning_messages.append(f"invalid transformation found: {reason}")
+            self._target_indices[idx] = None
+            self._transforms[idx] = None
+            return info_messages, warning_messages
+        self._transforms[idx] = m
+        self._target_indices[idx] = target_idx
+        return info_messages, warning_messages
+
+    def align_images(self, idx, img_ref, img_0):
+        m = self._cumulative_transforms[idx]
+        if m is None:
+            self.print_message(
+                f"no transformation for {self.image_str(idx)}, skipping alignment",
+                color=constants.LOG_COLOR_WARNING, level=logging.WARNING)
+            return img_0
+        transform_type = self.alignment_config['transform']
+        if transform_type == constants.ALIGN_RIGID and m.shape != (2, 3):
+            self.print_message(f"invalid matrix shape for rigid transform: {m.shape}")
+            return img_0
+        if transform_type == constants.ALIGN_HOMOGRAPHY and m.shape != (3, 3):
+            self.print_message(f"invalid matrix shape for homography: {m.shape}")
+            return img_0
+        self.print_message(f'{self.image_str(idx)}: apply image alignment')
+        try:
+            cv2_border_mode = _cv2_border_mode_map[self.alignment_config['border_mode']]
+        except KeyError as e:
+            raise InvalidOptionError("border_mode", self.alignment_config['border_mode']) from e
+        img_mask = np.ones_like(img_0, dtype=np.uint8)
+        h_ref, w_ref = img_ref.shape[:2]
+        if self.alignment_config['transform'] == constants.ALIGN_HOMOGRAPHY:
+            img_warp = cv2.warpPerspective(
+                img_0, m, (w_ref, h_ref),
+                borderMode=cv2_border_mode, borderValue=self.alignment_config['border_value'])
+            if self.alignment_config['border_mode'] == constants.BORDER_REPLICATE_BLUR:
+                mask = cv2.warpPerspective(img_mask, m, (w_ref, h_ref),
+                                           borderMode=cv2.BORDER_CONSTANT, borderValue=0)
+        elif self.alignment_config['transform'] == constants.ALIGN_RIGID:
+            img_warp = cv2.warpAffine(
+                img_0, m, (w_ref, h_ref),
+                borderMode=cv2_border_mode, borderValue=self.alignment_config['border_value'])
+            if self.alignment_config['border_mode'] == constants.BORDER_REPLICATE_BLUR:
+                mask = cv2.warpAffine(img_mask, m, (w_ref, h_ref),
+                                      borderMode=cv2.BORDER_CONSTANT, borderValue=0)
+        if self.alignment_config['border_mode'] == constants.BORDER_REPLICATE_BLUR:
+            self.print_message(f'{self.image_str(idx)}: blur borders')
+            mask = cv2.cvtColor(mask, cv2.COLOR_BGR2GRAY)
+            blurred_warp = cv2.GaussianBlur(
+                img_warp, (21, 21), sigmaX=self.alignment_config['border_blur'])
+            img_warp[mask == 0] = blurred_warp[mask == 0]
+        return img_warp

shinestacker/algorithms/balance.py

@@ -24,7 +24,6 @@ class BaseHistogrammer:
         self.plot_summary = plot_summary
         self.process = process
         self.corrections = None
-        self.figsize = (10, 5)
 
     def begin(self, size):
         self.corrections = np.ones((size, self.channels))
@@ -70,7 +69,7 @@ class LumiHistogrammer(BaseHistogrammer):
         self.colors = ("r", "g", "b")
 
     def generate_frame_plot(self, idx, hist, chans, calc_hist_func):
-        _fig, axs = plt.subplots(1, 2, figsize=self.figsize, sharey=True)
+        _fig, axs = plt.subplots(1, 2, figsize=constants.PLT_FIG_SIZE, sharey=True)
         self.histo_plot(axs[0], hist, "pixel luminosity", 'black')
         for (chan, color) in zip(chans, self.colors):
             hist_col = calc_hist_func(chan)
@@ -79,7 +78,7 @@ class LumiHistogrammer(BaseHistogrammer):
         self.save_plot(idx)
 
     def generate_summary_plot(self, ref_idx):
-        plt.figure(figsize=self.figsize)
+        plt.figure(figsize=constants.PLT_FIG_SIZE)
         x = np.arange(0, len(self.corrections), dtype=int)
         y = self.corrections
         plt.plot([ref_idx, ref_idx], [0, np.max(y)], color='cornflowerblue',
@@ -101,14 +100,14 @@ class RGBHistogrammer(BaseHistogrammer):
         self.colors = ("r", "g", "b")
 
     def generate_frame_plot(self, idx, hists):
-        _fig, axs = plt.subplots(1, 3, figsize=self.figsize, sharey=True)
+        _fig, axs = plt.subplots(1, 3, figsize=constants.PLT_FIG_SIZE, sharey=True)
         for c in [2, 1, 0]:
             self.histo_plot(axs[c], hists[c], self.colors[c] + " luminosity", self.colors[c])
         plt.xlim(0, self.max_pixel_value)
         self.save_plot(idx)
 
     def generate_summary_plot(self, ref_idx):
-        plt.figure(figsize=self.figsize)
+        plt.figure(figsize=constants.PLT_FIG_SIZE)
         x = np.arange(0, len(self.corrections), dtype=int)
         y = self.corrections
         max_val = np.max(y) if np.any(y) else 1.0
@@ -134,14 +133,14 @@ class Ch1Histogrammer(BaseHistogrammer):
         self.colors = colors
 
     def generate_frame_plot(self, idx, hists):
-        _fig, axs = plt.subplots(1, 3, figsize=self.figsize, sharey=True)
+        _fig, axs = plt.subplots(1, 3, figsize=constants.PLT_FIG_SIZE, sharey=True)
         for c in range(3):
             self.histo_plot(axs[c], hists[c], self.labels[c], self.colors[c])
         plt.xlim(0, self.max_pixel_value)
         self.save_plot(idx)
 
     def generate_summary_plot(self, ref_idx):
-        plt.figure(figsize=self.figsize)
+        plt.figure(figsize=constants.PLT_FIG_SIZE)
         x = np.arange(0, len(self.corrections), dtype=int)
         y = self.corrections
         max_val = np.max(y) if np.any(y) else 1.0
@@ -165,14 +164,14 @@ class Ch2Histogrammer(BaseHistogrammer):
         self.colors = colors
 
     def generate_frame_plot(self, idx, hists):
-        _fig, axs = plt.subplots(1, 3, figsize=self.figsize, sharey=True)
+        _fig, axs = plt.subplots(1, 3, figsize=constants.PLT_FIG_SIZE, sharey=True)
         for c in range(3):
             self.histo_plot(axs[c], hists[c], self.labels[c], self.colors[c])
         plt.xlim(0, self.max_pixel_value)
         self.save_plot(idx)
 
     def generate_summary_plot(self, ref_idx):
-        plt.figure(figsize=self.figsize)
+        plt.figure(figsize=constants.PLT_FIG_SIZE)
         x = np.arange(0, len(self.corrections), dtype=int)
         y = self.corrections
         max_val = np.max(y) if np.any(y) else 1.0
@@ -591,9 +590,9 @@ class BalanceFrames(SubAction):
     def begin(self, process):
         self.process = process
         self.correction.process = process
-        img = read_img(self.process.input_full_path + "/" + self.process.filenames[process.ref_idx])
+        img = read_img(self.process.input_filepath(process.ref_idx))
         self.shape = img.shape
-        self.correction.begin(img, self.process.counts, process.ref_idx)
+        self.correction.begin(img, self.process.total_action_counts, process.ref_idx)
 
     def end(self):
         self.process.print_message(' ' * 60)
@@ -603,13 +602,15 @@ class BalanceFrames(SubAction):
             img = np.zeros(shape)
             mask_radius = int(min(*shape) * self.mask_size / 2)
             cv2.circle(img, (shape[1] // 2, shape[0] // 2), mask_radius, 255, -1)
-            plt.figure(figsize=(10, 5))
+            plt.figure(figsize=constants.PLT_FIG_SIZE)
             plt.title('Mask')
             plt.imshow(img, 'gray')
             self.correction.histogrammer.save_summary_plot("mask")
 
     def run_frame(self, idx, _ref_idx, image):
         if idx != self.process.ref_idx:
-            self.process.sub_message_r(color_str(': balance image', constants.LOG_COLOR_LEVEL_3))
+            self.process.print_message(
+                color_str(f'{self.process.idx_tot_str(idx)}: balance image',
+                          constants.LOG_COLOR_LEVEL_3))
         image = self.correction.apply_correction(idx, image)
         return image

shinestacker/algorithms/base_stack_algo.py

@@ -34,6 +34,13 @@ class BaseStackAlgo:
     def set_do_step_callback(self, enable):
         self.do_step_callback = enable
 
+    def idx_tot_str(self, idx):
+        return f"{idx + 1}/{len(self.filenames)}"
+
+    def image_str(self, idx):
+        return f"image: {self.idx_tot_str(idx)}, " \
+               f"{os.path.basename(self.filenames[idx])}"
+
     def init(self, filenames):
         self.filenames = filenames
         first_img_file = ''
@@ -61,11 +68,13 @@ class BaseStackAlgo:
         return img, metadata, updated
 
     def check_running(self, cleanup_callback=None):
-        if self.process.callback('check_running', self.process.id, self.process.name) is False:
+        if self.process.callback(constants.CALLBACK_CHECK_RUNNING,
+                                 self.process.id, self.process.name) is False:
             if cleanup_callback is not None:
                 cleanup_callback()
             raise RunStopException(self.name)
 
     def after_step(self, step):
         if self.do_step_callback:
-            self.process.callback('after_step', self.process.id, self.process.name, step)
+            self.process.callback(constants.CALLBACK_AFTER_STEP,
+                                  self.process.id, self.process.name, step)

shinestacker/algorithms/multilayer.py

@@ -12,9 +12,9 @@ from psdtags import (PsdBlendMode, PsdChannel, PsdChannelId, PsdClippingType, Ps
 from .. config.constants import constants
 from .. config.config import config
 from .. core.colors import color_str
-from .. core.framework import JobBase
+from .. core.framework import TaskBase
 from .utils import EXTENSIONS_TIF, EXTENSIONS_JPG, EXTENSIONS_PNG
-from .stack_framework import FrameMultiDirectory
+from .stack_framework import ImageSequenceManager
 from .exif import exif_extra_tags_for_tif, get_exif
 
 
@@ -159,10 +159,10 @@ def write_multilayer_tiff_from_images(image_dict, output_file, exif_path='', cal
                      compression=compression, metadata=None, **tiff_tags)
 
 
-class MultiLayer(JobBase, FrameMultiDirectory):
+class MultiLayer(TaskBase, ImageSequenceManager):
     def __init__(self, name, enabled=True, **kwargs):
-        FrameMultiDirectory.__init__(self, name, **kwargs)
-        JobBase.__init__(self, name, enabled)
+        ImageSequenceManager.__init__(self, name, **kwargs)
+        TaskBase.__init__(self, name, enabled)
         self.exif_path = kwargs.get('exif_path', '')
         self.reverse_order = kwargs.get(
             'reverse_order',
@@ -170,16 +170,16 @@ class MultiLayer(JobBase, FrameMultiDirectory):
         )
 
     def init(self, job):
-        FrameMultiDirectory.init(self, job)
+        ImageSequenceManager.init(self, job)
         if self.exif_path == '':
-            self.exif_path = job.paths[0]
+            self.exif_path = job.action_path(0)
         if self.exif_path != '':
             self.exif_path = self.working_path + "/" + self.exif_path
 
     def run_core(self):
-        if isinstance(self.input_full_path, str):
+        if isinstance(self.input_full_path(), str):
             paths = [self.input_path]
-        elif hasattr(self.input_full_path, "__len__"):
+        elif hasattr(self.input_full_path(), "__len__"):
             paths = self.input_path
         else:
             raise RuntimeError("input_path option must contain a path or an array of paths")
@@ -188,8 +188,8 @@ class MultiLayer(JobBase, FrameMultiDirectory):
                                          constants.LOG_COLOR_ALERT),
                                level=logging.WARNING)
             return
-        files = self.folder_filelist()
-        if len(files) == 0:
+        input_files = self.input_filepaths()
+        if len(input_files) == 0:
             self.print_message(
                 color_str(f"no input in {len(paths)} specified path" +
                           ('s' if len(paths) > 1 else '') + ": "
@@ -199,12 +199,11 @@ class MultiLayer(JobBase, FrameMultiDirectory):
             return
         self.print_message(color_str("merging frames in " + self.folder_list_str(),
                            constants.LOG_COLOR_LEVEL_2))
-        input_files = [f"{self.working_path}/{f}" for f in files]
         self.print_message(
-            color_str("frames: " + ", ".join([i.split("/")[-1] for i in files]),
+            color_str("frames: " + ", ".join([os.path.basename(i) for i in input_files]),
                       constants.LOG_COLOR_LEVEL_2))
         self.print_message(color_str("reading files", constants.LOG_COLOR_LEVEL_2))
-        filename = ".".join(files[0].split("/")[-1].split(".")[:-1])
+        filename = ".".join(os.path.basename(input_files[0]).split(".")[:-1])
         output_file = f"{self.working_path}/{self.output_path}/{filename}.tif"
         callbacks = {
             'exif_msg': lambda path: self.print_message(
@@ -218,4 +217,4 @@ class MultiLayer(JobBase, FrameMultiDirectory):
         write_multilayer_tiff(input_files, output_file, labels=None, exif_path=self.exif_path,
                               callbacks=callbacks)
         app = 'internal_retouch_app' if config.COMBINED_APP else f'{constants.RETOUCH_APP}'
-        self.callback('open_app', self.id, self.name, app, output_file)
+        self.callback(constants.CALLBACK_OPEN_APP, self.id, self.name, app, output_file)

shinestacker/algorithms/noise_detection.py

@@ -9,10 +9,10 @@ from .. config.config import config
 from .. config.constants import constants
 from .. core.colors import color_str
 from .. core.exceptions import ImageLoadError
-from .. core.framework import JobBase
+from .. core.framework import TaskBase
 from .. core.core_utils import make_tqdm_bar
 from .. core.exceptions import RunStopException, ShapeError
-from .stack_framework import FrameMultiDirectory, SubAction
+from .stack_framework import ImageSequenceManager, SubAction
 from .utils import read_img, save_plot, get_img_metadata, validate_image
 
 MAX_NOISY_PIXELS = 1000
@@ -45,10 +45,10 @@ def mean_image(file_paths, max_frames=-1, message_callback=None, progress_callba
     return None if mean_img is None else (mean_img / counter).astype(np.uint8)
 
 
-class NoiseDetection(JobBase, FrameMultiDirectory):
+class NoiseDetection(TaskBase, ImageSequenceManager):
     def __init__(self, name="noise-map", enabled=True, **kwargs):
-        FrameMultiDirectory.__init__(self, name, **kwargs)
-        JobBase.__init__(self, name, enabled)
+        ImageSequenceManager.__init__(self, name, **kwargs)
+        TaskBase.__init__(self, name, enabled)
         self.max_frames = kwargs.get('max_frames', constants.DEFAULT_NOISE_MAX_FRAMES)
         self.blur_size = kwargs.get('blur_size', constants.DEFAULT_BLUR_SIZE)
         self.file_name = kwargs.get('file_name', constants.DEFAULT_NOISE_MAP_FILENAME)
@@ -65,10 +65,10 @@ class NoiseDetection(JobBase, FrameMultiDirectory):
         return cv2.threshold(ch, th, 255, cv2.THRESH_BINARY)[1]
 
     def progress(self, i):
-        self.callback('after_step', self.id, self.name, i)
+        self.callback(constants.CALLBACK_AFTER_STEP, self.id, self.name, i)
         if not config.DISABLE_TQDM:
             self.tbar.update(1)
-            if self.callback('check_running', self.id, self.name) is False:
+            if self.callback(constants.CALLBACK_CHECK_RUNNING, self.id, self.name) is False:
                 raise RunStopException(self.name)
 
     def run_core(self):
@@ -76,21 +76,20 @@ class NoiseDetection(JobBase, FrameMultiDirectory):
             f"map noisy pixels from frames in {self.folder_list_str()}",
             constants.LOG_COLOR_LEVEL_2
         ))
-        files = self.folder_filelist()
-        in_paths = [self.working_path + "/" + f for f in files]
+        in_paths = self.input_filepaths()
         n_frames = min(len(in_paths), self.max_frames) if self.max_frames > 0 else len(in_paths)
-        self.callback('step_counts', self.id, self.name, n_frames)
+        self.callback(constants.CALLBACK_STEP_COUNTS, self.id, self.name, n_frames)
         if not config.DISABLE_TQDM:
             self.tbar = make_tqdm_bar(self.name, n_frames)
 
         def progress_callback(i):
             self.progress(i)
-            if self.callback('check_running', self.id, self.name) is False:
+            if self.callback(constants.CALLBACK_CHECK_RUNNING, self.id, self.name) is False:
                 raise RunStopException(self.name)
         mean_img = mean_image(
             file_paths=in_paths, max_frames=self.max_frames,
             message_callback=lambda path: self.print_message_r(
-                color_str(f"reading frame: {path.split('/')[-1]}", constants.LOG_COLOR_LEVEL_2)
+                color_str(f"reading frame: {os.path.basename(path)}", constants.LOG_COLOR_LEVEL_2)
             ),
             progress_callback=progress_callback)
         if not config.DISABLE_TQDM:
@@ -123,7 +122,7 @@ class NoiseDetection(JobBase, FrameMultiDirectory):
             plot_range[1] = max_th + 1
         th_range = np.arange(self.plot_range[0], self.plot_range[1] + 1)
         if self.plot_histograms:
-            plt.figure(figsize=(10, 5))
+            plt.figure(figsize=constants.PLT_FIG_SIZE)
             x = np.array(list(th_range))
             ys = [[np.count_nonzero(self.hot_map(ch, th) > 0)
                   for th in th_range] for ch in channels]
@@ -138,7 +137,7 @@ class NoiseDetection(JobBase, FrameMultiDirectory):
             plt.ylim(0)
             plot_path = f"{self.working_path}/{self.plot_path}/{self.name}-hot-pixels.pdf"
             save_plot(plot_path)
-            self.callback('save_plot', self.id, f"{self.name}: noise", plot_path)
+            self.callback(constants.CALLBACK_SAVE_PLOT, self.id, f"{self.name}: noise", plot_path)
             plt.close('all')
 
 

shinestacker/algorithms/pyramid.py

@@ -124,10 +124,9 @@ class PyramidBase(BaseStackAlgo):
 
     def focus_stack_validate(self, cleanup_callback=None):
         metadata = None
-        n = len(self.filenames)
         for i, img_path in enumerate(self.filenames):
-            self.print_message(f": validating file {img_path.split('/')[-1]}, {i + 1}/{n}")
-
+            self.print_message(
+                f": validating file {self.image_str(i)}")
             _img, metadata, updated = self.read_image_and_update_metadata(img_path, metadata)
             if updated:
                 self.dtype = metadata[1]
@@ -185,7 +184,8 @@ class PyramidStack(PyramidBase):
         self.focus_stack_validate()
         all_laplacians = []
         for i, img_path in enumerate(self.filenames):
-            self.print_message(f": processing file {img_path.split('/')[-1]} ({i + 1}/{n})")
+            self.print_message(
+                f": processing {self.image_str(i)}")
             img = read_img(img_path)
             all_laplacians.append(self.process_single_image(img, self.n_levels))
             self.after_step(i + n + 1)