sentry-devenv 1.19.0__py3-none-any.whl → 1.21.0__py3-none-any.whl

devenv/checks/{credsStore.py → dockerConfig.py}

@@ -8,7 +8,7 @@ from devenv.lib_check.types import checker
 from devenv.lib_check.types import fixer
 
 tags: set[str] = {"builtin"}
-name = "credsStore fix"
+name = "correct docker configuration"
 
 
 @checker
@@ -23,6 +23,15 @@ def check() -> tuple[bool, str]:
     if store and not shutil.which(f"docker-credential-{store}"):
         return False, "credsStore requires nonexistent binary"
 
+    # When docker-buildx is installed via brew, brew adds cliPluginsExtraDirs
+    # which takes precedence over the default plugin path we rely on.
+    # This ensures the devenv-managed global docker cli uses the default plugin path.
+    if config.get("cliPluginsExtraDirs"):
+        return (
+            False,
+            "cliPluginsExtraDirs exists, which overshadows the default plugin path",
+        )
+
     return True, ""
 
 
@@ -33,6 +42,7 @@ def fix() -> tuple[bool, str]:
             config = json.load(f)
 
         config.pop("credsStore", None)
+        config.pop("cliPluginsExtraDirs", None)
 
         with open(os.path.expanduser("~/.docker/config.json"), "w") as f:
             json.dump(config, f)

devenv/lib/archive.py

@@ -38,51 +38,60 @@ def download(
         dest = f"{cache_root}/{sha256}"
         os.makedirs(cache_root, exist_ok=True)
 
-    if not os.path.exists(dest):
-        headers = {}
-        if url.startswith("https://ghcr.io/v2/homebrew"):
-            # downloading homebrew blobs requires auth
-            # you can get an anonymous token from https://ghcr.io/token?service=ghcr.io&scope=repository%3Ahomebrew/core/go%3Apull
-            # but there's also a special shortcut token QQ==
-            # https://github.com/Homebrew/brew/blob/2184406bd8444e4de2626f5b0c749d4d08cb1aed/Library/Homebrew/brew.sh#L993
-            headers["Authorization"] = "bearer QQ=="
-
-        req = urllib.request.Request(url, headers=headers)
-
-        retry_sleep = 1.0
-        while retries >= 0:
-            try:
-                resp = urllib.request.urlopen(req)
-                break
-            except HTTPError as e:
-                if retries == 0:
-                    raise RuntimeError(f"Error getting {url}: {e}")
-                print(f"Error getting {url} ({retries} retries left): {e}")
-
-            time.sleep(retry_sleep)
-            retries -= 1
-            retry_sleep *= retry_exp
-
-        dest_dir = os.path.dirname(dest)
-        os.makedirs(dest_dir, exist_ok=True)
-
-        with tempfile.NamedTemporaryFile(delete=False, dir=dest_dir) as tmpf:
-            shutil.copyfileobj(resp, tmpf)
-            tmpf.seek(0)
-            checksum = hashlib.sha256()
+    if os.path.islink(dest):
+        # there are cases where dest can be an existing symlink
+        # (docker desktop starts and puts symlinks into ~/.docker/cli-plugins)
+        # such symlinks should be removed otherwise callers to download
+        # usually try to chmod after and end up with PermissionError
+        os.remove(dest)
+
+    if os.path.exists(dest):
+        return dest
+
+    headers = {}
+    if url.startswith("https://ghcr.io/v2/homebrew"):
+        # downloading homebrew blobs requires auth
+        # you can get an anonymous token from https://ghcr.io/token?service=ghcr.io&scope=repository%3Ahomebrew/core/go%3Apull
+        # but there's also a special shortcut token QQ==
+        # https://github.com/Homebrew/brew/blob/2184406bd8444e4de2626f5b0c749d4d08cb1aed/Library/Homebrew/brew.sh#L993
+        headers["Authorization"] = "bearer QQ=="
+
+    req = urllib.request.Request(url, headers=headers)
+
+    retry_sleep = 1.0
+    while retries >= 0:
+        try:
+            resp = urllib.request.urlopen(req)
+            break
+        except HTTPError as e:
+            if retries == 0:
+                raise RuntimeError(f"Error getting {url}: {e}")
+            print(f"Error getting {url} ({retries} retries left): {e}")
+
+        time.sleep(retry_sleep)
+        retries -= 1
+        retry_sleep *= retry_exp
+
+    dest_dir = os.path.dirname(dest)
+    os.makedirs(dest_dir, exist_ok=True)
+
+    with tempfile.NamedTemporaryFile(delete=False, dir=dest_dir) as tmpf:
+        shutil.copyfileobj(resp, tmpf)
+        tmpf.seek(0)
+        checksum = hashlib.sha256()
+        buf = tmpf.read(4096)
+        while buf:
+            checksum.update(buf)
             buf = tmpf.read(4096)
-            while buf:
-                checksum.update(buf)
-                buf = tmpf.read(4096)
-
-            if not secrets.compare_digest(checksum.hexdigest(), sha256):
-                raise RuntimeError(
-                    f"checksum mismatch for {url}:\n"
-                    f"- got: {checksum.hexdigest()}\n"
-                    f"- expected: {sha256}\n"
-                )
-
-            atomic_replace(tmpf.name, dest)
+
+        if not secrets.compare_digest(checksum.hexdigest(), sha256):
+            raise RuntimeError(
+                f"checksum mismatch for {url}:\n"
+                f"- got: {checksum.hexdigest()}\n"
+                f"- expected: {sha256}\n"
+            )
+
+        atomic_replace(tmpf.name, dest)
 
     return dest
 

devenv/lib/colima.py

@@ -78,7 +78,7 @@ def install_global() -> None:
         installed_version = stdout.strip().split()[-1]
         if version == installed_version:
             return
-        print(f"installed colima {installed_version} is outdated!")
+        print(f"installed colima {installed_version} is unexpected!")
 
     print(f"installing colima {version}...")
     uninstall(binroot)

devenv/lib/docker.py

@@ -101,7 +101,7 @@ def _check_buildx(binroot: str, expected_version: str) -> bool:
         return True
 
     print(
-        f"installed docker-buildx {installed_version} is outdated! expected: {expected_version}"
+        f"installed docker-buildx {installed_version} is unexpected! expected: {expected_version}"
     )
     return False
 
@@ -133,7 +133,7 @@ def install_global() -> None:
         stdout = proc.run((f"{binroot}/docker", "--version"), stdout=True)
         installed_version = stdout.strip().split()[2][:-1]
         if version != installed_version:
-            print(f"installed docker {installed_version} is outdated!")
+            print(f"installed docker {installed_version} is unexpected!")
             print(f"installing docker (cli, not desktop) {version}...")
             uninstall(binroot)
             _install(

devenv/lib/gcloud.py

@@ -82,7 +82,7 @@ def install(version: str, url: str, sha256: str, reporoot: str) -> None:
             installed_version = f.read().strip()
             if version == installed_version:
                 return
-            print(f"installed gcloud {installed_version} is outdated!")
+            print(f"installed gcloud {installed_version} is unexpected!")
 
     print(f"installing gcloud {version}...")
     uninstall(binroot)

devenv/lib/limactl.py

@@ -91,7 +91,7 @@ def install_global() -> None:
         installed_version = stdout.strip().split()[-1]
         if version == installed_version:
             return
-        print(f"installed limactl {installed_version} is outdated!")
+        print(f"installed limactl {installed_version} is unexpected!")
 
     uninstall(binroot)
     _install(cfg[SYSTEM_MACHINE], cfg[f"{SYSTEM_MACHINE}_sha256"], binroot)

devenv/lib/node.py

@@ -67,7 +67,7 @@ def installed(version: str, binroot: str) -> bool:
         if version == installed_version:
             return True
 
-        print(f"installed node {installed_version} is outdated!")
+        print(f"installed node {installed_version} is unexpected!")
         return False
 
 
@@ -118,7 +118,7 @@ def installed_yarn(version: str, binroot: str) -> bool:
     if version == installed_version:
         return True
 
-    print(f"installed yarn {installed_version} is outdated!")
+    print(f"installed yarn {installed_version} is unexpected!")
     return False
 
 

devenv/lib/tenv.py

@@ -88,7 +88,7 @@ def install(version: str, url: str, sha256: str, reporoot: str) -> None:
         installed_version = _version(binpath)
         if version == installed_version:
             return
-        print(f"installed tenv {installed_version} is outdated!")
+        print(f"installed tenv {installed_version} is unexpected!")
 
     print(f"installing tenv {version}...")
     uninstall(binroot)

devenv/lib/venv.py

@@ -106,7 +106,7 @@ def ensure(venv: str, python_version: str, url: str, sha256: str) -> None:
         return
 
     print(
-        f"virtualenv doesn't exist or is using an outdated python, recreating at {venv}..."
+        f"virtualenv doesn't exist or is using an unexpected python, recreating at {venv}..."
     )
     if os.path.exists(venv):
         shutil.rmtree(venv)

devenv/main.py

@@ -103,7 +103,7 @@ def main() -> ExitCode:
         # https://sentry.sentry.io/settings/projects/sentry-dev-env/keys/
         dsn="https://9bdb053cb8274ea69231834d1edeec4c@o1.ingest.sentry.io/5723503",
         # enable performance monitoring
-        enable_tracing=True,
+        traces_sample_rate=1.0,
     )
 
     return devenv(sys.argv, f"{home}/.config/sentry-devenv/config.ini")

{sentry_devenv-1.19.0.dist-info → sentry_devenv-1.21.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sentry_devenv
-Version: 1.19.0
+Version: 1.21.0
 Summary: Utilities for setting up a Sentry development environment
 Author-email: Joshua Li <joshua.li@sentry.io>, Ian Woodard <ian.woodard@sentry.io>, Buck Evan <buck.evan@sentry.io>
 Classifier: Programming Language :: Python :: 3
@@ -47,7 +47,6 @@ To update this installation, run `devenv update`.
 
 This is intended for initial setup of a new machine.
 
-
 `devenv fetch [repository name]`
 
 Any repository on github in the form of `[org]/[reponame]`
@@ -71,7 +70,6 @@ In general, our library is designed to isolate, as much as possible, a repo's de
 For example, [gcloud](#gcloud) is installed to `[reporoot]/.devenv/bin/gcloud` (with the gcloud sdk at `[reporoot]/.devenv/bin/google-cloud-sdk`).
 An exception to this would be python virtualenvs, which was implemented before the idea of `[reporoot]/.devenv`.
 
-
 `devenv doctor`
 
 Use this to diagnose and fix common issues.
@@ -79,14 +77,25 @@ Use this to diagnose and fix common issues.
 Repo-specific checks and fixes can be defined in `[reporoot]/devenv/checks`.
 Otherwise we have "builtin" checks and fixes in `devenv.checks`.
 
+`devenv update`
+
+This updates the global devenv installation, and global tools.
+
+If you're upgrading from a particularly old devenv, it won't have `update` so you need to:
+`~/.local/share/sentry-devenv/venv/bin/pip install -U sentry-devenv`
+
 
 ## technical overview
 
 Everything devenv needs is in `~/.local/share/sentry-devenv`.
 
-- `~/.local/share/sentry-devenv/bin` contains `devenv` and `direnv`
-    - we currently rely on a minimal [`[reporoot]/.envrc`](#direnv) to add `[reporoot]/.devenv/bin` to PATH
-    - see [examples](#examples) for .envrc suggestions
+- `~/.local/share/sentry-devenv/bin` contains:
+    - `devenv` itself
+    - `direnv`
+      - we currently rely on direnv and a minimal [`[reporoot]/.envrc`](#direnv) to add `[reporoot]/.devenv/bin` to PATH
+      - see [examples](#examples) for .envrc suggestions
+    - global tools: `docker` (cli), `colima`
+
 
 ### runtime
 

{sentry_devenv-1.19.0.dist-info → sentry_devenv-1.21.0.dist-info}/RECORD

@@ -6,36 +6,36 @@ devenv/colima.py,sha256=Dk9t6eu2DEoqqkY8xLmgiB96r-6zi3aXcvON3P8h1JQ,1537
 devenv/constants.py,sha256=wl0sRfkNeJL-sML6MG5nS0zU-dwRo1mDPrhUSHHY1YQ,1498
 devenv/doctor.py,sha256=tcwXrE2Y7Ued2gAXCXtfFkyXbG9DOi6jVobbq6DnuZs,8663
 devenv/fetch.py,sha256=MbztGFOzBR4KDPG0TVWcQsA4pGXk61zrQXvh-C9xHuk,3904
-devenv/main.py,sha256=JYV1GflML2DOrIhbZq_Vn89dFd0hqOKXxDVSd2GQRgY,3264
+devenv/main.py,sha256=grOHjy0kUJjeGW8STg-WMneVYlkTRVMoFjNdIgt7sjg,3267
 devenv/pin_gha.py,sha256=t7A5CV1bnYRa4SAikuoJeodHuwV6moIePvhQ1Zdc1eE,2187
 devenv/py.typed,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 devenv/pythons.py,sha256=ZcjBrkfmQEkiMP217VyTG48cyteJdYG_hoQ6oFKx_CU,1252
 devenv/sync.py,sha256=B9bvAuI7K-4SqcfHD4_zwKpozAnHWCNOL-IhVOcc3Zg,1254
 devenv/update.py,sha256=CkshQUvmVVblXdjARgWQKXSe7pwMjSMrPR3gDEesX5c,2402
 devenv/checks/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-devenv/checks/credsStore.py,sha256=G0mqzH62w4_3Tc4VG6tssGHFOUiVgp4RSPlYj86zsUc,1153
+devenv/checks/dockerConfig.py,sha256=5VExtcarjizPhR7OSdyWhkvzS6zY-6qiefxlwkexQuk,1623
 devenv/checks/dockerDesktop.py,sha256=ynt8nNQ2DDT2rJDGZ-g7xxc4HErHJV_iqBqYHQtvA7Q,1343
 devenv/checks/limaDns.py,sha256=cHef2czdYYLvQqiM4bxiYtzYw4UVTIXJPwrGW2Kjpxo,1885
 devenv/checks/test.py,sha256=AvxoA2W5qTO2ZpoXmjScLiJxXD3Y_limYp5yTjGSZ9U,701
 devenv/lib/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-devenv/lib/archive.py,sha256=LlVETRsf3J53yY_8sjL4P8plLNEMKoS9G48kfoVoseA,4503
+devenv/lib/archive.py,sha256=75MjlDuwHVaazbNUr8vJmqTyl4Jz6KRd_fUcpwvPwec,4710
 devenv/lib/brew.py,sha256=_7recvYh-LnUJC0eKnYK7F8AzGRL5bi_Khv0f_mgrlM,1795
-devenv/lib/colima.py,sha256=8JSAGC2pXthY_h7-AOsW0xgN-kyZq7_fh63-hhYFCIE,7381
+devenv/lib/colima.py,sha256=fVzM8jCN06HAkJd3dTz3CXXlpGoykkAe-Ln8RgYb2QU,7383
 devenv/lib/config.py,sha256=5eXYwM44AJ3w2VfVbCDqchYOL1zAjazNcirtM6kxxGw,3344
 devenv/lib/context.py,sha256=4EDImK9pvTp3FqeNigevC9lbJsgdDO9D1t2_Y4NyPlc,207
 devenv/lib/direnv.py,sha256=HDRUaIR0PMAQYiiTaw3gEQuh6Tdb7BUJmV7dBZdPztM,1325
-devenv/lib/docker.py,sha256=cOBe9TRzoVkJbYv0g8yqkuyDYyntTasagwBGSiAgijs,5684
+devenv/lib/docker.py,sha256=d-jGdagfvxGpZtfoEG_m6IMcm8YvUEjJoHx0ACKNWKk,5688
 devenv/lib/fs.py,sha256=IBahQ9fB-o9cK9HipK_L0gso2OVinIDTxFWoeMte9ww,2764
-devenv/lib/gcloud.py,sha256=G8rhKC89TqWcFzIVsFd64d4ouD6M6s-TaMX5ZxtKypw,3550
+devenv/lib/gcloud.py,sha256=pJ28_L0gUS1lZna-gIHeJPo9bEfSHVXh63CoRQGyAw8,3552
 devenv/lib/github.py,sha256=AMtcz6gTVKy7qvCP1zTUdHQlnSM32TVaji0aOXJ_F9A,3463
-devenv/lib/limactl.py,sha256=uGcRkXQACDvbwKWhgEqgoUSVZjX6vEUGOutJDEw3kNM,4254
+devenv/lib/limactl.py,sha256=wMA_Q4DRPjmBPe0JSj1xPwYesFa9MT_vVSdaBAAKn5w,4256
 devenv/lib/modules.py,sha256=shoqgja0b-xzXr601Ryz0JOy3Vxbw53I3cRYezVt77g,859
-devenv/lib/node.py,sha256=0LobIBWRQMzBiTKgv-WCva0Q1ZK3sR2NXNmnSa0Pcow,4156
+devenv/lib/node.py,sha256=sp5QbExF0H03UnfLUmFown42_NhyPWKw0H776W7987U,4160
 devenv/lib/proc.py,sha256=eU7DHIk_66wgkHRmdtKbBKZTa6q4tl9QJbrlnQOQCls,2743
 devenv/lib/repository.py,sha256=cDCgcZ6lw0bcWC6DrcDp3tz_MWObmgAyFq39TeU7YHY,1966
 devenv/lib/rosetta.py,sha256=Lm-tDFut86o6l-Y55d5kTacRHTwrv5MFEymQpy7Qihc,1170
-devenv/lib/tenv.py,sha256=9-I-7wvJNqanaMEs39bheOfikVz3wgTKtArkeCsOz8I,3028
-devenv/lib/venv.py,sha256=VbV2IA3HTk5WABBpMQJvlizdknEQVz1SsLxlEBDOLkc,3186
+devenv/lib/tenv.py,sha256=EulO1xYh8wu6-QoDvQd3TVbaLvmztXqCV6ya5sBWZiw,3030
+devenv/lib/venv.py,sha256=1HWY1uFXLP1YCGVX7Ik5R3tNilRCKrVXOZN42-k_5eQ,3188
 devenv/lib_check/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 devenv/lib_check/brew.py,sha256=tId1IgItju-fulbmTXmmI2Oo_-q332rd1tUN5RSkTrs,544
 devenv/lib_check/types.py,sha256=HIvuU3q27Izgm77jH6QX6gKMvgfunx05X4OEsJoqjP8,271
@@ -46,7 +46,7 @@ tests/test_pythons.py,sha256=Nepff11shv18irF3EYzf3U6zsRMrpLeS8QfrGJ3bTME,723
 tests/test_sync.py,sha256=ihCYFxscPwbVY_cnFyq2fvYUBc_SyB6gsElz334fmaw,871
 tests/utils.py,sha256=Qr2RM5Vo-14mF8tPSJITiYuhGc6fU9rk-fChxW-lokk,291
 tests/checks/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-tests/checks/test_credStore.py,sha256=fvvKBx2vqbHDAfwxz77GPHO_gc8jawkqOpaDOob1dEs,1459
+tests/checks/test_dockerConfig.py,sha256=wJQ1ADdG4HJCQyiTirUk5VsEAUfhlSDWCJfW_ylH5po,1702
 tests/doctor/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/doctor/test_attempt_fix.py,sha256=cGUv7-xRKWCizC9cNNqiCp7aa95k3nHUXvRFFuLfJ34,1075
 tests/doctor/test_filter_failing_checks.py,sha256=5L5XdBSyeySwZtJeAR71lbktt3NxkJdUfncKBJPYdAc,1270
@@ -63,7 +63,7 @@ tests/doctor/devenv/checks/no_check.py,sha256=hcX2CNzB07U7r6KHbW71IvsW7UG-JsHcji
 tests/doctor/devenv/checks/no_name.py,sha256=txJhaXiJjY4CUPONTX9G6J6RttTCJ-BupDmZT1sKoAc,167
 tests/doctor/devenv/checks/no_tags.py,sha256=ATwlSsn5fe-OwNfgEDDa0HiBoOgkOGwkqIbQuDaghpk,161
 tests/doctor/devenv/checks/passing_check.py,sha256=F-gW4ZEqXVBL5akMaR3Hcf3yuihm3jfxTY80-EqsbOg,307
-tests/lib/test_archive.py,sha256=5FdCF8t64FewevL4P9PFojWS-a15z2I11TX0G1L_A-g,7944
+tests/lib/test_archive.py,sha256=4yWoB0ZBpGLQByutPAOEVjUYSBlWdZppvRofYqX3pjk,9370
 tests/lib/test_brew.py,sha256=g2Sz-yg4-212qlsKg0vfHf604bQyRjUElsf3khvXrTQ,5711
 tests/lib/test_direnv.py,sha256=GKpEbsHgaRZWevYrsa0oOGQFCsyllCLX1vGdg3igvAc,1551
 tests/lib/test_fs.py,sha256=qhX9CQTTSht1f6ZJfmpsSFICTwPs--h_mLlS_1jnZQg,1670
@@ -71,8 +71,8 @@ tests/lib/test_github.py,sha256=IMEG2cmRaK_PMJprFE_ZMqPnZ0StwWqgznhhT_zVk3U,4526
 tests/lib/test_proc.py,sha256=XH6OnxKPSSm3HvDjYHApputMKwgOE8lYqDuK2vK0Z0U,2626
 tests/lib/test_repository.py,sha256=gUi1lkY7bha5WwZ5xcnENOlFYboVV8TFW1lCESvS0VA,787
 tests/lib/test_venv.py,sha256=wscU7Enp8fK6o_2HgIT4WwDnvHbKwaKvJhNyJUrDNqk,3262
-sentry_devenv-1.19.0.dist-info/METADATA,sha256=I9mqOnTg4iM8ffcjIKb-grNlcw2KrQCQph6WUzMK5fI,13622
-sentry_devenv-1.19.0.dist-info/WHEEL,sha256=ck4Vq1_RXyvS4Jt6SI0Vz6fyVs4GWg7AINwpsaGEgPE,91
-sentry_devenv-1.19.0.dist-info/entry_points.txt,sha256=StsIuNugcoEU8jsPy6H9ECjzoDzOVKXl1vUaYTIGbzM,44
-sentry_devenv-1.19.0.dist-info/top_level.txt,sha256=dOQExvIA0fj_EQjCrMTS7CCHNH7WZFHxEU0M7LlNcKQ,16
-sentry_devenv-1.19.0.dist-info/RECORD,,
+sentry_devenv-1.21.0.dist-info/METADATA,sha256=HoKXEUwfiAL2U9Gfqz2BmOHWiPmz11r3h_4y2PRmz-4,13939
+sentry_devenv-1.21.0.dist-info/WHEEL,sha256=zaaOINJESkSfm_4HQVc5ssNzHCPXhJm0kEUakpsEHaU,91
+sentry_devenv-1.21.0.dist-info/entry_points.txt,sha256=StsIuNugcoEU8jsPy6H9ECjzoDzOVKXl1vUaYTIGbzM,44
+sentry_devenv-1.21.0.dist-info/top_level.txt,sha256=dOQExvIA0fj_EQjCrMTS7CCHNH7WZFHxEU0M7LlNcKQ,16
+sentry_devenv-1.21.0.dist-info/RECORD,,

{sentry_devenv-1.19.0.dist-info → sentry_devenv-1.21.0.dist-info}/WHEEL

@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: setuptools (80.0.0)
+Generator: setuptools (80.8.0)
 Root-Is-Purelib: true
 Tag: py3-none-any
 

tests/checks/{test_credStore.py → test_dockerConfig.py}

@@ -8,7 +8,7 @@ from unittest import mock
 
 import pytest
 
-from devenv.checks import credsStore
+from devenv.checks import dockerConfig
 
 
 @pytest.fixture
@@ -25,26 +25,32 @@ def fake_config(tmp_path: pathlib.Path) -> Generator[pathlib.Path]:
 
 def test_no_credsStore_ok(fake_config: pathlib.Path) -> None:
     fake_config.write_text("{}")
-    assert credsStore.check() == (True, "")
+    assert dockerConfig.check() == (True, "")
 
 
 def test_binary_ok(fake_config: pathlib.Path) -> None:
     fake_config.write_text('{"credsStore": "example"}')
     with mock.patch.object(shutil, "which", return_value="/fake/exe"):
-        assert credsStore.check() == (True, "")
+        assert dockerConfig.check() == (True, "")
 
 
 @pytest.mark.parametrize("name", ("desktop", "osxkeychain"))
 def test_binary_missing(fake_config: pathlib.Path, name: str) -> None:
     fake_config.write_text(f'{{"credsStore": "{name}"}}')
     with mock.patch.object(shutil, "which", return_value=None):
-        assert credsStore.check() == (
+        assert dockerConfig.check() == (
             False,
             "credsStore requires nonexistent binary",
         )
 
 
-def test_fix(fake_config: pathlib.Path) -> None:
+def test_fix_credsStore(fake_config: pathlib.Path) -> None:
     fake_config.write_text('{"credsStore": "bad"}')
-    assert credsStore.fix() == (True, "")
+    assert dockerConfig.fix() == (True, "")
+    assert fake_config.read_text() == "{}"
+
+
+def test_fix_cliPluginsExtraDirs(fake_config: pathlib.Path) -> None:
+    fake_config.write_text('{"cliPluginsExtraDirs": ["foo/"]}')
+    assert dockerConfig.fix() == (True, "")
     assert fake_config.read_text() == "{}"

tests/lib/test_archive.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import io
+import os
 import pathlib
 import tarfile
 import time
@@ -169,6 +170,12 @@ def test_download(tmp_path: pathlib.Path, mock_sleep: mock.MagicMock) -> None:
     )
 
     dest = f"{tmp_path}/a"
+
+    # if dest is already a valid symlink it should be paved over
+    with open(f"{tmp_path}/hi", "wb"):
+        pass
+    os.symlink(f"{tmp_path}/hi", dest)
+
     with mock.patch.object(
         urllib.request,
         "urlopen",
@@ -186,7 +193,22 @@ def test_download(tmp_path: pathlib.Path, mock_sleep: mock.MagicMock) -> None:
     with open(dest, "rb") as f:
         assert f.read() == data
 
-    dest = f"{tmp_path}/b"
+
+def test_download_exceeded_retries(
+    tmp_path: pathlib.Path, mock_sleep: mock.MagicMock
+) -> None:
+    data_sha256 = (
+        "b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c"
+    )
+
+    err = urllib.error.HTTPError(
+        "https://example.com/foo",
+        503,
+        "Service Unavailable",
+        "",  # type: ignore
+        io.BytesIO(b""),
+    )
+    dest = f"{tmp_path}/a"
     with pytest.raises(RuntimeError) as excinfo:
         with mock.patch.object(
             urllib.request,
@@ -202,7 +224,42 @@ def test_download(tmp_path: pathlib.Path, mock_sleep: mock.MagicMock) -> None:
         == "Error getting https://example.com/foo: HTTP Error 503: Service Unavailable"
     )
 
-    dest = f"{tmp_path}/b"
+
+def test_download_dest_is_broken_symlink(
+    tmp_path: pathlib.Path, mock_sleep: mock.MagicMock
+) -> None:
+    data = b"foo\n"
+    data_sha256 = (
+        "b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c"
+    )
+
+    dest = f"{tmp_path}/a"
+
+    # if dest is already a dead symlink it should be paved over as well
+    os.symlink(f"{tmp_path}/does-not-exist", dest)
+
+    with mock.patch.object(
+        urllib.request,
+        "urlopen",
+        autospec=True,
+        side_effect=(io.BytesIO(data),),
+    ):
+        archive.download("https://example.com/foo", data_sha256, dest)
+
+    with open(dest, "rb") as f:
+        assert f.read() == data
+
+
+def test_download_wrong_sha(
+    tmp_path: pathlib.Path, mock_sleep: mock.MagicMock
+) -> None:
+    data = b"foo\n"
+    data_sha256 = (
+        "b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c"
+    )
+
+    dest = f"{tmp_path}/a"
+
     with pytest.raises(RuntimeError) as excinfo:
         with mock.patch.object(
             urllib.request,