runnable 0.30.0__py3-none-any.whl → 0.30.2__py3-none-any.whl

extensions/nodes/torch.py

@@ -115,7 +115,9 @@ class TorchNode(DistributedNode, TorchConfig):
         map_variable: TypeMapVariable = None,
         attempt_number: int = 1,
     ) -> StepLog:
-        assert map_variable is None, "TorchNode does not support map_variable"
+        assert (
+            map_variable is None or not map_variable
+        ), "TorchNode does not support map_variable"
 
         step_log = self._context.run_log_store.get_step_log(
             self._get_step_log_name(map_variable), self._context.run_id
@@ -130,6 +132,8 @@ class TorchNode(DistributedNode, TorchConfig):
             self._context.parameters_file or ""
         )
         os.environ["RUNNABLE_TORCH_RUN_ID"] = self._context.run_id
+        # retrieve the master address and port from the parameters
+        # default to localhost and 29500
         launcher = elastic_launch(
             launch_config,
             training_subprocess,
@@ -161,9 +165,17 @@ class TorchNode(DistributedNode, TorchConfig):
 
         return step_log
 
-    # TODO: Not sure we need these methods
     def fan_in(self, map_variable: dict[str, str | int | float] | None = None):
-        assert map_variable is None, "TorchNode does not support map_variable"
+        # Destroy the service
+        # Destroy the statefulset
+        assert (
+            map_variable is None or not map_variable
+        ), "TorchNode does not support map_variable"
 
     def fan_out(self, map_variable: dict[str, str | int | float] | None = None):
-        assert map_variable is None, "TorchNode does not support map_variable"
+        # Create a service
+        # Create a statefulset
+        # Gather the IPs and set them as parameters downstream
+        assert (
+            map_variable is None or not map_variable
+        ), "TorchNode does not support map_variable"

extensions/pipeline_executor/__init__.py

@@ -233,11 +233,15 @@ class GenericPipelineExecutor(BasePipelineExecutor):
             mock=mock,
         )
 
-        data_catalogs_put: Optional[List[DataCatalog]] = self._sync_catalog(stage="put")
-        logger.debug(f"data_catalogs_put: {data_catalogs_put}")
+        if step_log.status == defaults.SUCCESS:
+            data_catalogs_put: Optional[List[DataCatalog]] = self._sync_catalog(
+                stage="put"
+            )
+            logger.debug(f"data_catalogs_put: {data_catalogs_put}")
+            step_log.add_data_catalogs(data_catalogs_put or [])
 
+        # get catalog should always be added to the step log
         step_log.add_data_catalogs(data_catalogs_get or [])
-        step_log.add_data_catalogs(data_catalogs_put or [])
 
         console.print(f"Summary of the step: {step_log.internal_name}")
         console.print(step_log.get_summary(), style=defaults.info_style)

extensions/pipeline_executor/argo.py

@@ -261,7 +261,7 @@ class CommonDefaults(BaseModelWIthConfig):
     tolerations: Optional[list[Toleration]] = Field(default=None)
     image_pull_policy: ImagePullPolicy = Field(default=ImagePullPolicy.Always)
     resources: Resources = Field(default_factory=Resources)
-    env: list[EnvVar | SecretEnvVar] = Field(default_factory=list, exclude=True)
+    env: list[EnvVar | SecretEnvVar] = Field(default_factory=list)
 
 
 # The user provided defaults at the top level
@@ -658,7 +658,7 @@ class ArgoExecutor(GenericPipelineExecutor):
     def _set_env_vars_to_task(
         self, working_on: BaseNode, container_template: CoreContainerTemplate
     ):
-        if not isinstance(working_on, TaskNode):
+        if not isinstance(working_on, TaskNode) or isinstance(working_on, TorchNode):
             return
 
         global_envs: dict[str, str] = {}
@@ -880,6 +880,7 @@ class ArgoExecutor(GenericPipelineExecutor):
                 case "torch":
                     assert isinstance(working_on, TorchNode)
                     # TODO: Need to add multi-node functionality
+                    # Check notes on the torch node
 
                     template_of_container = self._create_container_template(
                         working_on,

{runnable-0.30.0.dist-info → runnable-0.30.2.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: runnable
-Version: 0.30.0
+Version: 0.30.2
 Summary: Add your description here
 Author-email: "Vammi, Vijay" <vijay.vammi@astrazeneca.com>
 License-File: LICENSE

{runnable-0.30.0.dist-info → runnable-0.30.2.dist-info}/RECORD

@@ -16,11 +16,11 @@ extensions/job_executor/pyproject.toml,sha256=UIEgiCYHTXcRWSByNMFuKJFKgxTBpQqTqy
 extensions/nodes/README.md,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 extensions/nodes/nodes.py,sha256=s9ub1dqy4qHjRQG6YElCdL7rCOTYNs9RUIrStZ6tEB4,28256
 extensions/nodes/pyproject.toml,sha256=YTu-ETN3JNFSkMzzWeOwn4m-O2nbRH-PmiPBALDCUw4,278
-extensions/nodes/torch.py,sha256=kB4a72YMcrxDDzbR5LffODtrdA7vUo9dRJlaVr8KEEM,5570
+extensions/nodes/torch.py,sha256=oYh4ep9J6CS3r04HURJba5m4v8lzNupWUh4PAXvGgi0,5952
 extensions/nodes/torch_config.py,sha256=yDvDADpnLhQsNtfH8qIztLHQ2LhYiOJEWljxpH9GZzs,1222
 extensions/pipeline_executor/README.md,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-extensions/pipeline_executor/__init__.py,sha256=9ZMHcieSYdTiYyjSkc8eT8yhOlKEUFnrbrdbqdOgvP0,24195
-extensions/pipeline_executor/argo.py,sha256=svnje6l1mYfLhrHZf54pE_ljwxvH8Gt0ZXSLWLDs4aQ,37869
+extensions/pipeline_executor/__init__.py,sha256=LApJGwJctEBTDQX9gGHkGV97T6rF_q-_59OzvAJ2X1g,24346
+extensions/pipeline_executor/argo.py,sha256=-mWH5H2lZEldO8er7-tHberm7swqo4CwrtQKUd2VkGA,37944
 extensions/pipeline_executor/local.py,sha256=6oWUJ6b6NvIkpeQJBoCT1hbfX4_6WCB4HzMgHZ4ik1A,1887
 extensions/pipeline_executor/local_container.py,sha256=3kZ2QCsrq_YjH9dcAz8v05knKShQ_JtbIU-IA_-G538,12724
 extensions/pipeline_executor/mocked.py,sha256=0sMmypuvstBIv9uQg-WAcPrF3oOFpeEXNi6N8Nzdnl0,5680
@@ -58,8 +58,8 @@ runnable/sdk.py,sha256=NZVQGaL4Zm2hwloRmqEgp8UPbBg9hY1abQGYnOgniPI,35128
 runnable/secrets.py,sha256=4L_dBFxTgr8r_hHUD6RlZEtqaOHDRsFG5PXO5wlvMI0,2324
 runnable/tasks.py,sha256=Qb1IhVxHv68E7vf3M3YCf7MGRHyjmsEEYBpEpiZ4mRI,29062
 runnable/utils.py,sha256=hBr7oGwGL2VgfITlQCTz-a1iwvvf7Mfl-HY8UdENZac,19929
-runnable-0.30.0.dist-info/METADATA,sha256=mFY61nh2mT8DGjewQKOJIlNVxcZisIWsLZ6FlcvHvZU,10115
-runnable-0.30.0.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
-runnable-0.30.0.dist-info/entry_points.txt,sha256=PrjKrlfXPZaV_7hz8orGu4FDnatLqnhPOXljyllszdw,1880
-runnable-0.30.0.dist-info/licenses/LICENSE,sha256=xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ,11357
-runnable-0.30.0.dist-info/RECORD,,
+runnable-0.30.2.dist-info/METADATA,sha256=M-3XWv_ijqZLfEwzQ6W5IsZaHGOpNxToI8pYNI-SlwQ,10115
+runnable-0.30.2.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
+runnable-0.30.2.dist-info/entry_points.txt,sha256=PrjKrlfXPZaV_7hz8orGu4FDnatLqnhPOXljyllszdw,1880
+runnable-0.30.2.dist-info/licenses/LICENSE,sha256=xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ,11357
+runnable-0.30.2.dist-info/RECORD,,