runnable 0.11.0__py3-none-any.whl → 0.11.1__py3-none-any.whl

runnable/__init__.py

@@ -29,6 +29,10 @@ from runnable.sdk import (  # noqa
     pickled,
 )
 
+## TODO: Summary should be a bit better for catalog.
+## If the execution fails, hint them about the retry executor.
+# Make the retry executor loose!
+
 # TODO: Think of model registry as a central place to store models.
 # TODO: Implement Sagemaker pipelines as a executor.
 

runnable/cli.py

@@ -1,3 +1,4 @@
+# A dummy to trigger the PR
 import logging
 
 import click

runnable/entrypoints.py

@@ -172,6 +172,7 @@ def execute(
     )
     console.print("Working with context:")
     console.print(run_context)
+    console.rule(style="[dark orange]")
 
     executor = run_context.executor
 
@@ -243,6 +244,7 @@ def execute_single_node(
     )
     console.print("Working with context:")
     console.print(run_context)
+    console.rule(style="[dark orange]")
 
     executor = run_context.executor
     run_context.execution_plan = defaults.EXECUTION_PLAN.CHAINED.value
@@ -296,6 +298,7 @@ def execute_notebook(
 
     console.print("Working with context:")
     console.print(run_context)
+    console.rule(style="[dark orange]")
 
     step_config = {
         "command": notebook_file,
@@ -358,6 +361,7 @@ def execute_function(
 
     console.print("Working with context:")
     console.print(run_context)
+    console.rule(style="[dark orange]")
 
     # Prepare the graph with a single node
     step_config = {
@@ -427,6 +431,7 @@ def fan(
     )
     console.print("Working with context:")
     console.print(run_context)
+    console.rule(style="[dark orange]")
 
     executor = run_context.executor
     run_context.execution_plan = defaults.EXECUTION_PLAN.CHAINED.value

runnable/extensions/executor/__init__.py

@@ -476,6 +476,8 @@ class GenericExecutor(BaseExecutor):
                 logger.exception(e)
                 raise
 
+            console.rule(style="[dark orange]")
+
             if working_on.node_type in ["success", "fail"]:
                 break
 

runnable/sdk.py

@@ -15,8 +15,13 @@ from pydantic import (
     field_validator,
     model_validator,
 )
-from rich import print
-from rich.progress import BarColumn, Progress, TextColumn, TimeElapsedColumn
+from rich.progress import (
+    BarColumn,
+    Progress,
+    SpinnerColumn,
+    TextColumn,
+    TimeElapsedColumn,
+)
 from rich.table import Column
 from typing_extensions import Self
 
@@ -71,7 +76,7 @@ class Catalog(BaseModel):
 
 class BaseTraversal(ABC, BaseModel):
     name: str
-    next_node: str = Field(default="", alias="next")
+    next_node: str = Field(default="", serialization_alias="next_node")
     terminate_with_success: bool = Field(default=False, exclude=True)
     terminate_with_failure: bool = Field(default=False, exclude=True)
     on_failure: str = Field(default="", alias="on_failure")
@@ -83,6 +88,12 @@ class BaseTraversal(ABC, BaseModel):
     def internal_name(self) -> str:
         return self.name
 
+    def __hash__(self):
+        """
+        Needed to Uniqueize DataCatalog objects.
+        """
+        return hash(self.name)
+
     def __rshift__(self, other: StepType) -> StepType:
         if self.next_node:
             raise Exception(f"The node {self} already has a next node: {self.next_node}")
@@ -180,6 +191,7 @@ class BaseTask(BaseTraversal):
     catalog: Optional[Catalog] = Field(default=None, alias="catalog")
     overrides: Dict[str, Any] = Field(default_factory=dict, alias="overrides")
     returns: List[Union[str, TaskReturns]] = Field(default_factory=list, alias="returns")
+    secrets: List[str] = Field(default_factory=list)
 
     @field_validator("returns", mode="before")
     @classmethod
@@ -201,7 +213,7 @@ class BaseTask(BaseTraversal):
             if not (self.terminate_with_failure or self.terminate_with_success):
                 raise AssertionError("A node not being terminated must have a user defined next node")
 
-        return TaskNode.parse_from_config(self.model_dump(exclude_none=True))
+        return TaskNode.parse_from_config(self.model_dump(exclude_none=True, by_alias=True))
 
 
 class PythonTask(BaseTask):
@@ -297,9 +309,9 @@ class NotebookTask(BaseTask):
 
     """
 
-    notebook: str = Field(alias="command")
+    notebook: str = Field(serialization_alias="command")
 
-    notebook_output_path: Optional[str] = Field(default=None, alias="notebook_output_path")
+    notebook_output_path: Optional[str] = Field(default=None, alias="notebook_output_path", validate_default=True)
     optional_ploomber_args: Optional[Dict[str, Any]] = Field(default=None, alias="optional_ploomber_args")
 
     @computed_field
@@ -526,7 +538,7 @@ class Pipeline(BaseModel):
     _dag: graph.Graph = PrivateAttr()
     model_config = ConfigDict(extra="forbid")
 
-    def _validate_path(self, path: List[StepType]) -> None:
+    def _validate_path(self, path: List[StepType], failure_path: bool = False) -> None:
         # Check if one and only one step terminates with success
         # Check no more than one step terminates with failure
 
@@ -544,7 +556,7 @@ class Pipeline(BaseModel):
                     raise Exception("A pipeline cannot have more than one step that terminates with failure")
                 reached_failure = True
 
-        if not reached_success:
+        if not reached_success and not reached_failure:
             raise Exception("A pipeline must have at least one step that terminates with success")
 
     def _construct_path(self, path: List[StepType]) -> None:
@@ -594,11 +606,21 @@ class Pipeline(BaseModel):
 
         # Check all paths are valid and construct the path
         paths = [success_path] + on_failure_paths
+        failure_path = False
         for path in paths:
-            self._validate_path(path)
+            self._validate_path(path, failure_path)
             self._construct_path(path)
 
-        all_steps: List[StepType] = [step for step in success_path + on_failure_paths]  # type: ignore
+            failure_path = True
+
+        all_steps: List[StepType] = []
+
+        for path in paths:
+            for step in path:
+                all_steps.append(step)
+
+        seen = set()
+        unique = [x for x in all_steps if not (x in seen or seen.add(x))]  # type: ignore
 
         self._dag = graph.Graph(
             start_at=all_steps[0].name,
@@ -606,7 +628,7 @@ class Pipeline(BaseModel):
             internal_branch_name=self.internal_branch_name,
         )
 
-        for step in all_steps:
+        for step in unique:
             self._dag.add_node(step.create_node())
 
         if self.add_terminal_nodes:
@@ -675,8 +697,9 @@ class Pipeline(BaseModel):
 
         run_context.dag = graph.create_graph(dag_definition)
 
-        print("Working with context:")
-        print(run_context)
+        console.print("Working with context:")
+        console.print(run_context)
+        console.rule(style="[dark orange]")
 
         if not run_context.executor._local:
             # We are not working with non local executor
@@ -693,6 +716,7 @@ class Pipeline(BaseModel):
         run_context.executor.prepare_for_graph_execution()
 
         with Progress(
+            SpinnerColumn(spinner_name="runner"),
             TextColumn("[progress.description]{task.description}", table_column=Column(ratio=2)),
             BarColumn(table_column=Column(ratio=1), style="dark_orange"),
             TimeElapsedColumn(table_column=Column(ratio=1)),

runnable/tasks.py

@@ -9,13 +9,14 @@ import sys
 from datetime import datetime
 from pickle import PicklingError
 from string import Template
-from typing import Any, Dict, List, Literal, Tuple
+from typing import Any, Dict, List, Literal, Optional, Tuple
 
 from pydantic import BaseModel, ConfigDict, Field, ValidationInfo, field_validator
+from rich.console import Console
 from stevedore import driver
 
 import runnable.context as context
-from runnable import console, defaults, exceptions, parameters, utils
+from runnable import defaults, exceptions, parameters, utils
 from runnable.datastore import (
     JsonParameter,
     MetricParameter,
@@ -32,6 +33,9 @@ logging.getLogger("stevedore").setLevel(logging.CRITICAL)
 # TODO: Can we add memory peak, cpu usage, etc. to the metrics?
 
 
+console = Console(file=io.StringIO())
+
+
 class TaskReturns(BaseModel):
     name: str
     kind: Literal["json", "object", "metric"] = Field(default="json")
@@ -42,7 +46,7 @@ class BaseTaskType(BaseModel):
 
     task_type: str = Field(serialization_alias="command_type")
     node_name: str = Field(exclude=True)
-    secrets: Dict[str, str] = Field(default_factory=dict)
+    secrets: List[str] = Field(default_factory=list)
     returns: List[TaskReturns] = Field(default_factory=list, alias="returns")
 
     model_config = ConfigDict(extra="forbid")
@@ -69,15 +73,14 @@ class BaseTaskType(BaseModel):
         raise NotImplementedError()
 
     def set_secrets_as_env_variables(self):
-        for key, value in self.secrets.items():
+        for key in self.secrets:
             secret_value = context.run_context.secrets_handler.get(key)
-            self.secrets[value] = secret_value
-            os.environ[value] = secret_value
+            os.environ[key] = secret_value
 
     def delete_secrets_from_env_variables(self):
-        for _, value in self.secrets.items():
-            if value in os.environ:
-                del os.environ[value]
+        for key in self.secrets:
+            if key in os.environ:
+                del os.environ[key]
 
     def execute_command(
         self,
@@ -135,17 +138,21 @@ class BaseTaskType(BaseModel):
         if not allow_complex:
             params = {key: value for key, value in params.items() if isinstance(value, JsonParameter)}
 
-        log_file_name = self.node_name.replace(" ", "_") + ".execution.log"
+        log_file_name = self.node_name  # + ".execution.log"
         if map_variable:
             for _, value in map_variable.items():
                 log_file_name += "_" + str(value)
 
+        log_file_name = "".join(x for x in log_file_name if x.isalnum()) + ".execution.log"
+
         log_file = open(log_file_name, "w")
 
         f = io.StringIO()
         try:
             with contextlib.redirect_stdout(f):
+                # with contextlib.nullcontext():
                 yield params
+                print(console.file.getvalue())  # type: ignore
         except Exception as e:  # pylint: disable=broad-except
             logger.exception(e)
         finally:
@@ -156,10 +163,11 @@ class BaseTaskType(BaseModel):
             log_file.close()
 
             # Put the log file in the catalog
-            # self._context.catalog_handler.put(name=log_file.name, run_id=context.run_context.run_id)
+            self._context.catalog_handler.put(name=log_file.name, run_id=context.run_context.run_id)
             os.remove(log_file.name)
 
             # Update parameters
+            # This should only update the parameters that are changed at the root level.
             self._context.run_log_store.set_parameters(parameters=params, run_id=self._context.run_id)
 
 
@@ -219,8 +227,7 @@ class PythonTaskType(BaseTaskType):  # pylint: disable=too-few-public-methods
                     logger.info(f"Calling {func} from {module} with {filtered_parameters}")
                     user_set_parameters = f(**filtered_parameters)  # This is a tuple or single value
                 except Exception as e:
-                    logger.exception(e)
-                    console.print(e, style=defaults.error_style)
+                    console.log(e, style=defaults.error_style, markup=False)
                     raise exceptions.CommandCallError(f"Function call: {self.command} did not succeed.\n") from e
 
                 attempt_log.input_parameters = params.copy()
@@ -263,9 +270,9 @@ class PythonTaskType(BaseTaskType):  # pylint: disable=too-few-public-methods
                 attempt_log.status = defaults.SUCCESS
             except Exception as _e:
                 msg = f"Call to the function {self.command} did not succeed.\n"
-                logger.exception(_e)
                 attempt_log.message = msg
-                console.print(_e, style=defaults.error_style)
+                console.print_exception(show_locals=False)
+                console.log(_e, style=defaults.error_style)
 
         attempt_log.end_time = str(datetime.now())
 
@@ -277,7 +284,7 @@ class NotebookTaskType(BaseTaskType):
 
     task_type: str = Field(default="notebook", serialization_alias="command_type")
     command: str
-    notebook_output_path: str = Field(default="", validate_default=True)
+    notebook_output_path: Optional[str] = Field(default=None, validate_default=True)
     optional_ploomber_args: dict = {}
 
     @field_validator("command")
@@ -319,7 +326,7 @@ class NotebookTaskType(BaseTaskType):
             import ploomber_engine as pm
             from ploomber_engine.ipython import PloomberClient
 
-            notebook_output_path = self.notebook_output_path
+            notebook_output_path = self.notebook_output_path or ""
 
             with self.execution_context(
                 map_variable=map_variable, allow_complex=False
@@ -424,15 +431,17 @@ class ShellTaskType(BaseTaskType):
 
         # Expose secrets as environment variables
         if self.secrets:
-            for key, value in self.secrets.items():
+            for key in self.secrets:
                 secret_value = context.run_context.secrets_handler.get(key)
-                subprocess_env[value] = secret_value
+                subprocess_env[key] = secret_value
 
         with self.execution_context(map_variable=map_variable, allow_complex=False) as params:
             subprocess_env.update({k: v.get_value() for k, v in params.items()})
 
             # Json dumps all runnable environment variables
             for key, value in subprocess_env.items():
+                if isinstance(value, str):
+                    continue
                 subprocess_env[key] = json.dumps(value)
 
             collect_delimiter = "=== COLLECT ==="
@@ -441,37 +450,80 @@ class ShellTaskType(BaseTaskType):
             logger.info(f"Executing shell command: {command}")
 
             capture = False
-            return_keys = [x.name for x in self.returns]
+            return_keys = {x.name: x for x in self.returns}
 
-            with subprocess.Popen(
+            proc = subprocess.Popen(
                 command,
                 shell=True,
                 env=subprocess_env,
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE,
                 text=True,
-            ) as proc:
-                for line in proc.stdout:  # type: ignore
-                    logger.info(line)
-                    print(line)
-
-                    if line.strip() == collect_delimiter:
-                        # The lines from now on should be captured
-                        capture = True
-                        continue
-
-                    if capture:
-                        key, value = line.strip().split("=", 1)
-                        if key in (return_keys or []):
-                            param_name = Template(key).safe_substitute(map_variable)  # type: ignore
-                            try:
-                                params[param_name] = JsonParameter(kind="json", value=json.loads(value))
-                            except json.JSONDecodeError:
-                                params[param_name] = JsonParameter(kind="json", value=value)
-
-                proc.wait()
-                if proc.returncode == 0:
-                    attempt_log.status = defaults.SUCCESS
+            )
+            result = proc.communicate()
+            logger.debug(result)
+            logger.info(proc.returncode)
+
+            if proc.returncode != 0:
+                msg = ",".join(result[1].split("\n"))
+                attempt_log.status = defaults.FAIL
+                attempt_log.end_time = str(datetime.now())
+                attempt_log.message = msg
+                console.print(msg, style=defaults.error_style)
+                return attempt_log
+
+            # for stderr
+            for line in result[1].split("\n"):
+                if line.strip() == "":
+                    continue
+                console.print(line, style=defaults.warning_style)
+
+            output_parameters: Dict[str, Parameter] = {}
+            metrics: Dict[str, Parameter] = {}
+
+            # only from stdout
+            for line in result[0].split("\n"):
+                if line.strip() == "":
+                    continue
+
+                logger.info(line)
+                console.print(line)
+
+                if line.strip() == collect_delimiter:
+                    # The lines from now on should be captured
+                    capture = True
+                    continue
+
+                if capture:
+                    key, value = line.strip().split("=", 1)
+                    if key in return_keys:
+                        task_return = return_keys[key]
+
+                        try:
+                            value = json.loads(value)
+                        except json.JSONDecodeError:
+                            value = value
+
+                        output_parameter = task_return_to_parameter(
+                            task_return=task_return,
+                            value=value,
+                        )
+
+                        if task_return.kind == "metric":
+                            metrics[task_return.name] = output_parameter
+
+                        param_name = task_return.name
+                        if map_variable:
+                            for _, v in map_variable.items():
+                                param_name = f"{param_name}_{v}"
+
+                        output_parameters[param_name] = output_parameter
+
+                attempt_log.output_parameters = output_parameters
+                attempt_log.user_defined_metrics = metrics
+                params.update(output_parameters)
+
+            attempt_log.status = defaults.SUCCESS
 
         attempt_log.end_time = str(datetime.now())
         return attempt_log

{runnable-0.11.0.dist-info → runnable-0.11.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: runnable
-Version: 0.11.0
+Version: 0.11.1
 Summary: A Compute agnostic pipelining software
 Home-page: https://github.com/vijayvammi/runnable
 License: Apache-2.0
@@ -15,13 +15,12 @@ Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Provides-Extra: database
 Provides-Extra: docker
-Provides-Extra: mlflow
 Provides-Extra: notebook
 Requires-Dist: click
 Requires-Dist: click-plugins (>=1.1.1,<2.0.0)
 Requires-Dist: dill (>=0.3.8,<0.4.0)
 Requires-Dist: docker ; extra == "docker"
-Requires-Dist: mlflow-skinny ; extra == "mlflow"
+Requires-Dist: mlflow-skinny
 Requires-Dist: ploomber-engine (>=0.0.31,<0.0.32) ; extra == "notebook"
 Requires-Dist: pydantic (>=2.5,<3.0)
 Requires-Dist: rich (>=13.5.2,<14.0.0)

{runnable-0.11.0.dist-info → runnable-0.11.1.dist-info}/RECORD

@@ -1,10 +1,10 @@
-runnable/__init__.py,sha256=BzuufxKGqgYvd-v4fwhH7lgYGCzOnwY7ca5pZZasgx8,720
+runnable/__init__.py,sha256=C5ySSfN_vHWFTscnxLx3tfMjKT3Bs9jfUjXnDvun33Y,870
 runnable/catalog.py,sha256=22OECi5TrpHErxYIhfx-lJ2vgBUi4-5V9CaYEVm98hE,4138
-runnable/cli.py,sha256=gDKk-eg1Vlf0NAWEFqdFEUfcDJdBawRPgSMpNqpbsOc,9590
+runnable/cli.py,sha256=RILUrEfzernuKD3dNdXPBkqN_1OgE5GosYRuInj0FVs,9618
 runnable/context.py,sha256=QhiXJHRcEBfSKB1ijvL5yB9w44x0HCe7VEiwK1cUJ9U,1124
 runnable/datastore.py,sha256=EgKi4_b5g6KbInpjMyw8Xwr-EgcSGi1Lx2u5vp4amSQ,27672
 runnable/defaults.py,sha256=MOX7I2S6yO4FphZaZREFQca94a20oO8uvzXLd6GLKQs,4703
-runnable/entrypoints.py,sha256=-GbwFCUPkLfXpvslD1abXtlfwZevSocqc6QK8TPL40Q,16197
+runnable/entrypoints.py,sha256=a8M7vb954as_ni7lM0t65czXQj2AHjB-KrQJ3zt3sWo,16397
 runnable/exceptions.py,sha256=6NIYoTAzdKyGQ9PvW1Hu7b80OS746395KiGDhM7ThH8,2526
 runnable/executor.py,sha256=xfBighQ5t_vejohip000XfxLwsgechUE1ZMIJWrZbUA,14484
 runnable/extensions/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -14,7 +14,7 @@ runnable/extensions/catalog/file_system/implementation.py,sha256=9j920o9SULdcVp1
 runnable/extensions/catalog/k8s_pvc/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 runnable/extensions/catalog/k8s_pvc/implementation.py,sha256=oJDDI0APT7lrtjWmzYJRDHLGn3Vhbn2MdFSRYvFBUpY,436
 runnable/extensions/catalog/k8s_pvc/integration.py,sha256=OfrHbNFN8sR-wsVa4os3ajmWJFSd5H4KOHGVAmjRZTQ,1850
-runnable/extensions/executor/__init__.py,sha256=FTXtI_etk_eyKRIDpCiTrYfV5yCkfJMl-cuXVDzEqY8,26649
+runnable/extensions/executor/__init__.py,sha256=eV3q_dL2cRqYaJ8RWV6Xk1__KMWMM2hUnQFT7Z5pRso,26698
 runnable/extensions/executor/argo/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 runnable/extensions/executor/argo/implementation.py,sha256=_BfxCe742S6uV-7PuQ53KjzwY-8Rq-5y9txOXMYf20U,43670
 runnable/extensions/executor/argo/specification.yaml,sha256=wXQcm2gOQYqy-IOQIhucohS32ZrHKCfGA5zZ0RraPYc,1276
@@ -55,12 +55,12 @@ runnable/names.py,sha256=vn92Kv9ANROYSZX6Z4z1v_WA3WiEdIYmG6KEStBFZug,8134
 runnable/nodes.py,sha256=UqR-bJx0Hi7uLSUw_saB7VsNdFh3POKtdgsEPsasHfE,16576
 runnable/parameters.py,sha256=KGGW8_uoIK2hd3EwzzBmoHBOrai3fh-SESNPpJRTfj4,5161
 runnable/pickler.py,sha256=5SDNf0miMUJ3ZauhQdzwk8_t-9jeOqaTjP5bvRnu9sU,2685
-runnable/sdk.py,sha256=hx29PEDYjJIWaTZp3ZhyLDwuulG1HIQ2q7A4HVE1WkM,26998
+runnable/sdk.py,sha256=JsM27GUc3c57ZepK996FHtfzXP6FGs8MP-s96RC-_fo,27648
 runnable/secrets.py,sha256=dakb7WRloWVo-KpQp6Vy4rwFdGi58BTlT4OifQY106I,2324
-runnable/tasks.py,sha256=T8vVLo-yWHanrXKHFJvNdjQXKuWmJ13_-lxZzmf1mQM,18908
+runnable/tasks.py,sha256=CH0W7evAZK5hco0medJS6DwHRr06bng7oB7xk0Xh6zQ,20618
 runnable/utils.py,sha256=okZFGbJWqStl5Rq5vLhNUQZDv_vhcT58bq9MDrTVxhc,19449
-runnable-0.11.0.dist-info/LICENSE,sha256=xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ,11357
-runnable-0.11.0.dist-info/METADATA,sha256=M7YR0Y_j7zMnXCKHFWGk4mlWKYZTdkOyZa3M0v3NokI,17063
-runnable-0.11.0.dist-info/WHEEL,sha256=sP946D7jFCHeNz5Iq4fL4Lu-PrWrFsgfLXbbkciIZwg,88
-runnable-0.11.0.dist-info/entry_points.txt,sha256=Wy-dimdD2REO2a36Ri84fqGqA5iwGy2RIbdgRNtCNdM,1540
-runnable-0.11.0.dist-info/RECORD,,
+runnable-0.11.1.dist-info/LICENSE,sha256=xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ,11357
+runnable-0.11.1.dist-info/METADATA,sha256=IKuld8eA9gcb6y7YZaO-3Dpmw2x4U2wnPg0eag1fewU,17020
+runnable-0.11.1.dist-info/WHEEL,sha256=sP946D7jFCHeNz5Iq4fL4Lu-PrWrFsgfLXbbkciIZwg,88
+runnable-0.11.1.dist-info/entry_points.txt,sha256=Wy-dimdD2REO2a36Ri84fqGqA5iwGy2RIbdgRNtCNdM,1540
+runnable-0.11.1.dist-info/RECORD,,