runbooks 0.9.8__py3-none-any.whl → 1.0.0__py3-none-any.whl

runbooks/common/env_utils.py

@@ -0,0 +1,96 @@
+"""
+Environment Variable Utilities - Enterprise Hardcoded Value Elimination
+
+This module provides enterprise-compliant environment variable utilities
+that enforce zero hardcoded defaults policy across the entire codebase.
+"""
+
+import os
+from typing import Union
+
+
+def get_required_env(var_name: str) -> str:
+    """
+    Get required string environment variable - NO hardcoded defaults.
+    
+    Args:
+        var_name: Environment variable name
+        
+    Returns:
+        Environment variable value
+        
+    Raises:
+        ValueError: If environment variable is not set
+    """
+    value = os.getenv(var_name)
+    if value is None:
+        raise ValueError(f"Environment variable {var_name} required - no hardcoded defaults allowed")
+    return value
+
+
+def get_required_env_int(var_name: str) -> int:
+    """
+    Get required integer environment variable - NO hardcoded defaults.
+    
+    Args:
+        var_name: Environment variable name
+        
+    Returns:
+        Environment variable value as integer
+        
+    Raises:
+        ValueError: If environment variable is not set or not a valid integer
+    """
+    value = get_required_env(var_name)
+    try:
+        return int(value)
+    except ValueError as e:
+        raise ValueError(f"Environment variable {var_name} must be a valid integer, got: {value}") from e
+
+
+def get_required_env_float(var_name: str) -> float:
+    """
+    Get required float environment variable - NO hardcoded defaults.
+    
+    Args:
+        var_name: Environment variable name
+        
+    Returns:
+        Environment variable value as float
+        
+    Raises:
+        ValueError: If environment variable is not set or not a valid float
+    """
+    value = get_required_env(var_name)
+    try:
+        return float(value)
+    except ValueError as e:
+        raise ValueError(f"Environment variable {var_name} must be a valid float, got: {value}") from e
+
+
+def get_required_env_bool(var_name: str) -> bool:
+    """
+    Get required boolean environment variable - NO hardcoded defaults.
+    
+    Args:
+        var_name: Environment variable name
+        
+    Returns:
+        Environment variable value as boolean
+        
+    Raises:
+        ValueError: If environment variable is not set
+    """
+    value = get_required_env(var_name).lower()
+    if value in ('true', '1', 'yes', 'on'):
+        return True
+    elif value in ('false', '0', 'no', 'off'):
+        return False
+    else:
+        raise ValueError(f"Environment variable {var_name} must be a valid boolean (true/false), got: {value}")
+
+
+# Legacy compatibility function names for existing code
+_get_required_env_float = get_required_env_float
+_get_required_env_int = get_required_env_int 
+_get_required_env = get_required_env

runbooks/common/mcp_integration.py

@@ -150,6 +150,11 @@ class EnterpriseMCPIntegrator:
         self.validation_threshold = 99.5  # Enterprise accuracy requirement
         self.tolerance_percent = 5.0  # ±5% tolerance for validation
 
+        # Organizations API caching to prevent duplicate calls
+        self._organizations_cache = {}
+        self._organizations_cache_timestamp = None
+        self._cache_ttl_minutes = 30  # 30-minute TTL for Organizations data
+
         # Initialize enterprise profile architecture
         self._initialize_enterprise_profiles()
 
@@ -176,6 +181,27 @@ class EnterpriseMCPIntegrator:
             except Exception as e:
                 print_error(f"Failed to initialize {profile_type} profile: {str(e)}")
 
+    def _is_organizations_cache_valid(self) -> bool:
+        """Check if Organizations cache is still valid."""
+        if not self._organizations_cache_timestamp:
+            return False
+        
+        cache_age_minutes = (datetime.now() - self._organizations_cache_timestamp).total_seconds() / 60
+        return cache_age_minutes < self._cache_ttl_minutes
+
+    def get_cached_organization_accounts(self) -> Optional[List[Dict[str, Any]]]:
+        """Get cached Organizations data if valid."""
+        if self._is_organizations_cache_valid() and 'accounts' in self._organizations_cache:
+            print_info("Using cached Organizations data (performance optimization)")
+            return self._organizations_cache['accounts']
+        return None
+
+    def cache_organization_accounts(self, accounts: List[Dict[str, Any]]) -> None:
+        """Cache Organizations data for performance optimization."""
+        self._organizations_cache = {'accounts': accounts}
+        self._organizations_cache_timestamp = datetime.now()
+        print_success(f"Cached Organizations data: {len(accounts)} accounts (TTL: {self._cache_ttl_minutes}min)")
+
     async def validate_inventory_operations(self, inventory_data: Dict[str, Any]) -> MCPValidationResult:
         """
         Validate inventory operations using MCP integration.
@@ -496,11 +522,32 @@ class EnterpriseMCPIntegrator:
     async def _validate_resource_counts(self, inventory_data: Dict, progress, task) -> None:
         """Validate resource counts across services."""
         try:
-            resources = inventory_data.get("resources", [])
+            # Enhanced: Handle both dict and string inputs for robust data structure handling
+            if isinstance(inventory_data, str):
+                # Handle case where inventory_data is a JSON string
+                try:
+                    inventory_data = json.loads(inventory_data)
+                except json.JSONDecodeError:
+                    print_warning(f"Invalid JSON string in inventory data")
+                    return
+            
+            resources = inventory_data.get("resources", []) if isinstance(inventory_data, dict) else []
+            
+            # Enhanced: Ensure resources is always a list
+            if not isinstance(resources, list):
+                resources = []
+                
             service_counts = {}
 
             for resource in resources:
-                service = resource.get("service", "unknown")
+                # Enhanced: Handle both dict and string resource entries
+                if isinstance(resource, dict):
+                    service = resource.get("service", "unknown")
+                elif isinstance(resource, str):
+                    service = "unknown"
+                else:
+                    service = "unknown"
+                    
                 service_counts[service] = service_counts.get(service, 0) + 1
 
             progress.update(task, advance=40, description=f"Validated {len(resources)} resources...")